*: Collector API cleanup 2 (#1552)

pkg/collector/mscluster_resourcegroup/mscluster_resourcegroup.go

@@ -19,22 +19,20 @@ var ConfigDefaults = Config{}
 type Collector struct {
 	logger log.Logger
 
-	AutoFailbackType    *prometheus.Desc
-	Characteristics     *prometheus.Desc
-	ColdStartSetting    *prometheus.Desc
-	DefaultOwner        *prometheus.Desc
-	FailbackWindowEnd   *prometheus.Desc
-	FailbackWindowStart *prometheus.Desc
-	FailoverPeriod      *prometheus.Desc
-	FailoverThreshold   *prometheus.Desc
-	FaultDomain         *prometheus.Desc
-	Flags               *prometheus.Desc
-	GroupType           *prometheus.Desc
-	PlacementOptions    *prometheus.Desc
-	OwnerNode           *prometheus.Desc
-	Priority            *prometheus.Desc
-	ResiliencyPeriod    *prometheus.Desc
-	State               *prometheus.Desc
+	autoFailbackType    *prometheus.Desc
+	characteristics     *prometheus.Desc
+	coldStartSetting    *prometheus.Desc
+	defaultOwner        *prometheus.Desc
+	failbackWindowEnd   *prometheus.Desc
+	failbackWindowStart *prometheus.Desc
+	failOverPeriod      *prometheus.Desc
+	failOverThreshold   *prometheus.Desc
+	flags               *prometheus.Desc
+	groupType           *prometheus.Desc
+	ownerNode           *prometheus.Desc
+	priority            *prometheus.Desc
+	resiliencyPeriod    *prometheus.Desc
+	state               *prometheus.Desc
 }
 
 func New(logger log.Logger, _ *Config) *Collector {
@@ -65,91 +63,91 @@ func (c *Collector) Close() error {
 }
 
 func (c *Collector) Build() error {
-	c.AutoFailbackType = prometheus.NewDesc(
+	c.autoFailbackType = prometheus.NewDesc(
 		prometheus.BuildFQName(types.Namespace, Name, "auto_failback_type"),
 		"Provides access to the group's AutoFailbackType property.",
 		[]string{"name"},
 		nil,
 	)
-	c.Characteristics = prometheus.NewDesc(
+	c.characteristics = prometheus.NewDesc(
 		prometheus.BuildFQName(types.Namespace, Name, "characteristics"),
 		"Provides the characteristics of the group.",
 		[]string{"name"},
 		nil,
 	)
-	c.ColdStartSetting = prometheus.NewDesc(
+	c.coldStartSetting = prometheus.NewDesc(
 		prometheus.BuildFQName(types.Namespace, Name, "cold_start_setting"),
 		"Indicates whether a group can start after a cluster cold start.",
 		[]string{"name"},
 		nil,
 	)
-	c.DefaultOwner = prometheus.NewDesc(
+	c.defaultOwner = prometheus.NewDesc(
 		prometheus.BuildFQName(types.Namespace, Name, "default_owner"),
 		"Number of the last node the resource group was activated on or explicitly moved to.",
 		[]string{"name"},
 		nil,
 	)
-	c.FailbackWindowEnd = prometheus.NewDesc(
+	c.failbackWindowEnd = prometheus.NewDesc(
 		prometheus.BuildFQName(types.Namespace, Name, "failback_window_end"),
 		"The FailbackWindowEnd property provides the latest time that the group can be moved back to the node identified as its preferred node.",
 		[]string{"name"},
 		nil,
 	)
-	c.FailbackWindowStart = prometheus.NewDesc(
+	c.failbackWindowStart = prometheus.NewDesc(
 		prometheus.BuildFQName(types.Namespace, Name, "failback_window_start"),
 		"The FailbackWindowStart property provides the earliest time (that is, local time as kept by the cluster) that the group can be moved back to the node identified as its preferred node.",
 		[]string{"name"},
 		nil,
 	)
-	c.FailoverPeriod = prometheus.NewDesc(
+	c.failOverPeriod = prometheus.NewDesc(
 		prometheus.BuildFQName(types.Namespace, Name, "failover_period"),
 		"The FailoverPeriod property specifies a number of hours during which a maximum number of failover attempts, specified by the FailoverThreshold property, can occur.",
 		[]string{"name"},
 		nil,
 	)
-	c.FailoverThreshold = prometheus.NewDesc(
+	c.failOverThreshold = prometheus.NewDesc(
 		prometheus.BuildFQName(types.Namespace, Name, "failover_threshold"),
 		"The FailoverThreshold property specifies the maximum number of failover attempts.",
 		[]string{"name"},
 		nil,
 	)
-	c.Flags = prometheus.NewDesc(
+	c.flags = prometheus.NewDesc(
 		prometheus.BuildFQName(types.Namespace, Name, "flags"),
 		"Provides access to the flags set for the group. ",
 		[]string{"name"},
 		nil,
 	)
-	c.GroupType = prometheus.NewDesc(
+	c.groupType = prometheus.NewDesc(
 		prometheus.BuildFQName(types.Namespace, Name, "group_type"),
 		"The Type of the resource group.",
 		[]string{"name"},
 		nil,
 	)
-	c.OwnerNode = prometheus.NewDesc(
+	c.ownerNode = prometheus.NewDesc(
 		prometheus.BuildFQName(types.Namespace, Name, "owner_node"),
 		"The node hosting the resource group. 0: Not hosted; 1: Hosted",
 		[]string{"node_name", "name"},
 		nil,
 	)
-	c.OwnerNode = prometheus.NewDesc(
+	c.ownerNode = prometheus.NewDesc(
 		prometheus.BuildFQName(types.Namespace, Name, "owner_node"),
 		"The node hosting the resource group. 0: Not hosted; 1: Hosted",
 		[]string{"node_name", "name"},
 		nil,
 	)
-	c.Priority = prometheus.NewDesc(
+	c.priority = prometheus.NewDesc(
 		prometheus.BuildFQName(types.Namespace, Name, "priority"),
 		"Priority value of the resource group",
 		[]string{"name"},
 		nil,
 	)
-	c.ResiliencyPeriod = prometheus.NewDesc(
+	c.resiliencyPeriod = prometheus.NewDesc(
 		prometheus.BuildFQName(types.Namespace, Name, "resiliency_period"),
 		"The resiliency period for this group, in seconds.",
 		[]string{"name"},
 		nil,
 	)
-	c.State = prometheus.NewDesc(
+	c.state = prometheus.NewDesc(
 		prometheus.BuildFQName(types.Namespace, Name, "state"),
 		"The current state of the resource group. -1: Unknown; 0: Online; 1: Offline; 2: Failed; 3: Partial Online; 4: Pending",
 		[]string{"name"},
@@ -190,70 +188,70 @@ func (c *Collector) Collect(_ *types.ScrapeContext, ch chan<- prometheus.Metric)
 
 	for _, v := range dst {
 		ch <- prometheus.MustNewConstMetric(
-			c.AutoFailbackType,
+			c.autoFailbackType,
 			prometheus.GaugeValue,
 			float64(v.AutoFailbackType),
 			v.Name,
 		)
 
 		ch <- prometheus.MustNewConstMetric(
-			c.Characteristics,
+			c.characteristics,
 			prometheus.GaugeValue,
 			float64(v.Characteristics),
 			v.Name,
 		)
 
 		ch <- prometheus.MustNewConstMetric(
-			c.ColdStartSetting,
+			c.coldStartSetting,
 			prometheus.GaugeValue,
 			float64(v.ColdStartSetting),
 			v.Name,
 		)
 
 		ch <- prometheus.MustNewConstMetric(
-			c.DefaultOwner,
+			c.defaultOwner,
 			prometheus.GaugeValue,
 			float64(v.DefaultOwner),
 			v.Name,
 		)
 
 		ch <- prometheus.MustNewConstMetric(
-			c.FailbackWindowEnd,
+			c.failbackWindowEnd,
 			prometheus.GaugeValue,
 			float64(v.FailbackWindowEnd),
 			v.Name,
 		)
 
 		ch <- prometheus.MustNewConstMetric(
-			c.FailbackWindowStart,
+			c.failbackWindowStart,
 			prometheus.GaugeValue,
 			float64(v.FailbackWindowStart),
 			v.Name,
 		)
 
 		ch <- prometheus.MustNewConstMetric(
-			c.FailoverPeriod,
+			c.failOverPeriod,
 			prometheus.GaugeValue,
 			float64(v.FailoverPeriod),
 			v.Name,
 		)
 
 		ch <- prometheus.MustNewConstMetric(
-			c.FailoverThreshold,
+			c.failOverThreshold,
 			prometheus.GaugeValue,
 			float64(v.FailoverThreshold),
 			v.Name,
 		)
 
 		ch <- prometheus.MustNewConstMetric(
-			c.Flags,
+			c.flags,
 			prometheus.GaugeValue,
 			float64(v.Flags),
 			v.Name,
 		)
 
 		ch <- prometheus.MustNewConstMetric(
-			c.GroupType,
+			c.groupType,
 			prometheus.GaugeValue,
 			float64(v.GroupType),
 			v.Name,
@@ -266,7 +264,7 @@ func (c *Collector) Collect(_ *types.ScrapeContext, ch chan<- prometheus.Metric)
 					isCurrentState = 1.0
 				}
 				ch <- prometheus.MustNewConstMetric(
-					c.OwnerNode,
+					c.ownerNode,
 					prometheus.GaugeValue,
 					isCurrentState,
 					node_name, v.Name,
@@ -275,21 +273,21 @@ func (c *Collector) Collect(_ *types.ScrapeContext, ch chan<- prometheus.Metric)
 		}
 
 		ch <- prometheus.MustNewConstMetric(
-			c.Priority,
+			c.priority,
 			prometheus.GaugeValue,
 			float64(v.Priority),
 			v.Name,
 		)
 
 		ch <- prometheus.MustNewConstMetric(
-			c.ResiliencyPeriod,
+			c.resiliencyPeriod,
 			prometheus.GaugeValue,
 			float64(v.ResiliencyPeriod),
 			v.Name,
 		)
 
 		ch <- prometheus.MustNewConstMetric(
-			c.State,
+			c.state,
 			prometheus.GaugeValue,
 			float64(v.State),
 			v.Name,