Files
pocket-id/CONTRIBUTING.md
T

5.6 KiB

Contributing

We are happy that you want to contribute to Pocket ID and help to make it better!

Before you start

Before starting to work on a new feature, please open an issue first, or comment on an existing one, to discuss the implementation details. This saves you time and avoids the disappointment of having a PR closed later because the change doesn't fit the project's direction.

AI Usage Policy

We have nothing against using AI tools to assist your development. However, AI must not replace the human contribution behind a new feature. Simply copying a feature request into an AI tool, generating code, and submitting the result as a pull request is not accepted. Maintainers can already do that themselves, so this workflow provides no meaningful advantage to the project.

This restriction applies to new features, not bug fixes. For feature contributions, we expect meaningful human involvement such as thoughtfully prompting and iterating, making implementation decisions and reviewing and reflecting the output.

Guidelines for Using AI Tools

To keep contributions reviewable and high-quality, please follow these guidelines when using AI tools:

  1. Do not submit prompt-only feature implementations. A new feature must include meaningful human input beyond passing the feature request to an AI tool and submitting its output. This restriction does not apply to bug fixes.
  2. Understand every line. You must be able to explain what your code does and why, in your own words. "The AI wrote it" is not an acceptable answer to a reviewer's question.
  3. Test before submitting. Review and test all code manually, as a human, before opening a PR. Don't trust the AI's claim that it works.
  4. Write your own words. Don't paste AI-generated text into issues, comments, or PR descriptions. Walls of generated text make discussions harder, not easier.

Feature PRs that appear to be low-effort AI output may be closed without a detailed review.

Getting started

Submit a Pull Request

Before you submit the pull request for review please ensure that

  • The pull request naming follows the Conventional Commits specification:

    <type>[optional scope]: <description>

    example:

    fix: hide global audit log switch for non admin users
    

    Where TYPE can be:

    • feat - is a new feature
    • doc - documentation only changes
    • fix - a bug fix
    • refactor - code change that neither fixes a bug nor adds a feature
  • Your pull request has a detailed description

  • You run pnpm format to format the code

Development Environment

Pocket ID consists of a frontend and backend. In production the frontend gets statically served by the backend, but in development they run as separate processes to enable hot reloading.

There are two ways to get the development environment setup:

1. Install required tools

With Dev Containers

If you use Dev Containers in VS Code, you don't need to install anything manually, just follow the steps below.

  1. Make sure you have Dev Containers extension installed
  2. Clone and open the repo in VS Code
  3. VS Code will detect .devcontainer and will prompt you to open the folder in devcontainer
  4. If the auto prompt does not work, hit F1 and select Dev Containers: Open Folder in Container., then select the pocket-id repo root folder and it'll open in container.
Without Dev Containers

If you don't use Dev Containers, you need to install the following tools manually:

2. Setup

Backend

The backend is built with Gin and written in Go. To set it up, follow these steps:

  1. Open the backend folder
  2. Copy the .env.development-example file to .env and edit the variables as needed
  3. Start the backend with go run -tags exclude_frontend ./cmd
Frontend

The frontend is built with SvelteKit and written in TypeScript. To set it up, follow these steps:

  1. Open the pocket-id project folder
  2. Copy the frontend/.env.development-example file to frontend/.env and edit the variables as needed
  3. Install the dependencies with pnpm install
  4. Start the frontend with pnpm dev

You're all set! The application is now listening on localhost:3000. The backend gets proxied trough the frontend in development mode.

Testing

If you are contributing to a new feature please ensure that you add tests for it.

End-to-end tests

We are using Playwright for end-to-end testing.

The tests are located in the tests folder at the root of the project.

The tests can be run like this:

  1. Install the dependencies from the root of the project pnpm install

  2. Visit the setup folder by running cd tests/setup

  3. Start the test environment by running docker compose up -d --build

  4. Go back to the test folder by running cd ..

  5. Run the tests with pnpm dlx playwright test or from the root project folder pnpm test

If you make any changes to the application, you have to rebuild the test environment by running docker compose up -d --build again.

Unit tests

In the backend we are using unit tests with the built-in Go testing framework. The tests are located in the same folder as the code they are testing and have the _test.go suffix.

To run the tests, simply run go test -tags=exclude_frontend,unit ./... from the root of the backend folder.