mirror of
https://github.com/netbirdio/netbird.git
synced 2026-07-17 20:19:55 +00:00
* [client] categorize root/system-mutating tests behind a privileged build tag Tests that need root or mutate host state (nftables/iptables/DNS, TUN/WireGuard interfaces, routes, eBPF, SSH/service install) are now gated behind a //go:build privileged tag. The default `go test ./client/...` runs as a non-root user with no sudo and leaves host networking untouched; mixed files were split so pure-logic tests stay in the default suite. A self-hosting ory/dockertest/v4 harness (client/testutil/privileged) runs the privileged suite inside a --privileged --cap-add=NET_ADMIN container via `make test-privileged`; a DOCKER_CI=true guard skips the spawn when already inside the container. Added `make test-unit` for the host-safe run. * [client] add PRIV_RUN/PRIV_PKGS filters to the privileged test harness The dockertest harness now reads two optional env vars when building the in-container `go test` command: PRIV_RUN adds a -run test-name filter and PRIV_PKGS overrides the package list. Both empty reproduce the full privileged suite, so CI and `make test-privileged` behave as before. Lets a developer run a single privileged test in the container, e.g.: PRIV_RUN=TestNftablesManager PRIV_PKGS=./client/firewall/nftables/... make test-privileged * [client] fix unused-helper lint after the privileged test split Splitting privileged tests into *_privileged_test.go left their shared helpers in the untagged files, so in the default (no-tag) build they had no callers and golangci-lint flagged them as unused. Moved the privileged-only helpers into the privileged files next to their callers (generateDummyHandler; createEngine/startSignal/startManagement/getConnectedPeers/ getPeers + kaep/kasp; (*mockDaemon).setJWTToken). Annotated the shared routing-test fixtures that must stay untagged for cross-platform compilation with //nolint:unused (systemops_bsd expected* vars, ensureIPv6DefaultRoute on bsd/windows, loopbackIfaceWindows), matching the existing linux variant. * [client] fix privileged test CI failures and run the harness on macOS The host-safe unit run dropped sudo but two privileged test groups were never tagged, and the Docker privileged job silently never ran the suite: - Gate the ssh/server PrivilegeDropper command-construction tests behind the privileged tag (they require root to target a different UID); split them into executor_unix_privileged_test.go. - Tag sharedsock raw-socket tests privileged (need CAP_NET_RAW). - Fix the Docker job command: nested single quotes around the build tags closed the sh -c wrapper early, dropping the go list package set and the privileged tag, so go test ran on the empty repo root. Use double quotes. Make the self-hosting harness usable from a dev Mac: - Build it on darwin as well as linux; it only drives Docker. - Resolve the active docker context endpoint into DOCKER_HOST when the default /var/run/docker.sock is absent (Docker Desktop, Colima, OrbStack). - Rename the misspelled containerGoModache constant to containerGoModCache. * Update client/internal/engine_privileged_test.go Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update client/internal/routemanager/systemops/systemops_linux_test.go Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update client/internal/routemanager/systemops/systemops_windows_test.go Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update client/server/server_privileged_test.go Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * [ci] Run privileged-tagged tests on darwin, windows and freebsd The privileged build tag split moved root/system-mutating tests behind //go:build privileged, but only the linux docker job was given the tag. The native darwin (sudo), windows (PsExec64 -s) and freebsd VM runners already have the required privileges, so add the privileged tag there too to keep CI running the same set of tests as before the split. * [ci] Exclude dockertest harness from the darwin privileged run The privileged tag now compiles client/testutil/privileged on darwin, whose TestRunPrivilegedSuiteInDocker spawns a container the macOS runner has no Docker for. Exclude the harness package from the darwin list, matching the linux job, so the privileged tests run in place without a container spawn. --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
143 lines
3.5 KiB
Go
143 lines
3.5 KiB
Go
//go:build linux && !android && privileged
|
|
|
|
package systemops
|
|
|
|
import (
|
|
"errors"
|
|
"net"
|
|
"syscall"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
"github.com/vishvananda/netlink"
|
|
|
|
"github.com/netbirdio/netbird/client/internal/routemanager/vars"
|
|
)
|
|
|
|
func init() {
|
|
testCases = append(testCases, []testCase{
|
|
{
|
|
name: "To more specific route without custom dialer via physical interface",
|
|
expectedInterface: expectedInternalInt,
|
|
dialer: &net.Dialer{},
|
|
expectedPacket: createPacketExpectation("192.168.1.1", 12345, "10.10.0.2", 53),
|
|
},
|
|
}...)
|
|
}
|
|
|
|
func createAndSetupDummyInterface(t *testing.T, interfaceName, ipAddressCIDR string) string {
|
|
t.Helper()
|
|
|
|
dummy := &netlink.Dummy{LinkAttrs: netlink.LinkAttrs{Name: interfaceName}}
|
|
err := netlink.LinkDel(dummy)
|
|
if err != nil && !errors.Is(err, syscall.EINVAL) {
|
|
t.Logf("Failed to delete dummy interface: %v", err)
|
|
}
|
|
|
|
err = netlink.LinkAdd(dummy)
|
|
require.NoError(t, err)
|
|
|
|
err = netlink.LinkSetUp(dummy)
|
|
require.NoError(t, err)
|
|
|
|
if ipAddressCIDR != "" {
|
|
addr, err := netlink.ParseAddr(ipAddressCIDR)
|
|
require.NoError(t, err)
|
|
err = netlink.AddrAdd(dummy, addr)
|
|
require.NoError(t, err)
|
|
}
|
|
|
|
t.Cleanup(func() {
|
|
err := netlink.LinkDel(dummy)
|
|
assert.NoError(t, err)
|
|
})
|
|
|
|
return dummy.Name
|
|
}
|
|
|
|
func addDummyRoute(t *testing.T, dstCIDR string, gw net.IP, intf string) {
|
|
t.Helper()
|
|
|
|
_, dstIPNet, err := net.ParseCIDR(dstCIDR)
|
|
require.NoError(t, err)
|
|
|
|
link, err := netlink.LinkByName(intf)
|
|
require.NoError(t, err)
|
|
linkIndex := link.Attrs().Index
|
|
|
|
route := &netlink.Route{
|
|
Dst: dstIPNet,
|
|
Gw: gw,
|
|
LinkIndex: linkIndex,
|
|
}
|
|
|
|
// Handle existing routes with metric 0
|
|
var originalNexthop net.IP
|
|
var originalLinkIndex int
|
|
if dstIPNet.String() == "0.0.0.0/0" {
|
|
var err error
|
|
originalNexthop, originalLinkIndex, err = fetchOriginalGateway(netlink.FAMILY_V4)
|
|
if err != nil && !errors.Is(err, vars.ErrRouteNotFound) {
|
|
t.Logf("Failed to fetch original gateway: %v", err)
|
|
}
|
|
|
|
if originalNexthop != nil {
|
|
// remove original route
|
|
err = netlink.RouteDel(&netlink.Route{Dst: dstIPNet, Priority: 0})
|
|
assert.NoError(t, err)
|
|
|
|
// add new route
|
|
assert.NoError(t, netlink.RouteAdd(route))
|
|
|
|
t.Cleanup(func() {
|
|
// restore original route
|
|
assert.NoError(t, netlink.RouteDel(route))
|
|
err := netlink.RouteAdd(&netlink.Route{Dst: dstIPNet, Gw: originalNexthop, LinkIndex: originalLinkIndex, Priority: 0})
|
|
assert.NoError(t, err)
|
|
})
|
|
|
|
return
|
|
}
|
|
}
|
|
|
|
err = netlink.RouteDel(route)
|
|
if err != nil && !errors.Is(err, syscall.ESRCH) {
|
|
t.Logf("Failed to delete route: %v", err)
|
|
}
|
|
|
|
err = netlink.RouteAdd(route)
|
|
if err != nil && !errors.Is(err, syscall.EEXIST) {
|
|
t.Fatalf("Failed to add route: %v", err)
|
|
}
|
|
}
|
|
|
|
func fetchOriginalGateway(family int) (net.IP, int, error) {
|
|
routes, err := netlink.RouteList(nil, family)
|
|
if err != nil {
|
|
return nil, 0, err
|
|
}
|
|
|
|
for _, route := range routes {
|
|
ones := -1
|
|
if route.Dst != nil {
|
|
ones, _ = route.Dst.Mask.Size()
|
|
}
|
|
if route.Dst == nil || ones == 0 && route.Priority == 0 {
|
|
return route.Gw, route.LinkIndex, nil
|
|
}
|
|
}
|
|
|
|
return nil, 0, vars.ErrRouteNotFound
|
|
}
|
|
|
|
func setupDummyInterfacesAndRoutes(t *testing.T) {
|
|
t.Helper()
|
|
|
|
defaultDummy := createAndSetupDummyInterface(t, "dummyext0", "192.168.0.1/24")
|
|
addDummyRoute(t, "0.0.0.0/0", net.IPv4(192, 168, 0, 1), defaultDummy)
|
|
|
|
otherDummy := createAndSetupDummyInterface(t, "dummyint0", "192.168.1.1/24")
|
|
addDummyRoute(t, "10.0.0.0/8", net.IPv4(192, 168, 1, 1), otherDummy)
|
|
}
|