Zoltán Papp 98c71d7913 [client] fix Start/Stop race by making the run loop own engine shutdown ...

ConnectClient.Stop stopped the engine directly while the run loop's
backoff cycle could still be starting an engine, so Engine.close raced
Engine.Start (e.g. firewall setup reading wgInterface while close nils
it). embed.Client.Start's rollback only avoided a deadlock by cancelling
before Stop; the race itself remained and was caught by -race.

Make the run loop the sole owner of engine shutdown: derive the run
context in NewConnectClient, and have Stop cancel it and wait for the
loop to exit (skipping the wait when the loop never ran) instead of
calling engine.Stop. The loop now always stops the engine on its way
out, dropping the unsynchronised wgInterface check it used to guard that
call. Self-calls from within the loop use runCancel to avoid waiting on
themselves.

embed keeps a defensive pre-Stop cancel(); the daemon's cleanupConnection
gets a TODO to adopt Stop() rather than stopping the engine in parallel.

2026-06-16 13:57:41 +02:00

..

capture.go

[client, proxy] Add packet capture to debug bundle and CLI (#5891)

2026-05-04 11:28:56 +02:00

doc.go

[client] Add embeddable library (#3239)

2025-02-20 13:22:03 +01:00

embed_test.go

[client, proxy] cancel context before stopping engine on embedded client (#6397)

2026-06-10 21:26:54 +02:00

embed.go

[client] fix Start/Stop race by making the run loop own engine shutdown

2026-06-16 13:57:41 +02:00

expose.go

[client] Add Expose support to embed library (#5695)

2026-03-30 15:53:50 +02:00