mirror of
https://github.com/netbirdio/netbird.git
synced 2026-09-15 19:29:08 +02:00
Management / Unit (amd64, mysql) hit the 20 minute go test budget on #7516. The package was not hung: each of the 133 test store creations in management/server paid about 1.6s on MySQL for CREATE DATABASE, the pre-migrations, a 40-table AutoMigrate and the post-migrations, which puts the package at 10 minutes on a healthy runner and over the budget on a slow one. The migration now runs once per test binary into a template database and each test database is cloned from it, with CREATE DATABASE ... TEMPLATE on Postgres and a replay of SHOW CREATE TABLE on MySQL. The MySQL test container also drops the binary log, doublewrite buffer and per-commit redo fsync. Two goroutine leaks in the test helpers are fixed. tools/gotestsummary turns the go test -json stream into a readable log, and the Management unit and integration jobs now pipe through it, so a timeout names the tests still running. On MySQL, management/server went from 10m16s to 6m36s.
155 lines
4.3 KiB
Go
155 lines
4.3 KiB
Go
//go:build !ios
|
|
|
|
package testutil
|
|
|
|
import (
|
|
"context"
|
|
"time"
|
|
|
|
log "github.com/sirupsen/logrus"
|
|
"github.com/testcontainers/testcontainers-go"
|
|
"github.com/testcontainers/testcontainers-go/modules/mysql"
|
|
"github.com/testcontainers/testcontainers-go/modules/postgres"
|
|
testcontainersredis "github.com/testcontainers/testcontainers-go/modules/redis"
|
|
"github.com/testcontainers/testcontainers-go/wait"
|
|
)
|
|
|
|
var (
|
|
pgContainer *postgres.PostgresContainer
|
|
mysqlContainer *mysql.MySQLContainer
|
|
)
|
|
|
|
// CreateMysqlTestContainer creates a new MySQL container for testing.
|
|
func CreateMysqlTestContainer() (func(), string, error) {
|
|
ctx := context.Background()
|
|
|
|
if mysqlContainer != nil {
|
|
connStr, err := mysqlContainer.ConnectionString(ctx)
|
|
if err != nil {
|
|
return nil, "", err
|
|
}
|
|
return noOpCleanup, connStr, nil
|
|
}
|
|
|
|
var err error
|
|
mysqlContainer, err = mysql.Run(ctx,
|
|
"mlsmaycon/warmed-mysql:8",
|
|
mysql.WithDatabase("testing"),
|
|
mysql.WithUsername("root"),
|
|
mysql.WithPassword("testing"),
|
|
// Every test creates and drops a database with about 40 tables, so with
|
|
// the server defaults the run is dominated by durability work: each
|
|
// CREATE TABLE fsyncs the redo log, the binary log and the doublewrite
|
|
// buffer. None of it protects anything in a container that is discarded
|
|
// after the run. Tables stay in per-table files on purpose: in the shared
|
|
// system tablespace the cost of every CREATE and DROP grew with the number
|
|
// of databases the run had already created.
|
|
testcontainers.WithCmd("mysqld",
|
|
"--innodb-flush-log-at-trx-commit=0",
|
|
"--innodb-doublewrite=OFF",
|
|
"--skip-log-bin",
|
|
),
|
|
testcontainers.WithWaitStrategy(
|
|
wait.ForLog("/usr/sbin/mysqld: ready for connections").
|
|
WithOccurrence(1).WithStartupTimeout(15*time.Second).WithPollInterval(100*time.Millisecond),
|
|
),
|
|
)
|
|
if err != nil {
|
|
return nil, "", err
|
|
}
|
|
|
|
cleanup := func() {
|
|
if mysqlContainer != nil {
|
|
timeoutCtx, cancelFunc := context.WithTimeout(ctx, 1*time.Second)
|
|
defer cancelFunc()
|
|
if err = mysqlContainer.Terminate(timeoutCtx); err != nil {
|
|
log.WithContext(ctx).Warnf("failed to stop mysql container %s: %s", mysqlContainer.GetContainerID(), err)
|
|
}
|
|
mysqlContainer = nil // reset the container to allow recreation
|
|
}
|
|
}
|
|
|
|
talksConn, err := mysqlContainer.ConnectionString(ctx)
|
|
if err != nil {
|
|
return nil, "", err
|
|
}
|
|
|
|
return cleanup, talksConn, nil
|
|
}
|
|
|
|
// CreatePostgresTestContainer creates a new PostgreSQL container for testing.
|
|
func CreatePostgresTestContainer() (func(), string, error) {
|
|
ctx := context.Background()
|
|
|
|
if pgContainer != nil {
|
|
connStr, err := pgContainer.ConnectionString(ctx)
|
|
if err != nil {
|
|
return nil, "", err
|
|
}
|
|
return noOpCleanup, connStr, nil
|
|
}
|
|
|
|
var err error
|
|
pgContainer, err = postgres.Run(ctx,
|
|
"postgres:16-alpine",
|
|
postgres.WithDatabase("netbird"),
|
|
postgres.WithUsername("root"),
|
|
postgres.WithPassword("netbird"),
|
|
testcontainers.WithWaitStrategy(
|
|
wait.ForLog("database system is ready to accept connections").
|
|
WithOccurrence(2).WithStartupTimeout(15*time.Second),
|
|
),
|
|
)
|
|
if err != nil {
|
|
return nil, "", err
|
|
}
|
|
|
|
cleanup := func() {
|
|
if pgContainer != nil {
|
|
timeoutCtx, cancelFunc := context.WithTimeout(ctx, 1*time.Second)
|
|
defer cancelFunc()
|
|
if err = pgContainer.Terminate(timeoutCtx); err != nil {
|
|
log.WithContext(ctx).Warnf("failed to stop postgres container %s: %s", pgContainer.GetContainerID(), err)
|
|
}
|
|
pgContainer = nil // reset the container to allow recreation
|
|
}
|
|
|
|
}
|
|
|
|
talksConn, err := pgContainer.ConnectionString(ctx)
|
|
if err != nil {
|
|
return nil, "", err
|
|
}
|
|
|
|
return cleanup, talksConn, nil
|
|
}
|
|
|
|
func noOpCleanup() {
|
|
// no-op
|
|
}
|
|
|
|
// CreateRedisTestContainer creates a new Redis container for testing.
|
|
func CreateRedisTestContainer() (func(), string, error) {
|
|
ctx := context.Background()
|
|
|
|
redisContainer, err := testcontainersredis.Run(ctx, "redis:7")
|
|
if err != nil {
|
|
return nil, "", err
|
|
}
|
|
|
|
cleanup := func() {
|
|
timeoutCtx, cancelFunc := context.WithTimeout(ctx, 1*time.Second)
|
|
defer cancelFunc()
|
|
if err = redisContainer.Terminate(timeoutCtx); err != nil {
|
|
log.WithContext(ctx).Warnf("failed to stop redis container %s: %s", redisContainer.GetContainerID(), err)
|
|
}
|
|
}
|
|
|
|
redisURL, err := redisContainer.ConnectionString(ctx)
|
|
if err != nil {
|
|
return nil, "", err
|
|
}
|
|
|
|
return cleanup, redisURL, nil
|
|
}
|