mirror of
https://github.com/netbirdio/netbird.git
synced 2026-09-15 19:29:08 +02:00
mlsmaycon
e0ede59d68
A service reads LocalMachine\MY, where AD and Intune enrol device certificates. CurrentUser\MY lives in the signed-in user's registry hive with keys protected against their profile, and a service that opens it does not fail: "current user" resolves to HKU\S-1-5-18, so it silently reads the service account's own empty store. The service therefore reads the machine store itself and launches "netbird posture cert-proof" with the session token for the rest, mirroring the macOS console user helper. Windows lets a privileged service assume a user identity, so the token goes straight into the child process and no external tooling is involved. CREATE_NO_WINDOW keeps a console window from flashing on the desktop every sync. In-process impersonation would also work but is per OS thread while goroutines migrate, so the child process avoids that class of bug. Session selection prefers the physical console and falls back to any active session, so remote desktop and VDI hosts are covered. WTSQueryUserToken needs SE_TCB_NAME, so a user-run client skips the helper and reads the machine store alone. SystemStore takes a store location, gaining NewUserStore alongside NewSystemStore and the per candidate logging macOS already had. The request building and proof merging move to helper_spawn.go, shared by both platforms, and helperStore picks what the helper reads per platform.
57 lines
2.2 KiB
Go
57 lines
2.2 KiB
Go
//go:build darwin || windows
|
|
|
|
package certproof
|
|
|
|
import (
|
|
"crypto/sha256"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/netbirdio/netbird/shared/management/certposture"
|
|
"github.com/netbirdio/netbird/shared/management/certposture/certtest"
|
|
"github.com/netbirdio/netbird/shared/management/proto"
|
|
)
|
|
|
|
func TestMergeProofs_ProvesACertificateHeldByBothStoresOnce(t *testing.T) {
|
|
ca := certtest.NewCA(t, "corp-root")
|
|
shared := ca.Issue(t, certtest.ECDSAKey(t), "shared")
|
|
userOnly := ca.Issue(t, certtest.ECDSAKey(t), "user-only")
|
|
|
|
device := []certposture.Proof{{Chain: [][]byte{shared.Raw}}}
|
|
user := []certposture.Proof{{Chain: [][]byte{shared.Raw}}, {Chain: [][]byte{userOnly.Raw}}, {}}
|
|
|
|
merged := mergeProofs(device, user)
|
|
|
|
require.Len(t, merged, 2, "the shared leaf is proven once and the empty chain is dropped")
|
|
assert.Equal(t, shared.Raw, merged[0].Chain[0], "the device proof keeps its place")
|
|
assert.Equal(t, userOnly.Raw, merged[1].Chain[0], "the user-only certificate is appended")
|
|
}
|
|
|
|
func TestMergeProofs_KeepsDeviceProofsWhenNoUserSession(t *testing.T) {
|
|
ca := certtest.NewCA(t, "corp-root")
|
|
device := []certposture.Proof{{Chain: [][]byte{ca.Issue(t, certtest.ECDSAKey(t), "device").Raw}}}
|
|
|
|
merged := mergeProofs(device, nil)
|
|
|
|
require.Len(t, merged, 1, "a machine with nobody signed in still sends its device proof")
|
|
assert.Equal(t, sha256.Sum256(device[0].Chain[0]), sha256.Sum256(merged[0].Chain[0]), "the device proof is unchanged")
|
|
}
|
|
|
|
func TestHelperRequest_CarriesEveryChallenge(t *testing.T) {
|
|
ca := certtest.NewCA(t, "corp-root")
|
|
challenges := []*proto.CertificateChallenge{
|
|
{Nonce: []byte("first"), CaCertificates: []string{ca.PEM}},
|
|
{Nonce: []byte("second")},
|
|
}
|
|
|
|
req := helperRequest(challenges, peerKey)
|
|
|
|
require.Len(t, req.Challenges, 2, "every challenge must reach the helper")
|
|
assert.Equal(t, peerKey, req.PeerKey, "the peer key binds the signature to this machine")
|
|
assert.Equal(t, []byte("first"), req.Challenges[0].Nonce, "the nonce must survive unchanged")
|
|
assert.Equal(t, []string{ca.PEM}, req.Challenges[0].CACertificates, "the accepted CAs must survive unchanged")
|
|
assert.Empty(t, req.Challenges[1].CACertificates, "a challenge without CAs stays without CAs")
|
|
}
|