mirror of
https://github.com/netbirdio/netbird.git
synced 2026-09-28 01:29:05 +02:00
Zoltán PappandClaude Opus 5
d2eeb0a1f4
Route every mode transition through one locked helper so the staged managed version cannot outlive the decision that created it. Both download-only transitions kept pendingVersion, letting Install put on the old enforced release after management disabled updates or the platform fell back to download-only. The helper also bumps a generation counter. handleUpdate and NotifyUI copy the mode under the mutex but publish and install after releasing it, so a reset landing in that window could still emit an enforced notification. Both now recheck the generation right before the side effect and drop the stale work. Reset on every connection attempt instead of once per run: the backoff loop reconnects without re-entering run, and since disconnects no longer force download-only, a fetch in the disconnected gap republished the enforced notification before the new network map arrived. A missing AutoUpdateSettings now logs that it defaults to download-only rather than claiming auto-update is disabled, which contradicted the notifications that mode still emits. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
118 lines
3.7 KiB
Go
118 lines
3.7 KiB
Go
package updater
|
|
|
|
import (
|
|
"context"
|
|
"path"
|
|
"testing"
|
|
"time"
|
|
|
|
v "github.com/hashicorp/go-version"
|
|
|
|
"github.com/netbirdio/netbird/client/internal/peer"
|
|
"github.com/netbirdio/netbird/client/internal/statemanager"
|
|
)
|
|
|
|
func Test_UndecidedMode_SuppressesNotification(t *testing.T) {
|
|
tmpFile := path.Join(t.TempDir(), "update-test-undecided.json")
|
|
recorder := peer.NewRecorder("")
|
|
sub := recorder.SubscribeToEvents()
|
|
defer recorder.UnsubscribeFromEvents(sub)
|
|
|
|
mockUpdate := &versionUpdateMock{latestVersion: v.Must(v.NewSemver("1.0.1"))}
|
|
m := NewManager(recorder, statemanager.New(tmpFile))
|
|
m.update = mockUpdate
|
|
m.currentVersion = "1.0.0"
|
|
m.Start(context.Background())
|
|
defer m.Stop()
|
|
|
|
mockUpdate.onUpdate()
|
|
if ver, _ := waitForUpdateEvent(sub, 300*time.Millisecond); ver != "" {
|
|
t.Fatalf("undecided mode must not publish, got %q", ver)
|
|
}
|
|
|
|
m.NotifyUI()
|
|
if ver, _ := waitForUpdateEvent(sub, 300*time.Millisecond); ver != "" {
|
|
t.Fatalf("NotifyUI in undecided mode must not publish, got %q", ver)
|
|
}
|
|
|
|
m.SetDownloadOnly()
|
|
ver, enforced := waitForUpdateEvent(sub, 500*time.Millisecond)
|
|
if ver != "1.0.1" {
|
|
t.Fatalf("expected download-only event for 1.0.1, got %q", ver)
|
|
}
|
|
if enforced {
|
|
t.Error("download-only event must not carry enforced metadata")
|
|
}
|
|
}
|
|
|
|
func Test_ResetMode_ReturnsToUndecided(t *testing.T) {
|
|
tmpFile := path.Join(t.TempDir(), "update-test-reset.json")
|
|
recorder := peer.NewRecorder("")
|
|
sub := recorder.SubscribeToEvents()
|
|
defer recorder.UnsubscribeFromEvents(sub)
|
|
|
|
mockUpdate := &versionUpdateMock{latestVersion: v.Must(v.NewSemver("1.0.1"))}
|
|
m := NewManager(recorder, statemanager.New(tmpFile))
|
|
m.update = mockUpdate
|
|
m.currentVersion = "1.0.0"
|
|
m.autoUpdateSupported = func() bool { return true }
|
|
m.Start(context.Background())
|
|
defer m.Stop()
|
|
|
|
m.SetVersion("1.0.1", false)
|
|
ver, enforced := waitForUpdateEvent(sub, 500*time.Millisecond)
|
|
if ver != "1.0.1" || !enforced {
|
|
t.Fatalf("expected enforced event for 1.0.1, got %q enforced=%v", ver, enforced)
|
|
}
|
|
|
|
m.ResetMode()
|
|
|
|
mockUpdate.onUpdate()
|
|
if ver, _ := waitForUpdateEvent(sub, 300*time.Millisecond); ver != "" {
|
|
t.Fatalf("reset mode must not publish on fetch, got %q", ver)
|
|
}
|
|
|
|
m.NotifyUI()
|
|
if ver, _ := waitForUpdateEvent(sub, 300*time.Millisecond); ver != "" {
|
|
t.Fatalf("NotifyUI after reset must not publish, got %q", ver)
|
|
}
|
|
|
|
if err := m.Install(context.Background()); err == nil {
|
|
t.Fatal("Install after reset must fail without a pending version")
|
|
}
|
|
|
|
m.SetVersion("1.0.1", false)
|
|
ver, enforced = waitForUpdateEvent(sub, 500*time.Millisecond)
|
|
if ver != "1.0.1" || !enforced {
|
|
t.Fatalf("expected enforced event again after reset, got %q enforced=%v", ver, enforced)
|
|
}
|
|
}
|
|
|
|
func Test_SetDownloadOnly_ClearsPendingVersion(t *testing.T) {
|
|
tmpFile := path.Join(t.TempDir(), "update-test-pending.json")
|
|
recorder := peer.NewRecorder("")
|
|
sub := recorder.SubscribeToEvents()
|
|
defer recorder.UnsubscribeFromEvents(sub)
|
|
|
|
m := NewManager(recorder, statemanager.New(tmpFile))
|
|
m.update = &versionUpdateMock{latestVersion: v.Must(v.NewSemver("1.0.1"))}
|
|
m.currentVersion = "1.0.0"
|
|
m.autoUpdateSupported = func() bool { return true }
|
|
m.Start(context.Background())
|
|
defer m.Stop()
|
|
|
|
m.SetVersion("1.0.1", false)
|
|
if ver, enforced := waitForUpdateEvent(sub, 500*time.Millisecond); ver != "1.0.1" || !enforced {
|
|
t.Fatalf("expected enforced event for 1.0.1, got %q enforced=%v", ver, enforced)
|
|
}
|
|
|
|
m.SetDownloadOnly()
|
|
if ver, enforced := waitForUpdateEvent(sub, 500*time.Millisecond); ver != "1.0.1" || enforced {
|
|
t.Fatalf("expected download-only event for 1.0.1, got %q enforced=%v", ver, enforced)
|
|
}
|
|
|
|
if err := m.Install(context.Background()); err == nil {
|
|
t.Fatal("Install in download-only mode must not install the staged managed version")
|
|
}
|
|
}
|