mirror of
https://github.com/netbirdio/netbird.git
synced 2026-08-28 18:41:30 +02:00
On mobile the client kept dialing management, signal, relay and peer connections while the device had no usable network at all (airplane mode), burning battery for attempts that cannot succeed. Stopping the engine is not an option: tearing it down destroys the TUN device, and traffic can leak outside the tunnel until it is rebuilt. Add client/netstate, a small gate the platform feeds from its own connectivity callbacks. Every reconnection loop waits on it instead of retrying blindly, and resets its backoff when the network returns so recovery is immediate. The state is injected through functional options and consumers hold a *State that may be nil, so every platform that does not report availability behaves exactly as before. The relay quick-reconnect rechecks availability after its 1.5s wait: the disconnect that triggers it is usually the first symptom of the network going away, so the flag typically arrives while it sleeps. Report the suspension to the UI as well. peer.Listener grows OnStateChanged with a typed ClientState, re-exported across the gomobile boundary as integer constants, and the notifier maps Connecting to a new NoNetwork state while the OS reports no network, so mobile clients can show "no network available" instead of a misleading "connecting". Finally, exit the client retry loop cleanly when its context is cancelled. backoff.WithContext surfaces the bare context error, which callers could not distinguish from a real failure — on Android that turned an engine restart into an unrecoverable error.
206 lines
4.7 KiB
Go
206 lines
4.7 KiB
Go
package peer
|
|
|
|
import (
|
|
"sync"
|
|
)
|
|
|
|
type notifier struct {
|
|
serverStateLock sync.Mutex
|
|
listenersLock sync.Mutex
|
|
listener Listener
|
|
currentClientState bool
|
|
lastNotification ClientState
|
|
lastNumberOfPeers int
|
|
lastFqdnAddress string
|
|
lastIPAddress string
|
|
networkAvailable bool
|
|
}
|
|
|
|
func newNotifier() *notifier {
|
|
return ¬ifier{
|
|
networkAvailable: true,
|
|
}
|
|
}
|
|
|
|
// effectiveState maps the computed state to what listeners should see:
|
|
// while the OS reports no usable network, "Connecting" would be a lie —
|
|
// connection attempts are suspended — so it is reported as NoNetwork.
|
|
// Caller must hold serverStateLock.
|
|
func (n *notifier) effectiveState(state ClientState) ClientState {
|
|
if !n.networkAvailable && state == ClientStateConnecting {
|
|
return ClientStateNoNetwork
|
|
}
|
|
return state
|
|
}
|
|
|
|
// setNetworkAvailable records the OS network availability and re-notifies
|
|
// the listener when the flag flips the effective state (Connecting <->
|
|
// NoNetwork).
|
|
func (n *notifier) setNetworkAvailable(available bool) {
|
|
n.serverStateLock.Lock()
|
|
if n.networkAvailable == available {
|
|
n.serverStateLock.Unlock()
|
|
return
|
|
}
|
|
previous := n.effectiveState(n.lastNotification)
|
|
n.networkAvailable = available
|
|
current := n.effectiveState(n.lastNotification)
|
|
n.serverStateLock.Unlock()
|
|
|
|
if previous != current {
|
|
n.notify(current)
|
|
}
|
|
}
|
|
|
|
func (n *notifier) setListener(listener Listener) {
|
|
n.serverStateLock.Lock()
|
|
lastNotification := n.effectiveState(n.lastNotification)
|
|
numOfPeers := n.lastNumberOfPeers
|
|
fqdnAddress := n.lastFqdnAddress
|
|
address := n.lastIPAddress
|
|
n.serverStateLock.Unlock()
|
|
|
|
n.listenersLock.Lock()
|
|
defer n.listenersLock.Unlock()
|
|
|
|
n.listener = listener
|
|
|
|
listener.OnAddressChanged(fqdnAddress, address)
|
|
notifyListener(listener, lastNotification)
|
|
// run on go routine to avoid on Java layer to call go functions on same thread
|
|
go listener.OnPeersListChanged(numOfPeers)
|
|
}
|
|
|
|
func (n *notifier) removeListener() {
|
|
n.listenersLock.Lock()
|
|
defer n.listenersLock.Unlock()
|
|
n.listener = nil
|
|
}
|
|
|
|
func (n *notifier) updateServerStates(mgmState bool, signalState bool) {
|
|
n.serverStateLock.Lock()
|
|
calculatedState := n.calculateState(mgmState, signalState)
|
|
|
|
if !n.isServerStateChanged(calculatedState) {
|
|
n.serverStateLock.Unlock()
|
|
return
|
|
}
|
|
|
|
n.lastNotification = calculatedState
|
|
effective := n.effectiveState(calculatedState)
|
|
n.serverStateLock.Unlock()
|
|
|
|
n.notify(effective)
|
|
}
|
|
|
|
func (n *notifier) clientStart() {
|
|
n.serverStateLock.Lock()
|
|
n.currentClientState = true
|
|
n.lastNotification = ClientStateConnecting
|
|
effective := n.effectiveState(ClientStateConnecting)
|
|
n.serverStateLock.Unlock()
|
|
|
|
n.notify(effective)
|
|
}
|
|
|
|
func (n *notifier) clientStop() {
|
|
n.serverStateLock.Lock()
|
|
n.currentClientState = false
|
|
n.lastNotification = ClientStateDisconnected
|
|
n.serverStateLock.Unlock()
|
|
|
|
n.notify(ClientStateDisconnected)
|
|
}
|
|
|
|
func (n *notifier) clientTearDown() {
|
|
n.serverStateLock.Lock()
|
|
n.currentClientState = false
|
|
n.lastNotification = ClientStateDisconnecting
|
|
n.serverStateLock.Unlock()
|
|
|
|
n.notify(ClientStateDisconnecting)
|
|
}
|
|
|
|
func (n *notifier) isServerStateChanged(newState ClientState) bool {
|
|
return n.lastNotification != newState
|
|
}
|
|
|
|
func (n *notifier) notify(state ClientState) {
|
|
n.listenersLock.Lock()
|
|
listener := n.listener
|
|
n.listenersLock.Unlock()
|
|
|
|
if listener == nil {
|
|
return
|
|
}
|
|
|
|
notifyListener(listener, state)
|
|
}
|
|
|
|
func (n *notifier) calculateState(managementConn, signalConn bool) ClientState {
|
|
if managementConn && signalConn {
|
|
return ClientStateConnected
|
|
}
|
|
|
|
if !managementConn && !signalConn && !n.currentClientState {
|
|
return ClientStateDisconnected
|
|
}
|
|
|
|
if n.lastNotification == ClientStateDisconnecting {
|
|
return ClientStateDisconnecting
|
|
}
|
|
|
|
return ClientStateConnecting
|
|
}
|
|
|
|
func (n *notifier) peerListChanged(numOfPeers int) {
|
|
n.serverStateLock.Lock()
|
|
n.lastNumberOfPeers = numOfPeers
|
|
n.serverStateLock.Unlock()
|
|
|
|
n.listenersLock.Lock()
|
|
listener := n.listener
|
|
n.listenersLock.Unlock()
|
|
|
|
if listener == nil {
|
|
return
|
|
}
|
|
|
|
// run on go routine to avoid on Java layer to call go functions on same thread
|
|
go listener.OnPeersListChanged(numOfPeers)
|
|
}
|
|
|
|
func (n *notifier) localAddressChanged(fqdn, address string) {
|
|
n.serverStateLock.Lock()
|
|
n.lastFqdnAddress = fqdn
|
|
n.lastIPAddress = address
|
|
n.serverStateLock.Unlock()
|
|
|
|
n.listenersLock.Lock()
|
|
listener := n.listener
|
|
n.listenersLock.Unlock()
|
|
|
|
if listener == nil {
|
|
return
|
|
}
|
|
|
|
listener.OnAddressChanged(fqdn, address)
|
|
}
|
|
|
|
func notifyListener(l Listener, state ClientState) {
|
|
// legacy per-state callbacks; NoNetwork is delivered only via
|
|
// OnStateChanged below
|
|
switch state {
|
|
case ClientStateDisconnected:
|
|
l.OnDisconnected()
|
|
case ClientStateConnected:
|
|
l.OnConnected()
|
|
case ClientStateConnecting:
|
|
l.OnConnecting()
|
|
case ClientStateDisconnecting:
|
|
l.OnDisconnecting()
|
|
}
|
|
|
|
l.OnStateChanged(state)
|
|
}
|