mirror of
https://github.com/netbirdio/netbird.git
synced 2026-07-19 15:01:29 +02:00
b416063bcc
* [agent-network] Shared proto, OpenAPI schema, and generated types * [agent-network] Management: store, manager, synthesizer, policy engine, provider catalog, HTTP/gRPC API Adds the account-scoped agent-network module: provider/policy/budget CRUD and store, the reverse-proxy service synthesizer, policy selection + limit enforcement, the provider catalog (incl. Vertex AI and AWS Bedrock entries), and the management HTTP + proxy gRPC surfaces. * [management] Fix agent-network proxy-peer fan-out on affected-peer recompute The affected-peers resolver loaded only persisted reverse-proxy services, but agent-network services are synthesized on demand and never persisted. As a result the embedded proxy peer was never folded into the affected set when a client's group changed, so the proxy received no network-map update for a newly authorised client and rejected its handshake until a full resync (restart). loadProxyServices now merges the synthesized agent-network services (injected via a registration hook to avoid an import cycle), so proxy peers learn newly authorised clients immediately. * [proxy] Reverse-proxy middleware framework, chain, and request plumbing The per-target middleware chain (slots, dispatcher, mutation gate, metadata merger), body capture, access-log terminal sink, and the proxy wiring that builds + runs chains for synthesized agent-network services. * [proxy] LLM parsers, pricing, and builtin middlewares (OpenAI, Anthropic, Vertex AI, AWS Bedrock) Request/response parsers and SSE/event-stream metering, the embedded pricing table, and the builtin middleware set: request parser, router, policy limit-check/record, cost meter, guardrail, identity inject, response parser. Includes the path-routed providers — Google Vertex AI (keyfile:: service-account OAuth minting) and AWS Bedrock (bearer auth, invoke/converse/streaming, optional /bedrock prefix) — plus the Models allowlist and unmeterable-publisher deny. * [proxy] IPv6 in-place apply and TCP accept-loop hardening on netstack listeners * [agent-network] End-to-end test suite, module docs, and deployment preset * [agent-network] Fix codespell typos and exclude false positives - labelgen word pool: vermillion -> vermilion, racoon -> raccoon. - codespell ignore list: add flate (Go compress/flate package), recordin (a test-local identifier), and unparseable (a valid alternative spelling used consistently across identifiers + a metadata-value constant). * [management] Set LastSeen on injected proxy peer in realstack test (MySQL strict-mode) The injected embedded proxy peer had a PeerStatus with a zero LastSeen, which serializes to '0000-00-00' and is rejected by MySQL in strict mode (SQLite tolerates it). Set LastSeen to a valid time so SaveAccount succeeds on both engines. * [agent-network] Remove e2e shell-script suite from this branch The end-to-end shell scripts under scripts/e2e/ are maintained in a separate testing suite and are not part of this change set. * [agent-network] Polish module docs: remove internal review scaffolding, fix links, verify diagrams Strip PR-review framing, commit references, absolute paths, and stale internal references from the agent-network module docs; fix broken relative links; verify all diagrams against the current architecture. Remove the internal AI-reviewer prompt file. * [management] Refine session expiration handling to support 3-state encoding for SSO deadlines * [agent-network] Relocate agentnetwork package to internals/modules Move management/server/agentnetwork (and its catalog/, labelgen/, types/ subpackages) to management/internals/modules/agentnetwork, alongside the reverse-proxy module, and rewrite all importers. Pure relocation: package names, the synthesizer + affectedpeers registration hook, and store access (shared store.Store) are unchanged, so no import cycle is introduced (affectedpeers still depends only on the agentnetwork/types leaf). * [agent-network] Co-locate HTTP handlers in the module (RegisterEndpoints) Move the agent-network HTTP handlers from server/http/handlers/agentnetwork into the module at internals/modules/agentnetwork/handlers (package handlers) and rename the entrypoint AddEndpoints -> RegisterEndpoints, matching the reverse-proxy module convention. Wiring in http/handler.go updated accordingly.
96 lines
3.6 KiB
Go
96 lines
3.6 KiB
Go
package affectedpeers
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
rpservice "github.com/netbirdio/netbird/management/internals/modules/reverseproxy/service"
|
|
"github.com/netbirdio/netbird/management/server/store"
|
|
)
|
|
|
|
// fakeProxyStore implements only the two store methods loadProxyServices calls;
|
|
// the embedded nil store.Store panics if anything else is invoked, which keeps
|
|
// the test honest about the surface under test.
|
|
type fakeProxyStore struct {
|
|
store.Store
|
|
proxyByCluster map[string][]string
|
|
persisted []*rpservice.Service
|
|
}
|
|
|
|
func (f *fakeProxyStore) GetEmbeddedProxyPeerIDsByCluster(_ context.Context, _ string) (map[string][]string, error) {
|
|
return f.proxyByCluster, nil
|
|
}
|
|
|
|
func (f *fakeProxyStore) GetAccountServices(_ context.Context, _ store.LockingStrength, _ string) ([]*rpservice.Service, error) {
|
|
return f.persisted, nil
|
|
}
|
|
|
|
func serviceIDs(svcs []*rpservice.Service) []string {
|
|
ids := make([]string, 0, len(svcs))
|
|
for _, s := range svcs {
|
|
ids = append(ids, s.ID)
|
|
}
|
|
return ids
|
|
}
|
|
|
|
// loadProxyServices must merge the synthesised agent-network services (which are
|
|
// never persisted) with the persisted ones, so the proxy-affected expansion can
|
|
// see agent-network AccessGroups. Without this the embedded proxy peer is never
|
|
// flagged on a client group change and only a full resync (restart) recovers.
|
|
func TestLoadProxyServices_MergesSynthesizedAgentNetworkServices(t *testing.T) {
|
|
prev := agentNetworkSynthesizer
|
|
t.Cleanup(func() { agentNetworkSynthesizer = prev })
|
|
SetAgentNetworkSynthesizer(func(_ context.Context, _ store.Store, _ string) ([]*rpservice.Service, error) {
|
|
return []*rpservice.Service{
|
|
{ID: "agent-net-svc-acc", ProxyCluster: "proxy.netbird.local", Private: true, AccessGroups: []string{"gB"}},
|
|
}, nil
|
|
})
|
|
|
|
s := &fakeProxyStore{
|
|
proxyByCluster: map[string][]string{"proxy.netbird.local": {"proxy-peer-1"}},
|
|
persisted: []*rpservice.Service{{ID: "persisted-rp-svc", ProxyCluster: "proxy.netbird.local"}},
|
|
}
|
|
snap := &Snapshot{}
|
|
require.NoError(t, snap.loadProxyServices(context.Background(), s, "acc"))
|
|
|
|
ids := serviceIDs(snap.services)
|
|
assert.Contains(t, ids, "persisted-rp-svc", "persisted services must be kept")
|
|
assert.Contains(t, ids, "agent-net-svc-acc", "synthesised agent-network service must be merged in")
|
|
}
|
|
|
|
// With no synthesiser registered, loadProxyServices falls back to persisted
|
|
// services only (no panic, no behaviour change for non-agent-network builds).
|
|
func TestLoadProxyServices_NoSynthesizerRegistered(t *testing.T) {
|
|
prev := agentNetworkSynthesizer
|
|
t.Cleanup(func() { agentNetworkSynthesizer = prev })
|
|
agentNetworkSynthesizer = nil
|
|
|
|
s := &fakeProxyStore{
|
|
proxyByCluster: map[string][]string{"c": {"proxy-1"}},
|
|
persisted: []*rpservice.Service{{ID: "persisted"}},
|
|
}
|
|
snap := &Snapshot{}
|
|
require.NoError(t, snap.loadProxyServices(context.Background(), s, "acc"))
|
|
assert.Equal(t, []string{"persisted"}, serviceIDs(snap.services))
|
|
}
|
|
|
|
// No embedded proxy peers → skip entirely (don't even call the synthesiser).
|
|
func TestLoadProxyServices_NoEmbeddedProxyPeersSkips(t *testing.T) {
|
|
prev := agentNetworkSynthesizer
|
|
t.Cleanup(func() { agentNetworkSynthesizer = prev })
|
|
called := false
|
|
SetAgentNetworkSynthesizer(func(_ context.Context, _ store.Store, _ string) ([]*rpservice.Service, error) {
|
|
called = true
|
|
return nil, nil
|
|
})
|
|
|
|
s := &fakeProxyStore{proxyByCluster: map[string][]string{}}
|
|
snap := &Snapshot{}
|
|
require.NoError(t, snap.loadProxyServices(context.Background(), s, "acc"))
|
|
assert.False(t, called, "synthesiser must not run for accounts without embedded proxy peers")
|
|
assert.Empty(t, snap.services)
|
|
}
|