* [client] Mark Rosenpass flags as deprecated
Rosenpass support is being deprecated. Users enabling it from the CLI
should learn that before they depend on it, while the feature itself
keeps working.
* [client] Show Rosenpass deprecation notice in the UI settings
Desktop users enable Rosenpass from the settings toggle, not the CLI,
so the deprecation notice needs to reach them there too. A new string
key falls back to English until Crowdin translates it, instead of
showing a stale translation without the notice.
* [client] Keep switchOrCreateProfile doc comment attached
The Rosenpass warning helper landed between switchOrCreateProfile and
its doc comment, leaving the function undocumented.
* [client] Use MarkDeprecated for the Rosenpass flags
Follows the convention already used for --enable-lazy-connection, as
asked in review. The flags drop out of --help and pflag warns on any
use, so the custom helper is no longer needed.
* [client] Isolate the Rosenpass flag test from upCmd's flag set
Setting the shared upCmd flags left them marked Changed for any later
test in the package.
Riccardo Manfrin
36339993bc