mirror of
https://github.com/netbirdio/netbird.git
synced 2026-09-12 17:59:06 +02:00
Nothing recorded which run of the connection was current, so three defects followed from the same gap. A ConnectClient is single-use, and the daemon builds a fresh one per outer-retry turn (server.go connect). Each turn overwrote s.connectClient and nothing stopped the one it replaced — the outgoing run loop had returned, which is what brought control back to the retry, but that was assumed rather than enforced, and any teardown its error path left half-done got no second chance. cleanupConnection read s.connectClient, cancelled, then stopped that engine. Nothing established the client it read was still current by the time it stopped it, so a teardown could target a client a newer turn had already replaced and leave the live one running untracked. Down's wait on clientGiveUpChan and Up's refusal to start a second loop kept the window narrow, but by arrangement rather than by construction. Third, the engine was stopped twice concurrently: actCancel woke the run loop, which stops the engine on its way out, while cleanupConnection stopped the same engine directly. The TODO there said ConnectClient.Stop was the right call and that its unbounded wait was what ruled it out. RunSupervisor records the generation of the current run. Publish refuses a client from a superseded run and stops the client it displaces, so no ConnectClient is dropped without being stopped. Stop invalidates whatever run is in flight, stops the published client and waits for the run to exit. ConnectClient.StopWithContext bounds that wait, which removes the TODO's obstacle: cleanupConnection now hands the run loop sole ownership of engine shutdown and passes Down's 5s budget down. Stop() keeps its signature and its unbounded wait, so callers outside this change are untouched. embed.Client.Stop had built the same bound by hand with a goroutine and a select purely to watch its caller's context; it passes the context down instead. clientGiveUpChan and connectClient are gone — the supervisor answers both. The MDM restart path drops its hand-rolled 10s channel wait for the same Stop, which additionally stops the client the previous run left behind. Its deliberate choice to leave clientRunning set is unchanged. Down now waits inside cleanupConnection, under s.mutex, where it previously waited after releasing it. That is what pins the client being stopped to the one current when the call started; the cost is that Down can hold the mutex for up to its 5s budget. Found while fixing the iOS wifi-to-cellular black-hole (#7329), which was the same class of defect in the mobile SDKs. No bug report backs the daemon findings — they are read off the code, and the narrow windows above may be why they have not been observed.
146 lines
4.5 KiB
Go
146 lines
4.5 KiB
Go
package server
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
|
|
"github.com/hashicorp/go-multierror"
|
|
"google.golang.org/grpc/codes"
|
|
"google.golang.org/grpc/status"
|
|
|
|
nberrors "github.com/netbirdio/netbird/client/errors"
|
|
"github.com/netbirdio/netbird/client/internal"
|
|
"github.com/netbirdio/netbird/client/internal/routemanager/systemops"
|
|
"github.com/netbirdio/netbird/client/internal/statemanager"
|
|
"github.com/netbirdio/netbird/client/proto"
|
|
)
|
|
|
|
// ListStates returns a list of all saved states
|
|
func (s *Server) ListStates(_ context.Context, _ *proto.ListStatesRequest) (*proto.ListStatesResponse, error) {
|
|
mgr := statemanager.New(s.profileManager.GetStatePath())
|
|
|
|
stateNames, err := mgr.GetSavedStateNames()
|
|
if err != nil {
|
|
return nil, status.Errorf(codes.Internal, "failed to get saved state names: %v", err)
|
|
}
|
|
|
|
states := make([]*proto.State, 0, len(stateNames))
|
|
for _, name := range stateNames {
|
|
states = append(states, &proto.State{
|
|
Name: name,
|
|
})
|
|
}
|
|
|
|
return &proto.ListStatesResponse{
|
|
States: states,
|
|
}, nil
|
|
}
|
|
|
|
// CleanState handles cleaning of states (performing cleanup operations)
|
|
func (s *Server) CleanState(ctx context.Context, req *proto.CleanStateRequest) (*proto.CleanStateResponse, error) {
|
|
if s.runs.Current() != nil && (s.runs.Current().Status() == internal.StatusConnected || s.runs.Current().Status() == internal.StatusConnecting) {
|
|
return nil, status.Errorf(codes.FailedPrecondition, "cannot clean state while connecting or connected, run 'netbird down' first.")
|
|
}
|
|
|
|
statePath := s.profileManager.GetStatePath()
|
|
|
|
if req.All {
|
|
// Reuse existing cleanup logic for all states
|
|
if err := RestoreResidualState(ctx, statePath); err != nil {
|
|
return nil, status.Errorf(codes.Internal, "failed to clean all states: %v", err)
|
|
}
|
|
|
|
// Get count of cleaned states
|
|
mgr := statemanager.New(statePath)
|
|
stateNames, err := mgr.GetSavedStateNames()
|
|
if err != nil {
|
|
return nil, status.Errorf(codes.Internal, "failed to get state count: %v", err)
|
|
}
|
|
|
|
return &proto.CleanStateResponse{
|
|
CleanedStates: int32(len(stateNames)),
|
|
}, nil
|
|
}
|
|
|
|
// Handle single state cleanup
|
|
mgr := statemanager.New(statePath)
|
|
registerStates(mgr)
|
|
|
|
if err := mgr.CleanupStateByName(req.StateName); err != nil {
|
|
return nil, status.Errorf(codes.Internal, "failed to clean state %s: %v", req.StateName, err)
|
|
}
|
|
|
|
if err := mgr.PersistState(ctx); err != nil {
|
|
return nil, status.Errorf(codes.Internal, "failed to persist state changes: %v", err)
|
|
}
|
|
|
|
return &proto.CleanStateResponse{
|
|
CleanedStates: 1,
|
|
}, nil
|
|
}
|
|
|
|
// DeleteState handles deletion of states without cleanup
|
|
func (s *Server) DeleteState(ctx context.Context, req *proto.DeleteStateRequest) (*proto.DeleteStateResponse, error) {
|
|
if s.runs.Current() != nil && (s.runs.Current().Status() == internal.StatusConnected || s.runs.Current().Status() == internal.StatusConnecting) {
|
|
return nil, status.Errorf(codes.FailedPrecondition, "cannot clean state while connecting or connected, run 'netbird down' first.")
|
|
}
|
|
|
|
mgr := statemanager.New(s.profileManager.GetStatePath())
|
|
|
|
var count int
|
|
var err error
|
|
|
|
if req.All {
|
|
count, err = mgr.DeleteAllStates()
|
|
} else {
|
|
err = mgr.DeleteStateByName(req.StateName)
|
|
if err == nil {
|
|
count = 1
|
|
}
|
|
}
|
|
|
|
if err != nil {
|
|
return nil, status.Errorf(codes.Internal, "failed to delete state: %v", err)
|
|
}
|
|
|
|
// Persist the changes
|
|
if err := mgr.PersistState(ctx); err != nil {
|
|
return nil, status.Errorf(codes.Internal, "failed to persist state changes: %v", err)
|
|
}
|
|
|
|
return &proto.DeleteStateResponse{
|
|
DeletedStates: int32(count),
|
|
}, nil
|
|
}
|
|
|
|
// RestoreResidualState checks if the client was not shut down in a clean way and restores residual if required.
|
|
// Otherwise, we might not be able to connect to the management server to retrieve new config.
|
|
func RestoreResidualState(ctx context.Context, statePath string) error {
|
|
if statePath == "" {
|
|
return nil
|
|
}
|
|
|
|
mgr := statemanager.New(statePath)
|
|
|
|
// register the states we are interested in restoring
|
|
registerStates(mgr)
|
|
|
|
var merr *multierror.Error
|
|
|
|
if err := mgr.PerformCleanup(); err != nil {
|
|
merr = multierror.Append(merr, fmt.Errorf("perform cleanup: %w", err))
|
|
}
|
|
|
|
// persist state regardless of cleanup outcome. It could've succeeded partially
|
|
if err := mgr.PersistState(ctx); err != nil {
|
|
merr = multierror.Append(merr, fmt.Errorf("persist state: %w", err))
|
|
}
|
|
|
|
// clean up any remaining routes independently of the state file
|
|
if err := systemops.New(nil, nil).FlushMarkedRoutes(); err != nil {
|
|
merr = multierror.Append(merr, fmt.Errorf("flush marked routes: %w", err))
|
|
}
|
|
|
|
return nberrors.FormatErrorOrNil(merr)
|
|
}
|