mirror of
https://github.com/netbirdio/netbird.git
synced 2026-08-26 17:41:30 +02:00
540c551f19
Two gaps a review found in the live suite. The rotation test finished by renaming the provider and expecting that to succeed. A rename touches none of the fields the check looks at, so it is stored without asking the vendor anything — it would have passed just as well against a key the rotation had already replaced. It now moves the upstream by a trailing slash, which reaches the same host but differs as a string, so the check runs and the stored key is what has to satisfy it. And the refused-url test only asserted the error. An error is not the same fact as an absent record, so it now lists the providers and looks for the one that must not be there — which the refused-key test beside it already did. The discovery upstream override is logged. It sends the stored credential to a host the caller named, which the same permission set can already do by pointing the record there and letting the write check it — but that leaves an activity event behind, and this would otherwise leave nothing.