mirror of
https://github.com/netbirdio/netbird.git
synced 2026-10-09 06:59:08 +02:00
riccardom
0747fa0398
Capability is signalled in-band by an empty answer: a peer that does not run the KEM answers with no payload. But a responder that runs the KEM and simply fails to build the answer (crypto error, failed PSK program, a future protocol version it cannot parse) also produced an empty payload, so the initiator read it as "peer has no KEM" and marked it non-capable — permanently, since only peer removal clears the flag; in strict mode the peer stayed blocked. Add a payload-less MsgError marker. On a signalling-path failure the responder returns the marker instead of an empty answer, and the initiator treats it as "capable but failed this round": it leaves the exchange to time out and re-bootstrap rather than marking the peer non-capable. A genuinely non-KEM peer still sends no payload at all, so the empty-answer capability signal is unchanged. Found in cubic review on #7098 (client/internal/pqkem_adapter.go:72).
67 lines
1.9 KiB
Go
67 lines
1.9 KiB
Go
package pqkem
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestMessageRoundTrip(t *testing.T) {
|
|
init, err := NewInitiator()
|
|
require.NoError(t, err)
|
|
answer, _, err := Respond(init.Offer(), Binding{LocalID: wgB, RemoteID: wgA})
|
|
require.NoError(t, err)
|
|
|
|
id := ExchangeID{1, 2, 3, 4}
|
|
ack := ExchangeID{9, 9, 9}
|
|
|
|
offBytes, err := (&OfferMsg{ExchangeID: id, AckID: ack, KEMOffer: init.Offer()}).Encode()
|
|
require.NoError(t, err)
|
|
typ, decoded, err := Decode(offBytes)
|
|
require.NoError(t, err)
|
|
require.Equal(t, MsgOffer, typ)
|
|
require.Equal(t, id, decoded.(*OfferMsg).ExchangeID)
|
|
require.Equal(t, ack, decoded.(*OfferMsg).AckID)
|
|
require.Equal(t, init.Offer(), decoded.(*OfferMsg).KEMOffer)
|
|
|
|
ansBytes, err := (&AnswerMsg{ExchangeID: id, KEMAnswer: answer}).Encode()
|
|
require.NoError(t, err)
|
|
typ, decoded, err = Decode(ansBytes)
|
|
require.NoError(t, err)
|
|
require.Equal(t, MsgAnswer, typ)
|
|
require.Equal(t, answer, decoded.(*AnswerMsg).KEMAnswer)
|
|
|
|
// The error marker is a non-empty, payload-less message carrying the exchange id, so
|
|
// the initiator can tell a responder failure from an empty "no KEM" answer.
|
|
errBytes := (&ErrorMsg{ExchangeID: id}).Encode()
|
|
require.NotEmpty(t, errBytes)
|
|
typ, decoded, err = Decode(errBytes)
|
|
require.NoError(t, err)
|
|
require.Equal(t, MsgError, typ)
|
|
require.Equal(t, id, decoded.(*ErrorMsg).ExchangeID)
|
|
}
|
|
|
|
func TestDecodeRejects(t *testing.T) {
|
|
// too short
|
|
_, _, err := Decode([]byte{1, 1})
|
|
require.Error(t, err)
|
|
|
|
// wrong version
|
|
bad := make([]byte, headerSize+ExchangeIDSize+OfferSize)
|
|
bad[0] = byte(MsgOffer)
|
|
bad[1] = ProtocolVersion + 1
|
|
_, _, err = Decode(bad)
|
|
require.Error(t, err)
|
|
|
|
// unknown type
|
|
bad2 := make([]byte, headerSize)
|
|
bad2[0] = 99
|
|
bad2[1] = ProtocolVersion
|
|
_, _, err = Decode(bad2)
|
|
require.Error(t, err)
|
|
|
|
// offer with wrong payload size
|
|
_, err = (&OfferMsg{KEMOffer: []byte{1, 2, 3}}).Encode()
|
|
require.Error(t, err)
|
|
}
|