mirror of
https://github.com/netbirdio/netbird.git
synced 2026-09-12 17:59:06 +02:00
startSSOLogin consumed forceAccountPrompt and applied the prompt to the freshly built flow, but reuseOAuthFlow could then answer from a cached flow for the same client — one built without prompt=login, e.g. by RequestJWTAuth. The user got the same silent authorization URL that produced the mismatch, with the flag already spent, so no later round asked either. Rule reuse out when the prompt is forced, while still cancelling the predecessor's wait. RequestJWTAuth also wrote the flow fields one by one, leaving the previous login's hint and accountPrompted behind for WaitSSOLogin to judge a later token against. Both sites now replace the whole record.
183 lines
6.3 KiB
Go
183 lines
6.3 KiB
Go
package server
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/netbirdio/netbird/client/internal"
|
|
"github.com/netbirdio/netbird/client/internal/auth"
|
|
"github.com/netbirdio/netbird/client/proto"
|
|
)
|
|
|
|
type stubOAuthFlow struct {
|
|
token auth.TokenInfo
|
|
onWait func()
|
|
}
|
|
|
|
func (f *stubOAuthFlow) RequestAuthInfo(context.Context) (auth.AuthFlowInfo, error) {
|
|
return auth.AuthFlowInfo{}, nil
|
|
}
|
|
|
|
func (f *stubOAuthFlow) WaitToken(context.Context, auth.AuthFlowInfo) (auth.TokenInfo, error) {
|
|
if f.onWait != nil {
|
|
f.onWait()
|
|
}
|
|
return f.token, nil
|
|
}
|
|
|
|
func (f *stubOAuthFlow) GetClientID(context.Context) string {
|
|
return "stub-client"
|
|
}
|
|
|
|
func TestWaitSSOLogin_WrongAccountArmsPromptAndFails(t *testing.T) {
|
|
s := newSSOTestServer(t, "user@example.com", false, "other@example.com")
|
|
attempts := 0
|
|
s.loginAttemptFn = func(context.Context, string, string) (internal.StatusType, error) {
|
|
attempts++
|
|
return "", nil
|
|
}
|
|
|
|
resp, err := s.WaitSSOLogin(context.Background(), &proto.WaitSSOLoginRequest{UserCode: "code"})
|
|
require.Error(t, err)
|
|
require.Nil(t, resp)
|
|
require.Equal(t, 0, attempts, "the wrong account's token reached the management login")
|
|
require.True(t, s.forceAccountPrompt, "the next login was not armed to ask for the account")
|
|
require.Nil(t, s.oauthAuthFlow.flow, "the mismatched flow stayed cached for reuse")
|
|
|
|
status, stateErr := internal.CtxGetState(s.rootCtx).Status()
|
|
require.NoError(t, stateErr)
|
|
require.Equal(t, internal.StatusNeedsLogin, status, "the mismatch must stay retryable")
|
|
}
|
|
|
|
func TestWaitSSOLogin_WrongAccountAfterPromptProceeds(t *testing.T) {
|
|
s := newSSOTestServer(t, "user@example.com", true, "other@example.com")
|
|
attempts := 0
|
|
s.loginAttemptFn = func(context.Context, string, string) (internal.StatusType, error) {
|
|
attempts++
|
|
return "", nil
|
|
}
|
|
|
|
resp, err := s.WaitSSOLogin(context.Background(), &proto.WaitSSOLoginRequest{UserCode: "code"})
|
|
require.NoError(t, err, "a prompted round must not error again on a mismatch")
|
|
require.NotNil(t, resp)
|
|
require.Equal(t, "other@example.com", resp.Email)
|
|
require.Equal(t, 1, attempts)
|
|
require.False(t, s.forceAccountPrompt)
|
|
}
|
|
|
|
func TestWaitSSOLogin_MatchingAccountProceeds(t *testing.T) {
|
|
s := newSSOTestServer(t, "user@example.com", false, "User@Example.com")
|
|
attempts := 0
|
|
s.loginAttemptFn = func(context.Context, string, string) (internal.StatusType, error) {
|
|
attempts++
|
|
return "", nil
|
|
}
|
|
|
|
resp, err := s.WaitSSOLogin(context.Background(), &proto.WaitSSOLoginRequest{UserCode: "code"})
|
|
require.NoError(t, err)
|
|
require.NotNil(t, resp)
|
|
require.Equal(t, 1, attempts)
|
|
require.False(t, s.forceAccountPrompt)
|
|
}
|
|
|
|
func TestWaitSSOLogin_NoHintIsNotJudged(t *testing.T) {
|
|
s := newSSOTestServer(t, "", false, "whoever@example.com")
|
|
attempts := 0
|
|
s.loginAttemptFn = func(context.Context, string, string) (internal.StatusType, error) {
|
|
attempts++
|
|
return "", nil
|
|
}
|
|
|
|
_, err := s.WaitSSOLogin(context.Background(), &proto.WaitSSOLoginRequest{UserCode: "code"})
|
|
require.NoError(t, err)
|
|
require.Equal(t, 1, attempts)
|
|
require.False(t, s.forceAccountPrompt)
|
|
}
|
|
|
|
func TestSwitchProfile_DropsAccountPromptAndPendingFlow(t *testing.T) {
|
|
s, ctx, _, _, _ := setupServerWithProfile(t)
|
|
s.forceAccountPrompt = true
|
|
cancelled := false
|
|
s.oauthAuthFlow = oauthAuthFlow{
|
|
flow: &stubOAuthFlow{},
|
|
hint: "user@example.com",
|
|
waitCancel: func() { cancelled = true },
|
|
}
|
|
|
|
extendCancelled := false
|
|
s.extendAuthSessionFlow.Set(&stubOAuthFlow{}, auth.AuthFlowInfo{DeviceCode: "device"})
|
|
s.extendAuthSessionFlow.SetWaitCancel(func() { extendCancelled = true })
|
|
|
|
_, err := s.SwitchProfile(ctx, nil)
|
|
require.NoError(t, err)
|
|
require.False(t, s.forceAccountPrompt, "the prompt flag leaked across a profile switch")
|
|
require.Nil(t, s.oauthAuthFlow.flow, "the previous profile's flow leaked across a profile switch")
|
|
require.Empty(t, s.oauthAuthFlow.hint)
|
|
require.True(t, cancelled, "the pending wait was not cancelled")
|
|
|
|
require.True(t, extendCancelled, "the pending extend wait was not cancelled")
|
|
_, _, pending := s.extendAuthSessionFlow.Get()
|
|
require.False(t, pending, "the previous profile's extend flow leaked across a profile switch")
|
|
}
|
|
|
|
func TestWaitSSOLogin_JudgesTheFlowThatProducedTheToken(t *testing.T) {
|
|
s := newSSOTestServer(t, "user@example.com", false, "user@example.com")
|
|
attempts := 0
|
|
s.loginAttemptFn = func(context.Context, string, string) (internal.StatusType, error) {
|
|
attempts++
|
|
return "", nil
|
|
}
|
|
|
|
flow := s.oauthAuthFlow.flow.(*stubOAuthFlow)
|
|
flow.onWait = func() {
|
|
s.mutex.Lock()
|
|
defer s.mutex.Unlock()
|
|
s.oauthAuthFlow.hint = "someone-else@example.com"
|
|
}
|
|
|
|
ctx, cancel := context.WithCancel(context.Background())
|
|
defer cancel()
|
|
|
|
resp, err := s.WaitSSOLogin(ctx, &proto.WaitSSOLoginRequest{UserCode: "code"})
|
|
require.NoError(t, err, "a flow replaced mid-wait must not decide this wait's verdict")
|
|
require.NotNil(t, resp)
|
|
require.Equal(t, 1, attempts)
|
|
require.False(t, s.forceAccountPrompt, "the prompt was armed off another flow's hint")
|
|
}
|
|
|
|
func TestReuseOAuthFlow_ForcedPromptRefusesTheCachedFlow(t *testing.T) {
|
|
s := New(internal.CtxInitState(context.Background()), "console", "", false, false, false, false)
|
|
cancelled := false
|
|
s.oauthAuthFlow = oauthAuthFlow{
|
|
flow: &stubOAuthFlow{},
|
|
info: auth.AuthFlowInfo{UserCode: "code"},
|
|
expiresAt: time.Now().Add(time.Hour),
|
|
waitCancel: func() { cancelled = true },
|
|
}
|
|
|
|
state := internal.CtxGetState(s.rootCtx)
|
|
resp := s.reuseOAuthFlow(context.Background(), &stubOAuthFlow{}, state, true)
|
|
require.Nil(t, resp, "a forced account prompt reused the flow that skipped it")
|
|
require.True(t, cancelled, "the predecessor wait was orphaned")
|
|
|
|
resp = s.reuseOAuthFlow(context.Background(), &stubOAuthFlow{}, state, false)
|
|
require.NotNil(t, resp, "an unforced login stopped reusing a live flow")
|
|
require.Equal(t, "code", resp.UserCode)
|
|
}
|
|
|
|
func newSSOTestServer(t *testing.T, hint string, accountPrompted bool, tokenEmail string) *Server {
|
|
t.Helper()
|
|
s := New(internal.CtxInitState(context.Background()), "console", "", false, false, false, false)
|
|
s.oauthAuthFlow = oauthAuthFlow{
|
|
flow: &stubOAuthFlow{token: auth.TokenInfo{Email: tokenEmail, EmailClaim: tokenEmail}},
|
|
info: auth.AuthFlowInfo{UserCode: "code"},
|
|
expiresAt: time.Now().Add(time.Minute),
|
|
hint: hint,
|
|
accountPrompted: accountPrompted,
|
|
}
|
|
return s
|
|
}
|