mirror of
https://github.com/netbirdio/netbird.git
synced 2026-10-20 04:19:08 +02:00
EdwardandDevBot NetBird
279adb8fdd
* [management] Return the reason when custom domain validation fails The validate endpoint returned an empty 202 and ran the check in a goroutine, so a failed verification only reached the management log. Run the check in the request and return 204 or 412 with a classified reason. Resolver errors are not forwarded. * [management] Address review feedback on custom domain validation Pass the request context to the lookup and store calls now that the check runs in the request, compare the self-resolved name case-insensitively, document the 412 like the other entries, and check the returned error in the existing tests. * [management] Match custom domain CNAME targets case-insensitively DNS names are case-insensitive, so a CNAME pointing at the cluster in different casing should validate instead of failing as a mismatch. * [management] Add validation timeout --------- Co-authored-by: DevBot NetBird <91386968+netbirddev@users.noreply.github.com>
14 lines
435 B
Go
14 lines
435 B
Go
package domain
|
|
|
|
import (
|
|
"context"
|
|
)
|
|
|
|
type Manager interface {
|
|
GetDomains(ctx context.Context, accountID, userID string) ([]*Domain, error)
|
|
CreateDomain(ctx context.Context, accountID, userID, domainName, targetCluster string) (*Domain, error)
|
|
DeleteDomain(ctx context.Context, accountID, userID, domainID string) error
|
|
ValidateDomain(ctx context.Context, accountID, userID, domainID string) error
|
|
GetClusterDomains() []string
|
|
}
|