mirror of
https://github.com/netbirdio/netbird.git
synced 2026-07-17 20:19:55 +00:00
## Describe your changes ## Issue ticket number and link ## Stack <!-- branch-stack --> ### Checklist - [x] Is it a bug fix - [ ] Is a typo/documentation fix - [ ] Is a feature enhancement - [ ] It is a refactor - [ ] Created tests that fail without the change (if possible) - [x] This change does **not** modify the public API, gRPC protocols, functionality behavior, CLI / service flags, or introduce a new feature — **OR** I have discussed it with the NetBird team beforehand (link the issue / Slack thread in the description). See [CONTRIBUTING.md](https://github.com/netbirdio/netbird/blob/main/CONTRIBUTING.md#discuss-changes-with-the-netbird-team-first). > By submitting this pull request, you confirm that you have read and agree to the terms of the [Contributor License Agreement](https://github.com/netbirdio/netbird/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT.md). ## Documentation Select exactly one: - [ ] I added/updated documentation for this change - [x] Documentation is **not needed** for this change (explain why) ### Docs PR URL (required if "docs added" is checked) Paste the PR link from https://github.com/netbirdio/docs here: https://github.com/netbirdio/docs/pull/__ <!-- codesmith:footer --> --- <a href="https://app.blacksmith.sh/netbirdio/codesmith/netbird/pr/6800"><picture><source media="(prefers-color-scheme: dark)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-dark-v2.svg"><source media="(prefers-color-scheme: light)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-light-v2.svg"><img alt="View with Codesmith" src="https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-dark-v2.svg"></picture></a> <a href="https://backend.blacksmith.sh/track/enable-autofix?expires=1786797566&installation_id=146802194&pr_number=6800&repository=netbirdio%2Fnetbird&return_to=https%3A%2F%2Fgithub.com%2Fnetbirdio%2Fnetbird%2Fpull%2F6800&signature=36a7053e1029e5de1d496fbd9c428a1745d0ec22b3e6479d64aafb1b8350b0ef"><picture><source media="(prefers-color-scheme: dark)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-light.svg"><img alt="Autofix with Codesmith" src="https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-dark.svg"></picture></a> <sup>Need help on this PR? Tag <code>/codesmith</code> with what you need. Autofix is disabled.</sup> <!-- codesmith:autofix:disabled --> <!-- /codesmith:footer --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Ensure account settings are fully preserved through save/load, including automatic update and peer exposure preferences. * **Tests** * Added coverage to verify account settings remain unchanged after database persistence and retrieval (skipped on Windows due to SQLite limitations). * Introduced deterministic test-data population helpers to reliably set struct fields for deeper settings verification. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Dmitri Dolguikh <dmitri.external@netbird.io>
102 lines
2.7 KiB
Go
102 lines
2.7 KiB
Go
package testing_helpers
|
|
|
|
import (
|
|
"fmt"
|
|
"net/netip"
|
|
"reflect"
|
|
)
|
|
|
|
type PopulateFields struct {
|
|
CustomFieldSetters map[reflect.Type]func(this *PopulateFields, field reflect.Value) (int, error)
|
|
TagsToSkip map[string]string
|
|
}
|
|
|
|
func NewPopulateFields() *PopulateFields {
|
|
return &PopulateFields{CustomFieldSetters: defaultCustomFieldSetters(), TagsToSkip: make(map[string]string)}
|
|
}
|
|
|
|
func (p *PopulateFields) WithCustomFieldSetter(t reflect.Type, f func(this *PopulateFields, field reflect.Value) (int, error)) *PopulateFields {
|
|
p.CustomFieldSetters[t] = f
|
|
return p
|
|
}
|
|
|
|
func (p *PopulateFields) WithSkippedTag(tag, value string) *PopulateFields {
|
|
p.TagsToSkip[tag] = value
|
|
return p
|
|
}
|
|
|
|
func (p *PopulateFields) PopulateAll(v reflect.Value) (int, error) {
|
|
typ := v.Type()
|
|
totalExportedFields := 0
|
|
for i := 0; i < typ.NumField(); i++ {
|
|
f := typ.Field(i)
|
|
if f.PkgPath != "" { // unexported
|
|
continue
|
|
}
|
|
|
|
if p.skippedTagPresent(f.Tag) {
|
|
continue
|
|
}
|
|
|
|
numOfExportedFields, err := p.setNonZero(v.Field(i))
|
|
totalExportedFields += numOfExportedFields
|
|
if err != nil {
|
|
return totalExportedFields, err
|
|
}
|
|
}
|
|
return totalExportedFields, nil
|
|
}
|
|
|
|
// setNonZero assigns a deterministic non-zero value to a field based on its kind,
|
|
// recursing into nested structs and populating one element of slice fields.
|
|
func (p *PopulateFields) setNonZero(field reflect.Value) (int, error) {
|
|
if f, ok := p.CustomFieldSetters[field.Type()]; ok {
|
|
return f(p, field)
|
|
}
|
|
|
|
switch field.Kind() {
|
|
case reflect.String:
|
|
field.SetString("non-zero")
|
|
case reflect.Bool:
|
|
field.SetBool(true)
|
|
case reflect.Int, reflect.Int8, reflect.Int16, reflect.Int32, reflect.Int64:
|
|
field.SetInt(7)
|
|
case reflect.Uint, reflect.Uint8, reflect.Uint16, reflect.Uint32, reflect.Uint64:
|
|
field.SetUint(7)
|
|
case reflect.Float32, reflect.Float64:
|
|
field.SetFloat(7)
|
|
case reflect.Struct:
|
|
n, err := p.PopulateAll(field)
|
|
return n + 1, err
|
|
case reflect.Slice:
|
|
s := reflect.MakeSlice(field.Type(), 1, 1)
|
|
_, err := p.setNonZero(s.Index(0))
|
|
if err != nil {
|
|
return 0, err
|
|
}
|
|
field.Set(s)
|
|
default:
|
|
return 0, fmt.Errorf("unhandled field kind %s; extend setNonZero", field.Kind())
|
|
}
|
|
|
|
return 1, nil
|
|
}
|
|
|
|
func defaultCustomFieldSetters() map[reflect.Type]func(this *PopulateFields, field reflect.Value) (int, error) {
|
|
return map[reflect.Type]func(this *PopulateFields, field reflect.Value) (int, error){
|
|
reflect.TypeOf(netip.Prefix{}): func(_ *PopulateFields, field reflect.Value) (int, error) {
|
|
field.Set(reflect.ValueOf(netip.MustParsePrefix("10.0.0.0/24")))
|
|
return 1, nil
|
|
},
|
|
}
|
|
}
|
|
|
|
func (p *PopulateFields) skippedTagPresent(t reflect.StructTag) bool {
|
|
for tag, value := range p.TagsToSkip {
|
|
if v := t.Get(tag); v == value {
|
|
return true
|
|
}
|
|
}
|
|
return false
|
|
}
|