mirror of
https://github.com/netbirdio/netbird.git
synced 2026-09-13 18:29:07 +02:00
WaitSSOLogin snapshotted the flow on entry but re-read the info, hint and accountPrompted from the live s.oauthAuthFlow afterwards, in separate critical sections. WaitToken blocks for the whole browser leg, so a concurrent Login or RequestJWTAuth could replace the flow meanwhile and the mismatch check would compare this wait's token against another flow's account: either arming the prompt spuriously or letting a wrong-account token through against an unrelated profile's hint. Take all of it in the entry snapshot.
163 lines
5.4 KiB
Go
163 lines
5.4 KiB
Go
package server
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/netbirdio/netbird/client/internal"
|
|
"github.com/netbirdio/netbird/client/internal/auth"
|
|
"github.com/netbirdio/netbird/client/proto"
|
|
)
|
|
|
|
type stubOAuthFlow struct {
|
|
token auth.TokenInfo
|
|
onWait func()
|
|
}
|
|
|
|
func (f *stubOAuthFlow) RequestAuthInfo(context.Context) (auth.AuthFlowInfo, error) {
|
|
return auth.AuthFlowInfo{}, nil
|
|
}
|
|
|
|
func (f *stubOAuthFlow) WaitToken(context.Context, auth.AuthFlowInfo) (auth.TokenInfo, error) {
|
|
if f.onWait != nil {
|
|
f.onWait()
|
|
}
|
|
return f.token, nil
|
|
}
|
|
|
|
func (f *stubOAuthFlow) GetClientID(context.Context) string {
|
|
return "stub-client"
|
|
}
|
|
|
|
func TestWaitSSOLogin_WrongAccountArmsPromptAndFails(t *testing.T) {
|
|
s := newSSOTestServer(t, "user@example.com", false, "other@example.com")
|
|
attempts := 0
|
|
s.loginAttemptFn = func(context.Context, string, string) (internal.StatusType, error) {
|
|
attempts++
|
|
return "", nil
|
|
}
|
|
|
|
resp, err := s.WaitSSOLogin(context.Background(), &proto.WaitSSOLoginRequest{UserCode: "code"})
|
|
require.Error(t, err)
|
|
require.Nil(t, resp)
|
|
require.Equal(t, 0, attempts, "the wrong account's token reached the management login")
|
|
require.True(t, s.forceAccountPrompt, "the next login was not armed to ask for the account")
|
|
require.Nil(t, s.oauthAuthFlow.flow, "the mismatched flow stayed cached for reuse")
|
|
|
|
status, stateErr := internal.CtxGetState(s.rootCtx).Status()
|
|
require.NoError(t, stateErr)
|
|
require.Equal(t, internal.StatusNeedsLogin, status, "the mismatch must stay retryable")
|
|
}
|
|
|
|
func TestWaitSSOLogin_WrongAccountAfterPromptProceeds(t *testing.T) {
|
|
s := newSSOTestServer(t, "user@example.com", true, "other@example.com")
|
|
attempts := 0
|
|
s.loginAttemptFn = func(context.Context, string, string) (internal.StatusType, error) {
|
|
attempts++
|
|
return "", nil
|
|
}
|
|
|
|
resp, err := s.WaitSSOLogin(context.Background(), &proto.WaitSSOLoginRequest{UserCode: "code"})
|
|
require.NoError(t, err, "a prompted round must not error again on a mismatch")
|
|
require.NotNil(t, resp)
|
|
require.Equal(t, "other@example.com", resp.Email)
|
|
require.Equal(t, 1, attempts)
|
|
require.False(t, s.forceAccountPrompt)
|
|
}
|
|
|
|
func TestWaitSSOLogin_MatchingAccountProceeds(t *testing.T) {
|
|
s := newSSOTestServer(t, "user@example.com", false, "User@Example.com")
|
|
attempts := 0
|
|
s.loginAttemptFn = func(context.Context, string, string) (internal.StatusType, error) {
|
|
attempts++
|
|
return "", nil
|
|
}
|
|
|
|
resp, err := s.WaitSSOLogin(context.Background(), &proto.WaitSSOLoginRequest{UserCode: "code"})
|
|
require.NoError(t, err)
|
|
require.NotNil(t, resp)
|
|
require.Equal(t, 1, attempts)
|
|
require.False(t, s.forceAccountPrompt)
|
|
}
|
|
|
|
func TestWaitSSOLogin_NoHintIsNotJudged(t *testing.T) {
|
|
s := newSSOTestServer(t, "", false, "whoever@example.com")
|
|
attempts := 0
|
|
s.loginAttemptFn = func(context.Context, string, string) (internal.StatusType, error) {
|
|
attempts++
|
|
return "", nil
|
|
}
|
|
|
|
_, err := s.WaitSSOLogin(context.Background(), &proto.WaitSSOLoginRequest{UserCode: "code"})
|
|
require.NoError(t, err)
|
|
require.Equal(t, 1, attempts)
|
|
require.False(t, s.forceAccountPrompt)
|
|
}
|
|
|
|
func TestSwitchProfile_DropsAccountPromptAndPendingFlow(t *testing.T) {
|
|
s, ctx, _, _, _ := setupServerWithProfile(t)
|
|
s.forceAccountPrompt = true
|
|
cancelled := false
|
|
s.oauthAuthFlow = oauthAuthFlow{
|
|
flow: &stubOAuthFlow{},
|
|
hint: "user@example.com",
|
|
waitCancel: func() { cancelled = true },
|
|
}
|
|
|
|
extendCancelled := false
|
|
s.extendAuthSessionFlow.Set(&stubOAuthFlow{}, auth.AuthFlowInfo{DeviceCode: "device"})
|
|
s.extendAuthSessionFlow.SetWaitCancel(func() { extendCancelled = true })
|
|
|
|
_, err := s.SwitchProfile(ctx, nil)
|
|
require.NoError(t, err)
|
|
require.False(t, s.forceAccountPrompt, "the prompt flag leaked across a profile switch")
|
|
require.Nil(t, s.oauthAuthFlow.flow, "the previous profile's flow leaked across a profile switch")
|
|
require.Empty(t, s.oauthAuthFlow.hint)
|
|
require.True(t, cancelled, "the pending wait was not cancelled")
|
|
|
|
require.True(t, extendCancelled, "the pending extend wait was not cancelled")
|
|
_, _, pending := s.extendAuthSessionFlow.Get()
|
|
require.False(t, pending, "the previous profile's extend flow leaked across a profile switch")
|
|
}
|
|
|
|
func TestWaitSSOLogin_JudgesTheFlowThatProducedTheToken(t *testing.T) {
|
|
s := newSSOTestServer(t, "user@example.com", false, "user@example.com")
|
|
attempts := 0
|
|
s.loginAttemptFn = func(context.Context, string, string) (internal.StatusType, error) {
|
|
attempts++
|
|
return "", nil
|
|
}
|
|
|
|
flow := s.oauthAuthFlow.flow.(*stubOAuthFlow)
|
|
flow.onWait = func() {
|
|
s.mutex.Lock()
|
|
defer s.mutex.Unlock()
|
|
s.oauthAuthFlow.hint = "someone-else@example.com"
|
|
}
|
|
|
|
ctx, cancel := context.WithCancel(context.Background())
|
|
defer cancel()
|
|
|
|
resp, err := s.WaitSSOLogin(ctx, &proto.WaitSSOLoginRequest{UserCode: "code"})
|
|
require.NoError(t, err, "a flow replaced mid-wait must not decide this wait's verdict")
|
|
require.NotNil(t, resp)
|
|
require.Equal(t, 1, attempts)
|
|
require.False(t, s.forceAccountPrompt, "the prompt was armed off another flow's hint")
|
|
}
|
|
|
|
func newSSOTestServer(t *testing.T, hint string, accountPrompted bool, tokenEmail string) *Server {
|
|
t.Helper()
|
|
s := New(internal.CtxInitState(context.Background()), "console", "", false, false, false, false)
|
|
s.oauthAuthFlow = oauthAuthFlow{
|
|
flow: &stubOAuthFlow{token: auth.TokenInfo{Email: tokenEmail, EmailClaim: tokenEmail}},
|
|
info: auth.AuthFlowInfo{UserCode: "code"},
|
|
expiresAt: time.Now().Add(time.Minute),
|
|
hint: hint,
|
|
accountPrompted: accountPrompted,
|
|
}
|
|
return s
|
|
}
|