mirror of
https://github.com/netbirdio/netbird.git
synced 2026-09-14 18:59:08 +02:00
mlsmaycon
683af3b6cb
go test -json interleaves the streams of packages that run in parallel, so a single panic flag let one package's goroutine dump swallow the output of every other package until its own fail event. Keep the panic head per package and clear it with that package's result. A test that hangs before printing anything is now registered on its run event, so the unfinished list names it. Output a package prints outside any test, which is where compiler diagnostics of a failed build land, was dropped; it is buffered and printed when the package fails, including the build-fail event newer Go versions emit.
113 lines
4.0 KiB
Go
113 lines
4.0 KiB
Go
package main
|
|
|
|
import (
|
|
"bytes"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
func feed(t *testing.T, events string) string {
|
|
t.Helper()
|
|
var out bytes.Buffer
|
|
s := newSummarizer(&out)
|
|
if err := s.consume(strings.NewReader(events)); err != nil {
|
|
t.Fatalf("consume: %v", err)
|
|
}
|
|
s.printSummary(10)
|
|
return out.String()
|
|
}
|
|
|
|
func TestTimeoutReportsUnfinishedTestsAndPanicHead(t *testing.T) {
|
|
events := `
|
|
{"Action":"run","Package":"a","Test":"TestHang"}
|
|
{"Action":"output","Package":"a","Test":"TestHang","Output":"=== RUN TestHang\n"}
|
|
{"Action":"run","Package":"a","Test":"TestSilent"}
|
|
{"Action":"output","Package":"a","Test":"TestHang","Output":"panic: test timed out after 1s\n"}
|
|
{"Action":"output","Package":"a","Test":"TestHang","Output":"\trunning tests:\n"}
|
|
{"Action":"output","Package":"a","Test":"TestHang","Output":"\t\tTestHang (1s)\n"}
|
|
{"Action":"output","Package":"a","Test":"TestHang","Output":"goroutine 7 [running]:\n"}
|
|
{"Action":"fail","Package":"a","Elapsed":1.0}
|
|
`
|
|
got := feed(t, events)
|
|
for _, want := range []string{
|
|
"--- UNFINISHED: a.TestHang",
|
|
"--- UNFINISHED: a.TestSilent",
|
|
"==== panic in a (first 4 lines) ====",
|
|
"\t\tTestHang (1s)",
|
|
" === RUN TestHang",
|
|
} {
|
|
if !strings.Contains(got, want) {
|
|
t.Errorf("output lacks %q:\n%s", want, got)
|
|
}
|
|
}
|
|
if strings.Contains(got, " goroutine 7 [running]:") {
|
|
t.Errorf("goroutine dump leaked into the test's own output:\n%s", got)
|
|
}
|
|
}
|
|
|
|
func TestPanicInOnePackageKeepsOtherPackageOutput(t *testing.T) {
|
|
events := `
|
|
{"Action":"run","Package":"a","Test":"TestHang"}
|
|
{"Action":"output","Package":"a","Test":"TestHang","Output":"panic: test timed out after 1s\n"}
|
|
{"Action":"run","Package":"b","Test":"TestOther"}
|
|
{"Action":"output","Package":"b","Test":"TestOther","Output":" other_test.go:9: expected 1, got 2\n"}
|
|
{"Action":"output","Package":"a","Test":"TestHang","Output":"goroutine 7 [running]:\n"}
|
|
{"Action":"fail","Package":"b","Test":"TestOther","Elapsed":0.01}
|
|
{"Action":"fail","Package":"b","Elapsed":0.02}
|
|
{"Action":"fail","Package":"a","Elapsed":1.0}
|
|
`
|
|
got := feed(t, events)
|
|
if !strings.Contains(got, " other_test.go:9: expected 1, got 2") {
|
|
t.Errorf("other package's output was swallowed by the panic head:\n%s", got)
|
|
}
|
|
if strings.Contains(got, "panic in b") {
|
|
t.Errorf("panic head attributed to the wrong package:\n%s", got)
|
|
}
|
|
if !strings.Contains(got, "==== panic in a (first 2 lines) ====") {
|
|
t.Errorf("panic head missing for package a:\n%s", got)
|
|
}
|
|
}
|
|
|
|
func TestStoreSetupTimeIsAttributedToTheTest(t *testing.T) {
|
|
events := `
|
|
{"Action":"run","Package":"a","Test":"TestStore"}
|
|
{"Action":"output","Package":"a","Test":"TestStore","Output":"level=info msg=\"test store created: engine=mysql total=1.5s sqlite=100ms engine_setup=1.4s\"\n"}
|
|
{"Action":"output","Package":"a","Test":"TestStore","Output":"level=info msg=\"test store created: engine=mysql total=500ms sqlite=100ms engine_setup=400ms\"\n"}
|
|
{"Action":"pass","Package":"a","Test":"TestStore","Elapsed":2.5}
|
|
{"Action":"pass","Package":"a","Elapsed":2.6}
|
|
`
|
|
got := feed(t, events)
|
|
if !strings.Contains(got, "a.TestStore [stores: 2, 2s]") {
|
|
t.Errorf("store setup not aggregated:\n%s", got)
|
|
}
|
|
}
|
|
|
|
func TestBuildFailureShowsCompilerOutput(t *testing.T) {
|
|
events := `
|
|
{"Action":"build-output","ImportPath":"a [a.test]","Output":"# a [a.test]\n"}
|
|
{"Action":"build-output","ImportPath":"a [a.test]","Output":"a_test.go:7:2: undefined: nope\n"}
|
|
{"Action":"build-fail","ImportPath":"a [a.test]"}
|
|
`
|
|
got := feed(t, events)
|
|
for _, want := range []string{
|
|
"FAIL a 0s",
|
|
"==== output of a outside tests ====",
|
|
" a_test.go:7:2: undefined: nope",
|
|
} {
|
|
if !strings.Contains(got, want) {
|
|
t.Errorf("output lacks %q:\n%s", want, got)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestPassingPackageOutputIsNotPrinted(t *testing.T) {
|
|
events := `
|
|
{"Action":"output","Package":"a","Output":"level=info msg=\"noise between tests\"\n"}
|
|
{"Action":"pass","Package":"a","Elapsed":0.5}
|
|
`
|
|
got := feed(t, events)
|
|
if strings.Contains(got, "noise between tests") {
|
|
t.Errorf("package output of a passing package should stay quiet:\n%s", got)
|
|
}
|
|
}
|