mirror of
https://github.com/netbirdio/netbird.git
synced 2026-09-18 20:59:07 +02:00
Zoltán Papp
00e66b5dd4
The update manager started in download-only mode and every engine stop reset it there again, kicking the update loop with the cached latest version. On a managed peer this published a "New version available" notification on each disconnect, session expiry or logout, and once more in the window between daemon start and the first network map. Users under enforced updates then installed the release by hand. Replace the boolean with a three-state mode. The manager starts undecided and publishes nothing, from the fetcher or from NotifyUI, until the network map picks download-only or managed. A new connection lifecycle resets to undecided; disconnects leave the last decision untouched. A missing AutoUpdateSettings now means download-only instead of a no-op, and on platforms without an installer SetVersion falls back to download-only so they keep notifying.
90 lines
2.6 KiB
Go
90 lines
2.6 KiB
Go
package updater
|
|
|
|
import (
|
|
"context"
|
|
"path"
|
|
"testing"
|
|
"time"
|
|
|
|
v "github.com/hashicorp/go-version"
|
|
|
|
"github.com/netbirdio/netbird/client/internal/peer"
|
|
"github.com/netbirdio/netbird/client/internal/statemanager"
|
|
)
|
|
|
|
func Test_UndecidedMode_SuppressesNotification(t *testing.T) {
|
|
tmpFile := path.Join(t.TempDir(), "update-test-undecided.json")
|
|
recorder := peer.NewRecorder("")
|
|
sub := recorder.SubscribeToEvents()
|
|
defer recorder.UnsubscribeFromEvents(sub)
|
|
|
|
mockUpdate := &versionUpdateMock{latestVersion: v.Must(v.NewSemver("1.0.1"))}
|
|
m := NewManager(recorder, statemanager.New(tmpFile))
|
|
m.update = mockUpdate
|
|
m.currentVersion = "1.0.0"
|
|
m.Start(context.Background())
|
|
defer m.Stop()
|
|
|
|
mockUpdate.onUpdate()
|
|
if ver, _ := waitForUpdateEvent(sub, 300*time.Millisecond); ver != "" {
|
|
t.Fatalf("undecided mode must not publish, got %q", ver)
|
|
}
|
|
|
|
m.NotifyUI()
|
|
if ver, _ := waitForUpdateEvent(sub, 300*time.Millisecond); ver != "" {
|
|
t.Fatalf("NotifyUI in undecided mode must not publish, got %q", ver)
|
|
}
|
|
|
|
m.SetDownloadOnly()
|
|
ver, enforced := waitForUpdateEvent(sub, 500*time.Millisecond)
|
|
if ver != "1.0.1" {
|
|
t.Fatalf("expected download-only event for 1.0.1, got %q", ver)
|
|
}
|
|
if enforced {
|
|
t.Error("download-only event must not carry enforced metadata")
|
|
}
|
|
}
|
|
|
|
func Test_ResetMode_ReturnsToUndecided(t *testing.T) {
|
|
tmpFile := path.Join(t.TempDir(), "update-test-reset.json")
|
|
recorder := peer.NewRecorder("")
|
|
sub := recorder.SubscribeToEvents()
|
|
defer recorder.UnsubscribeFromEvents(sub)
|
|
|
|
mockUpdate := &versionUpdateMock{latestVersion: v.Must(v.NewSemver("1.0.1"))}
|
|
m := NewManager(recorder, statemanager.New(tmpFile))
|
|
m.update = mockUpdate
|
|
m.currentVersion = "1.0.0"
|
|
m.autoUpdateSupported = func() bool { return true }
|
|
m.Start(context.Background())
|
|
defer m.Stop()
|
|
|
|
m.SetVersion("1.0.1", false)
|
|
ver, enforced := waitForUpdateEvent(sub, 500*time.Millisecond)
|
|
if ver != "1.0.1" || !enforced {
|
|
t.Fatalf("expected enforced event for 1.0.1, got %q enforced=%v", ver, enforced)
|
|
}
|
|
|
|
m.ResetMode()
|
|
|
|
mockUpdate.onUpdate()
|
|
if ver, _ := waitForUpdateEvent(sub, 300*time.Millisecond); ver != "" {
|
|
t.Fatalf("reset mode must not publish on fetch, got %q", ver)
|
|
}
|
|
|
|
m.NotifyUI()
|
|
if ver, _ := waitForUpdateEvent(sub, 300*time.Millisecond); ver != "" {
|
|
t.Fatalf("NotifyUI after reset must not publish, got %q", ver)
|
|
}
|
|
|
|
if err := m.Install(context.Background()); err == nil {
|
|
t.Fatal("Install after reset must fail without a pending version")
|
|
}
|
|
|
|
m.SetVersion("1.0.1", false)
|
|
ver, enforced = waitForUpdateEvent(sub, 500*time.Millisecond)
|
|
if ver != "1.0.1" || !enforced {
|
|
t.Fatalf("expected enforced event again after reset, got %q enforced=%v", ver, enforced)
|
|
}
|
|
}
|