mirror of
https://github.com/netbirdio/netbird.git
synced 2026-09-08 16:01:29 +02:00
2af67c7023
Wails v3 builds on GTK4/WebKitGTK 6.0 by default, but distros that don't ship WebKitGTK 6.0 yet (Ubuntu 22.04, Debian 12, RHEL 9, Fedora <=39) can't install the GTK4 packages. Add a parallel legacy build via the -tags gtk3 path (removed upstream in Wails v3.1). The project's own XEmbed tray host links GTK4 and uses GTK4-only popup-menu APIs, so it can't compile against GTK3. Rather than port the ~150-line C menu layer, exclude it on gtk3 builds (!gtk3 constraint on xembed_host_linux.go + xembed_tray_linux.c) and add a pure-Go stub (xembed_host_gtk3_linux.go) where xembedTrayAvailable() returns false. The watcher probe then exits immediately, so the in-process XEmbed fallback is absent on gtk3 builds -- the tray still works on desktops that ship their own StatusNotifierWatcher, only the minimal-WM fallback is unavailable. goreleaser gains a netbird-ui-gtk3 build plus deb/rpm nfpm blocks (same netbird-ui package name, GTK3/WebKit2GTK 4.1 deps) routed to dedicated legacy repo paths. The release_ui CI job installs both dev stacks on the runner so goreleaser builds both Linux variants natively.
41 lines
1.7 KiB
Go
41 lines
1.7 KiB
Go
//go:build linux && gtk3 && !(linux && 386)
|
|
|
|
package main
|
|
|
|
import (
|
|
"errors"
|
|
|
|
"github.com/godbus/dbus/v5"
|
|
)
|
|
|
|
// The legacy GTK3 / WebKit2GTK 4.1 build (-tags gtk3) drops the in-process
|
|
// XEmbed StatusNotifierWatcher entirely. The real implementation
|
|
// (xembed_host_linux.go + xembed_tray_linux.c) links GTK4 and uses GTK4-only
|
|
// popup-menu APIs that have no drop-in GTK3 equivalent, so rather than port the
|
|
// C layer we stub the host out on gtk3 builds. The tray still works on every
|
|
// desktop that ships its own StatusNotifierWatcher (KDE, GNOME+AppIndicator,
|
|
// Cinnamon/xapp, XFCE, …); only the minimal-WM fallback (Fluxbox/OpenBox/i3/
|
|
// dwm/vanilla GNOME) is unavailable on gtk3 packages. See LINUX-TRAY.md.
|
|
|
|
// xembedHost is a placeholder so the package compiles on gtk3 builds; the real
|
|
// type (with X11/GTK4 state) lives in xembed_host_linux.go. It is never
|
|
// instantiated here because xembedTrayAvailable always reports false.
|
|
type xembedHost struct{}
|
|
|
|
// run satisfies the call in tray_watcher_linux.go; unreachable on gtk3 because
|
|
// newXembedHost never returns a non-nil host.
|
|
func (*xembedHost) run() {}
|
|
|
|
// xembedTrayAvailable always reports false on gtk3 builds, so the watcher probe
|
|
// loop in startStatusNotifierWatcher exits immediately and newXembedHost is
|
|
// never reached. recenter_linux.go's predicate becomes a harmless no-op too.
|
|
func xembedTrayAvailable() bool {
|
|
return false
|
|
}
|
|
|
|
// newXembedHost exists only to satisfy the reference in tray_watcher_linux.go;
|
|
// it is unreachable because xembedTrayAvailable returns false on gtk3.
|
|
func newXembedHost(conn *dbus.Conn, busName string, objPath dbus.ObjectPath) (*xembedHost, error) {
|
|
return nil, errors.New("xembed host unsupported on gtk3 build")
|
|
}
|