mirror of
https://github.com/netbirdio/netbird.git
synced 2026-07-20 23:41:28 +02:00
* [client] categorize root/system-mutating tests behind a privileged build tag Tests that need root or mutate host state (nftables/iptables/DNS, TUN/WireGuard interfaces, routes, eBPF, SSH/service install) are now gated behind a //go:build privileged tag. The default `go test ./client/...` runs as a non-root user with no sudo and leaves host networking untouched; mixed files were split so pure-logic tests stay in the default suite. A self-hosting ory/dockertest/v4 harness (client/testutil/privileged) runs the privileged suite inside a --privileged --cap-add=NET_ADMIN container via `make test-privileged`; a DOCKER_CI=true guard skips the spawn when already inside the container. Added `make test-unit` for the host-safe run. * [client] add PRIV_RUN/PRIV_PKGS filters to the privileged test harness The dockertest harness now reads two optional env vars when building the in-container `go test` command: PRIV_RUN adds a -run test-name filter and PRIV_PKGS overrides the package list. Both empty reproduce the full privileged suite, so CI and `make test-privileged` behave as before. Lets a developer run a single privileged test in the container, e.g.: PRIV_RUN=TestNftablesManager PRIV_PKGS=./client/firewall/nftables/... make test-privileged * [client] fix unused-helper lint after the privileged test split Splitting privileged tests into *_privileged_test.go left their shared helpers in the untagged files, so in the default (no-tag) build they had no callers and golangci-lint flagged them as unused. Moved the privileged-only helpers into the privileged files next to their callers (generateDummyHandler; createEngine/startSignal/startManagement/getConnectedPeers/ getPeers + kaep/kasp; (*mockDaemon).setJWTToken). Annotated the shared routing-test fixtures that must stay untagged for cross-platform compilation with //nolint:unused (systemops_bsd expected* vars, ensureIPv6DefaultRoute on bsd/windows, loopbackIfaceWindows), matching the existing linux variant. * [client] fix privileged test CI failures and run the harness on macOS The host-safe unit run dropped sudo but two privileged test groups were never tagged, and the Docker privileged job silently never ran the suite: - Gate the ssh/server PrivilegeDropper command-construction tests behind the privileged tag (they require root to target a different UID); split them into executor_unix_privileged_test.go. - Tag sharedsock raw-socket tests privileged (need CAP_NET_RAW). - Fix the Docker job command: nested single quotes around the build tags closed the sh -c wrapper early, dropping the go list package set and the privileged tag, so go test ran on the empty repo root. Use double quotes. Make the self-hosting harness usable from a dev Mac: - Build it on darwin as well as linux; it only drives Docker. - Resolve the active docker context endpoint into DOCKER_HOST when the default /var/run/docker.sock is absent (Docker Desktop, Colima, OrbStack). - Rename the misspelled containerGoModache constant to containerGoModCache. * Update client/internal/engine_privileged_test.go Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update client/internal/routemanager/systemops/systemops_linux_test.go Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update client/internal/routemanager/systemops/systemops_windows_test.go Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update client/server/server_privileged_test.go Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * [ci] Run privileged-tagged tests on darwin, windows and freebsd The privileged build tag split moved root/system-mutating tests behind //go:build privileged, but only the linux docker job was given the tag. The native darwin (sudo), windows (PsExec64 -s) and freebsd VM runners already have the required privileges, so add the privileged tag there too to keep CI running the same set of tests as before the split. * [ci] Exclude dockertest harness from the darwin privileged run The privileged tag now compiles client/testutil/privileged on darwin, whose TestRunPrivilegedSuiteInDocker spawns a container the macOS runner has no Docker for. Exclude the harness package from the darwin list, matching the linux job, so the privileged tests run in place without a container spawn. --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
192 lines
5.1 KiB
Go
192 lines
5.1 KiB
Go
//go:build (darwin || dragonfly || freebsd || netbsd || openbsd) && privileged
|
|
|
|
package systemops
|
|
|
|
import (
|
|
"fmt"
|
|
"net"
|
|
"net/netip"
|
|
"os/exec"
|
|
"regexp"
|
|
"runtime"
|
|
"strings"
|
|
"sync"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func init() {
|
|
testCases = append(testCases, []testCase{
|
|
{
|
|
name: "To more specific route without custom dialer via vpn",
|
|
expectedInterface: expectedVPNint,
|
|
dialer: &net.Dialer{},
|
|
expectedPacket: createPacketExpectation("100.64.0.1", 12345, "10.10.0.2", 53),
|
|
},
|
|
}...)
|
|
}
|
|
|
|
func TestConcurrentRoutes(t *testing.T) {
|
|
baseIP := netip.MustParseAddr("192.0.2.0")
|
|
|
|
var intf *net.Interface
|
|
var nexthop Nexthop
|
|
|
|
_, intf = setupDummyInterface(t)
|
|
nexthop = Nexthop{netip.Addr{}, intf}
|
|
|
|
r := New(nil, nil)
|
|
|
|
var wg sync.WaitGroup
|
|
for i := 0; i < 1024; i++ {
|
|
wg.Add(1)
|
|
go func(ip netip.Addr) {
|
|
defer wg.Done()
|
|
prefix := netip.PrefixFrom(ip, 32)
|
|
if err := r.addToRouteTable(prefix, nexthop); err != nil {
|
|
t.Errorf("Failed to add route for %s: %v", prefix, err)
|
|
}
|
|
}(baseIP)
|
|
baseIP = baseIP.Next()
|
|
}
|
|
|
|
wg.Wait()
|
|
|
|
baseIP = netip.MustParseAddr("192.0.2.0")
|
|
|
|
for i := 0; i < 1024; i++ {
|
|
wg.Add(1)
|
|
go func(ip netip.Addr) {
|
|
defer wg.Done()
|
|
prefix := netip.PrefixFrom(ip, 32)
|
|
if err := r.removeFromRouteTable(prefix, nexthop); err != nil {
|
|
t.Errorf("Failed to remove route for %s: %v", prefix, err)
|
|
}
|
|
}(baseIP)
|
|
baseIP = baseIP.Next()
|
|
}
|
|
|
|
wg.Wait()
|
|
}
|
|
|
|
func createAndSetupDummyInterface(t *testing.T, intf string, ipAddressCIDR string) string {
|
|
t.Helper()
|
|
|
|
if runtime.GOOS == "darwin" {
|
|
err := exec.Command("ifconfig", intf, "alias", ipAddressCIDR).Run()
|
|
require.NoError(t, err, "Failed to create loopback alias")
|
|
|
|
t.Cleanup(func() {
|
|
err := exec.Command("ifconfig", intf, ipAddressCIDR, "-alias").Run()
|
|
assert.NoError(t, err, "Failed to remove loopback alias")
|
|
})
|
|
|
|
return intf
|
|
}
|
|
|
|
prefix, err := netip.ParsePrefix(ipAddressCIDR)
|
|
require.NoError(t, err, "Failed to parse prefix")
|
|
|
|
netIntf, err := net.InterfaceByName(intf)
|
|
require.NoError(t, err, "Failed to get interface by name")
|
|
|
|
nexthop := Nexthop{netip.Addr{}, netIntf}
|
|
|
|
r := New(nil, nil)
|
|
err = r.addToRouteTable(prefix, nexthop)
|
|
require.NoError(t, err, "Failed to add route to table")
|
|
|
|
t.Cleanup(func() {
|
|
err := r.removeFromRouteTable(prefix, nexthop)
|
|
assert.NoError(t, err, "Failed to remove route from table")
|
|
})
|
|
|
|
return intf
|
|
}
|
|
|
|
func addDummyRoute(t *testing.T, dstCIDR string, gw netip.Addr, _ string) {
|
|
t.Helper()
|
|
|
|
var originalNexthop net.IP
|
|
if dstCIDR == "0.0.0.0/0" {
|
|
var err error
|
|
originalNexthop, err = fetchOriginalGateway()
|
|
if err != nil {
|
|
t.Logf("Failed to fetch original gateway: %v", err)
|
|
}
|
|
|
|
if output, err := exec.Command("route", "delete", "-net", dstCIDR).CombinedOutput(); err != nil {
|
|
t.Logf("Failed to delete route: %v, output: %s", err, output)
|
|
}
|
|
}
|
|
|
|
t.Cleanup(func() {
|
|
if originalNexthop != nil {
|
|
err := exec.Command("route", "add", "-net", dstCIDR, originalNexthop.String()).Run()
|
|
assert.NoError(t, err, "Failed to restore original route")
|
|
}
|
|
})
|
|
|
|
err := exec.Command("route", "add", "-net", dstCIDR, gw.String()).Run()
|
|
require.NoError(t, err, "Failed to add route")
|
|
|
|
t.Cleanup(func() {
|
|
err := exec.Command("route", "delete", "-net", dstCIDR).Run()
|
|
assert.NoError(t, err, "Failed to remove route")
|
|
})
|
|
}
|
|
|
|
func fetchOriginalGateway() (net.IP, error) {
|
|
output, err := exec.Command("route", "-n", "get", "default").CombinedOutput()
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
matches := regexp.MustCompile(`gateway: (\S+)`).FindStringSubmatch(string(output))
|
|
if len(matches) == 0 {
|
|
return nil, fmt.Errorf("gateway not found")
|
|
}
|
|
|
|
return net.ParseIP(matches[1]), nil
|
|
}
|
|
|
|
// setupDummyInterface creates a dummy tun interface for FreeBSD route testing
|
|
func setupDummyInterface(t *testing.T) (netip.Addr, *net.Interface) {
|
|
t.Helper()
|
|
|
|
if runtime.GOOS == "darwin" {
|
|
return netip.AddrFrom4([4]byte{192, 168, 1, 2}), &net.Interface{Name: "lo0"}
|
|
}
|
|
|
|
output, err := exec.Command("ifconfig", "tun", "create").CombinedOutput()
|
|
require.NoError(t, err, "Failed to create tun interface: %s", string(output))
|
|
|
|
tunName := strings.TrimSpace(string(output))
|
|
|
|
output, err = exec.Command("ifconfig", tunName, "192.168.1.1", "netmask", "255.255.0.0", "192.168.1.2", "up").CombinedOutput()
|
|
require.NoError(t, err, "Failed to configure tun interface: %s", string(output))
|
|
|
|
intf, err := net.InterfaceByName(tunName)
|
|
require.NoError(t, err, "Failed to get interface by name")
|
|
|
|
t.Cleanup(func() {
|
|
if err := exec.Command("ifconfig", tunName, "destroy").Run(); err != nil {
|
|
t.Logf("Failed to destroy tun interface %s: %v", tunName, err)
|
|
}
|
|
})
|
|
|
|
return netip.AddrFrom4([4]byte{192, 168, 1, 2}), intf
|
|
}
|
|
|
|
func setupDummyInterfacesAndRoutes(t *testing.T) {
|
|
t.Helper()
|
|
|
|
defaultDummy := createAndSetupDummyInterface(t, expectedExternalInt, "192.168.0.1/24")
|
|
addDummyRoute(t, "0.0.0.0/0", netip.AddrFrom4([4]byte{192, 168, 0, 1}), defaultDummy)
|
|
|
|
otherDummy := createAndSetupDummyInterface(t, expectedInternalInt, "192.168.1.1/24")
|
|
addDummyRoute(t, "10.0.0.0/8", netip.AddrFrom4([4]byte{192, 168, 1, 1}), otherDummy)
|
|
}
|