mirror of
https://github.com/netbirdio/netbird.git
synced 2026-09-08 16:01:29 +02:00
825389818c
* Gather fresh system info on every management sync stream connect The engine collected the peer meta once at start and reused the same Info for every Sync stream reconnect, so a mobile network switch that redials management kept reporting the old local network addresses. The peer network range posture check was then evaluated against stale data until the client restarted. Sync now takes a gatherer that runs at each stream connect. The gatherer is cheap: GetInfo plus the cached posture check file results, kept in the new system.InfoSource, which the engine refreshes whenever the checks list changes. No process enumeration runs on the reconnect path. Also fix the management mock server calling itself instead of SyncFunc. * Evaluate the login response posture checks before the first sync connect The engine starts with the checks the login response carried, and the first sync stream request used to send their evaluated file results. After moving the gather into InfoSource, the stream opened with an empty cache and the first sync response did not refill it, because its checks equal the ones the engine already holds. Desktop peers therefore never reported process or file posture results. Seed the cache once before the first connect, where the old gather ran, so a timed out evaluation still falls through to the address-only info. * Harden the sync info source against nil callbacks and shared slices A nil getInfo opens the stream without metadata, as a nil sysInfo did before. The cached posture results are a copy, so the Info returned by Refresh cannot alias the snapshot later Current calls report. The exclusion test asserts the remaining address count so it cannot pass vacuously on a single-address host. * Retry a posture check refresh that timed out or failed to sync The checks list was recorded before the gather ran, so once the gather timed out or SyncMeta failed, the next sync response carrying the same list matched the recorded one and nothing retried. The peer kept reporting the previous posture results until the list changed again. Record the checks only after the meta reached management, so a failed cycle is repeated on the next sync response. * Log the skipped posture refresh, let the mock Sync return errors and deflake the reconnect test * Drop the nil guard around the sync info callback * Send the refreshed info on the first sync connect instead of gathering it twice
39 lines
1.1 KiB
Go
39 lines
1.1 KiB
Go
package system
|
|
|
|
import (
|
|
"context"
|
|
"net/netip"
|
|
"slices"
|
|
"sync/atomic"
|
|
"time"
|
|
|
|
"github.com/netbirdio/netbird/shared/management/proto"
|
|
)
|
|
|
|
// InfoSource gathers the system info sent to management, keeping the posture
|
|
// check results from the last Refresh for the cheap Current snapshots.
|
|
type InfoSource struct {
|
|
files atomic.Pointer[[]File]
|
|
}
|
|
|
|
// Refresh gathers the info with the posture checks evaluated, bounded by timeout.
|
|
func (s *InfoSource) Refresh(ctx context.Context, timeout time.Duration, checks []*proto.Checks, excludeIPs ...netip.Addr) (*Info, bool) {
|
|
info, ok := GetInfoWithChecksTimeout(ctx, timeout, checks, excludeIPs...)
|
|
if !ok {
|
|
return nil, false
|
|
}
|
|
files := slices.Clone(info.Files)
|
|
s.files.Store(&files)
|
|
return info, true
|
|
}
|
|
|
|
// Current gathers the info without evaluating the checks, reusing the last Refresh results.
|
|
func (s *InfoSource) Current(ctx context.Context, excludeIPs ...netip.Addr) *Info {
|
|
info := GetInfo(ctx)
|
|
info.removeAddresses(excludeIPs...)
|
|
if files := s.files.Load(); files != nil {
|
|
info.Files = *files
|
|
}
|
|
return info
|
|
}
|