mirror of
https://github.com/netbirdio/netbird.git
synced 2026-09-13 02:09:08 +02:00
Maycon Santos
b789ffbb9f
Prevent unvalidated registrations from reserving domain names indefinitely. Give pending registrations a 48-hour validation window and clean up expired entries at startup and every 60 minutes. Emit CustomDomainValidationExpired for each deletion and preserve registrations referenced by services. Reject validation after expiry and prevent concurrent validation from recreating deleted registrations. Normalize domain names with the shared parser before registration. Migrate existing pending registrations to receive a fresh 48-hour validation window.
45 lines
2.1 KiB
Go
45 lines
2.1 KiB
Go
package migration_test
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/netbirdio/netbird/management/internals/modules/reverseproxy/domain"
|
|
"github.com/netbirdio/netbird/management/server/migration"
|
|
)
|
|
|
|
func TestMigrateCustomDomainValidationExpiry(t *testing.T) {
|
|
db := setupDatabase(t)
|
|
require.NoError(t, db.AutoMigrate(&domain.Domain{}))
|
|
t.Cleanup(func() { require.NoError(t, db.Migrator().DropTable(&domain.Domain{})) })
|
|
ctx := context.Background()
|
|
existingDeadline := time.Now().UTC().Add(time.Hour).Truncate(time.Second)
|
|
rows := []domain.Domain{
|
|
{ID: "legacy", Domain: "legacy.example.com"},
|
|
{ID: "validated", Domain: "validated.example.com", Validated: true},
|
|
{ID: "pending", Domain: "pending.example.com", ValidationExpiresAt: &existingDeadline},
|
|
}
|
|
require.NoError(t, db.Create(&rows).Error)
|
|
before := time.Now().UTC()
|
|
require.NoError(t, migration.MigrateCustomDomainValidationExpiry(ctx, db))
|
|
after := time.Now().UTC()
|
|
var migrated domain.Domain
|
|
require.NoError(t, db.First(&migrated, "id = ?", "legacy").Error)
|
|
require.NotNil(t, migrated.ValidationExpiresAt)
|
|
assert.WithinRange(t, *migrated.ValidationExpiresAt, before.Truncate(time.Millisecond).Add(48*time.Hour), after.Add(48*time.Hour+time.Millisecond), "legacy pending registrations get a full window")
|
|
deadline := *migrated.ValidationExpiresAt
|
|
require.NoError(t, migration.MigrateCustomDomainValidationExpiry(ctx, db))
|
|
require.NoError(t, db.First(&migrated, "id = ?", "legacy").Error)
|
|
assert.Equal(t, deadline, *migrated.ValidationExpiresAt, "repeated migration must not extend the deadline")
|
|
var validated, pending domain.Domain
|
|
require.NoError(t, db.First(&validated, "id = ?", "validated").Error)
|
|
require.NoError(t, db.First(&pending, "id = ?", "pending").Error)
|
|
assert.Nil(t, validated.ValidationExpiresAt, "validated domains do not acquire an expiry")
|
|
require.NotNil(t, pending.ValidationExpiresAt)
|
|
assert.WithinDuration(t, existingDeadline, *pending.ValidationExpiresAt, 0, "existing deadlines must be preserved")
|
|
}
|