From fcb06d1a235fe54fb801a0be6f5b1b02ffca04d9 Mon Sep 17 00:00:00 2001 From: Zoltan Papp Date: Wed, 16 Jul 2025 21:16:07 +0200 Subject: [PATCH] Revert error handling behaviour in test to support auto net.Conn creation --- relay/client/client_test.go | 4 ++-- relay/client/manager_test.go | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/relay/client/client_test.go b/relay/client/client_test.go index 089c7ed4c..275624df4 100644 --- a/relay/client/client_test.go +++ b/relay/client/client_test.go @@ -314,8 +314,8 @@ func TestBindToUnavailabePeer(t *testing.T) { t.Errorf("failed to connect to server: %s", err) } _, err = clientAlice.OpenConn(ctx, "bob") - if err == nil { - t.Errorf("expected error when binding to unavailable peer, got nil") + if err != nil { + t.Errorf("failed to open bob: %s", err) } log.Infof("closing client") diff --git a/relay/client/manager_test.go b/relay/client/manager_test.go index 52f2833e4..20a784a25 100644 --- a/relay/client/manager_test.go +++ b/relay/client/manager_test.go @@ -285,15 +285,15 @@ func TestForeginAutoClose(t *testing.T) { } t.Log("open connection to another peer") - if _, err = mgr.OpenConn(ctx, toURL(srvCfg2)[0], "anotherpeer"); err == nil { - t.Fatalf("should have failed to open connection to another peer") + if _, err = mgr.OpenConn(ctx, toURL(srvCfg2)[0], "anotherpeer"); err != nil { + t.Fatalf("failed to open connection: %s", err) } timeout := relayCleanupInterval + keepUnusedServerTime + 1*time.Second t.Logf("waiting for relay cleanup: %s", timeout) time.Sleep(timeout) - if len(mgr.relayClients) != 0 { - t.Errorf("expected 0, got %d", len(mgr.relayClients)) + if len(mgr.relayClients) != 1 { + t.Errorf("expected 1 relay client, got %d", len(mgr.relayClients)) } t.Logf("closing manager")