sendnrw/netbird
2
0
Fork 0
mirror of https://github.com/netbirdio/netbird.git synced 2026-04-23 02:36:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix sonar issue

Browse Source
This commit is contained in:
Zoltán Papp
2025-09-29 21:36:04 +02:00
parent 52f4290be6
commit f9992c3ac8
1 changed files with 13 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
client/internal/peer/signaler.go
View File

@@ -86,15 +86,7 @@ func (s *Signaler) signalOfferAnswer(offerAnswer OfferAnswer, remoteKey string,
case errors.Is(err, signal.ErrPeerNotAvailable): case errors.Is(err, signal.ErrPeerNotAvailable):
return ErrPeerNotAvailable return ErrPeerNotAvailable
case errors.Is(err, signal.ErrUnimplementedMethod): case errors.Is(err, signal.ErrUnimplementedMethod):
// print out the warning only once s.handleUnimplementedMethod(msg)
if !s.deliveryCheckNotSupported.Load() {
log.Warnf("signal client does not support delivery check, falling back to Send method and resend")
}
s.deliveryCheckNotSupported.Store(true)
if err := s.signal.Send(msg); err != nil {
log.Warnf("failed to send signal msg to remote peer: %v", err)
}
return ErrSignalNotSupportDeliveryCheck return ErrSignalNotSupportDeliveryCheck
default: default:
return err return err
@@ -112,3 +104,15 @@ func (s *Signaler) SignalIdle(remoteKey string) error {
}, },
}) })
} }
func (s *Signaler) handleUnimplementedMethod(msg *sProto.Message) {
// print out the warning only once
if !s.deliveryCheckNotSupported.Load() {
log.Warnf("signal client does not support delivery check, falling back to Send method and resend")
}
s.deliveryCheckNotSupported.Store(true)
if err := s.signal.Send(msg); err != nil {
log.Warnf("failed to send signal msg to remote peer: %v", err)
}
}