sendnrw/netbird
2
0
Fork 0
mirror of https://github.com/netbirdio/netbird.git synced 2026-10-10 07:29:06 +02:00
Code Issues Packages Projects Releases Wiki Activity

[client] peer: correct the MlkemPort zero-value comment

Browse Source 
Zero is the normal advertisement for a peer on the default PQ port (the port is
omitted when it equals DefaultPort), not a signal that the peer does not run the
exchange. Document zero as "assume DefaultPort" and point to the payload /
capability state for whether ML-KEM is running.

Found in cubic review on #7098 (client/internal/peer/handshaker.go:49).
This commit is contained in:
riccardom
2026-10-09 09:50:47 +02:00
parent 25893d233c
commit f660e2e578
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
client/internal/peer/handshaker.go
+4 -2
View File
@@ -45,8 +45,10 @@ type OfferAnswer struct {
// when the peer does not run the ML-KEM PQ exchange.
MlkemPayload []byte
// MlkemPort is the peer's ML-KEM PQ service UDP port (bound on its WG overlay
// IP) where data-path rekey messages are sent. Zero when not running the exchange.
// MlkemPort is the peer's ML-KEM PQ service UDP port (bound on its WG overlay IP)
// where data-path rekey messages are sent. Zero means "not explicitly advertised,
// assume DefaultPort" — it does NOT indicate whether the peer runs the exchange;
// that is told by the presence of MlkemPayload / the manager's capability state.
MlkemPort uint16
// relay server address