[management] add flow settings and credentials (#3389)

management/server/settings/manager.go

@@ -2,36 +2,124 @@ package settings
 
 import (
 	"context"
+	"fmt"
 
+	"github.com/netbirdio/netbird/management/server/activity"
+	"github.com/netbirdio/netbird/management/server/integrations/extra_settings"
+	"github.com/netbirdio/netbird/management/server/status"
 	"github.com/netbirdio/netbird/management/server/store"
 	"github.com/netbirdio/netbird/management/server/types"
+	"github.com/netbirdio/netbird/management/server/users"
 )
 
 type Manager interface {
+	GetExtraSettingsManager() extra_settings.Manager
 	GetSettings(ctx context.Context, accountID string, userID string) (*types.Settings, error)
+	GetExtraSettings(ctx context.Context, accountID string) (*types.ExtraSettings, error)
+	UpdateExtraSettings(ctx context.Context, accountID string, extraSettings *types.ExtraSettings) error
 }
 
 type managerImpl struct {
-	store store.Store
+	store                store.Store
+	extraSettingsManager extra_settings.Manager
+	userManager          users.Manager
 }
 
-type managerMock struct {
+type ManagerMock struct {
+	GetSettingsFunc func(ctx context.Context, accountID, userID string) (*types.Settings, error)
 }
 
-func NewManager(store store.Store) Manager {
+func NewManager(store store.Store, userManager users.Manager, extraSettingsManager extra_settings.Manager) Manager {
 	return &managerImpl{
-		store: store,
+		store:                store,
+		extraSettingsManager: extraSettingsManager,
+		userManager:          userManager,
 	}
 }
 
-func (m *managerImpl) GetSettings(ctx context.Context, accountID string, userID string) (*types.Settings, error) {
-	return m.store.GetAccountSettings(ctx, store.LockingStrengthShare, accountID)
+func (m *managerImpl) GetExtraSettingsManager() extra_settings.Manager {
+	return m.extraSettingsManager
 }
 
-func NewManagerMock() Manager {
-	return &managerMock{}
+func (m *managerImpl) GetSettings(ctx context.Context, accountID, userID string) (*types.Settings, error) {
+	if userID != activity.SystemInitiator {
+		user, err := m.userManager.GetUser(ctx, userID)
+		if err != nil {
+			return nil, fmt.Errorf("get user: %w", err)
+		}
+
+		if user.AccountID != accountID || (!user.HasAdminPower() && !user.IsServiceUser) {
+			return nil, status.Errorf(status.PermissionDenied, "the user has no permission to access account data")
+		}
+	}
+
+	extraSettings, err := m.extraSettingsManager.GetExtraSettings(ctx, accountID)
+	if err != nil {
+		return nil, fmt.Errorf("get extra settings: %w", err)
+	}
+
+	settings, err := m.store.GetAccountSettings(ctx, store.LockingStrengthShare, accountID)
+	if err != nil {
+		return nil, fmt.Errorf("get account settings: %w", err)
+	}
+
+	// Once we migrate the peer approval to settings manager this merging is obsolete
+	if settings.Extra != nil {
+		settings.Extra.FlowEnabled = extraSettings.FlowEnabled
+	}
+
+	return settings, nil
 }
 
-func (m *managerMock) GetSettings(ctx context.Context, accountID string, userID string) (*types.Settings, error) {
+func (m *managerImpl) GetExtraSettings(ctx context.Context, accountID string) (*types.ExtraSettings, error) {
+	extraSettings, err := m.extraSettingsManager.GetExtraSettings(ctx, accountID)
+	if err != nil {
+		return nil, fmt.Errorf("get extra settings: %w", err)
+	}
+
+	settings, err := m.store.GetAccountSettings(ctx, store.LockingStrengthShare, accountID)
+	if err != nil {
+		return nil, fmt.Errorf("get account settings: %w", err)
+	}
+
+	// Once we migrate the peer approval to settings manager this merging is obsolete
+	if settings.Extra == nil {
+		settings.Extra = &types.ExtraSettings{}
+	}
+
+	settings.Extra.FlowEnabled = extraSettings.FlowEnabled
+
+	return settings.Extra, nil
+}
+
+func (m *managerImpl) UpdateExtraSettings(ctx context.Context, accountID string, extraSettings *types.ExtraSettings) error {
+	return m.extraSettingsManager.UpdateExtraSettings(ctx, accountID, extraSettings)
+}
+
+func NewManagerMock() *ManagerMock {
+	return &ManagerMock{}
+}
+
+func (m *ManagerMock) GetExtraSettingsManager() extra_settings.Manager {
+	return nil
+}
+
+func (m *ManagerMock) GetSettings(ctx context.Context, accountID, userID string) (*types.Settings, error) {
+	if m.GetSettingsFunc != nil {
+		return m.GetSettingsFunc(ctx, accountID, userID)
+	}
+
 	return &types.Settings{}, nil
 }
+
+func (m *ManagerMock) SetGetSettingsFunc(f func(ctx context.Context, accountID, userID string) (*types.Settings, error)) {
+	m.GetSettingsFunc = f
+}
+
+func (m *ManagerMock) GetExtraSettings(ctx context.Context, accountID string) (*types.ExtraSettings, error) {
+	return &types.ExtraSettings{}, nil
+}
+
+func (m *ManagerMock) UpdateExtraSettings(ctx context.Context, accountID string, extraSettings *types.ExtraSettings) error {
+	return nil
+}