From ee8739760d45a8095c35ad870c050cb73a017a82 Mon Sep 17 00:00:00 2001 From: Pascal Fischer Date: Tue, 14 Oct 2025 17:46:01 +0200 Subject: [PATCH] remove status attr and unused function --- management/server/store/sql_store.go | 7 +++---- management/server/telemetry/store_metrics.go | 15 +-------------- 2 files changed, 4 insertions(+), 18 deletions(-) diff --git a/management/server/store/sql_store.go b/management/server/store/sql_store.go index e7c601f29..d83fab552 100644 --- a/management/server/store/sql_store.go +++ b/management/server/store/sql_store.go @@ -1833,12 +1833,11 @@ func (s *SqlStore) trackStoreOperation(start time.Time, method string, err *erro if s.metrics == nil { return } - duration := time.Since(start) - status := "success" if err != nil && *err != nil { - status = "error" + return } - s.metrics.StoreMetrics().CountStoreOperation(method, status, duration) + duration := time.Since(start) + s.metrics.StoreMetrics().CountStoreOperation(method, duration) } } diff --git a/management/server/telemetry/store_metrics.go b/management/server/telemetry/store_metrics.go index cb38491af..752ea4817 100644 --- a/management/server/telemetry/store_metrics.go +++ b/management/server/telemetry/store_metrics.go @@ -106,23 +106,10 @@ func (metrics *StoreMetrics) CountTransactionDuration(duration time.Duration) { metrics.transactionDurationMs.Record(metrics.ctx, duration.Milliseconds()) } -// CountQuery records a database query operation with its duration, operation type, table, and status -func (metrics *StoreMetrics) CountQuery(operation, table, status string, duration time.Duration) { - attrs := []attribute.KeyValue{ - attribute.String("operation", operation), - attribute.String("table", table), - attribute.String("status", status), - } - - metrics.queryDurationMs.Record(metrics.ctx, duration.Milliseconds(), metric.WithAttributes(attrs...)) - metrics.queryCounter.Add(metrics.ctx, 1, metric.WithAttributes(attrs...)) -} - // CountStoreOperation records a store operation with its method name, status, and duration -func (metrics *StoreMetrics) CountStoreOperation(method, status string, duration time.Duration) { +func (metrics *StoreMetrics) CountStoreOperation(method string, duration time.Duration) { attrs := []attribute.KeyValue{ attribute.String("method", method), - attribute.String("status", status), } metrics.queryDurationMs.Record(metrics.ctx, duration.Milliseconds(), metric.WithAttributes(attrs...))