fix linter issues

This commit is contained in:
pascal
2026-02-12 01:02:13 +01:00
parent 1c7059ee67
commit e20b969188
9 changed files with 27 additions and 54 deletions

View File

@@ -86,7 +86,7 @@ func (p *ReverseProxy) ServeHTTP(w http.ResponseWriter, r *http.Request) {
ErrorHandler: proxyErrorHandler,
}
if result.rewriteRedirects {
rp.ModifyResponse = p.rewriteLocationFunc(result.url, result.matchedPath, r)
rp.ModifyResponse = p.rewriteLocationFunc(result.url, result.matchedPath, r) //nolint:bodyclose
}
rp.ServeHTTP(w, r.WithContext(ctx))
}

View File

@@ -572,6 +572,7 @@ func TestRewriteLocationFunc(t *testing.T) {
"http://backend.internal:8080/login")
require.NoError(t, err)
defer resp.Body.Close()
assert.Equal(t, "https://public.example.com/login", resp.Header.Get("Location"))
})
@@ -580,6 +581,7 @@ func TestRewriteLocationFunc(t *testing.T) {
"https://other.example.com/path")
require.NoError(t, err)
defer resp.Body.Close()
assert.Equal(t, "https://other.example.com/path", resp.Header.Get("Location"))
})
@@ -588,12 +590,14 @@ func TestRewriteLocationFunc(t *testing.T) {
"/dashboard")
require.NoError(t, err)
defer resp.Body.Close()
assert.Equal(t, "/dashboard", resp.Header.Get("Location"))
})
t.Run("re-adds stripped path prefix", func(t *testing.T) {
resp, err := run(newProxy("https"), "/api", newReq("https://public.example.com/api/users"),
"http://backend.internal:8080/users")
defer resp.Body.Close()
require.NoError(t, err)
assert.Equal(t, "https://public.example.com/api/users", resp.Header.Get("Location"))