[management] use peer.Status.LastSeen field to detect stale peer.Status.Connected values (#7268)

management/server/peer/peer_test.go

@@ -4,6 +4,7 @@ import (
 	"fmt"
 	"net/netip"
 	"testing"
+	"time"
 
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
@@ -164,3 +165,22 @@ func TestPeerCapabilities(t *testing.T) {
 		})
 	}
 }
+
+func TestIsConnected(t *testing.T) {
+	tests := []struct {
+		name      string
+		connected bool
+		lastSeen  time.Time
+		want      bool
+	}{
+		{name: "connected and recently seen", connected: true, lastSeen: time.Now().Add(-time.Minute), want: true},
+		{name: "connected but not seen for longer than StaleAfter", connected: true, lastSeen: time.Now().Add(-StaleAfter - time.Minute)},
+		{name: "connected but never seen", connected: true},
+		{name: "disconnected and recently seen", lastSeen: time.Now()},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			assert.Equal(t, tt.want, IsConnected(tt.connected, tt.lastSeen))
+		})
+	}
+}