use testify assertions in cache store tests

management/server/cache/memory_test.go

@@ -5,47 +5,37 @@ import (
 	"testing"
 	"time"
 
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+
 	"github.com/netbirdio/netbird/management/server/cache"
 )
 
 func TestMemoryStore(t *testing.T) {
 	memStore, err := cache.NewStore(context.Background(), 100*time.Millisecond, 300*time.Millisecond, 100)
-	if err != nil {
+	require.NoError(t, err, "couldn't create memory store")
-		t.Fatalf("couldn't create memory store: %s", err)
+
-	}
 	ctx := context.Background()
 	key, value := "testing", "tested"
 	err = memStore.Set(ctx, key, value)
-	if err != nil {
+	assert.NoError(t, err, "couldn't set testing data")
-		t.Errorf("couldn't set testing data: %s", err)
+
-	}
 	result, err := memStore.Get(ctx, key)
-	if err != nil {
+	assert.NoError(t, err, "couldn't get testing data")
-		t.Errorf("couldn't get testing data: %s", err)
+	assert.Equal(t, value, result, "value returned doesn't match testing data")
-	}
+
-	if value != result.(string) {
+	created, err := memStore.SetNX(ctx, "conditional", value, 100*time.Millisecond)
-		t.Errorf("value returned doesn't match testing data, got %s, expected %s", result, value)
+	require.NoError(t, err, "couldn't conditionally set testing data")
-	}
+	require.True(t, created, "first conditional set should create the entry")
-	created, err := memStore.SetNX(ctx, "atomic", value, 100*time.Millisecond)
+
-	if err != nil {
+	created, err = memStore.SetNX(ctx, "conditional", value, 100*time.Millisecond)
-		t.Fatalf("couldn't atomically set testing data: %s", err)
+	require.NoError(t, err, "couldn't conditionally check testing data")
-	}
+	require.False(t, created, "second conditional set should not replace the entry")
-	if !created {
+
-		t.Fatal("first atomic set should create the entry")
-	}
-	created, err = memStore.SetNX(ctx, "atomic", value, 100*time.Millisecond)
-	if err != nil {
-		t.Fatalf("couldn't atomically check testing data: %s", err)
-	}
-	if created {
-		t.Fatal("second atomic set should not replace the entry")
-	}
 	// test expiration
 	time.Sleep(300 * time.Millisecond)
 	_, err = memStore.Get(ctx, key)
-	if err == nil {
+	assert.Error(t, err, "value should not be found")
-		t.Error("value should not be found")
-	}
 }
 
 func TestMemoryStoreGetDel(t *testing.T) {
@@ -53,9 +43,8 @@ func TestMemoryStoreGetDel(t *testing.T) {
 	newStore := func(t *testing.T) cache.Store {
 		t.Helper()
 		memStore, err := cache.NewStore(ctx, time.Minute, time.Minute, 100)
-		if err != nil {
+		require.NoError(t, err, "couldn't create memory store")
-			t.Fatalf("couldn't create memory store: %s", err)
+
-		}
 		return memStore
 	}
 
@@ -66,9 +55,7 @@ func TestMemoryStoreGetDel(t *testing.T) {
 
 	t.Run("exactly one concurrent caller consumes the key", func(t *testing.T) {
 		memStore := newStore(t)
-		if err := memStore.Set(ctx, key, value); err != nil {
+		require.NoError(t, memStore.Set(ctx, key, value), "couldn't set testing data")
-			t.Fatalf("couldn't set testing data: %s", err)
-		}
 
 		assertGetDelConsumedOnce(ctx, t, []cache.Store{memStore}, key, value)
 		assertGetDelMisses(ctx, t, memStore, key)
@@ -80,9 +67,8 @@ func TestMemoryStoreGetDel(t *testing.T) {
 
 	t.Run("expired key is not found", func(t *testing.T) {
 		memStore := newStore(t)
-		if _, err := memStore.SetNX(ctx, key, value, 50*time.Millisecond); err != nil {
+		_, err := memStore.SetNX(ctx, key, value, 50*time.Millisecond)
-			t.Fatalf("couldn't set testing data: %s", err)
+		require.NoError(t, err, "couldn't set testing data")
-		}
 
 		time.Sleep(100 * time.Millisecond)
 		assertGetDelMisses(ctx, t, memStore, key)

management/server/cache/redis_test.go

@@ -7,6 +7,7 @@ import (
 
 	"github.com/eko/gocache/lib/v4/store"
 	"github.com/redis/go-redis/v9"
+	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 	testcontainersredis "github.com/testcontainers/testcontainers-go/modules/redis"
 
@@ -45,9 +46,7 @@ func newRedisStore(t *testing.T) cache.Store {
 func TestRedisStoreConnectionFailure(t *testing.T) {
 	t.Setenv(cache.RedisStoreEnvVar, "redis://127.0.0.1:6379")
 	_, err := cache.NewStore(context.Background(), 10*time.Millisecond, 30*time.Millisecond, 100)
-	if err == nil {
+	require.Error(t, err, "getting redis cache store should return error")
-		t.Fatal("getting redis cache store should return error")
-	}
 }
 
 func TestRedisStoreConnectionSuccess(t *testing.T) {
@@ -57,37 +56,24 @@ func TestRedisStoreConnectionSuccess(t *testing.T) {
 
 	key, value := "testing", "tested"
 	err := redisStore.Set(ctx, key, value, store.WithExpiration(100*time.Millisecond))
-	if err != nil {
+	assert.NoError(t, err, "couldn't set testing data")
-		t.Errorf("couldn't set testing data: %s", err)
+
-	}
 	result, err := redisStore.Get(ctx, key)
-	if err != nil {
+	assert.NoError(t, err, "couldn't get testing data")
-		t.Errorf("couldn't get testing data: %s", err)
+	assert.Equal(t, value, result, "value returned doesn't match testing data")
-	}
-	if value != result.(string) {
-		t.Errorf("value returned doesn't match testing data, got %s, expected %s", result, value)
-	}
 
 	options, err := redis.ParseURL(redisURL)
-	if err != nil {
+	require.NoError(t, err, "parsing redis cache url")
-		t.Errorf("parsing redis cache url: %s", err)
-	}
 
 	redisClient := redis.NewClient(options)
-	r, e := redisClient.Get(ctx, key).Result()
+	r, err := redisClient.Get(ctx, key).Result()
-	if e != nil {
+	assert.NoError(t, err, "couldn't get testing data from redis")
-		t.Errorf("couldn't get testing data from redis: %s", e)
+	assert.Equal(t, value, r, "value returned from redis doesn't match testing data")
-	}
-	if value != r {
-		t.Errorf("value returned from redis doesn't match testing data, got %s, expected %s", r, value)
-	}
 
 	// test expiration
 	time.Sleep(300 * time.Millisecond)
 	_, err = redisStore.Get(ctx, key)
-	if err == nil {
+	assert.Error(t, err, "value should not be found")
-		t.Error("value should not be found")
-	}
 }
 
 func TestRedisStoreSetNX(t *testing.T) {
@@ -96,7 +82,7 @@ func TestRedisStoreSetNX(t *testing.T) {
 	redisStore, secondRedisStore := newRedisStore(t), newRedisStore(t)
 
 	const (
-		key   = "atomic"
+		key   = "conditional"
 		value = "tested"
 	)
 
@@ -118,28 +104,19 @@ func TestRedisStoreSetNX(t *testing.T) {
 	created := 0
 	for range 2 {
 		result := <-results
-		if result.err != nil {
+		require.NoError(t, result.err, "conditional redis set failed")
-			t.Fatalf("atomic redis set failed: %s", result.err)
-		}
 		if result.created {
 			created++
 		}
 	}
-	if created != 1 {
+	require.Equal(t, 1, created, "expected exactly one redis client to create the entry")
-		t.Fatalf("expected exactly one redis client to create the entry, got %d", created)
-	}
 
 	options, err := redis.ParseURL(redisURL)
-	if err != nil {
+	require.NoError(t, err, "parsing redis cache url")
-		t.Fatalf("parsing redis cache url: %s", err)
+
-	}
 	ttl, err := redis.NewClient(options).PTTL(ctx, key).Result()
-	if err != nil {
+	require.NoError(t, err, "couldn't read entry TTL")
-		t.Fatalf("couldn't read atomic entry TTL: %s", err)
+	require.Positive(t, ttl, "created entry should have a positive TTL")
-	}
-	if ttl <= 0 {
-		t.Fatalf("atomic entry should have a positive TTL, got %s", ttl)
-	}
 }
 
 func TestRedisStoreGetDel(t *testing.T) {
@@ -155,9 +132,8 @@ func TestRedisStoreGetDel(t *testing.T) {
 	t.Run("exactly one caller across independent clients consumes the key", func(t *testing.T) {
 		// A generous TTL: the key is consumed explicitly, so expiry racing the
 		// concurrent callers would only make the test flaky on a loaded runner.
-		if err := redisStore.Set(ctx, key, value, store.WithExpiration(time.Minute)); err != nil {
+		err := redisStore.Set(ctx, key, value, store.WithExpiration(time.Minute))
-			t.Fatalf("couldn't set value to consume: %s", err)
+		require.NoError(t, err, "couldn't set value to consume")
-		}
 
 		assertGetDelConsumedOnce(ctx, t, []cache.Store{redisStore, secondRedisStore}, key, value)
 		assertGetDelMisses(ctx, t, secondRedisStore, key)
@@ -168,9 +144,8 @@ func TestRedisStoreGetDel(t *testing.T) {
 	})
 
 	t.Run("expired key is not found", func(t *testing.T) {
-		if err := redisStore.Set(ctx, key, value, store.WithExpiration(50*time.Millisecond)); err != nil {
+		err := redisStore.Set(ctx, key, value, store.WithExpiration(50*time.Millisecond))
-			t.Fatalf("couldn't set value to consume: %s", err)
+		require.NoError(t, err, "couldn't set value to consume")
-		}
 
 		time.Sleep(100 * time.Millisecond)
 		assertGetDelMisses(ctx, t, redisStore, key)