use testify assertions in cache store tests

This commit is contained in:
bcmmbaga
2026-08-06 22:27:22 +03:00
parent 99d0970f06
commit de6bf481e6
2 changed files with 46 additions and 85 deletions
+24 -38
View File
@@ -5,47 +5,37 @@ import (
"testing"
"time"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"github.com/netbirdio/netbird/management/server/cache"
)
func TestMemoryStore(t *testing.T) {
memStore, err := cache.NewStore(context.Background(), 100*time.Millisecond, 300*time.Millisecond, 100)
if err != nil {
t.Fatalf("couldn't create memory store: %s", err)
}
require.NoError(t, err, "couldn't create memory store")
ctx := context.Background()
key, value := "testing", "tested"
err = memStore.Set(ctx, key, value)
if err != nil {
t.Errorf("couldn't set testing data: %s", err)
}
assert.NoError(t, err, "couldn't set testing data")
result, err := memStore.Get(ctx, key)
if err != nil {
t.Errorf("couldn't get testing data: %s", err)
}
if value != result.(string) {
t.Errorf("value returned doesn't match testing data, got %s, expected %s", result, value)
}
created, err := memStore.SetNX(ctx, "atomic", value, 100*time.Millisecond)
if err != nil {
t.Fatalf("couldn't atomically set testing data: %s", err)
}
if !created {
t.Fatal("first atomic set should create the entry")
}
created, err = memStore.SetNX(ctx, "atomic", value, 100*time.Millisecond)
if err != nil {
t.Fatalf("couldn't atomically check testing data: %s", err)
}
if created {
t.Fatal("second atomic set should not replace the entry")
}
assert.NoError(t, err, "couldn't get testing data")
assert.Equal(t, value, result, "value returned doesn't match testing data")
created, err := memStore.SetNX(ctx, "conditional", value, 100*time.Millisecond)
require.NoError(t, err, "couldn't conditionally set testing data")
require.True(t, created, "first conditional set should create the entry")
created, err = memStore.SetNX(ctx, "conditional", value, 100*time.Millisecond)
require.NoError(t, err, "couldn't conditionally check testing data")
require.False(t, created, "second conditional set should not replace the entry")
// test expiration
time.Sleep(300 * time.Millisecond)
_, err = memStore.Get(ctx, key)
if err == nil {
t.Error("value should not be found")
}
assert.Error(t, err, "value should not be found")
}
func TestMemoryStoreGetDel(t *testing.T) {
@@ -53,9 +43,8 @@ func TestMemoryStoreGetDel(t *testing.T) {
newStore := func(t *testing.T) cache.Store {
t.Helper()
memStore, err := cache.NewStore(ctx, time.Minute, time.Minute, 100)
if err != nil {
t.Fatalf("couldn't create memory store: %s", err)
}
require.NoError(t, err, "couldn't create memory store")
return memStore
}
@@ -66,9 +55,7 @@ func TestMemoryStoreGetDel(t *testing.T) {
t.Run("exactly one concurrent caller consumes the key", func(t *testing.T) {
memStore := newStore(t)
if err := memStore.Set(ctx, key, value); err != nil {
t.Fatalf("couldn't set testing data: %s", err)
}
require.NoError(t, memStore.Set(ctx, key, value), "couldn't set testing data")
assertGetDelConsumedOnce(ctx, t, []cache.Store{memStore}, key, value)
assertGetDelMisses(ctx, t, memStore, key)
@@ -80,9 +67,8 @@ func TestMemoryStoreGetDel(t *testing.T) {
t.Run("expired key is not found", func(t *testing.T) {
memStore := newStore(t)
if _, err := memStore.SetNX(ctx, key, value, 50*time.Millisecond); err != nil {
t.Fatalf("couldn't set testing data: %s", err)
}
_, err := memStore.SetNX(ctx, key, value, 50*time.Millisecond)
require.NoError(t, err, "couldn't set testing data")
time.Sleep(100 * time.Millisecond)
assertGetDelMisses(ctx, t, memStore, key)