sendnrw/netbird
2
0
Fork 0
mirror of https://github.com/netbirdio/netbird.git synced 2026-10-05 21:19:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fail instead of skipping when the IPv4 sender socket cannot be created

Browse Source
This commit is contained in:
Viktor Liu
2026-08-25 13:45:22 +02:00
parent d87510604b
commit d71f2fd822
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
client/iface/wgproxy/rawsocket/rawsocket_privileged_test.go
+9 -3
View File
@@ -26,16 +26,22 @@ func TestSenderRawSocketsCarryNoFwmark(t *testing.T) {
tests := []struct { tests := []struct {
name string name string
prepare func() (net.PacketConn, error) prepare func() (net.PacketConn, error)
// the proxy treats the IPv6 socket as optional, so a host without IPv6
// is a reason to skip rather than to fail
optional bool
}{ }{
{"IPv4", PrepareSenderRawSocketIPv4}, {name: "IPv4", prepare: PrepareSenderRawSocketIPv4},
{"IPv6", PrepareSenderRawSocketIPv6}, {name: "IPv6", prepare: PrepareSenderRawSocketIPv6, optional: true},
} }
for _, tc := range tests { for _, tc := range tests {
t.Run(tc.name, func(t *testing.T) { t.Run(tc.name, func(t *testing.T) {
conn, err := tc.prepare() conn, err := tc.prepare()
if err != nil { if err != nil {
t.Skipf("prepare raw socket: %v", err) if tc.optional {
t.Skipf("prepare raw socket: %v", err)
}
t.Fatalf("prepare raw socket: %v", err)
} }
defer func() { defer func() {
if err := conn.Close(); err != nil { if err := conn.Close(); err != nil {