Simplified Store Interface (#545)

This PR simplifies Store and FileStore
by keeping just the Get and Save account methods.

The AccountManager operates mostly around
a single account, so it makes sense to fetch
the whole account object from the store.

management/server/migration/README.md

@@ -1,13 +0,0 @@
-## Migration from Store v2 to Store v2
-
-Previously Account.Id was an Auth0 user id.
-Conversion moves user id to Account.CreatedBy and generates a new Account.Id using xid.
-It also adds a User with id = old Account.Id with a role Admin.
-
-To start a conversion simply run the command below providing your current Wiretrustee Management datadir (where store.json file is located)
-and a new data directory location (where a converted store.js will be stored):
-```shell
-    ./migration --oldDir /var/wiretrustee/datadir --newDir /var/wiretrustee/newdatadir/  
-```
-
-Afterwards you can run the Management service providing ```/var/wiretrustee/newdatadir/ ``` as a datadir.

management/server/migration/convert_accounts.go

@@ -1,56 +0,0 @@
-package main
-
-import (
-	"flag"
-	"fmt"
-	"github.com/netbirdio/netbird/management/server"
-	"github.com/rs/xid"
-)
-
-func main() {
-
-	oldDir := flag.String("oldDir", "old store directory", "/var/wiretrustee/datadir")
-	newDir := flag.String("newDir", "new store directory", "/var/wiretrustee/newdatadir")
-
-	flag.Parse()
-
-	oldStore, err := server.NewStore(*oldDir)
-	if err != nil {
-		panic(err)
-	}
-
-	newStore, err := server.NewStore(*newDir)
-	if err != nil {
-		panic(err)
-	}
-
-	err = Convert(oldStore, newStore)
-	if err != nil {
-		panic(err)
-	}
-
-	fmt.Println("successfully converted")
-}
-
-// Convert converts old store ato a new store
-// Previously Account.Id was an Auth0 user id
-// Conversion moved user id to Account.CreatedBy and generated a new Account.Id using xid
-// It also adds a User with id = old Account.Id with a role Admin
-func Convert(oldStore *server.FileStore, newStore *server.FileStore) error {
-	for _, account := range oldStore.Accounts {
-		accountCopy := account.Copy()
-		accountCopy.Id = xid.New().String()
-		accountCopy.CreatedBy = account.Id
-		accountCopy.Users[account.Id] = &server.User{
-			Id:   account.Id,
-			Role: server.UserRoleAdmin,
-		}
-
-		err := newStore.SaveAccount(accountCopy)
-		if err != nil {
-			return err
-		}
-	}
-
-	return nil
-}

management/server/migration/convert_accounts_test.go

@@ -1,76 +0,0 @@
-package main
-
-import (
-	"github.com/netbirdio/netbird/management/server"
-	"github.com/netbirdio/netbird/util"
-	"path/filepath"
-	"testing"
-)
-
-func TestConvertAccounts(t *testing.T) {
-
-	storeDir := t.TempDir()
-
-	err := util.CopyFileContents("../testdata/storev1.json", filepath.Join(storeDir, "store.json"))
-	if err != nil {
-		t.Fatal(err)
-	}
-
-	store, err := server.NewStore(storeDir)
-	if err != nil {
-		t.Fatal(err)
-	}
-
-	convertedStore, err := server.NewStore(filepath.Join(storeDir, "converted"))
-	if err != nil {
-		t.Fatal(err)
-	}
-
-	err = Convert(store, convertedStore)
-	if err != nil {
-		t.Fatal(err)
-	}
-
-	if len(store.Accounts) != len(convertedStore.Accounts) {
-		t.Errorf("expecting the same number of accounts after conversion")
-	}
-
-	for _, account := range store.Accounts {
-		convertedAccount, err := convertedStore.GetUserAccount(account.Id)
-		if err != nil || convertedAccount == nil {
-			t.Errorf("expecting Account %s to be converted", account.Id)
-			return
-		}
-		if convertedAccount.CreatedBy != account.Id {
-			t.Errorf("expecting converted Account.CreatedBy field to be equal to the old Account.Id")
-			return
-		}
-		if convertedAccount.Id == account.Id {
-			t.Errorf("expecting converted Account.Id to be different from Account.Id")
-			return
-		}
-		if len(convertedAccount.Users) != 1 {
-			t.Errorf("expecting converted Account.Users to be of size 1")
-			return
-		}
-		user := convertedAccount.Users[account.Id]
-		if user == nil {
-			t.Errorf("expecting to find a user in converted Account.Users")
-			return
-		}
-		if user.Role != server.UserRoleAdmin {
-			t.Errorf("expecting to find a user in converted Account.Users with a role Admin")
-			return
-		}
-
-		for peerId := range account.Peers {
-			convertedPeer := convertedAccount.Peers[peerId]
-			if convertedPeer == nil {
-				t.Errorf("expecting Account Peer of StoreV1 to be found in StoreV2")
-				return
-			}
-		}
-
-	}
-
-}