Address CodeRabbit VNC review feedback

This commit is contained in:
Viktor Liu
2026-05-21 18:09:07 +02:00
parent e2127b45f8
commit d06ed64e59
9 changed files with 59 additions and 29 deletions
+10
View File
@@ -117,12 +117,22 @@ func (a *Authorizer) Update(config *Config) {
a.machineUsers = machineUsers
sessionPubKeys := make(map[[sessionPubKeyLen]byte]sshuserhash.UserIDHash, len(config.SessionPubKeys))
conflicted := make(map[[sessionPubKeyLen]byte]struct{})
for _, e := range config.SessionPubKeys {
if len(e.PubKey) != sessionPubKeyLen {
continue
}
var key [sessionPubKeyLen]byte
copy(key[:], e.PubKey)
if _, bad := conflicted[key]; bad {
continue
}
if existing, ok := sessionPubKeys[key]; ok && existing != e.UserIDHash {
log.Warnf("SSH auth: session pubkey bound to conflicting user hashes; dropping binding")
delete(sessionPubKeys, key)
conflicted[key] = struct{}{}
continue
}
sessionPubKeys[key] = e.UserIDHash
}
a.sessionPubKeys = sessionPubKeys