sendnrw/netbird
2
0
Fork 0
mirror of https://github.com/netbirdio/netbird.git synced 2026-04-18 08:16:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

Clean up temp dir

Browse Source
This commit is contained in:
Zoltán Papp
2025-10-13 20:38:49 +02:00
parent 7d846bf9ba
commit bab5cd4b41
1 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
client/internal/updatemanager/manager.go
View File

@@ -318,6 +318,17 @@ func downloadFileToTemporaryDir(ctx context.Context, fileURL string) (string, er
if err != nil { if err != nil {
return "", fmt.Errorf("error creating temporary directory: %w", err) return "", fmt.Errorf("error creating temporary directory: %w", err)
} }
// Clean up temp directory on error
var success bool
defer func() {
if !success {
if err := os.RemoveAll(tempDir); err != nil {
log.Errorf("error cleaning up temporary directory: %v", err)
}
}
}()
fileNameParts := strings.Split(fileURL, "/") fileNameParts := strings.Split(fileURL, "/")
out, err := os.Create(filepath.Join(tempDir, fileNameParts[len(fileNameParts)-1])) out, err := os.Create(filepath.Join(tempDir, fileNameParts[len(fileNameParts)-1]))
if err != nil { if err != nil {
@@ -355,6 +366,7 @@ func downloadFileToTemporaryDir(ctx context.Context, fileURL string) (string, er
log.Debugf("downloaded update file to %s", out.Name()) log.Debugf("downloaded update file to %s", out.Name())
success = true // Mark success to prevent cleanup
return out.Name(), nil return out.Name(), nil
} }