From b42fe6a10f28be15e9bde5ef070d28e1400e9838 Mon Sep 17 00:00:00 2001 From: riccardom Date: Tue, 16 Jun 2026 21:58:05 +0200 Subject: [PATCH] And now let's just avoid it at all --- client/internal/connect.go | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/client/internal/connect.go b/client/internal/connect.go index 363725c7f..73a3e944c 100644 --- a/client/internal/connect.go +++ b/client/internal/connect.go @@ -296,10 +296,8 @@ func (c *ConnectClient) run(runCtx context.Context, config *profilemanager.Confi log.Debug(err) if s, ok := gstatus.FromError(err); ok && (s.Code() == codes.PermissionDenied) { state.Set(StatusNeedsLogin) - // Called from inside the run goroutine: tear the engine down - // directly, never through the lifecycle queue (sup.stop would - // deadlock — the supervisor would wait for this very run to end). - _ = c.stopEngine() + // No teardown needed: login fails before the engine is started + // (engine.Start is below), so there is nothing running to stop. return backoff.Permanent(wrapErr(err)) // unrecoverable error } return wrapErr(err)