diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
index 9d6bc96eb..8e68054bd 100644
--- a/.github/pull_request_template.md
+++ b/.github/pull_request_template.md
@@ -12,6 +12,7 @@
- [ ] Is a feature enhancement
- [ ] It is a refactor
- [ ] Created tests that fail without the change (if possible)
+- [ ] This change does **not** modify the public API, gRPC protocols, functionality behavior, CLI / service flags, or introduce a new feature โ **OR** I have discussed it with the NetBird team beforehand (link the issue / Slack thread in the description). See [CONTRIBUTING.md](https://github.com/netbirdio/netbird/blob/main/CONTRIBUTING.md#discuss-changes-with-the-netbird-team-first).
> By submitting this pull request, you confirm that you have read and agree to the terms of the [Contributor License Agreement](https://github.com/netbirdio/netbird/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT.md).
diff --git a/.github/workflows/golangci-lint.yml b/.github/workflows/golangci-lint.yml
index 62dfe9bce..7b7b32ec0 100644
--- a/.github/workflows/golangci-lint.yml
+++ b/.github/workflows/golangci-lint.yml
@@ -19,7 +19,7 @@ jobs:
- name: codespell
uses: codespell-project/actions-codespell@v2
with:
- ignore_words_list: erro,clienta,hastable,iif,groupd,testin,groupe,cros,ans,deriver,te,userA
+ ignore_words_list: erro,clienta,hastable,iif,groupd,testin,groupe,cros,ans,deriver,te,userA,ede,additionals
skip: go.mod,go.sum,**/proxy/web/**
golangci:
strategy:
diff --git a/.gitignore b/.gitignore
index a0f128933..783fe77f3 100644
--- a/.gitignore
+++ b/.gitignore
@@ -33,3 +33,4 @@ infrastructure_files/setup-*.env
vendor/
/netbird
client/netbird-electron/
+management/server/types/testdata/
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index efc7d9460..cd1c087bb 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -8,13 +8,14 @@ There are many ways that you can contribute:
- Sharing use cases in slack or Reddit
- Bug fix or feature enhancement
-If you haven't already, join our slack workspace [here](https://join.slack.com/t/netbirdio/shared_invite/zt-vrahf41g-ik1v7fV8du6t0RwxSrJ96A), we would love to discuss topics that need community contribution and enhancements to existing features.
+If you haven't already, join our slack workspace [here](https://docs.netbird.io/slack-url), we would love to discuss topics that need community contribution and enhancements to existing features.
## Contents
- [Contributing to NetBird](#contributing-to-netbird)
- [Contents](#contents)
- [Code of conduct](#code-of-conduct)
+ - [Discuss changes with the NetBird team first](#discuss-changes-with-the-netbird-team-first)
- [Directory structure](#directory-structure)
- [Development setup](#development-setup)
- [Requirements](#requirements)
@@ -33,6 +34,14 @@ Conduct which can be found in the file [CODE_OF_CONDUCT.md](CODE_OF_CONDUCT.md).
By participating, you are expected to uphold this code. Please report
unacceptable behavior to community@netbird.io.
+## Discuss changes with the NetBird team first
+
+Changes to the **public API**, **gRPC protocols**, **functionality behavior**, **CLI / service flags**, or **new features** should be discussed with the NetBird team before you start the work. These surfaces are part of NetBird's contract with operators, self-hosters, and downstream integrators, and changes to them have compatibility, security, and release-planning implications that benefit from an early conversation.
+
+Open an issue or reach out on [Slack](https://docs.netbird.io/slack-url) to talk through what you have in mind. We'll help shape the change, flag any constraints we know about, and confirm the direction so the PR review can focus on implementation rather than design.
+
+Typical bug fixes, internal refactors, documentation updates, and tests do not need pre-discussion โ open the PR directly.
+
## Directory structure
The NetBird project monorepo is organized to maintain most of its individual dependencies code within their directories, except for a few auxiliary or shared packages.
diff --git a/README.md b/README.md
index dc84af2fd..cc27e2d28 100644
--- a/README.md
+++ b/README.md
@@ -1,147 +1,134 @@
-
-
**NetBird combines a configuration-free peer-to-peer private network and a centralized access control system in a single platform, making it easy to create secure private networks for your organization or home.**
**Connect.** NetBird creates a WireGuard-based overlay network that automatically connects your machines over an encrypted tunnel, leaving behind the hassle of opening ports, complex firewall rules, VPN gateways, and so forth.
**Secure.** NetBird enables secure remote access by applying granular access policies while allowing you to manage them intuitively from a single place. Works universally on any infrastructure.
-### Open Source Network Security in a Single Platform
-
https://github.com/user-attachments/assets/10cec749-bb56-4ab3-97af-4e38850108d2
-### Self-Host NetBird (Video)
+### Self-host NetBird (video)
+
[](https://youtu.be/bZAgpT6nzaQ)
### Key features
-| Connectivity | Management | Security | Automation| Platforms |
-|----|----|----|----|----|
-|
- \[x] Kernel WireGuard
|
- \[x] [Admin Web UI](https://github.com/netbirdio/dashboard)
|
+| Connectivity | Management | Security | Automation | Platforms |
+|---|---|---|---|---|
+| โ [Kernel WireGuard](https://docs.netbird.io/about-netbird/why-wireguard-with-netbird) | โ [Admin Web UI](https://github.com/netbirdio/dashboard) | โ [SSO & MFA support](https://docs.netbird.io/how-to/installation#running-net-bird-with-sso-login) | โ [Public API](https://docs.netbird.io/api) | โ [Linux](https://docs.netbird.io/get-started/install/linux) |
+| โ [Peer-to-peer connections](https://docs.netbird.io/about-netbird/how-netbird-works) | โ Auto peer discovery and configuration | โ [Access control: groups & rules](https://docs.netbird.io/how-to/manage-network-access) | โ [Setup keys for bulk provisioning](https://docs.netbird.io/how-to/register-machines-using-setup-keys) | โ [macOS](https://docs.netbird.io/get-started/install/macos) |
+| โ Connection relay fallback | โ [IdP integrations](https://docs.netbird.io/selfhosted/identity-providers) | โ [Activity logging](https://docs.netbird.io/how-to/audit-events-logging) | โ [Self-hosting quickstart script](https://docs.netbird.io/selfhosted/selfhosted-quickstart) | โ [Windows](https://docs.netbird.io/get-started/install/windows) |
+| โ [Routes to external networks](https://docs.netbird.io/how-to/routing-traffic-to-private-networks) | โ [Private DNS](https://docs.netbird.io/how-to/manage-dns-in-your-network) | โ [Traffic events](https://docs.netbird.io/manage/activity/traffic-events-logging) | โ [IdP groups sync with JWT](https://docs.netbird.io/manage/team/idp-sync) | โ [Android](https://docs.netbird.io/get-started/install/android) |
+| โ [Domain-based DNS routes](https://docs.netbird.io/manage/dns/dns-aliases-for-routed-networks) | โ [Custom DNS zones](https://docs.netbird.io/manage/dns/custom-zones) | โ [Device posture checks](https://docs.netbird.io/how-to/manage-posture-checks) | โ [Terraform provider](https://registry.terraform.io/providers/netbirdio/netbird/latest) | โ [Android TV](https://docs.netbird.io/get-started/install/android-tv) |
+| โ [Exit nodes](https://docs.netbird.io/manage/network-routes/use-cases/exit-nodes) | โ [Multiuser support](https://docs.netbird.io/how-to/add-users-to-your-network) | โ Peer-to-peer encryption | โ [Ansible collection](https://github.com/netbirdio/ansible-netbird) | โ [iOS](https://docs.netbird.io/get-started/install/ios) |
+| โ [IPv6 dual-stack overlay](https://docs.netbird.io/manage/settings/ipv6) | โ [Multi-account profile switching](https://docs.netbird.io/client/profiles) | โ [SSH with central access policies](https://docs.netbird.io/manage/peers/ssh) | | โ [Apple TV](https://docs.netbird.io/get-started/install/tvos) |
+| โ [Browser SSH & RDP](https://docs.netbird.io/manage/peers/browser-client) | | โ [Quantum-resistance with Rosenpass](https://netbird.io/knowledge-hub/the-first-quantum-resistant-mesh-vpn) | | โ FreeBSD |
+| โ [Reverse proxy with auto-TLS](https://docs.netbird.io/manage/reverse-proxy) | | โ [Periodic re-authentication](https://docs.netbird.io/how-to/enforce-periodic-user-authentication) | | โ [pfSense](https://docs.netbird.io/get-started/install/pfsense) |
+| | | | | โ [OPNsense](https://docs.netbird.io/get-started/install/opnsense) |
+| | | | | โ [MikroTik RouterOS](https://docs.netbird.io/use-cases/homelab/client-on-mikrotik-router) |
+| | | | | โ OpenWRT |
+| | | | | โ [Synology](https://docs.netbird.io/get-started/install/synology) |
+| | | | | โ [TrueNAS](https://docs.netbird.io/get-started/install/truenas) |
+| | | | | โ [Proxmox](https://docs.netbird.io/get-started/install/proxmox-ve) |
+| | | | | โ [Raspberry Pi](https://docs.netbird.io/get-started/install/raspberrypi) |
+| | | | | โ [Serverless](https://docs.netbird.io/how-to/netbird-on-faas) |
+| | | | | โ [Container](https://docs.netbird.io/get-started/install/docker) |
### Quickstart with NetBird Cloud
-- Download and install NetBird at [https://app.netbird.io/install](https://app.netbird.io/install)
-- Follow the steps to sign-up with Google, Microsoft, GitHub or your email address.
-- Check NetBird [admin UI](https://app.netbird.io/).
-- Add more machines.
+- Download and install NetBird at [https://app.netbird.io/install](https://app.netbird.io/install).
+- Follow the steps to sign up with Google, Microsoft, GitHub or your email address.
+- Check the NetBird [admin UI](https://app.netbird.io/).
### Quickstart with self-hosted NetBird
-> This is the quickest way to try self-hosted NetBird. It should take around 5 minutes to get started if you already have a public domain and a VM.
-Follow the [Advanced guide with a custom identity provider](https://docs.netbird.io/selfhosted/selfhosted-guide#advanced-guide-with-a-custom-identity-provider) for installations with different IDPs.
+This is the quickest way to try self-hosted NetBird. It should take around 5 minutes to get started if you already have a public domain and a VM. Follow the [Advanced guide with a custom identity provider](https://docs.netbird.io/selfhosted/selfhosted-guide#advanced-guide-with-a-custom-identity-provider) for installations with different IdPs.
**Infrastructure requirements:**
-- A Linux VM with at least **1CPU** and **2GB** of memory.
-- The VM should be publicly accessible on TCP ports **80** and **443** and UDP port: **3478**.
-- **Public domain** name pointing to the VM.
+- A Linux VM with at least **1 CPU** and **2 GB** of memory.
+- The VM should be publicly accessible on TCP ports **80** and **443** and UDP port **3478**.
+- A **public domain** name pointing to the VM.
**Software requirements:**
-- Docker installed on the VM with the docker-compose plugin ([Docker installation guide](https://docs.docker.com/engine/install/)) or docker with docker-compose in version 2 or higher.
-- [jq](https://jqlang.github.io/jq/) installed. In most distributions
- Usually available in the official repositories and can be installed with `sudo apt install jq` or `sudo yum install jq`
-- [curl](https://curl.se/) installed.
- Usually available in the official repositories and can be installed with `sudo apt install curl` or `sudo yum install curl`
+- Docker with the Compose plugin (Compose v2 or higher). See the [Docker installation guide](https://docs.docker.com/engine/install/).
**Steps**
- Download and run the installation script:
```bash
export NETBIRD_DOMAIN=netbird.example.com; curl -fsSL https://github.com/netbirdio/netbird/releases/latest/download/getting-started.sh | bash
```
-- Once finished, you can manage the resources via `docker-compose`
### A bit on NetBird internals
-- Every machine in the network runs [NetBird Agent (or Client)](client/) that manages WireGuard.
-- Every agent connects to [Management Service](management/) that holds network state, manages peer IPs, and distributes network updates to agents (peers).
-- NetBird agent uses WebRTC ICE implemented in [pion/ice library](https://github.com/pion/ice) to discover connection candidates when establishing a peer-to-peer connection between machines.
-- Connection candidates are discovered with the help of [STUN](https://en.wikipedia.org/wiki/STUN) servers.
-- Agents negotiate a connection through [Signal Service](signal/) passing p2p encrypted messages with candidates.
-- Sometimes the NAT traversal is unsuccessful due to strict NATs (e.g. mobile carrier-grade NAT) and a p2p connection isn't possible. When this occurs the system falls back to a relay server called [TURN](https://en.wikipedia.org/wiki/Traversal_Using_Relays_around_NAT), and a secure WireGuard tunnel is established via the TURN server.
-
-[Coturn](https://github.com/coturn/coturn) is the one that has been successfully used for STUN and TURN in NetBird setups.
+- Every machine in the network runs the [NetBird agent](client/), which manages WireGuard.
+- Every agent connects to the [Management Service](management/), which holds network state, manages peer IPs, and distributes updates to agents.
+- Agents use ICE (via [pion/ice](https://github.com/pion/ice)) to discover connection candidates for peer-to-peer connections.
+- Candidates are discovered with the help of [STUN](https://en.wikipedia.org/wiki/STUN) servers.
+- Agents negotiate a connection through the [Signal Service](signal/), exchanging end-to-end encrypted messages with candidates.
+- When NAT traversal fails (e.g. mobile carrier-grade NAT) and a direct p2p connection isn't possible, the system falls back to a [Relay Service](relay/) and a secure WireGuard tunnel is established through it.
-
+
See a complete [architecture overview](https://docs.netbird.io/about-netbird/how-netbird-works#architecture) for details.
### Community projects
-- [NetBird installer script](https://github.com/physk/netbird-installer)
-- [NetBird ansible collection by Dominion Solutions](https://galaxy.ansible.com/ui/repo/published/dominion_solutions/netbird/)
-- [netbird-tui](https://github.com/n0pashkov/netbird-tui) โ terminal UI for managing NetBird peers, routes, and settings
+- [NetBird installer script](https://github.com/physk/netbird-installer)
+- [netbird-tui](https://github.com/n0pashkov/netbird-tui) - terminal UI for managing NetBird peers, routes, and settings
+- [caddy-netbird](https://github.com/lixmal/caddy-netbird) - Caddy plugin that embeds a NetBird client for proxying HTTP and TCP/UDP traffic through NetBird networks
**Note**: The `main` branch may be in an *unstable or even broken state* during development.
For stable versions, see [releases](https://github.com/netbirdio/netbird/releases).
### Support acknowledgement
-In November 2022, NetBird joined the [StartUpSecure program](https://www.forschung-it-sicherheit-kommunikationssysteme.de/foerderung/bekanntmachungen/startup-secure) sponsored by The Federal Ministry of Education and Research of The Federal Republic of Germany. Together with [CISPA Helmholtz Center for Information Security](https://cispa.de/en) NetBird brings the security best practices and simplicity to private networking.
+In November 2022, NetBird joined the [StartUpSecure program](https://www.forschung-it-sicherheit-kommunikationssysteme.de/foerderung/bekanntmachungen/startup-secure) sponsored by the Federal Ministry of Education and Research of the Federal Republic of Germany. Together with the [CISPA Helmholtz Center for Information Security](https://cispa.de/en), NetBird brings security best practices and simplicity to private networking.

-### Testimonials
-We use open-source technologies like [WireGuardยฎ](https://www.wireguard.com/), [Pion ICE (WebRTC)](https://github.com/pion/ice), [Coturn](https://github.com/coturn/coturn), and [Rosenpass](https://rosenpass.eu). We very much appreciate the work these guys are doing and we'd greatly appreciate if you could support them in any way (e.g., by giving a star or a contribution).
+### Acknowledgements
+We build on open-source technologies like [WireGuardยฎ](https://www.wireguard.com/), [Pion ICE](https://github.com/pion/ice), and [Rosenpass](https://rosenpass.eu). We greatly appreciate the work these projects are doing, and we'd love it if you could support them too (e.g., by starring or contributing).
### Legal
-This repository is licensed under BSD-3-Clause license that applies to all parts of the repository except for the directories management/, signal/ and relay/.
+This repository is licensed under the BSD-3-Clause license, which applies to all parts of the repository except for the directories management/, signal/ and relay/.
Those directories are licensed under the GNU Affero General Public License version 3.0 (AGPLv3). See the respective LICENSE files inside each directory.
_WireGuard_ and the _WireGuard_ logo are [registered trademarks](https://www.wireguard.com/trademark-policy/) of Jason A. Donenfeld.
diff --git a/client/android/client.go b/client/android/client.go
index 37e17a363..99ccdf393 100644
--- a/client/android/client.go
+++ b/client/android/client.go
@@ -301,10 +301,11 @@ func (c *Client) PeersList() *PeerInfoArray {
peerInfos := make([]PeerInfo, len(fullStatus.Peers))
for n, p := range fullStatus.Peers {
pi := PeerInfo{
- p.IP,
- p.FQDN,
- int(p.ConnStatus),
- PeerRoutes{routes: maps.Keys(p.GetRoutes())},
+ IP: p.IP,
+ IPv6: p.IPv6,
+ FQDN: p.FQDN,
+ ConnStatus: int(p.ConnStatus),
+ Routes: PeerRoutes{routes: maps.Keys(p.GetRoutes())},
}
peerInfos[n] = pi
}
@@ -336,43 +337,84 @@ func (c *Client) Networks() *NetworkArray {
return nil
}
+ routesMap := routeManager.GetClientRoutesWithNetID()
+ v6Merged := route.V6ExitMergeSet(routesMap)
+ resolvedDomains := c.recorder.GetResolvedDomainsStates()
+
networkArray := &NetworkArray{
items: make([]Network, 0),
}
- resolvedDomains := c.recorder.GetResolvedDomainsStates()
-
- for id, routes := range routeManager.GetClientRoutesWithNetID() {
+ for id, routes := range routesMap {
if len(routes) == 0 {
continue
}
-
- r := routes[0]
- domains := c.getNetworkDomainsFromRoute(r, resolvedDomains)
- netStr := r.Network.String()
-
- if r.IsDynamic() {
- netStr = r.Domains.SafeString()
- }
-
- routePeer, err := c.recorder.GetPeer(routes[0].Peer)
- if err != nil {
- log.Errorf("could not get peer info for %s: %v", routes[0].Peer, err)
+ if _, skip := v6Merged[id]; skip {
continue
}
- network := Network{
- Name: string(id),
- Network: netStr,
- Peer: routePeer.FQDN,
- Status: routePeer.ConnStatus.String(),
- IsSelected: routeSelector.IsSelected(id),
- Domains: domains,
+
+ network := c.buildNetwork(id, routes, routeSelector.IsSelected(id), resolvedDomains, v6Merged)
+ if network == nil {
+ continue
}
- networkArray.Add(network)
+ networkArray.Add(*network)
}
return networkArray
}
+func (c *Client) buildNetwork(id route.NetID, routes []*route.Route, selected bool, resolvedDomains map[domain.Domain]peer.ResolvedDomainInfo, v6Merged map[route.NetID]struct{}) *Network {
+ r := routes[0]
+ netStr := r.Network.String()
+ if r.IsDynamic() {
+ netStr = r.Domains.SafeString()
+ }
+
+ routePeer, err := c.findBestRoutePeer(routes)
+ if err != nil {
+ log.Errorf("could not get peer info for route %s: %v", id, err)
+ return nil
+ }
+
+ network := &Network{
+ Name: string(id),
+ Network: netStr,
+ Peer: routePeer.FQDN,
+ Status: routePeer.ConnStatus.String(),
+ IsSelected: selected,
+ Domains: c.getNetworkDomainsFromRoute(r, resolvedDomains),
+ }
+
+ if route.IsV4DefaultRoute(r.Network) && route.HasV6ExitPair(id, v6Merged) {
+ network.Network = "0.0.0.0/0, ::/0"
+ }
+
+ return network
+}
+
+// findBestRoutePeer returns the peer actively routing traffic for the given
+// HA route group. Falls back to the first connected peer, then the first peer.
+func (c *Client) findBestRoutePeer(routes []*route.Route) (peer.State, error) {
+ netStr := routes[0].Network.String()
+
+ fullStatus := c.recorder.GetFullStatus()
+ for _, p := range fullStatus.Peers {
+ if _, ok := p.GetRoutes()[netStr]; ok {
+ return p, nil
+ }
+ }
+
+ for _, r := range routes {
+ p, err := c.recorder.GetPeer(r.Peer)
+ if err != nil {
+ continue
+ }
+ if p.ConnStatus == peer.StatusConnected {
+ return p, nil
+ }
+ }
+ return c.recorder.GetPeer(routes[0].Peer)
+}
+
// OnUpdatedHostDNS update the DNS servers addresses for root zones
func (c *Client) OnUpdatedHostDNS(list *DNSList) error {
dnsServer, err := dns.GetServerDns()
diff --git a/client/android/peer_notifier.go b/client/android/peer_notifier.go
index 4ec22f3ab..c2595e574 100644
--- a/client/android/peer_notifier.go
+++ b/client/android/peer_notifier.go
@@ -14,6 +14,7 @@ const (
// PeerInfo describe information about the peers. It designed for the UI usage
type PeerInfo struct {
IP string
+ IPv6 string
FQDN string
ConnStatus int
Routes PeerRoutes
diff --git a/client/android/preferences.go b/client/android/preferences.go
index c3c8eb3fb..066477293 100644
--- a/client/android/preferences.go
+++ b/client/android/preferences.go
@@ -307,6 +307,24 @@ func (p *Preferences) SetBlockInbound(block bool) {
p.configInput.BlockInbound = &block
}
+// GetDisableIPv6 reads disable IPv6 setting from config file
+func (p *Preferences) GetDisableIPv6() (bool, error) {
+ if p.configInput.DisableIPv6 != nil {
+ return *p.configInput.DisableIPv6, nil
+ }
+
+ cfg, err := profilemanager.ReadConfig(p.configInput.ConfigPath)
+ if err != nil {
+ return false, err
+ }
+ return cfg.DisableIPv6, err
+}
+
+// SetDisableIPv6 stores the given value and waits for commit
+func (p *Preferences) SetDisableIPv6(disable bool) {
+ p.configInput.DisableIPv6 = &disable
+}
+
// Commit writes out the changes to the config file
func (p *Preferences) Commit() error {
_, err := profilemanager.UpdateOrCreateConfig(p.configInput)
diff --git a/client/android/route_command.go b/client/android/route_command.go
index b47d5ca6c..5e7357335 100644
--- a/client/android/route_command.go
+++ b/client/android/route_command.go
@@ -18,9 +18,12 @@ func executeRouteToggle(id string, manager routemanager.Manager,
netID := route.NetID(id)
routes := []route.NetID{netID}
- log.Debugf("%s with id: %s", operationName, id)
+ routesMap := manager.GetClientRoutesWithNetID()
+ routes = route.ExpandV6ExitPairs(routes, routesMap)
- if err := routeOperation(routes, maps.Keys(manager.GetClientRoutesWithNetID())); err != nil {
+ log.Debugf("%s with ids: %v", operationName, routes)
+
+ if err := routeOperation(routes, maps.Keys(routesMap)); err != nil {
log.Debugf("error when %s: %s", operationName, err)
return fmt.Errorf("error %s: %w", operationName, err)
}
diff --git a/client/anonymize/anonymize.go b/client/anonymize/anonymize.go
index 89e653300..c140cef89 100644
--- a/client/anonymize/anonymize.go
+++ b/client/anonymize/anonymize.go
@@ -9,6 +9,7 @@ import (
"net/url"
"regexp"
"slices"
+ "strconv"
"strings"
)
@@ -26,8 +27,9 @@ type Anonymizer struct {
}
func DefaultAddresses() (netip.Addr, netip.Addr) {
- // 198.51.100.0, 100::
- return netip.AddrFrom4([4]byte{198, 51, 100, 0}), netip.AddrFrom16([16]byte{0x01})
+ // 198.51.100.0 (RFC 5737 TEST-NET-2), 2001:db8:ffff:: (RFC 3849 documentation, last /48)
+ // The old start 100:: (discard, RFC 6666) is now used for fake IPs on Android.
+ return netip.AddrFrom4([4]byte{198, 51, 100, 0}), netip.MustParseAddr("2001:db8:ffff::")
}
func NewAnonymizer(startIPv4, startIPv6 netip.Addr) *Anonymizer {
@@ -48,7 +50,7 @@ func (a *Anonymizer) AnonymizeIP(ip netip.Addr) netip.Addr {
ip.IsLinkLocalUnicast() ||
ip.IsLinkLocalMulticast() ||
ip.IsInterfaceLocalMulticast() ||
- ip.IsPrivate() ||
+ (ip.Is4() && ip.IsPrivate()) ||
ip.IsUnspecified() ||
ip.IsMulticast() ||
isWellKnown(ip) ||
@@ -96,6 +98,11 @@ func (a *Anonymizer) isInAnonymizedRange(ip netip.Addr) bool {
}
func (a *Anonymizer) AnonymizeIPString(ip string) string {
+ // Handle CIDR notation (e.g. "2001:db8::/32")
+ if prefix, err := netip.ParsePrefix(ip); err == nil {
+ return a.AnonymizeIP(prefix.Addr()).String() + "/" + strconv.Itoa(prefix.Bits())
+ }
+
addr, err := netip.ParseAddr(ip)
if err != nil {
return ip
@@ -150,7 +157,7 @@ func (a *Anonymizer) AnonymizeURI(uri string) string {
if u.Opaque != "" {
host, port, err := net.SplitHostPort(u.Opaque)
if err == nil {
- anonymizedHost = fmt.Sprintf("%s:%s", a.AnonymizeDomain(host), port)
+ anonymizedHost = net.JoinHostPort(a.AnonymizeDomain(host), port)
} else {
anonymizedHost = a.AnonymizeDomain(u.Opaque)
}
@@ -158,7 +165,7 @@ func (a *Anonymizer) AnonymizeURI(uri string) string {
} else if u.Host != "" {
host, port, err := net.SplitHostPort(u.Host)
if err == nil {
- anonymizedHost = fmt.Sprintf("%s:%s", a.AnonymizeDomain(host), port)
+ anonymizedHost = net.JoinHostPort(a.AnonymizeDomain(host), port)
} else {
anonymizedHost = a.AnonymizeDomain(u.Host)
}
diff --git a/client/anonymize/anonymize_test.go b/client/anonymize/anonymize_test.go
index ff2e48869..852315fa1 100644
--- a/client/anonymize/anonymize_test.go
+++ b/client/anonymize/anonymize_test.go
@@ -13,7 +13,7 @@ import (
func TestAnonymizeIP(t *testing.T) {
startIPv4 := netip.MustParseAddr("198.51.100.0")
- startIPv6 := netip.MustParseAddr("100::")
+ startIPv6 := netip.MustParseAddr("2001:db8:ffff::")
anonymizer := anonymize.NewAnonymizer(startIPv4, startIPv6)
tests := []struct {
@@ -26,9 +26,9 @@ func TestAnonymizeIP(t *testing.T) {
{"Second Public IPv4", "4.3.2.1", "198.51.100.1"},
{"Repeated IPv4", "1.2.3.4", "198.51.100.0"},
{"Private IPv4", "192.168.1.1", "192.168.1.1"},
- {"First Public IPv6", "2607:f8b0:4005:805::200e", "100::"},
- {"Second Public IPv6", "a::b", "100::1"},
- {"Repeated IPv6", "2607:f8b0:4005:805::200e", "100::"},
+ {"First Public IPv6", "2607:f8b0:4005:805::200e", "2001:db8:ffff::"},
+ {"Second Public IPv6", "a::b", "2001:db8:ffff::1"},
+ {"Repeated IPv6", "2607:f8b0:4005:805::200e", "2001:db8:ffff::"},
{"Private IPv6", "fe80::1", "fe80::1"},
{"In Range IPv4", "198.51.100.2", "198.51.100.2"},
}
@@ -274,17 +274,27 @@ func TestAnonymizeString_IPAddresses(t *testing.T) {
{
name: "IPv6 Address",
input: "Access attempted from 2001:db8::ff00:42",
- expect: "Access attempted from 100::",
+ expect: "Access attempted from 2001:db8:ffff::",
},
{
name: "IPv6 Address with Port",
input: "Access attempted from [2001:db8::ff00:42]:8080",
- expect: "Access attempted from [100::]:8080",
+ expect: "Access attempted from [2001:db8:ffff::]:8080",
},
{
name: "Both IPv4 and IPv6",
input: "IPv4: 142.108.0.1 and IPv6: 2001:db8::ff00:43",
- expect: "IPv4: 198.51.100.1 and IPv6: 100::1",
+ expect: "IPv4: 198.51.100.1 and IPv6: 2001:db8:ffff::1",
+ },
+ {
+ name: "STUN URI with IPv6",
+ input: "Connecting to stun:[2001:db8::ff00:42]:3478",
+ expect: "Connecting to stun:[2001:db8:ffff::]:3478",
+ },
+ {
+ name: "HTTPS URI with IPv6",
+ input: "Visit https://[2001:db8::ff00:42]:443/path",
+ expect: "Visit https://[2001:db8:ffff::]:443/path",
},
}
diff --git a/client/cmd/root.go b/client/cmd/root.go
index 29d4328a1..0a0aa4197 100644
--- a/client/cmd/root.go
+++ b/client/cmd/root.go
@@ -143,7 +143,7 @@ func init() {
rootCmd.PersistentFlags().StringVar(&preSharedKey, preSharedKeyFlag, "", "Sets WireGuard PreSharedKey property. If set, then only peers that have the same key can communicate.")
rootCmd.PersistentFlags().StringVarP(&hostName, "hostname", "n", "", "Sets a custom hostname for the device")
rootCmd.PersistentFlags().BoolVarP(&anonymizeFlag, "anonymize", "A", false, "anonymize IP addresses and non-netbird.io domains in logs and status output")
- rootCmd.PersistentFlags().StringVarP(&configPath, "config", "c", defaultConfigPath, "Overrides the default profile file location")
+ rootCmd.PersistentFlags().StringVarP(&configPath, "config", "c", profilemanager.DefaultConfigPath, "Overrides the default profile file location")
rootCmd.AddCommand(upCmd)
rootCmd.AddCommand(downCmd)
diff --git a/client/cmd/ssh.go b/client/cmd/ssh.go
index 0acf0b133..d6e052e08 100644
--- a/client/cmd/ssh.go
+++ b/client/cmd/ssh.go
@@ -523,7 +523,7 @@ func parseHostnameAndCommand(args []string) error {
}
func runSSH(ctx context.Context, addr string, cmd *cobra.Command) error {
- target := fmt.Sprintf("%s:%d", addr, port)
+ target := net.JoinHostPort(strings.Trim(addr, "[]"), strconv.Itoa(port))
c, err := sshclient.Dial(ctx, target, username, sshclient.DialOptions{
KnownHostsFile: knownHostsFile,
IdentityFile: identityFile,
@@ -787,10 +787,10 @@ func isUnixSocket(path string) bool {
return strings.HasPrefix(path, "/") || strings.HasPrefix(path, "./")
}
-// normalizeLocalHost converts "*" to "0.0.0.0" for binding to all interfaces.
+// normalizeLocalHost converts "*" to "" for binding to all interfaces (dual-stack).
func normalizeLocalHost(host string) string {
if host == "*" {
- return "0.0.0.0"
+ return ""
}
return host
}
diff --git a/client/cmd/ssh_test.go b/client/cmd/ssh_test.go
index 43291fa87..16ffadb90 100644
--- a/client/cmd/ssh_test.go
+++ b/client/cmd/ssh_test.go
@@ -527,10 +527,10 @@ func TestParsePortForward(t *testing.T) {
{
name: "wildcard bind all interfaces",
spec: "*:8080:localhost:80",
- expectedLocal: "0.0.0.0:8080",
+ expectedLocal: ":8080",
expectedRemote: "localhost:80",
expectError: false,
- description: "Wildcard * should bind to all interfaces (0.0.0.0)",
+ description: "Wildcard * should bind to all interfaces (dual-stack)",
},
{
name: "wildcard for port only",
diff --git a/client/cmd/status.go b/client/cmd/status.go
index c35a06eb3..103b3044a 100644
--- a/client/cmd/status.go
+++ b/client/cmd/status.go
@@ -20,6 +20,7 @@ import (
var (
detailFlag bool
ipv4Flag bool
+ ipv6Flag bool
jsonFlag bool
yamlFlag bool
ipsFilter []string
@@ -42,15 +43,16 @@ func init() {
ipsFilterMap = make(map[string]struct{})
prefixNamesFilterMap = make(map[string]struct{})
statusCmd.PersistentFlags().BoolVarP(&detailFlag, "detail", "d", false, "display detailed status information in human-readable format")
- statusCmd.PersistentFlags().BoolVar(&jsonFlag, "json", false, "display detailed status information in json format")
- statusCmd.PersistentFlags().BoolVar(&yamlFlag, "yaml", false, "display detailed status information in yaml format")
- statusCmd.PersistentFlags().BoolVar(&ipv4Flag, "ipv4", false, "display only NetBird IPv4 of this peer, e.g., --ipv4 will output 100.64.0.33")
- statusCmd.MarkFlagsMutuallyExclusive("detail", "json", "yaml", "ipv4")
- statusCmd.PersistentFlags().StringSliceVar(&ipsFilter, "filter-by-ips", []string{}, "filters the detailed output by a list of one or more IPs, e.g., --filter-by-ips 100.64.0.100,100.64.0.200")
- statusCmd.PersistentFlags().StringSliceVar(&prefixNamesFilter, "filter-by-names", []string{}, "filters the detailed output by a list of one or more peer FQDN or hostnames, e.g., --filter-by-names peer-a,peer-b.netbird.cloud")
- statusCmd.PersistentFlags().StringVar(&statusFilter, "filter-by-status", "", "filters the detailed output by connection status(idle|connecting|connected), e.g., --filter-by-status connected")
- statusCmd.PersistentFlags().StringVar(&connectionTypeFilter, "filter-by-connection-type", "", "filters the detailed output by connection type (P2P|Relayed), e.g., --filter-by-connection-type P2P")
- statusCmd.PersistentFlags().StringVar(&checkFlag, "check", "", "run a health check and exit with code 0 on success, 1 on failure (live|ready|startup)")
+ statusCmd.PersistentFlags().BoolVarP(&jsonFlag, "json", "j", false, "display detailed status information in json format")
+ statusCmd.PersistentFlags().BoolVarP(&yamlFlag, "yaml", "y", false, "display detailed status information in yaml format")
+ statusCmd.PersistentFlags().BoolVarP(&ipv4Flag, "ipv4", "4", false, "display only NetBird IPv4 of this peer, e.g., --ipv4 will output 100.64.0.33")
+ statusCmd.PersistentFlags().BoolVarP(&ipv6Flag, "ipv6", "6", false, "display only NetBird IPv6 of this peer")
+ statusCmd.MarkFlagsMutuallyExclusive("detail", "json", "yaml", "ipv4", "ipv6")
+ statusCmd.PersistentFlags().StringSliceVarP(&ipsFilter, "filter-by-ips", "I", []string{}, "filters the detailed output by a list of one or more IPs (v4 or v6), e.g., --filter-by-ips 100.64.0.100,fd00::1")
+ statusCmd.PersistentFlags().StringSliceVarP(&prefixNamesFilter, "filter-by-names", "N", []string{}, "filters the detailed output by a list of one or more peer FQDN or hostnames, e.g., --filter-by-names peer-a,peer-b.netbird.cloud")
+ statusCmd.PersistentFlags().StringVarP(&statusFilter, "filter-by-status", "S", "", "filters the detailed output by connection status(idle|connecting|connected), e.g., --filter-by-status connected")
+ statusCmd.PersistentFlags().StringVarP(&connectionTypeFilter, "filter-by-connection-type", "T", "", "filters the detailed output by connection type (P2P|Relayed), e.g., --filter-by-connection-type P2P")
+ statusCmd.PersistentFlags().StringVarP(&checkFlag, "check", "C", "", "run a health check and exit with code 0 on success, 1 on failure (live|ready|startup)")
}
func statusFunc(cmd *cobra.Command, args []string) error {
@@ -101,6 +103,14 @@ func statusFunc(cmd *cobra.Command, args []string) error {
return nil
}
+ if ipv6Flag {
+ ipv6 := resp.GetFullStatus().GetLocalPeerState().GetIpv6()
+ if ipv6 != "" {
+ cmd.Print(parseInterfaceIP(ipv6))
+ }
+ return nil
+ }
+
pm := profilemanager.NewProfileManager()
var profName string
if activeProf, err := pm.GetActiveProfile(); err == nil {
diff --git a/client/cmd/system.go b/client/cmd/system.go
index f63432401..b386fe4ae 100644
--- a/client/cmd/system.go
+++ b/client/cmd/system.go
@@ -8,6 +8,7 @@ const (
disableFirewallFlag = "disable-firewall"
blockLANAccessFlag = "block-lan-access"
blockInboundFlag = "block-inbound"
+ disableIPv6Flag = "disable-ipv6"
)
var (
@@ -17,6 +18,7 @@ var (
disableFirewall bool
blockLANAccess bool
blockInbound bool
+ disableIPv6 bool
)
func init() {
@@ -39,4 +41,7 @@ func init() {
upCmd.PersistentFlags().BoolVar(&blockInbound, blockInboundFlag, false,
"Block inbound connections. If enabled, the client will not allow any inbound connections to the local machine nor routed networks.\n"+
"This overrides any policies received from the management service.")
+
+ upCmd.PersistentFlags().BoolVar(&disableIPv6, disableIPv6Flag, false,
+ "Disable IPv6 overlay. If enabled, the client won't request or use an IPv6 overlay address.")
}
diff --git a/client/cmd/up.go b/client/cmd/up.go
index f4136cb23..cabd0aacf 100644
--- a/client/cmd/up.go
+++ b/client/cmd/up.go
@@ -435,6 +435,10 @@ func setupSetConfigReq(customDNSAddressConverted []byte, cmd *cobra.Command, pro
req.BlockInbound = &blockInbound
}
+ if cmd.Flag(disableIPv6Flag).Changed {
+ req.DisableIpv6 = &disableIPv6
+ }
+
if cmd.Flag(enableLazyConnectionFlag).Changed {
req.LazyConnectionEnabled = &lazyConnEnabled
}
@@ -552,6 +556,10 @@ func setupConfig(customDNSAddressConverted []byte, cmd *cobra.Command, configFil
ic.BlockInbound = &blockInbound
}
+ if cmd.Flag(disableIPv6Flag).Changed {
+ ic.DisableIPv6 = &disableIPv6
+ }
+
if cmd.Flag(enableLazyConnectionFlag).Changed {
ic.LazyConnectionEnabled = &lazyConnEnabled
}
@@ -666,6 +674,10 @@ func setupLoginRequest(providedSetupKey string, customDNSAddressConverted []byte
loginRequest.BlockInbound = &blockInbound
}
+ if cmd.Flag(disableIPv6Flag).Changed {
+ loginRequest.DisableIpv6 = &disableIPv6
+ }
+
if cmd.Flag(enableLazyConnectionFlag).Changed {
loginRequest.LazyConnectionEnabled = &lazyConnEnabled
}
diff --git a/client/embed/embed.go b/client/embed/embed.go
index baa1d94d6..8b669e547 100644
--- a/client/embed/embed.go
+++ b/client/embed/embed.go
@@ -80,6 +80,8 @@ type Options struct {
StatePath string
// DisableClientRoutes disables the client routes
DisableClientRoutes bool
+ // DisableIPv6 disables IPv6 overlay addressing
+ DisableIPv6 bool
// BlockInbound blocks all inbound connections from peers
BlockInbound bool
// WireguardPort is the port for the tunnel interface. Use 0 for a random port.
@@ -171,6 +173,7 @@ func New(opts Options) (*Client, error) {
PreSharedKey: &opts.PreSharedKey,
DisableServerRoutes: &t,
DisableClientRoutes: &opts.DisableClientRoutes,
+ DisableIPv6: &opts.DisableIPv6,
BlockInbound: &opts.BlockInbound,
WireguardPort: opts.WireguardPort,
MTU: opts.MTU,
@@ -333,7 +336,7 @@ func (c *Client) ListenTCP(address string) (net.Listener, error) {
if err != nil {
return nil, fmt.Errorf("split host port: %w", err)
}
- listenAddr := fmt.Sprintf("%s:%s", addr, port)
+ listenAddr := net.JoinHostPort(addr.String(), port)
tcpAddr, err := net.ResolveTCPAddr("tcp", listenAddr)
if err != nil {
@@ -354,7 +357,7 @@ func (c *Client) ListenUDP(address string) (net.PacketConn, error) {
if err != nil {
return nil, fmt.Errorf("split host port: %w", err)
}
- listenAddr := fmt.Sprintf("%s:%s", addr, port)
+ listenAddr := net.JoinHostPort(addr.String(), port)
udpAddr, err := net.ResolveUDPAddr("udp", listenAddr)
if err != nil {
diff --git a/client/firewall/iptables/acl_linux.go b/client/firewall/iptables/acl_linux.go
index e629f7881..e5e19cec9 100644
--- a/client/firewall/iptables/acl_linux.go
+++ b/client/firewall/iptables/acl_linux.go
@@ -40,6 +40,7 @@ type aclManager struct {
entries aclEntries
optionalEntries map[string][]entry
ipsetStore *ipsetStore
+ v6 bool
stateManager *statemanager.Manager
}
@@ -51,6 +52,7 @@ func newAclManager(iptablesClient *iptables.IPTables, wgIface iFaceMapper) (*acl
entries: make(map[string][][]string),
optionalEntries: make(map[string][]entry),
ipsetStore: newIpsetStore(),
+ v6: iptablesClient.Proto() == iptables.ProtocolIPv6,
}, nil
}
@@ -85,7 +87,11 @@ func (m *aclManager) AddPeerFiltering(
chain := chainNameInputRules
ipsetName = transformIPsetName(ipsetName, sPort, dPort, action)
- specs := filterRuleSpecs(ip, string(protocol), sPort, dPort, action, ipsetName)
+ if m.v6 && ipsetName != "" {
+ ipsetName += "-v6"
+ }
+ proto := protoForFamily(protocol, m.v6)
+ specs := filterRuleSpecs(ip, proto, sPort, dPort, action, ipsetName)
mangleSpecs := slices.Clone(specs)
mangleSpecs = append(mangleSpecs,
@@ -109,6 +115,7 @@ func (m *aclManager) AddPeerFiltering(
ip: ip.String(),
chain: chain,
specs: specs,
+ v6: m.v6,
}}, nil
}
@@ -161,6 +168,7 @@ func (m *aclManager) AddPeerFiltering(
ipsetName: ipsetName,
ip: ip.String(),
chain: chain,
+ v6: m.v6,
}
m.updateState()
@@ -413,8 +421,13 @@ func (m *aclManager) updateState() {
currentState.Lock()
defer currentState.Unlock()
- currentState.ACLEntries = m.entries
- currentState.ACLIPsetStore = m.ipsetStore
+ if m.v6 {
+ currentState.ACLEntries6 = m.entries
+ currentState.ACLIPsetStore6 = m.ipsetStore
+ } else {
+ currentState.ACLEntries = m.entries
+ currentState.ACLIPsetStore = m.ipsetStore
+ }
if err := m.stateManager.UpdateState(currentState); err != nil {
log.Errorf("failed to update state: %v", err)
@@ -422,13 +435,22 @@ func (m *aclManager) updateState() {
}
// filterRuleSpecs returns the specs of a filtering rule
+// protoForFamily translates ICMP to ICMPv6 for ip6tables.
+// ip6tables requires "ipv6-icmp" (or "icmpv6") instead of "icmp".
+func protoForFamily(protocol firewall.Protocol, v6 bool) string {
+ if v6 && protocol == firewall.ProtocolICMP {
+ return "ipv6-icmp"
+ }
+ return string(protocol)
+}
+
func filterRuleSpecs(ip net.IP, protocol string, sPort, dPort *firewall.Port, action firewall.Action, ipsetName string) (specs []string) {
// don't use IP matching if IP is 0.0.0.0
matchByIP := !ip.IsUnspecified()
if matchByIP {
if ipsetName != "" {
- specs = append(specs, "-m", "set", "--set", ipsetName, "src")
+ specs = append(specs, "-m", "set", "--match-set", ipsetName, "src")
} else {
specs = append(specs, "-s", ip.String())
}
@@ -474,6 +496,9 @@ func (m *aclManager) createIPSet(name string) error {
opts := ipset.CreateOptions{
Replace: true,
}
+ if m.v6 {
+ opts.Family = ipset.FamilyIPV6
+ }
if err := ipset.Create(name, ipset.TypeHashNet, opts); err != nil {
return fmt.Errorf("create ipset %s: %w", name, err)
diff --git a/client/firewall/iptables/manager_linux.go b/client/firewall/iptables/manager_linux.go
index 7d8cd7f8c..696537dd8 100644
--- a/client/firewall/iptables/manager_linux.go
+++ b/client/firewall/iptables/manager_linux.go
@@ -18,6 +18,10 @@ import (
"github.com/netbirdio/netbird/client/internal/statemanager"
)
+type resetter interface {
+ Reset() error
+}
+
// Manager of iptables firewall
type Manager struct {
mutex sync.Mutex
@@ -28,6 +32,11 @@ type Manager struct {
aclMgr *aclManager
router *router
rawSupported bool
+
+ // IPv6 counterparts, nil when no v6 overlay
+ ipv6Client *iptables.IPTables
+ aclMgr6 *aclManager
+ router6 *router
}
// iFaceMapper defines subset methods of interface required for manager
@@ -58,9 +67,43 @@ func Create(wgIface iFaceMapper, mtu uint16) (*Manager, error) {
return nil, fmt.Errorf("create acl manager: %w", err)
}
+ if wgIface.Address().HasIPv6() {
+ if err := m.createIPv6Components(wgIface, mtu); err != nil {
+ return nil, fmt.Errorf("create IPv6 firewall: %w", err)
+ }
+ }
+
return m, nil
}
+func (m *Manager) createIPv6Components(wgIface iFaceMapper, mtu uint16) error {
+ ip6Client, err := iptables.NewWithProtocol(iptables.ProtocolIPv6)
+ if err != nil {
+ return fmt.Errorf("init ip6tables: %w", err)
+ }
+ m.ipv6Client = ip6Client
+
+ m.router6, err = newRouter(ip6Client, wgIface, mtu)
+ if err != nil {
+ return fmt.Errorf("create v6 router: %w", err)
+ }
+
+ // Share the same IP forwarding state with the v4 router, since
+ // EnableIPForwarding controls both v4 and v6 sysctls.
+ m.router6.ipFwdState = m.router.ipFwdState
+
+ m.aclMgr6, err = newAclManager(ip6Client, wgIface)
+ if err != nil {
+ return fmt.Errorf("create v6 acl manager: %w", err)
+ }
+
+ return nil
+}
+
+func (m *Manager) hasIPv6() bool {
+ return m.ipv6Client != nil
+}
+
func (m *Manager) Init(stateManager *statemanager.Manager) error {
state := &ShutdownState{
InterfaceState: &InterfaceState{
@@ -74,13 +117,8 @@ func (m *Manager) Init(stateManager *statemanager.Manager) error {
log.Errorf("failed to update state: %v", err)
}
- if err := m.router.init(stateManager); err != nil {
- return fmt.Errorf("router init: %w", err)
- }
-
- if err := m.aclMgr.init(stateManager); err != nil {
- // TODO: cleanup router
- return fmt.Errorf("acl manager init: %w", err)
+ if err := m.initChains(stateManager); err != nil {
+ return err
}
if err := m.initNoTrackChain(); err != nil {
@@ -103,6 +141,41 @@ func (m *Manager) Init(stateManager *statemanager.Manager) error {
return nil
}
+// initChains initializes router and ACL chains for both address families,
+// rolling back on failure.
+func (m *Manager) initChains(stateManager *statemanager.Manager) error {
+ type initStep struct {
+ name string
+ init func(*statemanager.Manager) error
+ mgr resetter
+ }
+
+ steps := []initStep{
+ {"router", m.router.init, m.router},
+ {"acl manager", m.aclMgr.init, m.aclMgr},
+ }
+ if m.hasIPv6() {
+ steps = append(steps,
+ initStep{"v6 router", m.router6.init, m.router6},
+ initStep{"v6 acl manager", m.aclMgr6.init, m.aclMgr6},
+ )
+ }
+
+ var initialized []initStep
+ for _, s := range steps {
+ if err := s.init(stateManager); err != nil {
+ for i := len(initialized) - 1; i >= 0; i-- {
+ if rerr := initialized[i].mgr.Reset(); rerr != nil {
+ log.Warnf("rollback %s: %v", initialized[i].name, rerr)
+ }
+ }
+ return fmt.Errorf("%s init: %w", s.name, err)
+ }
+ initialized = append(initialized, s)
+ }
+ return nil
+}
+
// AddPeerFiltering adds a rule to the firewall
//
// Comment will be ignored because some system this feature is not supported
@@ -118,7 +191,13 @@ func (m *Manager) AddPeerFiltering(
m.mutex.Lock()
defer m.mutex.Unlock()
- return m.aclMgr.AddPeerFiltering(id, ip, proto, sPort, dPort, action, ipsetName)
+ if ip.To4() != nil {
+ return m.aclMgr.AddPeerFiltering(id, ip, proto, sPort, dPort, action, ipsetName)
+ }
+ if !m.hasIPv6() {
+ return nil, fmt.Errorf("add peer filtering for %s: %w", ip, firewall.ErrIPv6NotInitialized)
+ }
+ return m.aclMgr6.AddPeerFiltering(id, ip, proto, sPort, dPort, action, ipsetName)
}
func (m *Manager) AddRouteFiltering(
@@ -132,25 +211,48 @@ func (m *Manager) AddRouteFiltering(
m.mutex.Lock()
defer m.mutex.Unlock()
- if destination.IsPrefix() && !destination.Prefix.Addr().Is4() {
- return nil, fmt.Errorf("unsupported IP version: %s", destination.Prefix.Addr().String())
+ if isIPv6RouteRule(sources, destination) {
+ if !m.hasIPv6() {
+ return nil, fmt.Errorf("add route filtering: %w", firewall.ErrIPv6NotInitialized)
+ }
+ return m.router6.AddRouteFiltering(id, sources, destination, proto, sPort, dPort, action)
}
return m.router.AddRouteFiltering(id, sources, destination, proto, sPort, dPort, action)
}
+func isIPv6RouteRule(sources []netip.Prefix, destination firewall.Network) bool {
+ if destination.IsPrefix() {
+ return destination.Prefix.Addr().Is6()
+ }
+ return len(sources) > 0 && sources[0].Addr().Is6()
+}
+
// DeletePeerRule from the firewall by rule definition
func (m *Manager) DeletePeerRule(rule firewall.Rule) error {
m.mutex.Lock()
defer m.mutex.Unlock()
+ if m.hasIPv6() && isIPv6IptRule(rule) {
+ return m.aclMgr6.DeletePeerRule(rule)
+ }
return m.aclMgr.DeletePeerRule(rule)
}
+func isIPv6IptRule(rule firewall.Rule) bool {
+ r, ok := rule.(*Rule)
+ return ok && r.v6
+}
+
+// DeleteRouteRule deletes a routing rule.
+// Route rules are keyed by content hash. Check v4 first, try v6 if not found.
func (m *Manager) DeleteRouteRule(rule firewall.Rule) error {
m.mutex.Lock()
defer m.mutex.Unlock()
+ if m.hasIPv6() && !m.router.hasRule(rule.ID()) {
+ return m.router6.DeleteRouteRule(rule)
+ }
return m.router.DeleteRouteRule(rule)
}
@@ -166,18 +268,65 @@ func (m *Manager) AddNatRule(pair firewall.RouterPair) error {
m.mutex.Lock()
defer m.mutex.Unlock()
- return m.router.AddNatRule(pair)
+ if pair.Destination.IsPrefix() && pair.Destination.Prefix.Addr().Is6() {
+ if !m.hasIPv6() {
+ return fmt.Errorf("add NAT rule: %w", firewall.ErrIPv6NotInitialized)
+ }
+ return m.router6.AddNatRule(pair)
+ }
+
+ if err := m.router.AddNatRule(pair); err != nil {
+ return err
+ }
+
+ // Dynamic routes need NAT in both tables since resolved IPs can be
+ // either v4 or v6. This covers both DomainSet (modern) and the legacy
+ // wildcard 0.0.0.0/0 destination where the client resolves DNS.
+ if m.hasIPv6() && pair.Dynamic {
+ v6Pair := firewall.ToV6NatPair(pair)
+ if err := m.router6.AddNatRule(v6Pair); err != nil {
+ return fmt.Errorf("add v6 NAT rule: %w", err)
+ }
+ }
+
+ return nil
}
func (m *Manager) RemoveNatRule(pair firewall.RouterPair) error {
m.mutex.Lock()
defer m.mutex.Unlock()
- return m.router.RemoveNatRule(pair)
+ if pair.Destination.IsPrefix() && pair.Destination.Prefix.Addr().Is6() {
+ if !m.hasIPv6() {
+ return nil
+ }
+ return m.router6.RemoveNatRule(pair)
+ }
+
+ var merr *multierror.Error
+
+ if err := m.router.RemoveNatRule(pair); err != nil {
+ merr = multierror.Append(merr, fmt.Errorf("remove v4 NAT rule: %w", err))
+ }
+
+ if m.hasIPv6() && pair.Dynamic {
+ v6Pair := firewall.ToV6NatPair(pair)
+ if err := m.router6.RemoveNatRule(v6Pair); err != nil {
+ merr = multierror.Append(merr, fmt.Errorf("remove v6 NAT rule: %w", err))
+ }
+ }
+
+ return nberrors.FormatErrorOrNil(merr)
}
func (m *Manager) SetLegacyManagement(isLegacy bool) error {
- return firewall.SetLegacyManagement(m.router, isLegacy)
+ if err := firewall.SetLegacyManagement(m.router, isLegacy); err != nil {
+ return err
+ }
+ if m.hasIPv6() {
+ return firewall.SetLegacyManagement(m.router6, isLegacy)
+ }
+ return nil
}
// Reset firewall to the default state
@@ -191,6 +340,15 @@ func (m *Manager) Close(stateManager *statemanager.Manager) error {
merr = multierror.Append(merr, fmt.Errorf("cleanup notrack chain: %w", err))
}
+ if m.hasIPv6() {
+ if err := m.aclMgr6.Reset(); err != nil {
+ merr = multierror.Append(merr, fmt.Errorf("reset v6 acl manager: %w", err))
+ }
+ if err := m.router6.Reset(); err != nil {
+ merr = multierror.Append(merr, fmt.Errorf("reset v6 router: %w", err))
+ }
+ }
+
if err := m.aclMgr.Reset(); err != nil {
merr = multierror.Append(merr, fmt.Errorf("reset acl manager: %w", err))
}
@@ -218,24 +376,21 @@ func (m *Manager) Close(stateManager *statemanager.Manager) error {
// This is called when USPFilter wraps the native firewall, adding blanket accept
// rules so that packet filtering is handled in userspace instead of by netfilter.
func (m *Manager) AllowNetbird() error {
- _, err := m.AddPeerFiltering(
- nil,
- net.IP{0, 0, 0, 0},
- firewall.ProtocolALL,
- nil,
- nil,
- firewall.ActionAccept,
- "",
- )
- if err != nil {
- return fmt.Errorf("allow netbird interface traffic: %w", err)
+ var merr *multierror.Error
+ if _, err := m.AddPeerFiltering(nil, net.IP{0, 0, 0, 0}, firewall.ProtocolALL, nil, nil, firewall.ActionAccept, ""); err != nil {
+ merr = multierror.Append(merr, fmt.Errorf("allow netbird v4 interface traffic: %w", err))
+ }
+ if m.hasIPv6() {
+ if _, err := m.AddPeerFiltering(nil, net.IPv6zero, firewall.ProtocolALL, nil, nil, firewall.ActionAccept, ""); err != nil {
+ merr = multierror.Append(merr, fmt.Errorf("allow netbird v6 interface traffic: %w", err))
+ }
}
if err := firewalld.TrustInterface(m.wgIface.Name()); err != nil {
log.Warnf("failed to trust interface in firewalld: %v", err)
}
- return nil
+ return nberrors.FormatErrorOrNil(merr)
}
// Flush doesn't need to be implemented for this manager
@@ -265,6 +420,12 @@ func (m *Manager) AddDNATRule(rule firewall.ForwardRule) (firewall.Rule, error)
m.mutex.Lock()
defer m.mutex.Unlock()
+ if rule.TranslatedAddress.Is6() {
+ if !m.hasIPv6() {
+ return nil, fmt.Errorf("add DNAT rule: %w", firewall.ErrIPv6NotInitialized)
+ }
+ return m.router6.AddDNATRule(rule)
+ }
return m.router.AddDNATRule(rule)
}
@@ -273,6 +434,9 @@ func (m *Manager) DeleteDNATRule(rule firewall.Rule) error {
m.mutex.Lock()
defer m.mutex.Unlock()
+ if m.hasIPv6() && !m.router.hasRule(rule.ID()+dnatSuffix) {
+ return m.router6.DeleteDNATRule(rule)
+ }
return m.router.DeleteDNATRule(rule)
}
@@ -281,39 +445,82 @@ func (m *Manager) UpdateSet(set firewall.Set, prefixes []netip.Prefix) error {
m.mutex.Lock()
defer m.mutex.Unlock()
- return m.router.UpdateSet(set, prefixes)
+ var v4Prefixes, v6Prefixes []netip.Prefix
+ for _, p := range prefixes {
+ if p.Addr().Is6() {
+ v6Prefixes = append(v6Prefixes, p)
+ } else {
+ v4Prefixes = append(v4Prefixes, p)
+ }
+ }
+
+ if err := m.router.UpdateSet(set, v4Prefixes); err != nil {
+ return err
+ }
+
+ if m.hasIPv6() && len(v6Prefixes) > 0 {
+ if err := m.router6.UpdateSet(set, v6Prefixes); err != nil {
+ return fmt.Errorf("update v6 set: %w", err)
+ }
+ }
+
+ return nil
}
// AddInboundDNAT adds an inbound DNAT rule redirecting traffic from NetBird peers to local services.
-func (m *Manager) AddInboundDNAT(localAddr netip.Addr, protocol firewall.Protocol, sourcePort, targetPort uint16) error {
+func (m *Manager) AddInboundDNAT(localAddr netip.Addr, protocol firewall.Protocol, originalPort, translatedPort uint16) error {
m.mutex.Lock()
defer m.mutex.Unlock()
- return m.router.AddInboundDNAT(localAddr, protocol, sourcePort, targetPort)
+ if localAddr.Is6() {
+ if !m.hasIPv6() {
+ return fmt.Errorf("add inbound DNAT: %w", firewall.ErrIPv6NotInitialized)
+ }
+ return m.router6.AddInboundDNAT(localAddr, protocol, originalPort, translatedPort)
+ }
+ return m.router.AddInboundDNAT(localAddr, protocol, originalPort, translatedPort)
}
// RemoveInboundDNAT removes an inbound DNAT rule.
-func (m *Manager) RemoveInboundDNAT(localAddr netip.Addr, protocol firewall.Protocol, sourcePort, targetPort uint16) error {
+func (m *Manager) RemoveInboundDNAT(localAddr netip.Addr, protocol firewall.Protocol, originalPort, translatedPort uint16) error {
m.mutex.Lock()
defer m.mutex.Unlock()
- return m.router.RemoveInboundDNAT(localAddr, protocol, sourcePort, targetPort)
+ if localAddr.Is6() {
+ if !m.hasIPv6() {
+ return fmt.Errorf("remove inbound DNAT: %w", firewall.ErrIPv6NotInitialized)
+ }
+ return m.router6.RemoveInboundDNAT(localAddr, protocol, originalPort, translatedPort)
+ }
+ return m.router.RemoveInboundDNAT(localAddr, protocol, originalPort, translatedPort)
}
// AddOutputDNAT adds an OUTPUT chain DNAT rule for locally-generated traffic.
-func (m *Manager) AddOutputDNAT(localAddr netip.Addr, protocol firewall.Protocol, sourcePort, targetPort uint16) error {
+func (m *Manager) AddOutputDNAT(localAddr netip.Addr, protocol firewall.Protocol, originalPort, translatedPort uint16) error {
m.mutex.Lock()
defer m.mutex.Unlock()
- return m.router.AddOutputDNAT(localAddr, protocol, sourcePort, targetPort)
+ if localAddr.Is6() {
+ if !m.hasIPv6() {
+ return fmt.Errorf("add output DNAT: %w", firewall.ErrIPv6NotInitialized)
+ }
+ return m.router6.AddOutputDNAT(localAddr, protocol, originalPort, translatedPort)
+ }
+ return m.router.AddOutputDNAT(localAddr, protocol, originalPort, translatedPort)
}
// RemoveOutputDNAT removes an OUTPUT chain DNAT rule.
-func (m *Manager) RemoveOutputDNAT(localAddr netip.Addr, protocol firewall.Protocol, sourcePort, targetPort uint16) error {
+func (m *Manager) RemoveOutputDNAT(localAddr netip.Addr, protocol firewall.Protocol, originalPort, translatedPort uint16) error {
m.mutex.Lock()
defer m.mutex.Unlock()
- return m.router.RemoveOutputDNAT(localAddr, protocol, sourcePort, targetPort)
+ if localAddr.Is6() {
+ if !m.hasIPv6() {
+ return fmt.Errorf("remove output DNAT: %w", firewall.ErrIPv6NotInitialized)
+ }
+ return m.router6.RemoveOutputDNAT(localAddr, protocol, originalPort, translatedPort)
+ }
+ return m.router.RemoveOutputDNAT(localAddr, protocol, originalPort, translatedPort)
}
const (
diff --git a/client/firewall/iptables/router_linux.go b/client/firewall/iptables/router_linux.go
index a7c4f67dd..290e5da1e 100644
--- a/client/firewall/iptables/router_linux.go
+++ b/client/firewall/iptables/router_linux.go
@@ -54,8 +54,10 @@ const (
snatSuffix = "_snat"
fwdSuffix = "_fwd"
- // ipTCPHeaderMinSize represents minimum IP (20) + TCP (20) header size for MSS calculation
- ipTCPHeaderMinSize = 40
+ // ipv4TCPHeaderSize is the minimum IPv4 (20) + TCP (20) header size for MSS calculation.
+ ipv4TCPHeaderSize = 40
+ // ipv6TCPHeaderSize is the minimum IPv6 (40) + TCP (20) header size for MSS calculation.
+ ipv6TCPHeaderSize = 60
)
type ruleInfo struct {
@@ -86,6 +88,7 @@ type router struct {
wgIface iFaceMapper
legacyManagement bool
mtu uint16
+ v6 bool
stateManager *statemanager.Manager
ipFwdState *ipfwdstate.IPForwardingState
@@ -97,6 +100,7 @@ func newRouter(iptablesClient *iptables.IPTables, wgIface iFaceMapper, mtu uint1
rules: make(map[string][]string),
wgIface: wgIface,
mtu: mtu,
+ v6: iptablesClient.Proto() == iptables.ProtocolIPv6,
ipFwdState: ipfwdstate.NewIPForwardingState(),
}
@@ -186,6 +190,11 @@ func (r *router) AddRouteFiltering(
return ruleKey, nil
}
+func (r *router) hasRule(id string) bool {
+ _, ok := r.rules[id]
+ return ok
+}
+
func (r *router) DeleteRouteRule(rule firewall.Rule) error {
ruleKey := rule.ID()
@@ -392,9 +401,13 @@ func (r *router) cleanUpDefaultForwardRules() error {
// Remove jump rules from built-in chains before deleting custom chains,
// otherwise the chain deletion fails with "device or resource busy".
- jumpRule := []string{"-j", chainNATOutput}
- if err := r.iptablesClient.Delete(tableNat, "OUTPUT", jumpRule...); err != nil {
- log.Debugf("clean OUTPUT jump rule: %v", err)
+ if ok, err := r.iptablesClient.ChainExists(tableNat, chainNATOutput); err != nil {
+ return fmt.Errorf("check chain %s: %w", chainNATOutput, err)
+ } else if ok {
+ jumpRule := []string{"-j", chainNATOutput}
+ if err := r.iptablesClient.Delete(tableNat, "OUTPUT", jumpRule...); err != nil {
+ log.Debugf("clean OUTPUT jump rule: %v", err)
+ }
}
for _, chainInfo := range []struct {
@@ -434,6 +447,12 @@ func (r *router) createContainers() error {
{chainRTRDR, tableNat},
{chainRTMSSCLAMP, tableMangle},
} {
+ // Fallback: clear chains that survived an unclean shutdown.
+ if ok, _ := r.iptablesClient.ChainExists(chainInfo.table, chainInfo.chain); ok {
+ if err := r.iptablesClient.ClearAndDeleteChain(chainInfo.table, chainInfo.chain); err != nil {
+ log.Warnf("clear stale chain %s in %s: %v", chainInfo.chain, chainInfo.table, err)
+ }
+ }
if err := r.iptablesClient.NewChain(chainInfo.table, chainInfo.chain); err != nil {
return fmt.Errorf("create chain %s in table %s: %w", chainInfo.chain, chainInfo.table, err)
}
@@ -540,9 +559,12 @@ func (r *router) addPostroutingRules() error {
}
// addMSSClampingRules adds MSS clamping rules to prevent fragmentation for forwarded traffic.
-// TODO: Add IPv6 support
func (r *router) addMSSClampingRules() error {
- mss := r.mtu - ipTCPHeaderMinSize
+ overhead := uint16(ipv4TCPHeaderSize)
+ if r.v6 {
+ overhead = ipv6TCPHeaderSize
+ }
+ mss := r.mtu - overhead
// Add jump rule from FORWARD chain in mangle table to our custom chain
jumpRule := []string{
@@ -727,8 +749,13 @@ func (r *router) updateState() {
currentState.Lock()
defer currentState.Unlock()
- currentState.RouteRules = r.rules
- currentState.RouteIPsetCounter = r.ipsetCounter
+ if r.v6 {
+ currentState.RouteRules6 = r.rules
+ currentState.RouteIPsetCounter6 = r.ipsetCounter
+ } else {
+ currentState.RouteRules = r.rules
+ currentState.RouteIPsetCounter = r.ipsetCounter
+ }
if err := r.stateManager.UpdateState(currentState); err != nil {
log.Errorf("failed to update state: %v", err)
@@ -856,7 +883,7 @@ func (r *router) DeleteDNATRule(rule firewall.Rule) error {
}
if fwdRule, exists := r.rules[ruleKey+fwdSuffix]; exists {
- if err := r.iptablesClient.Delete(tableFilter, chainRTFWDIN, fwdRule...); err != nil {
+ if err := r.iptablesClient.Delete(tableFilter, chainRTFWDOUT, fwdRule...); err != nil {
merr = multierror.Append(merr, fmt.Errorf("delete forward rule: %w", err))
}
delete(r.rules, ruleKey+fwdSuffix)
@@ -883,7 +910,7 @@ func (r *router) genRouteRuleSpec(params routeFilteringRuleParams, sources []net
rule = append(rule, destExp...)
if params.Proto != firewall.ProtocolALL {
- rule = append(rule, "-p", strings.ToLower(string(params.Proto)))
+ rule = append(rule, "-p", strings.ToLower(protoForFamily(params.Proto, r.v6)))
rule = append(rule, applyPort("--sport", params.SPort)...)
rule = append(rule, applyPort("--dport", params.DPort)...)
}
@@ -900,11 +927,12 @@ func (r *router) applyNetwork(flag string, network firewall.Network, prefixes []
}
if network.IsSet() {
- if _, err := r.ipsetCounter.Increment(network.Set.HashedName(), prefixes); err != nil {
+ name := r.ipsetName(network.Set.HashedName())
+ if _, err := r.ipsetCounter.Increment(name, prefixes); err != nil {
return nil, fmt.Errorf("create or get ipset: %w", err)
}
- return []string{"-m", "set", matchSet, network.Set.HashedName(), direction}, nil
+ return []string{"-m", "set", matchSet, name, direction}, nil
}
if network.IsPrefix() {
return []string{flag, network.Prefix.String()}, nil
@@ -915,27 +943,23 @@ func (r *router) applyNetwork(flag string, network firewall.Network, prefixes []
}
func (r *router) UpdateSet(set firewall.Set, prefixes []netip.Prefix) error {
+ name := r.ipsetName(set.HashedName())
var merr *multierror.Error
for _, prefix := range prefixes {
- // TODO: Implement IPv6 support
- if prefix.Addr().Is6() {
- log.Tracef("skipping IPv6 prefix %s: IPv6 support not yet implemented", prefix)
- continue
- }
- if err := r.addPrefixToIPSet(set.HashedName(), prefix); err != nil {
+ if err := r.addPrefixToIPSet(name, prefix); err != nil {
merr = multierror.Append(merr, fmt.Errorf("add prefix to ipset: %w", err))
}
}
if merr == nil {
- log.Debugf("updated set %s with prefixes %v", set.HashedName(), prefixes)
+ log.Debugf("updated set %s with prefixes %v", name, prefixes)
}
return nberrors.FormatErrorOrNil(merr)
}
// AddInboundDNAT adds an inbound DNAT rule redirecting traffic from NetBird peers to local services.
-func (r *router) AddInboundDNAT(localAddr netip.Addr, protocol firewall.Protocol, sourcePort, targetPort uint16) error {
- ruleID := fmt.Sprintf("inbound-dnat-%s-%s-%d-%d", localAddr.String(), protocol, sourcePort, targetPort)
+func (r *router) AddInboundDNAT(localAddr netip.Addr, protocol firewall.Protocol, originalPort, translatedPort uint16) error {
+ ruleID := fmt.Sprintf("inbound-dnat-%s-%s-%d-%d", localAddr.String(), protocol, originalPort, translatedPort)
if _, exists := r.rules[ruleID]; exists {
return nil
@@ -943,12 +967,12 @@ func (r *router) AddInboundDNAT(localAddr netip.Addr, protocol firewall.Protocol
dnatRule := []string{
"-i", r.wgIface.Name(),
- "-p", strings.ToLower(string(protocol)),
- "--dport", strconv.Itoa(int(sourcePort)),
+ "-p", strings.ToLower(protoForFamily(protocol, r.v6)),
+ "--dport", strconv.Itoa(int(originalPort)),
"-d", localAddr.String(),
"-m", "addrtype", "--dst-type", "LOCAL",
"-j", "DNAT",
- "--to-destination", ":" + strconv.Itoa(int(targetPort)),
+ "--to-destination", ":" + strconv.Itoa(int(translatedPort)),
}
ruleInfo := ruleInfo{
@@ -967,8 +991,8 @@ func (r *router) AddInboundDNAT(localAddr netip.Addr, protocol firewall.Protocol
}
// RemoveInboundDNAT removes an inbound DNAT rule.
-func (r *router) RemoveInboundDNAT(localAddr netip.Addr, protocol firewall.Protocol, sourcePort, targetPort uint16) error {
- ruleID := fmt.Sprintf("inbound-dnat-%s-%s-%d-%d", localAddr.String(), protocol, sourcePort, targetPort)
+func (r *router) RemoveInboundDNAT(localAddr netip.Addr, protocol firewall.Protocol, originalPort, translatedPort uint16) error {
+ ruleID := fmt.Sprintf("inbound-dnat-%s-%s-%d-%d", localAddr.String(), protocol, originalPort, translatedPort)
if dnatRule, exists := r.rules[ruleID]; exists {
if err := r.iptablesClient.Delete(tableNat, chainRTRDR, dnatRule...); err != nil {
@@ -1013,8 +1037,8 @@ func (r *router) ensureNATOutputChain() error {
}
// AddOutputDNAT adds an OUTPUT chain DNAT rule for locally-generated traffic.
-func (r *router) AddOutputDNAT(localAddr netip.Addr, protocol firewall.Protocol, sourcePort, targetPort uint16) error {
- ruleID := fmt.Sprintf("output-dnat-%s-%s-%d-%d", localAddr.String(), protocol, sourcePort, targetPort)
+func (r *router) AddOutputDNAT(localAddr netip.Addr, protocol firewall.Protocol, originalPort, translatedPort uint16) error {
+ ruleID := fmt.Sprintf("output-dnat-%s-%s-%d-%d", localAddr.String(), protocol, originalPort, translatedPort)
if _, exists := r.rules[ruleID]; exists {
return nil
@@ -1025,11 +1049,11 @@ func (r *router) AddOutputDNAT(localAddr netip.Addr, protocol firewall.Protocol,
}
dnatRule := []string{
- "-p", strings.ToLower(string(protocol)),
- "--dport", strconv.Itoa(int(sourcePort)),
+ "-p", strings.ToLower(protoForFamily(protocol, localAddr.Is6())),
+ "--dport", strconv.Itoa(int(originalPort)),
"-d", localAddr.String(),
"-j", "DNAT",
- "--to-destination", ":" + strconv.Itoa(int(targetPort)),
+ "--to-destination", ":" + strconv.Itoa(int(translatedPort)),
}
if err := r.iptablesClient.Append(tableNat, chainNATOutput, dnatRule...); err != nil {
@@ -1042,8 +1066,8 @@ func (r *router) AddOutputDNAT(localAddr netip.Addr, protocol firewall.Protocol,
}
// RemoveOutputDNAT removes an OUTPUT chain DNAT rule.
-func (r *router) RemoveOutputDNAT(localAddr netip.Addr, protocol firewall.Protocol, sourcePort, targetPort uint16) error {
- ruleID := fmt.Sprintf("output-dnat-%s-%s-%d-%d", localAddr.String(), protocol, sourcePort, targetPort)
+func (r *router) RemoveOutputDNAT(localAddr netip.Addr, protocol firewall.Protocol, originalPort, translatedPort uint16) error {
+ ruleID := fmt.Sprintf("output-dnat-%s-%s-%d-%d", localAddr.String(), protocol, originalPort, translatedPort)
if dnatRule, exists := r.rules[ruleID]; exists {
if err := r.iptablesClient.Delete(tableNat, chainNATOutput, dnatRule...); err != nil {
@@ -1076,10 +1100,22 @@ func applyPort(flag string, port *firewall.Port) []string {
return []string{flag, strconv.Itoa(int(port.Values[0]))}
}
+// ipsetName returns the ipset name, suffixed with "-v6" for the v6 router
+// to avoid collisions since ipsets are global in the kernel.
+func (r *router) ipsetName(name string) string {
+ if r.v6 {
+ return name + "-v6"
+ }
+ return name
+}
+
func (r *router) createIPSet(name string) error {
opts := ipset.CreateOptions{
Replace: true,
}
+ if r.v6 {
+ opts.Family = ipset.FamilyIPV6
+ }
if err := ipset.Create(name, ipset.TypeHashNet, opts); err != nil {
return fmt.Errorf("create ipset %s: %w", name, err)
diff --git a/client/firewall/iptables/rule.go b/client/firewall/iptables/rule.go
index aa4d2d079..4f4eab167 100644
--- a/client/firewall/iptables/rule.go
+++ b/client/firewall/iptables/rule.go
@@ -9,6 +9,7 @@ type Rule struct {
mangleSpecs []string
ip string
chain string
+ v6 bool
}
// GetRuleID returns the rule id
diff --git a/client/firewall/iptables/state_linux.go b/client/firewall/iptables/state_linux.go
index 121c755e9..f4be37d01 100644
--- a/client/firewall/iptables/state_linux.go
+++ b/client/firewall/iptables/state_linux.go
@@ -4,6 +4,8 @@ import (
"fmt"
"sync"
+ log "github.com/sirupsen/logrus"
+
"github.com/netbirdio/netbird/client/iface"
"github.com/netbirdio/netbird/client/iface/wgaddr"
)
@@ -32,6 +34,12 @@ type ShutdownState struct {
ACLEntries aclEntries `json:"acl_entries,omitempty"`
ACLIPsetStore *ipsetStore `json:"acl_ipset_store,omitempty"`
+
+ // IPv6 counterparts
+ RouteRules6 routeRules `json:"route_rules_v6,omitempty"`
+ RouteIPsetCounter6 *ipsetCounter `json:"route_ipset_counter_v6,omitempty"`
+ ACLEntries6 aclEntries `json:"acl_entries_v6,omitempty"`
+ ACLIPsetStore6 *ipsetStore `json:"acl_ipset_store_v6,omitempty"`
}
func (s *ShutdownState) Name() string {
@@ -62,6 +70,28 @@ func (s *ShutdownState) Cleanup() error {
ipt.aclMgr.ipsetStore = s.ACLIPsetStore
}
+ // Clean up v6 state even if the current run has no IPv6.
+ // The previous run may have left ip6tables rules behind.
+ if !ipt.hasIPv6() {
+ if err := ipt.createIPv6Components(s.InterfaceState, mtu); err != nil {
+ log.Warnf("failed to create v6 components for cleanup: %v", err)
+ }
+ }
+ if ipt.hasIPv6() {
+ if s.RouteRules6 != nil {
+ ipt.router6.rules = s.RouteRules6
+ }
+ if s.RouteIPsetCounter6 != nil {
+ ipt.router6.ipsetCounter.LoadData(s.RouteIPsetCounter6)
+ }
+ if s.ACLEntries6 != nil {
+ ipt.aclMgr6.entries = s.ACLEntries6
+ }
+ if s.ACLIPsetStore6 != nil {
+ ipt.aclMgr6.ipsetStore = s.ACLIPsetStore6
+ }
+ }
+
if err := ipt.Close(nil); err != nil {
return fmt.Errorf("reset iptables manager: %w", err)
}
diff --git a/client/firewall/manager/firewall.go b/client/firewall/manager/firewall.go
index d65d717b3..149c6db83 100644
--- a/client/firewall/manager/firewall.go
+++ b/client/firewall/manager/firewall.go
@@ -1,6 +1,7 @@
package manager
import (
+ "errors"
"fmt"
"net"
"net/netip"
@@ -11,6 +12,10 @@ import (
"github.com/netbirdio/netbird/client/internal/statemanager"
)
+// ErrIPv6NotInitialized is returned when an IPv6 address is passed to a firewall
+// method but the IPv6 firewall components were not initialized.
+var ErrIPv6NotInitialized = errors.New("IPv6 firewall not initialized")
+
const (
ForwardingFormatPrefix = "netbird-fwd-"
ForwardingFormat = "netbird-fwd-%s-%t"
@@ -164,18 +169,16 @@ type Manager interface {
UpdateSet(hash Set, prefixes []netip.Prefix) error
// AddInboundDNAT adds an inbound DNAT rule redirecting traffic from NetBird peers to local services
- AddInboundDNAT(localAddr netip.Addr, protocol Protocol, sourcePort, targetPort uint16) error
+ AddInboundDNAT(localAddr netip.Addr, protocol Protocol, originalPort, translatedPort uint16) error
// RemoveInboundDNAT removes inbound DNAT rule
- RemoveInboundDNAT(localAddr netip.Addr, protocol Protocol, sourcePort, targetPort uint16) error
+ RemoveInboundDNAT(localAddr netip.Addr, protocol Protocol, originalPort, translatedPort uint16) error
// AddOutputDNAT adds an OUTPUT chain DNAT rule for locally-generated traffic.
- // localAddr must be IPv4; the underlying iptables/nftables backends are IPv4-only.
- AddOutputDNAT(localAddr netip.Addr, protocol Protocol, sourcePort, targetPort uint16) error
+ AddOutputDNAT(localAddr netip.Addr, protocol Protocol, originalPort, translatedPort uint16) error
// RemoveOutputDNAT removes an OUTPUT chain DNAT rule.
- // localAddr must be IPv4; the underlying iptables/nftables backends are IPv4-only.
- RemoveOutputDNAT(localAddr netip.Addr, protocol Protocol, sourcePort, targetPort uint16) error
+ RemoveOutputDNAT(localAddr netip.Addr, protocol Protocol, originalPort, translatedPort uint16) error
// SetupEBPFProxyNoTrack creates static notrack rules for eBPF proxy loopback traffic.
// This prevents conntrack from interfering with WireGuard proxy communication.
diff --git a/client/firewall/manager/routerpair.go b/client/firewall/manager/routerpair.go
index 079c051d9..096f8b9bb 100644
--- a/client/firewall/manager/routerpair.go
+++ b/client/firewall/manager/routerpair.go
@@ -1,6 +1,8 @@
package manager
import (
+ "net/netip"
+
"github.com/netbirdio/netbird/route"
)
@@ -10,6 +12,10 @@ type RouterPair struct {
Destination Network
Masquerade bool
Inverse bool
+ // Dynamic indicates the route is domain-based. NAT rules for dynamic
+ // routes are duplicated to the v6 table so that resolved AAAA records
+ // are masqueraded correctly.
+ Dynamic bool
}
func GetInversePair(pair RouterPair) RouterPair {
@@ -20,5 +26,17 @@ func GetInversePair(pair RouterPair) RouterPair {
Destination: pair.Source,
Masquerade: pair.Masquerade,
Inverse: true,
+ Dynamic: pair.Dynamic,
}
}
+
+// ToV6NatPair creates a v6 counterpart of a v4 NAT pair with `::/0` source
+// and, for prefix destinations, `::/0` destination.
+func ToV6NatPair(pair RouterPair) RouterPair {
+ v6 := pair
+ v6.Source = Network{Prefix: netip.PrefixFrom(netip.IPv6Unspecified(), 0)}
+ if v6.Destination.IsPrefix() {
+ v6.Destination = Network{Prefix: netip.PrefixFrom(netip.IPv6Unspecified(), 0)}
+ }
+ return v6
+}
diff --git a/client/firewall/nftables/acl_linux.go b/client/firewall/nftables/acl_linux.go
index a9d066e2f..9d2ea7264 100644
--- a/client/firewall/nftables/acl_linux.go
+++ b/client/firewall/nftables/acl_linux.go
@@ -33,15 +33,12 @@ const (
const flushError = "flush: %w"
-var (
- anyIP = []byte{0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}
-)
-
type AclManager struct {
rConn *nftables.Conn
sConn *nftables.Conn
wgIface iFaceMapper
routingFwChainName string
+ af addrFamily
workTable *nftables.Table
chainInputRules *nftables.Chain
@@ -67,6 +64,7 @@ func newAclManager(table *nftables.Table, wgIface iFaceMapper, routingFwChainNam
wgIface: wgIface,
workTable: table,
routingFwChainName: routingFwChainName,
+ af: familyForAddr(table.Family == nftables.TableFamilyIPv4),
ipsetStore: newIpsetStore(),
rules: make(map[string]*Rule),
@@ -145,7 +143,7 @@ func (m *AclManager) DeletePeerRule(rule firewall.Rule) error {
}
if _, ok := ips[r.ip.String()]; ok {
- err := m.sConn.SetDeleteElements(r.nftSet, []nftables.SetElement{{Key: r.ip.To4()}})
+ err := m.sConn.SetDeleteElements(r.nftSet, []nftables.SetElement{{Key: ipToBytes(r.ip, m.af)}})
if err != nil {
log.Errorf("delete elements for set %q: %v", r.nftSet.Name, err)
}
@@ -254,11 +252,11 @@ func (m *AclManager) addIOFiltering(
expressions = append(expressions, &expr.Payload{
DestRegister: 1,
Base: expr.PayloadBaseNetworkHeader,
- Offset: uint32(9),
+ Offset: m.af.protoOffset,
Len: uint32(1),
})
- protoData, err := protoToInt(proto)
+ protoData, err := m.af.protoNum(proto)
if err != nil {
return nil, fmt.Errorf("convert protocol to number: %v", err)
}
@@ -270,19 +268,16 @@ func (m *AclManager) addIOFiltering(
})
}
- rawIP := ip.To4()
+ rawIP := ipToBytes(ip, m.af)
// check if rawIP contains zeroed IPv4 0.0.0.0 value
// in that case not add IP match expression into the rule definition
- if !bytes.HasPrefix(anyIP, rawIP) {
- // source address position
- addrOffset := uint32(12)
-
+ if slices.ContainsFunc(rawIP, func(v byte) bool { return v != 0 }) {
expressions = append(expressions,
&expr.Payload{
DestRegister: 1,
Base: expr.PayloadBaseNetworkHeader,
- Offset: addrOffset,
- Len: 4,
+ Offset: m.af.srcAddrOffset,
+ Len: m.af.addrLen,
},
)
// add individual IP for match if no ipset defined
@@ -587,7 +582,7 @@ func (m *AclManager) addJumpRule(chain *nftables.Chain, to string, ifaceKey expr
func (m *AclManager) addIpToSet(ipsetName string, ip net.IP) (*nftables.Set, error) {
ipset, err := m.rConn.GetSetByName(m.workTable, ipsetName)
- rawIP := ip.To4()
+ rawIP := ipToBytes(ip, m.af)
if err != nil {
if ipset, err = m.createSet(m.workTable, ipsetName); err != nil {
return nil, fmt.Errorf("get set name: %v", err)
@@ -619,7 +614,7 @@ func (m *AclManager) createSet(table *nftables.Table, name string) (*nftables.Se
Name: name,
Table: table,
Dynamic: true,
- KeyType: nftables.TypeIPAddr,
+ KeyType: m.af.setKeyType,
}
if err := m.rConn.AddSet(ipset, nil); err != nil {
@@ -707,15 +702,12 @@ func ifname(n string) []byte {
return b
}
-func protoToInt(protocol firewall.Protocol) (uint8, error) {
- switch protocol {
- case firewall.ProtocolTCP:
- return unix.IPPROTO_TCP, nil
- case firewall.ProtocolUDP:
- return unix.IPPROTO_UDP, nil
- case firewall.ProtocolICMP:
- return unix.IPPROTO_ICMP, nil
- }
- return 0, fmt.Errorf("unsupported protocol: %s", protocol)
+// ipToBytes converts net.IP to the correct byte length for the address family.
+func ipToBytes(ip net.IP, af addrFamily) []byte {
+ if af.addrLen == 4 {
+ return ip.To4()
+ }
+ return ip.To16()
}
+
diff --git a/client/firewall/nftables/addr_family_linux.go b/client/firewall/nftables/addr_family_linux.go
new file mode 100644
index 000000000..0c90d704a
--- /dev/null
+++ b/client/firewall/nftables/addr_family_linux.go
@@ -0,0 +1,81 @@
+package nftables
+
+import (
+ "fmt"
+ "net"
+
+ "github.com/google/nftables"
+ "golang.org/x/sys/unix"
+
+ firewall "github.com/netbirdio/netbird/client/firewall/manager"
+)
+
+var (
+ // afIPv4 defines IPv4 header layout and nftables types.
+ afIPv4 = addrFamily{
+ protoOffset: 9,
+ srcAddrOffset: 12,
+ dstAddrOffset: 16,
+ addrLen: net.IPv4len,
+ totalBits: 8 * net.IPv4len,
+ setKeyType: nftables.TypeIPAddr,
+ tableFamily: nftables.TableFamilyIPv4,
+ icmpProto: unix.IPPROTO_ICMP,
+ }
+ // afIPv6 defines IPv6 header layout and nftables types.
+ afIPv6 = addrFamily{
+ protoOffset: 6,
+ srcAddrOffset: 8,
+ dstAddrOffset: 24,
+ addrLen: net.IPv6len,
+ totalBits: 8 * net.IPv6len,
+ setKeyType: nftables.TypeIP6Addr,
+ tableFamily: nftables.TableFamilyIPv6,
+ icmpProto: unix.IPPROTO_ICMPV6,
+ }
+)
+
+// addrFamily holds protocol-specific constants for nftables expression building.
+type addrFamily struct {
+ // protoOffset is the IP header offset for the protocol/next-header field (9 for v4, 6 for v6)
+ protoOffset uint32
+ // srcAddrOffset is the IP header offset for the source address (12 for v4, 8 for v6)
+ srcAddrOffset uint32
+ // dstAddrOffset is the IP header offset for the destination address (16 for v4, 24 for v6)
+ dstAddrOffset uint32
+ // addrLen is the byte length of addresses (4 for v4, 16 for v6)
+ addrLen uint32
+ // totalBits is the address size in bits (32 for v4, 128 for v6)
+ totalBits int
+ // setKeyType is the nftables set data type for addresses
+ setKeyType nftables.SetDatatype
+ // tableFamily is the nftables table family
+ tableFamily nftables.TableFamily
+ // icmpProto is the ICMP protocol number for this family (1 for v4, 58 for v6)
+ icmpProto uint8
+}
+
+// familyForAddr returns the address family for the given IP.
+func familyForAddr(is4 bool) addrFamily {
+ if is4 {
+ return afIPv4
+ }
+ return afIPv6
+}
+
+// protoNum converts a firewall protocol to the IP protocol number,
+// using the correct ICMP variant for the address family.
+func (af addrFamily) protoNum(protocol firewall.Protocol) (uint8, error) {
+ switch protocol {
+ case firewall.ProtocolTCP:
+ return unix.IPPROTO_TCP, nil
+ case firewall.ProtocolUDP:
+ return unix.IPPROTO_UDP, nil
+ case firewall.ProtocolICMP:
+ return af.icmpProto, nil
+ case firewall.ProtocolALL:
+ return 0, nil
+ default:
+ return 0, fmt.Errorf("unsupported protocol: %s", protocol)
+ }
+}
diff --git a/client/firewall/nftables/external_chain_monitor_integration_linux_test.go b/client/firewall/nftables/external_chain_monitor_integration_linux_test.go
new file mode 100644
index 000000000..3c4e3f44d
--- /dev/null
+++ b/client/firewall/nftables/external_chain_monitor_integration_linux_test.go
@@ -0,0 +1,76 @@
+//go:build linux
+
+package nftables
+
+import (
+ "os"
+ "sync/atomic"
+ "testing"
+ "time"
+
+ "github.com/google/nftables"
+ "github.com/stretchr/testify/require"
+)
+
+// TestExternalChainMonitorRootIntegration verifies that adding a new chain
+// in an external (non-netbird) filter table triggers the reconciler.
+// Requires CAP_NET_ADMIN; skip otherwise.
+func TestExternalChainMonitorRootIntegration(t *testing.T) {
+ if os.Geteuid() != 0 {
+ t.Skip("root required")
+ }
+
+ calls := make(chan struct{}, 8)
+ var count atomic.Int32
+ rec := &countingReconciler{calls: calls, count: &count}
+
+ m := newExternalChainMonitor(rec)
+ m.start()
+ t.Cleanup(m.stop)
+
+ // Give the netlink subscription a moment to register.
+ time.Sleep(200 * time.Millisecond)
+
+ conn := &nftables.Conn{}
+ table := conn.AddTable(&nftables.Table{
+ Name: "nbmon_integration_test",
+ Family: nftables.TableFamilyINet,
+ })
+ t.Cleanup(func() {
+ cleanup := &nftables.Conn{}
+ cleanup.DelTable(table)
+ _ = cleanup.Flush()
+ })
+
+ chain := conn.AddChain(&nftables.Chain{
+ Name: "filter_INPUT",
+ Table: table,
+ Hooknum: nftables.ChainHookInput,
+ Priority: nftables.ChainPriorityFilter,
+ Type: nftables.ChainTypeFilter,
+ })
+ _ = chain
+ require.NoError(t, conn.Flush(), "create external test chain")
+
+ select {
+ case <-calls:
+ // success
+ case <-time.After(3 * time.Second):
+ t.Fatalf("reconcile was not invoked after creating an external chain")
+ }
+ require.GreaterOrEqual(t, count.Load(), int32(1))
+}
+
+type countingReconciler struct {
+ calls chan struct{}
+ count *atomic.Int32
+}
+
+func (c *countingReconciler) reconcileExternalChains() error {
+ c.count.Add(1)
+ select {
+ case c.calls <- struct{}{}:
+ default:
+ }
+ return nil
+}
diff --git a/client/firewall/nftables/external_chain_monitor_linux.go b/client/firewall/nftables/external_chain_monitor_linux.go
new file mode 100644
index 000000000..9c91c95cf
--- /dev/null
+++ b/client/firewall/nftables/external_chain_monitor_linux.go
@@ -0,0 +1,200 @@
+package nftables
+
+import (
+ "context"
+ "errors"
+ "fmt"
+ "sync"
+ "time"
+
+ "github.com/cenkalti/backoff/v4"
+ "github.com/google/nftables"
+ log "github.com/sirupsen/logrus"
+)
+
+const (
+ externalMonitorReconcileDelay = 500 * time.Millisecond
+ externalMonitorInitInterval = 5 * time.Second
+ externalMonitorMaxInterval = 5 * time.Minute
+ externalMonitorRandomization = 0.5
+)
+
+// externalChainReconciler re-applies passthrough accept rules to external
+// nftables chains. Implementations must be safe to call from the monitor
+// goroutine; the Manager locks its mutex internally.
+type externalChainReconciler interface {
+ reconcileExternalChains() error
+}
+
+// externalChainMonitor watches nftables netlink events and triggers a
+// reconcile when a new table or chain appears (e.g. after
+// `firewall-cmd --reload`). Netlink errors trigger exponential-backoff
+// reconnect.
+type externalChainMonitor struct {
+ reconciler externalChainReconciler
+
+ mu sync.Mutex
+ cancel context.CancelFunc
+ done chan struct{}
+}
+
+func newExternalChainMonitor(r externalChainReconciler) *externalChainMonitor {
+ return &externalChainMonitor{reconciler: r}
+}
+
+func (m *externalChainMonitor) start() {
+ m.mu.Lock()
+ defer m.mu.Unlock()
+
+ if m.cancel != nil {
+ return
+ }
+
+ ctx, cancel := context.WithCancel(context.Background())
+ m.cancel = cancel
+ done := make(chan struct{})
+ m.done = done
+
+ go m.run(ctx, done)
+}
+
+func (m *externalChainMonitor) stop() {
+ m.mu.Lock()
+ cancel := m.cancel
+ done := m.done
+ m.cancel = nil
+ m.done = nil
+ m.mu.Unlock()
+
+ if cancel == nil {
+ return
+ }
+ cancel()
+ <-done
+}
+
+func (m *externalChainMonitor) run(ctx context.Context, done chan struct{}) {
+ defer close(done)
+
+ bo := &backoff.ExponentialBackOff{
+ InitialInterval: externalMonitorInitInterval,
+ RandomizationFactor: externalMonitorRandomization,
+ Multiplier: backoff.DefaultMultiplier,
+ MaxInterval: externalMonitorMaxInterval,
+ MaxElapsedTime: 0,
+ Clock: backoff.SystemClock,
+ }
+ bo.Reset()
+
+ for ctx.Err() == nil {
+ err := m.watch(ctx)
+ if ctx.Err() != nil {
+ return
+ }
+
+ delay := bo.NextBackOff()
+ log.Warnf("external chain monitor: %v, reconnecting in %s", err, delay)
+ select {
+ case <-ctx.Done():
+ return
+ case <-time.After(delay):
+ }
+ }
+}
+
+func (m *externalChainMonitor) watch(ctx context.Context) error {
+ events, closeMon, err := m.subscribe()
+ if err != nil {
+ return err
+ }
+ defer closeMon()
+
+ debounce := time.NewTimer(time.Hour)
+ if !debounce.Stop() {
+ <-debounce.C
+ }
+ defer debounce.Stop()
+
+ pending := false
+ for {
+ select {
+ case <-ctx.Done():
+ return nil
+ case <-debounce.C:
+ pending = false
+ m.reconcile()
+ case ev, ok := <-events:
+ if !ok {
+ return errors.New("monitor channel closed")
+ }
+ if ev.Error != nil {
+ return fmt.Errorf("monitor event: %w", ev.Error)
+ }
+ if !isRelevantMonitorEvent(ev) {
+ continue
+ }
+ resetDebounce(debounce, pending)
+ pending = true
+ }
+ }
+}
+
+func (m *externalChainMonitor) subscribe() (chan *nftables.MonitorEvent, func(), error) {
+ conn := &nftables.Conn{}
+ mon := nftables.NewMonitor(
+ nftables.WithMonitorAction(nftables.MonitorActionNew),
+ nftables.WithMonitorObject(nftables.MonitorObjectChains|nftables.MonitorObjectTables),
+ )
+ events, err := conn.AddMonitor(mon)
+ if err != nil {
+ return nil, nil, fmt.Errorf("add netlink monitor: %w", err)
+ }
+ return events, func() { _ = mon.Close() }, nil
+}
+
+// resetDebounce reschedules a pending debounce timer without leaking a stale
+// fire on its channel. pending must reflect whether the timer is armed.
+func resetDebounce(t *time.Timer, pending bool) {
+ if pending && !t.Stop() {
+ select {
+ case <-t.C:
+ default:
+ }
+ }
+ t.Reset(externalMonitorReconcileDelay)
+}
+
+func (m *externalChainMonitor) reconcile() {
+ if err := m.reconciler.reconcileExternalChains(); err != nil {
+ log.Warnf("reconcile external chain rules: %v", err)
+ }
+}
+
+// isRelevantMonitorEvent returns true for table/chain creation events on
+// families we care about. The reconciler filters to actual external filter
+// chains.
+func isRelevantMonitorEvent(ev *nftables.MonitorEvent) bool {
+ switch ev.Type {
+ case nftables.MonitorEventTypeNewChain:
+ chain, ok := ev.Data.(*nftables.Chain)
+ if !ok || chain == nil || chain.Table == nil {
+ return false
+ }
+ return isMonitoredFamily(chain.Table.Family)
+ case nftables.MonitorEventTypeNewTable:
+ table, ok := ev.Data.(*nftables.Table)
+ if !ok || table == nil {
+ return false
+ }
+ return isMonitoredFamily(table.Family)
+ }
+ return false
+}
+
+func isMonitoredFamily(family nftables.TableFamily) bool {
+ switch family {
+ case nftables.TableFamilyIPv4, nftables.TableFamilyIPv6, nftables.TableFamilyINet:
+ return true
+ }
+ return false
+}
diff --git a/client/firewall/nftables/external_chain_monitor_linux_test.go b/client/firewall/nftables/external_chain_monitor_linux_test.go
new file mode 100644
index 000000000..1a37faca2
--- /dev/null
+++ b/client/firewall/nftables/external_chain_monitor_linux_test.go
@@ -0,0 +1,137 @@
+package nftables
+
+import (
+ "testing"
+
+ "github.com/google/nftables"
+ "github.com/stretchr/testify/assert"
+)
+
+func TestIsMonitoredFamily(t *testing.T) {
+ tests := []struct {
+ family nftables.TableFamily
+ want bool
+ }{
+ {nftables.TableFamilyIPv4, true},
+ {nftables.TableFamilyIPv6, true},
+ {nftables.TableFamilyINet, true},
+ {nftables.TableFamilyARP, false},
+ {nftables.TableFamilyBridge, false},
+ {nftables.TableFamilyNetdev, false},
+ {nftables.TableFamilyUnspecified, false},
+ }
+ for _, tc := range tests {
+ assert.Equal(t, tc.want, isMonitoredFamily(tc.family), "family=%d", tc.family)
+ }
+}
+
+func TestIsRelevantMonitorEvent(t *testing.T) {
+ inetTable := &nftables.Table{Name: "firewalld", Family: nftables.TableFamilyINet}
+ ipTable := &nftables.Table{Name: "filter", Family: nftables.TableFamilyIPv4}
+ arpTable := &nftables.Table{Name: "arp", Family: nftables.TableFamilyARP}
+
+ tests := []struct {
+ name string
+ ev *nftables.MonitorEvent
+ want bool
+ }{
+ {
+ name: "new chain in inet firewalld",
+ ev: &nftables.MonitorEvent{
+ Type: nftables.MonitorEventTypeNewChain,
+ Data: &nftables.Chain{Name: "filter_INPUT", Table: inetTable},
+ },
+ want: true,
+ },
+ {
+ name: "new chain in ip filter",
+ ev: &nftables.MonitorEvent{
+ Type: nftables.MonitorEventTypeNewChain,
+ Data: &nftables.Chain{Name: "INPUT", Table: ipTable},
+ },
+ want: true,
+ },
+ {
+ name: "new chain in unwatched arp family",
+ ev: &nftables.MonitorEvent{
+ Type: nftables.MonitorEventTypeNewChain,
+ Data: &nftables.Chain{Name: "x", Table: arpTable},
+ },
+ want: false,
+ },
+ {
+ name: "new table inet",
+ ev: &nftables.MonitorEvent{
+ Type: nftables.MonitorEventTypeNewTable,
+ Data: inetTable,
+ },
+ want: true,
+ },
+ {
+ name: "del chain (we only act on new)",
+ ev: &nftables.MonitorEvent{
+ Type: nftables.MonitorEventTypeDelChain,
+ Data: &nftables.Chain{Name: "filter_INPUT", Table: inetTable},
+ },
+ want: false,
+ },
+ {
+ name: "chain with nil table",
+ ev: &nftables.MonitorEvent{
+ Type: nftables.MonitorEventTypeNewChain,
+ Data: &nftables.Chain{Name: "x"},
+ },
+ want: false,
+ },
+ {
+ name: "nil data",
+ ev: &nftables.MonitorEvent{
+ Type: nftables.MonitorEventTypeNewChain,
+ Data: (*nftables.Chain)(nil),
+ },
+ want: false,
+ },
+ }
+
+ for _, tc := range tests {
+ t.Run(tc.name, func(t *testing.T) {
+ assert.Equal(t, tc.want, isRelevantMonitorEvent(tc.ev))
+ })
+ }
+}
+
+// fakeReconciler records reconcile invocations for debounce tests.
+type fakeReconciler struct {
+ calls chan struct{}
+}
+
+func (f *fakeReconciler) reconcileExternalChains() error {
+ f.calls <- struct{}{}
+ return nil
+}
+
+func TestExternalChainMonitorStopWithoutStart(t *testing.T) {
+ m := newExternalChainMonitor(&fakeReconciler{calls: make(chan struct{}, 1)})
+ // Must not panic or block.
+ m.stop()
+}
+
+func TestExternalChainMonitorDoubleStart(t *testing.T) {
+ // start() twice should be a no-op; stop() cleans up once.
+ // We avoid exercising the netlink watch loop here because it needs root.
+ m := newExternalChainMonitor(&fakeReconciler{calls: make(chan struct{}, 1)})
+
+ // Replace run with a stub that just waits for cancel, so start() stays
+ // deterministic without opening a netlink socket.
+ origDone := make(chan struct{})
+ m.done = origDone
+ m.cancel = func() { close(origDone) }
+
+ // Second start should be a no-op (cancel already set).
+ m.start()
+ assert.NotNil(t, m.cancel)
+
+ m.stop()
+ assert.Nil(t, m.cancel)
+ assert.Nil(t, m.done)
+}
diff --git a/client/firewall/nftables/manager_linux.go b/client/firewall/nftables/manager_linux.go
index 8cd5cc6b3..fdc7c2f3c 100644
--- a/client/firewall/nftables/manager_linux.go
+++ b/client/firewall/nftables/manager_linux.go
@@ -11,9 +11,11 @@ import (
"github.com/google/nftables"
"github.com/google/nftables/binaryutil"
"github.com/google/nftables/expr"
+ "github.com/hashicorp/go-multierror"
log "github.com/sirupsen/logrus"
"golang.org/x/sys/unix"
+ nberrors "github.com/netbirdio/netbird/client/errors"
"github.com/netbirdio/netbird/client/firewall/firewalld"
firewall "github.com/netbirdio/netbird/client/firewall/manager"
"github.com/netbirdio/netbird/client/iface/wgaddr"
@@ -49,10 +51,17 @@ type Manager struct {
rConn *nftables.Conn
wgIface iFaceMapper
- router *router
- aclManager *AclManager
+ router *router
+ aclManager *AclManager
+
+ // IPv6 counterparts, nil when no v6 overlay
+ router6 *router
+ aclManager6 *AclManager
+
notrackOutputChain *nftables.Chain
notrackPreroutingChain *nftables.Chain
+
+ extMonitor *externalChainMonitor
}
// Create nftables firewall manager
@@ -62,7 +71,8 @@ func Create(wgIface iFaceMapper, mtu uint16) (*Manager, error) {
wgIface: wgIface,
}
- workTable := &nftables.Table{Name: getTableName(), Family: nftables.TableFamilyIPv4}
+ tableName := getTableName()
+ workTable := &nftables.Table{Name: tableName, Family: nftables.TableFamilyIPv4}
var err error
m.router, err = newRouter(workTable, wgIface, mtu)
@@ -75,35 +85,137 @@ func Create(wgIface iFaceMapper, mtu uint16) (*Manager, error) {
return nil, fmt.Errorf("create acl manager: %w", err)
}
+ if wgIface.Address().HasIPv6() {
+ if err := m.createIPv6Components(tableName, wgIface, mtu); err != nil {
+ return nil, fmt.Errorf("create IPv6 firewall: %w", err)
+ }
+ }
+
+ m.extMonitor = newExternalChainMonitor(m)
+
return m, nil
}
+func (m *Manager) createIPv6Components(tableName string, wgIface iFaceMapper, mtu uint16) error {
+ workTable6 := &nftables.Table{Name: tableName, Family: nftables.TableFamilyIPv6}
+
+ var err error
+ m.router6, err = newRouter(workTable6, wgIface, mtu)
+ if err != nil {
+ return fmt.Errorf("create v6 router: %w", err)
+ }
+
+ // Share the same IP forwarding state with the v4 router, since
+ // EnableIPForwarding controls both v4 and v6 sysctls.
+ m.router6.ipFwdState = m.router.ipFwdState
+
+ m.aclManager6, err = newAclManager(workTable6, wgIface, chainNameRoutingFw)
+ if err != nil {
+ return fmt.Errorf("create v6 acl manager: %w", err)
+ }
+
+ return nil
+}
+
+// hasIPv6 reports whether the manager has IPv6 components initialized.
+func (m *Manager) hasIPv6() bool {
+ return m.router6 != nil
+}
+
+func (m *Manager) initIPv6() error {
+ workTable6, err := m.createWorkTableFamily(nftables.TableFamilyIPv6)
+ if err != nil {
+ return fmt.Errorf("create v6 work table: %w", err)
+ }
+
+ if err := m.router6.init(workTable6); err != nil {
+ return fmt.Errorf("v6 router init: %w", err)
+ }
+
+ if err := m.aclManager6.init(workTable6); err != nil {
+ return fmt.Errorf("v6 acl manager init: %w", err)
+ }
+
+ return nil
+}
+
// Init nftables firewall manager
func (m *Manager) Init(stateManager *statemanager.Manager) error {
+ if err := m.initFirewall(); err != nil {
+ return err
+ }
+
+ m.persistState(stateManager)
+
+ // Start after initFirewall has installed the baseline external-chain
+ // accept rules. start() is idempotent across Init/Close/Init cycles.
+ m.extMonitor.start()
+
+ return nil
+}
+
+// reconcileExternalChains re-applies passthrough accept rules to external
+// filter chains for both IPv4 and IPv6 routers. Called by the monitor when
+// tables or chains appear (e.g. after firewalld reloads).
+func (m *Manager) reconcileExternalChains() error {
+ m.mutex.Lock()
+ defer m.mutex.Unlock()
+
+ var merr *multierror.Error
+ if m.router != nil {
+ if err := m.router.acceptExternalChainsRules(); err != nil {
+ merr = multierror.Append(merr, fmt.Errorf("v4: %w", err))
+ }
+ }
+ if m.hasIPv6() {
+ if err := m.router6.acceptExternalChainsRules(); err != nil {
+ merr = multierror.Append(merr, fmt.Errorf("v6: %w", err))
+ }
+ }
+ return nberrors.FormatErrorOrNil(merr)
+}
+
+func (m *Manager) initFirewall() (err error) {
workTable, err := m.createWorkTable()
if err != nil {
return fmt.Errorf("create work table: %w", err)
}
+ defer func() {
+ if err != nil {
+ m.rollbackInit()
+ }
+ }()
+
if err := m.router.init(workTable); err != nil {
return fmt.Errorf("router init: %w", err)
}
if err := m.aclManager.init(workTable); err != nil {
- // TODO: cleanup router
return fmt.Errorf("acl manager init: %w", err)
}
+ if m.hasIPv6() {
+ if err := m.initIPv6(); err != nil {
+ // Peer has a v6 address: v6 firewall MUST work or we risk fail-open.
+ return fmt.Errorf("init IPv6 firewall (required because peer has IPv6 address): %w", err)
+ }
+ }
+
if err := m.initNoTrackChains(workTable); err != nil {
log.Warnf("raw priority chains not available, notrack rules will be disabled: %v", err)
}
+ return nil
+}
+
+// persistState saves the current interface state for potential recreation on restart.
+// Unlike iptables, which requires tracking individual rules, nftables maintains
+// a known state (our netbird table plus a few static rules). This allows for easy
+// cleanup using Close() without needing to store specific rules.
+func (m *Manager) persistState(stateManager *statemanager.Manager) {
stateManager.RegisterState(&ShutdownState{})
- // We only need to record minimal interface state for potential recreation.
- // Unlike iptables, which requires tracking individual rules, nftables maintains
- // a known state (our netbird table plus a few static rules). This allows for easy
- // cleanup using Close() without needing to store specific rules.
if err := stateManager.UpdateState(&ShutdownState{
InterfaceState: &InterfaceState{
NameStr: m.wgIface.Name(),
@@ -114,14 +226,29 @@ func (m *Manager) Init(stateManager *statemanager.Manager) error {
log.Errorf("failed to update state: %v", err)
}
- // persist early
go func() {
if err := stateManager.PersistState(context.Background()); err != nil {
log.Errorf("failed to persist state: %v", err)
}
}()
+}
- return nil
+// rollbackInit performs best-effort cleanup of already-initialized state when Init fails partway through.
+func (m *Manager) rollbackInit() {
+ if err := m.router.Reset(); err != nil {
+ log.Warnf("rollback router: %v", err)
+ }
+ if m.hasIPv6() {
+ if err := m.router6.Reset(); err != nil {
+ log.Warnf("rollback v6 router: %v", err)
+ }
+ }
+ if err := m.cleanupNetbirdTables(); err != nil {
+ log.Warnf("cleanup tables: %v", err)
+ }
+ if err := m.rConn.Flush(); err != nil {
+ log.Warnf("flush: %v", err)
+ }
}
// AddPeerFiltering rule to the firewall
@@ -140,12 +267,14 @@ func (m *Manager) AddPeerFiltering(
m.mutex.Lock()
defer m.mutex.Unlock()
- rawIP := ip.To4()
- if rawIP == nil {
- return nil, fmt.Errorf("unsupported IP version: %s", ip.String())
+ if ip.To4() != nil {
+ return m.aclManager.AddPeerFiltering(id, ip, proto, sPort, dPort, action, ipsetName)
}
- return m.aclManager.AddPeerFiltering(id, ip, proto, sPort, dPort, action, ipsetName)
+ if !m.hasIPv6() {
+ return nil, fmt.Errorf("add peer filtering for %s: %w", ip, firewall.ErrIPv6NotInitialized)
+ }
+ return m.aclManager6.AddPeerFiltering(id, ip, proto, sPort, dPort, action, ipsetName)
}
func (m *Manager) AddRouteFiltering(
@@ -159,8 +288,11 @@ func (m *Manager) AddRouteFiltering(
m.mutex.Lock()
defer m.mutex.Unlock()
- if destination.IsPrefix() && !destination.Prefix.Addr().Is4() {
- return nil, fmt.Errorf("unsupported IP version: %s", destination.Prefix.Addr().String())
+ if isIPv6RouteRule(sources, destination) {
+ if !m.hasIPv6() {
+ return nil, fmt.Errorf("add route filtering: %w", firewall.ErrIPv6NotInitialized)
+ }
+ return m.router6.AddRouteFiltering(id, sources, destination, proto, sPort, dPort, action)
}
return m.router.AddRouteFiltering(id, sources, destination, proto, sPort, dPort, action)
@@ -171,15 +303,66 @@ func (m *Manager) DeletePeerRule(rule firewall.Rule) error {
m.mutex.Lock()
defer m.mutex.Unlock()
+ if m.hasIPv6() && isIPv6Rule(rule) {
+ return m.aclManager6.DeletePeerRule(rule)
+ }
return m.aclManager.DeletePeerRule(rule)
}
-// DeleteRouteRule deletes a routing rule
+func isIPv6Rule(rule firewall.Rule) bool {
+ r, ok := rule.(*Rule)
+ return ok && r.nftRule != nil && r.nftRule.Table != nil && r.nftRule.Table.Family == nftables.TableFamilyIPv6
+}
+
+// isIPv6RouteRule determines whether a route rule belongs to the v6 table.
+// For static routes, the destination prefix determines the family. For dynamic
+// routes (DomainSet), the sources determine the family since management
+// duplicates dynamic rules per family.
+func isIPv6RouteRule(sources []netip.Prefix, destination firewall.Network) bool {
+ if destination.IsPrefix() {
+ return destination.Prefix.Addr().Is6()
+ }
+ return len(sources) > 0 && sources[0].Addr().Is6()
+}
+
+// DeleteRouteRule deletes a routing rule. Route rules live in exactly one
+// router; the cached maps are normally authoritative, so the kernel is only
+// consulted when neither map knows about the rule.
func (m *Manager) DeleteRouteRule(rule firewall.Rule) error {
m.mutex.Lock()
defer m.mutex.Unlock()
- return m.router.DeleteRouteRule(rule)
+ id := rule.ID()
+ r, err := m.routerForRuleID(id, (*router).hasRule)
+ if err != nil {
+ return err
+ }
+ return r.DeleteRouteRule(rule)
+}
+
+// routerForRuleID picks the router holding the rule with the given id, using
+// the supplied lookup. If the cached maps disagree (or both miss), it refreshes
+// from the kernel once and re-checks before falling back to the v4 router.
+func (m *Manager) routerForRuleID(id string, has func(*router, string) bool) (*router, error) {
+ if has(m.router, id) {
+ return m.router, nil
+ }
+ if m.hasIPv6() && has(m.router6, id) {
+ return m.router6, nil
+ }
+ if !m.hasIPv6() {
+ return m.router, nil
+ }
+ if err := m.router.refreshRulesMap(); err != nil {
+ return nil, fmt.Errorf("refresh v4 rules: %w", err)
+ }
+ if err := m.router6.refreshRulesMap(); err != nil {
+ return nil, fmt.Errorf("refresh v6 rules: %w", err)
+ }
+ if has(m.router6, id) && !has(m.router, id) {
+ return m.router6, nil
+ }
+ return m.router, nil
}
func (m *Manager) IsServerRouteSupported() bool {
@@ -194,19 +377,70 @@ func (m *Manager) AddNatRule(pair firewall.RouterPair) error {
m.mutex.Lock()
defer m.mutex.Unlock()
- return m.router.AddNatRule(pair)
+ if pair.Destination.IsPrefix() && pair.Destination.Prefix.Addr().Is6() {
+ if !m.hasIPv6() {
+ return fmt.Errorf("add NAT rule: %w", firewall.ErrIPv6NotInitialized)
+ }
+ return m.router6.AddNatRule(pair)
+ }
+
+ if err := m.router.AddNatRule(pair); err != nil {
+ return err
+ }
+
+ // Dynamic routes need NAT in both tables since resolved IPs can be
+ // either v4 or v6. This covers both DomainSet (modern) and the legacy
+ // wildcard 0.0.0.0/0 destination where the client resolves DNS.
+ // On v6 failure we keep the v4 NAT rule rather than rolling back: half
+ // connectivity is better than none, and RemoveNatRule is content-keyed
+ // so the eventual cleanup still works.
+ if m.hasIPv6() && pair.Dynamic {
+ v6Pair := firewall.ToV6NatPair(pair)
+ if err := m.router6.AddNatRule(v6Pair); err != nil {
+ return fmt.Errorf("add v6 NAT rule: %w", err)
+ }
+ }
+
+ return nil
}
func (m *Manager) RemoveNatRule(pair firewall.RouterPair) error {
m.mutex.Lock()
defer m.mutex.Unlock()
- return m.router.RemoveNatRule(pair)
+ if pair.Destination.IsPrefix() && pair.Destination.Prefix.Addr().Is6() {
+ if !m.hasIPv6() {
+ return nil
+ }
+ return m.router6.RemoveNatRule(pair)
+ }
+
+ var merr *multierror.Error
+
+ if err := m.router.RemoveNatRule(pair); err != nil {
+ merr = multierror.Append(merr, fmt.Errorf("remove v4 NAT rule: %w", err))
+ }
+
+ if m.hasIPv6() && pair.Dynamic {
+ v6Pair := firewall.ToV6NatPair(pair)
+ if err := m.router6.RemoveNatRule(v6Pair); err != nil {
+ merr = multierror.Append(merr, fmt.Errorf("remove v6 NAT rule: %w", err))
+ }
+ }
+
+ return nberrors.FormatErrorOrNil(merr)
}
// AllowNetbird allows netbird interface traffic.
// This is called when USPFilter wraps the native firewall, adding blanket accept
// rules so that packet filtering is handled in userspace instead of by netfilter.
+//
+// TODO: In USP mode this only adds ACCEPT to the netbird table's own chains,
+// which doesn't override DROP rules in external tables (e.g. firewalld).
+// Should add passthrough rules to external chains (like the native mode router's
+// addExternalChainsRules does) for both the netbird table family and inet tables.
+// The netbird table itself is fine (routing chains already exist there), but
+// non-netbird tables with INPUT/FORWARD hooks can still DROP our WG traffic.
func (m *Manager) AllowNetbird() error {
m.mutex.Lock()
defer m.mutex.Unlock()
@@ -214,6 +448,11 @@ func (m *Manager) AllowNetbird() error {
if err := m.aclManager.createDefaultAllowRules(); err != nil {
return fmt.Errorf("create default allow rules: %w", err)
}
+ if m.hasIPv6() {
+ if err := m.aclManager6.createDefaultAllowRules(); err != nil {
+ return fmt.Errorf("create v6 default allow rules: %w", err)
+ }
+ }
if err := m.rConn.Flush(); err != nil {
return fmt.Errorf("flush allow input netbird rules: %w", err)
}
@@ -227,31 +466,47 @@ func (m *Manager) AllowNetbird() error {
// SetLegacyManagement sets the route manager to use legacy management
func (m *Manager) SetLegacyManagement(isLegacy bool) error {
- return firewall.SetLegacyManagement(m.router, isLegacy)
+ if err := firewall.SetLegacyManagement(m.router, isLegacy); err != nil {
+ return err
+ }
+ if m.hasIPv6() {
+ return firewall.SetLegacyManagement(m.router6, isLegacy)
+ }
+ return nil
}
// Close closes the firewall manager
func (m *Manager) Close(stateManager *statemanager.Manager) error {
+ m.extMonitor.stop()
+
m.mutex.Lock()
defer m.mutex.Unlock()
+ var merr *multierror.Error
+
if err := m.router.Reset(); err != nil {
- return fmt.Errorf("reset router: %v", err)
+ merr = multierror.Append(merr, fmt.Errorf("reset router: %v", err))
+ }
+
+ if m.hasIPv6() {
+ if err := m.router6.Reset(); err != nil {
+ merr = multierror.Append(merr, fmt.Errorf("reset v6 router: %v", err))
+ }
}
if err := m.cleanupNetbirdTables(); err != nil {
- return fmt.Errorf("cleanup netbird tables: %v", err)
+ merr = multierror.Append(merr, fmt.Errorf("cleanup netbird tables: %v", err))
}
if err := m.rConn.Flush(); err != nil {
- return fmt.Errorf(flushError, err)
+ merr = multierror.Append(merr, fmt.Errorf(flushError, err))
}
if err := stateManager.DeleteState(&ShutdownState{}); err != nil {
- return fmt.Errorf("delete state: %v", err)
+ merr = multierror.Append(merr, fmt.Errorf("delete state: %v", err))
}
- return nil
+ return nberrors.FormatErrorOrNil(merr)
}
func (m *Manager) cleanupNetbirdTables() error {
@@ -300,6 +555,12 @@ func (m *Manager) Flush() error {
return err
}
+ if m.hasIPv6() {
+ if err := m.aclManager6.Flush(); err != nil {
+ return fmt.Errorf("flush v6 acl: %w", err)
+ }
+ }
+
if err := m.refreshNoTrackChains(); err != nil {
log.Errorf("failed to refresh notrack chains: %v", err)
}
@@ -312,6 +573,12 @@ func (m *Manager) AddDNATRule(rule firewall.ForwardRule) (firewall.Rule, error)
m.mutex.Lock()
defer m.mutex.Unlock()
+ if rule.TranslatedAddress.Is6() {
+ if !m.hasIPv6() {
+ return nil, fmt.Errorf("add DNAT rule: %w", firewall.ErrIPv6NotInitialized)
+ }
+ return m.router6.AddDNATRule(rule)
+ }
return m.router.AddDNATRule(rule)
}
@@ -320,7 +587,11 @@ func (m *Manager) DeleteDNATRule(rule firewall.Rule) error {
m.mutex.Lock()
defer m.mutex.Unlock()
- return m.router.DeleteDNATRule(rule)
+ r, err := m.routerForRuleID(rule.ID(), (*router).hasDNATRule)
+ if err != nil {
+ return err
+ }
+ return r.DeleteDNATRule(rule)
}
// UpdateSet updates the set with the given prefixes
@@ -328,39 +599,82 @@ func (m *Manager) UpdateSet(set firewall.Set, prefixes []netip.Prefix) error {
m.mutex.Lock()
defer m.mutex.Unlock()
- return m.router.UpdateSet(set, prefixes)
+ var v4Prefixes, v6Prefixes []netip.Prefix
+ for _, p := range prefixes {
+ if p.Addr().Is6() {
+ v6Prefixes = append(v6Prefixes, p)
+ } else {
+ v4Prefixes = append(v4Prefixes, p)
+ }
+ }
+
+ if err := m.router.UpdateSet(set, v4Prefixes); err != nil {
+ return err
+ }
+
+ if m.hasIPv6() && len(v6Prefixes) > 0 {
+ if err := m.router6.UpdateSet(set, v6Prefixes); err != nil {
+ return fmt.Errorf("update v6 set: %w", err)
+ }
+ }
+
+ return nil
}
// AddInboundDNAT adds an inbound DNAT rule redirecting traffic from NetBird peers to local services.
-func (m *Manager) AddInboundDNAT(localAddr netip.Addr, protocol firewall.Protocol, sourcePort, targetPort uint16) error {
+func (m *Manager) AddInboundDNAT(localAddr netip.Addr, protocol firewall.Protocol, originalPort, translatedPort uint16) error {
m.mutex.Lock()
defer m.mutex.Unlock()
- return m.router.AddInboundDNAT(localAddr, protocol, sourcePort, targetPort)
+ if localAddr.Is6() {
+ if !m.hasIPv6() {
+ return fmt.Errorf("add inbound DNAT: %w", firewall.ErrIPv6NotInitialized)
+ }
+ return m.router6.AddInboundDNAT(localAddr, protocol, originalPort, translatedPort)
+ }
+ return m.router.AddInboundDNAT(localAddr, protocol, originalPort, translatedPort)
}
// RemoveInboundDNAT removes an inbound DNAT rule.
-func (m *Manager) RemoveInboundDNAT(localAddr netip.Addr, protocol firewall.Protocol, sourcePort, targetPort uint16) error {
+func (m *Manager) RemoveInboundDNAT(localAddr netip.Addr, protocol firewall.Protocol, originalPort, translatedPort uint16) error {
m.mutex.Lock()
defer m.mutex.Unlock()
- return m.router.RemoveInboundDNAT(localAddr, protocol, sourcePort, targetPort)
+ if localAddr.Is6() {
+ if !m.hasIPv6() {
+ return fmt.Errorf("remove inbound DNAT: %w", firewall.ErrIPv6NotInitialized)
+ }
+ return m.router6.RemoveInboundDNAT(localAddr, protocol, originalPort, translatedPort)
+ }
+ return m.router.RemoveInboundDNAT(localAddr, protocol, originalPort, translatedPort)
}
// AddOutputDNAT adds an OUTPUT chain DNAT rule for locally-generated traffic.
-func (m *Manager) AddOutputDNAT(localAddr netip.Addr, protocol firewall.Protocol, sourcePort, targetPort uint16) error {
+func (m *Manager) AddOutputDNAT(localAddr netip.Addr, protocol firewall.Protocol, originalPort, translatedPort uint16) error {
m.mutex.Lock()
defer m.mutex.Unlock()
- return m.router.AddOutputDNAT(localAddr, protocol, sourcePort, targetPort)
+ if localAddr.Is6() {
+ if !m.hasIPv6() {
+ return fmt.Errorf("add output DNAT: %w", firewall.ErrIPv6NotInitialized)
+ }
+ return m.router6.AddOutputDNAT(localAddr, protocol, originalPort, translatedPort)
+ }
+ return m.router.AddOutputDNAT(localAddr, protocol, originalPort, translatedPort)
}
// RemoveOutputDNAT removes an OUTPUT chain DNAT rule.
-func (m *Manager) RemoveOutputDNAT(localAddr netip.Addr, protocol firewall.Protocol, sourcePort, targetPort uint16) error {
+func (m *Manager) RemoveOutputDNAT(localAddr netip.Addr, protocol firewall.Protocol, originalPort, translatedPort uint16) error {
m.mutex.Lock()
defer m.mutex.Unlock()
- return m.router.RemoveOutputDNAT(localAddr, protocol, sourcePort, targetPort)
+ if localAddr.Is6() {
+ if !m.hasIPv6() {
+ return fmt.Errorf("remove output DNAT: %w", firewall.ErrIPv6NotInitialized)
+ }
+ return m.router6.RemoveOutputDNAT(localAddr, protocol, originalPort, translatedPort)
+ }
+ return m.router.RemoveOutputDNAT(localAddr, protocol, originalPort, translatedPort)
}
const (
@@ -534,7 +848,11 @@ func (m *Manager) refreshNoTrackChains() error {
}
func (m *Manager) createWorkTable() (*nftables.Table, error) {
- tables, err := m.rConn.ListTablesOfFamily(nftables.TableFamilyIPv4)
+ return m.createWorkTableFamily(nftables.TableFamilyIPv4)
+}
+
+func (m *Manager) createWorkTableFamily(family nftables.TableFamily) (*nftables.Table, error) {
+ tables, err := m.rConn.ListTablesOfFamily(family)
if err != nil {
return nil, fmt.Errorf("list of tables: %w", err)
}
@@ -546,7 +864,7 @@ func (m *Manager) createWorkTable() (*nftables.Table, error) {
}
}
- table := m.rConn.AddTable(&nftables.Table{Name: getTableName(), Family: nftables.TableFamilyIPv4})
+ table := m.rConn.AddTable(&nftables.Table{Name: tableName, Family: family})
err = m.rConn.Flush()
return table, err
}
diff --git a/client/firewall/nftables/manager_linux_test.go b/client/firewall/nftables/manager_linux_test.go
index d48e4ba88..be4f65881 100644
--- a/client/firewall/nftables/manager_linux_test.go
+++ b/client/firewall/nftables/manager_linux_test.go
@@ -383,10 +383,138 @@ func TestNftablesManagerCompatibilityWithIptables(t *testing.T) {
err = manager.AddNatRule(pair)
require.NoError(t, err, "failed to add NAT rule")
+ dnatRule, err := manager.AddDNATRule(fw.ForwardRule{
+ Protocol: fw.ProtocolTCP,
+ DestinationPort: fw.Port{Values: []uint16{8080}},
+ TranslatedAddress: netip.MustParseAddr("100.96.0.2"),
+ TranslatedPort: fw.Port{Values: []uint16{80}},
+ })
+ require.NoError(t, err, "failed to add DNAT rule")
+
+ t.Cleanup(func() {
+ require.NoError(t, manager.DeleteDNATRule(dnatRule), "failed to delete DNAT rule")
+ })
+
stdout, stderr = runIptablesSave(t)
verifyIptablesOutput(t, stdout, stderr)
}
+func TestNftablesManagerIPv6CompatibilityWithIp6tables(t *testing.T) {
+ if check() != NFTABLES {
+ t.Skip("nftables not supported on this system")
+ }
+
+ for _, bin := range []string{"ip6tables", "ip6tables-save", "iptables-save"} {
+ if _, err := exec.LookPath(bin); err != nil {
+ t.Skipf("%s not available on this system: %v", bin, err)
+ }
+ }
+
+ // Seed ip6 tables in the nft backend. Docker may not create them.
+ seedIp6tables(t)
+
+ ifaceMockV6 := &iFaceMock{
+ NameFunc: func() string { return "wt-test" },
+ AddressFunc: func() wgaddr.Address {
+ return wgaddr.Address{
+ IP: netip.MustParseAddr("100.96.0.1"),
+ Network: netip.MustParsePrefix("100.96.0.0/16"),
+ IPv6: netip.MustParseAddr("fd00::1"),
+ IPv6Net: netip.MustParsePrefix("fd00::/64"),
+ }
+ },
+ }
+
+ manager, err := Create(ifaceMockV6, iface.DefaultMTU)
+ require.NoError(t, err, "create manager")
+ require.NoError(t, manager.Init(nil))
+
+ t.Cleanup(func() {
+ require.NoError(t, manager.Close(nil), "close manager")
+
+ stdout, stderr := runIp6tablesSave(t)
+ verifyIp6tablesOutput(t, stdout, stderr)
+ })
+
+ ip := netip.MustParseAddr("fd00::2")
+ _, err = manager.AddPeerFiltering(nil, ip.AsSlice(), fw.ProtocolTCP, nil, &fw.Port{Values: []uint16{80}}, fw.ActionAccept, "")
+ require.NoError(t, err, "add v6 peer filtering rule")
+
+ _, err = manager.AddRouteFiltering(
+ nil,
+ []netip.Prefix{netip.MustParsePrefix("fd00:1::/64")},
+ fw.Network{Prefix: netip.MustParsePrefix("2001:db8::/48")},
+ fw.ProtocolTCP,
+ nil,
+ &fw.Port{Values: []uint16{443}},
+ fw.ActionAccept,
+ )
+ require.NoError(t, err, "add v6 route filtering rule")
+
+ err = manager.AddNatRule(fw.RouterPair{
+ Source: fw.Network{Prefix: netip.MustParsePrefix("fd00::/64")},
+ Destination: fw.Network{Prefix: netip.MustParsePrefix("2001:db8::/48")},
+ Masquerade: true,
+ })
+ require.NoError(t, err, "add v6 NAT rule")
+
+ dnatRule, err := manager.AddDNATRule(fw.ForwardRule{
+ Protocol: fw.ProtocolTCP,
+ DestinationPort: fw.Port{Values: []uint16{8080}},
+ TranslatedAddress: netip.MustParseAddr("fd00::2"),
+ TranslatedPort: fw.Port{Values: []uint16{80}},
+ })
+ require.NoError(t, err, "add v6 DNAT rule")
+
+ t.Cleanup(func() {
+ require.NoError(t, manager.DeleteDNATRule(dnatRule), "delete v6 DNAT rule")
+ })
+
+ stdout, stderr := runIptablesSave(t)
+ verifyIptablesOutput(t, stdout, stderr)
+
+ stdout, stderr = runIp6tablesSave(t)
+ verifyIp6tablesOutput(t, stdout, stderr)
+}
+
+func seedIp6tables(t *testing.T) {
+ t.Helper()
+ for _, tc := range []struct{ table, chain string }{
+ {"filter", "FORWARD"},
+ {"nat", "POSTROUTING"},
+ {"mangle", "FORWARD"},
+ } {
+ add := exec.Command("ip6tables", "-t", tc.table, "-A", tc.chain, "-j", "ACCEPT")
+ require.NoError(t, add.Run(), "seed ip6tables -t %s", tc.table)
+ del := exec.Command("ip6tables", "-t", tc.table, "-D", tc.chain, "-j", "ACCEPT")
+ require.NoError(t, del.Run(), "unseed ip6tables -t %s", tc.table)
+ }
+}
+
+func runIp6tablesSave(t *testing.T) (string, string) {
+ t.Helper()
+ var stdout, stderr bytes.Buffer
+ cmd := exec.Command("ip6tables-save")
+ cmd.Stdout = &stdout
+ cmd.Stderr = &stderr
+ require.NoError(t, cmd.Run(), "ip6tables-save failed")
+ return stdout.String(), stderr.String()
+}
+
+func verifyIp6tablesOutput(t *testing.T, stdout, stderr string) {
+ t.Helper()
+ for _, msg := range []string{
+ "Table `nat' is incompatible",
+ "Table `mangle' is incompatible",
+ "Table `filter' is incompatible",
+ } {
+ require.NotContains(t, stdout, msg,
+ "ip6tables-save stdout reports incompatibility: %s", stdout)
+ require.NotContains(t, stderr, msg,
+ "ip6tables-save stderr reports incompatibility: %s", stderr)
+ }
+}
+
func TestNftablesManagerCompatibilityWithIptablesFor6kPrefixes(t *testing.T) {
if check() != NFTABLES {
t.Skip("nftables not supported on this system")
diff --git a/client/firewall/nftables/router_linux.go b/client/firewall/nftables/router_linux.go
index 8cc0d2792..4214455a9 100644
--- a/client/firewall/nftables/router_linux.go
+++ b/client/firewall/nftables/router_linux.go
@@ -50,8 +50,10 @@ const (
dnatSuffix = "_dnat"
snatSuffix = "_snat"
- // ipTCPHeaderMinSize represents minimum IP (20) + TCP (20) header size for MSS calculation
- ipTCPHeaderMinSize = 40
+ // ipv4TCPHeaderSize is the minimum IPv4 (20) + TCP (20) header size for MSS calculation.
+ ipv4TCPHeaderSize = 40
+ // ipv6TCPHeaderSize is the minimum IPv6 (40) + TCP (20) header size for MSS calculation.
+ ipv6TCPHeaderSize = 60
// maxPrefixesSet 1638 prefixes start to fail, taking some margin
maxPrefixesSet = 1500
@@ -76,6 +78,7 @@ type router struct {
rules map[string]*nftables.Rule
ipsetCounter *refcounter.Counter[string, setInput, *nftables.Set]
+ af addrFamily
wgIface iFaceMapper
ipFwdState *ipfwdstate.IPForwardingState
legacyManagement bool
@@ -88,6 +91,7 @@ func newRouter(workTable *nftables.Table, wgIface iFaceMapper, mtu uint16) (*rou
workTable: workTable,
chains: make(map[string]*nftables.Chain),
rules: make(map[string]*nftables.Rule),
+ af: familyForAddr(workTable.Family == nftables.TableFamilyIPv4),
wgIface: wgIface,
ipFwdState: ipfwdstate.NewIPForwardingState(),
mtu: mtu,
@@ -150,7 +154,7 @@ func (r *router) Reset() error {
func (r *router) removeNatPreroutingRules() error {
table := &nftables.Table{
Name: tableNat,
- Family: nftables.TableFamilyIPv4,
+ Family: r.af.tableFamily,
}
chain := &nftables.Chain{
Name: chainNameNatPrerouting,
@@ -183,7 +187,7 @@ func (r *router) removeNatPreroutingRules() error {
}
func (r *router) loadFilterTable() (*nftables.Table, error) {
- tables, err := r.conn.ListTablesOfFamily(nftables.TableFamilyIPv4)
+ tables, err := r.conn.ListTablesOfFamily(r.af.tableFamily)
if err != nil {
return nil, fmt.Errorf("list tables: %w", err)
}
@@ -419,7 +423,7 @@ func (r *router) AddRouteFiltering(
// Handle protocol
if proto != firewall.ProtocolALL {
- protoNum, err := protoToInt(proto)
+ protoNum, err := r.af.protoNum(proto)
if err != nil {
return nil, fmt.Errorf("convert protocol to number: %w", err)
}
@@ -479,7 +483,24 @@ func (r *router) getIpSet(set firewall.Set, prefixes []netip.Prefix, isSource bo
return nil, fmt.Errorf("create or get ipset: %w", err)
}
- return getIpSetExprs(ref, isSource)
+ return r.getIpSetExprs(ref, isSource)
+}
+
+func (r *router) iptablesProto() iptables.Protocol {
+ if r.af.tableFamily == nftables.TableFamilyIPv6 {
+ return iptables.ProtocolIPv6
+ }
+ return iptables.ProtocolIPv4
+}
+
+func (r *router) hasRule(id string) bool {
+ _, ok := r.rules[id]
+ return ok
+}
+
+func (r *router) hasDNATRule(id string) bool {
+ _, ok := r.rules[id+dnatSuffix]
+ return ok
}
func (r *router) DeleteRouteRule(rule firewall.Rule) error {
@@ -528,10 +549,10 @@ func (r *router) createIpSet(setName string, input setInput) (*nftables.Set, err
Table: r.workTable,
// required for prefixes
Interval: true,
- KeyType: nftables.TypeIPAddr,
+ KeyType: r.af.setKeyType,
}
- elements := convertPrefixesToSet(prefixes)
+ elements := r.convertPrefixesToSet(prefixes)
nElements := len(elements)
maxElements := maxPrefixesSet * 2
@@ -564,23 +585,17 @@ func (r *router) createIpSet(setName string, input setInput) (*nftables.Set, err
return nfset, nil
}
-func convertPrefixesToSet(prefixes []netip.Prefix) []nftables.SetElement {
+func (r *router) convertPrefixesToSet(prefixes []netip.Prefix) []nftables.SetElement {
var elements []nftables.SetElement
for _, prefix := range prefixes {
- // TODO: Implement IPv6 support
- if prefix.Addr().Is6() {
- log.Tracef("skipping IPv6 prefix %s: IPv6 support not yet implemented", prefix)
- continue
- }
-
// nftables needs half-open intervals [firstIP, lastIP) for prefixes
// e.g. 10.0.0.0/24 becomes [10.0.0.0, 10.0.1.0), 10.1.1.1/32 becomes [10.1.1.1, 10.1.1.2) etc
firstIP := prefix.Addr()
lastIP := calculateLastIP(prefix).Next()
elements = append(elements,
- // the nft tool also adds a line like this, see https://github.com/google/nftables/issues/247
- // nftables.SetElement{Key: []byte{0, 0, 0, 0}, IntervalEnd: true},
+ // the nft tool also adds a zero-address IntervalEnd element, see https://github.com/google/nftables/issues/247
+ // nftables.SetElement{Key: make([]byte, r.af.addrLen), IntervalEnd: true},
nftables.SetElement{Key: firstIP.AsSlice()},
nftables.SetElement{Key: lastIP.AsSlice(), IntervalEnd: true},
)
@@ -590,10 +605,20 @@ func convertPrefixesToSet(prefixes []netip.Prefix) []nftables.SetElement {
// calculateLastIP determines the last IP in a given prefix.
func calculateLastIP(prefix netip.Prefix) netip.Addr {
- hostMask := ^uint32(0) >> prefix.Masked().Bits()
- lastIP := uint32FromNetipAddr(prefix.Addr()) | hostMask
+ masked := prefix.Masked()
+ if masked.Addr().Is4() {
+ hostMask := ^uint32(0) >> masked.Bits()
+ lastIP := uint32FromNetipAddr(masked.Addr()) | hostMask
+ return netip.AddrFrom4(uint32ToBytes(lastIP))
+ }
- return netip.AddrFrom4(uint32ToBytes(lastIP))
+ // IPv6: set host bits to all 1s
+ b := masked.Addr().As16()
+ bits := masked.Bits()
+ for i := bits; i < 128; i++ {
+ b[i/8] |= 1 << (7 - i%8)
+ }
+ return netip.AddrFrom16(b)
}
// Utility function to convert netip.Addr to uint32.
@@ -845,9 +870,16 @@ func (r *router) addPostroutingRules() {
}
// addMSSClampingRules adds MSS clamping rules to prevent fragmentation for forwarded traffic.
-// TODO: Add IPv6 support
func (r *router) addMSSClampingRules() error {
- mss := r.mtu - ipTCPHeaderMinSize
+ overhead := uint16(ipv4TCPHeaderSize)
+ if r.af.tableFamily == nftables.TableFamilyIPv6 {
+ overhead = ipv6TCPHeaderSize
+ }
+ if r.mtu <= overhead {
+ log.Debugf("MTU %d too small for MSS clamping (overhead %d), skipping", r.mtu, overhead)
+ return nil
+ }
+ mss := r.mtu - overhead
exprsOut := []expr.Any{
&expr.Meta{
@@ -1054,17 +1086,22 @@ func (r *router) acceptFilterTableRules() error {
log.Debugf("Used %s to add accept forward and input rules", fw)
}()
- // Try iptables first and fallback to nftables if iptables is not available
- ipt, err := iptables.New()
+ // Try iptables first and fallback to nftables if iptables is not available.
+ // Use the correct protocol (iptables vs ip6tables) for the address family.
+ ipt, err := iptables.NewWithProtocol(r.iptablesProto())
if err != nil {
- // iptables is not available but the filter table exists
log.Warnf("Will use nftables to manipulate the filter table because iptables is not available: %v", err)
fw = "nftables"
return r.acceptFilterRulesNftables(r.filterTable)
}
- return r.acceptFilterRulesIptables(ipt)
+ if err := r.acceptFilterRulesIptables(ipt); err != nil {
+ log.Warnf("iptables failed (table may be incompatible), falling back to nftables: %v", err)
+ fw = "nftables"
+ return r.acceptFilterRulesNftables(r.filterTable)
+ }
+ return nil
}
func (r *router) acceptFilterRulesIptables(ipt *iptables.IPTables) error {
@@ -1135,83 +1172,122 @@ func (r *router) acceptExternalChainsRules() error {
}
intf := ifname(r.wgIface.Name())
-
for _, chain := range chains {
- if chain.Hooknum == nil {
- log.Debugf("skipping external chain %s/%s: hooknum is nil", chain.Table.Name, chain.Name)
- continue
- }
-
- log.Debugf("adding accept rules to external %s chain: %s %s/%s",
- hookName(chain.Hooknum), familyName(chain.Table.Family), chain.Table.Name, chain.Name)
-
- switch *chain.Hooknum {
- case *nftables.ChainHookForward:
- r.insertForwardAcceptRules(chain, intf)
- case *nftables.ChainHookInput:
- r.insertInputAcceptRule(chain, intf)
- }
+ r.applyExternalChainAccept(chain, intf)
}
if err := r.conn.Flush(); err != nil {
return fmt.Errorf("flush external chain rules: %w", err)
}
-
return nil
}
+func (r *router) applyExternalChainAccept(chain *nftables.Chain, intf []byte) {
+ if chain.Hooknum == nil {
+ log.Debugf("skipping external chain %s/%s: hooknum is nil", chain.Table.Name, chain.Name)
+ return
+ }
+
+ log.Debugf("adding accept rules to external %s chain: %s %s/%s",
+ hookName(chain.Hooknum), familyName(chain.Table.Family), chain.Table.Name, chain.Name)
+
+ switch *chain.Hooknum {
+ case *nftables.ChainHookForward:
+ r.insertForwardAcceptRules(chain, intf)
+ case *nftables.ChainHookInput:
+ r.insertInputAcceptRule(chain, intf)
+ }
+}
+
func (r *router) insertForwardAcceptRules(chain *nftables.Chain, intf []byte) {
- iifRule := &nftables.Rule{
+ existing, err := r.existingNetbirdRulesInChain(chain)
+ if err != nil {
+ log.Warnf("skip forward accept rules in %s/%s: %v", chain.Table.Name, chain.Name, err)
+ return
+ }
+ r.insertForwardIifRule(chain, intf, existing)
+ r.insertForwardOifEstablishedRule(chain, intf, existing)
+}
+
+func (r *router) insertForwardIifRule(chain *nftables.Chain, intf []byte, existing map[string]bool) {
+ if existing[userDataAcceptForwardRuleIif] {
+ return
+ }
+ r.conn.InsertRule(&nftables.Rule{
Table: chain.Table,
Chain: chain,
Exprs: []expr.Any{
&expr.Meta{Key: expr.MetaKeyIIFNAME, Register: 1},
- &expr.Cmp{
- Op: expr.CmpOpEq,
- Register: 1,
- Data: intf,
- },
+ &expr.Cmp{Op: expr.CmpOpEq, Register: 1, Data: intf},
&expr.Counter{},
&expr.Verdict{Kind: expr.VerdictAccept},
},
UserData: []byte(userDataAcceptForwardRuleIif),
- }
- r.conn.InsertRule(iifRule)
+ })
+}
- oifExprs := []expr.Any{
- &expr.Meta{Key: expr.MetaKeyOIFNAME, Register: 1},
- &expr.Cmp{
- Op: expr.CmpOpEq,
- Register: 1,
- Data: intf,
- },
+func (r *router) insertForwardOifEstablishedRule(chain *nftables.Chain, intf []byte, existing map[string]bool) {
+ if existing[userDataAcceptForwardRuleOif] {
+ return
}
- oifRule := &nftables.Rule{
+ exprs := []expr.Any{
+ &expr.Meta{Key: expr.MetaKeyOIFNAME, Register: 1},
+ &expr.Cmp{Op: expr.CmpOpEq, Register: 1, Data: intf},
+ }
+ r.conn.InsertRule(&nftables.Rule{
Table: chain.Table,
Chain: chain,
- Exprs: append(oifExprs, getEstablishedExprs(2)...),
+ Exprs: append(exprs, getEstablishedExprs(2)...),
UserData: []byte(userDataAcceptForwardRuleOif),
- }
- r.conn.InsertRule(oifRule)
+ })
}
func (r *router) insertInputAcceptRule(chain *nftables.Chain, intf []byte) {
- inputRule := &nftables.Rule{
+ existing, err := r.existingNetbirdRulesInChain(chain)
+ if err != nil {
+ log.Warnf("skip input accept rule in %s/%s: %v", chain.Table.Name, chain.Name, err)
+ return
+ }
+ if existing[userDataAcceptInputRule] {
+ return
+ }
+ r.conn.InsertRule(&nftables.Rule{
Table: chain.Table,
Chain: chain,
Exprs: []expr.Any{
&expr.Meta{Key: expr.MetaKeyIIFNAME, Register: 1},
- &expr.Cmp{
- Op: expr.CmpOpEq,
- Register: 1,
- Data: intf,
- },
+ &expr.Cmp{Op: expr.CmpOpEq, Register: 1, Data: intf},
&expr.Counter{},
&expr.Verdict{Kind: expr.VerdictAccept},
},
UserData: []byte(userDataAcceptInputRule),
+ })
+}
+
+// existingNetbirdRulesInChain returns the set of netbird-owned UserData tags present in a chain; callers must bail on error since InsertRule is additive.
+func (r *router) existingNetbirdRulesInChain(chain *nftables.Chain) (map[string]bool, error) {
+ rules, err := r.conn.GetRules(chain.Table, chain)
+ if err != nil {
+ return nil, fmt.Errorf("list rules: %w", err)
}
- r.conn.InsertRule(inputRule)
+ present := map[string]bool{}
+ for _, rule := range rules {
+ if !isNetbirdAcceptRuleTag(rule.UserData) {
+ continue
+ }
+ present[string(rule.UserData)] = true
+ }
+ return present, nil
+}
+
+func isNetbirdAcceptRuleTag(userData []byte) bool {
+ switch string(userData) {
+ case userDataAcceptForwardRuleIif,
+ userDataAcceptForwardRuleOif,
+ userDataAcceptInputRule:
+ return true
+ }
+ return false
}
func (r *router) removeAcceptFilterRules() error {
@@ -1233,13 +1309,17 @@ func (r *router) removeFilterTableRules() error {
return nil
}
- ipt, err := iptables.New()
+ ipt, err := iptables.NewWithProtocol(r.iptablesProto())
if err != nil {
log.Debugf("iptables not available, using nftables to remove filter rules: %v", err)
return r.removeAcceptRulesFromTable(r.filterTable)
}
- return r.removeAcceptFilterRulesIptables(ipt)
+ if err := r.removeAcceptFilterRulesIptables(ipt); err != nil {
+ log.Debugf("iptables removal failed (table may be incompatible), falling back to nftables: %v", err)
+ return r.removeAcceptRulesFromTable(r.filterTable)
+ }
+ return nil
}
func (r *router) removeAcceptRulesFromTable(table *nftables.Table) error {
@@ -1306,7 +1386,7 @@ func (r *router) removeExternalChainsRules() error {
func (r *router) findExternalChains() []*nftables.Chain {
var chains []*nftables.Chain
- families := []nftables.TableFamily{nftables.TableFamilyIPv4, nftables.TableFamilyINet}
+ families := []nftables.TableFamily{r.af.tableFamily, nftables.TableFamilyINet}
for _, family := range families {
allChains, err := r.conn.ListChainsOfTableFamily(family)
@@ -1337,8 +1417,8 @@ func (r *router) isExternalChain(chain *nftables.Chain) bool {
return false
}
- // Skip all iptables-managed tables in the ip family
- if chain.Table.Family == nftables.TableFamilyIPv4 && isIptablesTable(chain.Table.Name) {
+ // Skip iptables/ip6tables-managed tables (adding nft-native rules breaks iptables-save compat)
+ if (chain.Table.Family == nftables.TableFamilyIPv4 || chain.Table.Family == nftables.TableFamilyIPv6) && isIptablesTable(chain.Table.Name) {
return false
}
@@ -1479,7 +1559,7 @@ func (r *router) AddDNATRule(rule firewall.ForwardRule) (firewall.Rule, error) {
return rule, nil
}
- protoNum, err := protoToInt(rule.Protocol)
+ protoNum, err := r.af.protoNum(rule.Protocol)
if err != nil {
return nil, fmt.Errorf("convert protocol to number: %w", err)
}
@@ -1542,7 +1622,7 @@ func (r *router) addDnatRedirect(rule firewall.ForwardRule, protoNum uint8, rule
dnatExprs = append(dnatExprs,
&expr.NAT{
Type: expr.NATTypeDestNAT,
- Family: uint32(nftables.TableFamilyIPv4),
+ Family: uint32(r.af.tableFamily),
RegAddrMin: 1,
RegProtoMin: regProtoMin,
RegProtoMax: regProtoMax,
@@ -1635,14 +1715,15 @@ func (r *router) addXTablesRedirect(dnatExprs []expr.Any, ruleKey string, rule f
},
)
+ natTable := &nftables.Table{
+ Name: tableNat,
+ Family: r.af.tableFamily,
+ }
dnatRule := &nftables.Rule{
- Table: &nftables.Table{
- Name: tableNat,
- Family: nftables.TableFamilyIPv4,
- },
+ Table: natTable,
Chain: &nftables.Chain{
Name: chainNameNatPrerouting,
- Table: r.filterTable,
+ Table: natTable,
Type: nftables.ChainTypeNAT,
Hooknum: nftables.ChainHookPrerouting,
Priority: nftables.ChainPriorityNATDest,
@@ -1673,8 +1754,8 @@ func (r *router) addDnatMasq(rule firewall.ForwardRule, protoNum uint8, ruleKey
&expr.Payload{
DestRegister: 1,
Base: expr.PayloadBaseNetworkHeader,
- Offset: 16,
- Len: 4,
+ Offset: r.af.dstAddrOffset,
+ Len: r.af.addrLen,
},
&expr.Cmp{
Op: expr.CmpOpEq,
@@ -1752,7 +1833,7 @@ func (r *router) UpdateSet(set firewall.Set, prefixes []netip.Prefix) error {
return fmt.Errorf("get set %s: %w", set.HashedName(), err)
}
- elements := convertPrefixesToSet(prefixes)
+ elements := r.convertPrefixesToSet(prefixes)
if err := r.conn.SetAddElements(nfset, elements); err != nil {
return fmt.Errorf("add elements to set %s: %w", set.HashedName(), err)
}
@@ -1767,14 +1848,14 @@ func (r *router) UpdateSet(set firewall.Set, prefixes []netip.Prefix) error {
}
// AddInboundDNAT adds an inbound DNAT rule redirecting traffic from NetBird peers to local services.
-func (r *router) AddInboundDNAT(localAddr netip.Addr, protocol firewall.Protocol, sourcePort, targetPort uint16) error {
- ruleID := fmt.Sprintf("inbound-dnat-%s-%s-%d-%d", localAddr.String(), protocol, sourcePort, targetPort)
+func (r *router) AddInboundDNAT(localAddr netip.Addr, protocol firewall.Protocol, originalPort, translatedPort uint16) error {
+ ruleID := fmt.Sprintf("inbound-dnat-%s-%s-%d-%d", localAddr.String(), protocol, originalPort, translatedPort)
if _, exists := r.rules[ruleID]; exists {
return nil
}
- protoNum, err := protoToInt(protocol)
+ protoNum, err := r.af.protoNum(protocol)
if err != nil {
return fmt.Errorf("convert protocol to number: %w", err)
}
@@ -1801,11 +1882,15 @@ func (r *router) AddInboundDNAT(localAddr netip.Addr, protocol firewall.Protocol
&expr.Cmp{
Op: expr.CmpOpEq,
Register: 3,
- Data: binaryutil.BigEndian.PutUint16(sourcePort),
+ Data: binaryutil.BigEndian.PutUint16(originalPort),
},
}
- exprs = append(exprs, applyPrefix(netip.PrefixFrom(localAddr, 32), false)...)
+ bits := 32
+ if localAddr.Is6() {
+ bits = 128
+ }
+ exprs = append(exprs, r.applyPrefix(netip.PrefixFrom(localAddr, bits), false)...)
exprs = append(exprs,
&expr.Immediate{
@@ -1814,11 +1899,11 @@ func (r *router) AddInboundDNAT(localAddr netip.Addr, protocol firewall.Protocol
},
&expr.Immediate{
Register: 2,
- Data: binaryutil.BigEndian.PutUint16(targetPort),
+ Data: binaryutil.BigEndian.PutUint16(translatedPort),
},
&expr.NAT{
Type: expr.NATTypeDestNAT,
- Family: uint32(nftables.TableFamilyIPv4),
+ Family: uint32(r.af.tableFamily),
RegAddrMin: 1,
RegProtoMin: 2,
RegProtoMax: 0,
@@ -1843,12 +1928,12 @@ func (r *router) AddInboundDNAT(localAddr netip.Addr, protocol firewall.Protocol
}
// RemoveInboundDNAT removes an inbound DNAT rule.
-func (r *router) RemoveInboundDNAT(localAddr netip.Addr, protocol firewall.Protocol, sourcePort, targetPort uint16) error {
+func (r *router) RemoveInboundDNAT(localAddr netip.Addr, protocol firewall.Protocol, originalPort, translatedPort uint16) error {
if err := r.refreshRulesMap(); err != nil {
return fmt.Errorf(refreshRulesMapError, err)
}
- ruleID := fmt.Sprintf("inbound-dnat-%s-%s-%d-%d", localAddr.String(), protocol, sourcePort, targetPort)
+ ruleID := fmt.Sprintf("inbound-dnat-%s-%s-%d-%d", localAddr.String(), protocol, originalPort, translatedPort)
rule, exists := r.rules[ruleID]
if !exists {
@@ -1894,8 +1979,8 @@ func (r *router) ensureNATOutputChain() error {
}
// AddOutputDNAT adds an OUTPUT chain DNAT rule for locally-generated traffic.
-func (r *router) AddOutputDNAT(localAddr netip.Addr, protocol firewall.Protocol, sourcePort, targetPort uint16) error {
- ruleID := fmt.Sprintf("output-dnat-%s-%s-%d-%d", localAddr.String(), protocol, sourcePort, targetPort)
+func (r *router) AddOutputDNAT(localAddr netip.Addr, protocol firewall.Protocol, originalPort, translatedPort uint16) error {
+ ruleID := fmt.Sprintf("output-dnat-%s-%s-%d-%d", localAddr.String(), protocol, originalPort, translatedPort)
if _, exists := r.rules[ruleID]; exists {
return nil
@@ -1905,7 +1990,7 @@ func (r *router) AddOutputDNAT(localAddr netip.Addr, protocol firewall.Protocol,
return err
}
- protoNum, err := protoToInt(protocol)
+ protoNum, err := r.af.protoNum(protocol)
if err != nil {
return fmt.Errorf("convert protocol to number: %w", err)
}
@@ -1926,11 +2011,15 @@ func (r *router) AddOutputDNAT(localAddr netip.Addr, protocol firewall.Protocol,
&expr.Cmp{
Op: expr.CmpOpEq,
Register: 2,
- Data: binaryutil.BigEndian.PutUint16(sourcePort),
+ Data: binaryutil.BigEndian.PutUint16(originalPort),
},
}
- exprs = append(exprs, applyPrefix(netip.PrefixFrom(localAddr, 32), false)...)
+ bits := 32
+ if localAddr.Is6() {
+ bits = 128
+ }
+ exprs = append(exprs, r.applyPrefix(netip.PrefixFrom(localAddr, bits), false)...)
exprs = append(exprs,
&expr.Immediate{
@@ -1939,11 +2028,11 @@ func (r *router) AddOutputDNAT(localAddr netip.Addr, protocol firewall.Protocol,
},
&expr.Immediate{
Register: 2,
- Data: binaryutil.BigEndian.PutUint16(targetPort),
+ Data: binaryutil.BigEndian.PutUint16(translatedPort),
},
&expr.NAT{
Type: expr.NATTypeDestNAT,
- Family: uint32(nftables.TableFamilyIPv4),
+ Family: uint32(r.af.tableFamily),
RegAddrMin: 1,
RegProtoMin: 2,
},
@@ -1967,12 +2056,12 @@ func (r *router) AddOutputDNAT(localAddr netip.Addr, protocol firewall.Protocol,
}
// RemoveOutputDNAT removes an OUTPUT chain DNAT rule.
-func (r *router) RemoveOutputDNAT(localAddr netip.Addr, protocol firewall.Protocol, sourcePort, targetPort uint16) error {
+func (r *router) RemoveOutputDNAT(localAddr netip.Addr, protocol firewall.Protocol, originalPort, translatedPort uint16) error {
if err := r.refreshRulesMap(); err != nil {
return fmt.Errorf(refreshRulesMapError, err)
}
- ruleID := fmt.Sprintf("output-dnat-%s-%s-%d-%d", localAddr.String(), protocol, sourcePort, targetPort)
+ ruleID := fmt.Sprintf("output-dnat-%s-%s-%d-%d", localAddr.String(), protocol, originalPort, translatedPort)
rule, exists := r.rules[ruleID]
if !exists {
@@ -2011,45 +2100,44 @@ func (r *router) applyNetwork(
}
if network.IsPrefix() {
- return applyPrefix(network.Prefix, isSource), nil
+ return r.applyPrefix(network.Prefix, isSource), nil
}
return nil, nil
}
// applyPrefix generates nftables expressions for a CIDR prefix
-func applyPrefix(prefix netip.Prefix, isSource bool) []expr.Any {
- // dst offset
- offset := uint32(16)
+func (r *router) applyPrefix(prefix netip.Prefix, isSource bool) []expr.Any {
+ // dst offset by default
+ offset := r.af.dstAddrOffset
if isSource {
// src offset
- offset = 12
+ offset = r.af.srcAddrOffset
}
ones := prefix.Bits()
- // 0.0.0.0/0 doesn't need extra expressions
+ // unspecified address (/0) doesn't need extra expressions
if ones == 0 {
return nil
}
- mask := net.CIDRMask(ones, 32)
+ mask := net.CIDRMask(ones, r.af.totalBits)
+ xor := make([]byte, r.af.addrLen)
return []expr.Any{
&expr.Payload{
DestRegister: 1,
Base: expr.PayloadBaseNetworkHeader,
Offset: offset,
- Len: 4,
+ Len: r.af.addrLen,
},
- // netmask
&expr.Bitwise{
DestRegister: 1,
SourceRegister: 1,
- Len: 4,
+ Len: r.af.addrLen,
Mask: mask,
- Xor: []byte{0, 0, 0, 0},
+ Xor: xor,
},
- // net address
&expr.Cmp{
Op: expr.CmpOpEq,
Register: 1,
@@ -2132,13 +2220,12 @@ func getCtNewExprs() []expr.Any {
}
}
-func getIpSetExprs(ref refcounter.Ref[*nftables.Set], isSource bool) ([]expr.Any, error) {
-
- // dst offset
- offset := uint32(16)
+func (r *router) getIpSetExprs(ref refcounter.Ref[*nftables.Set], isSource bool) ([]expr.Any, error) {
+ // dst offset by default
+ offset := r.af.dstAddrOffset
if isSource {
// src offset
- offset = 12
+ offset = r.af.srcAddrOffset
}
return []expr.Any{
@@ -2146,7 +2233,7 @@ func getIpSetExprs(ref refcounter.Ref[*nftables.Set], isSource bool) ([]expr.Any
DestRegister: 1,
Base: expr.PayloadBaseNetworkHeader,
Offset: offset,
- Len: 4,
+ Len: r.af.addrLen,
},
&expr.Lookup{
SourceRegister: 1,
diff --git a/client/firewall/nftables/router_linux_test.go b/client/firewall/nftables/router_linux_test.go
index f0e34d211..c5d6729d9 100644
--- a/client/firewall/nftables/router_linux_test.go
+++ b/client/firewall/nftables/router_linux_test.go
@@ -90,8 +90,9 @@ func TestNftablesManager_AddNatRule(t *testing.T) {
}
// Build CIDR matching expressions
- sourceExp := applyPrefix(testCase.InputPair.Source.Prefix, true)
- destExp := applyPrefix(testCase.InputPair.Destination.Prefix, false)
+ testRouter := &router{af: afIPv4}
+ sourceExp := testRouter.applyPrefix(testCase.InputPair.Source.Prefix, true)
+ destExp := testRouter.applyPrefix(testCase.InputPair.Destination.Prefix, false)
// Combine all expressions in the correct order
// nolint:gocritic
@@ -508,6 +509,136 @@ func TestNftablesCreateIpSet(t *testing.T) {
}
}
+func TestNftablesCreateIpSet_IPv6(t *testing.T) {
+ if check() != NFTABLES {
+ t.Skip("nftables not supported on this system")
+ }
+
+ workTable, err := createWorkTableIPv6()
+ require.NoError(t, err, "Failed to create v6 work table")
+ defer deleteWorkTableIPv6()
+
+ r, err := newRouter(workTable, ifaceMock, iface.DefaultMTU)
+ require.NoError(t, err, "Failed to create router")
+ require.NoError(t, r.init(workTable))
+ defer func() {
+ require.NoError(t, r.Reset(), "Failed to reset router")
+ }()
+
+ tests := []struct {
+ name string
+ sources []netip.Prefix
+ expected []netip.Prefix
+ }{
+ {
+ name: "Single IPv6",
+ sources: []netip.Prefix{netip.MustParsePrefix("2001:db8::1/128")},
+ },
+ {
+ name: "Multiple IPv6 Subnets",
+ sources: []netip.Prefix{
+ netip.MustParsePrefix("fd00::/64"),
+ netip.MustParsePrefix("2001:db8::/48"),
+ netip.MustParsePrefix("fe80::/10"),
+ },
+ },
+ {
+ name: "Overlapping IPv6",
+ sources: []netip.Prefix{
+ netip.MustParsePrefix("fd00::/48"),
+ netip.MustParsePrefix("fd00::/64"),
+ netip.MustParsePrefix("fd00::1/128"),
+ },
+ expected: []netip.Prefix{
+ netip.MustParsePrefix("fd00::/48"),
+ },
+ },
+ {
+ name: "Mixed prefix lengths",
+ sources: []netip.Prefix{
+ netip.MustParsePrefix("2001:db8:1::/48"),
+ netip.MustParsePrefix("2001:db8:2::1/128"),
+ netip.MustParsePrefix("fd00:abcd::/32"),
+ },
+ },
+ }
+
+ for _, tt := range tests {
+ t.Run(tt.name, func(t *testing.T) {
+ setName := firewall.NewPrefixSet(tt.sources).HashedName()
+ set, err := r.createIpSet(setName, setInput{prefixes: tt.sources})
+ require.NoError(t, err, "Failed to create IPv6 set")
+ require.NotNil(t, set)
+
+ assert.Equal(t, setName, set.Name)
+ assert.True(t, set.Interval)
+ assert.Equal(t, nftables.TypeIP6Addr, set.KeyType)
+
+ fetchedSet, err := r.conn.GetSetByName(r.workTable, setName)
+ require.NoError(t, err, "Failed to fetch created set")
+
+ elements, err := r.conn.GetSetElements(fetchedSet)
+ require.NoError(t, err, "Failed to get set elements")
+
+ uniquePrefixes := make(map[string]bool)
+ for _, elem := range elements {
+ if !elem.IntervalEnd && len(elem.Key) == 16 {
+ ip := netip.AddrFrom16([16]byte(elem.Key))
+ uniquePrefixes[ip.String()] = true
+ }
+ }
+
+ expectedCount := len(tt.expected)
+ if expectedCount == 0 {
+ expectedCount = len(tt.sources)
+ }
+ assert.Equal(t, expectedCount, len(uniquePrefixes), "unique prefix count mismatch")
+
+ r.conn.DelSet(set)
+ require.NoError(t, r.conn.Flush())
+ })
+ }
+}
+
+func createWorkTableIPv6() (*nftables.Table, error) {
+ sConn, err := nftables.New(nftables.AsLasting())
+ if err != nil {
+ return nil, err
+ }
+
+ tables, err := sConn.ListTablesOfFamily(nftables.TableFamilyIPv6)
+ if err != nil {
+ return nil, err
+ }
+ for _, t := range tables {
+ if t.Name == tableNameNetbird {
+ sConn.DelTable(t)
+ }
+ }
+
+ table := sConn.AddTable(&nftables.Table{Name: tableNameNetbird, Family: nftables.TableFamilyIPv6})
+ err = sConn.Flush()
+ return table, err
+}
+
+func deleteWorkTableIPv6() {
+ sConn, err := nftables.New(nftables.AsLasting())
+ if err != nil {
+ return
+ }
+
+ tables, err := sConn.ListTablesOfFamily(nftables.TableFamilyIPv6)
+ if err != nil {
+ return
+ }
+ for _, t := range tables {
+ if t.Name == tableNameNetbird {
+ sConn.DelTable(t)
+ _ = sConn.Flush()
+ }
+ }
+}
+
func verifyRule(t *testing.T, rule *nftables.Rule, sources []netip.Prefix, destination netip.Prefix, proto firewall.Protocol, sPort, dPort *firewall.Port, direction firewall.RuleDirection, action firewall.Action, expectSet bool) {
t.Helper()
@@ -627,7 +758,7 @@ func containsPort(exprs []expr.Any, port *firewall.Port, isSource bool) bool {
func containsProtocol(exprs []expr.Any, proto firewall.Protocol) bool {
var metaFound, cmpFound bool
- expectedProto, _ := protoToInt(proto)
+ expectedProto, _ := afIPv4.protoNum(proto)
for _, e := range exprs {
switch ex := e.(type) {
case *expr.Meta:
@@ -854,3 +985,55 @@ func TestRouter_AddNatRule_WithStaleEntry(t *testing.T) {
}
assert.Equal(t, 1, found, "NAT rule should exist in kernel")
}
+
+func TestCalculateLastIP(t *testing.T) {
+ tests := []struct {
+ prefix string
+ want string
+ }{
+ {"10.0.0.0/24", "10.0.0.255"},
+ {"10.0.0.0/32", "10.0.0.0"},
+ {"0.0.0.0/0", "255.255.255.255"},
+ {"192.168.1.0/28", "192.168.1.15"},
+ {"fd00::/64", "fd00::ffff:ffff:ffff:ffff"},
+ {"fd00::/128", "fd00::"},
+ {"2001:db8::/48", "2001:db8:0:ffff:ffff:ffff:ffff:ffff"},
+ {"::/0", "ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff"},
+ }
+ for _, tt := range tests {
+ t.Run(tt.prefix, func(t *testing.T) {
+ prefix := netip.MustParsePrefix(tt.prefix)
+ got := calculateLastIP(prefix)
+ assert.Equal(t, tt.want, got.String())
+ })
+ }
+}
+
+func TestConvertPrefixesToSet_IPv6(t *testing.T) {
+ r := &router{af: afIPv6}
+ prefixes := []netip.Prefix{
+ netip.MustParsePrefix("fd00::/64"),
+ netip.MustParsePrefix("2001:db8::1/128"),
+ }
+
+ elements := r.convertPrefixesToSet(prefixes)
+
+ // Each prefix produces 2 elements (start + end)
+ require.Len(t, elements, 4)
+
+ // fd00::/64 start
+ assert.Equal(t, netip.MustParseAddr("fd00::").As16(), [16]byte(elements[0].Key))
+ assert.False(t, elements[0].IntervalEnd)
+
+ // fd00::/64 end (fd00:0:0:1::, one past the last)
+ assert.Equal(t, netip.MustParseAddr("fd00:0:0:1::").As16(), [16]byte(elements[1].Key))
+ assert.True(t, elements[1].IntervalEnd)
+
+ // 2001:db8::1/128 start
+ assert.Equal(t, netip.MustParseAddr("2001:db8::1").As16(), [16]byte(elements[2].Key))
+ assert.False(t, elements[2].IntervalEnd)
+
+ // 2001:db8::1/128 end (2001:db8::2)
+ assert.Equal(t, netip.MustParseAddr("2001:db8::2").As16(), [16]byte(elements[3].Key))
+ assert.True(t, elements[3].IntervalEnd)
+}
diff --git a/client/firewall/uspfilter/allow_netbird_windows.go b/client/firewall/uspfilter/allow_netbird_windows.go
index 6aef2ecfd..10a2b9116 100644
--- a/client/firewall/uspfilter/allow_netbird_windows.go
+++ b/client/firewall/uspfilter/allow_netbird_windows.go
@@ -5,8 +5,10 @@ import (
"os/exec"
"syscall"
+ "github.com/hashicorp/go-multierror"
log "github.com/sirupsen/logrus"
+ nberrors "github.com/netbirdio/netbird/client/errors"
"github.com/netbirdio/netbird/client/internal/statemanager"
)
@@ -29,15 +31,20 @@ func (m *Manager) Close(*statemanager.Manager) error {
return nil
}
- if !isFirewallRuleActive(firewallRuleName) {
- return nil
+ var merr *multierror.Error
+ if isFirewallRuleActive(firewallRuleName) {
+ if err := manageFirewallRule(firewallRuleName, deleteRule); err != nil {
+ merr = multierror.Append(merr, fmt.Errorf("remove windows firewall rule: %w", err))
+ }
}
- if err := manageFirewallRule(firewallRuleName, deleteRule); err != nil {
- return fmt.Errorf("couldn't remove windows firewall: %w", err)
+ if isFirewallRuleActive(firewallRuleName + "-v6") {
+ if err := manageFirewallRule(firewallRuleName+"-v6", deleteRule); err != nil {
+ merr = multierror.Append(merr, fmt.Errorf("remove windows v6 firewall rule: %w", err))
+ }
}
- return nil
+ return nberrors.FormatErrorOrNil(merr)
}
// AllowNetbird allows netbird interface traffic
@@ -46,17 +53,33 @@ func (m *Manager) AllowNetbird() error {
return nil
}
- if isFirewallRuleActive(firewallRuleName) {
- return nil
+ if !isFirewallRuleActive(firewallRuleName) {
+ if err := manageFirewallRule(firewallRuleName,
+ addRule,
+ "dir=in",
+ "enable=yes",
+ "action=allow",
+ "profile=any",
+ "localip="+m.wgIface.Address().IP.String(),
+ ); err != nil {
+ return err
+ }
}
- return manageFirewallRule(firewallRuleName,
- addRule,
- "dir=in",
- "enable=yes",
- "action=allow",
- "profile=any",
- "localip="+m.wgIface.Address().IP.String(),
- )
+
+ if v6 := m.wgIface.Address().IPv6; v6.IsValid() && !isFirewallRuleActive(firewallRuleName+"-v6") {
+ if err := manageFirewallRule(firewallRuleName+"-v6",
+ addRule,
+ "dir=in",
+ "enable=yes",
+ "action=allow",
+ "profile=any",
+ "localip="+v6.String(),
+ ); err != nil {
+ return err
+ }
+ }
+
+ return nil
}
func manageFirewallRule(ruleName string, action action, extraArgs ...string) error {
diff --git a/client/firewall/uspfilter/conntrack/cap_test.go b/client/firewall/uspfilter/conntrack/cap_test.go
new file mode 100644
index 000000000..ee6b72e7f
--- /dev/null
+++ b/client/firewall/uspfilter/conntrack/cap_test.go
@@ -0,0 +1,125 @@
+package conntrack
+
+import (
+ "net/netip"
+ "testing"
+
+ "github.com/google/gopacket/layers"
+ "github.com/stretchr/testify/require"
+)
+
+func TestTCPCapEvicts(t *testing.T) {
+ t.Setenv(EnvTCPMaxEntries, "4")
+
+ tracker := NewTCPTracker(DefaultTCPTimeout, logger, flowLogger)
+ defer tracker.Close()
+ require.Equal(t, 4, tracker.maxEntries)
+
+ src := netip.MustParseAddr("100.64.0.1")
+ dst := netip.MustParseAddr("100.64.0.2")
+
+ for i := 0; i < 10; i++ {
+ tracker.TrackOutbound(src, dst, uint16(10000+i), 80, TCPSyn, 0)
+ }
+ require.LessOrEqual(t, len(tracker.connections), 4,
+ "TCP table must not exceed the configured cap")
+ require.Greater(t, len(tracker.connections), 0,
+ "some entries must remain after eviction")
+
+ // The most recently admitted flow must be present: eviction must make
+ // room for new entries, not silently drop them.
+ require.Contains(t, tracker.connections,
+ ConnKey{SrcIP: src, DstIP: dst, SrcPort: uint16(10009), DstPort: 80},
+ "newest TCP flow must be admitted after eviction")
+ // A pre-cap flow must have been evicted to fit the last one.
+ require.NotContains(t, tracker.connections,
+ ConnKey{SrcIP: src, DstIP: dst, SrcPort: uint16(10000), DstPort: 80},
+ "oldest TCP flow should have been evicted")
+}
+
+func TestTCPCapPrefersTombstonedForEviction(t *testing.T) {
+ t.Setenv(EnvTCPMaxEntries, "3")
+
+ tracker := NewTCPTracker(DefaultTCPTimeout, logger, flowLogger)
+ defer tracker.Close()
+
+ src := netip.MustParseAddr("100.64.0.1")
+ dst := netip.MustParseAddr("100.64.0.2")
+
+ // Fill to cap with 3 live connections.
+ for i := 0; i < 3; i++ {
+ tracker.TrackOutbound(src, dst, uint16(20000+i), 80, TCPSyn, 0)
+ }
+ require.Len(t, tracker.connections, 3)
+
+ // Tombstone one by sending RST through IsValidInbound.
+ tombstonedKey := ConnKey{SrcIP: src, DstIP: dst, SrcPort: 20001, DstPort: 80}
+ require.True(t, tracker.IsValidInbound(dst, src, 80, 20001, TCPRst|TCPAck, 0))
+ require.True(t, tracker.connections[tombstonedKey].IsTombstone())
+
+ // Another live connection forces eviction. The tombstone must go first.
+ tracker.TrackOutbound(src, dst, uint16(29999), 80, TCPSyn, 0)
+
+ _, tombstonedStillPresent := tracker.connections[tombstonedKey]
+ require.False(t, tombstonedStillPresent,
+ "tombstoned entry should be evicted before live entries")
+ require.LessOrEqual(t, len(tracker.connections), 3)
+
+ // Both live pre-cap entries must survive: eviction must prefer the
+ // tombstone, not just satisfy the size bound by dropping any entry.
+ require.Contains(t, tracker.connections,
+ ConnKey{SrcIP: src, DstIP: dst, SrcPort: uint16(20000), DstPort: 80},
+ "live entries must not be evicted while a tombstone exists")
+ require.Contains(t, tracker.connections,
+ ConnKey{SrcIP: src, DstIP: dst, SrcPort: uint16(20002), DstPort: 80},
+ "live entries must not be evicted while a tombstone exists")
+}
+
+func TestUDPCapEvicts(t *testing.T) {
+ t.Setenv(EnvUDPMaxEntries, "5")
+
+ tracker := NewUDPTracker(DefaultUDPTimeout, logger, flowLogger)
+ defer tracker.Close()
+ require.Equal(t, 5, tracker.maxEntries)
+
+ src := netip.MustParseAddr("100.64.0.1")
+ dst := netip.MustParseAddr("100.64.0.2")
+
+ for i := 0; i < 12; i++ {
+ tracker.TrackOutbound(src, dst, uint16(30000+i), 53, 0)
+ }
+ require.LessOrEqual(t, len(tracker.connections), 5)
+ require.Greater(t, len(tracker.connections), 0)
+
+ require.Contains(t, tracker.connections,
+ ConnKey{SrcIP: src, DstIP: dst, SrcPort: uint16(30011), DstPort: 53},
+ "newest UDP flow must be admitted after eviction")
+ require.NotContains(t, tracker.connections,
+ ConnKey{SrcIP: src, DstIP: dst, SrcPort: uint16(30000), DstPort: 53},
+ "oldest UDP flow should have been evicted")
+}
+
+func TestICMPCapEvicts(t *testing.T) {
+ t.Setenv(EnvICMPMaxEntries, "3")
+
+ tracker := NewICMPTracker(DefaultICMPTimeout, logger, flowLogger)
+ defer tracker.Close()
+ require.Equal(t, 3, tracker.maxEntries)
+
+ src := netip.MustParseAddr("100.64.0.1")
+ dst := netip.MustParseAddr("100.64.0.2")
+
+ echoReq := layers.CreateICMPv4TypeCode(uint8(layers.ICMPv4TypeEchoRequest), 0)
+ for i := 0; i < 8; i++ {
+ tracker.TrackOutbound(src, dst, uint16(i), echoReq, nil, 64)
+ }
+ require.LessOrEqual(t, len(tracker.connections), 3)
+ require.Greater(t, len(tracker.connections), 0)
+
+ require.Contains(t, tracker.connections,
+ ICMPConnKey{SrcIP: src, DstIP: dst, ID: uint16(7)},
+ "newest ICMP flow must be admitted after eviction")
+ require.NotContains(t, tracker.connections,
+ ICMPConnKey{SrcIP: src, DstIP: dst, ID: uint16(0)},
+ "oldest ICMP flow should have been evicted")
+}
diff --git a/client/firewall/uspfilter/conntrack/common.go b/client/firewall/uspfilter/conntrack/common.go
index 7be0dd78f..e497a0bff 100644
--- a/client/firewall/uspfilter/conntrack/common.go
+++ b/client/firewall/uspfilter/conntrack/common.go
@@ -1,16 +1,63 @@
package conntrack
import (
- "fmt"
+ "net"
"net/netip"
+ "os"
+ "strconv"
"sync/atomic"
"time"
"github.com/google/uuid"
+ nblog "github.com/netbirdio/netbird/client/firewall/uspfilter/log"
nftypes "github.com/netbirdio/netbird/client/internal/netflow/types"
)
+// evictSampleSize bounds how many map entries we scan per eviction call.
+// Keeps eviction O(1) even at cap under sustained load; the sampled-LRU
+// heuristic is good enough for a conntrack table that only overflows under
+// abuse.
+const evictSampleSize = 8
+
+// envDuration parses an os.Getenv(name) as a time.Duration. Falls back to
+// def on empty or invalid; logs a warning on invalid.
+func envDuration(logger *nblog.Logger, name string, def time.Duration) time.Duration {
+ v := os.Getenv(name)
+ if v == "" {
+ return def
+ }
+ d, err := time.ParseDuration(v)
+ if err != nil {
+ logger.Warn3("invalid %s=%q: %v, using default", name, v, err)
+ return def
+ }
+ if d <= 0 {
+ logger.Warn2("invalid %s=%q: must be positive, using default", name, v)
+ return def
+ }
+ return d
+}
+
+// envInt parses an os.Getenv(name) as an int. Falls back to def on empty,
+// invalid, or non-positive. Logs a warning on invalid input.
+func envInt(logger *nblog.Logger, name string, def int) int {
+ v := os.Getenv(name)
+ if v == "" {
+ return def
+ }
+ n, err := strconv.Atoi(v)
+ switch {
+ case err != nil:
+ logger.Warn3("invalid %s=%q: %v, using default", name, v, err)
+ return def
+ case n <= 0:
+ logger.Warn2("invalid %s=%q: must be positive, using default", name, v)
+ return def
+ }
+ return n
+}
+
// BaseConnTrack provides common fields and locking for all connection types
type BaseConnTrack struct {
FlowId uuid.UUID
@@ -64,5 +111,7 @@ type ConnKey struct {
}
func (c ConnKey) String() string {
- return fmt.Sprintf("%s:%d โ %s:%d", c.SrcIP.Unmap(), c.SrcPort, c.DstIP.Unmap(), c.DstPort)
+ return net.JoinHostPort(c.SrcIP.Unmap().String(), strconv.Itoa(int(c.SrcPort))) +
+ " โ " +
+ net.JoinHostPort(c.DstIP.Unmap().String(), strconv.Itoa(int(c.DstPort)))
}
diff --git a/client/firewall/uspfilter/conntrack/common_test.go b/client/firewall/uspfilter/conntrack/common_test.go
index d868dd1fb..7e67b98fa 100644
--- a/client/firewall/uspfilter/conntrack/common_test.go
+++ b/client/firewall/uspfilter/conntrack/common_test.go
@@ -13,6 +13,54 @@ import (
var logger = log.NewFromLogrus(logrus.StandardLogger())
var flowLogger = netflow.NewManager(nil, []byte{}, nil).GetLogger()
+func TestConnKey_String(t *testing.T) {
+ tests := []struct {
+ name string
+ key ConnKey
+ expect string
+ }{
+ {
+ name: "IPv4",
+ key: ConnKey{
+ SrcIP: netip.MustParseAddr("192.168.1.1"),
+ DstIP: netip.MustParseAddr("10.0.0.1"),
+ SrcPort: 12345,
+ DstPort: 80,
+ },
+ expect: "192.168.1.1:12345 โ 10.0.0.1:80",
+ },
+ {
+ name: "IPv6",
+ key: ConnKey{
+ SrcIP: netip.MustParseAddr("2001:db8::1"),
+ DstIP: netip.MustParseAddr("2001:db8::2"),
+ SrcPort: 54321,
+ DstPort: 443,
+ },
+ expect: "[2001:db8::1]:54321 โ [2001:db8::2]:443",
+ },
+ {
+ name: "IPv4-mapped IPv6 unmaps",
+ key: ConnKey{
+ SrcIP: netip.MustParseAddr("::ffff:10.0.0.1"),
+ DstIP: netip.MustParseAddr("::ffff:10.0.0.2"),
+ SrcPort: 1000,
+ DstPort: 2000,
+ },
+ expect: "10.0.0.1:1000 โ 10.0.0.2:2000",
+ },
+ }
+
+ for _, tc := range tests {
+ t.Run(tc.name, func(t *testing.T) {
+ got := tc.key.String()
+ if got != tc.expect {
+ t.Errorf("got %q, want %q", got, tc.expect)
+ }
+ })
+ }
+}
+
// Memory pressure tests
func BenchmarkMemoryPressure(b *testing.B) {
b.Run("TCPHighLoad", func(b *testing.B) {
diff --git a/client/firewall/uspfilter/conntrack/defaults_desktop.go b/client/firewall/uspfilter/conntrack/defaults_desktop.go
new file mode 100644
index 000000000..2f07f5984
--- /dev/null
+++ b/client/firewall/uspfilter/conntrack/defaults_desktop.go
@@ -0,0 +1,11 @@
+//go:build !ios && !android
+
+package conntrack
+
+// Default per-tracker entry caps on desktop/server platforms. These mirror
+// typical Linux netfilter nf_conntrack_max territory with ample headroom.
+const (
+ DefaultMaxTCPEntries = 65536
+ DefaultMaxUDPEntries = 16384
+ DefaultMaxICMPEntries = 2048
+)
diff --git a/client/firewall/uspfilter/conntrack/defaults_mobile.go b/client/firewall/uspfilter/conntrack/defaults_mobile.go
new file mode 100644
index 000000000..c9e05d229
--- /dev/null
+++ b/client/firewall/uspfilter/conntrack/defaults_mobile.go
@@ -0,0 +1,13 @@
+//go:build ios || android
+
+package conntrack
+
+// Default per-tracker entry caps on mobile platforms. iOS network extensions
+// are capped at ~50 MB; Android runs under aggressive memory pressure. These
+// values keep conntrack footprint well under 5 MB worst case (TCPConnTrack
+// is ~200 B plus map overhead).
+const (
+ DefaultMaxTCPEntries = 4096
+ DefaultMaxUDPEntries = 2048
+ DefaultMaxICMPEntries = 512
+)
diff --git a/client/firewall/uspfilter/conntrack/icmp.go b/client/firewall/uspfilter/conntrack/icmp.go
index 50b663642..3c96548b5 100644
--- a/client/firewall/uspfilter/conntrack/icmp.go
+++ b/client/firewall/uspfilter/conntrack/icmp.go
@@ -5,6 +5,7 @@ import (
"fmt"
"net"
"net/netip"
+ "strconv"
"sync"
"time"
@@ -21,9 +22,14 @@ const (
// ICMPCleanupInterval is how often we check for stale ICMP connections
ICMPCleanupInterval = 15 * time.Second
- // MaxICMPPayloadLength is the maximum length of ICMP payload we consider for original packet info,
- // which includes the IP header (20 bytes) and transport header (8 bytes)
- MaxICMPPayloadLength = 28
+ // MaxICMPPayloadLength is the maximum length of ICMP payload we consider for original packet info.
+ // IPv4: 20-byte header + 8-byte transport = 28 bytes.
+ // IPv6: 40-byte header + 8-byte transport = 48 bytes.
+ MaxICMPPayloadLength = 48
+ // minICMPPayloadIPv4 is the minimum embedded packet length for IPv4 ICMP errors.
+ minICMPPayloadIPv4 = 28
+ // minICMPPayloadIPv6 is the minimum embedded packet length for IPv6 ICMP errors.
+ minICMPPayloadIPv6 = 48
)
// ICMPConnKey uniquely identifies an ICMP connection
@@ -44,6 +50,9 @@ type ICMPConnTrack struct {
ICMPCode uint8
}
+// EnvICMPMaxEntries caps the ICMP conntrack table size.
+const EnvICMPMaxEntries = "NB_CONNTRACK_ICMP_MAX"
+
// ICMPTracker manages ICMP connection states
type ICMPTracker struct {
logger *nblog.Logger
@@ -52,6 +61,7 @@ type ICMPTracker struct {
cleanupTicker *time.Ticker
tickerCancel context.CancelFunc
mutex sync.RWMutex
+ maxEntries int
flowLogger nftypes.FlowLogger
}
@@ -65,7 +75,7 @@ type ICMPInfo struct {
// String implements fmt.Stringer for lazy evaluation in log messages
func (info ICMPInfo) String() string {
- if info.isErrorMessage() && info.PayloadLen >= MaxICMPPayloadLength {
+ if info.isErrorMessage() && info.PayloadLen >= minICMPPayloadIPv4 {
if origInfo := info.parseOriginalPacket(); origInfo != "" {
return fmt.Sprintf("%s (original: %s)", info.TypeCode, origInfo)
}
@@ -74,42 +84,72 @@ func (info ICMPInfo) String() string {
return info.TypeCode.String()
}
-// isErrorMessage returns true if this ICMP type carries original packet info
+// isErrorMessage returns true if this ICMP type carries original packet info.
+// Covers both ICMPv4 and ICMPv6 error types. Without a family field we match
+// both sets; type 3 overlaps (v4 DestUnreachable / v6 TimeExceeded) so it's
+// kept as a literal.
func (info ICMPInfo) isErrorMessage() bool {
typ := info.TypeCode.Type()
- return typ == 3 || // Destination Unreachable
- typ == 5 || // Redirect
- typ == 11 || // Time Exceeded
- typ == 12 // Parameter Problem
+ // ICMPv4 error types
+ if typ == layers.ICMPv4TypeDestinationUnreachable ||
+ typ == layers.ICMPv4TypeRedirect ||
+ typ == layers.ICMPv4TypeTimeExceeded ||
+ typ == layers.ICMPv4TypeParameterProblem {
+ return true
+ }
+ // ICMPv6 error types (type 3 already matched above as v4 DestUnreachable)
+ if typ == layers.ICMPv6TypeDestinationUnreachable ||
+ typ == layers.ICMPv6TypePacketTooBig ||
+ typ == layers.ICMPv6TypeParameterProblem {
+ return true
+ }
+ return false
}
// parseOriginalPacket extracts info about the original packet from ICMP payload
func (info ICMPInfo) parseOriginalPacket() string {
- if info.PayloadLen < MaxICMPPayloadLength {
+ if info.PayloadLen == 0 {
return ""
}
- // TODO: handle IPv6
- if version := (info.PayloadData[0] >> 4) & 0xF; version != 4 {
+ version := (info.PayloadData[0] >> 4) & 0xF
+
+ var protocol uint8
+ var srcIP, dstIP net.IP
+ var transportData []byte
+
+ switch version {
+ case 4:
+ if info.PayloadLen < minICMPPayloadIPv4 {
+ return ""
+ }
+ protocol = info.PayloadData[9]
+ srcIP = net.IP(info.PayloadData[12:16])
+ dstIP = net.IP(info.PayloadData[16:20])
+ transportData = info.PayloadData[20:]
+ case 6:
+ if info.PayloadLen < minICMPPayloadIPv6 {
+ return ""
+ }
+ // Next Header field in IPv6 header
+ protocol = info.PayloadData[6]
+ srcIP = net.IP(info.PayloadData[8:24])
+ dstIP = net.IP(info.PayloadData[24:40])
+ transportData = info.PayloadData[40:]
+ default:
return ""
}
- protocol := info.PayloadData[9]
- srcIP := net.IP(info.PayloadData[12:16])
- dstIP := net.IP(info.PayloadData[16:20])
-
- transportData := info.PayloadData[20:]
-
switch nftypes.Protocol(protocol) {
case nftypes.TCP:
srcPort := uint16(transportData[0])<<8 | uint16(transportData[1])
dstPort := uint16(transportData[2])<<8 | uint16(transportData[3])
- return fmt.Sprintf("TCP %s:%d โ %s:%d", srcIP, srcPort, dstIP, dstPort)
+ return "TCP " + net.JoinHostPort(srcIP.String(), strconv.Itoa(int(srcPort))) + " โ " + net.JoinHostPort(dstIP.String(), strconv.Itoa(int(dstPort)))
case nftypes.UDP:
srcPort := uint16(transportData[0])<<8 | uint16(transportData[1])
dstPort := uint16(transportData[2])<<8 | uint16(transportData[3])
- return fmt.Sprintf("UDP %s:%d โ %s:%d", srcIP, srcPort, dstIP, dstPort)
+ return "UDP " + net.JoinHostPort(srcIP.String(), strconv.Itoa(int(srcPort))) + " โ " + net.JoinHostPort(dstIP.String(), strconv.Itoa(int(dstPort)))
case nftypes.ICMP:
icmpType := transportData[0]
@@ -135,6 +175,7 @@ func NewICMPTracker(timeout time.Duration, logger *nblog.Logger, flowLogger nfty
timeout: timeout,
cleanupTicker: time.NewTicker(ICMPCleanupInterval),
tickerCancel: cancel,
+ maxEntries: envInt(logger, EnvICMPMaxEntries, DefaultMaxICMPEntries),
flowLogger: flowLogger,
}
@@ -221,7 +262,9 @@ func (t *ICMPTracker) track(
// non echo requests don't need tracking
if typ != uint8(layers.ICMPv4TypeEchoRequest) {
- t.logger.Trace3("New %s ICMP connection %s - %s", direction, key, icmpInfo)
+ if t.logger.Enabled(nblog.LevelTrace) {
+ t.logger.Trace3("New %s ICMP connection %s - %s", direction, key, icmpInfo)
+ }
t.sendStartEvent(direction, srcIP, dstIP, typ, code, ruleId, size)
return
}
@@ -240,16 +283,22 @@ func (t *ICMPTracker) track(
conn.UpdateCounters(direction, size)
t.mutex.Lock()
+ if t.maxEntries > 0 && len(t.connections) >= t.maxEntries {
+ t.evictOneLocked()
+ }
t.connections[key] = conn
t.mutex.Unlock()
- t.logger.Trace3("New %s ICMP connection %s - %s", direction, key, icmpInfo)
+ if t.logger.Enabled(nblog.LevelTrace) {
+ t.logger.Trace3("New %s ICMP connection %s - %s", direction, key, icmpInfo)
+ }
t.sendEvent(nftypes.TypeStart, conn, ruleId)
}
-// IsValidInbound checks if an inbound ICMP Echo Reply matches a tracked request
+// IsValidInbound checks if an inbound ICMP Echo Reply matches a tracked request.
+// Accepts both ICMPv4 (type 0) and ICMPv6 (type 129) echo replies.
func (t *ICMPTracker) IsValidInbound(srcIP netip.Addr, dstIP netip.Addr, id uint16, icmpType uint8, size int) bool {
- if icmpType != uint8(layers.ICMPv4TypeEchoReply) {
+ if icmpType != uint8(layers.ICMPv4TypeEchoReply) && icmpType != uint8(layers.ICMPv6TypeEchoReply) {
return false
}
@@ -286,6 +335,34 @@ func (t *ICMPTracker) cleanupRoutine(ctx context.Context) {
}
}
+// evictOneLocked removes one entry to make room. Caller must hold t.mutex.
+// Bounded sample scan: picks the oldest among up to evictSampleSize entries.
+func (t *ICMPTracker) evictOneLocked() {
+ var candKey ICMPConnKey
+ var candSeen int64
+ haveCand := false
+ sampled := 0
+
+ for k, c := range t.connections {
+ seen := c.lastSeen.Load()
+ if !haveCand || seen < candSeen {
+ candKey = k
+ candSeen = seen
+ haveCand = true
+ }
+ sampled++
+ if sampled >= evictSampleSize {
+ break
+ }
+ }
+ if haveCand {
+ if evicted := t.connections[candKey]; evicted != nil {
+ t.sendEvent(nftypes.TypeEnd, evicted, nil)
+ }
+ delete(t.connections, candKey)
+ }
+}
+
func (t *ICMPTracker) cleanup() {
t.mutex.Lock()
defer t.mutex.Unlock()
@@ -294,13 +371,22 @@ func (t *ICMPTracker) cleanup() {
if conn.timeoutExceeded(t.timeout) {
delete(t.connections, key)
- t.logger.Trace5("Removed ICMP connection %s (timeout) [in: %d Pkts/%d B out: %d Pkts/%d B]",
- key, conn.PacketsRx.Load(), conn.BytesRx.Load(), conn.PacketsTx.Load(), conn.BytesTx.Load())
+ if t.logger.Enabled(nblog.LevelTrace) {
+ t.logger.Trace5("Removed ICMP connection %s (timeout) [in: %d Pkts/%d B out: %d Pkts/%d B]",
+ key, conn.PacketsRx.Load(), conn.BytesRx.Load(), conn.PacketsTx.Load(), conn.BytesTx.Load())
+ }
t.sendEvent(nftypes.TypeEnd, conn, nil)
}
}
}
+func icmpProtocolForAddr(ip netip.Addr) nftypes.Protocol {
+ if ip.Is6() {
+ return nftypes.ICMPv6
+ }
+ return nftypes.ICMP
+}
+
// Close stops the cleanup routine and releases resources
func (t *ICMPTracker) Close() {
t.tickerCancel()
@@ -316,7 +402,7 @@ func (t *ICMPTracker) sendEvent(typ nftypes.Type, conn *ICMPConnTrack, ruleID []
Type: typ,
RuleID: ruleID,
Direction: conn.Direction,
- Protocol: nftypes.ICMP, // TODO: adjust for IPv6/icmpv6
+ Protocol: icmpProtocolForAddr(conn.SourceIP),
SourceIP: conn.SourceIP,
DestIP: conn.DestIP,
ICMPType: conn.ICMPType,
@@ -334,7 +420,7 @@ func (t *ICMPTracker) sendStartEvent(direction nftypes.Direction, srcIP netip.Ad
Type: nftypes.TypeStart,
RuleID: ruleID,
Direction: direction,
- Protocol: nftypes.ICMP,
+ Protocol: icmpProtocolForAddr(srcIP),
SourceIP: srcIP,
DestIP: dstIP,
ICMPType: typ,
diff --git a/client/firewall/uspfilter/conntrack/icmp_test.go b/client/firewall/uspfilter/conntrack/icmp_test.go
index b15b42cf0..6d1f87162 100644
--- a/client/firewall/uspfilter/conntrack/icmp_test.go
+++ b/client/firewall/uspfilter/conntrack/icmp_test.go
@@ -5,6 +5,42 @@ import (
"testing"
)
+func TestICMPConnKey_String(t *testing.T) {
+ tests := []struct {
+ name string
+ key ICMPConnKey
+ expect string
+ }{
+ {
+ name: "IPv4",
+ key: ICMPConnKey{
+ SrcIP: netip.MustParseAddr("192.168.1.1"),
+ DstIP: netip.MustParseAddr("10.0.0.1"),
+ ID: 1234,
+ },
+ expect: "192.168.1.1 โ 10.0.0.1 (id 1234)",
+ },
+ {
+ name: "IPv6",
+ key: ICMPConnKey{
+ SrcIP: netip.MustParseAddr("2001:db8::1"),
+ DstIP: netip.MustParseAddr("2001:db8::2"),
+ ID: 5678,
+ },
+ expect: "2001:db8::1 โ 2001:db8::2 (id 5678)",
+ },
+ }
+
+ for _, tc := range tests {
+ t.Run(tc.name, func(t *testing.T) {
+ got := tc.key.String()
+ if got != tc.expect {
+ t.Errorf("got %q, want %q", got, tc.expect)
+ }
+ })
+ }
+}
+
func BenchmarkICMPTracker(b *testing.B) {
b.Run("TrackOutbound", func(b *testing.B) {
tracker := NewICMPTracker(DefaultICMPTimeout, logger, flowLogger)
diff --git a/client/firewall/uspfilter/conntrack/tcp.go b/client/firewall/uspfilter/conntrack/tcp.go
index 335a3abab..9edc9af22 100644
--- a/client/firewall/uspfilter/conntrack/tcp.go
+++ b/client/firewall/uspfilter/conntrack/tcp.go
@@ -38,6 +38,27 @@ const (
TCPHandshakeTimeout = 60 * time.Second
// TCPCleanupInterval is how often we check for stale connections
TCPCleanupInterval = 5 * time.Minute
+ // FinWaitTimeout bounds FIN_WAIT_1 / FIN_WAIT_2 / CLOSING states.
+ // Matches Linux netfilter nf_conntrack_tcp_timeout_fin_wait.
+ FinWaitTimeout = 60 * time.Second
+ // CloseWaitTimeout bounds CLOSE_WAIT. Matches Linux default; apps
+ // holding CloseWait longer than this should bump the env var.
+ CloseWaitTimeout = 60 * time.Second
+ // LastAckTimeout bounds LAST_ACK. Matches Linux default.
+ LastAckTimeout = 30 * time.Second
+)
+
+// Env vars to override per-state teardown timeouts. Values parsed by
+// time.ParseDuration (e.g. "120s", "2m"). Invalid values fall back to the
+// defaults above with a warning.
+const (
+ EnvTCPFinWaitTimeout = "NB_CONNTRACK_TCP_FIN_WAIT_TIMEOUT"
+ EnvTCPCloseWaitTimeout = "NB_CONNTRACK_TCP_CLOSE_WAIT_TIMEOUT"
+ EnvTCPLastAckTimeout = "NB_CONNTRACK_TCP_LAST_ACK_TIMEOUT"
+
+ // EnvTCPMaxEntries caps the TCP conntrack table size. Oldest entries
+ // (tombstones first) are evicted when the cap is reached.
+ EnvTCPMaxEntries = "NB_CONNTRACK_TCP_MAX"
)
// TCPState represents the state of a TCP connection
@@ -133,14 +154,18 @@ func (t *TCPConnTrack) SetTombstone() {
// TCPTracker manages TCP connection states
type TCPTracker struct {
- logger *nblog.Logger
- connections map[ConnKey]*TCPConnTrack
- mutex sync.RWMutex
- cleanupTicker *time.Ticker
- tickerCancel context.CancelFunc
- timeout time.Duration
- waitTimeout time.Duration
- flowLogger nftypes.FlowLogger
+ logger *nblog.Logger
+ connections map[ConnKey]*TCPConnTrack
+ mutex sync.RWMutex
+ cleanupTicker *time.Ticker
+ tickerCancel context.CancelFunc
+ timeout time.Duration
+ waitTimeout time.Duration
+ finWaitTimeout time.Duration
+ closeWaitTimeout time.Duration
+ lastAckTimeout time.Duration
+ maxEntries int
+ flowLogger nftypes.FlowLogger
}
// NewTCPTracker creates a new TCP connection tracker
@@ -155,13 +180,17 @@ func NewTCPTracker(timeout time.Duration, logger *nblog.Logger, flowLogger nftyp
ctx, cancel := context.WithCancel(context.Background())
tracker := &TCPTracker{
- logger: logger,
- connections: make(map[ConnKey]*TCPConnTrack),
- cleanupTicker: time.NewTicker(TCPCleanupInterval),
- tickerCancel: cancel,
- timeout: timeout,
- waitTimeout: waitTimeout,
- flowLogger: flowLogger,
+ logger: logger,
+ connections: make(map[ConnKey]*TCPConnTrack),
+ cleanupTicker: time.NewTicker(TCPCleanupInterval),
+ tickerCancel: cancel,
+ timeout: timeout,
+ waitTimeout: waitTimeout,
+ finWaitTimeout: envDuration(logger, EnvTCPFinWaitTimeout, FinWaitTimeout),
+ closeWaitTimeout: envDuration(logger, EnvTCPCloseWaitTimeout, CloseWaitTimeout),
+ lastAckTimeout: envDuration(logger, EnvTCPLastAckTimeout, LastAckTimeout),
+ maxEntries: envInt(logger, EnvTCPMaxEntries, DefaultMaxTCPEntries),
+ flowLogger: flowLogger,
}
go tracker.cleanupRoutine(ctx)
@@ -209,6 +238,12 @@ func (t *TCPTracker) track(srcIP, dstIP netip.Addr, srcPort, dstPort uint16, fla
if exists || flags&TCPSyn == 0 {
return
}
+ // Reject illegal SYN combinations (SYN+FIN, SYN+RST, โฆ) so they don't
+ // create spurious conntrack entries. Not mandated by RFC 9293 but a
+ // common hardening (Linux netfilter/nftables rejects these too).
+ if !isValidFlagCombination(flags) {
+ return
+ }
conn := &TCPConnTrack{
BaseConnTrack: BaseConnTrack{
@@ -225,20 +260,65 @@ func (t *TCPTracker) track(srcIP, dstIP netip.Addr, srcPort, dstPort uint16, fla
conn.state.Store(int32(TCPStateNew))
conn.DNATOrigPort.Store(uint32(origPort))
- if origPort != 0 {
- t.logger.Trace4("New %s TCP connection: %s (port DNAT %d -> %d)", direction, key, origPort, dstPort)
- } else {
- t.logger.Trace2("New %s TCP connection: %s", direction, key)
+ if t.logger.Enabled(nblog.LevelTrace) {
+ if origPort != 0 {
+ t.logger.Trace4("New %s TCP connection: %s (port DNAT %d -> %d)", direction, key, origPort, dstPort)
+ } else {
+ t.logger.Trace2("New %s TCP connection: %s", direction, key)
+ }
}
t.updateState(key, conn, flags, direction, size)
t.mutex.Lock()
+ if t.maxEntries > 0 && len(t.connections) >= t.maxEntries {
+ t.evictOneLocked()
+ }
t.connections[key] = conn
t.mutex.Unlock()
t.sendEvent(nftypes.TypeStart, conn, ruleID)
}
+// evictOneLocked removes one entry to make room. Caller must hold t.mutex.
+// Bounded scan: samples up to evictSampleSize pseudo-random entries (Go map
+// iteration order is randomized), preferring a tombstone. If no tombstone
+// found in the sample, evicts the oldest among the sampled entries. O(1)
+// worst case โ cheap enough to run on every insert at cap during abuse.
+func (t *TCPTracker) evictOneLocked() {
+ var candKey ConnKey
+ var candSeen int64
+ haveCand := false
+ sampled := 0
+
+ for k, c := range t.connections {
+ if c.IsTombstone() {
+ delete(t.connections, k)
+ return
+ }
+ seen := c.lastSeen.Load()
+ if !haveCand || seen < candSeen {
+ candKey = k
+ candSeen = seen
+ haveCand = true
+ }
+ sampled++
+ if sampled >= evictSampleSize {
+ break
+ }
+ }
+ if haveCand {
+ if evicted := t.connections[candKey]; evicted != nil {
+ // TypeEnd is already emitted at the state transition to
+ // TimeWait and when a connection is tombstoned. Only emit
+ // here when we're reaping a still-active flow.
+ if evicted.GetState() != TCPStateTimeWait && !evicted.IsTombstone() {
+ t.sendEvent(nftypes.TypeEnd, evicted, nil)
+ }
+ }
+ delete(t.connections, candKey)
+ }
+}
+
// IsValidInbound checks if an inbound TCP packet matches a tracked connection
func (t *TCPTracker) IsValidInbound(srcIP, dstIP netip.Addr, srcPort, dstPort uint16, flags uint8, size int) bool {
key := ConnKey{
@@ -256,12 +336,19 @@ func (t *TCPTracker) IsValidInbound(srcIP, dstIP netip.Addr, srcPort, dstPort ui
return false
}
+ // Reject illegal flag combinations regardless of state. These never belong
+ // to a legitimate flow and must not advance or tear down state.
+ if !isValidFlagCombination(flags) {
+ if t.logger.Enabled(nblog.LevelWarn) {
+ t.logger.Warn3("TCP illegal flag combination %x for connection %s (state %s)", flags, key, conn.GetState())
+ }
+ return false
+ }
+
currentState := conn.GetState()
if !t.isValidStateForFlags(currentState, flags) {
- t.logger.Warn3("TCP state %s is not valid with flags %x for connection %s", currentState, flags, key)
- // allow all flags for established for now
- if currentState == TCPStateEstablished {
- return true
+ if t.logger.Enabled(nblog.LevelWarn) {
+ t.logger.Warn3("TCP state %s is not valid with flags %x for connection %s", currentState, flags, key)
}
return false
}
@@ -270,116 +357,208 @@ func (t *TCPTracker) IsValidInbound(srcIP, dstIP netip.Addr, srcPort, dstPort ui
return true
}
-// updateState updates the TCP connection state based on flags
+// updateState updates the TCP connection state based on flags.
func (t *TCPTracker) updateState(key ConnKey, conn *TCPConnTrack, flags uint8, packetDir nftypes.Direction, size int) {
- conn.UpdateLastSeen()
conn.UpdateCounters(packetDir, size)
+ // Malformed flag combinations must not refresh lastSeen or drive state,
+ // otherwise spoofed packets keep a dead flow alive past its timeout.
+ if !isValidFlagCombination(flags) {
+ return
+ }
+
+ conn.UpdateLastSeen()
+
currentState := conn.GetState()
if flags&TCPRst != 0 {
- if conn.CompareAndSwapState(currentState, TCPStateClosed) {
- conn.SetTombstone()
- t.logger.Trace6("TCP connection reset: %s (dir: %s) [in: %d Pkts/%d B, out: %d Pkts/%d B]",
- key, packetDir, conn.PacketsRx.Load(), conn.BytesRx.Load(), conn.PacketsTx.Load(), conn.BytesTx.Load())
- t.sendEvent(nftypes.TypeEnd, conn, nil)
- }
+ // Hardening beyond RFC 9293 ยง3.10.7.4: without sequence tracking we
+ // cannot apply the RFC 5961 in-window RST check, so we conservatively
+ // reject RSTs that the spec would accept (TIME-WAIT with in-window
+ // SEQ, SynSent from same direction as own SYN, etc.).
+ t.handleRst(key, conn, currentState, packetDir)
return
}
- var newState TCPState
- switch currentState {
- case TCPStateNew:
- if flags&TCPSyn != 0 && flags&TCPAck == 0 {
- if conn.Direction == nftypes.Egress {
- newState = TCPStateSynSent
- } else {
- newState = TCPStateSynReceived
- }
- }
+ newState := nextState(currentState, conn.Direction, packetDir, flags)
+ if newState == 0 || !conn.CompareAndSwapState(currentState, newState) {
+ return
+ }
+ t.onTransition(key, conn, currentState, newState, packetDir)
+}
- case TCPStateSynSent:
- if flags&TCPSyn != 0 && flags&TCPAck != 0 {
- if packetDir != conn.Direction {
- newState = TCPStateEstablished
- } else {
- // Simultaneous open
- newState = TCPStateSynReceived
- }
- }
+// handleRst processes a RST segment. Late RSTs in TimeWait and spoofed RSTs
+// from the SYN direction are ignored; otherwise the flow is tombstoned.
+func (t *TCPTracker) handleRst(key ConnKey, conn *TCPConnTrack, currentState TCPState, packetDir nftypes.Direction) {
+ // TimeWait exists to absorb late segments; don't let a late RST
+ // tombstone the entry and break same-4-tuple reuse.
+ if currentState == TCPStateTimeWait {
+ return
+ }
+ // A RST from the same direction as the SYN cannot be a legitimate
+ // response and must not tear down a half-open connection.
+ if currentState == TCPStateSynSent && packetDir == conn.Direction {
+ return
+ }
+ if !conn.CompareAndSwapState(currentState, TCPStateClosed) {
+ return
+ }
+ conn.SetTombstone()
+ if t.logger.Enabled(nblog.LevelTrace) {
+ t.logger.Trace6("TCP connection reset: %s (dir: %s) [in: %d Pkts/%d B, out: %d Pkts/%d B]",
+ key, packetDir, conn.PacketsRx.Load(), conn.BytesRx.Load(), conn.PacketsTx.Load(), conn.BytesTx.Load())
+ }
+ t.sendEvent(nftypes.TypeEnd, conn, nil)
+}
- case TCPStateSynReceived:
- if flags&TCPAck != 0 && flags&TCPSyn == 0 {
- if packetDir == conn.Direction {
- newState = TCPStateEstablished
- }
- }
+// stateTransition describes one state's transition logic. It receives the
+// packet's flags plus whether the packet direction matches the connection's
+// origin direction (same=true means same side as the SYN initiator). Return 0
+// for no transition.
+type stateTransition func(flags uint8, connDir nftypes.Direction, same bool) TCPState
- case TCPStateEstablished:
- if flags&TCPFin != 0 {
- if packetDir == conn.Direction {
- newState = TCPStateFinWait1
- } else {
- newState = TCPStateCloseWait
- }
- }
+// stateTable maps each state to its transition function. Centralized here so
+// nextState stays trivial and each rule is easy to read in isolation.
+var stateTable = map[TCPState]stateTransition{
+ TCPStateNew: transNew,
+ TCPStateSynSent: transSynSent,
+ TCPStateSynReceived: transSynReceived,
+ TCPStateEstablished: transEstablished,
+ TCPStateFinWait1: transFinWait1,
+ TCPStateFinWait2: transFinWait2,
+ TCPStateClosing: transClosing,
+ TCPStateCloseWait: transCloseWait,
+ TCPStateLastAck: transLastAck,
+}
- case TCPStateFinWait1:
- if packetDir != conn.Direction {
- switch {
- case flags&TCPFin != 0 && flags&TCPAck != 0:
- newState = TCPStateClosing
- case flags&TCPFin != 0:
- newState = TCPStateClosing
- case flags&TCPAck != 0:
- newState = TCPStateFinWait2
- }
- }
+// nextState returns the target TCP state for the given current state and
+// packet, or 0 if the packet does not trigger a transition.
+func nextState(currentState TCPState, connDir, packetDir nftypes.Direction, flags uint8) TCPState {
+ fn, ok := stateTable[currentState]
+ if !ok {
+ return 0
+ }
+ return fn(flags, connDir, packetDir == connDir)
+}
- case TCPStateFinWait2:
- if flags&TCPFin != 0 {
- newState = TCPStateTimeWait
+func transNew(flags uint8, connDir nftypes.Direction, _ bool) TCPState {
+ if flags&TCPSyn != 0 && flags&TCPAck == 0 {
+ if connDir == nftypes.Egress {
+ return TCPStateSynSent
}
+ return TCPStateSynReceived
+ }
+ return 0
+}
- case TCPStateClosing:
- if flags&TCPAck != 0 {
- newState = TCPStateTimeWait
+func transSynSent(flags uint8, _ nftypes.Direction, same bool) TCPState {
+ if flags&TCPSyn != 0 && flags&TCPAck != 0 {
+ if same {
+ return TCPStateSynReceived // simultaneous open
}
+ return TCPStateEstablished
+ }
+ return 0
+}
- case TCPStateCloseWait:
- if flags&TCPFin != 0 {
- newState = TCPStateLastAck
- }
+func transSynReceived(flags uint8, _ nftypes.Direction, same bool) TCPState {
+ if flags&TCPAck != 0 && flags&TCPSyn == 0 && same {
+ return TCPStateEstablished
+ }
+ return 0
+}
- case TCPStateLastAck:
- if flags&TCPAck != 0 {
- newState = TCPStateClosed
- }
+func transEstablished(flags uint8, _ nftypes.Direction, same bool) TCPState {
+ if flags&TCPFin == 0 {
+ return 0
+ }
+ if same {
+ return TCPStateFinWait1
+ }
+ return TCPStateCloseWait
+}
+
+// transFinWait1 handles the active-close peer response. A FIN carrying our
+// ACK piggybacked goes straight to TIME-WAIT (RFC 9293 ยง3.10.7.4, FIN-WAIT-1:
+// "if our FIN has been ACKed... enter the TIME-WAIT state"); a lone FIN moves
+// to CLOSING; a pure ACK of our FIN moves to FIN-WAIT-2.
+func transFinWait1(flags uint8, _ nftypes.Direction, same bool) TCPState {
+ if same {
+ return 0
+ }
+ if flags&TCPFin != 0 && flags&TCPAck != 0 {
+ return TCPStateTimeWait
+ }
+ switch {
+ case flags&TCPFin != 0:
+ return TCPStateClosing
+ case flags&TCPAck != 0:
+ return TCPStateFinWait2
+ }
+ return 0
+}
+
+// transFinWait2 ignores own-side FIN retransmits; only the peer's FIN advances.
+func transFinWait2(flags uint8, _ nftypes.Direction, same bool) TCPState {
+ if flags&TCPFin != 0 && !same {
+ return TCPStateTimeWait
+ }
+ return 0
+}
+
+// transClosing completes a simultaneous close on the peer's ACK.
+func transClosing(flags uint8, _ nftypes.Direction, same bool) TCPState {
+ if flags&TCPAck != 0 && !same {
+ return TCPStateTimeWait
+ }
+ return 0
+}
+
+// transCloseWait only advances to LastAck when WE send FIN, ignoring peer retransmits.
+func transCloseWait(flags uint8, _ nftypes.Direction, same bool) TCPState {
+ if flags&TCPFin != 0 && same {
+ return TCPStateLastAck
+ }
+ return 0
+}
+
+// transLastAck closes the flow only on the peer's ACK (not our own ACK retransmits).
+func transLastAck(flags uint8, _ nftypes.Direction, same bool) TCPState {
+ if flags&TCPAck != 0 && !same {
+ return TCPStateClosed
+ }
+ return 0
+}
+
+// onTransition handles logging and flow-event emission after a successful
+// state transition. TimeWait and Closed are terminal for flow accounting.
+func (t *TCPTracker) onTransition(key ConnKey, conn *TCPConnTrack, from, to TCPState, packetDir nftypes.Direction) {
+ traceOn := t.logger.Enabled(nblog.LevelTrace)
+ if traceOn {
+ t.logger.Trace4("TCP connection %s transitioned from %s to %s (dir: %s)", key, from, to, packetDir)
}
- if newState != 0 && conn.CompareAndSwapState(currentState, newState) {
- t.logger.Trace4("TCP connection %s transitioned from %s to %s (dir: %s)", key, currentState, newState, packetDir)
-
- switch newState {
- case TCPStateTimeWait:
+ switch to {
+ case TCPStateTimeWait:
+ if traceOn {
t.logger.Trace5("TCP connection %s completed [in: %d Pkts/%d B, out: %d Pkts/%d B]",
key, conn.PacketsRx.Load(), conn.BytesRx.Load(), conn.PacketsTx.Load(), conn.BytesTx.Load())
- t.sendEvent(nftypes.TypeEnd, conn, nil)
-
- case TCPStateClosed:
- conn.SetTombstone()
+ }
+ t.sendEvent(nftypes.TypeEnd, conn, nil)
+ case TCPStateClosed:
+ conn.SetTombstone()
+ if traceOn {
t.logger.Trace5("TCP connection %s closed gracefully [in: %d Pkts/%d, B out: %d Pkts/%d B]",
key, conn.PacketsRx.Load(), conn.BytesRx.Load(), conn.PacketsTx.Load(), conn.BytesTx.Load())
- t.sendEvent(nftypes.TypeEnd, conn, nil)
}
+ t.sendEvent(nftypes.TypeEnd, conn, nil)
}
}
-// isValidStateForFlags checks if the TCP flags are valid for the current connection state
+// isValidStateForFlags checks if the TCP flags are valid for the current
+// connection state. Caller must have already verified the flag combination is
+// legal via isValidFlagCombination.
func (t *TCPTracker) isValidStateForFlags(state TCPState, flags uint8) bool {
- if !isValidFlagCombination(flags) {
- return false
- }
if flags&TCPRst != 0 {
if state == TCPStateSynSent {
return flags&TCPAck != 0
@@ -449,15 +628,24 @@ func (t *TCPTracker) cleanup() {
timeout = t.waitTimeout
case TCPStateEstablished:
timeout = t.timeout
+ case TCPStateFinWait1, TCPStateFinWait2, TCPStateClosing:
+ timeout = t.finWaitTimeout
+ case TCPStateCloseWait:
+ timeout = t.closeWaitTimeout
+ case TCPStateLastAck:
+ timeout = t.lastAckTimeout
default:
+ // SynSent / SynReceived / New
timeout = TCPHandshakeTimeout
}
if conn.timeoutExceeded(timeout) {
delete(t.connections, key)
- t.logger.Trace6("Cleaned up timed-out TCP connection %s (%s) [in: %d Pkts/%d, B out: %d Pkts/%d B]",
- key, conn.GetState(), conn.PacketsRx.Load(), conn.BytesRx.Load(), conn.PacketsTx.Load(), conn.BytesTx.Load())
+ if t.logger.Enabled(nblog.LevelTrace) {
+ t.logger.Trace6("Cleaned up timed-out TCP connection %s (%s) [in: %d Pkts/%d, B out: %d Pkts/%d B]",
+ key, conn.GetState(), conn.PacketsRx.Load(), conn.BytesRx.Load(), conn.PacketsTx.Load(), conn.BytesTx.Load())
+ }
// event already handled by state change
if currentState != TCPStateTimeWait {
diff --git a/client/firewall/uspfilter/conntrack/tcp_rst_bugs_test.go b/client/firewall/uspfilter/conntrack/tcp_rst_bugs_test.go
new file mode 100644
index 000000000..81d4f5710
--- /dev/null
+++ b/client/firewall/uspfilter/conntrack/tcp_rst_bugs_test.go
@@ -0,0 +1,100 @@
+package conntrack
+
+import (
+ "net/netip"
+ "testing"
+
+ "github.com/stretchr/testify/require"
+)
+
+// RST hygiene tests: the tracker currently closes the flow on any RST that
+// matches the 4-tuple, regardless of direction or state. These tests cover
+// the minimum checks we want (no SEQ tracking).
+
+func TestTCPRstInSynSentWrongDirection(t *testing.T) {
+ tracker := NewTCPTracker(DefaultTCPTimeout, logger, flowLogger)
+ defer tracker.Close()
+
+ srcIP := netip.MustParseAddr("100.64.0.1")
+ dstIP := netip.MustParseAddr("100.64.0.2")
+ srcPort := uint16(12345)
+ dstPort := uint16(80)
+ key := ConnKey{SrcIP: srcIP, DstIP: dstIP, SrcPort: srcPort, DstPort: dstPort}
+
+ tracker.TrackOutbound(srcIP, dstIP, srcPort, dstPort, TCPSyn, 0)
+ conn := tracker.connections[key]
+ require.Equal(t, TCPStateSynSent, conn.GetState())
+
+ // A RST arriving in the same direction as the SYN (i.e. TrackOutbound)
+ // cannot be a legitimate response. It must not close the connection.
+ tracker.TrackOutbound(srcIP, dstIP, srcPort, dstPort, TCPRst|TCPAck, 0)
+ require.Equal(t, TCPStateSynSent, conn.GetState(),
+ "RST in same direction as SYN must not close connection")
+ require.False(t, conn.IsTombstone())
+}
+
+func TestTCPRstInTimeWaitIgnored(t *testing.T) {
+ tracker := NewTCPTracker(DefaultTCPTimeout, logger, flowLogger)
+ defer tracker.Close()
+
+ srcIP := netip.MustParseAddr("100.64.0.1")
+ dstIP := netip.MustParseAddr("100.64.0.2")
+ srcPort := uint16(12345)
+ dstPort := uint16(80)
+ key := ConnKey{SrcIP: srcIP, DstIP: dstIP, SrcPort: srcPort, DstPort: dstPort}
+
+ // Drive to TIME-WAIT via active close.
+ establishConnection(t, tracker, srcIP, dstIP, srcPort, dstPort)
+ tracker.TrackOutbound(srcIP, dstIP, srcPort, dstPort, TCPFin|TCPAck, 0)
+ require.True(t, tracker.IsValidInbound(dstIP, srcIP, dstPort, srcPort, TCPAck, 0))
+ require.True(t, tracker.IsValidInbound(dstIP, srcIP, dstPort, srcPort, TCPFin|TCPAck, 0))
+ tracker.TrackOutbound(srcIP, dstIP, srcPort, dstPort, TCPAck, 0)
+
+ conn := tracker.connections[key]
+ require.Equal(t, TCPStateTimeWait, conn.GetState())
+ require.False(t, conn.IsTombstone(), "TIME-WAIT must not be tombstoned")
+
+ // Late RST during TIME-WAIT must not tombstone the entry (TIME-WAIT
+ // exists to absorb late segments).
+ tracker.IsValidInbound(dstIP, srcIP, dstPort, srcPort, TCPRst, 0)
+ require.Equal(t, TCPStateTimeWait, conn.GetState(),
+ "RST in TIME-WAIT must not transition state")
+ require.False(t, conn.IsTombstone(),
+ "RST in TIME-WAIT must not tombstone the entry")
+}
+
+func TestTCPIllegalFlagCombos(t *testing.T) {
+ tracker := NewTCPTracker(DefaultTCPTimeout, logger, flowLogger)
+ defer tracker.Close()
+
+ srcIP := netip.MustParseAddr("100.64.0.1")
+ dstIP := netip.MustParseAddr("100.64.0.2")
+ srcPort := uint16(12345)
+ dstPort := uint16(80)
+ key := ConnKey{SrcIP: srcIP, DstIP: dstIP, SrcPort: srcPort, DstPort: dstPort}
+
+ establishConnection(t, tracker, srcIP, dstIP, srcPort, dstPort)
+ conn := tracker.connections[key]
+
+ // Illegal combos must be rejected and must not change state.
+ combos := []struct {
+ name string
+ flags uint8
+ }{
+ {"SYN+RST", TCPSyn | TCPRst},
+ {"FIN+RST", TCPFin | TCPRst},
+ {"SYN+FIN", TCPSyn | TCPFin},
+ {"SYN+FIN+RST", TCPSyn | TCPFin | TCPRst},
+ }
+
+ for _, c := range combos {
+ t.Run(c.name, func(t *testing.T) {
+ before := conn.GetState()
+ valid := tracker.IsValidInbound(dstIP, srcIP, dstPort, srcPort, c.flags, 0)
+ require.False(t, valid, "illegal flag combo must be rejected: %s", c.name)
+ require.Equal(t, before, conn.GetState(),
+ "illegal flag combo must not change state")
+ require.False(t, conn.IsTombstone())
+ })
+ }
+}
diff --git a/client/firewall/uspfilter/conntrack/tcp_state_bugs_test.go b/client/firewall/uspfilter/conntrack/tcp_state_bugs_test.go
new file mode 100644
index 000000000..32112cd58
--- /dev/null
+++ b/client/firewall/uspfilter/conntrack/tcp_state_bugs_test.go
@@ -0,0 +1,235 @@
+package conntrack
+
+import (
+ "net/netip"
+ "testing"
+ "time"
+
+ "github.com/stretchr/testify/require"
+)
+
+// These tests exercise cases where the TCP state machine currently advances
+// on retransmitted or wrong-direction segments and tears the flow down
+// prematurely. They are expected to fail until the direction checks are added.
+
+func TestTCPCloseWaitRetransmittedPeerFIN(t *testing.T) {
+ tracker := NewTCPTracker(DefaultTCPTimeout, logger, flowLogger)
+ defer tracker.Close()
+
+ srcIP := netip.MustParseAddr("100.64.0.1")
+ dstIP := netip.MustParseAddr("100.64.0.2")
+ srcPort := uint16(12345)
+ dstPort := uint16(80)
+ key := ConnKey{SrcIP: srcIP, DstIP: dstIP, SrcPort: srcPort, DstPort: dstPort}
+
+ establishConnection(t, tracker, srcIP, dstIP, srcPort, dstPort)
+
+ // Peer sends FIN -> CloseWait (our app has not yet closed).
+ valid := tracker.IsValidInbound(dstIP, srcIP, dstPort, srcPort, TCPFin|TCPAck, 0)
+ require.True(t, valid)
+ conn := tracker.connections[key]
+ require.Equal(t, TCPStateCloseWait, conn.GetState())
+
+ // Peer retransmits their FIN (ACK may have been delayed). We have NOT
+ // sent our FIN yet, so state must remain CloseWait.
+ valid = tracker.IsValidInbound(dstIP, srcIP, dstPort, srcPort, TCPFin|TCPAck, 0)
+ require.True(t, valid, "retransmitted peer FIN must still be accepted")
+ require.Equal(t, TCPStateCloseWait, conn.GetState(),
+ "retransmitted peer FIN must not advance CloseWait to LastAck")
+
+ // Our app finally closes -> LastAck.
+ tracker.TrackOutbound(srcIP, dstIP, srcPort, dstPort, TCPFin|TCPAck, 0)
+ require.Equal(t, TCPStateLastAck, conn.GetState())
+
+ // Peer ACK closes.
+ valid = tracker.IsValidInbound(dstIP, srcIP, dstPort, srcPort, TCPAck, 0)
+ require.True(t, valid)
+ require.Equal(t, TCPStateClosed, conn.GetState())
+}
+
+func TestTCPFinWait2RetransmittedOwnFIN(t *testing.T) {
+ tracker := NewTCPTracker(DefaultTCPTimeout, logger, flowLogger)
+ defer tracker.Close()
+
+ srcIP := netip.MustParseAddr("100.64.0.1")
+ dstIP := netip.MustParseAddr("100.64.0.2")
+ srcPort := uint16(12345)
+ dstPort := uint16(80)
+ key := ConnKey{SrcIP: srcIP, DstIP: dstIP, SrcPort: srcPort, DstPort: dstPort}
+
+ establishConnection(t, tracker, srcIP, dstIP, srcPort, dstPort)
+
+ // We initiate close.
+ tracker.TrackOutbound(srcIP, dstIP, srcPort, dstPort, TCPFin|TCPAck, 0)
+ valid := tracker.IsValidInbound(dstIP, srcIP, dstPort, srcPort, TCPAck, 0)
+ require.True(t, valid)
+ conn := tracker.connections[key]
+ require.Equal(t, TCPStateFinWait2, conn.GetState())
+
+ // Stray retransmit of our own FIN (same direction as originator) must
+ // NOT advance FinWait2 to TimeWait; only the peer's FIN should.
+ tracker.TrackOutbound(srcIP, dstIP, srcPort, dstPort, TCPFin|TCPAck, 0)
+ require.Equal(t, TCPStateFinWait2, conn.GetState(),
+ "own FIN retransmit must not advance FinWait2 to TimeWait")
+
+ // Peer FIN -> TimeWait.
+ valid = tracker.IsValidInbound(dstIP, srcIP, dstPort, srcPort, TCPFin|TCPAck, 0)
+ require.True(t, valid)
+ require.Equal(t, TCPStateTimeWait, conn.GetState())
+}
+
+func TestTCPLastAckDirectionCheck(t *testing.T) {
+ tracker := NewTCPTracker(DefaultTCPTimeout, logger, flowLogger)
+ defer tracker.Close()
+
+ srcIP := netip.MustParseAddr("100.64.0.1")
+ dstIP := netip.MustParseAddr("100.64.0.2")
+ srcPort := uint16(12345)
+ dstPort := uint16(80)
+ key := ConnKey{SrcIP: srcIP, DstIP: dstIP, SrcPort: srcPort, DstPort: dstPort}
+
+ establishConnection(t, tracker, srcIP, dstIP, srcPort, dstPort)
+
+ // Drive to LastAck: peer FIN -> CloseWait, our FIN -> LastAck.
+ require.True(t, tracker.IsValidInbound(dstIP, srcIP, dstPort, srcPort, TCPFin|TCPAck, 0))
+ tracker.TrackOutbound(srcIP, dstIP, srcPort, dstPort, TCPFin|TCPAck, 0)
+ conn := tracker.connections[key]
+ require.Equal(t, TCPStateLastAck, conn.GetState())
+
+ // Our own ACK retransmit (same direction as originator) must NOT close.
+ tracker.TrackOutbound(srcIP, dstIP, srcPort, dstPort, TCPAck, 0)
+ require.Equal(t, TCPStateLastAck, conn.GetState(),
+ "own ACK retransmit in LastAck must not transition to Closed")
+
+ // Peer's ACK -> Closed.
+ require.True(t, tracker.IsValidInbound(dstIP, srcIP, dstPort, srcPort, TCPAck, 0))
+ require.Equal(t, TCPStateClosed, conn.GetState())
+}
+
+func TestTCPFinWait1OwnAckDoesNotAdvance(t *testing.T) {
+ tracker := NewTCPTracker(DefaultTCPTimeout, logger, flowLogger)
+ defer tracker.Close()
+
+ srcIP := netip.MustParseAddr("100.64.0.1")
+ dstIP := netip.MustParseAddr("100.64.0.2")
+ srcPort := uint16(12345)
+ dstPort := uint16(80)
+ key := ConnKey{SrcIP: srcIP, DstIP: dstIP, SrcPort: srcPort, DstPort: dstPort}
+
+ establishConnection(t, tracker, srcIP, dstIP, srcPort, dstPort)
+
+ tracker.TrackOutbound(srcIP, dstIP, srcPort, dstPort, TCPFin|TCPAck, 0)
+ conn := tracker.connections[key]
+ require.Equal(t, TCPStateFinWait1, conn.GetState())
+
+ // Our own ACK retransmit (same direction as originator) must not advance.
+ tracker.TrackOutbound(srcIP, dstIP, srcPort, dstPort, TCPAck, 0)
+ require.Equal(t, TCPStateFinWait1, conn.GetState(),
+ "own ACK in FinWait1 must not advance to FinWait2")
+}
+
+func TestTCPPerStateTeardownTimeouts(t *testing.T) {
+ // Verify cleanup reaps entries in each teardown state at the configured
+ // per-state timeout, not at the single handshake timeout.
+ t.Setenv(EnvTCPFinWaitTimeout, "50ms")
+ t.Setenv(EnvTCPCloseWaitTimeout, "80ms")
+ t.Setenv(EnvTCPLastAckTimeout, "30ms")
+
+ dstIP := netip.MustParseAddr("100.64.0.2")
+ dstPort := uint16(80)
+
+ // Drives a connection to the target state, forces its lastSeen well
+ // beyond the configured timeout, runs cleanup, and asserts reaping.
+ cases := []struct {
+ name string
+ // drive takes a fresh tracker and returns the conn key after
+ // transitioning the flow into the intended teardown state.
+ drive func(t *testing.T, tr *TCPTracker, srcIP netip.Addr, srcPort uint16) (ConnKey, TCPState)
+ }{
+ {
+ name: "FinWait1",
+ drive: func(t *testing.T, tr *TCPTracker, srcIP netip.Addr, srcPort uint16) (ConnKey, TCPState) {
+ establishConnection(t, tr, srcIP, dstIP, srcPort, dstPort)
+ tr.TrackOutbound(srcIP, dstIP, srcPort, dstPort, TCPFin|TCPAck, 0) // โ FinWait1
+ return ConnKey{SrcIP: srcIP, DstIP: dstIP, SrcPort: srcPort, DstPort: dstPort}, TCPStateFinWait1
+ },
+ },
+ {
+ name: "FinWait2",
+ drive: func(t *testing.T, tr *TCPTracker, srcIP netip.Addr, srcPort uint16) (ConnKey, TCPState) {
+ establishConnection(t, tr, srcIP, dstIP, srcPort, dstPort)
+ tr.TrackOutbound(srcIP, dstIP, srcPort, dstPort, TCPFin|TCPAck, 0) // FinWait1
+ require.True(t, tr.IsValidInbound(dstIP, srcIP, dstPort, srcPort, TCPAck, 0)) // โ FinWait2
+ return ConnKey{SrcIP: srcIP, DstIP: dstIP, SrcPort: srcPort, DstPort: dstPort}, TCPStateFinWait2
+ },
+ },
+ {
+ name: "CloseWait",
+ drive: func(t *testing.T, tr *TCPTracker, srcIP netip.Addr, srcPort uint16) (ConnKey, TCPState) {
+ establishConnection(t, tr, srcIP, dstIP, srcPort, dstPort)
+ require.True(t, tr.IsValidInbound(dstIP, srcIP, dstPort, srcPort, TCPFin|TCPAck, 0)) // โ CloseWait
+ return ConnKey{SrcIP: srcIP, DstIP: dstIP, SrcPort: srcPort, DstPort: dstPort}, TCPStateCloseWait
+ },
+ },
+ {
+ name: "LastAck",
+ drive: func(t *testing.T, tr *TCPTracker, srcIP netip.Addr, srcPort uint16) (ConnKey, TCPState) {
+ establishConnection(t, tr, srcIP, dstIP, srcPort, dstPort)
+ require.True(t, tr.IsValidInbound(dstIP, srcIP, dstPort, srcPort, TCPFin|TCPAck, 0)) // CloseWait
+ tr.TrackOutbound(srcIP, dstIP, srcPort, dstPort, TCPFin|TCPAck, 0) // โ LastAck
+ return ConnKey{SrcIP: srcIP, DstIP: dstIP, SrcPort: srcPort, DstPort: dstPort}, TCPStateLastAck
+ },
+ },
+ }
+
+ // Use a unique source port per subtest so nothing aliases.
+ port := uint16(12345)
+ for _, c := range cases {
+ t.Run(c.name, func(t *testing.T) {
+ tracker := NewTCPTracker(DefaultTCPTimeout, logger, flowLogger)
+ defer tracker.Close()
+
+ require.Equal(t, 50*time.Millisecond, tracker.finWaitTimeout)
+ require.Equal(t, 80*time.Millisecond, tracker.closeWaitTimeout)
+ require.Equal(t, 30*time.Millisecond, tracker.lastAckTimeout)
+
+ srcIP := netip.MustParseAddr("100.64.0.1")
+ port++
+ key, wantState := c.drive(t, tracker, srcIP, port)
+ conn := tracker.connections[key]
+ require.NotNil(t, conn)
+ require.Equal(t, wantState, conn.GetState())
+
+ // Age the entry past the largest per-state timeout.
+ conn.lastSeen.Store(time.Now().Add(-500 * time.Millisecond).UnixNano())
+ tracker.cleanup()
+ _, exists := tracker.connections[key]
+ require.False(t, exists, "%s entry should be reaped", c.name)
+ })
+ }
+}
+
+func TestTCPEstablishedPSHACKInFinStates(t *testing.T) {
+ // Verifies FIN|PSH|ACK and bare ACK keepalives are not dropped in FIN
+ // teardown states, which some stacks emit during close.
+ tracker := NewTCPTracker(DefaultTCPTimeout, logger, flowLogger)
+ defer tracker.Close()
+
+ srcIP := netip.MustParseAddr("100.64.0.1")
+ dstIP := netip.MustParseAddr("100.64.0.2")
+ srcPort := uint16(12345)
+ dstPort := uint16(80)
+
+ establishConnection(t, tracker, srcIP, dstIP, srcPort, dstPort)
+
+ // Peer FIN -> CloseWait.
+ require.True(t, tracker.IsValidInbound(dstIP, srcIP, dstPort, srcPort, TCPFin|TCPAck, 0))
+
+ // Peer pushes trailing data + FIN|PSH|ACK (legal).
+ require.True(t, tracker.IsValidInbound(dstIP, srcIP, dstPort, srcPort, TCPFin|TCPPush|TCPAck, 100),
+ "FIN|PSH|ACK in CloseWait must be accepted")
+
+ // Bare ACK keepalive from peer in CloseWait must be accepted.
+ require.True(t, tracker.IsValidInbound(dstIP, srcIP, dstPort, srcPort, TCPAck, 0),
+ "bare ACK in CloseWait must be accepted")
+}
diff --git a/client/firewall/uspfilter/conntrack/udp.go b/client/firewall/uspfilter/conntrack/udp.go
index a3b6a418b..335c5832a 100644
--- a/client/firewall/uspfilter/conntrack/udp.go
+++ b/client/firewall/uspfilter/conntrack/udp.go
@@ -17,6 +17,9 @@ const (
DefaultUDPTimeout = 30 * time.Second
// UDPCleanupInterval is how often we check for stale connections
UDPCleanupInterval = 15 * time.Second
+
+ // EnvUDPMaxEntries caps the UDP conntrack table size.
+ EnvUDPMaxEntries = "NB_CONNTRACK_UDP_MAX"
)
// UDPConnTrack represents a UDP connection state
@@ -34,6 +37,7 @@ type UDPTracker struct {
cleanupTicker *time.Ticker
tickerCancel context.CancelFunc
mutex sync.RWMutex
+ maxEntries int
flowLogger nftypes.FlowLogger
}
@@ -51,6 +55,7 @@ func NewUDPTracker(timeout time.Duration, logger *nblog.Logger, flowLogger nftyp
timeout: timeout,
cleanupTicker: time.NewTicker(UDPCleanupInterval),
tickerCancel: cancel,
+ maxEntries: envInt(logger, EnvUDPMaxEntries, DefaultMaxUDPEntries),
flowLogger: flowLogger,
}
@@ -117,13 +122,18 @@ func (t *UDPTracker) track(srcIP netip.Addr, dstIP netip.Addr, srcPort uint16, d
conn.UpdateCounters(direction, size)
t.mutex.Lock()
+ if t.maxEntries > 0 && len(t.connections) >= t.maxEntries {
+ t.evictOneLocked()
+ }
t.connections[key] = conn
t.mutex.Unlock()
- if origPort != 0 {
- t.logger.Trace4("New %s UDP connection: %s (port DNAT %d -> %d)", direction, key, origPort, dstPort)
- } else {
- t.logger.Trace2("New %s UDP connection: %s", direction, key)
+ if t.logger.Enabled(nblog.LevelTrace) {
+ if origPort != 0 {
+ t.logger.Trace4("New %s UDP connection: %s (port DNAT %d -> %d)", direction, key, origPort, dstPort)
+ } else {
+ t.logger.Trace2("New %s UDP connection: %s", direction, key)
+ }
}
t.sendEvent(nftypes.TypeStart, conn, ruleID)
}
@@ -151,6 +161,34 @@ func (t *UDPTracker) IsValidInbound(srcIP netip.Addr, dstIP netip.Addr, srcPort
return true
}
+// evictOneLocked removes one entry to make room. Caller must hold t.mutex.
+// Bounded sample: picks the oldest among up to evictSampleSize entries.
+func (t *UDPTracker) evictOneLocked() {
+ var candKey ConnKey
+ var candSeen int64
+ haveCand := false
+ sampled := 0
+
+ for k, c := range t.connections {
+ seen := c.lastSeen.Load()
+ if !haveCand || seen < candSeen {
+ candKey = k
+ candSeen = seen
+ haveCand = true
+ }
+ sampled++
+ if sampled >= evictSampleSize {
+ break
+ }
+ }
+ if haveCand {
+ if evicted := t.connections[candKey]; evicted != nil {
+ t.sendEvent(nftypes.TypeEnd, evicted, nil)
+ }
+ delete(t.connections, candKey)
+ }
+}
+
// cleanupRoutine periodically removes stale connections
func (t *UDPTracker) cleanupRoutine(ctx context.Context) {
defer t.cleanupTicker.Stop()
@@ -173,8 +211,10 @@ func (t *UDPTracker) cleanup() {
if conn.timeoutExceeded(t.timeout) {
delete(t.connections, key)
- t.logger.Trace5("Removed UDP connection %s (timeout) [in: %d Pkts/%d B, out: %d Pkts/%d B]",
- key, conn.PacketsRx.Load(), conn.BytesRx.Load(), conn.PacketsTx.Load(), conn.BytesTx.Load())
+ if t.logger.Enabled(nblog.LevelTrace) {
+ t.logger.Trace5("Removed UDP connection %s (timeout) [in: %d Pkts/%d B, out: %d Pkts/%d B]",
+ key, conn.PacketsRx.Load(), conn.BytesRx.Load(), conn.PacketsTx.Load(), conn.BytesTx.Load())
+ }
t.sendEvent(nftypes.TypeEnd, conn, nil)
}
}
diff --git a/client/firewall/uspfilter/filter.go b/client/firewall/uspfilter/filter.go
index 3787e63a8..91866dcab 100644
--- a/client/firewall/uspfilter/filter.go
+++ b/client/firewall/uspfilter/filter.go
@@ -18,9 +18,10 @@ import (
"github.com/google/gopacket"
"github.com/google/gopacket/layers"
"github.com/google/uuid"
+ "github.com/hashicorp/go-multierror"
log "github.com/sirupsen/logrus"
- "golang.org/x/exp/maps"
+ nberrors "github.com/netbirdio/netbird/client/errors"
firewall "github.com/netbirdio/netbird/client/firewall/manager"
"github.com/netbirdio/netbird/client/firewall/uspfilter/common"
"github.com/netbirdio/netbird/client/firewall/uspfilter/conntrack"
@@ -35,8 +36,10 @@ import (
const (
layerTypeAll = 255
- // ipTCPHeaderMinSize represents minimum IP (20) + TCP (20) header size for MSS calculation
- ipTCPHeaderMinSize = 40
+ // ipv4TCPHeaderMinSize represents minimum IPv4 (20) + TCP (20) header size for MSS calculation
+ ipv4TCPHeaderMinSize = 40
+ // ipv6TCPHeaderMinSize represents minimum IPv6 (40) + TCP (20) header size for MSS calculation
+ ipv6TCPHeaderMinSize = 60
)
// serviceKey represents a protocol/port combination for netstack service registry
@@ -123,7 +126,7 @@ type Manager struct {
logger *nblog.Logger
flowLogger nftypes.FlowLogger
- blockRule firewall.Rule
+ blockRules []firewall.Rule
// Internal 1:1 DNAT
dnatEnabled atomic.Bool
@@ -138,9 +141,10 @@ type Manager struct {
netstackServices map[serviceKey]struct{}
netstackServiceMutex sync.RWMutex
- mtu uint16
- mssClampValue uint16
- mssClampEnabled bool
+ mtu uint16
+ mssClampValueIPv4 uint16
+ mssClampValueIPv6 uint16
+ mssClampEnabled bool
// Only one hook per protocol is supported. Outbound direction only.
udpHookOut atomic.Pointer[common.PacketHook]
@@ -157,11 +161,28 @@ type decoder struct {
icmp4 layers.ICMPv4
icmp6 layers.ICMPv6
decoded []gopacket.LayerType
- parser *gopacket.DecodingLayerParser
+ parser4 *gopacket.DecodingLayerParser
+ parser6 *gopacket.DecodingLayerParser
dnatOrigPort uint16
}
+// decodePacket decodes packet data using the appropriate parser based on IP version.
+func (d *decoder) decodePacket(data []byte) error {
+ if len(data) == 0 {
+ return errors.New("empty packet")
+ }
+ version := data[0] >> 4
+ switch version {
+ case 4:
+ return d.parser4.DecodeLayers(data, &d.decoded)
+ case 6:
+ return d.parser6.DecodeLayers(data, &d.decoded)
+ default:
+ return fmt.Errorf("unknown IP version %d", version)
+ }
+}
+
// Create userspace firewall manager constructor
func Create(iface common.IFaceMapper, disableServerRoutes bool, flowLogger nftypes.FlowLogger, mtu uint16) (*Manager, error) {
return create(iface, nil, disableServerRoutes, flowLogger, mtu)
@@ -219,11 +240,17 @@ func create(iface common.IFaceMapper, nativeFirewall firewall.Manager, disableSe
d := &decoder{
decoded: []gopacket.LayerType{},
}
- d.parser = gopacket.NewDecodingLayerParser(
+ d.parser4 = gopacket.NewDecodingLayerParser(
layers.LayerTypeIPv4,
&d.eth, &d.ip4, &d.ip6, &d.icmp4, &d.icmp6, &d.tcp, &d.udp,
)
- d.parser.IgnoreUnsupported = true
+ d.parser4.IgnoreUnsupported = true
+
+ d.parser6 = gopacket.NewDecodingLayerParser(
+ layers.LayerTypeIPv6,
+ &d.eth, &d.ip4, &d.ip6, &d.icmp4, &d.icmp6, &d.tcp, &d.udp,
+ )
+ d.parser6.IgnoreUnsupported = true
return d
},
},
@@ -249,7 +276,12 @@ func create(iface common.IFaceMapper, nativeFirewall firewall.Manager, disableSe
if !disableMSSClamping {
m.mssClampEnabled = true
- m.mssClampValue = mtu - ipTCPHeaderMinSize
+ if mtu > ipv4TCPHeaderMinSize {
+ m.mssClampValueIPv4 = mtu - ipv4TCPHeaderMinSize
+ }
+ if mtu > ipv6TCPHeaderMinSize {
+ m.mssClampValueIPv6 = mtu - ipv6TCPHeaderMinSize
+ }
}
if err := m.localipmanager.UpdateLocalIPs(iface); err != nil {
return nil, fmt.Errorf("update local IPs: %w", err)
@@ -272,13 +304,25 @@ func create(iface common.IFaceMapper, nativeFirewall firewall.Manager, disableSe
return m, nil
}
-func (m *Manager) blockInvalidRouted(iface common.IFaceMapper) (firewall.Rule, error) {
+// blockInvalidRouted installs drop rules for traffic to the wg overlay that
+// arrives via the routing path. v4 and v6 are independent: a v6 install
+// failure leaves v4 protection in place (and vice versa) so the returned
+// slice always contains whatever was successfully installed, even on error.
+// Callers must persist the slice so DisableRouting can clean partial state.
+func (m *Manager) blockInvalidRouted(iface common.IFaceMapper) ([]firewall.Rule, error) {
wgPrefix := iface.Address().Network
log.Debugf("blocking invalid routed traffic for %s", wgPrefix)
- rule, err := m.addRouteFiltering(
+ sources := []netip.Prefix{netip.PrefixFrom(netip.IPv4Unspecified(), 0)}
+ v6Net := iface.Address().IPv6Net
+ if v6Net.IsValid() {
+ sources = append(sources, netip.PrefixFrom(netip.IPv6Unspecified(), 0))
+ }
+
+ var rules []firewall.Rule
+ v4Rule, err := m.addRouteFiltering(
nil,
- []netip.Prefix{netip.PrefixFrom(netip.IPv4Unspecified(), 0)},
+ sources,
firewall.Network{Prefix: wgPrefix},
firewall.ProtocolALL,
nil,
@@ -286,12 +330,30 @@ func (m *Manager) blockInvalidRouted(iface common.IFaceMapper) (firewall.Rule, e
firewall.ActionDrop,
)
if err != nil {
- return nil, fmt.Errorf("block wg nte : %w", err)
+ return rules, fmt.Errorf("block wg v4 net: %w", err)
+ }
+ rules = append(rules, v4Rule)
+
+ if v6Net.IsValid() {
+ log.Debugf("blocking invalid routed traffic for %s", v6Net)
+ v6Rule, err := m.addRouteFiltering(
+ nil,
+ sources,
+ firewall.Network{Prefix: v6Net},
+ firewall.ProtocolALL,
+ nil,
+ nil,
+ firewall.ActionDrop,
+ )
+ if err != nil {
+ return rules, fmt.Errorf("block wg v6 net: %w", err)
+ }
+ rules = append(rules, v6Rule)
}
// TODO: Block networks that we're a client of
- return rule, nil
+ return rules, nil
}
func (m *Manager) determineRouting() error {
@@ -521,7 +583,7 @@ func (m *Manager) addRouteFiltering(
mgmtId: id,
sources: sources,
dstSet: destination.Set,
- protoLayer: protoToLayer(proto, layers.LayerTypeIPv4),
+ protoLayer: protoToLayer(proto, ipLayerFromPrefix(destination.Prefix)),
srcPort: sPort,
dstPort: dPort,
action: action,
@@ -612,10 +674,10 @@ func (m *Manager) Flush() error { return nil }
// resetState clears all firewall rules and closes connection trackers.
// Must be called with m.mutex held.
func (m *Manager) resetState() {
- maps.Clear(m.outgoingRules)
- maps.Clear(m.incomingDenyRules)
- maps.Clear(m.incomingRules)
- maps.Clear(m.routeRulesMap)
+ clear(m.outgoingRules)
+ clear(m.incomingDenyRules)
+ clear(m.incomingRules)
+ clear(m.routeRulesMap)
m.routeRules = m.routeRules[:0]
m.udpHookOut.Store(nil)
m.tcpHookOut.Store(nil)
@@ -676,11 +738,7 @@ func (m *Manager) UpdateSet(set firewall.Set, prefixes []netip.Prefix) error {
}
destinations := matches[0].destinations
- for _, prefix := range prefixes {
- if prefix.Addr().Is4() {
- destinations = append(destinations, prefix)
- }
- }
+ destinations = append(destinations, prefixes...)
slices.SortFunc(destinations, func(a, b netip.Prefix) int {
cmp := a.Addr().Compare(b.Addr())
@@ -719,7 +777,7 @@ func (m *Manager) filterOutbound(packetData []byte, size int) bool {
d := m.decoders.Get().(*decoder)
defer m.decoders.Put(d)
- if err := d.parser.DecodeLayers(packetData, &d.decoded); err != nil {
+ if err := d.decodePacket(packetData); err != nil {
return false
}
@@ -729,7 +787,9 @@ func (m *Manager) filterOutbound(packetData []byte, size int) bool {
srcIP, dstIP := m.extractIPs(d)
if !srcIP.IsValid() {
- m.logger.Error1("Unknown network layer: %v", d.decoded[0])
+ if m.logger.Enabled(nblog.LevelError) {
+ m.logger.Error1("Unknown network layer: %v", d.decoded[0])
+ }
return false
}
@@ -803,12 +863,32 @@ func (m *Manager) clampTCPMSS(packetData []byte, d *decoder) bool {
return false
}
+ var mssClampValue uint16
+ var ipHeaderSize int
+ switch d.decoded[0] {
+ case layers.LayerTypeIPv4:
+ mssClampValue = m.mssClampValueIPv4
+ ipHeaderSize = int(d.ip4.IHL) * 4
+ if ipHeaderSize < 20 {
+ return false
+ }
+ case layers.LayerTypeIPv6:
+ mssClampValue = m.mssClampValueIPv6
+ ipHeaderSize = 40
+ default:
+ return false
+ }
+
+ if mssClampValue == 0 {
+ return false
+ }
+
mssOptionIndex := -1
var currentMSS uint16
for i, opt := range d.tcp.Options {
if opt.OptionType == layers.TCPOptionKindMSS && len(opt.OptionData) == 2 {
currentMSS = binary.BigEndian.Uint16(opt.OptionData)
- if currentMSS > m.mssClampValue {
+ if currentMSS > mssClampValue {
mssOptionIndex = i
break
}
@@ -819,20 +899,17 @@ func (m *Manager) clampTCPMSS(packetData []byte, d *decoder) bool {
return false
}
- ipHeaderSize := int(d.ip4.IHL) * 4
- if ipHeaderSize < 20 {
+ if !m.updateMSSOption(packetData, d, mssOptionIndex, mssClampValue, ipHeaderSize) {
return false
}
- if !m.updateMSSOption(packetData, d, mssOptionIndex, ipHeaderSize) {
- return false
+ if m.logger.Enabled(nblog.LevelTrace) {
+ m.logger.Trace2("Clamped TCP MSS from %d to %d", currentMSS, mssClampValue)
}
-
- m.logger.Trace2("Clamped TCP MSS from %d to %d", currentMSS, m.mssClampValue)
return true
}
-func (m *Manager) updateMSSOption(packetData []byte, d *decoder, mssOptionIndex, ipHeaderSize int) bool {
+func (m *Manager) updateMSSOption(packetData []byte, d *decoder, mssOptionIndex int, mssClampValue uint16, ipHeaderSize int) bool {
tcpHeaderStart := ipHeaderSize
tcpOptionsStart := tcpHeaderStart + 20
@@ -847,7 +924,7 @@ func (m *Manager) updateMSSOption(packetData []byte, d *decoder, mssOptionIndex,
}
mssValueOffset := optOffset + 2
- binary.BigEndian.PutUint16(packetData[mssValueOffset:mssValueOffset+2], m.mssClampValue)
+ binary.BigEndian.PutUint16(packetData[mssValueOffset:mssValueOffset+2], mssClampValue)
m.recalculateTCPChecksum(packetData, d, tcpHeaderStart)
return true
@@ -857,18 +934,32 @@ func (m *Manager) recalculateTCPChecksum(packetData []byte, d *decoder, tcpHeade
tcpLayer := packetData[tcpHeaderStart:]
tcpLength := len(packetData) - tcpHeaderStart
+ // Zero out existing checksum
tcpLayer[16] = 0
tcpLayer[17] = 0
+ // Build pseudo-header checksum based on IP version
var pseudoSum uint32
- pseudoSum += uint32(d.ip4.SrcIP[0])<<8 | uint32(d.ip4.SrcIP[1])
- pseudoSum += uint32(d.ip4.SrcIP[2])<<8 | uint32(d.ip4.SrcIP[3])
- pseudoSum += uint32(d.ip4.DstIP[0])<<8 | uint32(d.ip4.DstIP[1])
- pseudoSum += uint32(d.ip4.DstIP[2])<<8 | uint32(d.ip4.DstIP[3])
- pseudoSum += uint32(d.ip4.Protocol)
- pseudoSum += uint32(tcpLength)
+ switch d.decoded[0] {
+ case layers.LayerTypeIPv4:
+ pseudoSum += uint32(d.ip4.SrcIP[0])<<8 | uint32(d.ip4.SrcIP[1])
+ pseudoSum += uint32(d.ip4.SrcIP[2])<<8 | uint32(d.ip4.SrcIP[3])
+ pseudoSum += uint32(d.ip4.DstIP[0])<<8 | uint32(d.ip4.DstIP[1])
+ pseudoSum += uint32(d.ip4.DstIP[2])<<8 | uint32(d.ip4.DstIP[3])
+ pseudoSum += uint32(d.ip4.Protocol)
+ pseudoSum += uint32(tcpLength)
+ case layers.LayerTypeIPv6:
+ for i := 0; i < 16; i += 2 {
+ pseudoSum += uint32(d.ip6.SrcIP[i])<<8 | uint32(d.ip6.SrcIP[i+1])
+ }
+ for i := 0; i < 16; i += 2 {
+ pseudoSum += uint32(d.ip6.DstIP[i])<<8 | uint32(d.ip6.DstIP[i+1])
+ }
+ pseudoSum += uint32(tcpLength)
+ pseudoSum += uint32(layers.IPProtocolTCP)
+ }
- var sum = pseudoSum
+ sum := pseudoSum
for i := 0; i < tcpLength-1; i += 2 {
sum += uint32(tcpLayer[i])<<8 | uint32(tcpLayer[i+1])
}
@@ -906,6 +997,9 @@ func (m *Manager) trackOutbound(d *decoder, srcIP, dstIP netip.Addr, packetData
}
case layers.LayerTypeICMPv4:
m.icmpTracker.TrackOutbound(srcIP, dstIP, d.icmp4.Id, d.icmp4.TypeCode, d.icmp4.Payload, size)
+ case layers.LayerTypeICMPv6:
+ id, tc := icmpv6EchoFields(d)
+ m.icmpTracker.TrackOutbound(srcIP, dstIP, id, tc, d.icmp6.Payload, size)
}
}
@@ -919,6 +1013,9 @@ func (m *Manager) trackInbound(d *decoder, srcIP, dstIP netip.Addr, ruleID []byt
m.tcpTracker.TrackInbound(srcIP, dstIP, uint16(d.tcp.SrcPort), uint16(d.tcp.DstPort), flags, ruleID, size, d.dnatOrigPort)
case layers.LayerTypeICMPv4:
m.icmpTracker.TrackInbound(srcIP, dstIP, d.icmp4.Id, d.icmp4.TypeCode, ruleID, d.icmp4.Payload, size)
+ case layers.LayerTypeICMPv6:
+ id, tc := icmpv6EchoFields(d)
+ m.icmpTracker.TrackInbound(srcIP, dstIP, id, tc, ruleID, d.icmp6.Payload, size)
}
d.dnatOrigPort = 0
@@ -951,15 +1048,21 @@ func (m *Manager) filterInbound(packetData []byte, size int) bool {
// TODO: pass fragments of routed packets to forwarder
if fragment {
- m.logger.Trace4("packet is a fragment: src=%v dst=%v id=%v flags=%v",
- srcIP, dstIP, d.ip4.Id, d.ip4.Flags)
+ if m.logger.Enabled(nblog.LevelTrace) {
+ if d.decoded[0] == layers.LayerTypeIPv4 {
+ m.logger.Trace4("packet is a fragment: src=%v dst=%v id=%v flags=%v",
+ srcIP, dstIP, d.ip4.Id, d.ip4.Flags)
+ } else {
+ m.logger.Trace2("packet is an IPv6 fragment: src=%v dst=%v", srcIP, dstIP)
+ }
+ }
return false
}
// TODO: optimize port DNAT by caching matched rules in conntrack
if translated := m.translateInboundPortDNAT(packetData, d, srcIP, dstIP); translated {
// Re-decode after port DNAT translation to update port information
- if err := d.parser.DecodeLayers(packetData, &d.decoded); err != nil {
+ if err := d.decodePacket(packetData); err != nil {
m.logger.Error1("failed to re-decode packet after port DNAT: %v", err)
return true
}
@@ -968,7 +1071,7 @@ func (m *Manager) filterInbound(packetData []byte, size int) bool {
if translated := m.translateInboundReverse(packetData, d); translated {
// Re-decode after translation to get original addresses
- if err := d.parser.DecodeLayers(packetData, &d.decoded); err != nil {
+ if err := d.decodePacket(packetData); err != nil {
m.logger.Error1("failed to re-decode packet after reverse DNAT: %v", err)
return true
}
@@ -994,8 +1097,10 @@ func (m *Manager) handleLocalTraffic(d *decoder, srcIP, dstIP netip.Addr, packet
pnum := getProtocolFromPacket(d)
srcPort, dstPort := getPortsFromPacket(d)
- m.logger.Trace6("Dropping local packet (ACL denied): rule_id=%s proto=%v src=%s:%d dst=%s:%d",
- ruleID, pnum, srcIP, srcPort, dstIP, dstPort)
+ if m.logger.Enabled(nblog.LevelTrace) {
+ m.logger.Trace6("Dropping local packet (ACL denied): rule_id=%s proto=%v src=%s:%d dst=%s:%d",
+ ruleID, pnum, srcIP, srcPort, dstIP, dstPort)
+ }
m.flowLogger.StoreEvent(nftypes.EventFields{
FlowID: uuid.New(),
@@ -1045,8 +1150,10 @@ func (m *Manager) handleForwardedLocalTraffic(packetData []byte) bool {
func (m *Manager) handleRoutedTraffic(d *decoder, srcIP, dstIP netip.Addr, packetData []byte, size int) bool {
// Drop if routing is disabled
if !m.routingEnabled.Load() {
- m.logger.Trace2("Dropping routed packet (routing disabled): src=%s dst=%s",
- srcIP, dstIP)
+ if m.logger.Enabled(nblog.LevelTrace) {
+ m.logger.Trace2("Dropping routed packet (routing disabled): src=%s dst=%s",
+ srcIP, dstIP)
+ }
return true
}
@@ -1063,8 +1170,10 @@ func (m *Manager) handleRoutedTraffic(d *decoder, srcIP, dstIP netip.Addr, packe
if !pass {
proto := getProtocolFromPacket(d)
- m.logger.Trace6("Dropping routed packet (ACL denied): rule_id=%s proto=%v src=%s:%d dst=%s:%d",
- ruleID, proto, srcIP, srcPort, dstIP, dstPort)
+ if m.logger.Enabled(nblog.LevelTrace) {
+ m.logger.Trace6("Dropping routed packet (ACL denied): rule_id=%s proto=%v src=%s:%d dst=%s:%d",
+ ruleID, proto, srcIP, srcPort, dstIP, dstPort)
+ }
m.flowLogger.StoreEvent(nftypes.EventFields{
FlowID: uuid.New(),
@@ -1100,6 +1209,48 @@ func (m *Manager) handleRoutedTraffic(d *decoder, srcIP, dstIP netip.Addr, packe
return true
}
+// icmpv6EchoFields extracts the echo identifier from an ICMPv6 packet and maps
+// the ICMPv6 type code to an ICMPv4TypeCode so the ICMP conntrack can handle
+// both families uniformly. The echo ID is in the first two payload bytes.
+func icmpv6EchoFields(d *decoder) (id uint16, tc layers.ICMPv4TypeCode) {
+ if len(d.icmp6.Payload) >= 2 {
+ id = uint16(d.icmp6.Payload[0])<<8 | uint16(d.icmp6.Payload[1])
+ }
+ // Map ICMPv6 echo types to ICMPv4 equivalents for unified tracking.
+ switch d.icmp6.TypeCode.Type() {
+ case layers.ICMPv6TypeEchoRequest:
+ tc = layers.CreateICMPv4TypeCode(layers.ICMPv4TypeEchoRequest, 0)
+ case layers.ICMPv6TypeEchoReply:
+ tc = layers.CreateICMPv4TypeCode(layers.ICMPv4TypeEchoReply, 0)
+ default:
+ tc = layers.CreateICMPv4TypeCode(d.icmp6.TypeCode.Type(), d.icmp6.TypeCode.Code())
+ }
+ return id, tc
+}
+
+// protoLayerMatches checks if a packet's protocol layer matches a rule's expected
+// protocol layer. ICMPv4 and ICMPv6 are treated as equivalent when matching
+// ICMP rules since management sends a single ICMP rule for both families.
+func protoLayerMatches(ruleLayer, packetLayer gopacket.LayerType) bool {
+ if ruleLayer == packetLayer {
+ return true
+ }
+ if ruleLayer == layers.LayerTypeICMPv4 && packetLayer == layers.LayerTypeICMPv6 {
+ return true
+ }
+ if ruleLayer == layers.LayerTypeICMPv6 && packetLayer == layers.LayerTypeICMPv4 {
+ return true
+ }
+ return false
+}
+
+func ipLayerFromPrefix(p netip.Prefix) gopacket.LayerType {
+ if p.Addr().Is6() {
+ return layers.LayerTypeIPv6
+ }
+ return layers.LayerTypeIPv4
+}
+
func protoToLayer(proto firewall.Protocol, ipLayer gopacket.LayerType) gopacket.LayerType {
switch proto {
case firewall.ProtocolTCP:
@@ -1123,8 +1274,10 @@ func getProtocolFromPacket(d *decoder) nftypes.Protocol {
return nftypes.TCP
case layers.LayerTypeUDP:
return nftypes.UDP
- case layers.LayerTypeICMPv4, layers.LayerTypeICMPv6:
+ case layers.LayerTypeICMPv4:
return nftypes.ICMP
+ case layers.LayerTypeICMPv6:
+ return nftypes.ICMPv6
default:
return nftypes.ProtocolUnknown
}
@@ -1145,8 +1298,10 @@ func getPortsFromPacket(d *decoder) (srcPort, dstPort uint16) {
// It returns true, false if the packet is valid and not a fragment.
// It returns true, true if the packet is a fragment and valid.
func (m *Manager) isValidPacket(d *decoder, packetData []byte) (bool, bool) {
- if err := d.parser.DecodeLayers(packetData, &d.decoded); err != nil {
- m.logger.Trace1("couldn't decode packet, err: %s", err)
+ if err := d.decodePacket(packetData); err != nil {
+ if m.logger.Enabled(nblog.LevelTrace) {
+ m.logger.Trace1("couldn't decode packet, err: %s", err)
+ }
return false, false
}
@@ -1158,10 +1313,21 @@ func (m *Manager) isValidPacket(d *decoder, packetData []byte) (bool, bool) {
}
// Fragments are also valid
- if l == 1 && d.decoded[0] == layers.LayerTypeIPv4 {
- ip4 := d.ip4
- if ip4.Flags&layers.IPv4MoreFragments != 0 || ip4.FragOffset != 0 {
- return true, true
+ if l == 1 {
+ switch d.decoded[0] {
+ case layers.LayerTypeIPv4:
+ if d.ip4.Flags&layers.IPv4MoreFragments != 0 || d.ip4.FragOffset != 0 {
+ return true, true
+ }
+ case layers.LayerTypeIPv6:
+ // IPv6 uses Fragment extension header (NextHeader=44). If gopacket
+ // only decoded the IPv6 layer, the transport is in a fragment.
+ // TODO: handle non-Fragment extension headers (HopByHop, Routing,
+ // DestOpts) by walking the chain. gopacket's parser does not
+ // support them as DecodingLayers; today we drop such packets.
+ if d.ip6.NextHeader == layers.IPProtocolIPv6Fragment {
+ return true, true
+ }
}
}
@@ -1199,21 +1365,35 @@ func (m *Manager) isValidTrackedConnection(d *decoder, srcIP, dstIP netip.Addr,
size,
)
- // TODO: ICMPv6
+ case layers.LayerTypeICMPv6:
+ id, _ := icmpv6EchoFields(d)
+ return m.icmpTracker.IsValidInbound(
+ srcIP,
+ dstIP,
+ id,
+ d.icmp6.TypeCode.Type(),
+ size,
+ )
}
return false
}
-// isSpecialICMP returns true if the packet is a special ICMP packet that should be allowed
+// isSpecialICMP returns true if the packet is a special ICMP error packet that should be allowed.
func (m *Manager) isSpecialICMP(d *decoder) bool {
- if d.decoded[1] != layers.LayerTypeICMPv4 {
- return false
+ switch d.decoded[1] {
+ case layers.LayerTypeICMPv4:
+ icmpType := d.icmp4.TypeCode.Type()
+ return icmpType == layers.ICMPv4TypeDestinationUnreachable ||
+ icmpType == layers.ICMPv4TypeTimeExceeded
+ case layers.LayerTypeICMPv6:
+ icmpType := d.icmp6.TypeCode.Type()
+ return icmpType == layers.ICMPv6TypeDestinationUnreachable ||
+ icmpType == layers.ICMPv6TypePacketTooBig ||
+ icmpType == layers.ICMPv6TypeTimeExceeded ||
+ icmpType == layers.ICMPv6TypeParameterProblem
}
-
- icmpType := d.icmp4.TypeCode.Type()
- return icmpType == layers.ICMPv4TypeDestinationUnreachable ||
- icmpType == layers.ICMPv4TypeTimeExceeded
+ return false
}
func (m *Manager) peerACLsBlock(srcIP netip.Addr, d *decoder, packetData []byte) ([]byte, bool) {
@@ -1270,7 +1450,7 @@ func validateRule(ip netip.Addr, packetData []byte, rules map[string]PeerRule, d
return rule.mgmtId, rule.drop, true
}
- if payloadLayer != rule.protoLayer {
+ if !protoLayerMatches(rule.protoLayer, payloadLayer) {
continue
}
@@ -1305,8 +1485,7 @@ func (m *Manager) routeACLsPass(srcIP, dstIP netip.Addr, protoLayer gopacket.Lay
}
func (m *Manager) ruleMatches(rule *RouteRule, srcAddr, dstAddr netip.Addr, protoLayer gopacket.LayerType, srcPort, dstPort uint16) bool {
- // TODO: handle ipv6 vs ipv4 icmp rules
- if rule.protoLayer != layerTypeAll && rule.protoLayer != protoLayer {
+ if rule.protoLayer != layerTypeAll && !protoLayerMatches(rule.protoLayer, protoLayer) {
return false
}
@@ -1367,13 +1546,14 @@ func (m *Manager) EnableRouting() error {
return nil
}
- rule, err := m.blockInvalidRouted(m.wgIface)
+ rules, err := m.blockInvalidRouted(m.wgIface)
+ // Persist whatever was installed even on partial failure, so DisableRouting
+ // can clean it up later.
+ m.blockRules = rules
if err != nil {
return fmt.Errorf("block invalid routed: %w", err)
}
- m.blockRule = rule
-
return nil
}
@@ -1389,9 +1569,16 @@ func (m *Manager) DisableRouting() error {
m.routingEnabled.Store(false)
m.nativeRouter.Store(false)
- // don't stop forwarder if in use by netstack
+ var merr *multierror.Error
+ for _, rule := range m.blockRules {
+ if err := m.deleteRouteRule(rule); err != nil {
+ merr = multierror.Append(merr, fmt.Errorf("delete block rule: %w", err))
+ }
+ }
+ m.blockRules = nil
+
if m.netstack && m.localForwarding {
- return nil
+ return nberrors.FormatErrorOrNil(merr)
}
fwder.Stop()
@@ -1399,14 +1586,7 @@ func (m *Manager) DisableRouting() error {
log.Debug("forwarder stopped")
- if m.blockRule != nil {
- if err := m.deleteRouteRule(m.blockRule); err != nil {
- return fmt.Errorf("delete block rule: %w", err)
- }
- m.blockRule = nil
- }
-
- return nil
+ return nberrors.FormatErrorOrNil(merr)
}
// RegisterNetstackService registers a service as listening on the netstack for the given protocol and port
@@ -1460,7 +1640,8 @@ func (m *Manager) shouldForward(d *decoder, dstIP netip.Addr) bool {
}
// traffic to our other local interfaces (not NetBird IP) - always forward
- if dstIP != m.wgIface.Address().IP {
+ addr := m.wgIface.Address()
+ if dstIP != addr.IP && (!addr.IPv6.IsValid() || dstIP != addr.IPv6) {
return true
}
diff --git a/client/firewall/uspfilter/filter_bench_test.go b/client/firewall/uspfilter/filter_bench_test.go
index 10ff62ed3..4dccb0f65 100644
--- a/client/firewall/uspfilter/filter_bench_test.go
+++ b/client/firewall/uspfilter/filter_bench_test.go
@@ -1023,7 +1023,8 @@ func BenchmarkMSSClamping(b *testing.B) {
}()
manager.mssClampEnabled = true
- manager.mssClampValue = 1240
+ manager.mssClampValueIPv4 = 1240
+ manager.mssClampValueIPv6 = 1220
srcIP := net.ParseIP("100.64.0.2")
dstIP := net.ParseIP("8.8.8.8")
@@ -1088,7 +1089,8 @@ func BenchmarkMSSClampingOverhead(b *testing.B) {
manager.mssClampEnabled = sc.enabled
if sc.enabled {
- manager.mssClampValue = 1240
+ manager.mssClampValueIPv4 = 1240
+ manager.mssClampValueIPv6 = 1220
}
srcIP := net.ParseIP("100.64.0.2")
@@ -1141,7 +1143,8 @@ func BenchmarkMSSClampingMemory(b *testing.B) {
}()
manager.mssClampEnabled = true
- manager.mssClampValue = 1240
+ manager.mssClampValueIPv4 = 1240
+ manager.mssClampValueIPv6 = 1220
srcIP := net.ParseIP("100.64.0.2")
dstIP := net.ParseIP("8.8.8.8")
diff --git a/client/firewall/uspfilter/filter_filter_test.go b/client/firewall/uspfilter/filter_filter_test.go
index a8efbac1c..a64c83138 100644
--- a/client/firewall/uspfilter/filter_filter_test.go
+++ b/client/firewall/uspfilter/filter_filter_test.go
@@ -539,53 +539,236 @@ func TestPeerACLFiltering(t *testing.T) {
}
}
+func TestPeerACLFilteringIPv6(t *testing.T) {
+ localIP := netip.MustParseAddr("100.10.0.100")
+ localIPv6 := netip.MustParseAddr("fd00::100")
+ wgNet := netip.MustParsePrefix("100.10.0.0/16")
+ wgNetV6 := netip.MustParsePrefix("fd00::/64")
+
+ ifaceMock := &IFaceMock{
+ SetFilterFunc: func(device.PacketFilter) error { return nil },
+ AddressFunc: func() wgaddr.Address {
+ return wgaddr.Address{
+ IP: localIP,
+ Network: wgNet,
+ IPv6: localIPv6,
+ IPv6Net: wgNetV6,
+ }
+ },
+ }
+
+ manager, err := Create(ifaceMock, false, flowLogger, iface.DefaultMTU)
+ require.NoError(t, err)
+ t.Cleanup(func() { require.NoError(t, manager.Close(nil)) })
+
+ err = manager.UpdateLocalIPs()
+ require.NoError(t, err)
+
+ testCases := []struct {
+ name string
+ srcIP string
+ dstIP string
+ proto fw.Protocol
+ srcPort uint16
+ dstPort uint16
+ ruleIP string
+ ruleProto fw.Protocol
+ ruleDstPort *fw.Port
+ ruleAction fw.Action
+ shouldBeBlocked bool
+ }{
+ {
+ name: "IPv6: allow TCP from peer",
+ srcIP: "fd00::1",
+ dstIP: "fd00::100",
+ proto: fw.ProtocolTCP,
+ srcPort: 12345,
+ dstPort: 443,
+ ruleIP: "fd00::1",
+ ruleProto: fw.ProtocolTCP,
+ ruleDstPort: &fw.Port{Values: []uint16{443}},
+ ruleAction: fw.ActionAccept,
+ shouldBeBlocked: false,
+ },
+ {
+ name: "IPv6: allow UDP from peer",
+ srcIP: "fd00::1",
+ dstIP: "fd00::100",
+ proto: fw.ProtocolUDP,
+ srcPort: 12345,
+ dstPort: 53,
+ ruleIP: "fd00::1",
+ ruleProto: fw.ProtocolUDP,
+ ruleDstPort: &fw.Port{Values: []uint16{53}},
+ ruleAction: fw.ActionAccept,
+ shouldBeBlocked: false,
+ },
+ {
+ name: "IPv6: allow ICMPv6 from peer",
+ srcIP: "fd00::1",
+ dstIP: "fd00::100",
+ proto: fw.ProtocolICMP,
+ ruleIP: "fd00::1",
+ ruleProto: fw.ProtocolICMP,
+ ruleAction: fw.ActionAccept,
+ shouldBeBlocked: false,
+ },
+ {
+ name: "IPv6: block TCP without rule",
+ srcIP: "fd00::2",
+ dstIP: "fd00::100",
+ proto: fw.ProtocolTCP,
+ srcPort: 12345,
+ dstPort: 443,
+ ruleIP: "fd00::1",
+ ruleProto: fw.ProtocolTCP,
+ ruleDstPort: &fw.Port{Values: []uint16{443}},
+ ruleAction: fw.ActionAccept,
+ shouldBeBlocked: true,
+ },
+ {
+ name: "IPv6: drop rule",
+ srcIP: "fd00::1",
+ dstIP: "fd00::100",
+ proto: fw.ProtocolTCP,
+ srcPort: 12345,
+ dstPort: 22,
+ ruleIP: "fd00::1",
+ ruleProto: fw.ProtocolTCP,
+ ruleDstPort: &fw.Port{Values: []uint16{22}},
+ ruleAction: fw.ActionDrop,
+ shouldBeBlocked: true,
+ },
+ {
+ name: "IPv6: allow all protocols",
+ srcIP: "fd00::1",
+ dstIP: "fd00::100",
+ proto: fw.ProtocolUDP,
+ srcPort: 12345,
+ dstPort: 9999,
+ ruleIP: "fd00::1",
+ ruleProto: fw.ProtocolALL,
+ ruleAction: fw.ActionAccept,
+ shouldBeBlocked: false,
+ },
+ {
+ name: "IPv6: v4 wildcard ICMP rule matches ICMPv6 via protoLayerMatches",
+ srcIP: "fd00::1",
+ dstIP: "fd00::100",
+ proto: fw.ProtocolICMP,
+ ruleIP: "0.0.0.0",
+ ruleProto: fw.ProtocolICMP,
+ ruleAction: fw.ActionAccept,
+ shouldBeBlocked: false,
+ },
+ }
+
+ t.Run("IPv6 implicit DROP (no rules)", func(t *testing.T) {
+ packet := createTestPacket(t, "fd00::1", "fd00::100", fw.ProtocolTCP, 12345, 443)
+ isDropped := manager.FilterInbound(packet, 0)
+ require.True(t, isDropped, "IPv6 packet should be dropped when no rules exist")
+ })
+
+ for _, tc := range testCases {
+ t.Run(tc.name, func(t *testing.T) {
+ if tc.ruleAction == fw.ActionDrop {
+ rules, err := manager.AddPeerFiltering(nil, net.ParseIP(tc.ruleIP), fw.ProtocolALL, nil, nil, fw.ActionAccept, "")
+ require.NoError(t, err)
+ t.Cleanup(func() {
+ for _, rule := range rules {
+ require.NoError(t, manager.DeletePeerRule(rule))
+ }
+ })
+ }
+
+ rules, err := manager.AddPeerFiltering(nil, net.ParseIP(tc.ruleIP), tc.ruleProto, nil, tc.ruleDstPort, tc.ruleAction, "")
+ require.NoError(t, err)
+ require.NotEmpty(t, rules)
+ t.Cleanup(func() {
+ for _, rule := range rules {
+ require.NoError(t, manager.DeletePeerRule(rule))
+ }
+ })
+
+ packet := createTestPacket(t, tc.srcIP, tc.dstIP, tc.proto, tc.srcPort, tc.dstPort)
+ isDropped := manager.FilterInbound(packet, 0)
+ require.Equal(t, tc.shouldBeBlocked, isDropped, "packet filter result mismatch")
+ })
+ }
+}
+
func createTestPacket(t *testing.T, srcIP, dstIP string, proto fw.Protocol, srcPort, dstPort uint16) []byte {
t.Helper()
+ src := net.ParseIP(srcIP)
+ dst := net.ParseIP(dstIP)
+
buf := gopacket.NewSerializeBuffer()
opts := gopacket.SerializeOptions{
ComputeChecksums: true,
FixLengths: true,
}
- ipLayer := &layers.IPv4{
- Version: 4,
- TTL: 64,
- SrcIP: net.ParseIP(srcIP),
- DstIP: net.ParseIP(dstIP),
- }
+ // Detect address family
+ isV6 := src.To4() == nil
var err error
- switch proto {
- case fw.ProtocolTCP:
- ipLayer.Protocol = layers.IPProtocolTCP
- tcp := &layers.TCP{
- SrcPort: layers.TCPPort(srcPort),
- DstPort: layers.TCPPort(dstPort),
- }
- err = tcp.SetNetworkLayerForChecksum(ipLayer)
- require.NoError(t, err)
- err = gopacket.SerializeLayers(buf, opts, ipLayer, tcp)
- case fw.ProtocolUDP:
- ipLayer.Protocol = layers.IPProtocolUDP
- udp := &layers.UDP{
- SrcPort: layers.UDPPort(srcPort),
- DstPort: layers.UDPPort(dstPort),
+ if isV6 {
+ ip6 := &layers.IPv6{
+ Version: 6,
+ HopLimit: 64,
+ SrcIP: src,
+ DstIP: dst,
}
- err = udp.SetNetworkLayerForChecksum(ipLayer)
- require.NoError(t, err)
- err = gopacket.SerializeLayers(buf, opts, ipLayer, udp)
- case fw.ProtocolICMP:
- ipLayer.Protocol = layers.IPProtocolICMPv4
- icmp := &layers.ICMPv4{
- TypeCode: layers.CreateICMPv4TypeCode(layers.ICMPv4TypeEchoRequest, 0),
+ switch proto {
+ case fw.ProtocolTCP:
+ ip6.NextHeader = layers.IPProtocolTCP
+ tcp := &layers.TCP{SrcPort: layers.TCPPort(srcPort), DstPort: layers.TCPPort(dstPort)}
+ _ = tcp.SetNetworkLayerForChecksum(ip6)
+ err = gopacket.SerializeLayers(buf, opts, ip6, tcp)
+ case fw.ProtocolUDP:
+ ip6.NextHeader = layers.IPProtocolUDP
+ udp := &layers.UDP{SrcPort: layers.UDPPort(srcPort), DstPort: layers.UDPPort(dstPort)}
+ _ = udp.SetNetworkLayerForChecksum(ip6)
+ err = gopacket.SerializeLayers(buf, opts, ip6, udp)
+ case fw.ProtocolICMP:
+ ip6.NextHeader = layers.IPProtocolICMPv6
+ icmp := &layers.ICMPv6{
+ TypeCode: layers.CreateICMPv6TypeCode(layers.ICMPv6TypeEchoRequest, 0),
+ }
+ _ = icmp.SetNetworkLayerForChecksum(ip6)
+ err = gopacket.SerializeLayers(buf, opts, ip6, icmp)
+ default:
+ err = gopacket.SerializeLayers(buf, opts, ip6)
+ }
+ } else {
+ ip4 := &layers.IPv4{
+ Version: 4,
+ TTL: 64,
+ SrcIP: src,
+ DstIP: dst,
}
- err = gopacket.SerializeLayers(buf, opts, ipLayer, icmp)
- default:
- err = gopacket.SerializeLayers(buf, opts, ipLayer)
+ switch proto {
+ case fw.ProtocolTCP:
+ ip4.Protocol = layers.IPProtocolTCP
+ tcp := &layers.TCP{SrcPort: layers.TCPPort(srcPort), DstPort: layers.TCPPort(dstPort)}
+ _ = tcp.SetNetworkLayerForChecksum(ip4)
+ err = gopacket.SerializeLayers(buf, opts, ip4, tcp)
+ case fw.ProtocolUDP:
+ ip4.Protocol = layers.IPProtocolUDP
+ udp := &layers.UDP{SrcPort: layers.UDPPort(srcPort), DstPort: layers.UDPPort(dstPort)}
+ _ = udp.SetNetworkLayerForChecksum(ip4)
+ err = gopacket.SerializeLayers(buf, opts, ip4, udp)
+ case fw.ProtocolICMP:
+ ip4.Protocol = layers.IPProtocolICMPv4
+ icmp := &layers.ICMPv4{TypeCode: layers.CreateICMPv4TypeCode(layers.ICMPv4TypeEchoRequest, 0)}
+ err = gopacket.SerializeLayers(buf, opts, ip4, icmp)
+ default:
+ err = gopacket.SerializeLayers(buf, opts, ip4)
+ }
}
require.NoError(t, err)
@@ -1498,3 +1681,103 @@ func TestRouteACLSet(t *testing.T) {
_, isAllowed = manager.routeACLsPass(srcIP, dstIP, protoToLayer(fw.ProtocolTCP, layers.LayerTypeIPv4), 12345, 80)
require.True(t, isAllowed, "After set update, traffic to the added network should be allowed")
}
+
+// TestRouteACLFilteringIPv6 tests IPv6 route ACL matching directly via routeACLsPass.
+// Note: full FilterInbound for routed IPv6 traffic drops at the forwarder stage (IPv4-only)
+// but the ACL decision itself is correct.
+func TestRouteACLFilteringIPv6(t *testing.T) {
+ manager := setupRoutedManager(t, "10.10.0.100/16")
+
+ v6Dst := netip.MustParsePrefix("fd00:dead:beef::/48")
+ _, err := manager.AddRouteFiltering(
+ nil,
+ []netip.Prefix{netip.MustParsePrefix("fd00::/16")},
+ fw.Network{Prefix: v6Dst},
+ fw.ProtocolTCP,
+ nil,
+ &fw.Port{Values: []uint16{80}},
+ fw.ActionAccept,
+ )
+ require.NoError(t, err)
+
+ _, err = manager.AddRouteFiltering(
+ nil,
+ []netip.Prefix{netip.MustParsePrefix("fd00::/16")},
+ fw.Network{Prefix: netip.MustParsePrefix("fd00:dead:beef:1::/64")},
+ fw.ProtocolALL,
+ nil,
+ nil,
+ fw.ActionDrop,
+ )
+ require.NoError(t, err)
+
+ tests := []struct {
+ name string
+ srcIP netip.Addr
+ dstIP netip.Addr
+ proto gopacket.LayerType
+ srcPort uint16
+ dstPort uint16
+ allowed bool
+ }{
+ {
+ name: "IPv6 TCP to allowed dest",
+ srcIP: netip.MustParseAddr("fd00::1"),
+ dstIP: netip.MustParseAddr("fd00:dead:beef::80"),
+ proto: layers.LayerTypeTCP,
+ srcPort: 12345,
+ dstPort: 80,
+ allowed: true,
+ },
+ {
+ name: "IPv6 TCP wrong port",
+ srcIP: netip.MustParseAddr("fd00::1"),
+ dstIP: netip.MustParseAddr("fd00:dead:beef::80"),
+ proto: layers.LayerTypeTCP,
+ srcPort: 12345,
+ dstPort: 443,
+ allowed: false,
+ },
+ {
+ name: "IPv6 UDP not matched by TCP rule",
+ srcIP: netip.MustParseAddr("fd00::1"),
+ dstIP: netip.MustParseAddr("fd00:dead:beef::80"),
+ proto: layers.LayerTypeUDP,
+ srcPort: 12345,
+ dstPort: 80,
+ allowed: false,
+ },
+ {
+ name: "IPv6 ICMPv6 matches ICMP rule via protoLayerMatches",
+ srcIP: netip.MustParseAddr("fd00::1"),
+ dstIP: netip.MustParseAddr("fd00:dead:beef::80"),
+ proto: layers.LayerTypeICMPv6,
+ allowed: false,
+ },
+ {
+ name: "IPv6 to denied subnet",
+ srcIP: netip.MustParseAddr("fd00::1"),
+ dstIP: netip.MustParseAddr("fd00:dead:beef:1::1"),
+ proto: layers.LayerTypeTCP,
+ srcPort: 12345,
+ dstPort: 80,
+ allowed: false,
+ },
+ {
+ name: "IPv6 source outside allowed range",
+ srcIP: netip.MustParseAddr("fe80::1"),
+ dstIP: netip.MustParseAddr("fd00:dead:beef::80"),
+ proto: layers.LayerTypeTCP,
+ srcPort: 12345,
+ dstPort: 80,
+ allowed: false,
+ },
+ }
+
+ for _, tc := range tests {
+ t.Run(tc.name, func(t *testing.T) {
+ _, pass := manager.routeACLsPass(tc.srcIP, tc.dstIP, tc.proto, tc.srcPort, tc.dstPort)
+ require.Equal(t, tc.allowed, pass, "route ACL result mismatch")
+ })
+ }
+}
diff --git a/client/firewall/uspfilter/filter_routeacl_test.go b/client/firewall/uspfilter/filter_routeacl_test.go
index 68572a01c..449554d8b 100644
--- a/client/firewall/uspfilter/filter_routeacl_test.go
+++ b/client/firewall/uspfilter/filter_routeacl_test.go
@@ -189,21 +189,21 @@ func TestBlockInvalidRoutedIdempotent(t *testing.T) {
})
// Call blockInvalidRouted directly multiple times
- rule1, err := manager.blockInvalidRouted(ifaceMock)
+ rules1, err := manager.blockInvalidRouted(ifaceMock)
require.NoError(t, err)
- require.NotNil(t, rule1)
+ require.NotEmpty(t, rules1)
- rule2, err := manager.blockInvalidRouted(ifaceMock)
+ rules2, err := manager.blockInvalidRouted(ifaceMock)
require.NoError(t, err)
- require.NotNil(t, rule2)
+ require.NotEmpty(t, rules2)
- rule3, err := manager.blockInvalidRouted(ifaceMock)
+ rules3, err := manager.blockInvalidRouted(ifaceMock)
require.NoError(t, err)
- require.NotNil(t, rule3)
+ require.NotEmpty(t, rules3)
- // All should return the same rule
- assert.Equal(t, rule1.ID(), rule2.ID(), "Second call should return same rule")
- assert.Equal(t, rule2.ID(), rule3.ID(), "Third call should return same rule")
+ // All calls should return the same v4 block rule (idempotent install).
+ assert.Equal(t, rules1[0].ID(), rules2[0].ID(), "Second call should return same v4 rule")
+ assert.Equal(t, rules2[0].ID(), rules3[0].ID(), "Third call should return same v4 rule")
// Should have exactly 1 route rule
manager.mutex.RLock()
diff --git a/client/firewall/uspfilter/filter_test.go b/client/firewall/uspfilter/filter_test.go
index 5fb9fef0e..f19c4bb56 100644
--- a/client/firewall/uspfilter/filter_test.go
+++ b/client/firewall/uspfilter/filter_test.go
@@ -535,11 +535,16 @@ func TestProcessOutgoingHooks(t *testing.T) {
d := &decoder{
decoded: []gopacket.LayerType{},
}
- d.parser = gopacket.NewDecodingLayerParser(
+ d.parser4 = gopacket.NewDecodingLayerParser(
layers.LayerTypeIPv4,
&d.eth, &d.ip4, &d.ip6, &d.icmp4, &d.icmp6, &d.tcp, &d.udp,
)
- d.parser.IgnoreUnsupported = true
+ d.parser4.IgnoreUnsupported = true
+ d.parser6 = gopacket.NewDecodingLayerParser(
+ layers.LayerTypeIPv6,
+ &d.eth, &d.ip4, &d.ip6, &d.icmp4, &d.icmp6, &d.tcp, &d.udp,
+ )
+ d.parser6.IgnoreUnsupported = true
return d
},
}
@@ -638,11 +643,16 @@ func TestStatefulFirewall_UDPTracking(t *testing.T) {
d := &decoder{
decoded: []gopacket.LayerType{},
}
- d.parser = gopacket.NewDecodingLayerParser(
+ d.parser4 = gopacket.NewDecodingLayerParser(
layers.LayerTypeIPv4,
&d.eth, &d.ip4, &d.ip6, &d.icmp4, &d.icmp6, &d.tcp, &d.udp,
)
- d.parser.IgnoreUnsupported = true
+ d.parser4.IgnoreUnsupported = true
+ d.parser6 = gopacket.NewDecodingLayerParser(
+ layers.LayerTypeIPv6,
+ &d.eth, &d.ip4, &d.ip6, &d.icmp4, &d.icmp6, &d.tcp, &d.udp,
+ )
+ d.parser6.IgnoreUnsupported = true
return d
},
}
@@ -1048,8 +1058,8 @@ func TestMSSClamping(t *testing.T) {
}()
require.True(t, manager.mssClampEnabled, "MSS clamping should be enabled by default")
- expectedMSSValue := uint16(1280 - ipTCPHeaderMinSize)
- require.Equal(t, expectedMSSValue, manager.mssClampValue, "MSS clamp value should be MTU - 40")
+ require.Equal(t, uint16(1280-ipv4TCPHeaderMinSize), manager.mssClampValueIPv4, "IPv4 MSS clamp value should be MTU - 40")
+ require.Equal(t, uint16(1280-ipv6TCPHeaderMinSize), manager.mssClampValueIPv6, "IPv6 MSS clamp value should be MTU - 60")
err = manager.UpdateLocalIPs()
require.NoError(t, err)
@@ -1067,7 +1077,7 @@ func TestMSSClamping(t *testing.T) {
require.Len(t, d.tcp.Options, 1, "Should have MSS option")
require.Equal(t, uint8(layers.TCPOptionKindMSS), uint8(d.tcp.Options[0].OptionType))
actualMSS := binary.BigEndian.Uint16(d.tcp.Options[0].OptionData)
- require.Equal(t, expectedMSSValue, actualMSS, "MSS should be clamped to MTU - 40")
+ require.Equal(t, manager.mssClampValueIPv4, actualMSS, "MSS should be clamped to MTU - 40")
})
t.Run("SYN packet with low MSS unchanged", func(t *testing.T) {
@@ -1091,7 +1101,7 @@ func TestMSSClamping(t *testing.T) {
d := parsePacket(t, packet)
require.Len(t, d.tcp.Options, 1, "Should have MSS option")
actualMSS := binary.BigEndian.Uint16(d.tcp.Options[0].OptionData)
- require.Equal(t, expectedMSSValue, actualMSS, "MSS in SYN-ACK should be clamped")
+ require.Equal(t, manager.mssClampValueIPv4, actualMSS, "MSS in SYN-ACK should be clamped")
})
t.Run("Non-SYN packet unchanged", func(t *testing.T) {
@@ -1263,13 +1273,18 @@ func TestShouldForward(t *testing.T) {
d := &decoder{
decoded: []gopacket.LayerType{},
}
- d.parser = gopacket.NewDecodingLayerParser(
+ d.parser4 = gopacket.NewDecodingLayerParser(
layers.LayerTypeIPv4,
&d.eth, &d.ip4, &d.ip6, &d.icmp4, &d.icmp6, &d.tcp, &d.udp,
)
- d.parser.IgnoreUnsupported = true
+ d.parser4.IgnoreUnsupported = true
+ d.parser6 = gopacket.NewDecodingLayerParser(
+ layers.LayerTypeIPv6,
+ &d.eth, &d.ip4, &d.ip6, &d.icmp4, &d.icmp6, &d.tcp, &d.udp,
+ )
+ d.parser6.IgnoreUnsupported = true
- err = d.parser.DecodeLayers(buf.Bytes(), &d.decoded)
+ err = d.decodePacket(buf.Bytes())
require.NoError(t, err)
return d
@@ -1329,6 +1344,44 @@ func TestShouldForward(t *testing.T) {
},
}
+ // Add IPv6 to the interface and test dual-stack cases
+ wgIPv6 := netip.MustParseAddr("fd00::1")
+ otherIPv6 := netip.MustParseAddr("fd00::2")
+ ifaceMock.AddressFunc = func() wgaddr.Address {
+ return wgaddr.Address{
+ IP: wgIP,
+ Network: netip.PrefixFrom(wgIP, 24),
+ IPv6: wgIPv6,
+ IPv6Net: netip.PrefixFrom(wgIPv6, 64),
+ }
+ }
+
+ // Re-create manager to pick up the new address with IPv6
+ require.NoError(t, manager.Close(nil))
+ manager, err = Create(ifaceMock, false, flowLogger, nbiface.DefaultMTU)
+ require.NoError(t, err)
+
+ v6Cases := []struct {
+ name string
+ dstIP netip.Addr
+ expected bool
+ description string
+ }{
+ {"v6 traffic to other address", otherIPv6, true, "should forward v6 traffic not destined to our v6 address"},
+ {"v6 traffic to our v6 IP", wgIPv6, false, "should not forward traffic destined to our v6 address"},
+ {"v4 traffic to other with v6 configured", otherIP, true, "should forward v4 traffic when v6 configured"},
+ {"v4 traffic to our v4 IP with v6 configured", wgIP, false, "should not forward traffic to our v4 address"},
+ }
+ for _, tt := range v6Cases {
+ t.Run(tt.name, func(t *testing.T) {
+ manager.localForwarding = true
+ manager.netstack = false
+ decoder := createTCPDecoder(8080)
+ result := manager.shouldForward(decoder, tt.dstIP)
+ require.Equal(t, tt.expected, result, tt.description)
+ })
+ }
+
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
// Configure manager
diff --git a/client/firewall/uspfilter/forwarder/endpoint.go b/client/firewall/uspfilter/forwarder/endpoint.go
index 96ab89af8..fab776f2a 100644
--- a/client/firewall/uspfilter/forwarder/endpoint.go
+++ b/client/firewall/uspfilter/forwarder/endpoint.go
@@ -1,7 +1,8 @@
package forwarder
import (
- "fmt"
+ "net"
+ "strconv"
"sync/atomic"
wgdevice "golang.zx2c4.com/wireguard/device"
@@ -54,16 +55,23 @@ func (e *endpoint) LinkAddress() tcpip.LinkAddress {
func (e *endpoint) WritePackets(pkts stack.PacketBufferList) (int, tcpip.Error) {
var written int
for _, pkt := range pkts.AsSlice() {
- netHeader := header.IPv4(pkt.NetworkHeader().View().AsSlice())
-
data := stack.PayloadSince(pkt.NetworkHeader())
if data == nil {
continue
}
- pktBytes := data.AsSlice()
+ raw := pkt.NetworkHeader().View().AsSlice()
+ if len(raw) == 0 {
+ continue
+ }
+ var address tcpip.Address
+ if raw[0]>>4 == 6 {
+ address = header.IPv6(raw).DestinationAddress()
+ } else {
+ address = header.IPv4(raw).DestinationAddress()
+ }
- address := netHeader.DestinationAddress()
+ pktBytes := data.AsSlice()
if err := e.device.CreateOutboundPacket(pktBytes, address.AsSlice()); err != nil {
e.logger.Error1("CreateOutboundPacket: %v", err)
continue
@@ -114,5 +122,7 @@ type epID stack.TransportEndpointID
func (i epID) String() string {
// src and remote is swapped
- return fmt.Sprintf("%s:%d โ %s:%d", i.RemoteAddress, i.RemotePort, i.LocalAddress, i.LocalPort)
+ return net.JoinHostPort(i.RemoteAddress.String(), strconv.Itoa(int(i.RemotePort))) +
+ " โ " +
+ net.JoinHostPort(i.LocalAddress.String(), strconv.Itoa(int(i.LocalPort)))
}
diff --git a/client/firewall/uspfilter/forwarder/forwarder.go b/client/firewall/uspfilter/forwarder/forwarder.go
index 925273f24..6291eb285 100644
--- a/client/firewall/uspfilter/forwarder/forwarder.go
+++ b/client/firewall/uspfilter/forwarder/forwarder.go
@@ -14,6 +14,7 @@ import (
"gvisor.dev/gvisor/pkg/tcpip"
"gvisor.dev/gvisor/pkg/tcpip/header"
"gvisor.dev/gvisor/pkg/tcpip/network/ipv4"
+ "gvisor.dev/gvisor/pkg/tcpip/network/ipv6"
"gvisor.dev/gvisor/pkg/tcpip/stack"
"gvisor.dev/gvisor/pkg/tcpip/transport/icmp"
"gvisor.dev/gvisor/pkg/tcpip/transport/tcp"
@@ -36,25 +37,31 @@ type Forwarder struct {
logger *nblog.Logger
flowLogger nftypes.FlowLogger
// ruleIdMap is used to store the rule ID for a given connection
- ruleIdMap sync.Map
- stack *stack.Stack
- endpoint *endpoint
- udpForwarder *udpForwarder
- ctx context.Context
- cancel context.CancelFunc
- ip tcpip.Address
- netstack bool
- hasRawICMPAccess bool
- pingSemaphore chan struct{}
+ ruleIdMap sync.Map
+ stack *stack.Stack
+ endpoint *endpoint
+ udpForwarder *udpForwarder
+ ctx context.Context
+ cancel context.CancelFunc
+ ip tcpip.Address
+ ipv6 tcpip.Address
+ netstack bool
+ hasRawICMPAccess bool
+ hasRawICMPv6Access bool
+ pingSemaphore chan struct{}
}
func New(iface common.IFaceMapper, logger *nblog.Logger, flowLogger nftypes.FlowLogger, netstack bool, mtu uint16) (*Forwarder, error) {
s := stack.New(stack.Options{
- NetworkProtocols: []stack.NetworkProtocolFactory{ipv4.NewProtocol},
+ NetworkProtocols: []stack.NetworkProtocolFactory{
+ ipv4.NewProtocol,
+ ipv6.NewProtocol,
+ },
TransportProtocols: []stack.TransportProtocolFactory{
tcp.NewProtocol,
udp.NewProtocol,
icmp.NewProtocol4,
+ icmp.NewProtocol6,
},
HandleLocal: false,
})
@@ -73,7 +80,7 @@ func New(iface common.IFaceMapper, logger *nblog.Logger, flowLogger nftypes.Flow
protoAddr := tcpip.ProtocolAddress{
Protocol: ipv4.ProtocolNumber,
AddressWithPrefix: tcpip.AddressWithPrefix{
- Address: tcpip.AddrFromSlice(iface.Address().IP.AsSlice()),
+ Address: tcpip.AddrFrom4(iface.Address().IP.As4()),
PrefixLen: iface.Address().Network.Bits(),
},
}
@@ -82,6 +89,19 @@ func New(iface common.IFaceMapper, logger *nblog.Logger, flowLogger nftypes.Flow
return nil, fmt.Errorf("failed to add protocol address: %s", err)
}
+ if v6 := iface.Address().IPv6; v6.IsValid() {
+ v6Addr := tcpip.ProtocolAddress{
+ Protocol: ipv6.ProtocolNumber,
+ AddressWithPrefix: tcpip.AddressWithPrefix{
+ Address: tcpip.AddrFrom16(v6.As16()),
+ PrefixLen: iface.Address().IPv6Net.Bits(),
+ },
+ }
+ if err := s.AddProtocolAddress(nicID, v6Addr, stack.AddressProperties{}); err != nil {
+ return nil, fmt.Errorf("add IPv6 protocol address: %s", err)
+ }
+ }
+
defaultSubnet, err := tcpip.NewSubnet(
tcpip.AddrFrom4([4]byte{0, 0, 0, 0}),
tcpip.MaskFromBytes([]byte{0, 0, 0, 0}),
@@ -90,6 +110,14 @@ func New(iface common.IFaceMapper, logger *nblog.Logger, flowLogger nftypes.Flow
return nil, fmt.Errorf("creating default subnet: %w", err)
}
+ defaultSubnetV6, err := tcpip.NewSubnet(
+ tcpip.AddrFrom16([16]byte{}),
+ tcpip.MaskFromBytes(make([]byte, 16)),
+ )
+ if err != nil {
+ return nil, fmt.Errorf("creating default v6 subnet: %w", err)
+ }
+
if err := s.SetPromiscuousMode(nicID, true); err != nil {
return nil, fmt.Errorf("set promiscuous mode: %s", err)
}
@@ -98,10 +126,8 @@ func New(iface common.IFaceMapper, logger *nblog.Logger, flowLogger nftypes.Flow
}
s.SetRouteTable([]tcpip.Route{
- {
- Destination: defaultSubnet,
- NIC: nicID,
- },
+ {Destination: defaultSubnet, NIC: nicID},
+ {Destination: defaultSubnetV6, NIC: nicID},
})
ctx, cancel := context.WithCancel(context.Background())
@@ -114,7 +140,8 @@ func New(iface common.IFaceMapper, logger *nblog.Logger, flowLogger nftypes.Flow
ctx: ctx,
cancel: cancel,
netstack: netstack,
- ip: tcpip.AddrFromSlice(iface.Address().IP.AsSlice()),
+ ip: tcpip.AddrFrom4(iface.Address().IP.As4()),
+ ipv6: addrFromNetipAddr(iface.Address().IPv6),
pingSemaphore: make(chan struct{}, 3),
}
@@ -131,7 +158,10 @@ func New(iface common.IFaceMapper, logger *nblog.Logger, flowLogger nftypes.Flow
udpForwarder := udp.NewForwarder(s, f.handleUDP)
s.SetTransportProtocolHandler(udp.ProtocolNumber, udpForwarder.HandlePacket)
- s.SetTransportProtocolHandler(icmp.ProtocolNumber4, f.handleICMP)
+ // ICMP is handled directly in InjectIncomingPacket, bypassing gVisor's
+ // network layer. This avoids duplicate echo replies (v4) and the v6
+ // auto-reply bug where gVisor responds at the network layer before
+ // our transport handler fires.
f.checkICMPCapability()
@@ -150,8 +180,30 @@ func (f *Forwarder) SetCapture(pc PacketCapture) {
}
func (f *Forwarder) InjectIncomingPacket(payload []byte) error {
- if len(payload) < header.IPv4MinimumSize {
- return fmt.Errorf("packet too small: %d bytes", len(payload))
+ if len(payload) == 0 {
+ return fmt.Errorf("empty packet")
+ }
+
+ var protoNum tcpip.NetworkProtocolNumber
+ switch payload[0] >> 4 {
+ case 4:
+ if len(payload) < header.IPv4MinimumSize {
+ return fmt.Errorf("IPv4 packet too small: %d bytes", len(payload))
+ }
+ if f.handleICMPDirect(payload) {
+ return nil
+ }
+ protoNum = ipv4.ProtocolNumber
+ case 6:
+ if len(payload) < header.IPv6MinimumSize {
+ return fmt.Errorf("IPv6 packet too small: %d bytes", len(payload))
+ }
+ if f.handleICMPDirect(payload) {
+ return nil
+ }
+ protoNum = ipv6.ProtocolNumber
+ default:
+ return fmt.Errorf("unknown IP version: %d", payload[0]>>4)
}
pkt := stack.NewPacketBuffer(stack.PacketBufferOptions{
@@ -160,11 +212,160 @@ func (f *Forwarder) InjectIncomingPacket(payload []byte) error {
defer pkt.DecRef()
if f.endpoint.dispatcher != nil {
- f.endpoint.dispatcher.DeliverNetworkPacket(ipv4.ProtocolNumber, pkt)
+ f.endpoint.dispatcher.DeliverNetworkPacket(protoNum, pkt)
}
return nil
}
+// handleICMPDirect intercepts ICMP packets from raw IP payloads before they
+// enter gVisor. It synthesizes the TransportEndpointID and PacketBuffer that
+// the existing handlers expect, then dispatches to handleICMP/handleICMPv6.
+// This bypasses gVisor's network layer which causes duplicate v4 echo replies
+// and auto-replies to all v6 echo requests in promiscuous mode.
+//
+// Unlike gVisor's network layer, this does not validate ICMP checksums or
+// reassemble IP fragments. Fragmented ICMP packets fall through to gVisor.
+func parseICMPv4(payload []byte) (ipHdrLen, icmpLen int, src, dst tcpip.Address, ok bool) {
+ if len(payload) < header.IPv4MinimumSize {
+ return 0, 0, src, dst, false
+ }
+ ip := header.IPv4(payload)
+ if ip.Protocol() != uint8(header.ICMPv4ProtocolNumber) {
+ return 0, 0, src, dst, false
+ }
+ if ip.FragmentOffset() != 0 || ip.Flags()&header.IPv4FlagMoreFragments != 0 {
+ return 0, 0, src, dst, false
+ }
+ ipHdrLen = int(ip.HeaderLength())
+ totalLen := int(ip.TotalLength())
+ if ipHdrLen < header.IPv4MinimumSize || ipHdrLen > totalLen || totalLen > len(payload) {
+ return 0, 0, src, dst, false
+ }
+ icmpLen = totalLen - ipHdrLen
+ if icmpLen < header.ICMPv4MinimumSize {
+ return 0, 0, src, dst, false
+ }
+ return ipHdrLen, icmpLen, ip.SourceAddress(), ip.DestinationAddress(), true
+}
+
+func parseICMPv6(payload []byte) (ipHdrLen, icmpLen int, src, dst tcpip.Address, ok bool) {
+ if len(payload) < header.IPv6MinimumSize {
+ return 0, 0, src, dst, false
+ }
+ ip := header.IPv6(payload)
+ declaredLen := int(ip.PayloadLength())
+ hdrEnd := header.IPv6MinimumSize + declaredLen
+ if hdrEnd > len(payload) {
+ return 0, 0, src, dst, false
+ }
+ icmpStart, ok := skipIPv6ExtensionsToICMPv6(payload, ip.NextHeader(), hdrEnd)
+ if !ok {
+ return 0, 0, src, dst, false
+ }
+ icmpLen = hdrEnd - icmpStart
+ if icmpLen < header.ICMPv6MinimumSize {
+ return 0, 0, src, dst, false
+ }
+ return icmpStart, icmpLen, ip.SourceAddress(), ip.DestinationAddress(), true
+}
+
+// skipIPv6ExtensionsToICMPv6 walks the IPv6 extension-header chain starting
+// after the fixed header. It advances past Hop-by-Hop, Routing, and
+// Destination Options headers (which share the NextHeader+ExtLen+6+ExtLen*8
+// layout) and returns the offset of the ICMPv6 payload. Fragment, ESP, AH,
+// and unknown identifiers are reported as not handleable so the caller can
+// defer to gVisor.
+func skipIPv6ExtensionsToICMPv6(payload []byte, next uint8, hdrEnd int) (int, bool) {
+ off := header.IPv6MinimumSize
+ for {
+ if next == uint8(header.ICMPv6ProtocolNumber) {
+ return off, true
+ }
+ if !isWalkableIPv6ExtHdr(next) {
+ return 0, false
+ }
+ newOff, newNext, ok := advanceIPv6ExtHdr(payload, off, hdrEnd)
+ if !ok {
+ return 0, false
+ }
+ off = newOff
+ next = newNext
+ }
+}
+
+func isWalkableIPv6ExtHdr(id uint8) bool {
+ switch id {
+ case uint8(header.IPv6HopByHopOptionsExtHdrIdentifier),
+ uint8(header.IPv6RoutingExtHdrIdentifier),
+ uint8(header.IPv6DestinationOptionsExtHdrIdentifier):
+ return true
+ }
+ return false
+}
+
+func advanceIPv6ExtHdr(payload []byte, off, hdrEnd int) (int, uint8, bool) {
+ if off+8 > hdrEnd {
+ return 0, 0, false
+ }
+ extLen := (int(payload[off+1]) + 1) * 8
+ if off+extLen > hdrEnd {
+ return 0, 0, false
+ }
+ return off + extLen, payload[off], true
+}
+
+func (f *Forwarder) handleICMPDirect(payload []byte) bool {
+ if len(payload) == 0 {
+ return false
+ }
+ var (
+ ipHdrLen int
+ icmpLen int
+ srcAddr tcpip.Address
+ dstAddr tcpip.Address
+ ok bool
+ )
+ version := payload[0] >> 4
+ switch version {
+ case 4:
+ ipHdrLen, icmpLen, srcAddr, dstAddr, ok = parseICMPv4(payload)
+ case 6:
+ ipHdrLen, icmpLen, srcAddr, dstAddr, ok = parseICMPv6(payload)
+ }
+ if !ok {
+ return false
+ }
+
+ // Let gVisor handle ICMP destined for our own addresses natively.
+ // Its network-layer auto-reply is correct and efficient for local traffic.
+ if f.ip.Equal(dstAddr) || f.ipv6.Equal(dstAddr) {
+ return false
+ }
+
+ id := stack.TransportEndpointID{
+ LocalAddress: dstAddr,
+ RemoteAddress: srcAddr,
+ }
+
+ // Trim the buffer to the IP-declared length so gVisor doesn't see padding.
+ pkt := stack.NewPacketBuffer(stack.PacketBufferOptions{
+ Payload: buffer.MakeWithData(payload[:ipHdrLen+icmpLen]),
+ })
+ defer pkt.DecRef()
+
+ if _, ok := pkt.NetworkHeader().Consume(ipHdrLen); !ok {
+ return false
+ }
+ if _, ok := pkt.TransportHeader().Consume(icmpLen); !ok {
+ return false
+ }
+
+ if version == 6 {
+ return f.handleICMPv6(id, pkt)
+ }
+ return f.handleICMP(id, pkt)
+}
+
// Stop gracefully shuts down the forwarder
func (f *Forwarder) Stop() {
f.cancel()
@@ -177,11 +378,14 @@ func (f *Forwarder) Stop() {
f.stack.Wait()
}
-func (f *Forwarder) determineDialAddr(addr tcpip.Address) net.IP {
+func (f *Forwarder) determineDialAddr(addr tcpip.Address) netip.Addr {
if f.netstack && f.ip.Equal(addr) {
- return net.IPv4(127, 0, 0, 1)
+ return netip.AddrFrom4([4]byte{127, 0, 0, 1})
}
- return addr.AsSlice()
+ if f.netstack && f.ipv6.Equal(addr) {
+ return netip.IPv6Loopback()
+ }
+ return addrToNetipAddr(addr)
}
func (f *Forwarder) RegisterRuleID(srcIP, dstIP netip.Addr, srcPort, dstPort uint16, ruleID []byte) {
@@ -215,23 +419,50 @@ func buildKey(srcIP, dstIP netip.Addr, srcPort, dstPort uint16) conntrack.ConnKe
}
}
+// addrFromNetipAddr converts a netip.Addr to a gvisor tcpip.Address without allocating.
+func addrFromNetipAddr(addr netip.Addr) tcpip.Address {
+ if !addr.IsValid() {
+ return tcpip.Address{}
+ }
+ if addr.Is4() {
+ return tcpip.AddrFrom4(addr.As4())
+ }
+ return tcpip.AddrFrom16(addr.As16())
+}
+
+// addrToNetipAddr converts a gvisor tcpip.Address to netip.Addr without allocating.
+func addrToNetipAddr(addr tcpip.Address) netip.Addr {
+ switch addr.Len() {
+ case 4:
+ return netip.AddrFrom4(addr.As4())
+ case 16:
+ return netip.AddrFrom16(addr.As16())
+ default:
+ return netip.Addr{}
+ }
+}
+
// checkICMPCapability tests whether we have raw ICMP socket access at startup.
func (f *Forwarder) checkICMPCapability() {
+ f.hasRawICMPAccess = probeRawICMP("ip4:icmp", "0.0.0.0", f.logger)
+ f.hasRawICMPv6Access = probeRawICMP("ip6:ipv6-icmp", "::", f.logger)
+}
+
+func probeRawICMP(network, addr string, logger *nblog.Logger) bool {
ctx, cancel := context.WithTimeout(context.Background(), 100*time.Millisecond)
defer cancel()
lc := net.ListenConfig{}
- conn, err := lc.ListenPacket(ctx, "ip4:icmp", "0.0.0.0")
+ conn, err := lc.ListenPacket(ctx, network, addr)
if err != nil {
- f.hasRawICMPAccess = false
- f.logger.Debug("forwarder: No raw ICMP socket access, will use ping binary fallback")
- return
+ logger.Debug1("forwarder: no raw %s socket access, will use ping binary fallback", network)
+ return false
}
if err := conn.Close(); err != nil {
- f.logger.Debug1("forwarder: Failed to close ICMP capability test socket: %v", err)
+ logger.Debug2("forwarder: failed to close %s capability test socket: %v", network, err)
}
- f.hasRawICMPAccess = true
- f.logger.Debug("forwarder: Raw ICMP socket access available")
+ logger.Debug1("forwarder: raw %s socket access available", network)
+ return true
}
diff --git a/client/firewall/uspfilter/forwarder/forwarder_test.go b/client/firewall/uspfilter/forwarder/forwarder_test.go
new file mode 100644
index 000000000..ad74e8493
--- /dev/null
+++ b/client/firewall/uspfilter/forwarder/forwarder_test.go
@@ -0,0 +1,162 @@
+package forwarder
+
+import (
+ "net/netip"
+ "testing"
+
+ "github.com/stretchr/testify/assert"
+ "github.com/stretchr/testify/require"
+ "gvisor.dev/gvisor/pkg/tcpip"
+ "gvisor.dev/gvisor/pkg/tcpip/header"
+)
+
+const echoRequestSize = 8
+
+func makeIPv6(t *testing.T, src, dst netip.Addr, nextHdr uint8, payload []byte) []byte {
+ t.Helper()
+ buf := make([]byte, header.IPv6MinimumSize+len(payload))
+ ip := header.IPv6(buf)
+ ip.Encode(&header.IPv6Fields{
+ PayloadLength: uint16(len(payload)),
+ TransportProtocol: 0, // overwritten below to allow any value
+ HopLimit: 64,
+ SrcAddr: tcpipAddrFromNetip(src),
+ DstAddr: tcpipAddrFromNetip(dst),
+ })
+ buf[6] = nextHdr
+ copy(buf[header.IPv6MinimumSize:], payload)
+ return buf
+}
+
+func tcpipAddrFromNetip(a netip.Addr) tcpip.Address {
+ b := a.As16()
+ return tcpip.AddrFrom16(b)
+}
+
+func echoRequest() []byte {
+ icmp := make([]byte, echoRequestSize)
+ icmp[0] = uint8(header.ICMPv6EchoRequest)
+ return icmp
+}
+
+// extHdr builds a generic IPv6 extension header (HBH/Routing/DestOpts) of the
+// given total octet length (must be multiple of 8, >= 8) with the given next
+// header.
+func extHdr(t *testing.T, next uint8, totalLen int) []byte {
+ t.Helper()
+ require.GreaterOrEqual(t, totalLen, 8)
+ require.Equal(t, 0, totalLen%8)
+ buf := make([]byte, totalLen)
+ buf[0] = next
+ buf[1] = uint8(totalLen/8 - 1)
+ return buf
+}
+
+func TestParseICMPv6_NoExtensions(t *testing.T) {
+ src := netip.MustParseAddr("fd00::1")
+ dst := netip.MustParseAddr("fd00::2")
+ pkt := makeIPv6(t, src, dst, uint8(header.ICMPv6ProtocolNumber), echoRequest())
+
+ off, icmpLen, _, _, ok := parseICMPv6(pkt)
+ require.True(t, ok)
+ assert.Equal(t, header.IPv6MinimumSize, off)
+ assert.Equal(t, echoRequestSize, icmpLen)
+}
+
+func TestParseICMPv6_SingleExtension(t *testing.T) {
+ src := netip.MustParseAddr("fd00::1")
+ dst := netip.MustParseAddr("fd00::2")
+ hbh := extHdr(t, uint8(header.ICMPv6ProtocolNumber), 8)
+ payload := append([]byte{}, hbh...)
+ payload = append(payload, echoRequest()...)
+ pkt := makeIPv6(t, src, dst, uint8(header.IPv6HopByHopOptionsExtHdrIdentifier), payload)
+
+ off, icmpLen, _, _, ok := parseICMPv6(pkt)
+ require.True(t, ok)
+ assert.Equal(t, header.IPv6MinimumSize+8, off)
+ assert.Equal(t, echoRequestSize, icmpLen)
+}
+
+func TestParseICMPv6_ChainedExtensions(t *testing.T) {
+ src := netip.MustParseAddr("fd00::1")
+ dst := netip.MustParseAddr("fd00::2")
+ dest := extHdr(t, uint8(header.ICMPv6ProtocolNumber), 16)
+ rt := extHdr(t, uint8(header.IPv6DestinationOptionsExtHdrIdentifier), 8)
+ hbh := extHdr(t, uint8(header.IPv6RoutingExtHdrIdentifier), 8)
+ payload := append(append(append([]byte{}, hbh...), rt...), dest...)
+ payload = append(payload, echoRequest()...)
+ pkt := makeIPv6(t, src, dst, uint8(header.IPv6HopByHopOptionsExtHdrIdentifier), payload)
+
+ off, icmpLen, _, _, ok := parseICMPv6(pkt)
+ require.True(t, ok)
+ assert.Equal(t, header.IPv6MinimumSize+8+8+16, off)
+ assert.Equal(t, echoRequestSize, icmpLen)
+}
+
+func TestParseICMPv6_FragmentDefersToGVisor(t *testing.T) {
+ src := netip.MustParseAddr("fd00::1")
+ dst := netip.MustParseAddr("fd00::2")
+ pkt := makeIPv6(t, src, dst, uint8(header.IPv6FragmentExtHdrIdentifier), make([]byte, 8))
+
+ _, _, _, _, ok := parseICMPv6(pkt)
+ assert.False(t, ok)
+}
+
+func TestParseICMPv6_TruncatedExtension(t *testing.T) {
+ src := netip.MustParseAddr("fd00::1")
+ dst := netip.MustParseAddr("fd00::2")
+ // Extension claims 16 bytes but only 8 remain after the IP header.
+ hbh := []byte{uint8(header.ICMPv6ProtocolNumber), 1, 0, 0, 0, 0, 0, 0}
+ pkt := makeIPv6(t, src, dst, uint8(header.IPv6HopByHopOptionsExtHdrIdentifier), hbh)
+
+ _, _, _, _, ok := parseICMPv6(pkt)
+ assert.False(t, ok)
+}
+
+func TestParseICMPv6_TruncatedICMPPayload(t *testing.T) {
+ src := netip.MustParseAddr("fd00::1")
+ dst := netip.MustParseAddr("fd00::2")
+ // PayloadLength claims 8 bytes of ICMPv6 but the buffer only holds 4.
+ pkt := makeIPv6(t, src, dst, uint8(header.ICMPv6ProtocolNumber), make([]byte, 8))
+ pkt = pkt[:header.IPv6MinimumSize+4]
+
+ _, _, _, _, ok := parseICMPv6(pkt)
+ assert.False(t, ok)
+}
+
+func TestParseICMPv4_RejectsShortIHL(t *testing.T) {
+ pkt := make([]byte, 28)
+ pkt[0] = 0x44 // version 4, IHL 4 (16 bytes - below minimum)
+ pkt[9] = uint8(header.ICMPv4ProtocolNumber)
+ header.IPv4(pkt).SetTotalLength(28)
+
+ _, _, _, _, ok := parseICMPv4(pkt)
+ assert.False(t, ok)
+}
+
+func TestParseICMPv4_RejectsTotalLenOverBuffer(t *testing.T) {
+ pkt := make([]byte, header.IPv4MinimumSize+header.ICMPv4MinimumSize)
+ ip := header.IPv4(pkt)
+ ip.Encode(&header.IPv4Fields{
+ TotalLength: uint16(len(pkt) + 16),
+ Protocol: uint8(header.ICMPv4ProtocolNumber),
+ TTL: 64,
+ })
+
+ _, _, _, _, ok := parseICMPv4(pkt)
+ assert.False(t, ok)
+}
+
+func TestParseICMPv4_RejectsFragment(t *testing.T) {
+ pkt := make([]byte, header.IPv4MinimumSize+header.ICMPv4MinimumSize)
+ ip := header.IPv4(pkt)
+ ip.Encode(&header.IPv4Fields{
+ TotalLength: uint16(len(pkt)),
+ Protocol: uint8(header.ICMPv4ProtocolNumber),
+ TTL: 64,
+ Flags: header.IPv4FlagMoreFragments,
+ })
+
+ _, _, _, _, ok := parseICMPv4(pkt)
+ assert.False(t, ok)
+}
diff --git a/client/firewall/uspfilter/forwarder/icmp.go b/client/firewall/uspfilter/forwarder/icmp.go
index 217423901..d6d4e705e 100644
--- a/client/firewall/uspfilter/forwarder/icmp.go
+++ b/client/firewall/uspfilter/forwarder/icmp.go
@@ -13,6 +13,7 @@ import (
"gvisor.dev/gvisor/pkg/tcpip/header"
"gvisor.dev/gvisor/pkg/tcpip/stack"
+ nblog "github.com/netbirdio/netbird/client/firewall/uspfilter/log"
nftypes "github.com/netbirdio/netbird/client/internal/netflow/types"
)
@@ -35,7 +36,7 @@ func (f *Forwarder) handleICMP(id stack.TransportEndpointID, pkt *stack.PacketBu
}
icmpData := stack.PayloadSince(pkt.TransportHeader()).AsSlice()
- conn, err := f.forwardICMPPacket(id, icmpData, uint8(icmpHdr.Type()), uint8(icmpHdr.Code()), 100*time.Millisecond)
+ conn, err := f.forwardICMPPacket(id, icmpData, uint8(icmpHdr.Type()), uint8(icmpHdr.Code()), false, 100*time.Millisecond)
if err != nil {
f.logger.Error2("forwarder: Failed to forward ICMP packet for %v: %v", epID(id), err)
return true
@@ -58,7 +59,7 @@ func (f *Forwarder) handleICMPEcho(flowID uuid.UUID, id stack.TransportEndpointI
defer func() { <-f.pingSemaphore }()
if f.hasRawICMPAccess {
- f.handleICMPViaSocket(flowID, id, icmpType, icmpCode, icmpData, rxBytes)
+ f.handleICMPViaSocket(flowID, id, icmpType, icmpCode, icmpData, rxBytes, false)
} else {
f.handleICMPViaPing(flowID, id, icmpType, icmpCode, icmpData, rxBytes)
}
@@ -72,18 +73,23 @@ func (f *Forwarder) handleICMPEcho(flowID uuid.UUID, id stack.TransportEndpointI
// forwardICMPPacket creates a raw ICMP socket and sends the packet, returning the connection.
// The caller is responsible for closing the returned connection.
-func (f *Forwarder) forwardICMPPacket(id stack.TransportEndpointID, payload []byte, icmpType, icmpCode uint8, timeout time.Duration) (net.PacketConn, error) {
+func (f *Forwarder) forwardICMPPacket(id stack.TransportEndpointID, payload []byte, icmpType, icmpCode uint8, v6 bool, timeout time.Duration) (net.PacketConn, error) {
ctx, cancel := context.WithTimeout(f.ctx, timeout)
defer cancel()
+ network, listenAddr := "ip4:icmp", "0.0.0.0"
+ if v6 {
+ network, listenAddr = "ip6:ipv6-icmp", "::"
+ }
+
lc := net.ListenConfig{}
- conn, err := lc.ListenPacket(ctx, "ip4:icmp", "0.0.0.0")
+ conn, err := lc.ListenPacket(ctx, network, listenAddr)
if err != nil {
return nil, fmt.Errorf("create ICMP socket: %w", err)
}
dstIP := f.determineDialAddr(id.LocalAddress)
- dst := &net.IPAddr{IP: dstIP}
+ dst := &net.IPAddr{IP: dstIP.AsSlice()}
if _, err = conn.WriteTo(payload, dst); err != nil {
if closeErr := conn.Close(); closeErr != nil {
@@ -92,17 +98,19 @@ func (f *Forwarder) forwardICMPPacket(id stack.TransportEndpointID, payload []by
return nil, fmt.Errorf("write ICMP packet: %w", err)
}
- f.logger.Trace3("forwarder: Forwarded ICMP packet %v type %v code %v",
- epID(id), icmpType, icmpCode)
+ if f.logger.Enabled(nblog.LevelTrace) {
+ f.logger.Trace3("forwarder: Forwarded ICMP packet %v type %v code %v",
+ epID(id), icmpType, icmpCode)
+ }
return conn, nil
}
-// handleICMPViaSocket handles ICMP echo requests using raw sockets.
-func (f *Forwarder) handleICMPViaSocket(flowID uuid.UUID, id stack.TransportEndpointID, icmpType, icmpCode uint8, icmpData []byte, rxBytes int) {
+// handleICMPViaSocket handles ICMP echo requests using raw sockets for both v4 and v6.
+func (f *Forwarder) handleICMPViaSocket(flowID uuid.UUID, id stack.TransportEndpointID, icmpType, icmpCode uint8, icmpData []byte, rxBytes int, v6 bool) {
sendTime := time.Now()
- conn, err := f.forwardICMPPacket(id, icmpData, icmpType, icmpCode, 5*time.Second)
+ conn, err := f.forwardICMPPacket(id, icmpData, icmpType, icmpCode, v6, 5*time.Second)
if err != nil {
f.logger.Error2("forwarder: Failed to send ICMP packet for %v: %v", epID(id), err)
return
@@ -113,16 +121,22 @@ func (f *Forwarder) handleICMPViaSocket(flowID uuid.UUID, id stack.TransportEndp
}
}()
- txBytes := f.handleEchoResponse(conn, id)
+ txBytes := f.handleEchoResponse(conn, id, v6)
rtt := time.Since(sendTime).Round(10 * time.Microsecond)
- f.logger.Trace4("forwarder: Forwarded ICMP echo reply %v type %v code %v (rtt=%v, raw socket)",
- epID(id), icmpType, icmpCode, rtt)
+ if f.logger.Enabled(nblog.LevelTrace) {
+ proto := "ICMP"
+ if v6 {
+ proto = "ICMPv6"
+ }
+ f.logger.Trace5("forwarder: Forwarded %s echo reply %v type %v code %v (rtt=%v, raw socket)",
+ proto, epID(id), icmpType, icmpCode, rtt)
+ }
f.sendICMPEvent(nftypes.TypeEnd, flowID, id, icmpType, icmpCode, uint64(rxBytes), uint64(txBytes))
}
-func (f *Forwarder) handleEchoResponse(conn net.PacketConn, id stack.TransportEndpointID) int {
+func (f *Forwarder) handleEchoResponse(conn net.PacketConn, id stack.TransportEndpointID, v6 bool) int {
if err := conn.SetReadDeadline(time.Now().Add(5 * time.Second)); err != nil {
f.logger.Error1("forwarder: Failed to set read deadline for ICMP response: %v", err)
return 0
@@ -137,6 +151,19 @@ func (f *Forwarder) handleEchoResponse(conn net.PacketConn, id stack.TransportEn
return 0
}
+ if v6 {
+ // Recompute checksum: the raw socket response has a checksum computed
+ // over the real endpoint addresses, but we inject with overlay addresses.
+ icmpHdr := header.ICMPv6(response[:n])
+ icmpHdr.SetChecksum(0)
+ icmpHdr.SetChecksum(header.ICMPv6Checksum(header.ICMPv6ChecksumParams{
+ Header: icmpHdr,
+ Src: id.LocalAddress,
+ Dst: id.RemoteAddress,
+ }))
+ return f.injectICMPv6Reply(id, response[:n])
+ }
+
return f.injectICMPReply(id, response[:n])
}
@@ -150,19 +177,23 @@ func (f *Forwarder) sendICMPEvent(typ nftypes.Type, flowID uuid.UUID, id stack.T
txPackets = 1
}
- srcIp := netip.AddrFrom4(id.RemoteAddress.As4())
- dstIp := netip.AddrFrom4(id.LocalAddress.As4())
+ srcIp := addrToNetipAddr(id.RemoteAddress)
+ dstIp := addrToNetipAddr(id.LocalAddress)
+
+ proto := nftypes.ICMP
+ if srcIp.Is6() {
+ proto = nftypes.ICMPv6
+ }
fields := nftypes.EventFields{
FlowID: flowID,
Type: typ,
Direction: nftypes.Ingress,
- Protocol: nftypes.ICMP,
- // TODO: handle ipv6
- SourceIP: srcIp,
- DestIP: dstIp,
- ICMPType: icmpType,
- ICMPCode: icmpCode,
+ Protocol: proto,
+ SourceIP: srcIp,
+ DestIP: dstIp,
+ ICMPType: icmpType,
+ ICMPCode: icmpCode,
RxBytes: rxBytes,
TxBytes: txBytes,
@@ -198,37 +229,179 @@ func (f *Forwarder) handleICMPViaPing(flowID uuid.UUID, id stack.TransportEndpoi
}
rtt := time.Since(pingStart).Round(10 * time.Microsecond)
- f.logger.Trace3("forwarder: Forwarded ICMP echo request %v type %v code %v",
- epID(id), icmpType, icmpCode)
+ if f.logger.Enabled(nblog.LevelTrace) {
+ f.logger.Trace3("forwarder: Forwarded ICMP echo request %v type %v code %v",
+ epID(id), icmpType, icmpCode)
+ }
txBytes := f.synthesizeEchoReply(id, icmpData)
- f.logger.Trace4("forwarder: Forwarded ICMP echo reply %v type %v code %v (rtt=%v, ping binary)",
+ if f.logger.Enabled(nblog.LevelTrace) {
+ f.logger.Trace4("forwarder: Forwarded ICMP echo reply %v type %v code %v (rtt=%v, ping binary)",
+ epID(id), icmpType, icmpCode, rtt)
+ }
+
+ f.sendICMPEvent(nftypes.TypeEnd, flowID, id, icmpType, icmpCode, uint64(rxBytes), uint64(txBytes))
+}
+
+// handleICMPv6 handles ICMPv6 packets from the network stack.
+func (f *Forwarder) handleICMPv6(id stack.TransportEndpointID, pkt *stack.PacketBuffer) bool {
+ icmpHdr := header.ICMPv6(pkt.TransportHeader().View().AsSlice())
+
+ flowID := uuid.New()
+ f.sendICMPEvent(nftypes.TypeStart, flowID, id, uint8(icmpHdr.Type()), uint8(icmpHdr.Code()), 0, 0)
+
+ if icmpHdr.Type() == header.ICMPv6EchoRequest {
+ return f.handleICMPv6Echo(flowID, id, pkt, uint8(icmpHdr.Type()), uint8(icmpHdr.Code()))
+ }
+
+ // For non-echo types (Destination Unreachable, Packet Too Big, etc), forward without waiting
+ if !f.hasRawICMPv6Access {
+ f.logger.Debug2("forwarder: Cannot handle ICMPv6 type %v without raw socket access for %v", icmpHdr.Type(), epID(id))
+ return false
+ }
+
+ icmpData := stack.PayloadSince(pkt.TransportHeader()).AsSlice()
+ conn, err := f.forwardICMPPacket(id, icmpData, uint8(icmpHdr.Type()), uint8(icmpHdr.Code()), true, 100*time.Millisecond)
+ if err != nil {
+ f.logger.Error2("forwarder: Failed to forward ICMPv6 packet for %v: %v", epID(id), err)
+ return true
+ }
+ if err := conn.Close(); err != nil {
+ f.logger.Debug1("forwarder: Failed to close ICMPv6 socket: %v", err)
+ }
+
+ return true
+}
+
+// handleICMPv6Echo handles ICMPv6 echo requests via raw socket or ping binary fallback.
+func (f *Forwarder) handleICMPv6Echo(flowID uuid.UUID, id stack.TransportEndpointID, pkt *stack.PacketBuffer, icmpType, icmpCode uint8) bool {
+ select {
+ case f.pingSemaphore <- struct{}{}:
+ icmpData := stack.PayloadSince(pkt.TransportHeader()).ToSlice()
+ rxBytes := pkt.Size()
+
+ go func() {
+ defer func() { <-f.pingSemaphore }()
+
+ if f.hasRawICMPv6Access {
+ f.handleICMPViaSocket(flowID, id, icmpType, icmpCode, icmpData, rxBytes, true)
+ } else {
+ f.handleICMPv6ViaPing(flowID, id, icmpType, icmpCode, icmpData, rxBytes)
+ }
+ }()
+ default:
+ f.logger.Debug3("forwarder: ICMPv6 rate limit exceeded for %v type %v code %v", epID(id), icmpType, icmpCode)
+ }
+ return true
+}
+
+// handleICMPv6ViaPing uses the system ping6 binary for ICMPv6 echo.
+func (f *Forwarder) handleICMPv6ViaPing(flowID uuid.UUID, id stack.TransportEndpointID, icmpType, icmpCode uint8, icmpData []byte, rxBytes int) {
+ ctx, cancel := context.WithTimeout(f.ctx, 5*time.Second)
+ defer cancel()
+
+ dstIP := f.determineDialAddr(id.LocalAddress)
+ cmd := buildPingCommand(ctx, dstIP, 5*time.Second)
+
+ pingStart := time.Now()
+ if err := cmd.Run(); err != nil {
+ f.logger.Warn4("forwarder: Ping6 failed for %v type %v code %v: %v", epID(id), icmpType, icmpCode, err)
+ return
+ }
+ rtt := time.Since(pingStart).Round(10 * time.Microsecond)
+
+ f.logger.Trace3("forwarder: Forwarded ICMPv6 echo request %v type %v code %v",
+ epID(id), icmpType, icmpCode)
+
+ txBytes := f.synthesizeICMPv6EchoReply(id, icmpData)
+
+ f.logger.Trace4("forwarder: Forwarded ICMPv6 echo reply %v type %v code %v (rtt=%v, ping binary)",
epID(id), icmpType, icmpCode, rtt)
f.sendICMPEvent(nftypes.TypeEnd, flowID, id, icmpType, icmpCode, uint64(rxBytes), uint64(txBytes))
}
+// synthesizeICMPv6EchoReply creates an ICMPv6 echo reply and injects it back.
+func (f *Forwarder) synthesizeICMPv6EchoReply(id stack.TransportEndpointID, icmpData []byte) int {
+ replyICMP := make([]byte, len(icmpData))
+ copy(replyICMP, icmpData)
+
+ replyHdr := header.ICMPv6(replyICMP)
+ replyHdr.SetType(header.ICMPv6EchoReply)
+ replyHdr.SetChecksum(0)
+ // ICMPv6Checksum computes the pseudo-header internally from Src/Dst.
+ // Header contains the full ICMP message, so PayloadCsum/PayloadLen are zero.
+ replyHdr.SetChecksum(header.ICMPv6Checksum(header.ICMPv6ChecksumParams{
+ Header: replyHdr,
+ Src: id.LocalAddress,
+ Dst: id.RemoteAddress,
+ }))
+
+ return f.injectICMPv6Reply(id, replyICMP)
+}
+
+// injectICMPv6Reply wraps an ICMPv6 payload in an IPv6 header and sends to the peer.
+func (f *Forwarder) injectICMPv6Reply(id stack.TransportEndpointID, icmpPayload []byte) int {
+ ipHdr := make([]byte, header.IPv6MinimumSize)
+ ip := header.IPv6(ipHdr)
+ ip.Encode(&header.IPv6Fields{
+ PayloadLength: uint16(len(icmpPayload)),
+ TransportProtocol: header.ICMPv6ProtocolNumber,
+ HopLimit: 64,
+ SrcAddr: id.LocalAddress,
+ DstAddr: id.RemoteAddress,
+ })
+
+ fullPacket := make([]byte, 0, len(ipHdr)+len(icmpPayload))
+ fullPacket = append(fullPacket, ipHdr...)
+ fullPacket = append(fullPacket, icmpPayload...)
+
+ if err := f.endpoint.device.CreateOutboundPacket(fullPacket, id.RemoteAddress.AsSlice()); err != nil {
+ f.logger.Error1("forwarder: Failed to send ICMPv6 reply to peer: %v", err)
+ return 0
+ }
+
+ return len(fullPacket)
+}
+
+const (
+ pingBin = "ping"
+ ping6Bin = "ping6"
+)
+
// buildPingCommand creates a platform-specific ping command.
-func buildPingCommand(ctx context.Context, target net.IP, timeout time.Duration) *exec.Cmd {
+// Most platforms auto-detect IPv6 from raw addresses. macOS/iOS/OpenBSD require ping6.
+func buildPingCommand(ctx context.Context, target netip.Addr, timeout time.Duration) *exec.Cmd {
timeoutSec := int(timeout.Seconds())
if timeoutSec < 1 {
timeoutSec = 1
}
+ isV6 := target.Is6()
+ timeoutStr := fmt.Sprintf("%d", timeoutSec)
+
switch runtime.GOOS {
case "linux", "android":
- return exec.CommandContext(ctx, "ping", "-c", "1", "-W", fmt.Sprintf("%d", timeoutSec), "-q", target.String())
+ return exec.CommandContext(ctx, pingBin, "-c", "1", "-W", timeoutStr, "-q", target.String())
case "darwin", "ios":
- return exec.CommandContext(ctx, "ping", "-c", "1", "-t", fmt.Sprintf("%d", timeoutSec), "-q", target.String())
+ bin := pingBin
+ if isV6 {
+ bin = ping6Bin
+ }
+ return exec.CommandContext(ctx, bin, "-c", "1", "-t", timeoutStr, "-q", target.String())
case "freebsd":
- return exec.CommandContext(ctx, "ping", "-c", "1", "-t", fmt.Sprintf("%d", timeoutSec), target.String())
+ return exec.CommandContext(ctx, pingBin, "-c", "1", "-t", timeoutStr, target.String())
case "openbsd", "netbsd":
- return exec.CommandContext(ctx, "ping", "-c", "1", "-w", fmt.Sprintf("%d", timeoutSec), target.String())
+ bin := pingBin
+ if isV6 {
+ bin = ping6Bin
+ }
+ return exec.CommandContext(ctx, bin, "-c", "1", "-w", timeoutStr, target.String())
case "windows":
- return exec.CommandContext(ctx, "ping", "-n", "1", "-w", fmt.Sprintf("%d", timeoutSec*1000), target.String())
+ return exec.CommandContext(ctx, pingBin, "-n", "1", "-w", fmt.Sprintf("%d", timeoutSec*1000), target.String())
default:
- return exec.CommandContext(ctx, "ping", "-c", "1", target.String())
+ return exec.CommandContext(ctx, pingBin, "-c", "1", target.String())
}
}
diff --git a/client/firewall/uspfilter/forwarder/tcp.go b/client/firewall/uspfilter/forwarder/tcp.go
index aef420061..c65ebcde0 100644
--- a/client/firewall/uspfilter/forwarder/tcp.go
+++ b/client/firewall/uspfilter/forwarder/tcp.go
@@ -1,12 +1,8 @@
package forwarder
import (
- "context"
- "fmt"
- "io"
"net"
- "net/netip"
- "sync"
+ "strconv"
"github.com/google/uuid"
@@ -16,7 +12,9 @@ import (
"gvisor.dev/gvisor/pkg/tcpip/transport/tcp"
"gvisor.dev/gvisor/pkg/waiter"
+ nblog "github.com/netbirdio/netbird/client/firewall/uspfilter/log"
nftypes "github.com/netbirdio/netbird/client/internal/netflow/types"
+ "github.com/netbirdio/netbird/util/netrelay"
)
// handleTCP is called by the TCP forwarder for new connections.
@@ -33,12 +31,14 @@ func (f *Forwarder) handleTCP(r *tcp.ForwarderRequest) {
}
}()
- dialAddr := fmt.Sprintf("%s:%d", f.determineDialAddr(id.LocalAddress), id.LocalPort)
+ dialAddr := net.JoinHostPort(f.determineDialAddr(id.LocalAddress).String(), strconv.Itoa(int(id.LocalPort)))
outConn, err := (&net.Dialer{}).DialContext(f.ctx, "tcp", dialAddr)
if err != nil {
r.Complete(true)
- f.logger.Trace2("forwarder: dial error for %v: %v", epID(id), err)
+ if f.logger.Enabled(nblog.LevelTrace) {
+ f.logger.Trace2("forwarder: dial error for %v: %v", epID(id), err)
+ }
return
}
@@ -61,64 +61,22 @@ func (f *Forwarder) handleTCP(r *tcp.ForwarderRequest) {
inConn := gonet.NewTCPConn(&wq, ep)
success = true
- f.logger.Trace1("forwarder: established TCP connection %v", epID(id))
+ if f.logger.Enabled(nblog.LevelTrace) {
+ f.logger.Trace1("forwarder: established TCP connection %v", epID(id))
+ }
go f.proxyTCP(id, inConn, outConn, ep, flowID)
}
func (f *Forwarder) proxyTCP(id stack.TransportEndpointID, inConn *gonet.TCPConn, outConn net.Conn, ep tcpip.Endpoint, flowID uuid.UUID) {
+ // netrelay.Relay copies bidirectionally with proper half-close propagation
+ // and fully closes both conns before returning.
+ bytesFromInToOut, bytesFromOutToIn := netrelay.Relay(f.ctx, inConn, outConn, netrelay.Options{
+ Logger: f.logger,
+ })
- ctx, cancel := context.WithCancel(f.ctx)
- defer cancel()
-
- go func() {
- <-ctx.Done()
- // Close connections and endpoint.
- if err := inConn.Close(); err != nil && !isClosedError(err) {
- f.logger.Debug1("forwarder: inConn close error: %v", err)
- }
- if err := outConn.Close(); err != nil && !isClosedError(err) {
- f.logger.Debug1("forwarder: outConn close error: %v", err)
- }
-
- ep.Close()
- }()
-
- var wg sync.WaitGroup
- wg.Add(2)
-
- var (
- bytesFromInToOut int64 // bytes from client to server (tx for client)
- bytesFromOutToIn int64 // bytes from server to client (rx for client)
- errInToOut error
- errOutToIn error
- )
-
- go func() {
- bytesFromInToOut, errInToOut = io.Copy(outConn, inConn)
- cancel()
- wg.Done()
- }()
-
- go func() {
-
- bytesFromOutToIn, errOutToIn = io.Copy(inConn, outConn)
- cancel()
- wg.Done()
- }()
-
- wg.Wait()
-
- if errInToOut != nil {
- if !isClosedError(errInToOut) {
- f.logger.Error2("proxyTCP: copy error (in โ out) for %s: %v", epID(id), errInToOut)
- }
- }
- if errOutToIn != nil {
- if !isClosedError(errOutToIn) {
- f.logger.Error2("proxyTCP: copy error (out โ in) for %s: %v", epID(id), errOutToIn)
- }
- }
+ // Close the netstack endpoint after both conns are drained.
+ ep.Close()
var rxPackets, txPackets uint64
if tcpStats, ok := ep.Stats().(*tcp.Stats); ok {
@@ -127,21 +85,22 @@ func (f *Forwarder) proxyTCP(id stack.TransportEndpointID, inConn *gonet.TCPConn
txPackets = tcpStats.SegmentsReceived.Value()
}
- f.logger.Trace5("forwarder: Removed TCP connection %s [in: %d Pkts/%d B, out: %d Pkts/%d B]", epID(id), rxPackets, bytesFromOutToIn, txPackets, bytesFromInToOut)
+ if f.logger.Enabled(nblog.LevelTrace) {
+ f.logger.Trace5("forwarder: Removed TCP connection %s [in: %d Pkts/%d B, out: %d Pkts/%d B]", epID(id), rxPackets, bytesFromOutToIn, txPackets, bytesFromInToOut)
+ }
f.sendTCPEvent(nftypes.TypeEnd, flowID, id, uint64(bytesFromOutToIn), uint64(bytesFromInToOut), rxPackets, txPackets)
}
func (f *Forwarder) sendTCPEvent(typ nftypes.Type, flowID uuid.UUID, id stack.TransportEndpointID, rxBytes, txBytes, rxPackets, txPackets uint64) {
- srcIp := netip.AddrFrom4(id.RemoteAddress.As4())
- dstIp := netip.AddrFrom4(id.LocalAddress.As4())
+ srcIp := addrToNetipAddr(id.RemoteAddress)
+ dstIp := addrToNetipAddr(id.LocalAddress)
fields := nftypes.EventFields{
- FlowID: flowID,
- Type: typ,
- Direction: nftypes.Ingress,
- Protocol: nftypes.TCP,
- // TODO: handle ipv6
+ FlowID: flowID,
+ Type: typ,
+ Direction: nftypes.Ingress,
+ Protocol: nftypes.TCP,
SourceIP: srcIp,
DestIP: dstIp,
SourcePort: id.RemotePort,
diff --git a/client/firewall/uspfilter/forwarder/udp.go b/client/firewall/uspfilter/forwarder/udp.go
index f175e275b..d840ef06b 100644
--- a/client/firewall/uspfilter/forwarder/udp.go
+++ b/client/firewall/uspfilter/forwarder/udp.go
@@ -6,7 +6,7 @@ import (
"fmt"
"io"
"net"
- "net/netip"
+ "strconv"
"sync"
"sync/atomic"
"time"
@@ -125,7 +125,9 @@ func (f *udpForwarder) cleanup() {
delete(f.conns, idle.id)
f.Unlock()
- f.logger.Trace1("forwarder: cleaned up idle UDP connection %v", epID(idle.id))
+ if f.logger.Enabled(nblog.LevelTrace) {
+ f.logger.Trace1("forwarder: cleaned up idle UDP connection %v", epID(idle.id))
+ }
}
}
}
@@ -144,7 +146,9 @@ func (f *Forwarder) handleUDP(r *udp.ForwarderRequest) bool {
_, exists := f.udpForwarder.conns[id]
f.udpForwarder.RUnlock()
if exists {
- f.logger.Trace1("forwarder: existing UDP connection for %v", epID(id))
+ if f.logger.Enabled(nblog.LevelTrace) {
+ f.logger.Trace1("forwarder: existing UDP connection for %v", epID(id))
+ }
return true
}
@@ -158,7 +162,7 @@ func (f *Forwarder) handleUDP(r *udp.ForwarderRequest) bool {
}
}()
- dstAddr := fmt.Sprintf("%s:%d", f.determineDialAddr(id.LocalAddress), id.LocalPort)
+ dstAddr := net.JoinHostPort(f.determineDialAddr(id.LocalAddress).String(), strconv.Itoa(int(id.LocalPort)))
outConn, err := (&net.Dialer{}).DialContext(f.ctx, "udp", dstAddr)
if err != nil {
f.logger.Debug2("forwarder: UDP dial error for %v: %v", epID(id), err)
@@ -206,7 +210,9 @@ func (f *Forwarder) handleUDP(r *udp.ForwarderRequest) bool {
f.udpForwarder.Unlock()
success = true
- f.logger.Trace1("forwarder: established UDP connection %v", epID(id))
+ if f.logger.Enabled(nblog.LevelTrace) {
+ f.logger.Trace1("forwarder: established UDP connection %v", epID(id))
+ }
go f.proxyUDP(connCtx, pConn, id, ep)
return true
@@ -265,7 +271,9 @@ func (f *Forwarder) proxyUDP(ctx context.Context, pConn *udpPacketConn, id stack
txPackets = udpStats.PacketsReceived.Value()
}
- f.logger.Trace5("forwarder: Removed UDP connection %s [in: %d Pkts/%d B, out: %d Pkts/%d B]", epID(id), rxPackets, rxBytes, txPackets, txBytes)
+ if f.logger.Enabled(nblog.LevelTrace) {
+ f.logger.Trace5("forwarder: Removed UDP connection %s [in: %d Pkts/%d B, out: %d Pkts/%d B]", epID(id), rxPackets, rxBytes, txPackets, txBytes)
+ }
f.udpForwarder.Lock()
delete(f.udpForwarder.conns, id)
@@ -276,15 +284,14 @@ func (f *Forwarder) proxyUDP(ctx context.Context, pConn *udpPacketConn, id stack
// sendUDPEvent stores flow events for UDP connections
func (f *Forwarder) sendUDPEvent(typ nftypes.Type, flowID uuid.UUID, id stack.TransportEndpointID, rxBytes, txBytes, rxPackets, txPackets uint64) {
- srcIp := netip.AddrFrom4(id.RemoteAddress.As4())
- dstIp := netip.AddrFrom4(id.LocalAddress.As4())
+ srcIp := addrToNetipAddr(id.RemoteAddress)
+ dstIp := addrToNetipAddr(id.LocalAddress)
fields := nftypes.EventFields{
- FlowID: flowID,
- Type: typ,
- Direction: nftypes.Ingress,
- Protocol: nftypes.UDP,
- // TODO: handle ipv6
+ FlowID: flowID,
+ Type: typ,
+ Direction: nftypes.Ingress,
+ Protocol: nftypes.UDP,
SourceIP: srcIp,
DestIP: dstIp,
SourcePort: id.RemotePort,
diff --git a/client/firewall/uspfilter/hooks_filter.go b/client/firewall/uspfilter/hooks_filter.go
index 8d3cc0f5c..f3adf5f8b 100644
--- a/client/firewall/uspfilter/hooks_filter.go
+++ b/client/firewall/uspfilter/hooks_filter.go
@@ -13,7 +13,6 @@ const (
ipv4HeaderMinLen = 20
ipv4ProtoOffset = 9
ipv4FlagsOffset = 6
- ipv4DstOffset = 16
ipProtoUDP = 17
ipProtoTCP = 6
ipv4FragOffMask = 0x1fff
diff --git a/client/firewall/uspfilter/localip.go b/client/firewall/uspfilter/localip.go
index f63fe3e45..b35be56c6 100644
--- a/client/firewall/uspfilter/localip.go
+++ b/client/firewall/uspfilter/localip.go
@@ -4,89 +4,32 @@ import (
"fmt"
"net"
"net/netip"
- "sync"
+ "sync/atomic"
log "github.com/sirupsen/logrus"
"github.com/netbirdio/netbird/client/firewall/uspfilter/common"
)
-type localIPManager struct {
- mu sync.RWMutex
-
- // fixed-size high array for upper byte of a IPv4 address
- ipv4Bitmap [256]*ipv4LowBitmap
+// localIPSnapshot is an immutable snapshot of local IP addresses, swapped
+// atomically so reads are lock-free.
+type localIPSnapshot struct {
+ ips map[netip.Addr]struct{}
}
-// ipv4LowBitmap is a map for the low 16 bits of a IPv4 address
-type ipv4LowBitmap struct {
- bitmap [8192]uint32
+type localIPManager struct {
+ snapshot atomic.Pointer[localIPSnapshot]
}
func newLocalIPManager() *localIPManager {
- return &localIPManager{}
+ m := &localIPManager{}
+ m.snapshot.Store(&localIPSnapshot{
+ ips: make(map[netip.Addr]struct{}),
+ })
+ return m
}
-func (m *localIPManager) setBitmapBit(ip net.IP) {
- ipv4 := ip.To4()
- if ipv4 == nil {
- return
- }
- high := uint16(ipv4[0])
- low := (uint16(ipv4[1]) << 8) | (uint16(ipv4[2]) << 4) | uint16(ipv4[3])
-
- index := low / 32
- bit := low % 32
-
- if m.ipv4Bitmap[high] == nil {
- m.ipv4Bitmap[high] = &ipv4LowBitmap{}
- }
-
- m.ipv4Bitmap[high].bitmap[index] |= 1 << bit
-}
-
-func (m *localIPManager) setBitInBitmap(ip netip.Addr, bitmap *[256]*ipv4LowBitmap, ipv4Set map[netip.Addr]struct{}, ipv4Addresses *[]netip.Addr) {
- if !ip.Is4() {
- return
- }
- ipv4 := ip.AsSlice()
-
- high := uint16(ipv4[0])
- low := (uint16(ipv4[1]) << 8) | (uint16(ipv4[2]) << 4) | uint16(ipv4[3])
-
- if bitmap[high] == nil {
- bitmap[high] = &ipv4LowBitmap{}
- }
-
- index := low / 32
- bit := low % 32
- bitmap[high].bitmap[index] |= 1 << bit
-
- if _, exists := ipv4Set[ip]; !exists {
- ipv4Set[ip] = struct{}{}
- *ipv4Addresses = append(*ipv4Addresses, ip)
- }
-}
-
-func (m *localIPManager) checkBitmapBit(ip []byte) bool {
- high := uint16(ip[0])
- low := (uint16(ip[1]) << 8) | (uint16(ip[2]) << 4) | uint16(ip[3])
-
- if m.ipv4Bitmap[high] == nil {
- return false
- }
-
- index := low / 32
- bit := low % 32
- return (m.ipv4Bitmap[high].bitmap[index] & (1 << bit)) != 0
-}
-
-func (m *localIPManager) processIP(ip netip.Addr, bitmap *[256]*ipv4LowBitmap, ipv4Set map[netip.Addr]struct{}, ipv4Addresses *[]netip.Addr) error {
- m.setBitInBitmap(ip, bitmap, ipv4Set, ipv4Addresses)
- return nil
-}
-
-func (m *localIPManager) processInterface(iface net.Interface, bitmap *[256]*ipv4LowBitmap, ipv4Set map[netip.Addr]struct{}, ipv4Addresses *[]netip.Addr) {
+func processInterface(iface net.Interface, ips map[netip.Addr]struct{}, addresses *[]netip.Addr) {
addrs, err := iface.Addrs()
if err != nil {
log.Debugf("get addresses for interface %s failed: %v", iface.Name, err)
@@ -104,18 +47,19 @@ func (m *localIPManager) processInterface(iface net.Interface, bitmap *[256]*ipv
continue
}
- addr, ok := netip.AddrFromSlice(ip)
+ parsed, ok := netip.AddrFromSlice(ip)
if !ok {
log.Warnf("invalid IP address %s in interface %s", ip.String(), iface.Name)
continue
}
- if err := m.processIP(addr.Unmap(), bitmap, ipv4Set, ipv4Addresses); err != nil {
- log.Debugf("process IP failed: %v", err)
- }
+ parsed = parsed.Unmap()
+ ips[parsed] = struct{}{}
+ *addresses = append(*addresses, parsed)
}
}
+// UpdateLocalIPs rebuilds the local IP snapshot and swaps it in atomically.
func (m *localIPManager) UpdateLocalIPs(iface common.IFaceMapper) (err error) {
defer func() {
if r := recover(); r != nil {
@@ -123,20 +67,20 @@ func (m *localIPManager) UpdateLocalIPs(iface common.IFaceMapper) (err error) {
}
}()
- var newIPv4Bitmap [256]*ipv4LowBitmap
- ipv4Set := make(map[netip.Addr]struct{})
- var ipv4Addresses []netip.Addr
+ ips := make(map[netip.Addr]struct{})
+ var addresses []netip.Addr
- // 127.0.0.0/8
- newIPv4Bitmap[127] = &ipv4LowBitmap{}
- for i := 0; i < 8192; i++ {
- // #nosec G602 -- bitmap is defined as [8192]uint32, loop range is correct
- newIPv4Bitmap[127].bitmap[i] = 0xFFFFFFFF
- }
+ // loopback
+ ips[netip.AddrFrom4([4]byte{127, 0, 0, 1})] = struct{}{}
+ ips[netip.IPv6Loopback()] = struct{}{}
if iface != nil {
- if err := m.processIP(iface.Address().IP, &newIPv4Bitmap, ipv4Set, &ipv4Addresses); err != nil {
- return err
+ ip := iface.Address().IP
+ ips[ip] = struct{}{}
+ addresses = append(addresses, ip)
+ if v6 := iface.Address().IPv6; v6.IsValid() {
+ ips[v6] = struct{}{}
+ addresses = append(addresses, v6)
}
}
@@ -147,25 +91,24 @@ func (m *localIPManager) UpdateLocalIPs(iface common.IFaceMapper) (err error) {
// TODO: filter out down interfaces (net.FlagUp). Also handle the reverse
// case where an interface comes up between refreshes.
for _, intf := range interfaces {
- m.processInterface(intf, &newIPv4Bitmap, ipv4Set, &ipv4Addresses)
+ processInterface(intf, ips, &addresses)
}
}
- m.mu.Lock()
- m.ipv4Bitmap = newIPv4Bitmap
- m.mu.Unlock()
+ m.snapshot.Store(&localIPSnapshot{ips: ips})
- log.Debugf("Local IPv4 addresses: %v", ipv4Addresses)
+ log.Debugf("Local IP addresses: %v", addresses)
return nil
}
+// IsLocalIP checks if the given IP is a local address. Lock-free on the read path.
func (m *localIPManager) IsLocalIP(ip netip.Addr) bool {
- if !ip.Is4() {
- return false
+ s := m.snapshot.Load()
+
+ if ip.Is4() && ip.As4()[0] == 127 {
+ return true
}
- m.mu.RLock()
- defer m.mu.RUnlock()
-
- return m.checkBitmapBit(ip.AsSlice())
+ _, found := s.ips[ip]
+ return found
}
diff --git a/client/firewall/uspfilter/localip_bench_test.go b/client/firewall/uspfilter/localip_bench_test.go
new file mode 100644
index 000000000..14e12bd08
--- /dev/null
+++ b/client/firewall/uspfilter/localip_bench_test.go
@@ -0,0 +1,72 @@
+package uspfilter
+
+import (
+ "net/netip"
+ "testing"
+
+ "github.com/netbirdio/netbird/client/iface/wgaddr"
+)
+
+func setupManager(b *testing.B) *localIPManager {
+ b.Helper()
+ m := newLocalIPManager()
+ mock := &IFaceMock{
+ AddressFunc: func() wgaddr.Address {
+ return wgaddr.Address{
+ IP: netip.MustParseAddr("100.64.0.1"),
+ Network: netip.MustParsePrefix("100.64.0.0/16"),
+ IPv6: netip.MustParseAddr("fd00::1"),
+ IPv6Net: netip.MustParsePrefix("fd00::/64"),
+ }
+ },
+ }
+ if err := m.UpdateLocalIPs(mock); err != nil {
+ b.Fatalf("UpdateLocalIPs: %v", err)
+ }
+ return m
+}
+
+func BenchmarkIsLocalIP_v4_hit(b *testing.B) {
+ m := setupManager(b)
+ ip := netip.MustParseAddr("100.64.0.1")
+ b.ResetTimer()
+ for i := 0; i < b.N; i++ {
+ m.IsLocalIP(ip)
+ }
+}
+
+func BenchmarkIsLocalIP_v4_miss(b *testing.B) {
+ m := setupManager(b)
+ ip := netip.MustParseAddr("8.8.8.8")
+ b.ResetTimer()
+ for i := 0; i < b.N; i++ {
+ m.IsLocalIP(ip)
+ }
+}
+
+func BenchmarkIsLocalIP_v6_hit(b *testing.B) {
+ m := setupManager(b)
+ ip := netip.MustParseAddr("fd00::1")
+ b.ResetTimer()
+ for i := 0; i < b.N; i++ {
+ m.IsLocalIP(ip)
+ }
+}
+
+func BenchmarkIsLocalIP_v6_miss(b *testing.B) {
+ m := setupManager(b)
+ ip := netip.MustParseAddr("2001:db8::1")
+ b.ResetTimer()
+ for i := 0; i < b.N; i++ {
+ m.IsLocalIP(ip)
+ }
+}
+
+func BenchmarkIsLocalIP_loopback(b *testing.B) {
+ m := setupManager(b)
+ ip := netip.MustParseAddr("127.0.0.1")
+ b.ResetTimer()
+ for i := 0; i < b.N; i++ {
+ m.IsLocalIP(ip)
+ }
+}
diff --git a/client/firewall/uspfilter/localip_test.go b/client/firewall/uspfilter/localip_test.go
index 6653947fa..0dc524c41 100644
--- a/client/firewall/uspfilter/localip_test.go
+++ b/client/firewall/uspfilter/localip_test.go
@@ -72,14 +72,45 @@ func TestLocalIPManager(t *testing.T) {
expected: false,
},
{
- name: "IPv6 address",
+ name: "IPv6 address matches",
setupAddr: wgaddr.Address{
- IP: netip.MustParseAddr("fe80::1"),
+ IP: netip.MustParseAddr("100.64.0.1"),
+ Network: netip.MustParsePrefix("100.64.0.0/16"),
+ IPv6: netip.MustParseAddr("fd00::1"),
+ IPv6Net: netip.MustParsePrefix("fd00::/64"),
+ },
+ testIP: netip.MustParseAddr("fd00::1"),
+ expected: true,
+ },
+ {
+ name: "IPv6 address does not match",
+ setupAddr: wgaddr.Address{
+ IP: netip.MustParseAddr("100.64.0.1"),
+ Network: netip.MustParsePrefix("100.64.0.0/16"),
+ IPv6: netip.MustParseAddr("fd00::1"),
+ IPv6Net: netip.MustParsePrefix("fd00::/64"),
+ },
+ testIP: netip.MustParseAddr("fd00::99"),
+ expected: false,
+ },
+ {
+ name: "No aliasing between similar IPs",
+ setupAddr: wgaddr.Address{
+ IP: netip.MustParseAddr("192.168.1.1"),
Network: netip.MustParsePrefix("192.168.1.0/24"),
},
- testIP: netip.MustParseAddr("fe80::1"),
+ testIP: netip.MustParseAddr("192.168.0.17"),
expected: false,
},
+ {
+ name: "IPv6 loopback",
+ setupAddr: wgaddr.Address{
+ IP: netip.MustParseAddr("100.64.0.1"),
+ Network: netip.MustParsePrefix("100.64.0.0/16"),
+ },
+ testIP: netip.MustParseAddr("::1"),
+ expected: true,
+ },
}
for _, tt := range tests {
@@ -171,90 +202,3 @@ func TestLocalIPManager_AllInterfaces(t *testing.T) {
})
}
}
-
-// MapImplementation is a version using map[string]struct{}
-type MapImplementation struct {
- localIPs map[string]struct{}
-}
-
-func BenchmarkIPChecks(b *testing.B) {
- interfaces := make([]net.IP, 16)
- for i := range interfaces {
- interfaces[i] = net.IPv4(10, 0, byte(i>>8), byte(i))
- }
-
- // Setup bitmap
- bitmapManager := newLocalIPManager()
- for _, ip := range interfaces[:8] { // Add half of IPs
- bitmapManager.setBitmapBit(ip)
- }
-
- // Setup map version
- mapManager := &MapImplementation{
- localIPs: make(map[string]struct{}),
- }
- for _, ip := range interfaces[:8] {
- mapManager.localIPs[ip.String()] = struct{}{}
- }
-
- b.Run("Bitmap_Hit", func(b *testing.B) {
- ip := interfaces[4]
- b.ResetTimer()
- for i := 0; i < b.N; i++ {
- bitmapManager.checkBitmapBit(ip)
- }
- })
-
- b.Run("Bitmap_Miss", func(b *testing.B) {
- ip := interfaces[12]
- b.ResetTimer()
- for i := 0; i < b.N; i++ {
- bitmapManager.checkBitmapBit(ip)
- }
- })
-
- b.Run("Map_Hit", func(b *testing.B) {
- ip := interfaces[4]
- b.ResetTimer()
- for i := 0; i < b.N; i++ {
- // nolint:gosimple
- _ = mapManager.localIPs[ip.String()]
- }
- })
-
- b.Run("Map_Miss", func(b *testing.B) {
- ip := interfaces[12]
- b.ResetTimer()
- for i := 0; i < b.N; i++ {
- // nolint:gosimple
- _ = mapManager.localIPs[ip.String()]
- }
- })
-}
-
-func BenchmarkWGPosition(b *testing.B) {
- wgIP := net.ParseIP("10.10.0.1")
-
- // Create two managers - one checks WG IP first, other checks it last
- b.Run("WG_First", func(b *testing.B) {
- bm := newLocalIPManager()
- bm.setBitmapBit(wgIP)
- b.ResetTimer()
- for i := 0; i < b.N; i++ {
- bm.checkBitmapBit(wgIP)
- }
- })
-
- b.Run("WG_Last", func(b *testing.B) {
- bm := newLocalIPManager()
- // Fill with other IPs first
- for i := 0; i < 15; i++ {
- bm.setBitmapBit(net.IPv4(10, 0, byte(i>>8), byte(i)))
- }
- bm.setBitmapBit(wgIP) // Add WG IP last
- b.ResetTimer()
- for i := 0; i < b.N; i++ {
- bm.checkBitmapBit(wgIP)
- }
- })
-}
diff --git a/client/firewall/uspfilter/log/log.go b/client/firewall/uspfilter/log/log.go
index c6ca55e70..03e7d4809 100644
--- a/client/firewall/uspfilter/log/log.go
+++ b/client/firewall/uspfilter/log/log.go
@@ -53,16 +53,17 @@ var levelStrings = map[Level]string{
}
type logMessage struct {
- level Level
- format string
- arg1 any
- arg2 any
- arg3 any
- arg4 any
- arg5 any
- arg6 any
- arg7 any
- arg8 any
+ level Level
+ argCount uint8
+ format string
+ arg1 any
+ arg2 any
+ arg3 any
+ arg4 any
+ arg5 any
+ arg6 any
+ arg7 any
+ arg8 any
}
// Logger is a high-performance, non-blocking logger
@@ -107,6 +108,13 @@ func (l *Logger) SetLevel(level Level) {
log.Debugf("Set uspfilter logger loglevel to %v", levelStrings[level])
}
+// Enabled reports whether the given level is currently logged. Callers on the
+// hot path should guard log sites with this to avoid boxing arguments into
+// any when the level is off.
+func (l *Logger) Enabled(level Level) bool {
+ return l.level.Load() >= uint32(level)
+}
+
func (l *Logger) Error(format string) {
if l.level.Load() >= uint32(LevelError) {
select {
@@ -155,7 +163,7 @@ func (l *Logger) Trace(format string) {
func (l *Logger) Error1(format string, arg1 any) {
if l.level.Load() >= uint32(LevelError) {
select {
- case l.msgChannel <- logMessage{level: LevelError, format: format, arg1: arg1}:
+ case l.msgChannel <- logMessage{level: LevelError, argCount: 1, format: format, arg1: arg1}:
default:
}
}
@@ -164,7 +172,16 @@ func (l *Logger) Error1(format string, arg1 any) {
func (l *Logger) Error2(format string, arg1, arg2 any) {
if l.level.Load() >= uint32(LevelError) {
select {
- case l.msgChannel <- logMessage{level: LevelError, format: format, arg1: arg1, arg2: arg2}:
+ case l.msgChannel <- logMessage{level: LevelError, argCount: 2, format: format, arg1: arg1, arg2: arg2}:
+ default:
+ }
+ }
+}
+
+func (l *Logger) Warn2(format string, arg1, arg2 any) {
+ if l.level.Load() >= uint32(LevelWarn) {
+ select {
+ case l.msgChannel <- logMessage{level: LevelWarn, argCount: 2, format: format, arg1: arg1, arg2: arg2}:
default:
}
}
@@ -173,7 +190,7 @@ func (l *Logger) Error2(format string, arg1, arg2 any) {
func (l *Logger) Warn3(format string, arg1, arg2, arg3 any) {
if l.level.Load() >= uint32(LevelWarn) {
select {
- case l.msgChannel <- logMessage{level: LevelWarn, format: format, arg1: arg1, arg2: arg2, arg3: arg3}:
+ case l.msgChannel <- logMessage{level: LevelWarn, argCount: 3, format: format, arg1: arg1, arg2: arg2, arg3: arg3}:
default:
}
}
@@ -182,7 +199,7 @@ func (l *Logger) Warn3(format string, arg1, arg2, arg3 any) {
func (l *Logger) Warn4(format string, arg1, arg2, arg3, arg4 any) {
if l.level.Load() >= uint32(LevelWarn) {
select {
- case l.msgChannel <- logMessage{level: LevelWarn, format: format, arg1: arg1, arg2: arg2, arg3: arg3, arg4: arg4}:
+ case l.msgChannel <- logMessage{level: LevelWarn, argCount: 4, format: format, arg1: arg1, arg2: arg2, arg3: arg3, arg4: arg4}:
default:
}
}
@@ -191,7 +208,7 @@ func (l *Logger) Warn4(format string, arg1, arg2, arg3, arg4 any) {
func (l *Logger) Debug1(format string, arg1 any) {
if l.level.Load() >= uint32(LevelDebug) {
select {
- case l.msgChannel <- logMessage{level: LevelDebug, format: format, arg1: arg1}:
+ case l.msgChannel <- logMessage{level: LevelDebug, argCount: 1, format: format, arg1: arg1}:
default:
}
}
@@ -200,7 +217,7 @@ func (l *Logger) Debug1(format string, arg1 any) {
func (l *Logger) Debug2(format string, arg1, arg2 any) {
if l.level.Load() >= uint32(LevelDebug) {
select {
- case l.msgChannel <- logMessage{level: LevelDebug, format: format, arg1: arg1, arg2: arg2}:
+ case l.msgChannel <- logMessage{level: LevelDebug, argCount: 2, format: format, arg1: arg1, arg2: arg2}:
default:
}
}
@@ -209,16 +226,59 @@ func (l *Logger) Debug2(format string, arg1, arg2 any) {
func (l *Logger) Debug3(format string, arg1, arg2, arg3 any) {
if l.level.Load() >= uint32(LevelDebug) {
select {
- case l.msgChannel <- logMessage{level: LevelDebug, format: format, arg1: arg1, arg2: arg2, arg3: arg3}:
+ case l.msgChannel <- logMessage{level: LevelDebug, argCount: 3, format: format, arg1: arg1, arg2: arg2, arg3: arg3}:
default:
}
}
}
+// Debugf is the variadic shape. Dispatches to Debug/Debug1/Debug2/Debug3
+// to avoid allocating an args slice on the fast path when the arg count is
+// known (0-3). Args beyond 3 land on the general variadic path; callers on
+// the hot path should prefer DebugN for known counts.
+func (l *Logger) Debugf(format string, args ...any) {
+ if l.level.Load() < uint32(LevelDebug) {
+ return
+ }
+ switch len(args) {
+ case 0:
+ l.Debug(format)
+ case 1:
+ l.Debug1(format, args[0])
+ case 2:
+ l.Debug2(format, args[0], args[1])
+ case 3:
+ l.Debug3(format, args[0], args[1], args[2])
+ default:
+ l.sendVariadic(LevelDebug, format, args)
+ }
+}
+
+// sendVariadic packs a slice of arguments into a logMessage and non-blocking
+// enqueues it. Used for arg counts beyond the fixed-arity fast paths. Args
+// beyond the 8-arg slot limit are dropped so callers don't produce silently
+// empty log lines via uint8 wraparound in argCount.
+func (l *Logger) sendVariadic(level Level, format string, args []any) {
+ const maxArgs = 8
+ n := len(args)
+ if n > maxArgs {
+ n = maxArgs
+ }
+ msg := logMessage{level: level, argCount: uint8(n), format: format}
+ slots := [maxArgs]*any{&msg.arg1, &msg.arg2, &msg.arg3, &msg.arg4, &msg.arg5, &msg.arg6, &msg.arg7, &msg.arg8}
+ for i := 0; i < n; i++ {
+ *slots[i] = args[i]
+ }
+ select {
+ case l.msgChannel <- msg:
+ default:
+ }
+}
+
func (l *Logger) Trace1(format string, arg1 any) {
if l.level.Load() >= uint32(LevelTrace) {
select {
- case l.msgChannel <- logMessage{level: LevelTrace, format: format, arg1: arg1}:
+ case l.msgChannel <- logMessage{level: LevelTrace, argCount: 1, format: format, arg1: arg1}:
default:
}
}
@@ -227,7 +287,7 @@ func (l *Logger) Trace1(format string, arg1 any) {
func (l *Logger) Trace2(format string, arg1, arg2 any) {
if l.level.Load() >= uint32(LevelTrace) {
select {
- case l.msgChannel <- logMessage{level: LevelTrace, format: format, arg1: arg1, arg2: arg2}:
+ case l.msgChannel <- logMessage{level: LevelTrace, argCount: 2, format: format, arg1: arg1, arg2: arg2}:
default:
}
}
@@ -236,7 +296,7 @@ func (l *Logger) Trace2(format string, arg1, arg2 any) {
func (l *Logger) Trace3(format string, arg1, arg2, arg3 any) {
if l.level.Load() >= uint32(LevelTrace) {
select {
- case l.msgChannel <- logMessage{level: LevelTrace, format: format, arg1: arg1, arg2: arg2, arg3: arg3}:
+ case l.msgChannel <- logMessage{level: LevelTrace, argCount: 3, format: format, arg1: arg1, arg2: arg2, arg3: arg3}:
default:
}
}
@@ -245,7 +305,7 @@ func (l *Logger) Trace3(format string, arg1, arg2, arg3 any) {
func (l *Logger) Trace4(format string, arg1, arg2, arg3, arg4 any) {
if l.level.Load() >= uint32(LevelTrace) {
select {
- case l.msgChannel <- logMessage{level: LevelTrace, format: format, arg1: arg1, arg2: arg2, arg3: arg3, arg4: arg4}:
+ case l.msgChannel <- logMessage{level: LevelTrace, argCount: 4, format: format, arg1: arg1, arg2: arg2, arg3: arg3, arg4: arg4}:
default:
}
}
@@ -254,7 +314,7 @@ func (l *Logger) Trace4(format string, arg1, arg2, arg3, arg4 any) {
func (l *Logger) Trace5(format string, arg1, arg2, arg3, arg4, arg5 any) {
if l.level.Load() >= uint32(LevelTrace) {
select {
- case l.msgChannel <- logMessage{level: LevelTrace, format: format, arg1: arg1, arg2: arg2, arg3: arg3, arg4: arg4, arg5: arg5}:
+ case l.msgChannel <- logMessage{level: LevelTrace, argCount: 5, format: format, arg1: arg1, arg2: arg2, arg3: arg3, arg4: arg4, arg5: arg5}:
default:
}
}
@@ -263,7 +323,7 @@ func (l *Logger) Trace5(format string, arg1, arg2, arg3, arg4, arg5 any) {
func (l *Logger) Trace6(format string, arg1, arg2, arg3, arg4, arg5, arg6 any) {
if l.level.Load() >= uint32(LevelTrace) {
select {
- case l.msgChannel <- logMessage{level: LevelTrace, format: format, arg1: arg1, arg2: arg2, arg3: arg3, arg4: arg4, arg5: arg5, arg6: arg6}:
+ case l.msgChannel <- logMessage{level: LevelTrace, argCount: 6, format: format, arg1: arg1, arg2: arg2, arg3: arg3, arg4: arg4, arg5: arg5, arg6: arg6}:
default:
}
}
@@ -273,7 +333,7 @@ func (l *Logger) Trace6(format string, arg1, arg2, arg3, arg4, arg5, arg6 any) {
func (l *Logger) Trace8(format string, arg1, arg2, arg3, arg4, arg5, arg6, arg7, arg8 any) {
if l.level.Load() >= uint32(LevelTrace) {
select {
- case l.msgChannel <- logMessage{level: LevelTrace, format: format, arg1: arg1, arg2: arg2, arg3: arg3, arg4: arg4, arg5: arg5, arg6: arg6, arg7: arg7, arg8: arg8}:
+ case l.msgChannel <- logMessage{level: LevelTrace, argCount: 8, format: format, arg1: arg1, arg2: arg2, arg3: arg3, arg4: arg4, arg5: arg5, arg6: arg6, arg7: arg7, arg8: arg8}:
default:
}
}
@@ -286,35 +346,8 @@ func (l *Logger) formatMessage(buf *[]byte, msg logMessage) {
*buf = append(*buf, levelStrings[msg.level]...)
*buf = append(*buf, ' ')
- // Count non-nil arguments for switch
- argCount := 0
- if msg.arg1 != nil {
- argCount++
- if msg.arg2 != nil {
- argCount++
- if msg.arg3 != nil {
- argCount++
- if msg.arg4 != nil {
- argCount++
- if msg.arg5 != nil {
- argCount++
- if msg.arg6 != nil {
- argCount++
- if msg.arg7 != nil {
- argCount++
- if msg.arg8 != nil {
- argCount++
- }
- }
- }
- }
- }
- }
- }
- }
-
var formatted string
- switch argCount {
+ switch msg.argCount {
case 0:
formatted = msg.format
case 1:
diff --git a/client/firewall/uspfilter/nat.go b/client/firewall/uspfilter/nat.go
index 8ed32eb5e..5d51c1538 100644
--- a/client/firewall/uspfilter/nat.go
+++ b/client/firewall/uspfilter/nat.go
@@ -11,10 +11,9 @@ import (
"github.com/google/gopacket/layers"
firewall "github.com/netbirdio/netbird/client/firewall/manager"
+ nblog "github.com/netbirdio/netbird/client/firewall/uspfilter/log"
)
-var ErrIPv4Only = errors.New("only IPv4 is supported for DNAT")
-
var (
errInvalidIPHeaderLength = errors.New("invalid IP header length")
)
@@ -25,10 +24,33 @@ const (
destinationPortOffset = 2
// IP address offsets in IPv4 header
- sourceIPOffset = 12
- destinationIPOffset = 16
+ ipv4SrcOffset = 12
+ ipv4DstOffset = 16
+
+ // IP address offsets in IPv6 header
+ ipv6SrcOffset = 8
+ ipv6DstOffset = 24
+
+ // IPv6 fixed header length
+ ipv6HeaderLen = 40
)
+// ipHeaderLen returns the IP header length based on the decoded layer type.
+func ipHeaderLen(d *decoder) (int, error) {
+ switch d.decoded[0] {
+ case layers.LayerTypeIPv4:
+ n := int(d.ip4.IHL) * 4
+ if n < 20 {
+ return 0, errInvalidIPHeaderLength
+ }
+ return n, nil
+ case layers.LayerTypeIPv6:
+ return ipv6HeaderLen, nil
+ default:
+ return 0, fmt.Errorf("unknown IP layer: %v", d.decoded[0])
+ }
+}
+
// ipv4Checksum calculates IPv4 header checksum.
func ipv4Checksum(header []byte) uint16 {
if len(header) < 20 {
@@ -234,19 +256,22 @@ func (m *Manager) translateOutboundDNAT(packetData []byte, d *decoder) bool {
return false
}
- dstIP := netip.AddrFrom4([4]byte{packetData[16], packetData[17], packetData[18], packetData[19]})
-
+ _, dstIP := extractPacketIPs(packetData, d)
translatedIP, exists := m.getDNATTranslation(dstIP)
if !exists {
return false
}
- if err := m.rewritePacketIP(packetData, d, translatedIP, destinationIPOffset); err != nil {
- m.logger.Error1("failed to rewrite packet destination: %v", err)
+ if err := m.rewritePacketIP(packetData, d, translatedIP, false); err != nil {
+ if m.logger.Enabled(nblog.LevelError) {
+ m.logger.Error1("failed to rewrite packet destination: %v", err)
+ }
return false
}
- m.logger.Trace2("DNAT: %s -> %s", dstIP, translatedIP)
+ if m.logger.Enabled(nblog.LevelTrace) {
+ m.logger.Trace2("DNAT: %s -> %s", dstIP, translatedIP)
+ }
return true
}
@@ -256,54 +281,115 @@ func (m *Manager) translateInboundReverse(packetData []byte, d *decoder) bool {
return false
}
- srcIP := netip.AddrFrom4([4]byte{packetData[12], packetData[13], packetData[14], packetData[15]})
-
+ srcIP, _ := extractPacketIPs(packetData, d)
originalIP, exists := m.findReverseDNATMapping(srcIP)
if !exists {
return false
}
- if err := m.rewritePacketIP(packetData, d, originalIP, sourceIPOffset); err != nil {
- m.logger.Error1("failed to rewrite packet source: %v", err)
+ if err := m.rewritePacketIP(packetData, d, originalIP, true); err != nil {
+ if m.logger.Enabled(nblog.LevelError) {
+ m.logger.Error1("failed to rewrite packet source: %v", err)
+ }
return false
}
- m.logger.Trace2("Reverse DNAT: %s -> %s", srcIP, originalIP)
+ if m.logger.Enabled(nblog.LevelTrace) {
+ m.logger.Trace2("Reverse DNAT: %s -> %s", srcIP, originalIP)
+ }
return true
}
-// rewritePacketIP replaces an IP address (source or destination) in the packet and updates checksums.
-func (m *Manager) rewritePacketIP(packetData []byte, d *decoder, newIP netip.Addr, ipOffset int) error {
+// extractPacketIPs extracts src and dst IP addresses directly from raw packet bytes.
+func extractPacketIPs(packetData []byte, d *decoder) (src, dst netip.Addr) {
+ switch d.decoded[0] {
+ case layers.LayerTypeIPv4:
+ src = netip.AddrFrom4([4]byte{packetData[ipv4SrcOffset], packetData[ipv4SrcOffset+1], packetData[ipv4SrcOffset+2], packetData[ipv4SrcOffset+3]})
+ dst = netip.AddrFrom4([4]byte{packetData[ipv4DstOffset], packetData[ipv4DstOffset+1], packetData[ipv4DstOffset+2], packetData[ipv4DstOffset+3]})
+ case layers.LayerTypeIPv6:
+ src = netip.AddrFrom16([16]byte(packetData[ipv6SrcOffset : ipv6SrcOffset+16]))
+ dst = netip.AddrFrom16([16]byte(packetData[ipv6DstOffset : ipv6DstOffset+16]))
+ }
+ return src, dst
+}
+
+// rewritePacketIP replaces a source (isSource=true) or destination IP address in the packet and updates checksums.
+func (m *Manager) rewritePacketIP(packetData []byte, d *decoder, newIP netip.Addr, isSource bool) error {
+ hdrLen, err := ipHeaderLen(d)
+ if err != nil {
+ return err
+ }
+
+ switch d.decoded[0] {
+ case layers.LayerTypeIPv4:
+ return m.rewriteIPv4(packetData, d, newIP, hdrLen, isSource)
+ case layers.LayerTypeIPv6:
+ return m.rewriteIPv6(packetData, d, newIP, hdrLen, isSource)
+ default:
+ return fmt.Errorf("unknown IP layer: %v", d.decoded[0])
+ }
+}
+
+func (m *Manager) rewriteIPv4(packetData []byte, d *decoder, newIP netip.Addr, hdrLen int, isSource bool) error {
if !newIP.Is4() {
- return ErrIPv4Only
+ return fmt.Errorf("cannot write IPv6 address into IPv4 packet")
+ }
+
+ offset := ipv4DstOffset
+ if isSource {
+ offset = ipv4SrcOffset
}
var oldIP [4]byte
- copy(oldIP[:], packetData[ipOffset:ipOffset+4])
+ copy(oldIP[:], packetData[offset:offset+4])
newIPBytes := newIP.As4()
+ copy(packetData[offset:offset+4], newIPBytes[:])
- copy(packetData[ipOffset:ipOffset+4], newIPBytes[:])
-
- ipHeaderLen := int(d.ip4.IHL) * 4
- if ipHeaderLen < 20 || ipHeaderLen > len(packetData) {
- return errInvalidIPHeaderLength
- }
-
+ // Recalculate IPv4 header checksum
binary.BigEndian.PutUint16(packetData[10:12], 0)
- ipChecksum := ipv4Checksum(packetData[:ipHeaderLen])
- binary.BigEndian.PutUint16(packetData[10:12], ipChecksum)
+ binary.BigEndian.PutUint16(packetData[10:12], ipv4Checksum(packetData[:hdrLen]))
+ // Update transport checksums incrementally
if len(d.decoded) > 1 {
switch d.decoded[1] {
case layers.LayerTypeTCP:
- m.updateTCPChecksum(packetData, ipHeaderLen, oldIP[:], newIPBytes[:])
+ m.updateTCPChecksum(packetData, hdrLen, oldIP[:], newIPBytes[:])
case layers.LayerTypeUDP:
- m.updateUDPChecksum(packetData, ipHeaderLen, oldIP[:], newIPBytes[:])
+ m.updateUDPChecksum(packetData, hdrLen, oldIP[:], newIPBytes[:])
case layers.LayerTypeICMPv4:
- m.updateICMPChecksum(packetData, ipHeaderLen)
+ m.updateICMPChecksum(packetData, hdrLen)
}
}
+ return nil
+}
+func (m *Manager) rewriteIPv6(packetData []byte, d *decoder, newIP netip.Addr, hdrLen int, isSource bool) error {
+ if !newIP.Is6() {
+ return fmt.Errorf("cannot write IPv4 address into IPv6 packet")
+ }
+
+ offset := ipv6DstOffset
+ if isSource {
+ offset = ipv6SrcOffset
+ }
+
+ var oldIP [16]byte
+ copy(oldIP[:], packetData[offset:offset+16])
+ newIPBytes := newIP.As16()
+ copy(packetData[offset:offset+16], newIPBytes[:])
+
+ // IPv6 has no header checksum, only update transport checksums
+ if len(d.decoded) > 1 {
+ switch d.decoded[1] {
+ case layers.LayerTypeTCP:
+ m.updateTCPChecksum(packetData, hdrLen, oldIP[:], newIPBytes[:])
+ case layers.LayerTypeUDP:
+ m.updateUDPChecksum(packetData, hdrLen, oldIP[:], newIPBytes[:])
+ case layers.LayerTypeICMPv6:
+ // ICMPv6 checksum includes pseudo-header with addresses, use incremental update
+ m.updateICMPv6Checksum(packetData, hdrLen, oldIP[:], newIPBytes[:])
+ }
+ }
return nil
}
@@ -351,6 +437,20 @@ func (m *Manager) updateICMPChecksum(packetData []byte, ipHeaderLen int) {
binary.BigEndian.PutUint16(icmpData[2:4], checksum)
}
+// updateICMPv6Checksum updates ICMPv6 checksum after address change.
+// ICMPv6 uses a pseudo-header (like TCP/UDP), so incremental update applies.
+func (m *Manager) updateICMPv6Checksum(packetData []byte, ipHeaderLen int, oldIP, newIP []byte) {
+ icmpStart := ipHeaderLen
+ if len(packetData) < icmpStart+4 {
+ return
+ }
+
+ checksumOffset := icmpStart + 2
+ oldChecksum := binary.BigEndian.Uint16(packetData[checksumOffset : checksumOffset+2])
+ newChecksum := incrementalUpdate(oldChecksum, oldIP, newIP)
+ binary.BigEndian.PutUint16(packetData[checksumOffset:checksumOffset+2], newChecksum)
+}
+
// incrementalUpdate performs incremental checksum update per RFC 1624.
func incrementalUpdate(oldChecksum uint16, oldBytes, newBytes []byte) uint16 {
sum := uint32(^oldChecksum)
@@ -403,14 +503,14 @@ func (m *Manager) DeleteDNATRule(rule firewall.Rule) error {
}
// addPortRedirection adds a port redirection rule.
-func (m *Manager) addPortRedirection(targetIP netip.Addr, protocol gopacket.LayerType, sourcePort, targetPort uint16) error {
+func (m *Manager) addPortRedirection(targetIP netip.Addr, protocol gopacket.LayerType, originalPort, translatedPort uint16) error {
m.portDNATMutex.Lock()
defer m.portDNATMutex.Unlock()
rule := portDNATRule{
protocol: protocol,
- origPort: sourcePort,
- targetPort: targetPort,
+ origPort: originalPort,
+ targetPort: translatedPort,
targetIP: targetIP,
}
@@ -422,7 +522,7 @@ func (m *Manager) addPortRedirection(targetIP netip.Addr, protocol gopacket.Laye
// AddInboundDNAT adds an inbound DNAT rule redirecting traffic from NetBird peers to local services.
// TODO: also delegate to nativeFirewall when available for kernel WG mode
-func (m *Manager) AddInboundDNAT(localAddr netip.Addr, protocol firewall.Protocol, sourcePort, targetPort uint16) error {
+func (m *Manager) AddInboundDNAT(localAddr netip.Addr, protocol firewall.Protocol, originalPort, translatedPort uint16) error {
var layerType gopacket.LayerType
switch protocol {
case firewall.ProtocolTCP:
@@ -433,16 +533,16 @@ func (m *Manager) AddInboundDNAT(localAddr netip.Addr, protocol firewall.Protoco
return fmt.Errorf("unsupported protocol: %s", protocol)
}
- return m.addPortRedirection(localAddr, layerType, sourcePort, targetPort)
+ return m.addPortRedirection(localAddr, layerType, originalPort, translatedPort)
}
// removePortRedirection removes a port redirection rule.
-func (m *Manager) removePortRedirection(targetIP netip.Addr, protocol gopacket.LayerType, sourcePort, targetPort uint16) error {
+func (m *Manager) removePortRedirection(targetIP netip.Addr, protocol gopacket.LayerType, originalPort, translatedPort uint16) error {
m.portDNATMutex.Lock()
defer m.portDNATMutex.Unlock()
m.portDNATRules = slices.DeleteFunc(m.portDNATRules, func(rule portDNATRule) bool {
- return rule.protocol == protocol && rule.origPort == sourcePort && rule.targetPort == targetPort && rule.targetIP.Compare(targetIP) == 0
+ return rule.protocol == protocol && rule.origPort == originalPort && rule.targetPort == translatedPort && rule.targetIP.Compare(targetIP) == 0
})
if len(m.portDNATRules) == 0 {
@@ -453,7 +553,7 @@ func (m *Manager) removePortRedirection(targetIP netip.Addr, protocol gopacket.L
}
// RemoveInboundDNAT removes an inbound DNAT rule.
-func (m *Manager) RemoveInboundDNAT(localAddr netip.Addr, protocol firewall.Protocol, sourcePort, targetPort uint16) error {
+func (m *Manager) RemoveInboundDNAT(localAddr netip.Addr, protocol firewall.Protocol, originalPort, translatedPort uint16) error {
var layerType gopacket.LayerType
switch protocol {
case firewall.ProtocolTCP:
@@ -464,23 +564,23 @@ func (m *Manager) RemoveInboundDNAT(localAddr netip.Addr, protocol firewall.Prot
return fmt.Errorf("unsupported protocol: %s", protocol)
}
- return m.removePortRedirection(localAddr, layerType, sourcePort, targetPort)
+ return m.removePortRedirection(localAddr, layerType, originalPort, translatedPort)
}
// AddOutputDNAT delegates to the native firewall if available.
-func (m *Manager) AddOutputDNAT(localAddr netip.Addr, protocol firewall.Protocol, sourcePort, targetPort uint16) error {
+func (m *Manager) AddOutputDNAT(localAddr netip.Addr, protocol firewall.Protocol, originalPort, translatedPort uint16) error {
if m.nativeFirewall == nil {
return fmt.Errorf("output DNAT not supported without native firewall")
}
- return m.nativeFirewall.AddOutputDNAT(localAddr, protocol, sourcePort, targetPort)
+ return m.nativeFirewall.AddOutputDNAT(localAddr, protocol, originalPort, translatedPort)
}
// RemoveOutputDNAT delegates to the native firewall if available.
-func (m *Manager) RemoveOutputDNAT(localAddr netip.Addr, protocol firewall.Protocol, sourcePort, targetPort uint16) error {
+func (m *Manager) RemoveOutputDNAT(localAddr netip.Addr, protocol firewall.Protocol, originalPort, translatedPort uint16) error {
if m.nativeFirewall == nil {
return nil
}
- return m.nativeFirewall.RemoveOutputDNAT(localAddr, protocol, sourcePort, targetPort)
+ return m.nativeFirewall.RemoveOutputDNAT(localAddr, protocol, originalPort, translatedPort)
}
// translateInboundPortDNAT applies port-specific DNAT translation to inbound packets.
@@ -521,7 +621,9 @@ func (m *Manager) applyPortRule(packetData []byte, d *decoder, srcIP, dstIP neti
}
if err := rewriteFn(packetData, d, rule.targetPort, destinationPortOffset); err != nil {
- m.logger.Error1("failed to rewrite port: %v", err)
+ if m.logger.Enabled(nblog.LevelError) {
+ m.logger.Error1("failed to rewrite port: %v", err)
+ }
return false
}
d.dnatOrigPort = rule.origPort
@@ -532,12 +634,12 @@ func (m *Manager) applyPortRule(packetData []byte, d *decoder, srcIP, dstIP neti
// rewriteTCPPort rewrites a TCP port (source or destination) and updates checksum.
func (m *Manager) rewriteTCPPort(packetData []byte, d *decoder, newPort uint16, portOffset int) error {
- ipHeaderLen := int(d.ip4.IHL) * 4
- if ipHeaderLen < 20 || ipHeaderLen > len(packetData) {
- return errInvalidIPHeaderLength
+ hdrLen, err := ipHeaderLen(d)
+ if err != nil {
+ return err
}
- tcpStart := ipHeaderLen
+ tcpStart := hdrLen
if len(packetData) < tcpStart+4 {
return fmt.Errorf("packet too short for TCP header")
}
@@ -563,12 +665,12 @@ func (m *Manager) rewriteTCPPort(packetData []byte, d *decoder, newPort uint16,
// rewriteUDPPort rewrites a UDP port (source or destination) and updates checksum.
func (m *Manager) rewriteUDPPort(packetData []byte, d *decoder, newPort uint16, portOffset int) error {
- ipHeaderLen := int(d.ip4.IHL) * 4
- if ipHeaderLen < 20 || ipHeaderLen > len(packetData) {
- return errInvalidIPHeaderLength
+ hdrLen, err := ipHeaderLen(d)
+ if err != nil {
+ return err
}
- udpStart := ipHeaderLen
+ udpStart := hdrLen
if len(packetData) < udpStart+8 {
return fmt.Errorf("packet too short for UDP header")
}
diff --git a/client/firewall/uspfilter/nat_bench_test.go b/client/firewall/uspfilter/nat_bench_test.go
index d2599e577..1e15c8c0c 100644
--- a/client/firewall/uspfilter/nat_bench_test.go
+++ b/client/firewall/uspfilter/nat_bench_test.go
@@ -342,12 +342,17 @@ func BenchmarkDNATMemoryAllocations(b *testing.B) {
// Parse the packet fresh each time to get a clean decoder
d := &decoder{decoded: []gopacket.LayerType{}}
- d.parser = gopacket.NewDecodingLayerParser(
+ d.parser4 = gopacket.NewDecodingLayerParser(
layers.LayerTypeIPv4,
&d.eth, &d.ip4, &d.ip6, &d.icmp4, &d.icmp6, &d.tcp, &d.udp,
)
- d.parser.IgnoreUnsupported = true
- err = d.parser.DecodeLayers(testPacket, &d.decoded)
+ d.parser4.IgnoreUnsupported = true
+ d.parser6 = gopacket.NewDecodingLayerParser(
+ layers.LayerTypeIPv6,
+ &d.eth, &d.ip4, &d.ip6, &d.icmp4, &d.icmp6, &d.tcp, &d.udp,
+ )
+ d.parser6.IgnoreUnsupported = true
+ err = d.decodePacket(testPacket)
assert.NoError(b, err)
manager.translateOutboundDNAT(testPacket, d)
@@ -371,12 +376,17 @@ func BenchmarkDirectIPExtraction(b *testing.B) {
b.Run("decoder_extraction", func(b *testing.B) {
// Create decoder once for comparison
d := &decoder{decoded: []gopacket.LayerType{}}
- d.parser = gopacket.NewDecodingLayerParser(
+ d.parser4 = gopacket.NewDecodingLayerParser(
layers.LayerTypeIPv4,
&d.eth, &d.ip4, &d.ip6, &d.icmp4, &d.icmp6, &d.tcp, &d.udp,
)
- d.parser.IgnoreUnsupported = true
- err := d.parser.DecodeLayers(packet, &d.decoded)
+ d.parser4.IgnoreUnsupported = true
+ d.parser6 = gopacket.NewDecodingLayerParser(
+ layers.LayerTypeIPv6,
+ &d.eth, &d.ip4, &d.ip6, &d.icmp4, &d.icmp6, &d.tcp, &d.udp,
+ )
+ d.parser6.IgnoreUnsupported = true
+ err := d.decodePacket(packet)
assert.NoError(b, err)
for i := 0; i < b.N; i++ {
diff --git a/client/firewall/uspfilter/nat_test.go b/client/firewall/uspfilter/nat_test.go
index 50743d006..4598c3901 100644
--- a/client/firewall/uspfilter/nat_test.go
+++ b/client/firewall/uspfilter/nat_test.go
@@ -86,13 +86,18 @@ func parsePacket(t testing.TB, packetData []byte) *decoder {
d := &decoder{
decoded: []gopacket.LayerType{},
}
- d.parser = gopacket.NewDecodingLayerParser(
+ d.parser4 = gopacket.NewDecodingLayerParser(
layers.LayerTypeIPv4,
&d.eth, &d.ip4, &d.ip6, &d.icmp4, &d.icmp6, &d.tcp, &d.udp,
)
- d.parser.IgnoreUnsupported = true
+ d.parser4.IgnoreUnsupported = true
+ d.parser6 = gopacket.NewDecodingLayerParser(
+ layers.LayerTypeIPv6,
+ &d.eth, &d.ip4, &d.ip6, &d.icmp4, &d.icmp6, &d.tcp, &d.udp,
+ )
+ d.parser6.IgnoreUnsupported = true
- err := d.parser.DecodeLayers(packetData, &d.decoded)
+ err := d.decodePacket(packetData)
require.NoError(t, err)
return d
}
diff --git a/client/firewall/uspfilter/tracer.go b/client/firewall/uspfilter/tracer.go
index 69c2519bf..696489e95 100644
--- a/client/firewall/uspfilter/tracer.go
+++ b/client/firewall/uspfilter/tracer.go
@@ -2,7 +2,9 @@ package uspfilter
import (
"fmt"
+ "net"
"net/netip"
+ "strconv"
"time"
"github.com/google/gopacket"
@@ -112,10 +114,13 @@ func (t *PacketTrace) AddResultWithForwarder(stage PacketStage, message string,
}
func (p *PacketBuilder) Build() ([]byte, error) {
- ip := p.buildIPLayer()
- pktLayers := []gopacket.SerializableLayer{ip}
+ ipLayer, err := p.buildIPLayer()
+ if err != nil {
+ return nil, err
+ }
+ pktLayers := []gopacket.SerializableLayer{ipLayer}
- transportLayer, err := p.buildTransportLayer(ip)
+ transportLayer, err := p.buildTransportLayer(ipLayer)
if err != nil {
return nil, err
}
@@ -129,30 +134,43 @@ func (p *PacketBuilder) Build() ([]byte, error) {
return serializePacket(pktLayers)
}
-func (p *PacketBuilder) buildIPLayer() *layers.IPv4 {
+func (p *PacketBuilder) buildIPLayer() (gopacket.SerializableLayer, error) {
+ if p.SrcIP.Is4() != p.DstIP.Is4() {
+ return nil, fmt.Errorf("mixed address families: src=%s dst=%s", p.SrcIP, p.DstIP)
+ }
+ proto := getIPProtocolNumber(p.Protocol, p.SrcIP.Is6())
+ if p.SrcIP.Is6() {
+ return &layers.IPv6{
+ Version: 6,
+ HopLimit: 64,
+ NextHeader: proto,
+ SrcIP: p.SrcIP.AsSlice(),
+ DstIP: p.DstIP.AsSlice(),
+ }, nil
+ }
return &layers.IPv4{
Version: 4,
TTL: 64,
- Protocol: layers.IPProtocol(getIPProtocolNumber(p.Protocol)),
+ Protocol: proto,
SrcIP: p.SrcIP.AsSlice(),
DstIP: p.DstIP.AsSlice(),
- }
+ }, nil
}
-func (p *PacketBuilder) buildTransportLayer(ip *layers.IPv4) ([]gopacket.SerializableLayer, error) {
+func (p *PacketBuilder) buildTransportLayer(ipLayer gopacket.SerializableLayer) ([]gopacket.SerializableLayer, error) {
switch p.Protocol {
case "tcp":
- return p.buildTCPLayer(ip)
+ return p.buildTCPLayer(ipLayer)
case "udp":
- return p.buildUDPLayer(ip)
+ return p.buildUDPLayer(ipLayer)
case "icmp":
- return p.buildICMPLayer()
+ return p.buildICMPLayer(ipLayer)
default:
return nil, fmt.Errorf("unsupported protocol: %s", p.Protocol)
}
}
-func (p *PacketBuilder) buildTCPLayer(ip *layers.IPv4) ([]gopacket.SerializableLayer, error) {
+func (p *PacketBuilder) buildTCPLayer(ipLayer gopacket.SerializableLayer) ([]gopacket.SerializableLayer, error) {
tcp := &layers.TCP{
SrcPort: layers.TCPPort(p.SrcPort),
DstPort: layers.TCPPort(p.DstPort),
@@ -164,24 +182,44 @@ func (p *PacketBuilder) buildTCPLayer(ip *layers.IPv4) ([]gopacket.SerializableL
PSH: p.TCPState != nil && p.TCPState.PSH,
URG: p.TCPState != nil && p.TCPState.URG,
}
- if err := tcp.SetNetworkLayerForChecksum(ip); err != nil {
- return nil, fmt.Errorf("set network layer for TCP checksum: %w", err)
+ if nl, ok := ipLayer.(gopacket.NetworkLayer); ok {
+ if err := tcp.SetNetworkLayerForChecksum(nl); err != nil {
+ return nil, fmt.Errorf("set network layer for TCP checksum: %w", err)
+ }
}
return []gopacket.SerializableLayer{tcp}, nil
}
-func (p *PacketBuilder) buildUDPLayer(ip *layers.IPv4) ([]gopacket.SerializableLayer, error) {
+func (p *PacketBuilder) buildUDPLayer(ipLayer gopacket.SerializableLayer) ([]gopacket.SerializableLayer, error) {
udp := &layers.UDP{
SrcPort: layers.UDPPort(p.SrcPort),
DstPort: layers.UDPPort(p.DstPort),
}
- if err := udp.SetNetworkLayerForChecksum(ip); err != nil {
- return nil, fmt.Errorf("set network layer for UDP checksum: %w", err)
+ if nl, ok := ipLayer.(gopacket.NetworkLayer); ok {
+ if err := udp.SetNetworkLayerForChecksum(nl); err != nil {
+ return nil, fmt.Errorf("set network layer for UDP checksum: %w", err)
+ }
}
return []gopacket.SerializableLayer{udp}, nil
}
-func (p *PacketBuilder) buildICMPLayer() ([]gopacket.SerializableLayer, error) {
+func (p *PacketBuilder) buildICMPLayer(ipLayer gopacket.SerializableLayer) ([]gopacket.SerializableLayer, error) {
+ if p.SrcIP.Is6() || p.DstIP.Is6() {
+ icmp := &layers.ICMPv6{
+ TypeCode: layers.CreateICMPv6TypeCode(p.ICMPType, p.ICMPCode),
+ }
+ if nl, ok := ipLayer.(gopacket.NetworkLayer); ok {
+ _ = icmp.SetNetworkLayerForChecksum(nl)
+ }
+ if p.ICMPType == layers.ICMPv6TypeEchoRequest || p.ICMPType == layers.ICMPv6TypeEchoReply {
+ echo := &layers.ICMPv6Echo{
+ Identifier: 1,
+ SeqNumber: 1,
+ }
+ return []gopacket.SerializableLayer{icmp, echo}, nil
+ }
+ return []gopacket.SerializableLayer{icmp}, nil
+ }
icmp := &layers.ICMPv4{
TypeCode: layers.CreateICMPv4TypeCode(p.ICMPType, p.ICMPCode),
}
@@ -204,14 +242,17 @@ func serializePacket(layers []gopacket.SerializableLayer) ([]byte, error) {
return buf.Bytes(), nil
}
-func getIPProtocolNumber(protocol fw.Protocol) int {
+func getIPProtocolNumber(protocol fw.Protocol, isV6 bool) layers.IPProtocol {
switch protocol {
case fw.ProtocolTCP:
- return int(layers.IPProtocolTCP)
+ return layers.IPProtocolTCP
case fw.ProtocolUDP:
- return int(layers.IPProtocolUDP)
+ return layers.IPProtocolUDP
case fw.ProtocolICMP:
- return int(layers.IPProtocolICMPv4)
+ if isV6 {
+ return layers.IPProtocolICMPv6
+ }
+ return layers.IPProtocolICMPv4
default:
return 0
}
@@ -234,7 +275,7 @@ func (m *Manager) TracePacket(packetData []byte, direction fw.RuleDirection) *Pa
trace := &PacketTrace{Direction: direction}
// Initial packet decoding
- if err := d.parser.DecodeLayers(packetData, &d.decoded); err != nil {
+ if err := d.decodePacket(packetData); err != nil {
trace.AddResult(StageReceived, fmt.Sprintf("Failed to decode packet: %v", err), false)
return trace
}
@@ -256,6 +297,8 @@ func (m *Manager) TracePacket(packetData []byte, direction fw.RuleDirection) *Pa
trace.DestinationPort = uint16(d.udp.DstPort)
case layers.LayerTypeICMPv4:
trace.Protocol = "ICMP"
+ case layers.LayerTypeICMPv6:
+ trace.Protocol = "ICMPv6"
}
trace.AddResult(StageReceived, fmt.Sprintf("Received %s packet: %s:%d -> %s:%d",
@@ -319,6 +362,13 @@ func (m *Manager) buildConntrackStateMessage(d *decoder) string {
flags&conntrack.TCPFin != 0)
case layers.LayerTypeICMPv4:
msg += fmt.Sprintf(" (ICMP ID=%d, Seq=%d)", d.icmp4.Id, d.icmp4.Seq)
+ case layers.LayerTypeICMPv6:
+ var id, seq uint16
+ if len(d.icmp6.Payload) >= 4 {
+ id = uint16(d.icmp6.Payload[0])<<8 | uint16(d.icmp6.Payload[1])
+ seq = uint16(d.icmp6.Payload[2])<<8 | uint16(d.icmp6.Payload[3])
+ }
+ msg += fmt.Sprintf(" (ICMPv6 ID=%d, Seq=%d)", id, seq)
}
return msg
}
@@ -395,7 +445,7 @@ func (m *Manager) handleRouteACLs(trace *PacketTrace, d *decoder, srcIP, dstIP n
trace.AddResult(StageRouteACL, msg, allowed)
if allowed && m.forwarder.Load() != nil {
- m.addForwardingResult(trace, "proxy-remote", fmt.Sprintf("%s:%d", dstIP, dstPort), true)
+ m.addForwardingResult(trace, "proxy-remote", net.JoinHostPort(dstIP.String(), strconv.Itoa(int(dstPort))), true)
}
trace.AddResult(StageCompleted, msgProcessingCompleted, allowed)
@@ -415,7 +465,7 @@ func (m *Manager) traceOutbound(packetData []byte, trace *PacketTrace) *PacketTr
d := m.decoders.Get().(*decoder)
defer m.decoders.Put(d)
- if err := d.parser.DecodeLayers(packetData, &d.decoded); err != nil {
+ if err := d.decodePacket(packetData); err != nil {
trace.AddResult(StageCompleted, "Packet dropped - decode error", false)
return trace
}
@@ -434,7 +484,7 @@ func (m *Manager) traceOutbound(packetData []byte, trace *PacketTrace) *PacketTr
func (m *Manager) handleInboundDNAT(trace *PacketTrace, packetData []byte, d *decoder, srcIP, dstIP *netip.Addr) bool {
portDNATApplied := m.traceInboundPortDNAT(trace, packetData, d)
if portDNATApplied {
- if err := d.parser.DecodeLayers(packetData, &d.decoded); err != nil {
+ if err := d.decodePacket(packetData); err != nil {
trace.AddResult(StageInboundPortDNAT, "Failed to re-decode after port DNAT", false)
return true
}
@@ -444,7 +494,7 @@ func (m *Manager) handleInboundDNAT(trace *PacketTrace, packetData []byte, d *de
nat1to1Applied := m.traceInbound1to1NAT(trace, packetData, d)
if nat1to1Applied {
- if err := d.parser.DecodeLayers(packetData, &d.decoded); err != nil {
+ if err := d.decodePacket(packetData); err != nil {
trace.AddResult(StageInbound1to1NAT, "Failed to re-decode after 1:1 NAT", false)
return true
}
@@ -509,7 +559,7 @@ func (m *Manager) traceInbound1to1NAT(trace *PacketTrace, packetData []byte, d *
return false
}
- srcIP := netip.AddrFrom4([4]byte{packetData[12], packetData[13], packetData[14], packetData[15]})
+ srcIP, _ := extractPacketIPs(packetData, d)
translated := m.translateInboundReverse(packetData, d)
if translated {
@@ -539,7 +589,7 @@ func (m *Manager) traceOutbound1to1NAT(trace *PacketTrace, packetData []byte, d
return false
}
- dstIP := netip.AddrFrom4([4]byte{packetData[16], packetData[17], packetData[18], packetData[19]})
+ _, dstIP := extractPacketIPs(packetData, d)
translated := m.translateOutboundDNAT(packetData, d)
if translated {
diff --git a/client/iface/configurer/usp.go b/client/iface/configurer/usp.go
index e3a96590c..9b070aab8 100644
--- a/client/iface/configurer/usp.go
+++ b/client/iface/configurer/usp.go
@@ -119,7 +119,7 @@ func (c *WGUSPConfigurer) UpdatePeer(peerKey string, allowedIps []netip.Prefix,
if err != nil {
return fmt.Errorf("failed to parse endpoint address: %w", err)
}
- addrPort := netip.AddrPortFrom(addr, uint16(endpoint.Port))
+ addrPort := netip.AddrPortFrom(addr.Unmap(), uint16(endpoint.Port))
c.activityRecorder.UpsertAddress(peerKey, addrPort)
}
return nil
diff --git a/client/iface/device/adapter.go b/client/iface/device/adapter.go
index 6ebc05390..e3caaf930 100644
--- a/client/iface/device/adapter.go
+++ b/client/iface/device/adapter.go
@@ -2,7 +2,7 @@ package device
// TunAdapter is an interface for create tun device from external service
type TunAdapter interface {
- ConfigureInterface(address string, mtu int, dns string, searchDomains string, routes string) (int, error)
+ ConfigureInterface(address string, addressV6 string, mtu int, dns string, searchDomains string, routes string) (int, error)
UpdateAddr(address string) error
ProtectSocket(fd int32) bool
}
diff --git a/client/iface/device/device_android.go b/client/iface/device/device_android.go
index 198343fbd..cbe88c10c 100644
--- a/client/iface/device/device_android.go
+++ b/client/iface/device/device_android.go
@@ -63,7 +63,7 @@ func (t *WGTunDevice) Create(routes []string, dns string, searchDomains []string
searchDomainsToString = ""
}
- fd, err := t.tunAdapter.ConfigureInterface(t.address.String(), int(t.mtu), dns, searchDomainsToString, routesString)
+ fd, err := t.tunAdapter.ConfigureInterface(t.address.String(), t.address.IPv6String(), int(t.mtu), dns, searchDomainsToString, routesString)
if err != nil {
log.Errorf("failed to create Android interface: %s", err)
return nil, err
diff --git a/client/iface/device/device_darwin.go b/client/iface/device/device_darwin.go
index acd5f6f11..ac8f8a51b 100644
--- a/client/iface/device/device_darwin.go
+++ b/client/iface/device/device_darwin.go
@@ -131,23 +131,32 @@ func (t *TunDevice) Device() *device.Device {
// assignAddr Adds IP address to the tunnel interface and network route based on the range provided
func (t *TunDevice) assignAddr() error {
- cmd := exec.Command("ifconfig", t.name, "inet", t.address.IP.String(), t.address.IP.String())
- if out, err := cmd.CombinedOutput(); err != nil {
- log.Errorf("adding address command '%v' failed with output: %s", cmd.String(), out)
- return err
+ if out, err := exec.Command("ifconfig", t.name, "inet", t.address.IP.String(), t.address.IP.String()).CombinedOutput(); err != nil {
+ return fmt.Errorf("add v4 address: %s: %w", string(out), err)
}
- // dummy ipv6 so routing works
- cmd = exec.Command("ifconfig", t.name, "inet6", "fe80::/64")
- if out, err := cmd.CombinedOutput(); err != nil {
- log.Debugf("adding address command '%v' failed with output: %s", cmd.String(), out)
+ // Assign a dummy link-local so macOS enables IPv6 on the tun device.
+ // When a real overlay v6 is present, use that instead.
+ v6Addr := "fe80::/64"
+ if t.address.HasIPv6() {
+ v6Addr = t.address.IPv6String()
+ }
+ if out, err := exec.Command("ifconfig", t.name, "inet6", v6Addr).CombinedOutput(); err != nil {
+ log.Warnf("failed to assign IPv6 address %s, continuing v4-only: %s: %v", v6Addr, string(out), err)
+ t.address.ClearIPv6()
}
- routeCmd := exec.Command("route", "add", "-net", t.address.Network.String(), "-interface", t.name)
- if out, err := routeCmd.CombinedOutput(); err != nil {
- log.Errorf("adding route command '%v' failed with output: %s", routeCmd.String(), out)
- return err
+ if out, err := exec.Command("route", "add", "-net", t.address.Network.String(), "-interface", t.name).CombinedOutput(); err != nil {
+ return fmt.Errorf("add route %s via %s: %s: %w", t.address.Network, t.name, string(out), err)
}
+
+ if t.address.HasIPv6() {
+ if out, err := exec.Command("route", "add", "-inet6", "-net", t.address.IPv6Net.String(), "-interface", t.name).CombinedOutput(); err != nil {
+ log.Warnf("failed to add route %s via %s, continuing v4-only: %s: %v", t.address.IPv6Net, t.name, string(out), err)
+ t.address.ClearIPv6()
+ }
+ }
+
return nil
}
diff --git a/client/iface/device/device_ios.go b/client/iface/device/device_ios.go
index aa77cee45..8368c8dce 100644
--- a/client/iface/device/device_ios.go
+++ b/client/iface/device/device_ios.go
@@ -151,8 +151,11 @@ func (t *TunDevice) MTU() uint16 {
return t.mtu
}
-func (t *TunDevice) UpdateAddr(_ wgaddr.Address) error {
- // todo implement
+// UpdateAddr updates the device address. On iOS the tunnel is managed by the
+// NetworkExtension, so we only store the new value. The extension picks up the
+// change on the next tunnel reconfiguration.
+func (t *TunDevice) UpdateAddr(addr wgaddr.Address) error {
+ t.address = addr
return nil
}
diff --git a/client/iface/device/device_kernel_unix.go b/client/iface/device/device_kernel_unix.go
index 2a836f846..25c4148a6 100644
--- a/client/iface/device/device_kernel_unix.go
+++ b/client/iface/device/device_kernel_unix.go
@@ -173,7 +173,7 @@ func (t *TunKernelDevice) FilteredDevice() *FilteredDevice {
// assignAddr Adds IP address to the tunnel interface
func (t *TunKernelDevice) assignAddr() error {
- return t.link.assignAddr(t.address)
+ return t.link.assignAddr(&t.address)
}
func (t *TunKernelDevice) GetNet() *netstack.Net {
diff --git a/client/iface/device/device_netstack.go b/client/iface/device/device_netstack.go
index 1a92b148f..b3bce3925 100644
--- a/client/iface/device/device_netstack.go
+++ b/client/iface/device/device_netstack.go
@@ -3,6 +3,7 @@ package device
import (
"errors"
"fmt"
+ "net/netip"
log "github.com/sirupsen/logrus"
"golang.zx2c4.com/wireguard/conn"
@@ -63,8 +64,12 @@ func (t *TunNetstackDevice) create() (WGConfigurer, error) {
return nil, fmt.Errorf("last ip: %w", err)
}
- log.Debugf("netstack using address: %s", t.address.IP)
- t.nsTun = nbnetstack.NewNetStackTun(t.listenAddress, t.address.IP, dnsAddr, int(t.mtu))
+ addresses := []netip.Addr{t.address.IP}
+ if t.address.HasIPv6() {
+ addresses = append(addresses, t.address.IPv6)
+ }
+ log.Debugf("netstack using addresses: %v", addresses)
+ t.nsTun = nbnetstack.NewNetStackTun(t.listenAddress, addresses, dnsAddr, int(t.mtu))
log.Debugf("netstack using dns address: %s", dnsAddr)
tunIface, net, err := t.nsTun.Create()
if err != nil {
diff --git a/client/iface/device/device_usp_unix.go b/client/iface/device/device_usp_unix.go
index 24654fc03..04c265c49 100644
--- a/client/iface/device/device_usp_unix.go
+++ b/client/iface/device/device_usp_unix.go
@@ -16,7 +16,7 @@ import (
"github.com/netbirdio/netbird/client/iface/wgaddr"
)
-type USPDevice struct {
+type TunDevice struct {
name string
address wgaddr.Address
port int
@@ -30,10 +30,10 @@ type USPDevice struct {
configurer WGConfigurer
}
-func NewUSPDevice(name string, address wgaddr.Address, port int, key string, mtu uint16, iceBind *bind.ICEBind) *USPDevice {
+func NewTunDevice(name string, address wgaddr.Address, port int, key string, mtu uint16, iceBind *bind.ICEBind) *TunDevice {
log.Infof("using userspace bind mode")
- return &USPDevice{
+ return &TunDevice{
name: name,
address: address,
port: port,
@@ -43,7 +43,7 @@ func NewUSPDevice(name string, address wgaddr.Address, port int, key string, mtu
}
}
-func (t *USPDevice) Create() (WGConfigurer, error) {
+func (t *TunDevice) Create() (WGConfigurer, error) {
log.Info("create tun interface")
tunIface, err := tun.CreateTUN(t.name, int(t.mtu))
if err != nil {
@@ -75,7 +75,7 @@ func (t *USPDevice) Create() (WGConfigurer, error) {
return t.configurer, nil
}
-func (t *USPDevice) Up() (*udpmux.UniversalUDPMuxDefault, error) {
+func (t *TunDevice) Up() (*udpmux.UniversalUDPMuxDefault, error) {
if t.device == nil {
return nil, fmt.Errorf("device is not ready yet")
}
@@ -95,12 +95,12 @@ func (t *USPDevice) Up() (*udpmux.UniversalUDPMuxDefault, error) {
return udpMux, nil
}
-func (t *USPDevice) UpdateAddr(address wgaddr.Address) error {
+func (t *TunDevice) UpdateAddr(address wgaddr.Address) error {
t.address = address
return t.assignAddr()
}
-func (t *USPDevice) Close() error {
+func (t *TunDevice) Close() error {
if t.configurer != nil {
t.configurer.Close()
}
@@ -115,39 +115,39 @@ func (t *USPDevice) Close() error {
return nil
}
-func (t *USPDevice) WgAddress() wgaddr.Address {
+func (t *TunDevice) WgAddress() wgaddr.Address {
return t.address
}
-func (t *USPDevice) MTU() uint16 {
+func (t *TunDevice) MTU() uint16 {
return t.mtu
}
-func (t *USPDevice) DeviceName() string {
+func (t *TunDevice) DeviceName() string {
return t.name
}
-func (t *USPDevice) FilteredDevice() *FilteredDevice {
+func (t *TunDevice) FilteredDevice() *FilteredDevice {
return t.filteredDevice
}
// Device returns the wireguard device
-func (t *USPDevice) Device() *device.Device {
+func (t *TunDevice) Device() *device.Device {
return t.device
}
// assignAddr Adds IP address to the tunnel interface
-func (t *USPDevice) assignAddr() error {
+func (t *TunDevice) assignAddr() error {
link := newWGLink(t.name)
- return link.assignAddr(t.address)
+ return link.assignAddr(&t.address)
}
-func (t *USPDevice) GetNet() *netstack.Net {
+func (t *TunDevice) GetNet() *netstack.Net {
return nil
}
// GetICEBind returns the ICEBind instance
-func (t *USPDevice) GetICEBind() EndpointManager {
+func (t *TunDevice) GetICEBind() EndpointManager {
return t.iceBind
}
diff --git a/client/iface/device/device_windows.go b/client/iface/device/device_windows.go
index 96350df8a..f52392fa2 100644
--- a/client/iface/device/device_windows.go
+++ b/client/iface/device/device_windows.go
@@ -87,7 +87,21 @@ func (t *TunDevice) Create() (WGConfigurer, error) {
err = nbiface.Set()
if err != nil {
t.device.Close()
- return nil, fmt.Errorf("got error when getting setting the interface mtu: %s", err)
+ return nil, fmt.Errorf("set IPv4 interface MTU: %s", err)
+ }
+
+ if t.address.HasIPv6() {
+ nbiface6, err := luid.IPInterface(windows.AF_INET6)
+ if err != nil {
+ log.Warnf("failed to get IPv6 interface for MTU, continuing v4-only: %v", err)
+ t.address.ClearIPv6()
+ } else {
+ nbiface6.NLMTU = uint32(t.mtu)
+ if err := nbiface6.Set(); err != nil {
+ log.Warnf("failed to set IPv6 interface MTU, continuing v4-only: %v", err)
+ t.address.ClearIPv6()
+ }
+ }
}
err = t.assignAddr()
if err != nil {
@@ -178,8 +192,21 @@ func (t *TunDevice) GetInterfaceGUIDString() (string, error) {
// assignAddr Adds IP address to the tunnel interface and network route based on the range provided
func (t *TunDevice) assignAddr() error {
luid := winipcfg.LUID(t.nativeTunDevice.LUID())
- log.Debugf("adding address %s to interface: %s", t.address.IP, t.name)
- return luid.SetIPAddresses([]netip.Prefix{netip.MustParsePrefix(t.address.String())})
+
+ v4Prefix := t.address.Prefix()
+ if t.address.HasIPv6() {
+ v6Prefix := t.address.IPv6Prefix()
+ log.Debugf("adding addresses %s, %s to interface: %s", v4Prefix, v6Prefix, t.name)
+ if err := luid.SetIPAddresses([]netip.Prefix{v4Prefix, v6Prefix}); err != nil {
+ log.Warnf("failed to assign dual-stack addresses, retrying v4-only: %v", err)
+ t.address.ClearIPv6()
+ return luid.SetIPAddresses([]netip.Prefix{v4Prefix})
+ }
+ return nil
+ }
+
+ log.Debugf("adding address %s to interface: %s", v4Prefix, t.name)
+ return luid.SetIPAddresses([]netip.Prefix{v4Prefix})
}
func (t *TunDevice) GetNet() *netstack.Net {
diff --git a/client/iface/device/kernel_module.go b/client/iface/device/kernel_module.go
deleted file mode 100644
index 1bdd6f7c6..000000000
--- a/client/iface/device/kernel_module.go
+++ /dev/null
@@ -1,8 +0,0 @@
-//go:build (!linux && !freebsd) || android
-
-package device
-
-// WireGuardModuleIsLoaded check if we can load WireGuard mod (linux only)
-func WireGuardModuleIsLoaded() bool {
- return false
-}
diff --git a/client/iface/device/kernel_module_freebsd.go b/client/iface/device/kernel_module_freebsd.go
deleted file mode 100644
index dd6c8b408..000000000
--- a/client/iface/device/kernel_module_freebsd.go
+++ /dev/null
@@ -1,18 +0,0 @@
-package device
-
-// WireGuardModuleIsLoaded check if kernel support wireguard
-func WireGuardModuleIsLoaded() bool {
- // Despite the fact FreeBSD natively support Wireguard (https://github.com/WireGuard/wireguard-freebsd)
- // we are currently do not use it, since it is required to add wireguard kernel support to
- // - https://github.com/netbirdio/netbird/tree/main/sharedsock
- // - https://github.com/mdlayher/socket
- // TODO: implement kernel space
- return false
-}
-
-// ModuleTunIsLoaded check if tun module exist, if is not attempt to load it
-func ModuleTunIsLoaded() bool {
- // Assume tun supported by freebsd kernel by default
- // TODO: implement check for module loaded in kernel or build-it
- return true
-}
diff --git a/client/iface/device/kernel_module_nonlinux.go b/client/iface/device/kernel_module_nonlinux.go
new file mode 100644
index 000000000..58d97080b
--- /dev/null
+++ b/client/iface/device/kernel_module_nonlinux.go
@@ -0,0 +1,13 @@
+//go:build !linux || android
+
+package device
+
+// WireGuardModuleIsLoaded reports whether the kernel WireGuard module is available.
+func WireGuardModuleIsLoaded() bool {
+ return false
+}
+
+// ModuleTunIsLoaded reports whether the tun device is available.
+func ModuleTunIsLoaded() bool {
+ return true
+}
diff --git a/client/iface/device/wg_link_freebsd.go b/client/iface/device/wg_link_freebsd.go
index 1b06e0e15..87df89183 100644
--- a/client/iface/device/wg_link_freebsd.go
+++ b/client/iface/device/wg_link_freebsd.go
@@ -2,6 +2,7 @@ package device
import (
"fmt"
+ "os/exec"
log "github.com/sirupsen/logrus"
@@ -57,32 +58,32 @@ func (l *wgLink) up() error {
return nil
}
-func (l *wgLink) assignAddr(address wgaddr.Address) error {
+func (l *wgLink) assignAddr(address *wgaddr.Address) error {
link, err := freebsd.LinkByName(l.name)
if err != nil {
return fmt.Errorf("link by name: %w", err)
}
- ip := address.IP.String()
-
- // Convert prefix length to hex netmask
prefixLen := address.Network.Bits()
- if !address.IP.Is4() {
- return fmt.Errorf("IPv6 not supported for interface assignment")
- }
-
maskBits := uint32(0xffffffff) << (32 - prefixLen)
mask := fmt.Sprintf("0x%08x", maskBits)
- log.Infof("assign addr %s mask %s to %s interface", ip, mask, l.name)
+ log.Infof("assign addr %s mask %s to %s interface", address.IP, mask, l.name)
- err = link.AssignAddr(ip, mask)
- if err != nil {
+ if err := link.AssignAddr(address.IP.String(), mask); err != nil {
return fmt.Errorf("assign addr: %w", err)
}
- err = link.Up()
- if err != nil {
+ if address.HasIPv6() {
+ log.Infof("assign IPv6 addr %s to %s interface", address.IPv6String(), l.name)
+ cmd := exec.Command("ifconfig", l.name, "inet6", address.IPv6String())
+ if out, err := cmd.CombinedOutput(); err != nil {
+ log.Warnf("failed to assign IPv6 address %s to %s, continuing v4-only: %s: %v", address.IPv6String(), l.name, string(out), err)
+ address.ClearIPv6()
+ }
+ }
+
+ if err := link.Up(); err != nil {
return fmt.Errorf("up: %w", err)
}
diff --git a/client/iface/device/wg_link_linux.go b/client/iface/device/wg_link_linux.go
index d941cd022..6a02cb356 100644
--- a/client/iface/device/wg_link_linux.go
+++ b/client/iface/device/wg_link_linux.go
@@ -4,6 +4,8 @@ package device
import (
"fmt"
+ "net"
+ "net/netip"
"os"
log "github.com/sirupsen/logrus"
@@ -92,7 +94,7 @@ func (l *wgLink) up() error {
return nil
}
-func (l *wgLink) assignAddr(address wgaddr.Address) error {
+func (l *wgLink) assignAddr(address *wgaddr.Address) error {
//delete existing addresses
list, err := netlink.AddrList(l, 0)
if err != nil {
@@ -110,20 +112,16 @@ func (l *wgLink) assignAddr(address wgaddr.Address) error {
}
name := l.attrs.Name
- addrStr := address.String()
- log.Debugf("adding address %s to interface: %s", addrStr, name)
-
- addr, err := netlink.ParseAddr(addrStr)
- if err != nil {
- return fmt.Errorf("parse addr: %w", err)
+ if err := l.addAddr(name, address.Prefix()); err != nil {
+ return err
}
- err = netlink.AddrAdd(l, addr)
- if os.IsExist(err) {
- log.Infof("interface %s already has the address: %s", name, addrStr)
- } else if err != nil {
- return fmt.Errorf("add addr: %w", err)
+ if address.HasIPv6() {
+ if err := l.addAddr(name, address.IPv6Prefix()); err != nil {
+ log.Warnf("failed to assign IPv6 address %s to %s, continuing v4-only: %v", address.IPv6Prefix(), name, err)
+ address.ClearIPv6()
+ }
}
// On linux, the link must be brought up
@@ -133,3 +131,22 @@ func (l *wgLink) assignAddr(address wgaddr.Address) error {
return nil
}
+
+func (l *wgLink) addAddr(ifaceName string, prefix netip.Prefix) error {
+ log.Debugf("adding address %s to interface: %s", prefix, ifaceName)
+
+ addr := &netlink.Addr{
+ IPNet: &net.IPNet{
+ IP: prefix.Addr().AsSlice(),
+ Mask: net.CIDRMask(prefix.Bits(), prefix.Addr().BitLen()),
+ },
+ }
+
+ if err := netlink.AddrAdd(l, addr); os.IsExist(err) {
+ log.Infof("interface %s already has the address: %s", ifaceName, prefix)
+ } else if err != nil {
+ return fmt.Errorf("add addr %s: %w", prefix, err)
+ }
+
+ return nil
+}
diff --git a/client/iface/iface.go b/client/iface/iface.go
index 655dd1682..78c5080e7 100644
--- a/client/iface/iface.go
+++ b/client/iface/iface.go
@@ -57,7 +57,7 @@ type wgProxyFactory interface {
type WGIFaceOpts struct {
IFaceName string
- Address string
+ Address wgaddr.Address
WGPort int
WGPrivKey string
MTU uint16
@@ -141,16 +141,11 @@ func (w *WGIface) Up() (*udpmux.UniversalUDPMuxDefault, error) {
}
// UpdateAddr updates address of the interface
-func (w *WGIface) UpdateAddr(newAddr string) error {
+func (w *WGIface) UpdateAddr(newAddr wgaddr.Address) error {
w.mu.Lock()
defer w.mu.Unlock()
- addr, err := wgaddr.ParseWGAddress(newAddr)
- if err != nil {
- return err
- }
-
- return w.tun.UpdateAddr(addr)
+ return w.tun.UpdateAddr(newAddr)
}
// UpdatePeer updates existing Wireguard Peer or creates a new one if doesn't exist
diff --git a/client/iface/iface_new_windows.go b/client/iface/iface_new.go
similarity index 50%
rename from client/iface/iface_new_windows.go
rename to client/iface/iface_new.go
index dfd9028e7..28f350e3f 100644
--- a/client/iface/iface_new_windows.go
+++ b/client/iface/iface_new.go
@@ -1,33 +1,28 @@
+//go:build !linux && !ios && !android && !js
+
package iface
import (
"github.com/netbirdio/netbird/client/iface/bind"
"github.com/netbirdio/netbird/client/iface/device"
"github.com/netbirdio/netbird/client/iface/netstack"
- wgaddr "github.com/netbirdio/netbird/client/iface/wgaddr"
"github.com/netbirdio/netbird/client/iface/wgproxy"
)
// NewWGIFace Creates a new WireGuard interface instance
func NewWGIFace(opts WGIFaceOpts) (*WGIface, error) {
- wgAddress, err := wgaddr.ParseWGAddress(opts.Address)
- if err != nil {
- return nil, err
- }
- iceBind := bind.NewICEBind(opts.TransportNet, opts.FilterFn, wgAddress, opts.MTU)
+ iceBind := bind.NewICEBind(opts.TransportNet, opts.FilterFn, opts.Address, opts.MTU)
var tun WGTunDevice
if netstack.IsEnabled() {
- tun = device.NewNetstackDevice(opts.IFaceName, wgAddress, opts.WGPort, opts.WGPrivKey, opts.MTU, iceBind, netstack.ListenAddr())
+ tun = device.NewNetstackDevice(opts.IFaceName, opts.Address, opts.WGPort, opts.WGPrivKey, opts.MTU, iceBind, netstack.ListenAddr())
} else {
- tun = device.NewTunDevice(opts.IFaceName, wgAddress, opts.WGPort, opts.WGPrivKey, opts.MTU, iceBind)
+ tun = device.NewTunDevice(opts.IFaceName, opts.Address, opts.WGPort, opts.WGPrivKey, opts.MTU, iceBind)
}
- wgIFace := &WGIface{
+ return &WGIface{
userspaceBind: true,
tun: tun,
wgProxyFactory: wgproxy.NewUSPFactory(iceBind, opts.MTU),
- }
- return wgIFace, nil
-
+ }, nil
}
diff --git a/client/iface/iface_new_android.go b/client/iface/iface_new_android.go
index 3b68f63f2..e28dcc0de 100644
--- a/client/iface/iface_new_android.go
+++ b/client/iface/iface_new_android.go
@@ -4,23 +4,17 @@ import (
"github.com/netbirdio/netbird/client/iface/bind"
"github.com/netbirdio/netbird/client/iface/device"
"github.com/netbirdio/netbird/client/iface/netstack"
- "github.com/netbirdio/netbird/client/iface/wgaddr"
"github.com/netbirdio/netbird/client/iface/wgproxy"
)
// NewWGIFace Creates a new WireGuard interface instance
func NewWGIFace(opts WGIFaceOpts) (*WGIface, error) {
- wgAddress, err := wgaddr.ParseWGAddress(opts.Address)
- if err != nil {
- return nil, err
- }
-
- iceBind := bind.NewICEBind(opts.TransportNet, opts.FilterFn, wgAddress, opts.MTU)
+ iceBind := bind.NewICEBind(opts.TransportNet, opts.FilterFn, opts.Address, opts.MTU)
if netstack.IsEnabled() {
wgIFace := &WGIface{
userspaceBind: true,
- tun: device.NewNetstackDevice(opts.IFaceName, wgAddress, opts.WGPort, opts.WGPrivKey, opts.MTU, iceBind, netstack.ListenAddr()),
+ tun: device.NewNetstackDevice(opts.IFaceName, opts.Address, opts.WGPort, opts.WGPrivKey, opts.MTU, iceBind, netstack.ListenAddr()),
wgProxyFactory: wgproxy.NewUSPFactory(iceBind, opts.MTU),
}
return wgIFace, nil
@@ -28,7 +22,7 @@ func NewWGIFace(opts WGIFaceOpts) (*WGIface, error) {
wgIFace := &WGIface{
userspaceBind: true,
- tun: device.NewTunDevice(wgAddress, opts.WGPort, opts.WGPrivKey, opts.MTU, iceBind, opts.MobileArgs.TunAdapter, opts.DisableDNS),
+ tun: device.NewTunDevice(opts.Address, opts.WGPort, opts.WGPrivKey, opts.MTU, iceBind, opts.MobileArgs.TunAdapter, opts.DisableDNS),
wgProxyFactory: wgproxy.NewUSPFactory(iceBind, opts.MTU),
}
return wgIFace, nil
diff --git a/client/iface/iface_new_darwin.go b/client/iface/iface_new_darwin.go
deleted file mode 100644
index 9f21ec950..000000000
--- a/client/iface/iface_new_darwin.go
+++ /dev/null
@@ -1,35 +0,0 @@
-//go:build !ios
-
-package iface
-
-import (
- "github.com/netbirdio/netbird/client/iface/bind"
- "github.com/netbirdio/netbird/client/iface/device"
- "github.com/netbirdio/netbird/client/iface/netstack"
- "github.com/netbirdio/netbird/client/iface/wgaddr"
- "github.com/netbirdio/netbird/client/iface/wgproxy"
-)
-
-// NewWGIFace Creates a new WireGuard interface instance
-func NewWGIFace(opts WGIFaceOpts) (*WGIface, error) {
- wgAddress, err := wgaddr.ParseWGAddress(opts.Address)
- if err != nil {
- return nil, err
- }
-
- iceBind := bind.NewICEBind(opts.TransportNet, opts.FilterFn, wgAddress, opts.MTU)
-
- var tun WGTunDevice
- if netstack.IsEnabled() {
- tun = device.NewNetstackDevice(opts.IFaceName, wgAddress, opts.WGPort, opts.WGPrivKey, opts.MTU, iceBind, netstack.ListenAddr())
- } else {
- tun = device.NewTunDevice(opts.IFaceName, wgAddress, opts.WGPort, opts.WGPrivKey, opts.MTU, iceBind)
- }
-
- wgIFace := &WGIface{
- userspaceBind: true,
- tun: tun,
- wgProxyFactory: wgproxy.NewUSPFactory(iceBind, opts.MTU),
- }
- return wgIFace, nil
-}
diff --git a/client/iface/iface_new_freebsd.go b/client/iface/iface_new_freebsd.go
deleted file mode 100644
index a342bd579..000000000
--- a/client/iface/iface_new_freebsd.go
+++ /dev/null
@@ -1,41 +0,0 @@
-//go:build freebsd
-
-package iface
-
-import (
- "fmt"
-
- "github.com/netbirdio/netbird/client/iface/bind"
- "github.com/netbirdio/netbird/client/iface/device"
- "github.com/netbirdio/netbird/client/iface/netstack"
- "github.com/netbirdio/netbird/client/iface/wgaddr"
- "github.com/netbirdio/netbird/client/iface/wgproxy"
-)
-
-// NewWGIFace Creates a new WireGuard interface instance
-func NewWGIFace(opts WGIFaceOpts) (*WGIface, error) {
- wgAddress, err := wgaddr.ParseWGAddress(opts.Address)
- if err != nil {
- return nil, err
- }
-
- wgIFace := &WGIface{}
-
- if netstack.IsEnabled() {
- iceBind := bind.NewICEBind(opts.TransportNet, opts.FilterFn, wgAddress, opts.MTU)
- wgIFace.tun = device.NewNetstackDevice(opts.IFaceName, wgAddress, opts.WGPort, opts.WGPrivKey, opts.MTU, iceBind, netstack.ListenAddr())
- wgIFace.userspaceBind = true
- wgIFace.wgProxyFactory = wgproxy.NewUSPFactory(iceBind, opts.MTU)
- return wgIFace, nil
- }
-
- if device.ModuleTunIsLoaded() {
- iceBind := bind.NewICEBind(opts.TransportNet, opts.FilterFn, wgAddress, opts.MTU)
- wgIFace.tun = device.NewUSPDevice(opts.IFaceName, wgAddress, opts.WGPort, opts.WGPrivKey, opts.MTU, iceBind)
- wgIFace.userspaceBind = true
- wgIFace.wgProxyFactory = wgproxy.NewUSPFactory(iceBind, opts.MTU)
- return wgIFace, nil
- }
-
- return nil, fmt.Errorf("couldn't check or load tun module")
-}
diff --git a/client/iface/iface_new_ios.go b/client/iface/iface_new_ios.go
index 5d6a32e39..41e0022b2 100644
--- a/client/iface/iface_new_ios.go
+++ b/client/iface/iface_new_ios.go
@@ -5,21 +5,15 @@ package iface
import (
"github.com/netbirdio/netbird/client/iface/bind"
"github.com/netbirdio/netbird/client/iface/device"
- "github.com/netbirdio/netbird/client/iface/wgaddr"
"github.com/netbirdio/netbird/client/iface/wgproxy"
)
// NewWGIFace Creates a new WireGuard interface instance
func NewWGIFace(opts WGIFaceOpts) (*WGIface, error) {
- wgAddress, err := wgaddr.ParseWGAddress(opts.Address)
- if err != nil {
- return nil, err
- }
-
- iceBind := bind.NewICEBind(opts.TransportNet, opts.FilterFn, wgAddress, opts.MTU)
+ iceBind := bind.NewICEBind(opts.TransportNet, opts.FilterFn, opts.Address, opts.MTU)
wgIFace := &WGIface{
- tun: device.NewTunDevice(opts.IFaceName, wgAddress, opts.WGPort, opts.WGPrivKey, opts.MTU, iceBind, opts.MobileArgs.TunFd),
+ tun: device.NewTunDevice(opts.IFaceName, opts.Address, opts.WGPort, opts.WGPrivKey, opts.MTU, iceBind, opts.MobileArgs.TunFd),
userspaceBind: true,
wgProxyFactory: wgproxy.NewUSPFactory(iceBind, opts.MTU),
}
diff --git a/client/iface/iface_new_js.go b/client/iface/iface_new_js.go
index ad913ab04..9f7a3ba62 100644
--- a/client/iface/iface_new_js.go
+++ b/client/iface/iface_new_js.go
@@ -4,21 +4,15 @@ import (
"github.com/netbirdio/netbird/client/iface/bind"
"github.com/netbirdio/netbird/client/iface/device"
"github.com/netbirdio/netbird/client/iface/netstack"
- "github.com/netbirdio/netbird/client/iface/wgaddr"
"github.com/netbirdio/netbird/client/iface/wgproxy"
)
// NewWGIFace creates a new WireGuard interface for WASM (always uses netstack mode)
func NewWGIFace(opts WGIFaceOpts) (*WGIface, error) {
- wgAddress, err := wgaddr.ParseWGAddress(opts.Address)
- if err != nil {
- return nil, err
- }
-
relayBind := bind.NewRelayBindJS()
wgIface := &WGIface{
- tun: device.NewNetstackDevice(opts.IFaceName, wgAddress, opts.WGPort, opts.WGPrivKey, opts.MTU, relayBind, netstack.ListenAddr()),
+ tun: device.NewNetstackDevice(opts.IFaceName, opts.Address, opts.WGPort, opts.WGPrivKey, opts.MTU, relayBind, netstack.ListenAddr()),
userspaceBind: true,
wgProxyFactory: wgproxy.NewUSPFactory(relayBind, opts.MTU),
}
diff --git a/client/iface/iface_new_linux.go b/client/iface/iface_new_linux.go
index d84035403..65ce67e88 100644
--- a/client/iface/iface_new_linux.go
+++ b/client/iface/iface_new_linux.go
@@ -3,44 +3,40 @@
package iface
import (
- "fmt"
+ "errors"
"github.com/netbirdio/netbird/client/iface/bind"
"github.com/netbirdio/netbird/client/iface/device"
"github.com/netbirdio/netbird/client/iface/netstack"
- "github.com/netbirdio/netbird/client/iface/wgaddr"
"github.com/netbirdio/netbird/client/iface/wgproxy"
)
// NewWGIFace Creates a new WireGuard interface instance
func NewWGIFace(opts WGIFaceOpts) (*WGIface, error) {
- wgAddress, err := wgaddr.ParseWGAddress(opts.Address)
- if err != nil {
- return nil, err
- }
-
- wgIFace := &WGIface{}
-
if netstack.IsEnabled() {
- iceBind := bind.NewICEBind(opts.TransportNet, opts.FilterFn, wgAddress, opts.MTU)
- wgIFace.tun = device.NewNetstackDevice(opts.IFaceName, wgAddress, opts.WGPort, opts.WGPrivKey, opts.MTU, iceBind, netstack.ListenAddr())
- wgIFace.userspaceBind = true
- wgIFace.wgProxyFactory = wgproxy.NewUSPFactory(iceBind, opts.MTU)
- return wgIFace, nil
+ iceBind := bind.NewICEBind(opts.TransportNet, opts.FilterFn, opts.Address, opts.MTU)
+ return &WGIface{
+ tun: device.NewNetstackDevice(opts.IFaceName, opts.Address, opts.WGPort, opts.WGPrivKey, opts.MTU, iceBind, netstack.ListenAddr()),
+ userspaceBind: true,
+ wgProxyFactory: wgproxy.NewUSPFactory(iceBind, opts.MTU),
+ }, nil
}
if device.WireGuardModuleIsLoaded() {
- wgIFace.tun = device.NewKernelDevice(opts.IFaceName, wgAddress, opts.WGPort, opts.WGPrivKey, opts.MTU, opts.TransportNet)
- wgIFace.wgProxyFactory = wgproxy.NewKernelFactory(opts.WGPort, opts.MTU)
- return wgIFace, nil
- }
- if device.ModuleTunIsLoaded() {
- iceBind := bind.NewICEBind(opts.TransportNet, opts.FilterFn, wgAddress, opts.MTU)
- wgIFace.tun = device.NewUSPDevice(opts.IFaceName, wgAddress, opts.WGPort, opts.WGPrivKey, opts.MTU, iceBind)
- wgIFace.userspaceBind = true
- wgIFace.wgProxyFactory = wgproxy.NewUSPFactory(iceBind, opts.MTU)
- return wgIFace, nil
+ return &WGIface{
+ tun: device.NewKernelDevice(opts.IFaceName, opts.Address, opts.WGPort, opts.WGPrivKey, opts.MTU, opts.TransportNet),
+ wgProxyFactory: wgproxy.NewKernelFactory(opts.WGPort, opts.MTU),
+ }, nil
}
- return nil, fmt.Errorf("couldn't check or load tun module")
+ if device.ModuleTunIsLoaded() {
+ iceBind := bind.NewICEBind(opts.TransportNet, opts.FilterFn, opts.Address, opts.MTU)
+ return &WGIface{
+ tun: device.NewTunDevice(opts.IFaceName, opts.Address, opts.WGPort, opts.WGPrivKey, opts.MTU, iceBind),
+ userspaceBind: true,
+ wgProxyFactory: wgproxy.NewUSPFactory(iceBind, opts.MTU),
+ }, nil
+ }
+
+ return nil, errors.New("tun module not available")
}
diff --git a/client/iface/iface_test.go b/client/iface/iface_test.go
index 6bbfeaa63..dbeb69bc6 100644
--- a/client/iface/iface_test.go
+++ b/client/iface/iface_test.go
@@ -16,6 +16,7 @@ import (
"golang.zx2c4.com/wireguard/wgctrl/wgtypes"
"github.com/netbirdio/netbird/client/iface/device"
+ "github.com/netbirdio/netbird/client/iface/wgaddr"
"github.com/netbirdio/netbird/client/internal/stdnet"
)
@@ -48,7 +49,7 @@ func TestWGIface_UpdateAddr(t *testing.T) {
opts := WGIFaceOpts{
IFaceName: ifaceName,
- Address: addr,
+ Address: wgaddr.MustParseWGAddress(addr),
WGPort: wgPort,
WGPrivKey: key,
MTU: DefaultMTU,
@@ -84,7 +85,7 @@ func TestWGIface_UpdateAddr(t *testing.T) {
//update WireGuard address
addr = "100.64.0.2/8"
- err = iface.UpdateAddr(addr)
+ err = iface.UpdateAddr(wgaddr.MustParseWGAddress(addr))
if err != nil {
t.Fatal(err)
}
@@ -130,7 +131,7 @@ func Test_CreateInterface(t *testing.T) {
}
opts := WGIFaceOpts{
IFaceName: ifaceName,
- Address: wgIP,
+ Address: wgaddr.MustParseWGAddress(wgIP),
WGPort: 33100,
WGPrivKey: key,
MTU: DefaultMTU,
@@ -174,7 +175,7 @@ func Test_Close(t *testing.T) {
opts := WGIFaceOpts{
IFaceName: ifaceName,
- Address: wgIP,
+ Address: wgaddr.MustParseWGAddress(wgIP),
WGPort: wgPort,
WGPrivKey: key,
MTU: DefaultMTU,
@@ -219,7 +220,7 @@ func TestRecreation(t *testing.T) {
opts := WGIFaceOpts{
IFaceName: ifaceName,
- Address: wgIP,
+ Address: wgaddr.MustParseWGAddress(wgIP),
WGPort: wgPort,
WGPrivKey: key,
MTU: DefaultMTU,
@@ -291,7 +292,7 @@ func Test_ConfigureInterface(t *testing.T) {
}
opts := WGIFaceOpts{
IFaceName: ifaceName,
- Address: wgIP,
+ Address: wgaddr.MustParseWGAddress(wgIP),
WGPort: wgPort,
WGPrivKey: key,
MTU: DefaultMTU,
@@ -347,7 +348,7 @@ func Test_UpdatePeer(t *testing.T) {
opts := WGIFaceOpts{
IFaceName: ifaceName,
- Address: wgIP,
+ Address: wgaddr.MustParseWGAddress(wgIP),
WGPort: 33100,
WGPrivKey: key,
MTU: DefaultMTU,
@@ -417,7 +418,7 @@ func Test_RemovePeer(t *testing.T) {
opts := WGIFaceOpts{
IFaceName: ifaceName,
- Address: wgIP,
+ Address: wgaddr.MustParseWGAddress(wgIP),
WGPort: 33100,
WGPrivKey: key,
MTU: DefaultMTU,
@@ -482,7 +483,7 @@ func Test_ConnectPeers(t *testing.T) {
optsPeer1 := WGIFaceOpts{
IFaceName: peer1ifaceName,
- Address: peer1wgIP.String(),
+ Address: wgaddr.MustParseWGAddress(peer1wgIP.String()),
WGPort: peer1wgPort,
WGPrivKey: peer1Key.String(),
MTU: DefaultMTU,
@@ -522,7 +523,7 @@ func Test_ConnectPeers(t *testing.T) {
optsPeer2 := WGIFaceOpts{
IFaceName: peer2ifaceName,
- Address: peer2wgIP.String(),
+ Address: wgaddr.MustParseWGAddress(peer2wgIP.String()),
WGPort: peer2wgPort,
WGPrivKey: peer2Key.String(),
MTU: DefaultMTU,
diff --git a/client/iface/netstack/tun.go b/client/iface/netstack/tun.go
index 346ae29ec..8c7526bbb 100644
--- a/client/iface/netstack/tun.go
+++ b/client/iface/netstack/tun.go
@@ -13,7 +13,7 @@ import (
const EnvSkipProxy = "NB_NETSTACK_SKIP_PROXY"
type NetStackTun struct { //nolint:revive
- address netip.Addr
+ addresses []netip.Addr
dnsAddress netip.Addr
mtu int
listenAddress string
@@ -22,9 +22,9 @@ type NetStackTun struct { //nolint:revive
tundev tun.Device
}
-func NewNetStackTun(listenAddress string, address netip.Addr, dnsAddress netip.Addr, mtu int) *NetStackTun {
+func NewNetStackTun(listenAddress string, addresses []netip.Addr, dnsAddress netip.Addr, mtu int) *NetStackTun {
return &NetStackTun{
- address: address,
+ addresses: addresses,
dnsAddress: dnsAddress,
mtu: mtu,
listenAddress: listenAddress,
@@ -33,7 +33,7 @@ func NewNetStackTun(listenAddress string, address netip.Addr, dnsAddress netip.A
func (t *NetStackTun) Create() (tun.Device, *netstack.Net, error) {
nsTunDev, tunNet, err := netstack.CreateNetTUN(
- []netip.Addr{t.address},
+ t.addresses,
[]netip.Addr{t.dnsAddress},
t.mtu)
if err != nil {
diff --git a/client/iface/wgaddr/address.go b/client/iface/wgaddr/address.go
index 078f8be95..43d1ec9aa 100644
--- a/client/iface/wgaddr/address.go
+++ b/client/iface/wgaddr/address.go
@@ -3,12 +3,18 @@ package wgaddr
import (
"fmt"
"net/netip"
+
+ "github.com/netbirdio/netbird/shared/netiputil"
)
// Address WireGuard parsed address
type Address struct {
IP netip.Addr
Network netip.Prefix
+
+ // IPv6 overlay address, if assigned.
+ IPv6 netip.Addr
+ IPv6Net netip.Prefix
}
// ParseWGAddress parse a string ("1.2.3.4/24") address to WG Address
@@ -23,6 +29,60 @@ func ParseWGAddress(address string) (Address, error) {
}, nil
}
-func (addr Address) String() string {
- return fmt.Sprintf("%s/%d", addr.IP.String(), addr.Network.Bits())
+// HasIPv6 reports whether a v6 overlay address is assigned.
+func (addr Address) HasIPv6() bool {
+ return addr.IPv6.IsValid()
+}
+
+func (addr Address) String() string {
+ return addr.Prefix().String()
+}
+
+// IPv6String returns the v6 address in CIDR notation, or empty string if none.
+func (addr Address) IPv6String() string {
+ if !addr.HasIPv6() {
+ return ""
+ }
+ return addr.IPv6Prefix().String()
+}
+
+// Prefix returns the v4 host address with its network prefix length (e.g. 100.64.0.1/16).
+func (addr Address) Prefix() netip.Prefix {
+ return netip.PrefixFrom(addr.IP, addr.Network.Bits())
+}
+
+// IPv6Prefix returns the v6 host address with its network prefix length, or a zero prefix if none.
+func (addr Address) IPv6Prefix() netip.Prefix {
+ if !addr.HasIPv6() {
+ return netip.Prefix{}
+ }
+ return netip.PrefixFrom(addr.IPv6, addr.IPv6Net.Bits())
+}
+
+// SetIPv6FromCompact decodes a compact prefix (5 or 17 bytes) and sets the IPv6 fields.
+// Returns an error if the bytes are invalid. A nil or empty input is a no-op.
+//
+//nolint:recvcheck
+func (addr *Address) SetIPv6FromCompact(raw []byte) error {
+ if len(raw) == 0 {
+ return nil
+ }
+ prefix, err := netiputil.DecodePrefix(raw)
+ if err != nil {
+ return fmt.Errorf("decode v6 overlay address: %w", err)
+ }
+ if !prefix.Addr().Is6() {
+ return fmt.Errorf("expected IPv6 address, got %s", prefix.Addr())
+ }
+ addr.IPv6 = prefix.Addr()
+ addr.IPv6Net = prefix.Masked()
+ return nil
+}
+
+// ClearIPv6 removes the IPv6 overlay address, leaving only v4.
+//
+//nolint:recvcheck
+func (addr *Address) ClearIPv6() {
+ addr.IPv6 = netip.Addr{}
+ addr.IPv6Net = netip.Prefix{}
}
diff --git a/client/iface/wgaddr/address_test_helpers.go b/client/iface/wgaddr/address_test_helpers.go
new file mode 100644
index 000000000..87403e789
--- /dev/null
+++ b/client/iface/wgaddr/address_test_helpers.go
@@ -0,0 +1,10 @@
+package wgaddr
+
+// MustParseWGAddress parses and returns a WG Address, panicking on error.
+func MustParseWGAddress(address string) Address {
+ a, err := ParseWGAddress(address)
+ if err != nil {
+ panic(err)
+ }
+ return a
+}
diff --git a/client/iface/wgproxy/bind/proxy.go b/client/iface/wgproxy/bind/proxy.go
index 9ac3ea6df..be6f3806e 100644
--- a/client/iface/wgproxy/bind/proxy.go
+++ b/client/iface/wgproxy/bind/proxy.go
@@ -6,7 +6,7 @@ import (
"fmt"
"net"
"net/netip"
- "strings"
+
"sync"
log "github.com/sirupsen/logrus"
@@ -196,18 +196,25 @@ func (p *ProxyBind) proxyToLocal(ctx context.Context) {
}
}
-// fakeAddress returns a fake address that is used to as an identifier for the peer.
-// The fake address is in the format of 127.1.x.x where x.x is the last two octets of the peer address.
+// fakeAddress returns a fake address that is used as an identifier for the peer.
+// The fake address is in the format of 127.1.x.x where x.x is derived from the
+// last two bytes of the peer address (works for both IPv4 and IPv6).
func fakeAddress(peerAddress *net.UDPAddr) (*netip.AddrPort, error) {
- octets := strings.Split(peerAddress.IP.String(), ".")
- if len(octets) != 4 {
- return nil, fmt.Errorf("invalid IP format")
+ if peerAddress == nil {
+ return nil, fmt.Errorf("nil peer address")
+ }
+ if peerAddress.Port < 0 || peerAddress.Port > 65535 {
+ return nil, fmt.Errorf("invalid UDP port: %d", peerAddress.Port)
}
- fakeIP, err := netip.ParseAddr(fmt.Sprintf("127.1.%s.%s", octets[2], octets[3]))
- if err != nil {
- return nil, fmt.Errorf("parse new IP: %w", err)
+ addr, ok := netip.AddrFromSlice(peerAddress.IP)
+ if !ok {
+ return nil, fmt.Errorf("invalid IP format")
}
+ addr = addr.Unmap()
+
+ raw := addr.As16()
+ fakeIP := netip.AddrFrom4([4]byte{127, 1, raw[14], raw[15]})
netipAddr := netip.AddrPortFrom(fakeIP, uint16(peerAddress.Port))
return &netipAddr, nil
diff --git a/client/internal/acl/manager.go b/client/internal/acl/manager.go
index dd6f9479a..c54a3e897 100644
--- a/client/internal/acl/manager.go
+++ b/client/internal/acl/manager.go
@@ -5,7 +5,6 @@ import (
"encoding/hex"
"errors"
"fmt"
- "net"
"net/netip"
"strconv"
"sync"
@@ -19,6 +18,7 @@ import (
"github.com/netbirdio/netbird/client/internal/acl/id"
"github.com/netbirdio/netbird/shared/management/domain"
mgmProto "github.com/netbirdio/netbird/shared/management/proto"
+ "github.com/netbirdio/netbird/shared/netiputil"
)
var ErrSourceRangesEmpty = errors.New("sources range is empty")
@@ -105,6 +105,10 @@ func (d *DefaultManager) applyPeerACLs(networkMap *mgmProto.NetworkMap) {
newRulePairs := make(map[id.RuleID][]firewall.Rule)
ipsetByRuleSelectors := make(map[string]string)
+ // TODO: deny rules should be fatal: if a deny rule fails to apply, we must
+ // roll back all allow rules to avoid a fail-open where allowed traffic bypasses
+ // the missing deny. Currently we accumulate errors and continue.
+ var merr *multierror.Error
for _, r := range rules {
// if this rule is member of rule selection with more than DefaultIPsCountForSet
// it's IP address can be used in the ipset for firewall manager which supports it
@@ -117,9 +121,8 @@ func (d *DefaultManager) applyPeerACLs(networkMap *mgmProto.NetworkMap) {
}
pairID, rulePair, err := d.protoRuleToFirewallRule(r, ipsetName)
if err != nil {
- log.Errorf("failed to apply firewall rule: %+v, %v", r, err)
- d.rollBack(newRulePairs)
- break
+ merr = multierror.Append(merr, fmt.Errorf("apply firewall rule: %w", err))
+ continue
}
if len(rulePair) > 0 {
d.peerRulesPairs[pairID] = rulePair
@@ -127,6 +130,10 @@ func (d *DefaultManager) applyPeerACLs(networkMap *mgmProto.NetworkMap) {
}
}
+ if merr != nil {
+ log.Errorf("failed to apply %d peer ACL rule(s): %v", merr.Len(), nberrors.FormatErrorOrNil(merr))
+ }
+
for pairID, rules := range d.peerRulesPairs {
if _, ok := newRulePairs[pairID]; !ok {
for _, rule := range rules {
@@ -216,9 +223,9 @@ func (d *DefaultManager) protoRuleToFirewallRule(
r *mgmProto.FirewallRule,
ipsetName string,
) (id.RuleID, []firewall.Rule, error) {
- ip := net.ParseIP(r.PeerIP)
- if ip == nil {
- return "", nil, fmt.Errorf("invalid IP address, skipping firewall rule")
+ ip, err := extractRuleIP(r)
+ if err != nil {
+ return "", nil, err
}
protocol, err := convertToFirewallProtocol(r.Protocol)
@@ -289,13 +296,13 @@ func portInfoEmpty(portInfo *mgmProto.PortInfo) bool {
func (d *DefaultManager) addInRules(
id []byte,
- ip net.IP,
+ ip netip.Addr,
protocol firewall.Protocol,
port *firewall.Port,
action firewall.Action,
ipsetName string,
) ([]firewall.Rule, error) {
- rule, err := d.firewall.AddPeerFiltering(id, ip, protocol, nil, port, action, ipsetName)
+ rule, err := d.firewall.AddPeerFiltering(id, ip.AsSlice(), protocol, nil, port, action, ipsetName)
if err != nil {
return nil, fmt.Errorf("add firewall rule: %w", err)
}
@@ -305,7 +312,7 @@ func (d *DefaultManager) addInRules(
func (d *DefaultManager) addOutRules(
id []byte,
- ip net.IP,
+ ip netip.Addr,
protocol firewall.Protocol,
port *firewall.Port,
action firewall.Action,
@@ -315,7 +322,7 @@ func (d *DefaultManager) addOutRules(
return nil, nil
}
- rule, err := d.firewall.AddPeerFiltering(id, ip, protocol, port, nil, action, ipsetName)
+ rule, err := d.firewall.AddPeerFiltering(id, ip.AsSlice(), protocol, port, nil, action, ipsetName)
if err != nil {
return nil, fmt.Errorf("add firewall rule: %w", err)
}
@@ -323,9 +330,9 @@ func (d *DefaultManager) addOutRules(
return rule, nil
}
-// getPeerRuleID() returns unique ID for the rule based on its parameters.
+// getPeerRuleID returns unique ID for the rule based on its parameters.
func (d *DefaultManager) getPeerRuleID(
- ip net.IP,
+ ip netip.Addr,
proto firewall.Protocol,
direction int,
port *firewall.Port,
@@ -344,15 +351,25 @@ func (d *DefaultManager) getRuleGroupingSelector(rule *mgmProto.FirewallRule) st
return fmt.Sprintf("%v:%v:%v:%s:%v", strconv.Itoa(int(rule.Direction)), rule.Action, rule.Protocol, rule.Port, rule.PortInfo)
}
-func (d *DefaultManager) rollBack(newRulePairs map[id.RuleID][]firewall.Rule) {
- log.Debugf("rollback ACL to previous state")
- for _, rules := range newRulePairs {
- for _, rule := range rules {
- if err := d.firewall.DeletePeerRule(rule); err != nil {
- log.Errorf("failed to delete new firewall rule (id: %v) during rollback: %v", rule.ID(), err)
- }
+
+// extractRuleIP extracts the peer IP from a firewall rule.
+// If sourcePrefixes is populated (new management), decode the first entry and use its address.
+// Otherwise fall back to the deprecated PeerIP string field (old management).
+func extractRuleIP(r *mgmProto.FirewallRule) (netip.Addr, error) {
+ if len(r.SourcePrefixes) > 0 {
+ addr, err := netiputil.DecodeAddr(r.SourcePrefixes[0])
+ if err != nil {
+ return netip.Addr{}, fmt.Errorf("decode source prefix: %w", err)
}
+ return addr.Unmap(), nil
}
+
+ //nolint:staticcheck // PeerIP used for backward compatibility with old management
+ addr, err := netip.ParseAddr(r.PeerIP)
+ if err != nil {
+ return netip.Addr{}, fmt.Errorf("invalid IP address, skipping firewall rule")
+ }
+ return addr.Unmap(), nil
}
func convertToFirewallProtocol(protocol mgmProto.RuleProtocol) (firewall.Protocol, error) {
diff --git a/client/internal/auth/auth.go b/client/internal/auth/auth.go
index bdfd07430..afc8ee77f 100644
--- a/client/internal/auth/auth.go
+++ b/client/internal/auth/auth.go
@@ -321,6 +321,7 @@ func (a *Auth) setSystemInfoFlags(info *system.Info) {
a.config.DisableFirewall,
a.config.BlockLANAccess,
a.config.BlockInbound,
+ a.config.DisableIPv6,
a.config.LazyConnectionEnabled,
a.config.EnableSSHRoot,
a.config.EnableSSHSFTP,
diff --git a/client/internal/connect.go b/client/internal/connect.go
index 71c54526b..72f81c782 100644
--- a/client/internal/connect.go
+++ b/client/internal/connect.go
@@ -14,10 +14,13 @@ import (
"github.com/cenkalti/backoff/v4"
log "github.com/sirupsen/logrus"
+
"golang.zx2c4.com/wireguard/wgctrl/wgtypes"
"google.golang.org/grpc/codes"
gstatus "google.golang.org/grpc/status"
+ "github.com/netbirdio/netbird/client/iface/wgaddr"
+
"github.com/netbirdio/netbird/client/iface"
"github.com/netbirdio/netbird/client/iface/device"
"github.com/netbirdio/netbird/client/iface/netstack"
@@ -113,7 +116,6 @@ func (c *ConnectClient) RunOniOS(
fileDescriptor int32,
networkChangeListener listener.NetworkChangeListener,
dnsManager dns.IosDnsManager,
- dnsAddresses []netip.AddrPort,
stateFilePath string,
cacheDir string,
) error {
@@ -124,7 +126,6 @@ func (c *ConnectClient) RunOniOS(
FileDescriptor: fileDescriptor,
NetworkChangeListener: networkChangeListener,
DnsManager: dnsManager,
- HostDNSAddresses: dnsAddresses,
StateFilePath: stateFilePath,
TempDir: cacheDir,
}
@@ -538,9 +539,20 @@ func createEngineConfig(key wgtypes.Key, config *profilemanager.Config, peerConf
if config.NetworkMonitor != nil {
nm = *config.NetworkMonitor
}
+ wgAddr, err := wgaddr.ParseWGAddress(peerConfig.Address)
+ if err != nil {
+ return nil, fmt.Errorf("parse overlay address %q: %w", peerConfig.Address, err)
+ }
+
+ if !config.DisableIPv6 {
+ if err := wgAddr.SetIPv6FromCompact(peerConfig.GetAddressV6()); err != nil {
+ log.Warn(err)
+ }
+ }
+
engineConf := &EngineConfig{
WgIfaceName: config.WgIface,
- WgAddr: peerConfig.Address,
+ WgAddr: wgAddr,
IFaceBlackList: config.IFaceBlackList,
DisableIPv6Discovery: config.DisableIPv6Discovery,
WgPrivateKey: key,
@@ -565,6 +577,7 @@ func createEngineConfig(key wgtypes.Key, config *profilemanager.Config, peerConf
DisableFirewall: config.DisableFirewall,
BlockLANAccess: config.BlockLANAccess,
BlockInbound: config.BlockInbound,
+ DisableIPv6: config.DisableIPv6,
LazyConnectionEnabled: config.LazyConnectionEnabled,
@@ -639,6 +652,7 @@ func loginToManagement(ctx context.Context, client mgm.Client, pubSSHKey []byte,
config.DisableFirewall,
config.BlockLANAccess,
config.BlockInbound,
+ config.DisableIPv6,
config.LazyConnectionEnabled,
config.EnableSSHRoot,
config.EnableSSHSFTP,
diff --git a/client/internal/connect_android_default.go b/client/internal/connect_android_default.go
index 190341c4a..b05e91fec 100644
--- a/client/internal/connect_android_default.go
+++ b/client/internal/connect_android_default.go
@@ -40,6 +40,10 @@ func (noopNetworkChangeListener) SetInterfaceIP(string) {
// network stack, not by OS-level interface configuration.
}
+func (noopNetworkChangeListener) SetInterfaceIPv6(string) {
+ // No-op: same as SetInterfaceIP, IPv6 overlay is managed by userspace stack.
+}
+
// noopDnsReadyListener is a stub for embed.Client on Android.
// DNS readiness notifications are not needed in netstack/embed mode
// since system DNS is disabled and DNS resolution happens externally.
diff --git a/client/internal/debug/debug.go b/client/internal/debug/debug.go
index 06238ab96..8bc425a87 100644
--- a/client/internal/debug/debug.go
+++ b/client/internal/debug/debug.go
@@ -31,6 +31,7 @@ import (
"github.com/netbirdio/netbird/client/internal/updater/installer"
nbstatus "github.com/netbirdio/netbird/client/status"
mgmProto "github.com/netbirdio/netbird/shared/management/proto"
+ "github.com/netbirdio/netbird/shared/netiputil"
)
const readmeContent = `Netbird debug bundle
@@ -44,8 +45,11 @@ netbird.out: Most recent, anonymized stdout log file of the NetBird client.
routes.txt: Detailed system routing table in tabular format including destination, gateway, interface, metrics, and protocol information, if --system-info flag was provided.
interfaces.txt: Anonymized network interface information, if --system-info flag was provided.
ip_rules.txt: Detailed IP routing rules in tabular format including priority, source, destination, interfaces, table, and action information (Linux only), if --system-info flag was provided.
-iptables.txt: Anonymized iptables rules with packet counters, if --system-info flag was provided.
-nftables.txt: Anonymized nftables rules with packet counters, if --system-info flag was provided.
+iptables.txt: Anonymized iptables (IPv4) rules with packet counters, if --system-info flag was provided.
+ip6tables.txt: Anonymized ip6tables (IPv6) rules with packet counters, if --system-info flag was provided.
+ipset.txt: Anonymized ipset list output, if --system-info flag was provided.
+nftables.txt: Anonymized nftables rules with packet counters across all families (ip, ip6, inet, etc.), if --system-info flag was provided.
+sysctls.txt: Forwarding, reverse-path filter, source-validation, and conntrack accounting sysctl values that the NetBird client may read or modify, if --system-info flag was provided (Linux only).
resolv.conf: DNS resolver configuration from /etc/resolv.conf (Unix systems only), if --system-info flag was provided.
scutil_dns.txt: DNS configuration from scutil --dns (macOS only), if --system-info flag was provided.
resolved_domains.txt: Anonymized resolved domain IP addresses from the status recorder.
@@ -164,22 +168,33 @@ The config.txt file contains anonymized configuration information of the NetBird
Other non-sensitive configuration options are included without anonymization.
Firewall Rules (Linux only)
-The bundle includes two separate firewall rule files:
+The bundle includes the following firewall-related files:
iptables.txt:
-- Complete iptables ruleset with packet counters using 'iptables -v -n -L'
+- IPv4 iptables ruleset with packet counters using 'iptables-save' and 'iptables -v -n -L'
- Includes all tables (filter, nat, mangle, raw, security)
- Shows packet and byte counters for each rule
- All IP addresses are anonymized
- Chain names, table names, and other non-sensitive information remain unchanged
+ip6tables.txt:
+- IPv6 ip6tables ruleset with packet counters using 'ip6tables-save' and 'ip6tables -v -n -L'
+- Same table coverage and anonymization as iptables.txt
+- Omitted when ip6tables is not installed or no IPv6 rules are present
+
+ipset.txt:
+- Output of 'ipset list' (family-agnostic)
+- IP addresses are anonymized; set names and types remain unchanged
+
nftables.txt:
-- Complete nftables ruleset obtained via 'nft -a list ruleset'
+- Complete nftables ruleset across all families (ip, ip6, inet, arp, bridge, netdev) via 'nft -a list ruleset'
- Includes rule handle numbers and packet counters
-- All tables, chains, and rules are included
-- Shows packet and byte counters for each rule
-- All IP addresses are anonymized
-- Chain names, table names, and other non-sensitive information remain unchanged
+- All IP addresses are anonymized; chain/table names remain unchanged
+
+sysctls.txt:
+- Forwarding (IPv4 + IPv6, global and per-interface), reverse-path filter, source-validation, conntrack accounting, and TCP-related sysctls that netbird may read or modify
+- Per-interface keys are enumerated from /proc/sys/net/ipv{4,6}/conf
+- Interface names anonymized when --anonymize is set
IP Rules (Linux only)
The ip_rules.txt file contains detailed IP routing rule information:
@@ -414,6 +429,10 @@ func (g *BundleGenerator) addSystemInfo() {
log.Errorf("failed to add firewall rules to debug bundle: %v", err)
}
+ if err := g.addSysctls(); err != nil {
+ log.Errorf("failed to add sysctls to debug bundle: %v", err)
+ }
+
if err := g.addDNSInfo(); err != nil {
log.Errorf("failed to add DNS info to debug bundle: %v", err)
}
@@ -627,6 +646,7 @@ func (g *BundleGenerator) addCommonConfigFields(configContent *strings.Builder)
configContent.WriteString(fmt.Sprintf("DisableFirewall: %v\n", g.internalConfig.DisableFirewall))
configContent.WriteString(fmt.Sprintf("BlockLANAccess: %v\n", g.internalConfig.BlockLANAccess))
configContent.WriteString(fmt.Sprintf("BlockInbound: %v\n", g.internalConfig.BlockInbound))
+ configContent.WriteString(fmt.Sprintf("DisableIPv6: %v\n", g.internalConfig.DisableIPv6))
if g.internalConfig.DisableNotifications != nil {
configContent.WriteString(fmt.Sprintf("DisableNotifications: %v\n", *g.internalConfig.DisableNotifications))
@@ -1300,6 +1320,21 @@ func anonymizePeerConfig(config *mgmProto.PeerConfig, anonymizer *anonymize.Anon
config.Address = anonymizer.AnonymizeIP(addr).String()
}
+ if len(config.GetAddressV6()) > 0 {
+ v6Prefix, err := netiputil.DecodePrefix(config.GetAddressV6())
+ if err != nil {
+ config.AddressV6 = nil
+ } else {
+ anonV6 := anonymizer.AnonymizeIP(v6Prefix.Addr())
+ b, err := netiputil.EncodePrefix(netip.PrefixFrom(anonV6, v6Prefix.Bits()))
+ if err != nil {
+ config.AddressV6 = nil
+ } else {
+ config.AddressV6 = b
+ }
+ }
+ }
+
anonymizeSSHConfig(config.SshConfig)
config.Dns = anonymizer.AnonymizeString(config.Dns)
@@ -1402,8 +1437,20 @@ func anonymizeFirewallRule(rule *mgmProto.FirewallRule, anonymizer *anonymize.An
return
}
+ //nolint:staticcheck // PeerIP used for backward compatibility
if addr, err := netip.ParseAddr(rule.PeerIP); err == nil {
- rule.PeerIP = anonymizer.AnonymizeIP(addr).String()
+ rule.PeerIP = anonymizer.AnonymizeIP(addr).String() //nolint:staticcheck
+ }
+
+ for i, raw := range rule.GetSourcePrefixes() {
+ p, err := netiputil.DecodePrefix(raw)
+ if err != nil {
+ continue
+ }
+ anonAddr := anonymizer.AnonymizeIP(p.Addr())
+ if b, err := netiputil.EncodePrefix(netip.PrefixFrom(anonAddr, p.Bits())); err == nil {
+ rule.SourcePrefixes[i] = b
+ }
}
}
diff --git a/client/internal/debug/debug_linux.go b/client/internal/debug/debug_linux.go
index aedf88b79..40d864eda 100644
--- a/client/internal/debug/debug_linux.go
+++ b/client/internal/debug/debug_linux.go
@@ -124,15 +124,18 @@ func getSystemdLogs(serviceName string) (string, error) {
// addFirewallRules collects and adds firewall rules to the archive
func (g *BundleGenerator) addFirewallRules() error {
log.Info("Collecting firewall rules")
- iptablesRules, err := collectIPTablesRules()
+ g.addIPTablesRulesToBundle("iptables-save", "iptables", "iptables.txt")
+ g.addIPTablesRulesToBundle("ip6tables-save", "ip6tables", "ip6tables.txt")
+
+ ipsetOutput, err := collectIPSets()
if err != nil {
- log.Warnf("Failed to collect iptables rules: %v", err)
+ log.Warnf("Failed to collect ipset information: %v", err)
} else {
if g.anonymize {
- iptablesRules = g.anonymizer.AnonymizeString(iptablesRules)
+ ipsetOutput = g.anonymizer.AnonymizeString(ipsetOutput)
}
- if err := g.addFileToZip(strings.NewReader(iptablesRules), "iptables.txt"); err != nil {
- log.Warnf("Failed to add iptables rules to bundle: %v", err)
+ if err := g.addFileToZip(strings.NewReader(ipsetOutput), "ipset.txt"); err != nil {
+ log.Warnf("Failed to add ipset output to bundle: %v", err)
}
}
@@ -151,44 +154,65 @@ func (g *BundleGenerator) addFirewallRules() error {
return nil
}
-// collectIPTablesRules collects rules using both iptables-save and verbose listing
-func collectIPTablesRules() (string, error) {
- var builder strings.Builder
-
- saveOutput, err := collectIPTablesSave()
+// addIPTablesRulesToBundle collects iptables/ip6tables rules and writes them to the bundle.
+func (g *BundleGenerator) addIPTablesRulesToBundle(saveBin, listBin, filename string) {
+ rules, err := collectIPTablesRules(saveBin, listBin)
if err != nil {
- log.Warnf("Failed to collect iptables rules using iptables-save: %v", err)
- } else {
- builder.WriteString("=== iptables-save output ===\n")
+ log.Warnf("Failed to collect %s rules: %v", listBin, err)
+ return
+ }
+ if g.anonymize {
+ rules = g.anonymizer.AnonymizeString(rules)
+ }
+ if err := g.addFileToZip(strings.NewReader(rules), filename); err != nil {
+ log.Warnf("Failed to add %s rules to bundle: %v", listBin, err)
+ }
+}
+
+// collectIPTablesRules collects rules using both and verbose listing via .
+// Returns an error when neither command produced any output (e.g. the binary is missing),
+// so the caller can skip writing an empty file.
+func collectIPTablesRules(saveBin, listBin string) (string, error) {
+ var builder strings.Builder
+ var collected bool
+ var firstErr error
+
+ saveOutput, err := runCommand(saveBin)
+ switch {
+ case err != nil:
+ firstErr = err
+ log.Warnf("Failed to collect %s output: %v", saveBin, err)
+ case strings.TrimSpace(saveOutput) == "":
+ log.Debugf("%s produced no output, skipping", saveBin)
+ default:
+ builder.WriteString(fmt.Sprintf("=== %s output ===\n", saveBin))
builder.WriteString(saveOutput)
builder.WriteString("\n")
+ collected = true
}
- ipsetOutput, err := collectIPSets()
- if err != nil {
- log.Warnf("Failed to collect ipset information: %v", err)
- } else {
- builder.WriteString("=== ipset list output ===\n")
- builder.WriteString(ipsetOutput)
- builder.WriteString("\n")
- }
-
- builder.WriteString("=== iptables -v -n -L output ===\n")
+ listHeader := fmt.Sprintf("=== %s -v -n -L output ===\n", listBin)
+ builder.WriteString(listHeader)
tables := []string{"filter", "nat", "mangle", "raw", "security"}
-
for _, table := range tables {
- builder.WriteString(fmt.Sprintf("*%s\n", table))
-
- stats, err := getTableStatistics(table)
+ stats, err := runCommand(listBin, "-v", "-n", "-L", "-t", table)
if err != nil {
- log.Warnf("Failed to get statistics for table %s: %v", table, err)
+ if firstErr == nil {
+ firstErr = err
+ }
+ log.Warnf("Failed to get %s statistics for table %s: %v", listBin, table, err)
continue
}
+ builder.WriteString(fmt.Sprintf("*%s\n", table))
builder.WriteString(stats)
builder.WriteString("\n")
+ collected = true
}
+ if !collected {
+ return "", fmt.Errorf("collect %s rules: %w", listBin, firstErr)
+ }
return builder.String(), nil
}
@@ -214,34 +238,15 @@ func collectIPSets() (string, error) {
return ipsets, nil
}
-// collectIPTablesSave uses iptables-save to get rule definitions
-func collectIPTablesSave() (string, error) {
- cmd := exec.Command("iptables-save")
+// runCommand executes a command and returns its stdout, wrapping stderr in the error on failure.
+func runCommand(name string, args ...string) (string, error) {
+ cmd := exec.Command(name, args...)
var stdout, stderr bytes.Buffer
cmd.Stdout = &stdout
cmd.Stderr = &stderr
if err := cmd.Run(); err != nil {
- return "", fmt.Errorf("execute iptables-save: %w (stderr: %s)", err, stderr.String())
- }
-
- rules := stdout.String()
- if strings.TrimSpace(rules) == "" {
- return "", fmt.Errorf("no iptables rules found")
- }
-
- return rules, nil
-}
-
-// getTableStatistics gets verbose statistics for an entire table using iptables command
-func getTableStatistics(table string) (string, error) {
- cmd := exec.Command("iptables", "-v", "-n", "-L", "-t", table)
- var stdout, stderr bytes.Buffer
- cmd.Stdout = &stdout
- cmd.Stderr = &stderr
-
- if err := cmd.Run(); err != nil {
- return "", fmt.Errorf("execute iptables -v -n -L: %w (stderr: %s)", err, stderr.String())
+ return "", fmt.Errorf("execute %s: %w (stderr: %s)", name, err, stderr.String())
}
return stdout.String(), nil
@@ -804,3 +809,91 @@ func formatSetKeyType(keyType nftables.SetDatatype) string {
return fmt.Sprintf("type-%v", keyType)
}
}
+
+// addSysctls collects forwarding and netbird-managed sysctl values and writes them to the bundle.
+func (g *BundleGenerator) addSysctls() error {
+ log.Info("Collecting sysctls")
+ content := collectSysctls()
+ if g.anonymize {
+ content = g.anonymizer.AnonymizeString(content)
+ }
+ if err := g.addFileToZip(strings.NewReader(content), "sysctls.txt"); err != nil {
+ return fmt.Errorf("add sysctls to bundle: %w", err)
+ }
+ return nil
+}
+
+// collectSysctls reads every sysctl that the netbird client may modify, plus
+// global IPv4/IPv6 forwarding, and returns a formatted dump grouped by topic.
+// Per-interface values are enumerated by listing /proc/sys/net/ipv{4,6}/conf.
+func collectSysctls() string {
+ var builder strings.Builder
+
+ writeSysctlGroup(&builder, "forwarding", []string{
+ "net.ipv4.ip_forward",
+ "net.ipv6.conf.all.forwarding",
+ "net.ipv6.conf.default.forwarding",
+ })
+ writeSysctlGroup(&builder, "ipv4 per-interface forwarding", listInterfaceSysctls("ipv4", "forwarding"))
+ writeSysctlGroup(&builder, "ipv6 per-interface forwarding", listInterfaceSysctls("ipv6", "forwarding"))
+ writeSysctlGroup(&builder, "rp_filter", append(
+ []string{"net.ipv4.conf.all.rp_filter", "net.ipv4.conf.default.rp_filter"},
+ listInterfaceSysctls("ipv4", "rp_filter")...,
+ ))
+ writeSysctlGroup(&builder, "src_valid_mark", append(
+ []string{"net.ipv4.conf.all.src_valid_mark", "net.ipv4.conf.default.src_valid_mark"},
+ listInterfaceSysctls("ipv4", "src_valid_mark")...,
+ ))
+ writeSysctlGroup(&builder, "conntrack", []string{
+ "net.netfilter.nf_conntrack_acct",
+ "net.netfilter.nf_conntrack_tcp_loose",
+ })
+ writeSysctlGroup(&builder, "tcp", []string{
+ "net.ipv4.tcp_tw_reuse",
+ })
+
+ return builder.String()
+}
+
+func writeSysctlGroup(builder *strings.Builder, title string, keys []string) {
+ builder.WriteString(fmt.Sprintf("=== %s ===\n", title))
+ for _, key := range keys {
+ value, err := readSysctl(key)
+ if err != nil {
+ builder.WriteString(fmt.Sprintf("%s = \n", key, err))
+ continue
+ }
+ builder.WriteString(fmt.Sprintf("%s = %s\n", key, value))
+ }
+ builder.WriteString("\n")
+}
+
+// listInterfaceSysctls returns net.ipvX.conf.. keys for every
+// interface present in /proc/sys/net/ipvX/conf, skipping "all" and "default"
+// (callers add those explicitly so they appear first).
+func listInterfaceSysctls(family, leaf string) []string {
+ dir := fmt.Sprintf("/proc/sys/net/%s/conf", family)
+ entries, err := os.ReadDir(dir)
+ if err != nil {
+ return nil
+ }
+ var keys []string
+ for _, e := range entries {
+ name := e.Name()
+ if name == "all" || name == "default" {
+ continue
+ }
+ keys = append(keys, fmt.Sprintf("net.%s.conf.%s.%s", family, name, leaf))
+ }
+ sort.Strings(keys)
+ return keys
+}
+
+func readSysctl(key string) (string, error) {
+ path := fmt.Sprintf("/proc/sys/%s", strings.ReplaceAll(key, ".", "/"))
+ value, err := os.ReadFile(path)
+ if err != nil {
+ return "", err
+ }
+ return strings.TrimSpace(string(value)), nil
+}
diff --git a/client/internal/debug/debug_nonlinux.go b/client/internal/debug/debug_nonlinux.go
index ace53bd94..878fee40f 100644
--- a/client/internal/debug/debug_nonlinux.go
+++ b/client/internal/debug/debug_nonlinux.go
@@ -17,3 +17,8 @@ func (g *BundleGenerator) addIPRules() error {
// IP rules are only supported on Linux
return nil
}
+
+func (g *BundleGenerator) addSysctls() error {
+ // Sysctl collection is only supported on Linux
+ return nil
+}
diff --git a/client/internal/debug/debug_test.go b/client/internal/debug/debug_test.go
index 05d51e593..39b972244 100644
--- a/client/internal/debug/debug_test.go
+++ b/client/internal/debug/debug_test.go
@@ -5,6 +5,7 @@ import (
"bytes"
"encoding/json"
"net"
+ "net/netip"
"net/url"
"os"
"path/filepath"
@@ -21,8 +22,16 @@ import (
"github.com/netbirdio/netbird/client/internal/profilemanager"
"github.com/netbirdio/netbird/shared/management/domain"
mgmProto "github.com/netbirdio/netbird/shared/management/proto"
+ "github.com/netbirdio/netbird/shared/netiputil"
)
+func mustEncodePrefix(t *testing.T, p netip.Prefix) []byte {
+ t.Helper()
+ b, err := netiputil.EncodePrefix(p)
+ require.NoError(t, err)
+ return b
+}
+
func TestAnonymizeStateFile(t *testing.T) {
testState := map[string]json.RawMessage{
"null_state": json.RawMessage("null"),
@@ -173,7 +182,7 @@ func TestAnonymizeStateFile(t *testing.T) {
assert.Equal(t, "100.64.0.1", state["protected_ip"]) // Protected IP unchanged
assert.Equal(t, "8.8.8.8", state["well_known_ip"]) // Well-known IP unchanged
assert.NotEqual(t, "2001:db8::1", state["ipv6_addr"])
- assert.Equal(t, "fd00::1", state["private_ipv6"]) // Private IPv6 unchanged
+ assert.NotEqual(t, "fd00::1", state["private_ipv6"]) // ULA IPv6 anonymized (global ID is a fingerprint)
assert.NotEqual(t, "test.example.com", state["domain"])
assert.True(t, strings.HasSuffix(state["domain"].(string), ".domain"))
assert.Equal(t, "device.netbird.cloud", state["netbird_domain"]) // Netbird domain unchanged
@@ -277,11 +286,13 @@ func mustMarshal(v any) json.RawMessage {
}
func TestAnonymizeNetworkMap(t *testing.T) {
+ origV6Prefix := netip.MustParsePrefix("2001:db8:abcd::5/64")
networkMap := &mgmProto.NetworkMap{
PeerConfig: &mgmProto.PeerConfig{
- Address: "203.0.113.5",
- Dns: "1.2.3.4",
- Fqdn: "peer1.corp.example.com",
+ Address: "203.0.113.5",
+ AddressV6: mustEncodePrefix(t, origV6Prefix),
+ Dns: "1.2.3.4",
+ Fqdn: "peer1.corp.example.com",
SshConfig: &mgmProto.SSHConfig{
SshPubKey: []byte("ssh-rsa AAAAB3NzaC1..."),
},
@@ -355,6 +366,12 @@ func TestAnonymizeNetworkMap(t *testing.T) {
require.NotEqual(t, "peer1.corp.example.com", peerCfg.Fqdn)
require.True(t, strings.HasSuffix(peerCfg.Fqdn, ".domain"))
+ // Verify AddressV6 is anonymized but preserves prefix length
+ anonV6Prefix, err := netiputil.DecodePrefix(peerCfg.AddressV6)
+ require.NoError(t, err)
+ assert.Equal(t, origV6Prefix.Bits(), anonV6Prefix.Bits(), "prefix length must be preserved")
+ assert.NotEqual(t, origV6Prefix.Addr(), anonV6Prefix.Addr(), "IPv6 address must be anonymized")
+
// Verify SSH key is replaced
require.Equal(t, []byte("ssh-placeholder-key"), peerCfg.SshConfig.SshPubKey)
@@ -660,8 +677,6 @@ func isInCGNATRange(ip net.IP) bool {
}
func TestAnonymizeFirewallRules(t *testing.T) {
- // TODO: Add ipv6
-
// Example iptables-save output
iptablesSave := `# Generated by iptables-save v1.8.7 on Thu Dec 19 10:00:00 2024
*filter
@@ -697,17 +712,31 @@ Chain FORWARD (policy ACCEPT 0 packets, 0 bytes)
Chain OUTPUT (policy ACCEPT 0 packets, 0 bytes)
pkts bytes target prot opt in out source destination`
- // Example nftables output
+ // Example ip6tables-save output
+ ip6tablesSave := `# Generated by ip6tables-save v1.8.7 on Thu Dec 19 10:00:00 2024
+*filter
+:INPUT ACCEPT [0:0]
+:FORWARD ACCEPT [0:0]
+:OUTPUT ACCEPT [0:0]
+-A INPUT -s fd00:1234::1/128 -j ACCEPT
+-A INPUT -s 2607:f8b0:4005::1/128 -j DROP
+-A FORWARD -s 2001:db8::/32 -d 2607:f8b0:4005::200e/128 -j ACCEPT
+COMMIT`
+
+ // Example nftables output with IPv6
nftablesRules := `table inet filter {
chain input {
type filter hook input priority filter; policy accept;
ip saddr 192.168.1.1 accept
ip saddr 44.192.140.1 drop
+ ip6 saddr 2607:f8b0:4005::1 drop
+ ip6 saddr fd00:1234::1 accept
}
chain forward {
type filter hook forward priority filter; policy accept;
ip saddr 10.0.0.0/8 drop
ip saddr 44.192.140.0/24 ip daddr 52.84.12.34/24 accept
+ ip6 saddr 2001:db8::/32 ip6 daddr 2607:f8b0:4005::200e/128 accept
}
}`
@@ -770,6 +799,37 @@ Chain OUTPUT (policy ACCEPT 0 packets, 0 bytes)
assert.Contains(t, anonNftables, "table inet filter {")
assert.Contains(t, anonNftables, "chain input {")
assert.Contains(t, anonNftables, "type filter hook input priority filter; policy accept;")
+
+ // IPv6 public addresses in nftables should be anonymized
+ assert.NotContains(t, anonNftables, "2607:f8b0:4005::1")
+ assert.NotContains(t, anonNftables, "2607:f8b0:4005::200e")
+ assert.NotContains(t, anonNftables, "2001:db8::")
+ assert.Contains(t, anonNftables, "2001:db8:ffff::") // Default anonymous v6 range
+
+ // ULA addresses in nftables should be anonymized (global ID is a fingerprint)
+ assert.NotContains(t, anonNftables, "fd00:1234::1")
+
+ // IPv6 nftables structure preserved
+ assert.Contains(t, anonNftables, "ip6 saddr")
+ assert.Contains(t, anonNftables, "ip6 daddr")
+
+ // Test ip6tables-save anonymization
+ anonIp6tablesSave := anonymizer.AnonymizeString(ip6tablesSave)
+
+ // ULA IPv6 should be anonymized (global ID is a fingerprint)
+ assert.NotContains(t, anonIp6tablesSave, "fd00:1234::1/128")
+
+ // Public IPv6 addresses should be anonymized
+ assert.NotContains(t, anonIp6tablesSave, "2607:f8b0:4005::1")
+ assert.NotContains(t, anonIp6tablesSave, "2607:f8b0:4005::200e")
+ assert.NotContains(t, anonIp6tablesSave, "2001:db8::")
+ assert.Contains(t, anonIp6tablesSave, "2001:db8:ffff::") // Default anonymous v6 range
+
+ // Structure should be preserved
+ assert.Contains(t, anonIp6tablesSave, "*filter")
+ assert.Contains(t, anonIp6tablesSave, "COMMIT")
+ assert.Contains(t, anonIp6tablesSave, "-j DROP")
+ assert.Contains(t, anonIp6tablesSave, "-j ACCEPT")
}
// TestAddConfig_AllFieldsCovered uses reflection to ensure every field in
diff --git a/client/internal/dns.go b/client/internal/dns.go
index f5040ee49..a6604810f 100644
--- a/client/internal/dns.go
+++ b/client/internal/dns.go
@@ -12,52 +12,83 @@ import (
nbdns "github.com/netbirdio/netbird/dns"
)
-func createPTRRecord(aRecord nbdns.SimpleRecord, prefix netip.Prefix) (nbdns.SimpleRecord, bool) {
- ip, err := netip.ParseAddr(aRecord.RData)
+func createPTRRecord(record nbdns.SimpleRecord, prefix netip.Prefix) (nbdns.SimpleRecord, bool) {
+ ip, err := netip.ParseAddr(record.RData)
if err != nil {
- log.Warnf("failed to parse IP address %s: %v", aRecord.RData, err)
+ log.Warnf("failed to parse IP address %s: %v", record.RData, err)
return nbdns.SimpleRecord{}, false
}
+ ip = ip.Unmap()
if !prefix.Contains(ip) {
return nbdns.SimpleRecord{}, false
}
- ipOctets := strings.Split(ip.String(), ".")
- slices.Reverse(ipOctets)
- rdnsName := dns.Fqdn(strings.Join(ipOctets, ".") + ".in-addr.arpa")
+ var rdnsName string
+ if ip.Is4() {
+ octets := strings.Split(ip.String(), ".")
+ slices.Reverse(octets)
+ rdnsName = dns.Fqdn(strings.Join(octets, ".") + ".in-addr.arpa")
+ } else {
+ // Expand to full 32 nibbles in reverse order (LSB first) per RFC 3596.
+ raw := ip.As16()
+ nibbles := make([]string, 32)
+ for i := 0; i < 16; i++ {
+ nibbles[31-i*2] = fmt.Sprintf("%x", raw[i]>>4)
+ nibbles[31-i*2-1] = fmt.Sprintf("%x", raw[i]&0x0f)
+ }
+ rdnsName = dns.Fqdn(strings.Join(nibbles, ".") + ".ip6.arpa")
+ }
return nbdns.SimpleRecord{
Name: rdnsName,
Type: int(dns.TypePTR),
- Class: aRecord.Class,
- TTL: aRecord.TTL,
- RData: dns.Fqdn(aRecord.Name),
+ Class: record.Class,
+ TTL: record.TTL,
+ RData: dns.Fqdn(record.Name),
}, true
}
-// generateReverseZoneName creates the reverse DNS zone name for a given network
+// generateReverseZoneName creates the reverse DNS zone name for a given network.
+// For IPv4 it produces an in-addr.arpa name, for IPv6 an ip6.arpa name.
func generateReverseZoneName(network netip.Prefix) (string, error) {
- networkIP := network.Masked().Addr()
+ networkIP := network.Masked().Addr().Unmap()
+ bits := network.Bits()
- if !networkIP.Is4() {
- return "", fmt.Errorf("reverse DNS is only supported for IPv4 networks, got: %s", networkIP)
+ if networkIP.Is4() {
+ // Round up to nearest byte.
+ octetsToUse := (bits + 7) / 8
+
+ octets := strings.Split(networkIP.String(), ".")
+ if octetsToUse > len(octets) {
+ return "", fmt.Errorf("invalid network mask size for reverse DNS: %d", bits)
+ }
+
+ reverseOctets := make([]string, octetsToUse)
+ for i := 0; i < octetsToUse; i++ {
+ reverseOctets[octetsToUse-1-i] = octets[i]
+ }
+
+ return dns.Fqdn(strings.Join(reverseOctets, ".") + ".in-addr.arpa"), nil
}
- // round up to nearest byte
- octetsToUse := (network.Bits() + 7) / 8
+ // IPv6: round up to nearest nibble (4-bit boundary).
+ nibblesToUse := (bits + 3) / 4
- octets := strings.Split(networkIP.String(), ".")
- if octetsToUse > len(octets) {
- return "", fmt.Errorf("invalid network mask size for reverse DNS: %d", network.Bits())
+ raw := networkIP.As16()
+ allNibbles := make([]string, 32)
+ for i := 0; i < 16; i++ {
+ allNibbles[i*2] = fmt.Sprintf("%x", raw[i]>>4)
+ allNibbles[i*2+1] = fmt.Sprintf("%x", raw[i]&0x0f)
}
- reverseOctets := make([]string, octetsToUse)
- for i := 0; i < octetsToUse; i++ {
- reverseOctets[octetsToUse-1-i] = octets[i]
+ // Take the first nibblesToUse nibbles (network portion), reverse them.
+ used := make([]string, nibblesToUse)
+ for i := 0; i < nibblesToUse; i++ {
+ used[nibblesToUse-1-i] = allNibbles[i]
}
- return dns.Fqdn(strings.Join(reverseOctets, ".") + ".in-addr.arpa"), nil
+ return dns.Fqdn(strings.Join(used, ".") + ".ip6.arpa"), nil
}
// zoneExists checks if a zone with the given name already exists in the configuration
@@ -71,7 +102,7 @@ func zoneExists(config *nbdns.Config, zoneName string) bool {
return false
}
-// collectPTRRecords gathers all PTR records for the given network from A records
+// collectPTRRecords gathers all PTR records for the given network from A and AAAA records.
func collectPTRRecords(config *nbdns.Config, prefix netip.Prefix) []nbdns.SimpleRecord {
var records []nbdns.SimpleRecord
@@ -80,7 +111,7 @@ func collectPTRRecords(config *nbdns.Config, prefix netip.Prefix) []nbdns.Simple
continue
}
for _, record := range zone.Records {
- if record.Type != int(dns.TypeA) {
+ if record.Type != int(dns.TypeA) && record.Type != int(dns.TypeAAAA) {
continue
}
diff --git a/client/internal/dns/host.go b/client/internal/dns/host.go
index f7dc46a6b..48eacef29 100644
--- a/client/internal/dns/host.go
+++ b/client/internal/dns/host.go
@@ -16,6 +16,10 @@ type hostManager interface {
restoreHostDNS() error
supportCustomPort() bool
string() string
+ // getOriginalNameservers returns the OS-side resolvers used as PriorityFallback
+ // upstreams: pre-takeover snapshots on desktop, the OS-pushed list on Android,
+ // hardcoded Quad9 on iOS, nil for noop / mock.
+ getOriginalNameservers() []netip.Addr
}
type SystemDNSSettings struct {
@@ -131,3 +135,11 @@ func (n noopHostConfigurator) supportCustomPort() bool {
func (n noopHostConfigurator) string() string {
return "noop"
}
+
+func (n noopHostConfigurator) getOriginalNameservers() []netip.Addr {
+ return nil
+}
+
+func (m *mockHostConfigurator) getOriginalNameservers() []netip.Addr {
+ return nil
+}
diff --git a/client/internal/dns/host_android.go b/client/internal/dns/host_android.go
index dfa3e5712..48b3e0301 100644
--- a/client/internal/dns/host_android.go
+++ b/client/internal/dns/host_android.go
@@ -1,14 +1,20 @@
package dns
import (
+ "net/netip"
+
"github.com/netbirdio/netbird/client/internal/statemanager"
)
+// androidHostManager is a noop on the OS side (Android's VPN service handles
+// DNS for us) but tracks the OS-reported resolver list pushed via
+// OnUpdatedHostDNSServer so it can serve as the fallback nameserver source.
type androidHostManager struct {
+ holder *hostsDNSHolder
}
-func newHostManager() (*androidHostManager, error) {
- return &androidHostManager{}, nil
+func newHostManager(holder *hostsDNSHolder) (*androidHostManager, error) {
+ return &androidHostManager{holder: holder}, nil
}
func (a androidHostManager) applyDNSConfig(HostDNSConfig, *statemanager.Manager) error {
@@ -26,3 +32,12 @@ func (a androidHostManager) supportCustomPort() bool {
func (a androidHostManager) string() string {
return "none"
}
+
+func (a androidHostManager) getOriginalNameservers() []netip.Addr {
+ hosts := a.holder.get()
+ out := make([]netip.Addr, 0, len(hosts))
+ for ap := range hosts {
+ out = append(out, ap.Addr())
+ }
+ return out
+}
diff --git a/client/internal/dns/host_darwin.go b/client/internal/dns/host_darwin.go
index b3908f163..0f4eb6bf8 100644
--- a/client/internal/dns/host_darwin.go
+++ b/client/internal/dns/host_darwin.go
@@ -298,6 +298,7 @@ func (s *systemConfigurator) getSystemDNSSettings() (SystemDNSSettings, error) {
if ip, err := netip.ParseAddr(address); err == nil && !ip.IsUnspecified() {
ip = ip.Unmap()
serverAddresses = append(serverAddresses, ip)
+ // Prefer the first IPv4 server as ServerIP since our DNS listener is IPv4.
if !dnsSettings.ServerIP.IsValid() && ip.Is4() {
dnsSettings.ServerIP = ip
}
diff --git a/client/internal/dns/host_ios.go b/client/internal/dns/host_ios.go
index 1c0ac63e9..860bb8b50 100644
--- a/client/internal/dns/host_ios.go
+++ b/client/internal/dns/host_ios.go
@@ -3,6 +3,7 @@ package dns
import (
"encoding/json"
"fmt"
+ "net/netip"
log "github.com/sirupsen/logrus"
@@ -20,6 +21,14 @@ func newHostManager(dnsManager IosDnsManager) (*iosHostManager, error) {
}, nil
}
+func (a iosHostManager) getOriginalNameservers() []netip.Addr {
+ // Quad9 v4+v6: 9.9.9.9, 2620:fe::fe.
+ return []netip.Addr{
+ netip.AddrFrom4([4]byte{9, 9, 9, 9}),
+ netip.AddrFrom16([16]byte{0x26, 0x20, 0x00, 0xfe, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0xfe}),
+ }
+}
+
func (a iosHostManager) applyDNSConfig(config HostDNSConfig, _ *statemanager.Manager) error {
jsonData, err := json.Marshal(config)
if err != nil {
diff --git a/client/internal/dns/host_windows.go b/client/internal/dns/host_windows.go
index 4a8cf8cec..4f6ece532 100644
--- a/client/internal/dns/host_windows.go
+++ b/client/internal/dns/host_windows.go
@@ -7,6 +7,7 @@ import (
"io"
"net/netip"
"os/exec"
+ "slices"
"strings"
"syscall"
"time"
@@ -44,9 +45,11 @@ const (
nrptMaxDomainsPerRule = 50
- interfaceConfigPath = `SYSTEM\CurrentControlSet\Services\Tcpip\Parameters\Interfaces`
- interfaceConfigNameServerKey = "NameServer"
- interfaceConfigSearchListKey = "SearchList"
+ interfaceConfigPath = `SYSTEM\CurrentControlSet\Services\Tcpip\Parameters\Interfaces`
+ interfaceConfigPathV6 = `SYSTEM\CurrentControlSet\Services\Tcpip6\Parameters\Interfaces`
+ interfaceConfigNameServerKey = "NameServer"
+ interfaceConfigDhcpNameSrvKey = "DhcpNameServer"
+ interfaceConfigSearchListKey = "SearchList"
// Network interface DNS registration settings
disableDynamicUpdateKey = "DisableDynamicUpdate"
@@ -67,10 +70,11 @@ const (
)
type registryConfigurator struct {
- guid string
- routingAll bool
- gpo bool
- nrptEntryCount int
+ guid string
+ routingAll bool
+ gpo bool
+ nrptEntryCount int
+ origNameservers []netip.Addr
}
func newHostManager(wgInterface WGIface) (*registryConfigurator, error) {
@@ -94,6 +98,17 @@ func newHostManager(wgInterface WGIface) (*registryConfigurator, error) {
gpo: useGPO,
}
+ origNameservers, err := configurator.captureOriginalNameservers()
+ switch {
+ case err != nil:
+ log.Warnf("capture original nameservers from non-WG adapters: %v", err)
+ case len(origNameservers) == 0:
+ log.Warnf("no original nameservers captured from non-WG adapters; DNS fallback will be empty")
+ default:
+ log.Debugf("captured %d original nameservers from non-WG adapters: %v", len(origNameservers), origNameservers)
+ }
+ configurator.origNameservers = origNameservers
+
if err := configurator.configureInterface(); err != nil {
log.Errorf("failed to configure interface settings: %v", err)
}
@@ -101,6 +116,98 @@ func newHostManager(wgInterface WGIface) (*registryConfigurator, error) {
return configurator, nil
}
+// captureOriginalNameservers reads DNS addresses from every Tcpip(6) interface
+// registry key except the WG adapter. v4 and v6 servers live in separate
+// hives (Tcpip vs Tcpip6) keyed by the same interface GUID.
+func (r *registryConfigurator) captureOriginalNameservers() ([]netip.Addr, error) {
+ seen := make(map[netip.Addr]struct{})
+ var out []netip.Addr
+ var merr *multierror.Error
+ for _, root := range []string{interfaceConfigPath, interfaceConfigPathV6} {
+ addrs, err := r.captureFromTcpipRoot(root)
+ if err != nil {
+ merr = multierror.Append(merr, fmt.Errorf("%s: %w", root, err))
+ continue
+ }
+ for _, addr := range addrs {
+ if _, dup := seen[addr]; dup {
+ continue
+ }
+ seen[addr] = struct{}{}
+ out = append(out, addr)
+ }
+ }
+ return out, nberrors.FormatErrorOrNil(merr)
+}
+
+func (r *registryConfigurator) captureFromTcpipRoot(rootPath string) ([]netip.Addr, error) {
+ root, err := registry.OpenKey(registry.LOCAL_MACHINE, rootPath, registry.READ)
+ if err != nil {
+ return nil, fmt.Errorf("open key: %w", err)
+ }
+ defer closer(root)
+
+ guids, err := root.ReadSubKeyNames(-1)
+ if err != nil {
+ return nil, fmt.Errorf("read subkeys: %w", err)
+ }
+
+ var out []netip.Addr
+ for _, guid := range guids {
+ if strings.EqualFold(guid, r.guid) {
+ continue
+ }
+ out = append(out, readInterfaceNameservers(rootPath, guid)...)
+ }
+ return out, nil
+}
+
+func readInterfaceNameservers(rootPath, guid string) []netip.Addr {
+ keyPath := rootPath + "\\" + guid
+ k, err := registry.OpenKey(registry.LOCAL_MACHINE, keyPath, registry.QUERY_VALUE)
+ if err != nil {
+ return nil
+ }
+ defer closer(k)
+
+ // Static NameServer wins over DhcpNameServer for actual resolution.
+ for _, name := range []string{interfaceConfigNameServerKey, interfaceConfigDhcpNameSrvKey} {
+ raw, _, err := k.GetStringValue(name)
+ if err != nil || raw == "" {
+ continue
+ }
+ if out := parseRegistryNameservers(raw); len(out) > 0 {
+ return out
+ }
+ }
+ return nil
+}
+
+func parseRegistryNameservers(raw string) []netip.Addr {
+ var out []netip.Addr
+ for _, field := range strings.FieldsFunc(raw, func(r rune) bool { return r == ',' || r == ' ' || r == '\t' }) {
+ addr, err := netip.ParseAddr(strings.TrimSpace(field))
+ if err != nil {
+ continue
+ }
+ addr = addr.Unmap()
+ if !addr.IsValid() || addr.IsUnspecified() {
+ continue
+ }
+ // Drop unzoned link-local: not routable without a scope id. If
+ // the user wrote "fe80::1%eth0" ParseAddr preserves the zone.
+ if addr.IsLinkLocalUnicast() && addr.Zone() == "" {
+ continue
+ }
+ out = append(out, addr)
+ }
+ return out
+}
+
+func (r *registryConfigurator) getOriginalNameservers() []netip.Addr {
+ return slices.Clone(r.origNameservers)
+}
+
func (r *registryConfigurator) supportCustomPort() bool {
return false
}
diff --git a/client/internal/dns/hosts_dns_holder.go b/client/internal/dns/hosts_dns_holder.go
index 980d917a7..9ecc397be 100644
--- a/client/internal/dns/hosts_dns_holder.go
+++ b/client/internal/dns/hosts_dns_holder.go
@@ -25,6 +25,7 @@ func (h *hostsDNSHolder) set(list []netip.AddrPort) {
h.mutex.Unlock()
}
+//nolint:unused
func (h *hostsDNSHolder) get() map[netip.AddrPort]struct{} {
h.mutex.RLock()
l := h.unprotectedDNSList
diff --git a/client/internal/dns/local/local.go b/client/internal/dns/local/local.go
index a67a23945..4a75a76b6 100644
--- a/client/internal/dns/local/local.go
+++ b/client/internal/dns/local/local.go
@@ -13,7 +13,6 @@ import (
"github.com/miekg/dns"
log "github.com/sirupsen/logrus"
- "golang.org/x/exp/maps"
"github.com/netbirdio/netbird/client/internal/dns/resutil"
"github.com/netbirdio/netbird/client/internal/dns/types"
@@ -67,9 +66,9 @@ func (d *Resolver) Stop() {
d.mu.Lock()
defer d.mu.Unlock()
- maps.Clear(d.records)
- maps.Clear(d.domains)
- maps.Clear(d.zones)
+ clear(d.records)
+ clear(d.domains)
+ clear(d.zones)
}
// ID returns the unique handler ID
@@ -77,8 +76,6 @@ func (d *Resolver) ID() types.HandlerID {
return "local-resolver"
}
-func (d *Resolver) ProbeAvailability(context.Context) {}
-
// ServeDNS handles a DNS request
func (d *Resolver) ServeDNS(w dns.ResponseWriter, r *dns.Msg) {
logger := log.WithFields(log.Fields{
@@ -444,9 +441,9 @@ func (d *Resolver) Update(customZones []nbdns.CustomZone) {
d.mu.Lock()
defer d.mu.Unlock()
- maps.Clear(d.records)
- maps.Clear(d.domains)
- maps.Clear(d.zones)
+ clear(d.records)
+ clear(d.domains)
+ clear(d.zones)
for _, zone := range customZones {
zoneDomain := domain.Domain(strings.ToLower(dns.Fqdn(zone.Domain)))
diff --git a/client/internal/dns/mock_server.go b/client/internal/dns/mock_server.go
index 548b1f54f..31fedd9e5 100644
--- a/client/internal/dns/mock_server.go
+++ b/client/internal/dns/mock_server.go
@@ -9,6 +9,7 @@ import (
dnsconfig "github.com/netbirdio/netbird/client/internal/dns/config"
nbdns "github.com/netbirdio/netbird/dns"
+ "github.com/netbirdio/netbird/route"
"github.com/netbirdio/netbird/shared/management/domain"
)
@@ -70,10 +71,6 @@ func (m *MockServer) SearchDomains() []string {
return make([]string, 0)
}
-// ProbeAvailability mocks implementation of ProbeAvailability from the Server interface
-func (m *MockServer) ProbeAvailability() {
-}
-
func (m *MockServer) UpdateServerConfig(domains dnsconfig.ServerDomains) error {
if m.UpdateServerConfigFunc != nil {
return m.UpdateServerConfigFunc(domains)
@@ -85,8 +82,8 @@ func (m *MockServer) PopulateManagementDomain(mgmtURL *url.URL) error {
return nil
}
-// SetRouteChecker mock implementation of SetRouteChecker from Server interface
-func (m *MockServer) SetRouteChecker(func(netip.Addr) bool) {
+// SetRouteSources mock implementation of SetRouteSources from Server interface
+func (m *MockServer) SetRouteSources(selected, active func() route.HAMap) {
// Mock implementation - no-op
}
diff --git a/client/internal/dns/network_manager_unix.go b/client/internal/dns/network_manager_unix.go
index e4ccc8cbd..3932e78b7 100644
--- a/client/internal/dns/network_manager_unix.go
+++ b/client/internal/dns/network_manager_unix.go
@@ -8,6 +8,7 @@ import (
"errors"
"fmt"
"net/netip"
+ "slices"
"strings"
"time"
@@ -32,6 +33,15 @@ const (
networkManagerDbusDeviceGetAppliedConnectionMethod = networkManagerDbusDeviceInterface + ".GetAppliedConnection"
networkManagerDbusDeviceReapplyMethod = networkManagerDbusDeviceInterface + ".Reapply"
networkManagerDbusDeviceDeleteMethod = networkManagerDbusDeviceInterface + ".Delete"
+ networkManagerDbusDeviceIp4ConfigProperty = networkManagerDbusDeviceInterface + ".Ip4Config"
+ networkManagerDbusDeviceIp6ConfigProperty = networkManagerDbusDeviceInterface + ".Ip6Config"
+ networkManagerDbusDeviceIfaceProperty = networkManagerDbusDeviceInterface + ".Interface"
+ networkManagerDbusGetDevicesMethod = networkManagerDest + ".GetDevices"
+ networkManagerDbusIp4ConfigInterface = "org.freedesktop.NetworkManager.IP4Config"
+ networkManagerDbusIp6ConfigInterface = "org.freedesktop.NetworkManager.IP6Config"
+ networkManagerDbusIp4ConfigNameserverDataProperty = networkManagerDbusIp4ConfigInterface + ".NameserverData"
+ networkManagerDbusIp4ConfigNameserversProperty = networkManagerDbusIp4ConfigInterface + ".Nameservers"
+ networkManagerDbusIp6ConfigNameserversProperty = networkManagerDbusIp6ConfigInterface + ".Nameservers"
networkManagerDbusDefaultBehaviorFlag networkManagerConfigBehavior = 0
networkManagerDbusIPv4Key = "ipv4"
networkManagerDbusIPv6Key = "ipv6"
@@ -51,9 +61,10 @@ var supportedNetworkManagerVersionConstraints = []string{
}
type networkManagerDbusConfigurator struct {
- dbusLinkObject dbus.ObjectPath
- routingAll bool
- ifaceName string
+ dbusLinkObject dbus.ObjectPath
+ routingAll bool
+ ifaceName string
+ origNameservers []netip.Addr
}
// the types below are based on dbus specification, each field is mapped to a dbus type
@@ -92,10 +103,200 @@ func newNetworkManagerDbusConfigurator(wgInterface string) (*networkManagerDbusC
log.Debugf("got network manager dbus Link Object: %s from net interface %s", s, wgInterface)
- return &networkManagerDbusConfigurator{
+ c := &networkManagerDbusConfigurator{
dbusLinkObject: dbus.ObjectPath(s),
ifaceName: wgInterface,
- }, nil
+ }
+
+ origNameservers, err := c.captureOriginalNameservers()
+ switch {
+ case err != nil:
+ log.Warnf("capture original nameservers from NetworkManager: %v", err)
+ case len(origNameservers) == 0:
+ log.Warnf("no original nameservers captured from non-WG NetworkManager devices; DNS fallback will be empty")
+ default:
+ log.Debugf("captured %d original nameservers from non-WG NetworkManager devices: %v", len(origNameservers), origNameservers)
+ }
+ c.origNameservers = origNameservers
+ return c, nil
+}
+
+// captureOriginalNameservers reads DNS servers from every NM device's
+// IP4Config / IP6Config except our WG device.
+func (n *networkManagerDbusConfigurator) captureOriginalNameservers() ([]netip.Addr, error) {
+ devices, err := networkManagerListDevices()
+ if err != nil {
+ return nil, fmt.Errorf("list devices: %w", err)
+ }
+
+ seen := make(map[netip.Addr]struct{})
+ var out []netip.Addr
+ for _, dev := range devices {
+ if dev == n.dbusLinkObject {
+ continue
+ }
+ ifaceName := readNetworkManagerDeviceInterface(dev)
+ for _, addr := range readNetworkManagerDeviceDNS(dev) {
+ addr = addr.Unmap()
+ if !addr.IsValid() || addr.IsUnspecified() {
+ continue
+ }
+ // IP6Config.Nameservers is a byte slice without zone info;
+ // reattach the device's interface name so a captured fe80::โฆ
+ // stays routable.
+ if addr.IsLinkLocalUnicast() && ifaceName != "" {
+ addr = addr.WithZone(ifaceName)
+ }
+ if _, dup := seen[addr]; dup {
+ continue
+ }
+ seen[addr] = struct{}{}
+ out = append(out, addr)
+ }
+ }
+ return out, nil
+}
+
+func readNetworkManagerDeviceInterface(devicePath dbus.ObjectPath) string {
+ obj, closeConn, err := getDbusObject(networkManagerDest, devicePath)
+ if err != nil {
+ return ""
+ }
+ defer closeConn()
+ v, err := obj.GetProperty(networkManagerDbusDeviceIfaceProperty)
+ if err != nil {
+ return ""
+ }
+ s, _ := v.Value().(string)
+ return s
+}
+
+func networkManagerListDevices() ([]dbus.ObjectPath, error) {
+ obj, closeConn, err := getDbusObject(networkManagerDest, networkManagerDbusObjectNode)
+ if err != nil {
+ return nil, fmt.Errorf("dbus NetworkManager: %w", err)
+ }
+ defer closeConn()
+ var devs []dbus.ObjectPath
+ if err := obj.Call(networkManagerDbusGetDevicesMethod, dbusDefaultFlag).Store(&devs); err != nil {
+ return nil, err
+ }
+ return devs, nil
+}
+
+func readNetworkManagerDeviceDNS(devicePath dbus.ObjectPath) []netip.Addr {
+ obj, closeConn, err := getDbusObject(networkManagerDest, devicePath)
+ if err != nil {
+ return nil
+ }
+ defer closeConn()
+
+ var out []netip.Addr
+ if path := readNetworkManagerConfigPath(obj, networkManagerDbusDeviceIp4ConfigProperty); path != "" {
+ out = append(out, readIPv4ConfigDNS(path)...)
+ }
+ if path := readNetworkManagerConfigPath(obj, networkManagerDbusDeviceIp6ConfigProperty); path != "" {
+ out = append(out, readIPv6ConfigDNS(path)...)
+ }
+ return out
+}
+
+func readNetworkManagerConfigPath(obj dbus.BusObject, property string) dbus.ObjectPath {
+ v, err := obj.GetProperty(property)
+ if err != nil {
+ return ""
+ }
+ path, ok := v.Value().(dbus.ObjectPath)
+ if !ok || path == "/" {
+ return ""
+ }
+ return path
+}
+
+func readIPv4ConfigDNS(path dbus.ObjectPath) []netip.Addr {
+ obj, closeConn, err := getDbusObject(networkManagerDest, path)
+ if err != nil {
+ return nil
+ }
+ defer closeConn()
+
+ // NameserverData (NM 1.13+) carries strings; older NMs only expose the
+ // legacy uint32 Nameservers property.
+ if out := readIPv4NameserverData(obj); len(out) > 0 {
+ return out
+ }
+ return readIPv4LegacyNameservers(obj)
+}
+
+func readIPv4NameserverData(obj dbus.BusObject) []netip.Addr {
+ v, err := obj.GetProperty(networkManagerDbusIp4ConfigNameserverDataProperty)
+ if err != nil {
+ return nil
+ }
+ entries, ok := v.Value().([]map[string]dbus.Variant)
+ if !ok {
+ return nil
+ }
+ var out []netip.Addr
+ for _, entry := range entries {
+ addrVar, ok := entry["address"]
+ if !ok {
+ continue
+ }
+ s, ok := addrVar.Value().(string)
+ if !ok {
+ continue
+ }
+ if a, err := netip.ParseAddr(s); err == nil {
+ out = append(out, a)
+ }
+ }
+ return out
+}
+
+func readIPv4LegacyNameservers(obj dbus.BusObject) []netip.Addr {
+ v, err := obj.GetProperty(networkManagerDbusIp4ConfigNameserversProperty)
+ if err != nil {
+ return nil
+ }
+ raw, ok := v.Value().([]uint32)
+ if !ok {
+ return nil
+ }
+ out := make([]netip.Addr, 0, len(raw))
+ for _, n := range raw {
+ var b [4]byte
+ binary.LittleEndian.PutUint32(b[:], n)
+ out = append(out, netip.AddrFrom4(b))
+ }
+ return out
+}
+
+func readIPv6ConfigDNS(path dbus.ObjectPath) []netip.Addr {
+ obj, closeConn, err := getDbusObject(networkManagerDest, path)
+ if err != nil {
+ return nil
+ }
+ defer closeConn()
+ v, err := obj.GetProperty(networkManagerDbusIp6ConfigNameserversProperty)
+ if err != nil {
+ return nil
+ }
+ raw, ok := v.Value().([][]byte)
+ if !ok {
+ return nil
+ }
+ out := make([]netip.Addr, 0, len(raw))
+ for _, b := range raw {
+ if a, ok := netip.AddrFromSlice(b); ok {
+ out = append(out, a)
+ }
+ }
+ return out
+}
+
+func (n *networkManagerDbusConfigurator) getOriginalNameservers() []netip.Addr {
+ return slices.Clone(n.origNameservers)
}
func (n *networkManagerDbusConfigurator) supportCustomPort() bool {
@@ -110,8 +311,25 @@ func (n *networkManagerDbusConfigurator) applyDNSConfig(config HostDNSConfig, st
connSettings.cleanDeprecatedSettings()
- convDNSIP := binary.LittleEndian.Uint32(config.ServerIP.AsSlice())
- connSettings[networkManagerDbusIPv4Key][networkManagerDbusDNSKey] = dbus.MakeVariant([]uint32{convDNSIP})
+ ipKey := networkManagerDbusIPv4Key
+ staleKey := networkManagerDbusIPv6Key
+ if config.ServerIP.Is6() {
+ ipKey = networkManagerDbusIPv6Key
+ staleKey = networkManagerDbusIPv4Key
+ raw := config.ServerIP.As16()
+ connSettings[ipKey][networkManagerDbusDNSKey] = dbus.MakeVariant([][]byte{raw[:]})
+ } else {
+ convDNSIP := binary.LittleEndian.Uint32(config.ServerIP.AsSlice())
+ connSettings[ipKey][networkManagerDbusDNSKey] = dbus.MakeVariant([]uint32{convDNSIP})
+ }
+
+ // Clear stale DNS settings from the opposite address family to avoid
+ // leftover entries if the server IP family changed.
+ if staleSettings, ok := connSettings[staleKey]; ok {
+ delete(staleSettings, networkManagerDbusDNSKey)
+ delete(staleSettings, networkManagerDbusDNSPriorityKey)
+ delete(staleSettings, networkManagerDbusDNSSearchKey)
+ }
var (
searchDomains []string
matchDomains []string
@@ -146,8 +364,8 @@ func (n *networkManagerDbusConfigurator) applyDNSConfig(config HostDNSConfig, st
n.routingAll = false
}
- connSettings[networkManagerDbusIPv4Key][networkManagerDbusDNSPriorityKey] = dbus.MakeVariant(priority)
- connSettings[networkManagerDbusIPv4Key][networkManagerDbusDNSSearchKey] = dbus.MakeVariant(newDomainList)
+ connSettings[ipKey][networkManagerDbusDNSPriorityKey] = dbus.MakeVariant(priority)
+ connSettings[ipKey][networkManagerDbusDNSSearchKey] = dbus.MakeVariant(newDomainList)
state := &ShutdownState{
ManagerType: networkManager,
diff --git a/client/internal/dns/server.go b/client/internal/dns/server.go
index d4f54dec5..e689f3586 100644
--- a/client/internal/dns/server.go
+++ b/client/internal/dns/server.go
@@ -6,11 +6,10 @@ import (
"fmt"
"net/netip"
"net/url"
- "os"
- "runtime"
- "strconv"
+ "slices"
"strings"
"sync"
+ "time"
"github.com/miekg/dns"
"github.com/mitchellh/hashstructure/v2"
@@ -25,11 +24,31 @@ import (
"github.com/netbirdio/netbird/client/internal/listener"
"github.com/netbirdio/netbird/client/internal/peer"
"github.com/netbirdio/netbird/client/internal/statemanager"
+ "github.com/netbirdio/netbird/client/proto"
nbdns "github.com/netbirdio/netbird/dns"
+ "github.com/netbirdio/netbird/route"
"github.com/netbirdio/netbird/shared/management/domain"
)
-const envSkipDNSProbe = "NB_SKIP_DNS_PROBE"
+const (
+ // healthLookback must exceed the upstream query timeout so one
+ // query per refresh cycle is enough to keep a group marked healthy.
+ healthLookback = 60 * time.Second
+ nsGroupHealthRefreshInterval = 10 * time.Second
+ // defaultWarningDelayBase is the starting grace window before a
+ // "Nameserver group unreachable" event fires for a group that's
+ // never been healthy and only has overlay upstreams with no
+ // Connected peer. Per-server and overridable; see warningDelayFor.
+ defaultWarningDelayBase = 30 * time.Second
+ // warningDelayBonusCap caps the route-count bonus added to the
+ // base grace window. See warningDelayFor.
+ warningDelayBonusCap = 30 * time.Second
+)
+
+// errNoUsableNameservers signals that a merged-domain group has no usable
+// upstream servers. Callers should skip the group without treating it as a
+// build failure.
+var errNoUsableNameservers = errors.New("no usable nameservers")
// ReadyListener is a notification mechanism what indicate the server is ready to handle host dns address changes
type ReadyListener interface {
@@ -54,10 +73,9 @@ type Server interface {
UpdateDNSServer(serial uint64, update nbdns.Config) error
OnUpdatedHostDNSServer(addrs []netip.AddrPort)
SearchDomains() []string
- ProbeAvailability()
UpdateServerConfig(domains dnsconfig.ServerDomains) error
PopulateManagementDomain(mgmtURL *url.URL) error
- SetRouteChecker(func(netip.Addr) bool)
+ SetRouteSources(selected, active func() route.HAMap)
SetFirewall(Firewall)
}
@@ -66,12 +84,47 @@ type nsGroupsByDomain struct {
groups []*nbdns.NameServerGroup
}
-// hostManagerWithOriginalNS extends the basic hostManager interface
-type hostManagerWithOriginalNS interface {
- hostManager
- getOriginalNameservers() []netip.Addr
+// nsGroupID identifies a nameserver group by the tuple (server list, domain
+// list) so config updates produce stable IDs across recomputations.
+type nsGroupID string
+
+// nsHealthSnapshot is the input to projectNSGroupHealth, captured under
+// s.mux so projection runs lock-free.
+type nsHealthSnapshot struct {
+ groups []*nbdns.NameServerGroup
+ merged map[netip.AddrPort]UpstreamHealth
+ selected route.HAMap
+ active route.HAMap
}
+// nsGroupProj holds per-group state for the emission rules.
+type nsGroupProj struct {
+ // unhealthySince is the start of the current Unhealthy streak,
+ // zero when the group is not currently Unhealthy.
+ unhealthySince time.Time
+ // everHealthy is sticky: once the group has been Healthy at least
+ // once this session, subsequent failures skip warningDelay.
+ everHealthy bool
+ // warningActive tracks whether we've already published a warning
+ // for the current streak, so recovery emits iff a warning did.
+ warningActive bool
+}
+
+// nsGroupVerdict is the outcome of evaluateNSGroupHealth.
+type nsGroupVerdict int
+
+const (
+ // nsVerdictUndecided means no upstream has a fresh observation
+ // (startup before first query, or records aged past healthLookback).
+ nsVerdictUndecided nsGroupVerdict = iota
+ // nsVerdictHealthy means at least one upstream's most-recent
+ // in-lookback observation is a success.
+ nsVerdictHealthy
+ // nsVerdictUnhealthy means at least one upstream has a recent
+ // failure and none has a fresher success.
+ nsVerdictUnhealthy
+)
+
// DefaultServer dns server object
type DefaultServer struct {
ctx context.Context
@@ -100,26 +153,46 @@ type DefaultServer struct {
permanent bool
hostsDNSHolder *hostsDNSHolder
+ // fallbackHandler is the upstream resolver currently registered at
+ // PriorityFallback. Tracked so registerFallback can Stop() the previous
+ // instance instead of leaking its context.
+ fallbackHandler handlerWithStop
+
// make sense on mobile only
searchDomainNotifier *notifier
iosDnsManager IosDnsManager
statusRecorder *peer.Status
stateManager *statemanager.Manager
- routeMatch func(netip.Addr) bool
+ // selectedRoutes returns admin-enabled client routes.
+ selectedRoutes func() route.HAMap
+ // activeRoutes returns the subset whose peer is in StatusConnected.
+ activeRoutes func() route.HAMap
- probeMu sync.Mutex
- probeCancel context.CancelFunc
- probeWg sync.WaitGroup
+ nsGroups []*nbdns.NameServerGroup
+ healthProjectMu sync.Mutex
+ // nsGroupProj is the per-group state used by the emission rules.
+ // Accessed only under healthProjectMu.
+ nsGroupProj map[nsGroupID]*nsGroupProj
+ // warningDelayBase is the base grace window for health projection.
+ // Set at construction, mutated only by tests. Read by the
+ // refresher goroutine so never change it while one is running.
+ warningDelayBase time.Duration
+ // healthRefresh is buffered=1; writers coalesce, senders never block.
+ // See refreshHealth for the lock-order rationale.
+ healthRefresh chan struct{}
}
type handlerWithStop interface {
dns.Handler
Stop()
- ProbeAvailability(context.Context)
ID() types.HandlerID
}
+type upstreamHealthReporter interface {
+ UpstreamHealth() map[netip.AddrPort]UpstreamHealth
+}
+
type handlerWrapper struct {
domain string
handler handlerWithStop
@@ -174,7 +247,6 @@ func NewDefaultServerPermanentUpstream(
ds.hostsDNSHolder.set(hostsDnsList)
ds.permanent = true
- ds.addHostRootZone()
ds.currentConfig = dnsConfigToHostDNSConfig(config, ds.service.RuntimeIP(), ds.service.RuntimePort())
ds.searchDomainNotifier = newNotifier(ds.SearchDomains())
ds.searchDomainNotifier.setListener(listener)
@@ -182,21 +254,17 @@ func NewDefaultServerPermanentUpstream(
return ds
}
-// NewDefaultServerIos returns a new dns server. It optimized for ios
+// NewDefaultServerIos returns a new dns server. It optimized for ios.
func NewDefaultServerIos(
ctx context.Context,
wgInterface WGIface,
iosDnsManager IosDnsManager,
- hostsDnsList []netip.AddrPort,
statusRecorder *peer.Status,
disableSys bool,
) *DefaultServer {
- log.Debugf("iOS host dns address list is: %v", hostsDnsList)
ds := newDefaultServer(ctx, wgInterface, NewServiceViaMemory(wgInterface), statusRecorder, nil, disableSys)
ds.iosDnsManager = iosDnsManager
- ds.hostsDNSHolder.set(hostsDnsList)
ds.permanent = true
- ds.addHostRootZone()
return ds
}
@@ -230,6 +298,8 @@ func newDefaultServer(
hostManager: &noopHostConfigurator{},
mgmtCacheResolver: mgmtCacheResolver,
currentConfigHash: ^uint64(0), // Initialize to max uint64 to ensure first config is always applied
+ warningDelayBase: defaultWarningDelayBase,
+ healthRefresh: make(chan struct{}, 1),
}
// register with root zone, handler chain takes care of the routing
@@ -238,12 +308,26 @@ func newDefaultServer(
return defaultServer
}
-// SetRouteChecker sets the function used by upstream resolvers to determine
-// whether an IP is routed through the tunnel.
-func (s *DefaultServer) SetRouteChecker(f func(netip.Addr) bool) {
+// SetRouteSources wires the route-manager accessors used by health
+// projection to classify each upstream for emission timing.
+func (s *DefaultServer) SetRouteSources(selected, active func() route.HAMap) {
s.mux.Lock()
defer s.mux.Unlock()
- s.routeMatch = f
+ s.selectedRoutes = selected
+ s.activeRoutes = active
+
+ // Permanent / iOS constructors build the root handler before the
+ // engine wires route sources, so its selectedRoutes callback would
+ // otherwise remain nil and overlay upstreams would be classified
+ // as public. Propagate the new accessors to existing handlers.
+ type routeSettable interface {
+ setSelectedRoutes(func() route.HAMap)
+ }
+ for _, entry := range s.dnsMuxMap {
+ if h, ok := entry.handler.(routeSettable); ok {
+ h.setSelectedRoutes(selected)
+ }
+ }
}
// RegisterHandler registers a handler for the given domains with the given priority.
@@ -256,7 +340,6 @@ func (s *DefaultServer) RegisterHandler(domains domain.List, handler dns.Handler
// TODO: This will take over zones for non-wildcard domains, for which we might not have a handler in the chain
for _, domain := range domains {
- // convert to zone with simple ref counter
s.extraDomains[toZone(domain)]++
}
if !s.batchMode {
@@ -357,6 +440,8 @@ func (s *DefaultServer) Initialize() (err error) {
s.stateManager.RegisterState(&ShutdownState{})
+ s.startHealthRefresher()
+
// Keep using noop host manager if dns off requested or running in netstack mode.
// Netstack mode currently doesn't have a way to receive DNS requests.
// TODO: Use listener on localhost in netstack mode when running as root.
@@ -370,6 +455,13 @@ func (s *DefaultServer) Initialize() (err error) {
return fmt.Errorf("initialize: %w", err)
}
s.hostManager = hostManager
+ // On mobile-permanent setups the seeded host DNS list is the only
+ // source until the first network-map arrives; register it now so DNS
+ // works in that window. Desktop host managers register fallback when
+ // applyConfiguration runs.
+ if s.permanent {
+ s.registerFallback()
+ }
return nil
}
@@ -394,13 +486,7 @@ func (s *DefaultServer) SetFirewall(fw Firewall) {
// Stop stops the server
func (s *DefaultServer) Stop() {
- s.probeMu.Lock()
- if s.probeCancel != nil {
- s.probeCancel()
- }
s.ctxCancel()
- s.probeMu.Unlock()
- s.probeWg.Wait()
s.shutdownWg.Wait()
s.mux.Lock()
@@ -410,7 +496,14 @@ func (s *DefaultServer) Stop() {
log.Errorf("failed to disable DNS: %v", err)
}
- maps.Clear(s.extraDomains)
+ clear(s.extraDomains)
+
+ // Clear health projection state so a subsequent Start doesn't
+ // inherit sticky flags (notably everHealthy) that would bypass
+ // the grace window during the next peer handshake.
+ s.healthProjectMu.Lock()
+ s.nsGroupProj = nil
+ s.healthProjectMu.Unlock()
}
func (s *DefaultServer) disableDNS() (retErr error) {
@@ -424,10 +517,9 @@ func (s *DefaultServer) disableDNS() (retErr error) {
return nil
}
- // Deregister original nameservers if they were registered as fallback
- if srvs, ok := s.hostManager.(hostManagerWithOriginalNS); ok && len(srvs.getOriginalNameservers()) > 0 {
- log.Debugf("deregistering original nameservers as fallback handlers")
- s.deregisterHandler([]string{nbdns.RootZone}, PriorityFallback)
+ if s.fallbackHandler != nil {
+ log.Debugf("deregistering fallback handlers")
+ s.clearFallback()
}
if err := s.hostManager.restoreHostDNS(); err != nil {
@@ -441,27 +533,16 @@ func (s *DefaultServer) disableDNS() (retErr error) {
return nil
}
-// OnUpdatedHostDNSServer update the DNS servers addresses for root zones
-// It will be applied if the mgm server do not enforce DNS settings for root zone
+// OnUpdatedHostDNSServer updates the fallback DNS upstreams. Called by Android
+// outside the engine's sync mux when the OS reports a network change, so it
+// takes s.mux to serialize against host manager swaps in Initialize/enableDNS.
func (s *DefaultServer) OnUpdatedHostDNSServer(hostsDnsList []netip.AddrPort) {
s.hostsDNSHolder.set(hostsDnsList)
-
- // Check if there's any root handler
- var hasRootHandler bool
- for _, handler := range s.dnsMuxMap {
- if handler.domain == nbdns.RootZone {
- hasRootHandler = true
- break
- }
- }
-
- if hasRootHandler {
- log.Debugf("on new host DNS config but skip to apply it")
- return
- }
-
log.Debugf("update host DNS settings: %+v", hostsDnsList)
- s.addHostRootZone()
+
+ s.mux.Lock()
+ defer s.mux.Unlock()
+ s.registerFallback()
}
// UpdateDNSServer processes an update received from the management service
@@ -520,69 +601,6 @@ func (s *DefaultServer) SearchDomains() []string {
return searchDomains
}
-// ProbeAvailability tests each upstream group's servers for availability
-// and deactivates the group if no server responds.
-// If a previous probe is still running, it will be cancelled before starting a new one.
-func (s *DefaultServer) ProbeAvailability() {
- if val := os.Getenv(envSkipDNSProbe); val != "" {
- skipProbe, err := strconv.ParseBool(val)
- if err != nil {
- log.Warnf("failed to parse %s: %v", envSkipDNSProbe, err)
- }
- if skipProbe {
- log.Infof("skipping DNS probe due to %s", envSkipDNSProbe)
- return
- }
- }
-
- s.probeMu.Lock()
-
- // don't start probes on a stopped server
- if s.ctx.Err() != nil {
- s.probeMu.Unlock()
- return
- }
-
- // cancel any running probe
- if s.probeCancel != nil {
- s.probeCancel()
- s.probeCancel = nil
- }
-
- // wait for the previous probe goroutines to finish while holding
- // the mutex so no other caller can start a new probe concurrently
- s.probeWg.Wait()
-
- // start a new probe
- probeCtx, probeCancel := context.WithCancel(s.ctx)
- s.probeCancel = probeCancel
-
- s.probeWg.Add(1)
- defer s.probeWg.Done()
-
- // Snapshot handlers under s.mux to avoid racing with updateMux/dnsMuxMap writers.
- s.mux.Lock()
- handlers := make([]handlerWithStop, 0, len(s.dnsMuxMap))
- for _, mux := range s.dnsMuxMap {
- handlers = append(handlers, mux.handler)
- }
- s.mux.Unlock()
-
- var wg sync.WaitGroup
- for _, handler := range handlers {
- wg.Add(1)
- go func(h handlerWithStop) {
- defer wg.Done()
- h.ProbeAvailability(probeCtx)
- }(handler)
- }
-
- s.probeMu.Unlock()
-
- wg.Wait()
- probeCancel()
-}
-
func (s *DefaultServer) UpdateServerConfig(domains dnsconfig.ServerDomains) error {
s.mux.Lock()
defer s.mux.Unlock()
@@ -746,19 +764,17 @@ func (s *DefaultServer) applyHostConfig() {
s.currentConfigHash = hash
}
- s.registerFallback(config)
+ s.registerFallback()
}
// registerFallback registers original nameservers as low-priority fallback handlers.
-func (s *DefaultServer) registerFallback(config HostDNSConfig) {
- hostMgrWithNS, ok := s.hostManager.(hostManagerWithOriginalNS)
- if !ok {
- return
- }
-
- originalNameservers := hostMgrWithNS.getOriginalNameservers()
+// Replaces and Stop()s the previously-registered fallback handler so its
+// context is released rather than leaked until GC.
+func (s *DefaultServer) registerFallback() {
+ originalNameservers := s.hostManager.getOriginalNameservers()
if len(originalNameservers) == 0 {
- s.deregisterHandler([]string{nbdns.RootZone}, PriorityFallback)
+ log.Debugf("no fallback upstreams to register; clearing PriorityFallback handler")
+ s.clearFallback()
return
}
@@ -775,21 +791,28 @@ func (s *DefaultServer) registerFallback(config HostDNSConfig) {
log.Errorf("failed to create upstream resolver for original nameservers: %v", err)
return
}
- handler.routeMatch = s.routeMatch
+ handler.selectedRoutes = s.selectedRoutes
+ var servers []netip.AddrPort
for _, ns := range originalNameservers {
- if ns == config.ServerIP {
- log.Debugf("skipping original nameserver %s as it is the same as the server IP %s", ns, config.ServerIP)
- continue
- }
-
- addrPort := netip.AddrPortFrom(ns, DefaultPort)
- handler.upstreamServers = append(handler.upstreamServers, addrPort)
+ servers = append(servers, netip.AddrPortFrom(ns, DefaultPort))
}
- handler.deactivate = func(error) { /* always active */ }
- handler.reactivate = func() { /* always active */ }
+ handler.addRace(servers)
+ prev := s.fallbackHandler
+ s.fallbackHandler = handler
s.registerHandler([]string{nbdns.RootZone}, handler, PriorityFallback)
+ if prev != nil {
+ prev.Stop()
+ }
+}
+
+func (s *DefaultServer) clearFallback() {
+ s.deregisterHandler([]string{nbdns.RootZone}, PriorityFallback)
+ if s.fallbackHandler != nil {
+ s.fallbackHandler.Stop()
+ s.fallbackHandler = nil
+ }
}
func (s *DefaultServer) buildLocalHandlerUpdate(customZones []nbdns.CustomZone) ([]handlerWrapper, []nbdns.CustomZone, error) {
@@ -847,100 +870,99 @@ func (s *DefaultServer) buildUpstreamHandlerUpdate(nameServerGroups []*nbdns.Nam
groupedNS := groupNSGroupsByDomain(nameServerGroups)
for _, domainGroup := range groupedNS {
- basePriority := PriorityUpstream
+ priority := PriorityUpstream
if domainGroup.domain == nbdns.RootZone {
- basePriority = PriorityDefault
+ priority = PriorityDefault
}
- updates, err := s.createHandlersForDomainGroup(domainGroup, basePriority)
+ update, err := s.buildMergedDomainHandler(domainGroup, priority)
if err != nil {
+ if errors.Is(err, errNoUsableNameservers) {
+ log.Errorf("no usable nameservers for domain=%s", domainGroup.domain)
+ continue
+ }
return nil, err
}
- muxUpdates = append(muxUpdates, updates...)
+ muxUpdates = append(muxUpdates, *update)
}
return muxUpdates, nil
}
-func (s *DefaultServer) createHandlersForDomainGroup(domainGroup nsGroupsByDomain, basePriority int) ([]handlerWrapper, error) {
- var muxUpdates []handlerWrapper
+// buildMergedDomainHandler merges every nameserver group that targets the
+// same domain into one handler whose inner groups are raced in parallel.
+func (s *DefaultServer) buildMergedDomainHandler(domainGroup nsGroupsByDomain, priority int) (*handlerWrapper, error) {
+ handler, err := newUpstreamResolver(
+ s.ctx,
+ s.wgInterface,
+ s.statusRecorder,
+ s.hostsDNSHolder,
+ domain.Domain(domainGroup.domain),
+ )
+ if err != nil {
+ return nil, fmt.Errorf("create upstream resolver: %v", err)
+ }
+ handler.selectedRoutes = s.selectedRoutes
- for i, nsGroup := range domainGroup.groups {
- // Decrement priority by handler index (0, 1, 2, ...) to avoid conflicts
- priority := basePriority - i
-
- // Check if we're about to overlap with the next priority tier
- if s.leaksPriority(domainGroup, basePriority, priority) {
- break
- }
-
- log.Debugf("creating handler for domain=%s with priority=%d", domainGroup.domain, priority)
- handler, err := newUpstreamResolver(
- s.ctx,
- s.wgInterface,
- s.statusRecorder,
- s.hostsDNSHolder,
- domainGroup.domain,
- )
- if err != nil {
- return nil, fmt.Errorf("create upstream resolver: %v", err)
- }
- handler.routeMatch = s.routeMatch
-
- for _, ns := range nsGroup.NameServers {
- if ns.NSType != nbdns.UDPNameServerType {
- log.Warnf("skipping nameserver %s with type %s, this peer supports only %s",
- ns.IP.String(), ns.NSType.String(), nbdns.UDPNameServerType.String())
- continue
- }
-
- if ns.IP == s.service.RuntimeIP() {
- log.Warnf("skipping nameserver %s as it matches our DNS server IP, preventing potential loop", ns.IP)
- continue
- }
-
- handler.upstreamServers = append(handler.upstreamServers, ns.AddrPort())
- }
-
- if len(handler.upstreamServers) == 0 {
- handler.Stop()
- log.Errorf("received a nameserver group with an invalid nameserver list")
+ for _, nsGroup := range domainGroup.groups {
+ servers := s.filterNameServers(nsGroup.NameServers)
+ if len(servers) == 0 {
+ log.Warnf("nameserver group for domain=%s yielded no usable servers, skipping", domainGroup.domain)
continue
}
-
- // when upstream fails to resolve domain several times over all it servers
- // it will calls this hook to exclude self from the configuration and
- // reapply DNS settings, but it not touch the original configuration and serial number
- // because it is temporal deactivation until next try
- //
- // after some period defined by upstream it tries to reactivate self by calling this hook
- // everything we need here is just to re-apply current configuration because it already
- // contains this upstream settings (temporal deactivation not removed it)
- handler.deactivate, handler.reactivate = s.upstreamCallbacks(nsGroup, handler, priority)
-
- muxUpdates = append(muxUpdates, handlerWrapper{
- domain: domainGroup.domain,
- handler: handler,
- priority: priority,
- })
+ handler.addRace(servers)
}
- return muxUpdates, nil
+ if len(handler.upstreamServers) == 0 {
+ handler.Stop()
+ return nil, errNoUsableNameservers
+ }
+
+ log.Debugf("creating merged handler for domain=%s with %d group(s) priority=%d", domainGroup.domain, len(handler.upstreamServers), priority)
+
+ return &handlerWrapper{
+ domain: domainGroup.domain,
+ handler: handler,
+ priority: priority,
+ }, nil
}
-func (s *DefaultServer) leaksPriority(domainGroup nsGroupsByDomain, basePriority int, priority int) bool {
- if basePriority == PriorityUpstream && priority <= PriorityDefault {
- log.Warnf("too many handlers for domain=%s, would overlap with default priority tier (diff=%d). Skipping remaining handlers",
- domainGroup.domain, PriorityUpstream-PriorityDefault)
- return true
- }
- if basePriority == PriorityDefault && priority <= PriorityFallback {
- log.Warnf("too many handlers for domain=%s, would overlap with fallback priority tier (diff=%d). Skipping remaining handlers",
- domainGroup.domain, PriorityDefault-PriorityFallback)
- return true
+func (s *DefaultServer) filterNameServers(nameServers []nbdns.NameServer) []netip.AddrPort {
+ var out []netip.AddrPort
+ for _, ns := range nameServers {
+ if ns.NSType != nbdns.UDPNameServerType {
+ log.Warnf("skipping nameserver %s with type %s, this peer supports only %s",
+ ns.IP.String(), ns.NSType.String(), nbdns.UDPNameServerType.String())
+ continue
+ }
+ if ns.IP == s.service.RuntimeIP() {
+ log.Warnf("skipping nameserver %s as it matches our DNS server IP, preventing potential loop", ns.IP)
+ continue
+ }
+ out = append(out, ns.AddrPort())
}
+ return out
+}
- return false
+// usableNameServers returns the subset of nameServers the handler would
+// actually query. Matches filterNameServers without the warning logs, so
+// it's safe to call on every health-projection tick.
+func (s *DefaultServer) usableNameServers(nameServers []nbdns.NameServer) []netip.AddrPort {
+ var runtimeIP netip.Addr
+ if s.service != nil {
+ runtimeIP = s.service.RuntimeIP()
+ }
+ var out []netip.AddrPort
+ for _, ns := range nameServers {
+ if ns.NSType != nbdns.UDPNameServerType {
+ continue
+ }
+ if runtimeIP.IsValid() && ns.IP == runtimeIP {
+ continue
+ }
+ out = append(out, ns.AddrPort())
+ }
+ return out
}
func (s *DefaultServer) updateMux(muxUpdates []handlerWrapper) {
@@ -951,175 +973,356 @@ func (s *DefaultServer) updateMux(muxUpdates []handlerWrapper) {
}
muxUpdateMap := make(registeredHandlerMap)
- var containsRootUpdate bool
for _, update := range muxUpdates {
- if update.domain == nbdns.RootZone {
- containsRootUpdate = true
- }
s.registerHandler([]string{update.domain}, update.handler, update.priority)
muxUpdateMap[update.handler.ID()] = update
}
- // If there's no root update and we had a root handler, restore it
- if !containsRootUpdate {
- for _, existing := range s.dnsMuxMap {
- if existing.domain == nbdns.RootZone {
- s.addHostRootZone()
- break
- }
- }
- }
-
s.dnsMuxMap = muxUpdateMap
}
-// upstreamCallbacks returns two functions, the first one is used to deactivate
-// the upstream resolver from the configuration, the second one is used to
-// reactivate it. Not allowed to call reactivate before deactivate.
-func (s *DefaultServer) upstreamCallbacks(
- nsGroup *nbdns.NameServerGroup,
- handler dns.Handler,
- priority int,
-) (deactivate func(error), reactivate func()) {
- var removeIndex map[string]int
- deactivate = func(err error) {
- s.mux.Lock()
- defer s.mux.Unlock()
-
- l := log.WithField("nameservers", nsGroup.NameServers)
- l.Info("Temporarily deactivating nameservers group due to timeout")
-
- removeIndex = make(map[string]int)
- for _, domain := range nsGroup.Domains {
- removeIndex[domain] = -1
- }
- if nsGroup.Primary {
- removeIndex[nbdns.RootZone] = -1
- s.currentConfig.RouteAll = false
- s.deregisterHandler([]string{nbdns.RootZone}, priority)
- }
-
- for i, item := range s.currentConfig.Domains {
- if _, found := removeIndex[item.Domain]; found {
- s.currentConfig.Domains[i].Disabled = true
- s.deregisterHandler([]string{item.Domain}, priority)
- removeIndex[item.Domain] = i
- }
- }
-
- // Always apply host config when nameserver goes down, regardless of batch mode
- s.applyHostConfig()
-
- go func() {
- if err := s.stateManager.PersistState(s.ctx); err != nil {
- l.Errorf("Failed to persist dns state: %v", err)
- }
- }()
-
- if runtime.GOOS == "android" && nsGroup.Primary && len(s.hostsDNSHolder.get()) > 0 {
- s.addHostRootZone()
- }
-
- s.updateNSState(nsGroup, err, false)
- }
-
- reactivate = func() {
- s.mux.Lock()
- defer s.mux.Unlock()
-
- for domain, i := range removeIndex {
- if i == -1 || i >= len(s.currentConfig.Domains) || s.currentConfig.Domains[i].Domain != domain {
- continue
- }
- s.currentConfig.Domains[i].Disabled = false
- s.registerHandler([]string{domain}, handler, priority)
- }
-
- l := log.WithField("nameservers", nsGroup.NameServers)
- l.Debug("reactivate temporary disabled nameserver group")
-
- if nsGroup.Primary {
- s.currentConfig.RouteAll = true
- s.registerHandler([]string{nbdns.RootZone}, handler, priority)
- }
-
- // Always apply host config when nameserver reactivates, regardless of batch mode
- s.applyHostConfig()
-
- s.updateNSState(nsGroup, nil, true)
- }
- return
-}
-
-func (s *DefaultServer) addHostRootZone() {
- hostDNSServers := s.hostsDNSHolder.get()
- if len(hostDNSServers) == 0 {
- log.Debug("no host DNS servers available, skipping root zone handler creation")
- return
- }
-
- handler, err := newUpstreamResolver(
- s.ctx,
- s.wgInterface,
- s.statusRecorder,
- s.hostsDNSHolder,
- nbdns.RootZone,
- )
- if err != nil {
- log.Errorf("unable to create a new upstream resolver, error: %v", err)
- return
- }
- handler.routeMatch = s.routeMatch
-
- handler.upstreamServers = maps.Keys(hostDNSServers)
- handler.deactivate = func(error) {}
- handler.reactivate = func() {}
-
- s.registerHandler([]string{nbdns.RootZone}, handler, PriorityDefault)
-}
-
+// updateNSGroupStates records the new group set and pokes the refresher.
+// Must hold s.mux; projection runs async (see refreshHealth for why).
func (s *DefaultServer) updateNSGroupStates(groups []*nbdns.NameServerGroup) {
- var states []peer.NSGroupState
+ s.nsGroups = groups
+ select {
+ case s.healthRefresh <- struct{}{}:
+ default:
+ }
+}
- for _, group := range groups {
- var servers []netip.AddrPort
- for _, ns := range group.NameServers {
- servers = append(servers, ns.AddrPort())
+// refreshHealth runs one projection cycle. Must not be called while
+// holding s.mux: the route callbacks re-enter routemanager's lock.
+func (s *DefaultServer) refreshHealth() {
+ s.mux.Lock()
+ groups := s.nsGroups
+ merged := s.collectUpstreamHealth()
+ selFn := s.selectedRoutes
+ actFn := s.activeRoutes
+ s.mux.Unlock()
+
+ var selected, active route.HAMap
+ if selFn != nil {
+ selected = selFn()
+ }
+ if actFn != nil {
+ active = actFn()
+ }
+
+ s.projectNSGroupHealth(nsHealthSnapshot{
+ groups: groups,
+ merged: merged,
+ selected: selected,
+ active: active,
+ })
+}
+
+// projectNSGroupHealth applies the emission rules to the snapshot and
+// publishes the resulting NSGroupStates. Serialized by healthProjectMu,
+// lock-free wrt s.mux.
+//
+// Rules:
+// - Healthy: emit recovery iff warningActive; set everHealthy.
+// - Unhealthy: stamp unhealthySince on streak start; emit warning
+// iff any of immediate / everHealthy / elapsed >= effective delay.
+// - Undecided: no-op.
+//
+// "Immediate" means the group has at least one upstream that's public
+// or overlay+Connected: no peer-startup race to wait out.
+func (s *DefaultServer) projectNSGroupHealth(snap nsHealthSnapshot) {
+ if s.statusRecorder == nil {
+ return
+ }
+
+ s.healthProjectMu.Lock()
+ defer s.healthProjectMu.Unlock()
+
+ if s.nsGroupProj == nil {
+ s.nsGroupProj = make(map[nsGroupID]*nsGroupProj)
+ }
+
+ now := time.Now()
+ delay := s.warningDelay(haMapRouteCount(snap.selected))
+ states := make([]peer.NSGroupState, 0, len(snap.groups))
+ seen := make(map[nsGroupID]struct{}, len(snap.groups))
+ for _, group := range snap.groups {
+ servers := s.usableNameServers(group.NameServers)
+ if len(servers) == 0 {
+ continue
+ }
+ verdict, groupErr := evaluateNSGroupHealth(snap.merged, servers, now)
+ id := generateGroupKey(group)
+ seen[id] = struct{}{}
+
+ immediate := s.groupHasImmediateUpstream(servers, snap)
+
+ p, known := s.nsGroupProj[id]
+ if !known {
+ p = &nsGroupProj{}
+ s.nsGroupProj[id] = p
}
- state := peer.NSGroupState{
- ID: generateGroupKey(group),
+ enabled := true
+ switch verdict {
+ case nsVerdictHealthy:
+ enabled = s.projectHealthy(p, servers)
+ case nsVerdictUnhealthy:
+ enabled = s.projectUnhealthy(p, servers, immediate, now, delay)
+ case nsVerdictUndecided:
+ // Stay Available until evidence says otherwise, unless a
+ // warning is already active for this group. Also clear any
+ // prior Unhealthy streak so a later Unhealthy verdict starts
+ // a fresh grace window rather than inheriting a stale one.
+ p.unhealthySince = time.Time{}
+ enabled = !p.warningActive
+ groupErr = nil
+ }
+
+ states = append(states, peer.NSGroupState{
+ ID: string(id),
Servers: servers,
Domains: group.Domains,
- // The probe will determine the state, default enabled
- Enabled: true,
- Error: nil,
- }
- states = append(states, state)
+ Enabled: enabled,
+ Error: groupErr,
+ })
}
- s.statusRecorder.UpdateDNSStates(states)
-}
-
-func (s *DefaultServer) updateNSState(nsGroup *nbdns.NameServerGroup, err error, enabled bool) {
- states := s.statusRecorder.GetDNSStates()
- id := generateGroupKey(nsGroup)
- for i, state := range states {
- if state.ID == id {
- states[i].Enabled = enabled
- states[i].Error = err
- break
+ for id := range s.nsGroupProj {
+ if _, ok := seen[id]; !ok {
+ delete(s.nsGroupProj, id)
}
}
s.statusRecorder.UpdateDNSStates(states)
}
-func generateGroupKey(nsGroup *nbdns.NameServerGroup) string {
- var servers []string
+// projectHealthy records a healthy tick on p and publishes a recovery
+// event iff a warning was active for the current streak. Returns the
+// Enabled flag to record in NSGroupState.
+func (s *DefaultServer) projectHealthy(p *nsGroupProj, servers []netip.AddrPort) bool {
+ p.everHealthy = true
+ p.unhealthySince = time.Time{}
+ if !p.warningActive {
+ return true
+ }
+ log.Debugf("DNS health: group [%s] recovered, emitting event", joinAddrPorts(servers))
+ s.statusRecorder.PublishEvent(
+ proto.SystemEvent_INFO,
+ proto.SystemEvent_DNS,
+ "Nameserver group recovered",
+ "DNS servers are reachable again.",
+ map[string]string{"upstreams": joinAddrPorts(servers)},
+ )
+ p.warningActive = false
+ return true
+}
+
+// projectUnhealthy records an unhealthy tick on p, publishes the
+// warning when the emission rules fire, and returns the Enabled flag
+// to record in NSGroupState.
+func (s *DefaultServer) projectUnhealthy(p *nsGroupProj, servers []netip.AddrPort, immediate bool, now time.Time, delay time.Duration) bool {
+ streakStart := p.unhealthySince.IsZero()
+ if streakStart {
+ p.unhealthySince = now
+ }
+ reason := unhealthyEmitReason(immediate, p.everHealthy, now.Sub(p.unhealthySince), delay)
+ switch {
+ case reason != "" && !p.warningActive:
+ log.Debugf("DNS health: group [%s] unreachable, emitting event (reason=%s)", joinAddrPorts(servers), reason)
+ s.statusRecorder.PublishEvent(
+ proto.SystemEvent_WARNING,
+ proto.SystemEvent_DNS,
+ "Nameserver group unreachable",
+ "Unable to reach one or more DNS servers. This might affect your ability to connect to some services.",
+ map[string]string{"upstreams": joinAddrPorts(servers)},
+ )
+ p.warningActive = true
+ case streakStart && reason == "":
+ // One line per streak, not per tick.
+ log.Debugf("DNS health: group [%s] unreachable but holding warning for up to %v (overlay-routed, no connected peer)", joinAddrPorts(servers), delay)
+ }
+ return false
+}
+
+// warningDelay returns the grace window for the given selected-route
+// count. Scales gently: +1s per 100 routes, capped by
+// warningDelayBonusCap. Parallel handshakes mean handshake time grows
+// much slower than route count, so linear scaling would overcorrect.
+//
+// TODO: revisit the scaling curve with real-world data โ the current
+// values are a reasonable starting point, not a measured fit.
+func (s *DefaultServer) warningDelay(routeCount int) time.Duration {
+ bonus := time.Duration(routeCount/100) * time.Second
+ if bonus > warningDelayBonusCap {
+ bonus = warningDelayBonusCap
+ }
+ return s.warningDelayBase + bonus
+}
+
+// groupHasImmediateUpstream reports whether the group has at least one
+// upstream in a classification that bypasses the grace window: public
+// (outside the overlay range and not routed), or overlay/routed with a
+// Connected peer.
+//
+// TODO(ipv6): include the v6 overlay prefix once it's plumbed in.
+func (s *DefaultServer) groupHasImmediateUpstream(servers []netip.AddrPort, snap nsHealthSnapshot) bool {
+ var overlayV4 netip.Prefix
+ if s.wgInterface != nil {
+ overlayV4 = s.wgInterface.Address().Network
+ }
+ for _, srv := range servers {
+ addr := srv.Addr().Unmap()
+ overlay := overlayV4.IsValid() && overlayV4.Contains(addr)
+ selMatched, selDynamic := haMapContains(snap.selected, addr)
+ // Treat an unknown (dynamic selected route) as possibly routed:
+ // the upstream might reach through a dynamic route whose Network
+ // hasn't resolved yet, and classifying as public would bypass
+ // the startup grace window.
+ routed := selMatched || selDynamic
+ if !overlay && !routed {
+ return true
+ }
+ if actMatched, _ := haMapContains(snap.active, addr); actMatched {
+ return true
+ }
+ }
+ return false
+}
+
+// collectUpstreamHealth merges health snapshots across handlers, keeping
+// the most recent success and failure per upstream when an address appears
+// in more than one handler.
+func (s *DefaultServer) collectUpstreamHealth() map[netip.AddrPort]UpstreamHealth {
+ merged := make(map[netip.AddrPort]UpstreamHealth)
+ for _, entry := range s.dnsMuxMap {
+ reporter, ok := entry.handler.(upstreamHealthReporter)
+ if !ok {
+ continue
+ }
+ for addr, h := range reporter.UpstreamHealth() {
+ existing, have := merged[addr]
+ if !have {
+ merged[addr] = h
+ continue
+ }
+ if h.LastOk.After(existing.LastOk) {
+ existing.LastOk = h.LastOk
+ }
+ if h.LastFail.After(existing.LastFail) {
+ existing.LastFail = h.LastFail
+ existing.LastErr = h.LastErr
+ }
+ merged[addr] = existing
+ }
+ }
+ return merged
+}
+
+func (s *DefaultServer) startHealthRefresher() {
+ s.shutdownWg.Add(1)
+ go func() {
+ defer s.shutdownWg.Done()
+ ticker := time.NewTicker(nsGroupHealthRefreshInterval)
+ defer ticker.Stop()
+ for {
+ select {
+ case <-s.ctx.Done():
+ return
+ case <-ticker.C:
+ case <-s.healthRefresh:
+ }
+ s.refreshHealth()
+ }
+ }()
+}
+
+// evaluateNSGroupHealth decides a group's verdict from query records
+// alone. Per upstream, the most-recent-in-lookback observation wins.
+// Group is Healthy if any upstream is fresh-working, Unhealthy if any
+// is fresh-broken with no fresh-working sibling, Undecided otherwise.
+func evaluateNSGroupHealth(merged map[netip.AddrPort]UpstreamHealth, servers []netip.AddrPort, now time.Time) (nsGroupVerdict, error) {
+ anyWorking := false
+ anyBroken := false
+ var mostRecentFail time.Time
+ var mostRecentErr string
+
+ for _, srv := range servers {
+ h, ok := merged[srv]
+ if !ok {
+ continue
+ }
+ switch classifyUpstreamHealth(h, now) {
+ case upstreamFresh:
+ anyWorking = true
+ case upstreamBroken:
+ anyBroken = true
+ if h.LastFail.After(mostRecentFail) {
+ mostRecentFail = h.LastFail
+ mostRecentErr = h.LastErr
+ }
+ }
+ }
+
+ if anyWorking {
+ return nsVerdictHealthy, nil
+ }
+ if anyBroken {
+ if mostRecentErr == "" {
+ return nsVerdictUnhealthy, nil
+ }
+ return nsVerdictUnhealthy, errors.New(mostRecentErr)
+ }
+ return nsVerdictUndecided, nil
+}
+
+// upstreamClassification is the per-upstream verdict within healthLookback.
+type upstreamClassification int
+
+const (
+ upstreamStale upstreamClassification = iota
+ upstreamFresh
+ upstreamBroken
+)
+
+// classifyUpstreamHealth compares the last ok and last fail timestamps
+// against healthLookback and returns which one (if any) counts. Fresh
+// wins when both are in-window and ok is newer; broken otherwise.
+func classifyUpstreamHealth(h UpstreamHealth, now time.Time) upstreamClassification {
+ okRecent := !h.LastOk.IsZero() && now.Sub(h.LastOk) <= healthLookback
+ failRecent := !h.LastFail.IsZero() && now.Sub(h.LastFail) <= healthLookback
+ switch {
+ case okRecent && failRecent:
+ if h.LastOk.After(h.LastFail) {
+ return upstreamFresh
+ }
+ return upstreamBroken
+ case okRecent:
+ return upstreamFresh
+ case failRecent:
+ return upstreamBroken
+ }
+ return upstreamStale
+}
+
+func joinAddrPorts(servers []netip.AddrPort) string {
+ parts := make([]string, 0, len(servers))
+ for _, s := range servers {
+ parts = append(parts, s.String())
+ }
+ return strings.Join(parts, ", ")
+}
+
+// generateGroupKey returns a stable identity for an NS group so health
+// state (everHealthy / warningActive) survives reorderings in the
+// configured nameserver or domain lists.
+func generateGroupKey(nsGroup *nbdns.NameServerGroup) nsGroupID {
+ servers := make([]string, 0, len(nsGroup.NameServers))
for _, ns := range nsGroup.NameServers {
servers = append(servers, ns.AddrPort().String())
}
- return fmt.Sprintf("%v_%v", servers, nsGroup.Domains)
+ slices.Sort(servers)
+ domains := slices.Clone(nsGroup.Domains)
+ slices.Sort(domains)
+ return nsGroupID(fmt.Sprintf("%v_%v", servers, domains))
}
// groupNSGroupsByDomain groups nameserver groups by their match domains
@@ -1161,6 +1364,21 @@ func toZone(d domain.Domain) domain.Domain {
)
}
+// unhealthyEmitReason returns the tag of the rule that fires the
+// warning now, or "" if the group is still inside its grace window.
+func unhealthyEmitReason(immediate, everHealthy bool, elapsed, delay time.Duration) string {
+ switch {
+ case immediate:
+ return "immediate"
+ case everHealthy:
+ return "ever-healthy"
+ case elapsed >= delay:
+ return "grace-elapsed"
+ default:
+ return ""
+ }
+}
+
// PopulateManagementDomain populates the DNS cache with management domain
func (s *DefaultServer) PopulateManagementDomain(mgmtURL *url.URL) error {
if s.mgmtCacheResolver != nil {
diff --git a/client/internal/dns/server_android.go b/client/internal/dns/server_android.go
index 7ca12d69d..b2cb26f65 100644
--- a/client/internal/dns/server_android.go
+++ b/client/internal/dns/server_android.go
@@ -1,5 +1,5 @@
package dns
func (s *DefaultServer) initialize() (manager hostManager, err error) {
- return newHostManager()
+ return newHostManager(s.hostsDNSHolder)
}
diff --git a/client/internal/dns/server_test.go b/client/internal/dns/server_test.go
index f77f6e898..722c2abd7 100644
--- a/client/internal/dns/server_test.go
+++ b/client/internal/dns/server_test.go
@@ -6,7 +6,7 @@ import (
"net"
"net/netip"
"os"
- "strings"
+ "runtime"
"testing"
"time"
@@ -15,6 +15,7 @@ import (
log "github.com/sirupsen/logrus"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/mock"
+ "github.com/stretchr/testify/require"
"golang.zx2c4.com/wireguard/tun/netstack"
"golang.zx2c4.com/wireguard/wgctrl/wgtypes"
@@ -31,8 +32,10 @@ import (
"github.com/netbirdio/netbird/client/internal/peer"
"github.com/netbirdio/netbird/client/internal/statemanager"
"github.com/netbirdio/netbird/client/internal/stdnet"
+ "github.com/netbirdio/netbird/client/proto"
nbdns "github.com/netbirdio/netbird/dns"
"github.com/netbirdio/netbird/formatter"
+ "github.com/netbirdio/netbird/route"
"github.com/netbirdio/netbird/shared/management/domain"
)
@@ -101,16 +104,17 @@ func init() {
formatter.SetTextFormatter(log.StandardLogger())
}
-func generateDummyHandler(domain string, servers []nbdns.NameServer) *upstreamResolverBase {
+func generateDummyHandler(d string, servers []nbdns.NameServer) *upstreamResolverBase {
var srvs []netip.AddrPort
for _, srv := range servers {
srvs = append(srvs, srv.AddrPort())
}
- return &upstreamResolverBase{
- domain: domain,
- upstreamServers: srvs,
- cancel: func() {},
+ u := &upstreamResolverBase{
+ domain: domain.Domain(d),
+ cancel: func() {},
}
+ u.addRace(srvs)
+ return u
}
func TestUpdateDNSServer(t *testing.T) {
@@ -347,7 +351,7 @@ func TestUpdateDNSServer(t *testing.T) {
opts := iface.WGIFaceOpts{
IFaceName: fmt.Sprintf("utun230%d", n),
- Address: fmt.Sprintf("100.66.100.%d/32", n+1),
+ Address: wgaddr.MustParseWGAddress(fmt.Sprintf("100.66.100.%d/32", n+1)),
WGPort: 33100,
WGPrivKey: privKey.String(),
MTU: iface.DefaultMTU,
@@ -448,7 +452,7 @@ func TestDNSFakeResolverHandleUpdates(t *testing.T) {
privKey, _ := wgtypes.GeneratePrivateKey()
opts := iface.WGIFaceOpts{
IFaceName: "utun2301",
- Address: "100.66.100.1/32",
+ Address: wgaddr.MustParseWGAddress("100.66.100.1/32"),
WGPort: 33100,
WGPrivKey: privKey.String(),
MTU: iface.DefaultMTU,
@@ -653,74 +657,8 @@ func TestDNSServerStartStop(t *testing.T) {
}
}
-func TestDNSServerUpstreamDeactivateCallback(t *testing.T) {
- hostManager := &mockHostConfigurator{}
- server := DefaultServer{
- ctx: context.Background(),
- service: NewServiceViaMemory(&mocWGIface{}),
- localResolver: local.NewResolver(),
- handlerChain: NewHandlerChain(),
- hostManager: hostManager,
- currentConfig: HostDNSConfig{
- Domains: []DomainConfig{
- {false, "domain0", false},
- {false, "domain1", false},
- {false, "domain2", false},
- },
- },
- statusRecorder: peer.NewRecorder("mgm"),
- }
-
- var domainsUpdate string
- hostManager.applyDNSConfigFunc = func(config HostDNSConfig, statemanager *statemanager.Manager) error {
- domains := []string{}
- for _, item := range config.Domains {
- if item.Disabled {
- continue
- }
- domains = append(domains, item.Domain)
- }
- domainsUpdate = strings.Join(domains, ",")
- return nil
- }
-
- deactivate, reactivate := server.upstreamCallbacks(&nbdns.NameServerGroup{
- Domains: []string{"domain1"},
- NameServers: []nbdns.NameServer{
- {IP: netip.MustParseAddr("8.8.0.0"), NSType: nbdns.UDPNameServerType, Port: 53},
- },
- }, nil, 0)
-
- deactivate(nil)
- expected := "domain0,domain2"
- domains := []string{}
- for _, item := range server.currentConfig.Domains {
- if item.Disabled {
- continue
- }
- domains = append(domains, item.Domain)
- }
- got := strings.Join(domains, ",")
- if expected != got {
- t.Errorf("expected domains list: %q, got %q", expected, got)
- }
-
- reactivate()
- expected = "domain0,domain1,domain2"
- domains = []string{}
- for _, item := range server.currentConfig.Domains {
- if item.Disabled {
- continue
- }
- domains = append(domains, item.Domain)
- }
- got = strings.Join(domains, ",")
- if expected != got {
- t.Errorf("expected domains list: %q, got %q", expected, domainsUpdate)
- }
-}
-
func TestDNSPermanent_updateHostDNS_emptyUpstream(t *testing.T) {
+ skipUnlessAndroid(t)
wgIFace, err := createWgInterfaceWithBind(t)
if err != nil {
t.Fatal("failed to initialize wg interface")
@@ -748,6 +686,7 @@ func TestDNSPermanent_updateHostDNS_emptyUpstream(t *testing.T) {
}
func TestDNSPermanent_updateUpstream(t *testing.T) {
+ skipUnlessAndroid(t)
wgIFace, err := createWgInterfaceWithBind(t)
if err != nil {
t.Fatal("failed to initialize wg interface")
@@ -841,6 +780,7 @@ func TestDNSPermanent_updateUpstream(t *testing.T) {
}
func TestDNSPermanent_matchOnly(t *testing.T) {
+ skipUnlessAndroid(t)
wgIFace, err := createWgInterfaceWithBind(t)
if err != nil {
t.Fatal("failed to initialize wg interface")
@@ -913,6 +853,18 @@ func TestDNSPermanent_matchOnly(t *testing.T) {
}
}
+// skipUnlessAndroid marks tests that exercise the mobile-permanent DNS path,
+// which only matches a real production setup on android (NewDefaultServerPermanentUpstream
+// + androidHostManager). On non-android the desktop host manager replaces it
+// during Initialize and the assertion stops making sense. Skipped here until we
+// have an android CI runner.
+func skipUnlessAndroid(t *testing.T) {
+ t.Helper()
+ if runtime.GOOS != "android" {
+ t.Skip("requires android runner; mobile-permanent path doesn't match production on this OS")
+ }
+}
+
func createWgInterfaceWithBind(t *testing.T) (*iface.WGIface, error) {
t.Helper()
ov := os.Getenv("NB_WG_KERNEL_DISABLED")
@@ -929,7 +881,7 @@ func createWgInterfaceWithBind(t *testing.T) (*iface.WGIface, error) {
opts := iface.WGIFaceOpts{
IFaceName: "utun2301",
- Address: "100.66.100.2/24",
+ Address: wgaddr.MustParseWGAddress("100.66.100.2/24"),
WGPort: 33100,
WGPrivKey: privKey.String(),
MTU: iface.DefaultMTU,
@@ -1065,7 +1017,6 @@ type mockHandler struct {
func (m *mockHandler) ServeDNS(dns.ResponseWriter, *dns.Msg) {}
func (m *mockHandler) Stop() {}
-func (m *mockHandler) ProbeAvailability(context.Context) {}
func (m *mockHandler) ID() types.HandlerID { return types.HandlerID(m.Id) }
type mockService struct{}
@@ -2085,6 +2036,598 @@ func TestLocalResolverPriorityConstants(t *testing.T) {
assert.Equal(t, "local.example.com", localMuxUpdates[0].domain)
}
+// TestBuildUpstreamHandler_MergesGroupsPerDomain verifies that multiple
+// admin-defined nameserver groups targeting the same domain collapse into a
+// single handler with each group preserved as a sequential inner list.
+func TestBuildUpstreamHandler_MergesGroupsPerDomain(t *testing.T) {
+ wgInterface := &mocWGIface{}
+ service := NewServiceViaMemory(wgInterface)
+ server := &DefaultServer{
+ ctx: context.Background(),
+ wgInterface: wgInterface,
+ service: service,
+ localResolver: local.NewResolver(),
+ handlerChain: NewHandlerChain(),
+ hostManager: &noopHostConfigurator{},
+ dnsMuxMap: make(registeredHandlerMap),
+ }
+
+ groups := []*nbdns.NameServerGroup{
+ {
+ NameServers: []nbdns.NameServer{
+ {IP: netip.MustParseAddr("192.0.2.1"), NSType: nbdns.UDPNameServerType, Port: 53},
+ },
+ Domains: []string{"example.com"},
+ },
+ {
+ NameServers: []nbdns.NameServer{
+ {IP: netip.MustParseAddr("192.0.2.2"), NSType: nbdns.UDPNameServerType, Port: 53},
+ {IP: netip.MustParseAddr("192.0.2.3"), NSType: nbdns.UDPNameServerType, Port: 53},
+ },
+ Domains: []string{"example.com"},
+ },
+ }
+
+ muxUpdates, err := server.buildUpstreamHandlerUpdate(groups)
+ require.NoError(t, err)
+ require.Len(t, muxUpdates, 1, "same-domain groups should merge into one handler")
+ assert.Equal(t, "example.com", muxUpdates[0].domain)
+ assert.Equal(t, PriorityUpstream, muxUpdates[0].priority)
+
+ handler := muxUpdates[0].handler.(*upstreamResolver)
+ require.Len(t, handler.upstreamServers, 2, "handler should have two groups")
+ assert.Equal(t, upstreamRace{netip.MustParseAddrPort("192.0.2.1:53")}, handler.upstreamServers[0])
+ assert.Equal(t, upstreamRace{
+ netip.MustParseAddrPort("192.0.2.2:53"),
+ netip.MustParseAddrPort("192.0.2.3:53"),
+ }, handler.upstreamServers[1])
+}
+
+// TestEvaluateNSGroupHealth covers the records-only verdict. The gate
+// (overlay route selected-but-no-active-peer) is intentionally NOT an
+// input to the evaluator anymore: the verdict drives the Enabled flag,
+// which must always reflect what we actually observed. Gate-aware event
+// suppression is tested separately in the projection test.
+//
+// Matrix per upstream: {no record, fresh Ok, fresh Fail, stale Fail,
+// stale Ok, Ok newer than Fail, Fail newer than Ok}.
+// Group verdict: any fresh-working โ Healthy; any fresh-broken with no
+// fresh-working โ Unhealthy; otherwise Undecided.
+func TestEvaluateNSGroupHealth(t *testing.T) {
+ now := time.Now()
+ a := netip.MustParseAddrPort("192.0.2.1:53")
+ b := netip.MustParseAddrPort("192.0.2.2:53")
+
+ recentOk := UpstreamHealth{LastOk: now.Add(-2 * time.Second)}
+ recentFail := UpstreamHealth{LastFail: now.Add(-1 * time.Second), LastErr: "timeout"}
+ staleOk := UpstreamHealth{LastOk: now.Add(-10 * time.Minute)}
+ staleFail := UpstreamHealth{LastFail: now.Add(-10 * time.Minute), LastErr: "timeout"}
+ okThenFail := UpstreamHealth{
+ LastOk: now.Add(-10 * time.Second),
+ LastFail: now.Add(-1 * time.Second),
+ LastErr: "timeout",
+ }
+ failThenOk := UpstreamHealth{
+ LastOk: now.Add(-1 * time.Second),
+ LastFail: now.Add(-10 * time.Second),
+ LastErr: "timeout",
+ }
+
+ tests := []struct {
+ name string
+ health map[netip.AddrPort]UpstreamHealth
+ servers []netip.AddrPort
+ wantVerdict nsGroupVerdict
+ wantErrSubst string
+ }{
+ {
+ name: "no record, undecided",
+ servers: []netip.AddrPort{a},
+ wantVerdict: nsVerdictUndecided,
+ },
+ {
+ name: "fresh success, healthy",
+ health: map[netip.AddrPort]UpstreamHealth{a: recentOk},
+ servers: []netip.AddrPort{a},
+ wantVerdict: nsVerdictHealthy,
+ },
+ {
+ name: "fresh failure, unhealthy",
+ health: map[netip.AddrPort]UpstreamHealth{a: recentFail},
+ servers: []netip.AddrPort{a},
+ wantVerdict: nsVerdictUnhealthy,
+ wantErrSubst: "timeout",
+ },
+ {
+ name: "only stale success, undecided",
+ health: map[netip.AddrPort]UpstreamHealth{a: staleOk},
+ servers: []netip.AddrPort{a},
+ wantVerdict: nsVerdictUndecided,
+ },
+ {
+ name: "only stale failure, undecided",
+ health: map[netip.AddrPort]UpstreamHealth{a: staleFail},
+ servers: []netip.AddrPort{a},
+ wantVerdict: nsVerdictUndecided,
+ },
+ {
+ name: "both fresh, fail newer, unhealthy",
+ health: map[netip.AddrPort]UpstreamHealth{a: okThenFail},
+ servers: []netip.AddrPort{a},
+ wantVerdict: nsVerdictUnhealthy,
+ wantErrSubst: "timeout",
+ },
+ {
+ name: "both fresh, ok newer, healthy",
+ health: map[netip.AddrPort]UpstreamHealth{a: failThenOk},
+ servers: []netip.AddrPort{a},
+ wantVerdict: nsVerdictHealthy,
+ },
+ {
+ name: "two upstreams, one success wins",
+ health: map[netip.AddrPort]UpstreamHealth{
+ a: recentFail,
+ b: recentOk,
+ },
+ servers: []netip.AddrPort{a, b},
+ wantVerdict: nsVerdictHealthy,
+ },
+ {
+ name: "two upstreams, one fail one unseen, unhealthy",
+ health: map[netip.AddrPort]UpstreamHealth{
+ a: recentFail,
+ },
+ servers: []netip.AddrPort{a, b},
+ wantVerdict: nsVerdictUnhealthy,
+ wantErrSubst: "timeout",
+ },
+ {
+ name: "two upstreams, all recent failures, unhealthy",
+ health: map[netip.AddrPort]UpstreamHealth{
+ a: {LastFail: now.Add(-5 * time.Second), LastErr: "timeout"},
+ b: {LastFail: now.Add(-1 * time.Second), LastErr: "SERVFAIL"},
+ },
+ servers: []netip.AddrPort{a, b},
+ wantVerdict: nsVerdictUnhealthy,
+ wantErrSubst: "SERVFAIL",
+ },
+ }
+
+ for _, tc := range tests {
+ t.Run(tc.name, func(t *testing.T) {
+ verdict, err := evaluateNSGroupHealth(tc.health, tc.servers, now)
+ assert.Equal(t, tc.wantVerdict, verdict, "verdict mismatch")
+ if tc.wantErrSubst != "" {
+ require.Error(t, err)
+ assert.Contains(t, err.Error(), tc.wantErrSubst)
+ } else {
+ assert.NoError(t, err)
+ }
+ })
+ }
+}
+
+// healthStubHandler is a minimal dnsMuxMap entry that exposes a fixed
+// UpstreamHealth snapshot, letting tests drive recomputeNSGroupStates
+// without spinning up real handlers.
+type healthStubHandler struct {
+ health map[netip.AddrPort]UpstreamHealth
+}
+
+func (h *healthStubHandler) ServeDNS(dns.ResponseWriter, *dns.Msg) {}
+func (h *healthStubHandler) Stop() {}
+func (h *healthStubHandler) ID() types.HandlerID { return "health-stub" }
+func (h *healthStubHandler) UpstreamHealth() map[netip.AddrPort]UpstreamHealth {
+ return h.health
+}
+
+// TestProjection_SteadyStateIsSilent guards against duplicate events:
+// while a group stays Unhealthy tick after tick, only the first
+// Unhealthy transition may emit. Same for staying Healthy.
+func TestProjection_SteadyStateIsSilent(t *testing.T) {
+ fx := newProjTestFixture(t)
+
+ fx.setHealth(UpstreamHealth{LastFail: time.Now(), LastErr: "timeout"})
+ fx.tick()
+ fx.expectEvent("unreachable", "first fail emits warning")
+
+ fx.setHealth(UpstreamHealth{LastFail: time.Now(), LastErr: "timeout"})
+ fx.tick()
+ fx.tick()
+ fx.expectNoEvent("staying unhealthy must not re-emit")
+
+ fx.setHealth(UpstreamHealth{LastOk: time.Now()})
+ fx.tick()
+ fx.expectEvent("recovered", "recovery on transition")
+
+ fx.tick()
+ fx.tick()
+ fx.expectNoEvent("staying healthy must not re-emit")
+}
+
+// projTestFixture is the common setup for the projection tests: a
+// single-upstream group whose route classification the test can flip by
+// assigning to selected/active. Callers drive failures/successes by
+// mutating stub.health and calling refreshHealth.
+type projTestFixture struct {
+ t *testing.T
+ recorder *peer.Status
+ events <-chan *proto.SystemEvent
+ server *DefaultServer
+ stub *healthStubHandler
+ group *nbdns.NameServerGroup
+ srv netip.AddrPort
+ selected route.HAMap
+ active route.HAMap
+}
+
+func newProjTestFixture(t *testing.T) *projTestFixture {
+ t.Helper()
+ recorder := peer.NewRecorder("mgm")
+ sub := recorder.SubscribeToEvents()
+ t.Cleanup(func() { recorder.UnsubscribeFromEvents(sub) })
+
+ srv := netip.MustParseAddrPort("100.64.0.1:53")
+ fx := &projTestFixture{
+ t: t,
+ recorder: recorder,
+ events: sub.Events(),
+ stub: &healthStubHandler{health: map[netip.AddrPort]UpstreamHealth{}},
+ srv: srv,
+ group: &nbdns.NameServerGroup{
+ Domains: []string{"example.com"},
+ NameServers: []nbdns.NameServer{{IP: srv.Addr(), NSType: nbdns.UDPNameServerType, Port: int(srv.Port())}},
+ },
+ }
+ fx.server = &DefaultServer{
+ ctx: context.Background(),
+ wgInterface: &mocWGIface{},
+ statusRecorder: recorder,
+ dnsMuxMap: make(registeredHandlerMap),
+ selectedRoutes: func() route.HAMap { return fx.selected },
+ activeRoutes: func() route.HAMap { return fx.active },
+ warningDelayBase: defaultWarningDelayBase,
+ }
+ fx.server.dnsMuxMap["example.com"] = handlerWrapper{domain: "example.com", handler: fx.stub, priority: PriorityUpstream}
+
+ fx.server.mux.Lock()
+ fx.server.updateNSGroupStates([]*nbdns.NameServerGroup{fx.group})
+ fx.server.mux.Unlock()
+ return fx
+}
+
+func (f *projTestFixture) setHealth(h UpstreamHealth) {
+ f.stub.health = map[netip.AddrPort]UpstreamHealth{f.srv: h}
+}
+
+func (f *projTestFixture) tick() []peer.NSGroupState {
+ f.server.refreshHealth()
+ return f.recorder.GetDNSStates()
+}
+
+func (f *projTestFixture) expectNoEvent(why string) {
+ f.t.Helper()
+ select {
+ case evt := <-f.events:
+ f.t.Fatalf("unexpected event (%s): %+v", why, evt)
+ case <-time.After(100 * time.Millisecond):
+ }
+}
+
+func (f *projTestFixture) expectEvent(substr, why string) *proto.SystemEvent {
+ f.t.Helper()
+ select {
+ case evt := <-f.events:
+ assert.Contains(f.t, evt.Message, substr, why)
+ return evt
+ case <-time.After(time.Second):
+ f.t.Fatalf("expected event (%s) with %q", why, substr)
+ return nil
+ }
+}
+
+var overlayNetForTest = netip.MustParsePrefix("100.64.0.0/16")
+var overlayMapForTest = route.HAMap{"overlay": {{Network: overlayNetForTest}}}
+
+// TestProjection_PublicFailEmitsImmediately covers rule 1: an upstream
+// that is not inside any selected route (public DNS) fires the warning
+// on the first Unhealthy tick, no grace period.
+func TestProjection_PublicFailEmitsImmediately(t *testing.T) {
+ fx := newProjTestFixture(t)
+
+ fx.setHealth(UpstreamHealth{LastFail: time.Now(), LastErr: "timeout"})
+ states := fx.tick()
+ require.Len(t, states, 1)
+ assert.False(t, states[0].Enabled)
+ fx.expectEvent("unreachable", "public DNS failure")
+}
+
+// TestProjection_OverlayConnectedFailEmitsImmediately covers rule 2:
+// the upstream is inside a selected route AND the route has a Connected
+// peer. Tunnel is up, failure is real, emit immediately.
+func TestProjection_OverlayConnectedFailEmitsImmediately(t *testing.T) {
+ fx := newProjTestFixture(t)
+ fx.selected = overlayMapForTest
+ fx.active = overlayMapForTest
+
+ fx.setHealth(UpstreamHealth{LastFail: time.Now(), LastErr: "timeout"})
+ states := fx.tick()
+ require.Len(t, states, 1)
+ assert.False(t, states[0].Enabled)
+ fx.expectEvent("unreachable", "overlay + connected failure")
+}
+
+// TestProjection_OverlayNotConnectedDelaysWarning covers rule 3: the
+// upstream is routed but no peer is Connected (Connecting/Idle/missing).
+// First tick: Unhealthy display, no warning. After the grace window
+// elapses with no recovery, the warning fires.
+func TestProjection_OverlayNotConnectedDelaysWarning(t *testing.T) {
+ grace := 50 * time.Millisecond
+ fx := newProjTestFixture(t)
+ fx.server.warningDelayBase = grace
+ fx.selected = overlayMapForTest
+ // active stays nil: routed but not connected.
+
+ fx.setHealth(UpstreamHealth{LastFail: time.Now(), LastErr: "timeout"})
+ states := fx.tick()
+ require.Len(t, states, 1)
+ assert.False(t, states[0].Enabled, "display must reflect failure even during grace window")
+ fx.expectNoEvent("first fail tick within grace window")
+
+ time.Sleep(grace + 10*time.Millisecond)
+ fx.setHealth(UpstreamHealth{LastFail: time.Now(), LastErr: "timeout"})
+ fx.tick()
+ fx.expectEvent("unreachable", "warning after grace window")
+}
+
+// TestProjection_OverlayAddrNoRouteDelaysWarning covers an upstream
+// whose address is inside the WireGuard overlay range but is not
+// covered by any selected route (peer-to-peer DNS without an explicit
+// route). Until a peer reports Connected for that address, startup
+// failures must be held just like the routed case.
+func TestProjection_OverlayAddrNoRouteDelaysWarning(t *testing.T) {
+ recorder := peer.NewRecorder("mgm")
+ sub := recorder.SubscribeToEvents()
+ t.Cleanup(func() { recorder.UnsubscribeFromEvents(sub) })
+
+ overlayPeer := netip.MustParseAddrPort("100.66.100.5:53")
+ server := &DefaultServer{
+ ctx: context.Background(),
+ wgInterface: &mocWGIface{},
+ statusRecorder: recorder,
+ dnsMuxMap: make(registeredHandlerMap),
+ selectedRoutes: func() route.HAMap { return nil },
+ activeRoutes: func() route.HAMap { return nil },
+ warningDelayBase: 50 * time.Millisecond,
+ }
+ group := &nbdns.NameServerGroup{
+ Domains: []string{"example.com"},
+ NameServers: []nbdns.NameServer{{IP: overlayPeer.Addr(), NSType: nbdns.UDPNameServerType, Port: int(overlayPeer.Port())}},
+ }
+ stub := &healthStubHandler{health: map[netip.AddrPort]UpstreamHealth{
+ overlayPeer: {LastFail: time.Now(), LastErr: "timeout"},
+ }}
+ server.dnsMuxMap["example.com"] = handlerWrapper{domain: "example.com", handler: stub, priority: PriorityUpstream}
+
+ server.mux.Lock()
+ server.updateNSGroupStates([]*nbdns.NameServerGroup{group})
+ server.mux.Unlock()
+ server.refreshHealth()
+
+ select {
+ case evt := <-sub.Events():
+ t.Fatalf("unexpected event during grace window: %+v", evt)
+ case <-time.After(100 * time.Millisecond):
+ }
+
+ time.Sleep(60 * time.Millisecond)
+ stub.health = map[netip.AddrPort]UpstreamHealth{overlayPeer: {LastFail: time.Now(), LastErr: "timeout"}}
+ server.refreshHealth()
+
+ select {
+ case evt := <-sub.Events():
+ assert.Contains(t, evt.Message, "unreachable")
+ case <-time.After(time.Second):
+ t.Fatal("expected warning after grace window")
+ }
+}
+
+// TestProjection_StopClearsHealthState verifies that Stop wipes the
+// per-group projection state so a subsequent Start doesn't inherit
+// sticky flags (notably everHealthy) that would bypass the grace
+// window during the next peer handshake.
+func TestProjection_StopClearsHealthState(t *testing.T) {
+ wgIface := &mocWGIface{}
+ server := &DefaultServer{
+ ctx: context.Background(),
+ wgInterface: wgIface,
+ service: NewServiceViaMemory(wgIface),
+ hostManager: &noopHostConfigurator{},
+ extraDomains: map[domain.Domain]int{},
+ dnsMuxMap: make(registeredHandlerMap),
+ statusRecorder: peer.NewRecorder("mgm"),
+ selectedRoutes: func() route.HAMap { return nil },
+ activeRoutes: func() route.HAMap { return nil },
+ warningDelayBase: defaultWarningDelayBase,
+ currentConfigHash: ^uint64(0),
+ }
+ server.ctx, server.ctxCancel = context.WithCancel(context.Background())
+
+ srv := netip.MustParseAddrPort("8.8.8.8:53")
+ group := &nbdns.NameServerGroup{
+ Domains: []string{"example.com"},
+ NameServers: []nbdns.NameServer{{IP: srv.Addr(), NSType: nbdns.UDPNameServerType, Port: int(srv.Port())}},
+ }
+ stub := &healthStubHandler{health: map[netip.AddrPort]UpstreamHealth{srv: {LastOk: time.Now()}}}
+ server.dnsMuxMap["example.com"] = handlerWrapper{domain: "example.com", handler: stub, priority: PriorityUpstream}
+
+ server.mux.Lock()
+ server.updateNSGroupStates([]*nbdns.NameServerGroup{group})
+ server.mux.Unlock()
+ server.refreshHealth()
+
+ server.healthProjectMu.Lock()
+ p, ok := server.nsGroupProj[generateGroupKey(group)]
+ server.healthProjectMu.Unlock()
+ require.True(t, ok, "projection state should exist after tick")
+ require.True(t, p.everHealthy, "tick with success must set everHealthy")
+
+ server.Stop()
+
+ server.healthProjectMu.Lock()
+ cleared := server.nsGroupProj == nil
+ server.healthProjectMu.Unlock()
+ assert.True(t, cleared, "Stop must clear nsGroupProj")
+}
+
+// TestProjection_OverlayRecoversDuringGrace covers the happy path of
+// rule 3: startup failures while the peer is handshaking, then the peer
+// comes up and a query succeeds before the grace window elapses. No
+// warning should ever have fired, and no recovery either.
+func TestProjection_OverlayRecoversDuringGrace(t *testing.T) {
+ fx := newProjTestFixture(t)
+ fx.server.warningDelayBase = 200 * time.Millisecond
+ fx.selected = overlayMapForTest
+
+ fx.setHealth(UpstreamHealth{LastFail: time.Now(), LastErr: "timeout"})
+ fx.tick()
+ fx.expectNoEvent("fail within grace, warning suppressed")
+
+ fx.active = overlayMapForTest
+ fx.setHealth(UpstreamHealth{LastOk: time.Now()})
+ states := fx.tick()
+ require.Len(t, states, 1)
+ assert.True(t, states[0].Enabled)
+ fx.expectNoEvent("recovery without prior warning must not emit")
+}
+
+// TestProjection_RecoveryOnlyAfterWarning enforces the invariant the
+// whole design leans on: recovery events only appear when a warning
+// event was actually emitted for the current streak. A Healthy verdict
+// without a prior warning is silent, so the user never sees "recovered"
+// out of thin air.
+func TestProjection_RecoveryOnlyAfterWarning(t *testing.T) {
+ fx := newProjTestFixture(t)
+
+ fx.setHealth(UpstreamHealth{LastOk: time.Now()})
+ states := fx.tick()
+ require.Len(t, states, 1)
+ assert.True(t, states[0].Enabled)
+ fx.expectNoEvent("first healthy tick should not recover anything")
+
+ fx.setHealth(UpstreamHealth{LastFail: time.Now(), LastErr: "timeout"})
+ fx.tick()
+ fx.expectEvent("unreachable", "public fail emits immediately")
+
+ fx.setHealth(UpstreamHealth{LastOk: time.Now()})
+ fx.tick()
+ fx.expectEvent("recovered", "recovery follows real warning")
+
+ fx.setHealth(UpstreamHealth{LastFail: time.Now(), LastErr: "timeout"})
+ fx.tick()
+ fx.expectEvent("unreachable", "second cycle warning")
+
+ fx.setHealth(UpstreamHealth{LastOk: time.Now()})
+ fx.tick()
+ fx.expectEvent("recovered", "second cycle recovery")
+}
+
+// TestProjection_EverHealthyOverridesDelay covers rule 4: once a group
+// has ever been Healthy, subsequent failures skip the grace window even
+// if classification says "routed + not connected". The system has
+// proved it can work, so any new failure is real.
+func TestProjection_EverHealthyOverridesDelay(t *testing.T) {
+ fx := newProjTestFixture(t)
+ // Large base so any emission must come from the everHealthy bypass, not elapsed time.
+ fx.server.warningDelayBase = time.Hour
+ fx.selected = overlayMapForTest
+ fx.active = overlayMapForTest
+
+ // Establish "ever healthy".
+ fx.setHealth(UpstreamHealth{LastOk: time.Now()})
+ fx.tick()
+ fx.expectNoEvent("first healthy tick")
+
+ // Peer drops. Query fails. Routed + not connected โ normally grace,
+ // but everHealthy flag bypasses it.
+ fx.active = nil
+ fx.setHealth(UpstreamHealth{LastFail: time.Now(), LastErr: "timeout"})
+ fx.tick()
+ fx.expectEvent("unreachable", "failure after ever-healthy must be immediate")
+}
+
+// TestProjection_ReconnectBlipEmitsPair covers the explicit tradeoff
+// from the design discussion: once a group has been healthy, a brief
+// reconnect that produces a failing tick will fire warning + recovery.
+// This is by design: user-visible blips are accurate signal, not noise.
+func TestProjection_ReconnectBlipEmitsPair(t *testing.T) {
+ fx := newProjTestFixture(t)
+ fx.selected = overlayMapForTest
+ fx.active = overlayMapForTest
+
+ fx.setHealth(UpstreamHealth{LastOk: time.Now()})
+ fx.tick()
+
+ fx.setHealth(UpstreamHealth{LastFail: time.Now(), LastErr: "timeout"})
+ fx.tick()
+ fx.expectEvent("unreachable", "blip warning")
+
+ fx.setHealth(UpstreamHealth{LastOk: time.Now()})
+ fx.tick()
+ fx.expectEvent("recovered", "blip recovery")
+}
+
+// TestProjection_MixedGroupEmitsImmediately covers the multi-upstream
+// rule: a group with at least one public upstream is in the "immediate"
+// category regardless of the other upstreams' routing, because the
+// public one has no peer-startup excuse. Prevents public-DNS failures
+// from being hidden behind a routed sibling.
+func TestProjection_MixedGroupEmitsImmediately(t *testing.T) {
+ recorder := peer.NewRecorder("mgm")
+ sub := recorder.SubscribeToEvents()
+ t.Cleanup(func() { recorder.UnsubscribeFromEvents(sub) })
+ events := sub.Events()
+
+ public := netip.MustParseAddrPort("8.8.8.8:53")
+ overlay := netip.MustParseAddrPort("100.64.0.1:53")
+ overlayMap := route.HAMap{"overlay": {{Network: netip.MustParsePrefix("100.64.0.0/16")}}}
+
+ server := &DefaultServer{
+ ctx: context.Background(),
+ statusRecorder: recorder,
+ dnsMuxMap: make(registeredHandlerMap),
+ selectedRoutes: func() route.HAMap { return overlayMap },
+ activeRoutes: func() route.HAMap { return nil },
+ warningDelayBase: time.Hour,
+ }
+ group := &nbdns.NameServerGroup{
+ Domains: []string{"example.com"},
+ NameServers: []nbdns.NameServer{
+ {IP: public.Addr(), NSType: nbdns.UDPNameServerType, Port: int(public.Port())},
+ {IP: overlay.Addr(), NSType: nbdns.UDPNameServerType, Port: int(overlay.Port())},
+ },
+ }
+ stub := &healthStubHandler{
+ health: map[netip.AddrPort]UpstreamHealth{
+ public: {LastFail: time.Now(), LastErr: "servfail"},
+ overlay: {LastFail: time.Now(), LastErr: "timeout"},
+ },
+ }
+ server.dnsMuxMap["example.com"] = handlerWrapper{domain: "example.com", handler: stub, priority: PriorityUpstream}
+
+ server.mux.Lock()
+ server.updateNSGroupStates([]*nbdns.NameServerGroup{group})
+ server.mux.Unlock()
+ server.refreshHealth()
+
+ select {
+ case evt := <-events:
+ assert.Contains(t, evt.Message, "unreachable")
+ case <-time.After(time.Second):
+ t.Fatal("expected immediate warning because group contains a public upstream")
+ }
+}
+
func TestDNSLoopPrevention(t *testing.T) {
wgInterface := &mocWGIface{}
service := NewServiceViaMemory(wgInterface)
@@ -2183,17 +2726,18 @@ func TestDNSLoopPrevention(t *testing.T) {
if tt.expectedHandlers > 0 {
handler := muxUpdates[0].handler.(*upstreamResolver)
- assert.Len(t, handler.upstreamServers, len(tt.expectedServers))
+ flat := handler.flatUpstreams()
+ assert.Len(t, flat, len(tt.expectedServers))
if tt.shouldFilterOwnIP {
- for _, upstream := range handler.upstreamServers {
+ for _, upstream := range flat {
assert.NotEqual(t, dnsServerIP, upstream.Addr())
}
}
for _, expected := range tt.expectedServers {
found := false
- for _, upstream := range handler.upstreamServers {
+ for _, upstream := range flat {
if upstream.Addr() == expected {
found = true
break
diff --git a/client/internal/dns/service.go b/client/internal/dns/service.go
index 1c6ce7849..04bcd5985 100644
--- a/client/internal/dns/service.go
+++ b/client/internal/dns/service.go
@@ -16,8 +16,8 @@ const (
// This is used when the DNS server cannot bind port 53 directly
// and needs firewall rules to redirect traffic.
type Firewall interface {
- AddOutputDNAT(localAddr netip.Addr, protocol firewall.Protocol, sourcePort, targetPort uint16) error
- RemoveOutputDNAT(localAddr netip.Addr, protocol firewall.Protocol, sourcePort, targetPort uint16) error
+ AddOutputDNAT(localAddr netip.Addr, protocol firewall.Protocol, originalPort, translatedPort uint16) error
+ RemoveOutputDNAT(localAddr netip.Addr, protocol firewall.Protocol, originalPort, translatedPort uint16) error
}
type service interface {
diff --git a/client/internal/dns/service_listener.go b/client/internal/dns/service_listener.go
index 4e09f1b7f..9c0e52af8 100644
--- a/client/internal/dns/service_listener.go
+++ b/client/internal/dns/service_listener.go
@@ -188,11 +188,10 @@ func (s *serviceViaListener) RuntimeIP() netip.Addr {
return s.listenIP
}
-
-// evalListenAddress figure out the listen address for the DNS server
-// first check the 53 port availability on WG interface or lo, if not success
-// pick a random port on WG interface for eBPF, if not success
-// check the 5053 port availability on WG interface or lo without eBPF usage,
+// evalListenAddress figures out the listen address for the DNS server.
+// IPv4-only: all peers have a v4 overlay address, and DNS config points to v4.
+// First checks port 53 on WG interface or lo, then tries eBPF on a random port,
+// then falls back to port 5053.
func (s *serviceViaListener) evalListenAddress() (netip.Addr, uint16, error) {
if s.customAddr != nil {
return s.customAddr.Addr(), s.customAddr.Port(), nil
@@ -278,7 +277,7 @@ func (s *serviceViaListener) tryToUseeBPF() (ebpfMgr.Manager, uint16, bool) {
}
ebpfSrv := ebpf.GetEbpfManagerInstance()
- err = ebpfSrv.LoadDNSFwd(s.wgInterface.Address().IP.String(), int(port))
+ err = ebpfSrv.LoadDNSFwd(s.wgInterface.Address().IP, int(port))
if err != nil {
log.Warnf("failed to load DNS forwarder eBPF program, error: %s", err)
return nil, 0, false
diff --git a/client/internal/dns/systemd_linux.go b/client/internal/dns/systemd_linux.go
index d9854c033..bd301e177 100644
--- a/client/internal/dns/systemd_linux.go
+++ b/client/internal/dns/systemd_linux.go
@@ -8,6 +8,7 @@ import (
"fmt"
"net"
"net/netip"
+ "slices"
"time"
"github.com/godbus/dbus/v5"
@@ -40,10 +41,17 @@ const (
)
type systemdDbusConfigurator struct {
- dbusLinkObject dbus.ObjectPath
- ifaceName string
+ dbusLinkObject dbus.ObjectPath
+ ifaceName string
+ wgIndex int
+ origNameservers []netip.Addr
}
+const (
+ systemdDbusLinkDNSProperty = systemdDbusLinkInterface + ".DNS"
+ systemdDbusLinkDefaultRouteProperty = systemdDbusLinkInterface + ".DefaultRoute"
+)
+
// the types below are based on dbus specification, each field is mapped to a dbus type
// see https://dbus.freedesktop.org/doc/dbus-specification.html#basic-types for more details on dbus types
// see https://www.freedesktop.org/software/systemd/man/org.freedesktop.resolve1.html on resolve1 input types
@@ -79,10 +87,145 @@ func newSystemdDbusConfigurator(wgInterface string) (*systemdDbusConfigurator, e
log.Debugf("got dbus Link interface: %s from net interface %s and index %d", s, iface.Name, iface.Index)
- return &systemdDbusConfigurator{
+ c := &systemdDbusConfigurator{
dbusLinkObject: dbus.ObjectPath(s),
ifaceName: wgInterface,
- }, nil
+ wgIndex: iface.Index,
+ }
+
+ origNameservers, err := c.captureOriginalNameservers()
+ switch {
+ case err != nil:
+ log.Warnf("capture original nameservers from systemd-resolved: %v", err)
+ case len(origNameservers) == 0:
+ log.Warnf("no original nameservers captured from systemd-resolved default-route links; DNS fallback will be empty")
+ default:
+ log.Debugf("captured %d original nameservers from systemd-resolved default-route links: %v", len(origNameservers), origNameservers)
+ }
+ c.origNameservers = origNameservers
+ return c, nil
+}
+
+// captureOriginalNameservers reads per-link DNS from systemd-resolved for
+// every default-route link except our own WG link. Non-default-route links
+// (VPNs, docker bridges) are skipped because their upstreams wouldn't
+// actually serve host queries.
+func (s *systemdDbusConfigurator) captureOriginalNameservers() ([]netip.Addr, error) {
+ ifaces, err := net.Interfaces()
+ if err != nil {
+ return nil, fmt.Errorf("list interfaces: %w", err)
+ }
+
+ seen := make(map[netip.Addr]struct{})
+ var out []netip.Addr
+ for _, iface := range ifaces {
+ if !s.isCandidateLink(iface) {
+ continue
+ }
+ linkPath, err := getSystemdLinkPath(iface.Index)
+ if err != nil || !isSystemdLinkDefaultRoute(linkPath) {
+ continue
+ }
+ for _, addr := range readSystemdLinkDNS(linkPath) {
+ addr = normalizeSystemdAddr(addr, iface.Name)
+ if !addr.IsValid() {
+ continue
+ }
+ if _, dup := seen[addr]; dup {
+ continue
+ }
+ seen[addr] = struct{}{}
+ out = append(out, addr)
+ }
+ }
+ return out, nil
+}
+
+func (s *systemdDbusConfigurator) isCandidateLink(iface net.Interface) bool {
+ if iface.Index == s.wgIndex {
+ return false
+ }
+ if iface.Flags&net.FlagLoopback != 0 || iface.Flags&net.FlagUp == 0 {
+ return false
+ }
+ return true
+}
+
+// normalizeSystemdAddr unmaps v4-mapped-v6, drops unspecified, and reattaches
+// the link's iface name as zone for link-local v6 (Link.DNS strips it).
+// Returns the zero Addr to signal "skip this entry".
+func normalizeSystemdAddr(addr netip.Addr, ifaceName string) netip.Addr {
+ addr = addr.Unmap()
+ if !addr.IsValid() || addr.IsUnspecified() {
+ return netip.Addr{}
+ }
+ if addr.IsLinkLocalUnicast() {
+ return addr.WithZone(ifaceName)
+ }
+ return addr
+}
+
+func getSystemdLinkPath(ifIndex int) (dbus.ObjectPath, error) {
+ obj, closeConn, err := getDbusObject(systemdResolvedDest, systemdDbusObjectNode)
+ if err != nil {
+ return "", fmt.Errorf("dbus resolve1: %w", err)
+ }
+ defer closeConn()
+ var p string
+ if err := obj.Call(systemdDbusGetLinkMethod, dbusDefaultFlag, int32(ifIndex)).Store(&p); err != nil {
+ return "", err
+ }
+ return dbus.ObjectPath(p), nil
+}
+
+func isSystemdLinkDefaultRoute(linkPath dbus.ObjectPath) bool {
+ obj, closeConn, err := getDbusObject(systemdResolvedDest, linkPath)
+ if err != nil {
+ return false
+ }
+ defer closeConn()
+ v, err := obj.GetProperty(systemdDbusLinkDefaultRouteProperty)
+ if err != nil {
+ return false
+ }
+ b, ok := v.Value().(bool)
+ return ok && b
+}
+
+func readSystemdLinkDNS(linkPath dbus.ObjectPath) []netip.Addr {
+ obj, closeConn, err := getDbusObject(systemdResolvedDest, linkPath)
+ if err != nil {
+ return nil
+ }
+ defer closeConn()
+ v, err := obj.GetProperty(systemdDbusLinkDNSProperty)
+ if err != nil {
+ return nil
+ }
+ entries, ok := v.Value().([][]any)
+ if !ok {
+ return nil
+ }
+ var out []netip.Addr
+ for _, entry := range entries {
+ if len(entry) < 2 {
+ continue
+ }
+ raw, ok := entry[1].([]byte)
+ if !ok {
+ continue
+ }
+ addr, ok := netip.AddrFromSlice(raw)
+ if !ok {
+ continue
+ }
+ out = append(out, addr)
+ }
+ return out
+}
+
+func (s *systemdDbusConfigurator) getOriginalNameservers() []netip.Addr {
+ return slices.Clone(s.origNameservers)
}
func (s *systemdDbusConfigurator) supportCustomPort() bool {
@@ -90,8 +233,12 @@ func (s *systemdDbusConfigurator) supportCustomPort() bool {
}
func (s *systemdDbusConfigurator) applyDNSConfig(config HostDNSConfig, stateManager *statemanager.Manager) error {
+ family := int32(unix.AF_INET)
+ if config.ServerIP.Is6() {
+ family = unix.AF_INET6
+ }
defaultLinkInput := systemdDbusDNSInput{
- Family: unix.AF_INET,
+ Family: family,
Address: config.ServerIP.AsSlice(),
}
if err := s.callLinkMethod(systemdDbusSetDNSMethodSuffix, []systemdDbusDNSInput{defaultLinkInput}); err != nil {
diff --git a/client/internal/dns/upstream.go b/client/internal/dns/upstream.go
index 746b73ca7..a4f713d68 100644
--- a/client/internal/dns/upstream.go
+++ b/client/internal/dns/upstream.go
@@ -1,3 +1,32 @@
+// Package dns implements the client-side DNS stack: listener/service on the
+// peer's tunnel address, handler chain that routes questions by domain and
+// priority, and upstream resolvers that forward what remains to configured
+// nameservers.
+//
+// # Upstream resolution and the race model
+//
+// When two or more nameserver groups target the same domain, DefaultServer
+// merges them into one upstream handler whose state is:
+//
+// upstreamResolverBase
+// โโโ upstreamServers []upstreamRace // one entry per source NS group
+// โโโ []netip.AddrPort // primary, fallback, ...
+//
+// Each source nameserver group contributes one upstreamRace. Within a race
+// upstreams are tried in order: the next is used only on failure (timeout,
+// SERVFAIL, REFUSED, no response). NXDOMAIN is a valid answer and stops
+// the walk. When more than one race exists, ServeDNS fans out one
+// goroutine per race and returns the first valid answer, cancelling the
+// rest. A handler with a single race skips the fan-out.
+//
+// # Health projection
+//
+// Query outcomes are recorded per-upstream in UpstreamHealth. The server
+// periodically merges these snapshots across handlers and projects them
+// into peer.NSGroupState. There is no active probing: a group is marked
+// unhealthy only when every seen upstream has a recent failure and none
+// has a recent success. Healthyโunhealthy fires a single
+// SystemEvent_WARNING; steady-state refreshes do not duplicate it.
package dns
import (
@@ -11,24 +40,50 @@ import (
"slices"
"strings"
"sync"
- "sync/atomic"
"time"
- "github.com/cenkalti/backoff/v4"
- "github.com/hashicorp/go-multierror"
"github.com/miekg/dns"
log "github.com/sirupsen/logrus"
"golang.zx2c4.com/wireguard/tun/netstack"
"github.com/netbirdio/netbird/client/iface"
+ "github.com/netbirdio/netbird/client/iface/wgaddr"
"github.com/netbirdio/netbird/client/internal/dns/resutil"
"github.com/netbirdio/netbird/client/internal/dns/types"
"github.com/netbirdio/netbird/client/internal/peer"
- "github.com/netbirdio/netbird/client/proto"
+ "github.com/netbirdio/netbird/route"
+ "github.com/netbirdio/netbird/shared/management/domain"
)
var currentMTU uint16 = iface.DefaultMTU
+// nonRetryableEDECodes lists EDE info codes (RFC 8914) for which a SERVFAIL
+// from one upstream means another upstream would return the same answer:
+// DNSSEC validation outcomes and policy-based blocks. Transient errors
+// (network, cached, not ready) are not included.
+var nonRetryableEDECodes = map[uint16]struct{}{
+ dns.ExtendedErrorCodeUnsupportedDNSKEYAlgorithm: {},
+ dns.ExtendedErrorCodeUnsupportedDSDigestType: {},
+ dns.ExtendedErrorCodeDNSSECIndeterminate: {},
+ dns.ExtendedErrorCodeDNSBogus: {},
+ dns.ExtendedErrorCodeSignatureExpired: {},
+ dns.ExtendedErrorCodeSignatureNotYetValid: {},
+ dns.ExtendedErrorCodeDNSKEYMissing: {},
+ dns.ExtendedErrorCodeRRSIGsMissing: {},
+ dns.ExtendedErrorCodeNoZoneKeyBitSet: {},
+ dns.ExtendedErrorCodeNSECMissing: {},
+ dns.ExtendedErrorCodeBlocked: {},
+ dns.ExtendedErrorCodeCensored: {},
+ dns.ExtendedErrorCodeFiltered: {},
+ dns.ExtendedErrorCodeProhibited: {},
+}
+
+// privateClientIface is the subset of the WireGuard interface needed by GetClientPrivate.
+type privateClientIface interface {
+ Name() string
+ Address() wgaddr.Address
+}
+
func SetCurrentMTU(mtu uint16) {
currentMTU = mtu
}
@@ -39,15 +94,17 @@ const (
// Set longer than UpstreamTimeout to ensure context timeout takes precedence
ClientTimeout = 5 * time.Second
- reactivatePeriod = 30 * time.Second
- probeTimeout = 2 * time.Second
-
// ipv6HeaderSize + udpHeaderSize, used to derive the maximum DNS UDP
// payload from the tunnel MTU.
ipUDPHeaderSize = 60 + 8
-)
-const testRecord = "com."
+ // raceMaxTotalTimeout caps the combined time spent walking all upstreams
+ // within one race, so a slow primary can't eat the whole race budget.
+ raceMaxTotalTimeout = 5 * time.Second
+ // raceMinPerUpstreamTimeout is the floor applied when dividing
+ // raceMaxTotalTimeout across upstreams within a race.
+ raceMinPerUpstreamTimeout = 2 * time.Second
+)
const (
protoUDP = "udp"
@@ -56,6 +113,69 @@ const (
type dnsProtocolKey struct{}
+type upstreamProtocolKey struct{}
+
+// upstreamProtocolResult holds the protocol used for the upstream exchange.
+// Stored as a pointer in context so the exchange function can set it.
+type upstreamProtocolResult struct {
+ protocol string
+}
+
+type upstreamClient interface {
+ exchange(ctx context.Context, upstream string, r *dns.Msg) (*dns.Msg, time.Duration, error)
+}
+
+type UpstreamResolver interface {
+ serveDNS(r *dns.Msg) (*dns.Msg, time.Duration, error)
+ upstreamExchange(upstream string, r *dns.Msg) (*dns.Msg, time.Duration, error)
+}
+
+// upstreamRace is an ordered list of upstreams derived from one configured
+// nameserver group. Order matters: the first upstream is tried first, the
+// second only on failure, and so on. Multiple upstreamRace values coexist
+// inside one resolver when overlapping nameserver groups target the same
+// domain; those races run in parallel and the first valid answer wins.
+type upstreamRace []netip.AddrPort
+
+// UpstreamHealth is the last query-path outcome for a single upstream,
+// consumed by nameserver-group status projection.
+type UpstreamHealth struct {
+ LastOk time.Time
+ LastFail time.Time
+ LastErr string
+}
+
+type upstreamResolverBase struct {
+ ctx context.Context
+ cancel context.CancelFunc
+ upstreamClient upstreamClient
+ upstreamServers []upstreamRace
+ domain domain.Domain
+ upstreamTimeout time.Duration
+
+ healthMu sync.RWMutex
+ health map[netip.AddrPort]*UpstreamHealth
+
+ statusRecorder *peer.Status
+ // selectedRoutes returns the current set of client routes the admin
+ // has enabled. Called lazily from the query hot path when an upstream
+ // might need a tunnel-bound client (iOS) and from health projection.
+ selectedRoutes func() route.HAMap
+}
+
+type upstreamFailure struct {
+ upstream netip.AddrPort
+ reason string
+}
+
+type raceResult struct {
+ msg *dns.Msg
+ upstream netip.AddrPort
+ protocol string
+ ede string
+ failures []upstreamFailure
+}
+
// contextWithDNSProtocol stores the inbound DNS protocol ("udp" or "tcp") in context.
func contextWithDNSProtocol(ctx context.Context, network string) context.Context {
return context.WithValue(ctx, dnsProtocolKey{}, network)
@@ -72,16 +192,8 @@ func dnsProtocolFromContext(ctx context.Context) string {
return ""
}
-type upstreamProtocolKey struct{}
-
-// upstreamProtocolResult holds the protocol used for the upstream exchange.
-// Stored as a pointer in context so the exchange function can set it.
-type upstreamProtocolResult struct {
- protocol string
-}
-
-// contextWithupstreamProtocolResult stores a mutable result holder in the context.
-func contextWithupstreamProtocolResult(ctx context.Context) (context.Context, *upstreamProtocolResult) {
+// contextWithUpstreamProtocolResult stores a mutable result holder in the context.
+func contextWithUpstreamProtocolResult(ctx context.Context) (context.Context, *upstreamProtocolResult) {
r := &upstreamProtocolResult{}
return context.WithValue(ctx, upstreamProtocolKey{}, r), r
}
@@ -96,67 +208,37 @@ func setUpstreamProtocol(ctx context.Context, protocol string) {
}
}
-type upstreamClient interface {
- exchange(ctx context.Context, upstream string, r *dns.Msg) (*dns.Msg, time.Duration, error)
-}
-
-type UpstreamResolver interface {
- serveDNS(r *dns.Msg) (*dns.Msg, time.Duration, error)
- upstreamExchange(upstream string, r *dns.Msg) (*dns.Msg, time.Duration, error)
-}
-
-type upstreamResolverBase struct {
- ctx context.Context
- cancel context.CancelFunc
- upstreamClient upstreamClient
- upstreamServers []netip.AddrPort
- domain string
- disabled bool
- successCount atomic.Int32
- mutex sync.Mutex
- reactivatePeriod time.Duration
- upstreamTimeout time.Duration
- wg sync.WaitGroup
-
- deactivate func(error)
- reactivate func()
- statusRecorder *peer.Status
- routeMatch func(netip.Addr) bool
-}
-
-type upstreamFailure struct {
- upstream netip.AddrPort
- reason string
-}
-
-func newUpstreamResolverBase(ctx context.Context, statusRecorder *peer.Status, domain string) *upstreamResolverBase {
+func newUpstreamResolverBase(ctx context.Context, statusRecorder *peer.Status, d domain.Domain) *upstreamResolverBase {
ctx, cancel := context.WithCancel(ctx)
return &upstreamResolverBase{
- ctx: ctx,
- cancel: cancel,
- domain: domain,
- upstreamTimeout: UpstreamTimeout,
- reactivatePeriod: reactivatePeriod,
- statusRecorder: statusRecorder,
+ ctx: ctx,
+ cancel: cancel,
+ domain: d,
+ upstreamTimeout: UpstreamTimeout,
+ statusRecorder: statusRecorder,
}
}
// String returns a string representation of the upstream resolver
func (u *upstreamResolverBase) String() string {
- return fmt.Sprintf("Upstream %s", u.upstreamServers)
+ return fmt.Sprintf("Upstream %s", u.flatUpstreams())
}
-// ID returns the unique handler ID
+// ID returns the unique handler ID. Race groupings and within-race
+// ordering are both part of the identity: [[A,B]] and [[A],[B]] query
+// the same servers but with different semantics (serial fallback vs
+// parallel race), so their handlers must not collide.
func (u *upstreamResolverBase) ID() types.HandlerID {
- servers := slices.Clone(u.upstreamServers)
- slices.SortFunc(servers, func(a, b netip.AddrPort) int { return a.Compare(b) })
-
hash := sha256.New()
- hash.Write([]byte(u.domain + ":"))
- for _, s := range servers {
- hash.Write([]byte(s.String()))
- hash.Write([]byte("|"))
+ hash.Write([]byte(u.domain.PunycodeString() + ":"))
+ for _, race := range u.upstreamServers {
+ hash.Write([]byte("["))
+ for _, s := range race {
+ hash.Write([]byte(s.String()))
+ hash.Write([]byte("|"))
+ }
+ hash.Write([]byte("]"))
}
return types.HandlerID("upstream-" + hex.EncodeToString(hash.Sum(nil)[:8]))
}
@@ -166,13 +248,31 @@ func (u *upstreamResolverBase) MatchSubdomains() bool {
}
func (u *upstreamResolverBase) Stop() {
- log.Debugf("stopping serving DNS for upstreams %s", u.upstreamServers)
+ log.Debugf("stopping serving DNS for upstreams %s", u.flatUpstreams())
u.cancel()
+}
- u.mutex.Lock()
- u.wg.Wait()
- u.mutex.Unlock()
+// flatUpstreams is for logging and ID hashing only, not for dispatch.
+func (u *upstreamResolverBase) flatUpstreams() []netip.AddrPort {
+ var out []netip.AddrPort
+ for _, g := range u.upstreamServers {
+ out = append(out, g...)
+ }
+ return out
+}
+// setSelectedRoutes swaps the accessor used to classify overlay-routed
+// upstreams. Called when route sources are wired after the handler was
+// built (permanent / iOS constructors).
+func (u *upstreamResolverBase) setSelectedRoutes(selected func() route.HAMap) {
+ u.selectedRoutes = selected
+}
+
+func (u *upstreamResolverBase) addRace(servers []netip.AddrPort) {
+ if len(servers) == 0 {
+ return
+ }
+ u.upstreamServers = append(u.upstreamServers, slices.Clone(servers))
}
// ServeDNS handles a DNS request
@@ -214,59 +314,226 @@ func (u *upstreamResolverBase) prepareRequest(r *dns.Msg) {
}
func (u *upstreamResolverBase) tryUpstreamServers(ctx context.Context, w dns.ResponseWriter, r *dns.Msg, logger *log.Entry) (bool, []upstreamFailure) {
- timeout := u.upstreamTimeout
- if len(u.upstreamServers) > 1 {
- maxTotal := 5 * time.Second
- minPerUpstream := 2 * time.Second
- scaledTimeout := maxTotal / time.Duration(len(u.upstreamServers))
- if scaledTimeout > minPerUpstream {
- timeout = scaledTimeout
- } else {
- timeout = minPerUpstream
- }
+ groups := u.upstreamServers
+ switch len(groups) {
+ case 0:
+ return false, nil
+ case 1:
+ return u.tryOnlyRace(ctx, w, r, groups[0], logger)
+ default:
+ return u.raceAll(ctx, w, r, groups, logger)
+ }
+}
+
+func (u *upstreamResolverBase) tryOnlyRace(ctx context.Context, w dns.ResponseWriter, r *dns.Msg, group upstreamRace, logger *log.Entry) (bool, []upstreamFailure) {
+ res := u.tryRace(ctx, r, group)
+ if res.msg == nil {
+ return false, res.failures
+ }
+ if res.ede != "" {
+ resutil.SetMeta(w, "ede", res.ede)
+ }
+ u.writeSuccessResponse(w, res.msg, res.upstream, r.Question[0].Name, res.protocol, logger)
+ return true, res.failures
+}
+
+// raceAll runs one worker per group in parallel, taking the first valid
+// answer and cancelling the rest.
+func (u *upstreamResolverBase) raceAll(ctx context.Context, w dns.ResponseWriter, r *dns.Msg, groups []upstreamRace, logger *log.Entry) (bool, []upstreamFailure) {
+ raceCtx, cancel := context.WithCancel(ctx)
+ defer cancel()
+
+ // Buffer sized to len(groups) so workers never block on send, even
+ // after the coordinator has returned.
+ results := make(chan raceResult, len(groups))
+ for _, g := range groups {
+ // tryRace clones the request per attempt, so workers never share
+ // a *dns.Msg and concurrent EDNS0 mutations can't race.
+ go func(g upstreamRace) {
+ results <- u.tryRace(raceCtx, r, g)
+ }(g)
}
var failures []upstreamFailure
- for _, upstream := range u.upstreamServers {
- if failure := u.queryUpstream(ctx, w, r, upstream, timeout, logger); failure != nil {
- failures = append(failures, *failure)
- } else {
- return true, failures
+ for range groups {
+ select {
+ case res := <-results:
+ failures = append(failures, res.failures...)
+ if res.msg != nil {
+ if res.ede != "" {
+ resutil.SetMeta(w, "ede", res.ede)
+ }
+ u.writeSuccessResponse(w, res.msg, res.upstream, r.Question[0].Name, res.protocol, logger)
+ return true, failures
+ }
+ case <-ctx.Done():
+ return false, failures
}
}
return false, failures
}
-// queryUpstream queries a single upstream server. Returns nil on success, or failure info to try next upstream.
-func (u *upstreamResolverBase) queryUpstream(parentCtx context.Context, w dns.ResponseWriter, r *dns.Msg, upstream netip.AddrPort, timeout time.Duration, logger *log.Entry) *upstreamFailure {
- var rm *dns.Msg
- var t time.Duration
- var err error
-
- var startTime time.Time
- var upstreamProto *upstreamProtocolResult
- func() {
- ctx, cancel := context.WithTimeout(parentCtx, timeout)
+func (u *upstreamResolverBase) tryRace(ctx context.Context, r *dns.Msg, group upstreamRace) raceResult {
+ timeout := u.upstreamTimeout
+ if len(group) > 1 {
+ // Cap the whole walk at raceMaxTotalTimeout: per-upstream timeouts
+ // still honor raceMinPerUpstreamTimeout as a floor for correctness
+ // on slow links, but the outer context ensures the combined walk
+ // cannot exceed the cap regardless of group size.
+ timeout = max(raceMaxTotalTimeout/time.Duration(len(group)), raceMinPerUpstreamTimeout)
+ var cancel context.CancelFunc
+ ctx, cancel = context.WithTimeout(ctx, raceMaxTotalTimeout)
defer cancel()
- ctx, upstreamProto = contextWithupstreamProtocolResult(ctx)
- startTime = time.Now()
- rm, t, err = u.upstreamClient.exchange(ctx, upstream.String(), r)
- }()
+ }
+
+ var failures []upstreamFailure
+ for _, upstream := range group {
+ if ctx.Err() != nil {
+ return raceResult{failures: failures}
+ }
+ // Clone the request per attempt: the exchange path mutates EDNS0
+ // options in-place, so reusing the same *dns.Msg across sequential
+ // upstreams would carry those mutations (e.g. a reduced UDP size)
+ // into the next attempt.
+ res, failure := u.queryUpstream(ctx, r.Copy(), upstream, timeout)
+ if failure != nil {
+ failures = append(failures, *failure)
+ continue
+ }
+ res.failures = failures
+ return res
+ }
+ return raceResult{failures: failures}
+}
+
+func (u *upstreamResolverBase) queryUpstream(parentCtx context.Context, r *dns.Msg, upstream netip.AddrPort, timeout time.Duration) (raceResult, *upstreamFailure) {
+ ctx, cancel := context.WithTimeout(parentCtx, timeout)
+ defer cancel()
+ ctx, upstreamProto := contextWithUpstreamProtocolResult(ctx)
+
+ // Advertise EDNS0 so the upstream may include Extended DNS Errors
+ // (RFC 8914) in failure responses; we use those to short-circuit
+ // failover for definitive answers like DNSSEC validation failures.
+ // The caller already passed a per-attempt copy, so we can mutate r
+ // directly; hadEdns reflects the original client request's state and
+ // controls whether we strip the OPT from the response.
+ hadEdns := r.IsEdns0() != nil
+ if !hadEdns {
+ r.SetEdns0(upstreamUDPSize(), false)
+ }
+
+ startTime := time.Now()
+ rm, _, err := u.upstreamClient.exchange(ctx, upstream.String(), r)
if err != nil {
- return u.handleUpstreamError(err, upstream, startTime)
+ // A parent cancellation (e.g., another race won and the coordinator
+ // cancelled the losers) is not an upstream failure. Check both the
+ // error chain and the parent context: a transport may surface the
+ // cancellation as a read/deadline error rather than context.Canceled.
+ if errors.Is(err, context.Canceled) || errors.Is(parentCtx.Err(), context.Canceled) {
+ return raceResult{}, &upstreamFailure{upstream: upstream, reason: "canceled"}
+ }
+ failure := u.handleUpstreamError(err, upstream, startTime)
+ u.markUpstreamFail(upstream, failure.reason)
+ return raceResult{}, failure
}
if rm == nil || !rm.Response {
- return &upstreamFailure{upstream: upstream, reason: "no response"}
+ u.markUpstreamFail(upstream, "no response")
+ return raceResult{}, &upstreamFailure{upstream: upstream, reason: "no response"}
+ }
+
+ proto := ""
+ if upstreamProto != nil {
+ proto = upstreamProto.protocol
}
if rm.Rcode == dns.RcodeServerFailure || rm.Rcode == dns.RcodeRefused {
- return &upstreamFailure{upstream: upstream, reason: dns.RcodeToString[rm.Rcode]}
+ if code, ok := nonRetryableEDE(rm); ok {
+ if !hadEdns {
+ stripOPT(rm)
+ }
+ u.markUpstreamOk(upstream)
+ return raceResult{msg: rm, upstream: upstream, protocol: proto, ede: edeName(code)}, nil
+ }
+ reason := dns.RcodeToString[rm.Rcode]
+ u.markUpstreamFail(upstream, reason)
+ return raceResult{}, &upstreamFailure{upstream: upstream, reason: reason}
}
- u.writeSuccessResponse(w, rm, upstream, r.Question[0].Name, t, upstreamProto, logger)
- return nil
+ if !hadEdns {
+ stripOPT(rm)
+ }
+
+ u.markUpstreamOk(upstream)
+ return raceResult{msg: rm, upstream: upstream, protocol: proto}, nil
+}
+
+// healthEntry returns the mutable health record for addr, lazily creating
+// the map and the entry. Caller must hold u.healthMu.
+func (u *upstreamResolverBase) healthEntry(addr netip.AddrPort) *UpstreamHealth {
+ if u.health == nil {
+ u.health = make(map[netip.AddrPort]*UpstreamHealth)
+ }
+ h := u.health[addr]
+ if h == nil {
+ h = &UpstreamHealth{}
+ u.health[addr] = h
+ }
+ return h
+}
+
+func (u *upstreamResolverBase) markUpstreamOk(addr netip.AddrPort) {
+ u.healthMu.Lock()
+ defer u.healthMu.Unlock()
+ h := u.healthEntry(addr)
+ h.LastOk = time.Now()
+ h.LastFail = time.Time{}
+ h.LastErr = ""
+}
+
+func (u *upstreamResolverBase) markUpstreamFail(addr netip.AddrPort, reason string) {
+ u.healthMu.Lock()
+ defer u.healthMu.Unlock()
+ h := u.healthEntry(addr)
+ h.LastFail = time.Now()
+ h.LastErr = reason
+}
+
+// UpstreamHealth returns a snapshot of per-upstream query outcomes.
+func (u *upstreamResolverBase) UpstreamHealth() map[netip.AddrPort]UpstreamHealth {
+ u.healthMu.RLock()
+ defer u.healthMu.RUnlock()
+ out := make(map[netip.AddrPort]UpstreamHealth, len(u.health))
+ for k, v := range u.health {
+ out[k] = *v
+ }
+ return out
+}
+
+// upstreamUDPSize returns the EDNS0 UDP buffer size we advertise to upstreams,
+// derived from the tunnel MTU and bounded against underflow.
+func upstreamUDPSize() uint16 {
+ if currentMTU > ipUDPHeaderSize {
+ return currentMTU - ipUDPHeaderSize
+ }
+ return dns.MinMsgSize
+}
+
+// stripOPT removes any OPT pseudo-RRs from the response's Extra section so
+// the response complies with RFC 6891 when the client did not advertise EDNS0.
+func stripOPT(rm *dns.Msg) {
+ if len(rm.Extra) == 0 {
+ return
+ }
+ out := rm.Extra[:0]
+ for _, rr := range rm.Extra {
+ if _, ok := rr.(*dns.OPT); ok {
+ continue
+ }
+ out = append(out, rr)
+ }
+ rm.Extra = out
}
func (u *upstreamResolverBase) handleUpstreamError(err error, upstream netip.AddrPort, startTime time.Time) *upstreamFailure {
@@ -282,12 +549,23 @@ func (u *upstreamResolverBase) handleUpstreamError(err error, upstream netip.Add
return &upstreamFailure{upstream: upstream, reason: reason}
}
-func (u *upstreamResolverBase) writeSuccessResponse(w dns.ResponseWriter, rm *dns.Msg, upstream netip.AddrPort, domain string, t time.Duration, upstreamProto *upstreamProtocolResult, logger *log.Entry) bool {
- u.successCount.Add(1)
+func (u *upstreamResolverBase) debugUpstreamTimeout(upstream netip.AddrPort) string {
+ if u.statusRecorder == nil {
+ return ""
+ }
+ peerInfo := findPeerForIP(upstream.Addr(), u.statusRecorder)
+ if peerInfo == nil {
+ return ""
+ }
+
+ return fmt.Sprintf("(routes through NetBird peer %s)", FormatPeerStatus(peerInfo))
+}
+
+func (u *upstreamResolverBase) writeSuccessResponse(w dns.ResponseWriter, rm *dns.Msg, upstream netip.AddrPort, domain string, proto string, logger *log.Entry) {
resutil.SetMeta(w, "upstream", upstream.String())
- if upstreamProto != nil && upstreamProto.protocol != "" {
- resutil.SetMeta(w, "upstream_protocol", upstreamProto.protocol)
+ if proto != "" {
+ resutil.SetMeta(w, "upstream_protocol", proto)
}
// Clear Zero bit from external responses to prevent upstream servers from
@@ -296,14 +574,11 @@ func (u *upstreamResolverBase) writeSuccessResponse(w dns.ResponseWriter, rm *dn
if err := w.WriteMsg(rm); err != nil {
logger.Errorf("failed to write DNS response for question domain=%s: %s", domain, err)
- return true
}
-
- return true
}
func (u *upstreamResolverBase) logUpstreamFailures(domain string, failures []upstreamFailure, succeeded bool, logger *log.Entry) {
- totalUpstreams := len(u.upstreamServers)
+ totalUpstreams := len(u.flatUpstreams())
failedCount := len(failures)
failureSummary := formatFailures(failures)
@@ -330,117 +605,32 @@ func formatFailures(failures []upstreamFailure) string {
return strings.Join(parts, ", ")
}
-// ProbeAvailability tests all upstream servers simultaneously and
-// disables the resolver if none work
-func (u *upstreamResolverBase) ProbeAvailability(ctx context.Context) {
- u.mutex.Lock()
- defer u.mutex.Unlock()
-
- // avoid probe if upstreams could resolve at least one query
- if u.successCount.Load() > 0 {
- return
+// nonRetryableEDE returns the first non-retryable EDE code carried in the
+// response, if any.
+func nonRetryableEDE(rm *dns.Msg) (uint16, bool) {
+ opt := rm.IsEdns0()
+ if opt == nil {
+ return 0, false
}
-
- var success bool
- var mu sync.Mutex
- var wg sync.WaitGroup
-
- var errs *multierror.Error
- for _, upstream := range u.upstreamServers {
- wg.Add(1)
- go func(upstream netip.AddrPort) {
- defer wg.Done()
- err := u.testNameserver(u.ctx, ctx, upstream, 500*time.Millisecond)
- if err != nil {
- mu.Lock()
- errs = multierror.Append(errs, err)
- mu.Unlock()
- log.Warnf("probing upstream nameserver %s: %s", upstream, err)
- return
- }
-
- mu.Lock()
- success = true
- mu.Unlock()
- }(upstream)
- }
-
- wg.Wait()
-
- select {
- case <-ctx.Done():
- return
- case <-u.ctx.Done():
- return
- default:
- }
-
- // didn't find a working upstream server, let's disable and try later
- if !success {
- u.disable(errs.ErrorOrNil())
-
- if u.statusRecorder == nil {
- return
+ for _, o := range opt.Option {
+ ede, ok := o.(*dns.EDNS0_EDE)
+ if !ok {
+ continue
+ }
+ if _, ok := nonRetryableEDECodes[ede.InfoCode]; ok {
+ return ede.InfoCode, true
}
-
- u.statusRecorder.PublishEvent(
- proto.SystemEvent_WARNING,
- proto.SystemEvent_DNS,
- "All upstream servers failed (probe failed)",
- "Unable to reach one or more DNS servers. This might affect your ability to connect to some services.",
- map[string]string{"upstreams": u.upstreamServersString()},
- )
}
+ return 0, false
}
-// waitUntilResponse retries, in an exponential interval, querying the upstream servers until it gets a positive response
-func (u *upstreamResolverBase) waitUntilResponse() {
- exponentialBackOff := &backoff.ExponentialBackOff{
- InitialInterval: 500 * time.Millisecond,
- RandomizationFactor: 0.5,
- Multiplier: 1.1,
- MaxInterval: u.reactivatePeriod,
- MaxElapsedTime: 0,
- Stop: backoff.Stop,
- Clock: backoff.SystemClock,
+// edeName returns a human-readable name for an EDE code, falling back to
+// the numeric code when unknown.
+func edeName(code uint16) string {
+ if name, ok := dns.ExtendedErrorCodeToString[code]; ok {
+ return name
}
-
- operation := func() error {
- select {
- case <-u.ctx.Done():
- return backoff.Permanent(fmt.Errorf("exiting upstream retry loop for upstreams %s: parent context has been canceled", u.upstreamServersString()))
- default:
- }
-
- for _, upstream := range u.upstreamServers {
- if err := u.testNameserver(u.ctx, nil, upstream, probeTimeout); err != nil {
- log.Tracef("upstream check for %s: %s", upstream, err)
- } else {
- // at least one upstream server is available, stop probing
- return nil
- }
- }
-
- log.Tracef("checking connectivity with upstreams %s failed. Retrying in %s", u.upstreamServersString(), exponentialBackOff.NextBackOff())
- return fmt.Errorf("upstream check call error")
- }
-
- err := backoff.Retry(operation, backoff.WithContext(exponentialBackOff, u.ctx))
- if err != nil {
- if errors.Is(err, context.Canceled) {
- log.Debugf("upstream retry loop exited for upstreams %s", u.upstreamServersString())
- } else {
- log.Warnf("upstream retry loop exited for upstreams %s: %v", u.upstreamServersString(), err)
- }
- return
- }
-
- log.Infof("upstreams %s are responsive again. Adding them back to system", u.upstreamServersString())
- u.successCount.Add(1)
- u.reactivate()
- u.mutex.Lock()
- u.disabled = false
- u.mutex.Unlock()
+ return fmt.Sprintf("EDE %d", code)
}
// isTimeout returns true if the given error is a network timeout error.
@@ -454,45 +644,6 @@ func isTimeout(err error) bool {
return false
}
-func (u *upstreamResolverBase) disable(err error) {
- if u.disabled {
- return
- }
-
- log.Warnf("Upstream resolving is Disabled for %v", reactivatePeriod)
- u.successCount.Store(0)
- u.deactivate(err)
- u.disabled = true
- u.wg.Add(1)
- go func() {
- defer u.wg.Done()
- u.waitUntilResponse()
- }()
-}
-
-func (u *upstreamResolverBase) upstreamServersString() string {
- var servers []string
- for _, server := range u.upstreamServers {
- servers = append(servers, server.String())
- }
- return strings.Join(servers, ", ")
-}
-
-func (u *upstreamResolverBase) testNameserver(baseCtx context.Context, externalCtx context.Context, server netip.AddrPort, timeout time.Duration) error {
- mergedCtx, cancel := context.WithTimeout(baseCtx, timeout)
- defer cancel()
-
- if externalCtx != nil {
- stop2 := context.AfterFunc(externalCtx, cancel)
- defer stop2()
- }
-
- r := new(dns.Msg).SetQuestion(testRecord, dns.TypeSOA)
-
- _, _, err := u.upstreamClient.exchange(mergedCtx, server.String(), r)
- return err
-}
-
// clientUDPMaxSize returns the maximum UDP response size the client accepts.
func clientUDPMaxSize(r *dns.Msg) int {
if opt := r.IsEdns0(); opt != nil {
@@ -504,13 +655,10 @@ func clientUDPMaxSize(r *dns.Msg) int {
// ExchangeWithFallback exchanges a DNS message with the upstream server.
// It first tries to use UDP, and if it is truncated, it falls back to TCP.
// If the inbound request came over TCP (via context), it skips the UDP attempt.
-// If the passed context is nil, this will use Exchange instead of ExchangeContext.
func ExchangeWithFallback(ctx context.Context, client *dns.Client, r *dns.Msg, upstream string) (*dns.Msg, time.Duration, error) {
// If the request came in over TCP, go straight to TCP upstream.
if dnsProtocolFromContext(ctx) == protoTCP {
- tcpClient := *client
- tcpClient.Net = protoTCP
- rm, t, err := tcpClient.ExchangeContext(ctx, r, upstream)
+ rm, t, err := toTCPClient(client).ExchangeContext(ctx, r, upstream)
if err != nil {
return nil, t, fmt.Errorf("with tcp: %w", err)
}
@@ -530,18 +678,7 @@ func ExchangeWithFallback(ctx context.Context, client *dns.Client, r *dns.Msg, u
opt.SetUDPSize(maxUDPPayload)
}
- var (
- rm *dns.Msg
- t time.Duration
- err error
- )
-
- if ctx == nil {
- rm, t, err = client.Exchange(r, upstream)
- } else {
- rm, t, err = client.ExchangeContext(ctx, r, upstream)
- }
-
+ rm, t, err := client.ExchangeContext(ctx, r, upstream)
if err != nil {
return nil, t, fmt.Errorf("with udp: %w", err)
}
@@ -555,15 +692,7 @@ func ExchangeWithFallback(ctx context.Context, client *dns.Client, r *dns.Msg, u
// data than the client's buffer, we could truncate locally and skip
// the TCP retry.
- tcpClient := *client
- tcpClient.Net = protoTCP
-
- if ctx == nil {
- rm, t, err = tcpClient.Exchange(r, upstream)
- } else {
- rm, t, err = tcpClient.ExchangeContext(ctx, r, upstream)
- }
-
+ rm, t, err = toTCPClient(client).ExchangeContext(ctx, r, upstream)
if err != nil {
return nil, t, fmt.Errorf("with tcp: %w", err)
}
@@ -577,6 +706,25 @@ func ExchangeWithFallback(ctx context.Context, client *dns.Client, r *dns.Msg, u
return rm, t, nil
}
+// toTCPClient returns a copy of c configured for TCP. If c's Dialer has a
+// *net.UDPAddr bound as LocalAddr (iOS does this to keep the source IP on
+// the tunnel interface), it is converted to the equivalent *net.TCPAddr
+// so net.Dialer doesn't reject the TCP dial with "mismatched local
+// address type".
+func toTCPClient(c *dns.Client) *dns.Client {
+ tcp := *c
+ tcp.Net = protoTCP
+ if tcp.Dialer == nil {
+ return &tcp
+ }
+ d := *tcp.Dialer
+ if ua, ok := d.LocalAddr.(*net.UDPAddr); ok {
+ d.LocalAddr = &net.TCPAddr{IP: ua.IP, Port: ua.Port, Zone: ua.Zone}
+ }
+ tcp.Dialer = &d
+ return &tcp
+}
+
// ExchangeWithNetstack performs a DNS exchange using netstack for dialing.
// This is needed when netstack is enabled to reach peer IPs through the tunnel.
func ExchangeWithNetstack(ctx context.Context, nsNet *netstack.Net, r *dns.Msg, upstream string) (*dns.Msg, error) {
@@ -718,15 +866,36 @@ func findPeerForIP(ip netip.Addr, statusRecorder *peer.Status) *peer.State {
return bestMatch
}
-func (u *upstreamResolverBase) debugUpstreamTimeout(upstream netip.AddrPort) string {
- if u.statusRecorder == nil {
- return ""
+// haMapRouteCount returns the total number of routes across all HA
+// groups in the map. route.HAMap is keyed by HAUniqueID with slices of
+// routes per key, so len(hm) is the number of HA groups, not routes.
+func haMapRouteCount(hm route.HAMap) int {
+ total := 0
+ for _, routes := range hm {
+ total += len(routes)
}
-
- peerInfo := findPeerForIP(upstream.Addr(), u.statusRecorder)
- if peerInfo == nil {
- return ""
- }
-
- return fmt.Sprintf("(routes through NetBird peer %s)", FormatPeerStatus(peerInfo))
+ return total
+}
+
+// haMapContains checks whether ip is covered by any concrete prefix in
+// the HA map. haveDynamic is reported separately: dynamic (domain-based)
+// routes carry a placeholder Network that can't be prefix-checked, so we
+// can't know at this point whether ip is reached through one. Callers
+// decide how to interpret the unknown: health projection treats it as
+// "possibly routed" to avoid emitting false-positive warnings during
+// startup, while iOS dial selection requires a concrete match before
+// binding to the tunnel.
+func haMapContains(hm route.HAMap, ip netip.Addr) (matched, haveDynamic bool) {
+ for _, routes := range hm {
+ for _, r := range routes {
+ if r.IsDynamic() {
+ haveDynamic = true
+ continue
+ }
+ if r.Network.Contains(ip) {
+ return true, haveDynamic
+ }
+ }
+ }
+ return false, haveDynamic
}
diff --git a/client/internal/dns/upstream_android.go b/client/internal/dns/upstream_android.go
index ee1ca42fe..f7ab48b10 100644
--- a/client/internal/dns/upstream_android.go
+++ b/client/internal/dns/upstream_android.go
@@ -11,6 +11,7 @@ import (
"github.com/netbirdio/netbird/client/internal/peer"
nbnet "github.com/netbirdio/netbird/client/net"
+ "github.com/netbirdio/netbird/shared/management/domain"
)
type upstreamResolver struct {
@@ -26,9 +27,9 @@ func newUpstreamResolver(
_ WGIface,
statusRecorder *peer.Status,
hostsDNSHolder *hostsDNSHolder,
- domain string,
+ d domain.Domain,
) (*upstreamResolver, error) {
- upstreamResolverBase := newUpstreamResolverBase(ctx, statusRecorder, domain)
+ upstreamResolverBase := newUpstreamResolverBase(ctx, statusRecorder, d)
c := &upstreamResolver{
upstreamResolverBase: upstreamResolverBase,
hostsDNSHolder: hostsDNSHolder,
@@ -86,7 +87,7 @@ func (u *upstreamResolver) isLocalResolver(upstream string) bool {
return false
}
-func GetClientPrivate(ip netip.Addr, interfaceName string, dialTimeout time.Duration) (*dns.Client, error) {
+func GetClientPrivate(_ privateClientIface, _ netip.Addr, dialTimeout time.Duration) (*dns.Client, error) {
return &dns.Client{
Timeout: dialTimeout,
Net: "udp",
diff --git a/client/internal/dns/upstream_general.go b/client/internal/dns/upstream_general.go
index 1143b6c51..dc841757b 100644
--- a/client/internal/dns/upstream_general.go
+++ b/client/internal/dns/upstream_general.go
@@ -12,6 +12,7 @@ import (
"golang.zx2c4.com/wireguard/tun/netstack"
"github.com/netbirdio/netbird/client/internal/peer"
+ "github.com/netbirdio/netbird/shared/management/domain"
)
type upstreamResolver struct {
@@ -24,9 +25,9 @@ func newUpstreamResolver(
wgIface WGIface,
statusRecorder *peer.Status,
_ *hostsDNSHolder,
- domain string,
+ d domain.Domain,
) (*upstreamResolver, error) {
- upstreamResolverBase := newUpstreamResolverBase(ctx, statusRecorder, domain)
+ upstreamResolverBase := newUpstreamResolverBase(ctx, statusRecorder, d)
nonIOS := &upstreamResolver{
upstreamResolverBase: upstreamResolverBase,
nsNet: wgIface.GetNet(),
@@ -52,7 +53,7 @@ func (u *upstreamResolver) exchange(ctx context.Context, upstream string, r *dns
return ExchangeWithFallback(ctx, client, r, upstream)
}
-func GetClientPrivate(ip netip.Addr, interfaceName string, dialTimeout time.Duration) (*dns.Client, error) {
+func GetClientPrivate(_ privateClientIface, _ netip.Addr, dialTimeout time.Duration) (*dns.Client, error) {
return &dns.Client{
Timeout: dialTimeout,
Net: "udp",
diff --git a/client/internal/dns/upstream_ios.go b/client/internal/dns/upstream_ios.go
index 02c11173b..b989bf0f9 100644
--- a/client/internal/dns/upstream_ios.go
+++ b/client/internal/dns/upstream_ios.go
@@ -15,13 +15,12 @@ import (
"golang.org/x/sys/unix"
"github.com/netbirdio/netbird/client/internal/peer"
+ "github.com/netbirdio/netbird/shared/management/domain"
)
type upstreamResolverIOS struct {
*upstreamResolverBase
- lIP netip.Addr
- lNet netip.Prefix
- interfaceName string
+ wgIface WGIface
}
func newUpstreamResolver(
@@ -29,15 +28,13 @@ func newUpstreamResolver(
wgIface WGIface,
statusRecorder *peer.Status,
_ *hostsDNSHolder,
- domain string,
+ d domain.Domain,
) (*upstreamResolverIOS, error) {
- upstreamResolverBase := newUpstreamResolverBase(ctx, statusRecorder, domain)
+ upstreamResolverBase := newUpstreamResolverBase(ctx, statusRecorder, d)
ios := &upstreamResolverIOS{
upstreamResolverBase: upstreamResolverBase,
- lIP: wgIface.Address().IP,
- lNet: wgIface.Address().Network,
- interfaceName: wgIface.Name(),
+ wgIface: wgIface,
}
ios.upstreamClient = ios
@@ -65,39 +62,55 @@ func (u *upstreamResolverIOS) exchange(ctx context.Context, upstream string, r *
} else {
upstreamIP = upstreamIP.Unmap()
}
- needsPrivate := u.lNet.Contains(upstreamIP) ||
- (u.routeMatch != nil && u.routeMatch(upstreamIP))
+ addr := u.wgIface.Address()
+ var routed bool
+ if u.selectedRoutes != nil {
+ // Only a concrete prefix match binds to the tunnel: dialing
+ // through a private client for an upstream we can't prove is
+ // routed would break public resolvers.
+ routed, _ = haMapContains(u.selectedRoutes(), upstreamIP)
+ }
+ needsPrivate := addr.Network.Contains(upstreamIP) ||
+ addr.IPv6Net.Contains(upstreamIP) ||
+ routed
if needsPrivate {
log.Debugf("using private client to query %s via upstream %s", r.Question[0].Name, upstream)
- client, err = GetClientPrivate(u.lIP, u.interfaceName, timeout)
+ client, err = GetClientPrivate(u.wgIface, upstreamIP, timeout)
if err != nil {
return nil, 0, fmt.Errorf("create private client: %s", err)
}
}
- // Cannot use client.ExchangeContext because it overwrites our Dialer
- return ExchangeWithFallback(nil, client, r, upstream)
+ return ExchangeWithFallback(ctx, client, r, upstream)
}
-// GetClientPrivate returns a new DNS client bound to the local IP address of the Netbird interface
-// This method is needed for iOS
-func GetClientPrivate(ip netip.Addr, interfaceName string, dialTimeout time.Duration) (*dns.Client, error) {
- index, err := getInterfaceIndex(interfaceName)
+// GetClientPrivate returns a new DNS client bound to the local IP of the Netbird interface.
+// It selects the v6 bind address when the upstream is IPv6 and the interface has one, otherwise v4.
+func GetClientPrivate(iface privateClientIface, upstreamIP netip.Addr, dialTimeout time.Duration) (*dns.Client, error) {
+ index, err := getInterfaceIndex(iface.Name())
if err != nil {
- log.Debugf("unable to get interface index for %s: %s", interfaceName, err)
+ log.Debugf("unable to get interface index for %s: %s", iface.Name(), err)
return nil, err
}
+ addr := iface.Address()
+ bindIP := addr.IP
+ if upstreamIP.Is6() && addr.HasIPv6() {
+ bindIP = addr.IPv6
+ }
+
+ proto, opt := unix.IPPROTO_IP, unix.IP_BOUND_IF
+ if bindIP.Is6() {
+ proto, opt = unix.IPPROTO_IPV6, unix.IPV6_BOUND_IF
+ }
+
dialer := &net.Dialer{
- LocalAddr: &net.UDPAddr{
- IP: ip.AsSlice(),
- Port: 0, // Let the OS pick a free port
- },
- Timeout: dialTimeout,
+ LocalAddr: net.UDPAddrFromAddrPort(netip.AddrPortFrom(bindIP, 0)),
+ Timeout: dialTimeout,
Control: func(network, address string, c syscall.RawConn) error {
var operr error
fn := func(s uintptr) {
- operr = unix.SetsockoptInt(int(s), unix.IPPROTO_IP, unix.IP_BOUND_IF, index)
+ operr = unix.SetsockoptInt(int(s), proto, opt, index)
}
if err := c.Control(fn); err != nil {
diff --git a/client/internal/dns/upstream_test.go b/client/internal/dns/upstream_test.go
index 1797fdad8..8b3c589f1 100644
--- a/client/internal/dns/upstream_test.go
+++ b/client/internal/dns/upstream_test.go
@@ -6,6 +6,7 @@ import (
"net"
"net/netip"
"strings"
+ "sync/atomic"
"testing"
"time"
@@ -73,7 +74,7 @@ func TestUpstreamResolver_ServeDNS(t *testing.T) {
servers = append(servers, netip.AddrPortFrom(addrPort.Addr().Unmap(), addrPort.Port()))
}
}
- resolver.upstreamServers = servers
+ resolver.addRace(servers)
resolver.upstreamTimeout = testCase.timeout
if testCase.cancelCTX {
cancel()
@@ -132,20 +133,10 @@ func (m *mockNetstackProvider) GetInterfaceGUIDString() (string, error) {
return "", nil
}
-type mockUpstreamResolver struct {
- r *dns.Msg
- rtt time.Duration
- err error
-}
-
-// exchange mock implementation of exchange from upstreamResolver
-func (c mockUpstreamResolver) exchange(_ context.Context, _ string, _ *dns.Msg) (*dns.Msg, time.Duration, error) {
- return c.r, c.rtt, c.err
-}
-
type mockUpstreamResponse struct {
- msg *dns.Msg
- err error
+ msg *dns.Msg
+ err error
+ delay time.Duration
}
type mockUpstreamResolverPerServer struct {
@@ -153,63 +144,19 @@ type mockUpstreamResolverPerServer struct {
rtt time.Duration
}
-func (c mockUpstreamResolverPerServer) exchange(_ context.Context, upstream string, _ *dns.Msg) (*dns.Msg, time.Duration, error) {
- if r, ok := c.responses[upstream]; ok {
- return r.msg, c.rtt, r.err
+func (c mockUpstreamResolverPerServer) exchange(ctx context.Context, upstream string, _ *dns.Msg) (*dns.Msg, time.Duration, error) {
+ r, ok := c.responses[upstream]
+ if !ok {
+ return nil, c.rtt, fmt.Errorf("no mock response for %s", upstream)
}
- return nil, c.rtt, fmt.Errorf("no mock response for %s", upstream)
-}
-
-func TestUpstreamResolver_DeactivationReactivation(t *testing.T) {
- mockClient := &mockUpstreamResolver{
- err: dns.ErrTime,
- r: new(dns.Msg),
- rtt: time.Millisecond,
- }
-
- resolver := &upstreamResolverBase{
- ctx: context.TODO(),
- upstreamClient: mockClient,
- upstreamTimeout: UpstreamTimeout,
- reactivatePeriod: time.Microsecond * 100,
- }
- addrPort, _ := netip.ParseAddrPort("0.0.0.0:1") // Use valid port for parsing, test will still fail on connection
- resolver.upstreamServers = []netip.AddrPort{netip.AddrPortFrom(addrPort.Addr().Unmap(), addrPort.Port())}
-
- failed := false
- resolver.deactivate = func(error) {
- failed = true
- // After deactivation, make the mock client work again
- mockClient.err = nil
- }
-
- reactivated := false
- resolver.reactivate = func() {
- reactivated = true
- }
-
- resolver.ProbeAvailability(context.TODO())
-
- if !failed {
- t.Errorf("expected that resolving was deactivated")
- return
- }
-
- if !resolver.disabled {
- t.Errorf("resolver should be Disabled")
- return
- }
-
- time.Sleep(time.Millisecond * 200)
-
- if !reactivated {
- t.Errorf("expected that resolving was reactivated")
- return
- }
-
- if resolver.disabled {
- t.Errorf("should be enabled")
+ if r.delay > 0 {
+ select {
+ case <-time.After(r.delay):
+ case <-ctx.Done():
+ return nil, c.rtt, ctx.Err()
+ }
}
+ return r.msg, c.rtt, r.err
}
func TestUpstreamResolver_Failover(t *testing.T) {
@@ -339,9 +286,9 @@ func TestUpstreamResolver_Failover(t *testing.T) {
resolver := &upstreamResolverBase{
ctx: ctx,
upstreamClient: trackingClient,
- upstreamServers: []netip.AddrPort{upstream1, upstream2},
upstreamTimeout: UpstreamTimeout,
}
+ resolver.addRace([]netip.AddrPort{upstream1, upstream2})
var responseMSG *dns.Msg
responseWriter := &test.MockResponseWriter{
@@ -421,9 +368,9 @@ func TestUpstreamResolver_SingleUpstreamFailure(t *testing.T) {
resolver := &upstreamResolverBase{
ctx: ctx,
upstreamClient: mockClient,
- upstreamServers: []netip.AddrPort{upstream},
upstreamTimeout: UpstreamTimeout,
}
+ resolver.addRace([]netip.AddrPort{upstream})
var responseMSG *dns.Msg
responseWriter := &test.MockResponseWriter{
@@ -440,6 +387,136 @@ func TestUpstreamResolver_SingleUpstreamFailure(t *testing.T) {
assert.Equal(t, dns.RcodeServerFailure, responseMSG.Rcode, "single upstream SERVFAIL should return SERVFAIL")
}
+// TestUpstreamResolver_RaceAcrossGroups covers two nameserver groups
+// configured for the same domain, with one broken group. The merge+race
+// path should answer as fast as the working group and not pay the timeout
+// of the broken one on every query.
+func TestUpstreamResolver_RaceAcrossGroups(t *testing.T) {
+ broken := netip.MustParseAddrPort("192.0.2.1:53")
+ working := netip.MustParseAddrPort("192.0.2.2:53")
+ successAnswer := "192.0.2.100"
+ timeoutErr := &net.OpError{Op: "read", Err: fmt.Errorf("i/o timeout")}
+
+ mockClient := &mockUpstreamResolverPerServer{
+ responses: map[string]mockUpstreamResponse{
+ // Force the broken upstream to only unblock via timeout /
+ // cancellation so the assertion below can't pass if races
+ // were run serially.
+ broken.String(): {err: timeoutErr, delay: 500 * time.Millisecond},
+ working.String(): {msg: buildMockResponse(dns.RcodeSuccess, successAnswer)},
+ },
+ rtt: time.Millisecond,
+ }
+
+ ctx, cancel := context.WithCancel(context.Background())
+ defer cancel()
+
+ resolver := &upstreamResolverBase{
+ ctx: ctx,
+ upstreamClient: mockClient,
+ upstreamTimeout: 250 * time.Millisecond,
+ }
+ resolver.addRace([]netip.AddrPort{broken})
+ resolver.addRace([]netip.AddrPort{working})
+
+ var responseMSG *dns.Msg
+ responseWriter := &test.MockResponseWriter{
+ WriteMsgFunc: func(m *dns.Msg) error {
+ responseMSG = m
+ return nil
+ },
+ }
+
+ inputMSG := new(dns.Msg).SetQuestion("example.com.", dns.TypeA)
+ start := time.Now()
+ resolver.ServeDNS(responseWriter, inputMSG)
+ elapsed := time.Since(start)
+
+ require.NotNil(t, responseMSG, "should write a response")
+ assert.Equal(t, dns.RcodeSuccess, responseMSG.Rcode)
+ require.NotEmpty(t, responseMSG.Answer)
+ assert.Contains(t, responseMSG.Answer[0].String(), successAnswer)
+ // Working group answers in a single RTT; the broken group's
+ // timeout (100ms) must not block the response.
+ assert.Less(t, elapsed, 100*time.Millisecond, "race must not wait for broken group's timeout")
+}
+
+// TestUpstreamResolver_AllGroupsFail checks that when every group fails the
+// resolver returns SERVFAIL rather than leaking a partial response.
+func TestUpstreamResolver_AllGroupsFail(t *testing.T) {
+ a := netip.MustParseAddrPort("192.0.2.1:53")
+ b := netip.MustParseAddrPort("192.0.2.2:53")
+
+ mockClient := &mockUpstreamResolverPerServer{
+ responses: map[string]mockUpstreamResponse{
+ a.String(): {msg: buildMockResponse(dns.RcodeServerFailure, "")},
+ b.String(): {msg: buildMockResponse(dns.RcodeServerFailure, "")},
+ },
+ rtt: time.Millisecond,
+ }
+
+ ctx, cancel := context.WithCancel(context.Background())
+ defer cancel()
+
+ resolver := &upstreamResolverBase{
+ ctx: ctx,
+ upstreamClient: mockClient,
+ upstreamTimeout: UpstreamTimeout,
+ }
+ resolver.addRace([]netip.AddrPort{a})
+ resolver.addRace([]netip.AddrPort{b})
+
+ var responseMSG *dns.Msg
+ responseWriter := &test.MockResponseWriter{
+ WriteMsgFunc: func(m *dns.Msg) error {
+ responseMSG = m
+ return nil
+ },
+ }
+
+ resolver.ServeDNS(responseWriter, new(dns.Msg).SetQuestion("example.com.", dns.TypeA))
+ require.NotNil(t, responseMSG)
+ assert.Equal(t, dns.RcodeServerFailure, responseMSG.Rcode)
+}
+
+// TestUpstreamResolver_HealthTracking verifies that query-path results are
+// recorded into per-upstream health, which is what projects back to
+// NSGroupState for status reporting.
+func TestUpstreamResolver_HealthTracking(t *testing.T) {
+ ok := netip.MustParseAddrPort("192.0.2.10:53")
+ bad := netip.MustParseAddrPort("192.0.2.11:53")
+
+ mockClient := &mockUpstreamResolverPerServer{
+ responses: map[string]mockUpstreamResponse{
+ ok.String(): {msg: buildMockResponse(dns.RcodeSuccess, "192.0.2.100")},
+ bad.String(): {msg: buildMockResponse(dns.RcodeServerFailure, "")},
+ },
+ rtt: time.Millisecond,
+ }
+
+ ctx, cancel := context.WithCancel(context.Background())
+ defer cancel()
+
+ resolver := &upstreamResolverBase{
+ ctx: ctx,
+ upstreamClient: mockClient,
+ upstreamTimeout: UpstreamTimeout,
+ }
+ resolver.addRace([]netip.AddrPort{ok, bad})
+
+ responseWriter := &test.MockResponseWriter{WriteMsgFunc: func(m *dns.Msg) error { return nil }}
+ resolver.ServeDNS(responseWriter, new(dns.Msg).SetQuestion("example.com.", dns.TypeA))
+
+ health := resolver.UpstreamHealth()
+ require.Contains(t, health, ok)
+ assert.False(t, health[ok].LastOk.IsZero(), "ok upstream should have LastOk set")
+ assert.Empty(t, health[ok].LastErr)
+
+ // bad upstream was never tried because ok answered first; its health
+ // should remain unset.
+ assert.NotContains(t, health, bad, "sibling upstream should not be queried when primary answers")
+}
+
func TestFormatFailures(t *testing.T) {
testCases := []struct {
name string
@@ -665,10 +742,10 @@ func TestExchangeWithFallback_EDNS0Capped(t *testing.T) {
// Verify that a client EDNS0 larger than our MTU-derived limit gets
// capped in the outgoing request so the upstream doesn't send a
// response larger than our read buffer.
- var receivedUDPSize uint16
+ var receivedUDPSize atomic.Uint32
udpHandler := dns.HandlerFunc(func(w dns.ResponseWriter, r *dns.Msg) {
if opt := r.IsEdns0(); opt != nil {
- receivedUDPSize = opt.UDPSize()
+ receivedUDPSize.Store(uint32(opt.UDPSize()))
}
m := new(dns.Msg)
m.SetReply(r)
@@ -699,7 +776,7 @@ func TestExchangeWithFallback_EDNS0Capped(t *testing.T) {
require.NotNil(t, rm)
expectedMax := uint16(currentMTU - ipUDPHeaderSize)
- assert.Equal(t, expectedMax, receivedUDPSize,
+ assert.Equal(t, expectedMax, uint16(receivedUDPSize.Load()),
"upstream should see capped EDNS0, not the client's 4096")
}
@@ -770,3 +847,132 @@ func TestExchangeWithFallback_TCPTruncatesToClientSize(t *testing.T) {
assert.Less(t, len(rm2.Answer), 20, "small EDNS0 client should get fewer records")
assert.True(t, rm2.Truncated, "response should be truncated for small buffer client")
}
+
+func msgWithEDE(rcode int, codes ...uint16) *dns.Msg {
+ m := new(dns.Msg)
+ m.Response = true
+ m.Rcode = rcode
+ if len(codes) == 0 {
+ return m
+ }
+ opt := &dns.OPT{Hdr: dns.RR_Header{Name: ".", Rrtype: dns.TypeOPT}}
+ opt.SetUDPSize(dns.MinMsgSize)
+ for _, c := range codes {
+ opt.Option = append(opt.Option, &dns.EDNS0_EDE{InfoCode: c})
+ }
+ m.Extra = append(m.Extra, opt)
+ return m
+}
+
+func TestNonRetryableEDE(t *testing.T) {
+ tests := []struct {
+ name string
+ msg *dns.Msg
+ wantOK bool
+ wantCode uint16
+ }{
+ {name: "no edns0", msg: msgWithEDE(dns.RcodeServerFailure)},
+ {
+ name: "opt without ede",
+ msg: func() *dns.Msg {
+ m := msgWithEDE(dns.RcodeServerFailure)
+ opt := &dns.OPT{Hdr: dns.RR_Header{Name: ".", Rrtype: dns.TypeOPT}}
+ opt.Option = append(opt.Option, &dns.EDNS0_NSID{Code: dns.EDNS0NSID})
+ m.Extra = []dns.RR{opt}
+ return m
+ }(),
+ },
+ {name: "ede dnsbogus", msg: msgWithEDE(dns.RcodeServerFailure, dns.ExtendedErrorCodeDNSBogus), wantOK: true, wantCode: dns.ExtendedErrorCodeDNSBogus},
+ {name: "ede signature expired", msg: msgWithEDE(dns.RcodeServerFailure, dns.ExtendedErrorCodeSignatureExpired), wantOK: true, wantCode: dns.ExtendedErrorCodeSignatureExpired},
+ {name: "ede blocked", msg: msgWithEDE(dns.RcodeServerFailure, dns.ExtendedErrorCodeBlocked), wantOK: true, wantCode: dns.ExtendedErrorCodeBlocked},
+ {name: "ede prohibited", msg: msgWithEDE(dns.RcodeRefused, dns.ExtendedErrorCodeProhibited), wantOK: true, wantCode: dns.ExtendedErrorCodeProhibited},
+ {name: "ede cached error retryable", msg: msgWithEDE(dns.RcodeServerFailure, dns.ExtendedErrorCodeCachedError)},
+ {name: "ede network error retryable", msg: msgWithEDE(dns.RcodeServerFailure, dns.ExtendedErrorCodeNetworkError)},
+ {name: "ede not ready retryable", msg: msgWithEDE(dns.RcodeServerFailure, dns.ExtendedErrorCodeNotReady)},
+ {
+ name: "first non-retryable wins",
+ msg: msgWithEDE(dns.RcodeServerFailure, dns.ExtendedErrorCodeNetworkError, dns.ExtendedErrorCodeDNSBogus),
+ wantOK: true,
+ wantCode: dns.ExtendedErrorCodeDNSBogus,
+ },
+ }
+ for _, tc := range tests {
+ t.Run(tc.name, func(t *testing.T) {
+ code, ok := nonRetryableEDE(tc.msg)
+ assert.Equal(t, tc.wantOK, ok, "ok should match")
+ if tc.wantOK {
+ assert.Equal(t, tc.wantCode, code, "code should match")
+ }
+ })
+ }
+}
+
+func TestEDEName(t *testing.T) {
+ assert.Equal(t, "DNSSEC Bogus", edeName(dns.ExtendedErrorCodeDNSBogus))
+ assert.Equal(t, "Signature Expired", edeName(dns.ExtendedErrorCodeSignatureExpired))
+ assert.Equal(t, "EDE 9999", edeName(9999), "unknown code falls back to numeric")
+}
+
+func TestStripOPT(t *testing.T) {
+ rm := &dns.Msg{
+ Extra: []dns.RR{
+ &dns.OPT{Hdr: dns.RR_Header{Name: ".", Rrtype: dns.TypeOPT}},
+ &dns.A{Hdr: dns.RR_Header{Name: "x.", Rrtype: dns.TypeA}, A: net.IPv4(1, 2, 3, 4)},
+ },
+ }
+ stripOPT(rm)
+ assert.Len(t, rm.Extra, 1, "OPT should be removed, A kept")
+ _, isOPT := rm.Extra[0].(*dns.OPT)
+ assert.False(t, isOPT, "remaining record must not be OPT")
+}
+
+func TestUpstreamResolver_NonRetryableEDEShortCircuits(t *testing.T) {
+ upstream1 := netip.MustParseAddrPort("192.0.2.1:53")
+ upstream2 := netip.MustParseAddrPort("192.0.2.2:53")
+
+ servfailWithEDE := msgWithEDE(dns.RcodeServerFailure, dns.ExtendedErrorCodeDNSBogus)
+ successResp := buildMockResponse(dns.RcodeSuccess, "192.0.2.100")
+
+ var queried []string
+ tracking := &trackingMockClient{
+ inner: &mockUpstreamResolverPerServer{
+ responses: map[string]mockUpstreamResponse{
+ upstream1.String(): {msg: servfailWithEDE},
+ upstream2.String(): {msg: successResp},
+ },
+ rtt: time.Millisecond,
+ },
+ queriedUpstreams: &queried,
+ }
+
+ ctx, cancel := context.WithCancel(context.Background())
+ defer cancel()
+
+ resolver := &upstreamResolverBase{
+ ctx: ctx,
+ upstreamClient: tracking,
+ upstreamServers: []upstreamRace{{upstream1, upstream2}},
+ upstreamTimeout: UpstreamTimeout,
+ }
+
+ var written *dns.Msg
+ w := &test.MockResponseWriter{
+ WriteMsgFunc: func(m *dns.Msg) error {
+ written = m
+ return nil
+ },
+ }
+
+ // Client query without EDNS0 must not see an OPT in the response.
+ q := new(dns.Msg).SetQuestion("example.com.", dns.TypeA)
+ resolver.ServeDNS(w, q)
+
+ require.NotNil(t, written, "response must be written")
+ assert.Equal(t, dns.RcodeServerFailure, written.Rcode, "SERVFAIL must propagate")
+ assert.Len(t, queried, 1, "only first upstream should be queried")
+ assert.Equal(t, upstream1.String(), queried[0])
+ for _, rr := range written.Extra {
+ _, isOPT := rr.(*dns.OPT)
+ assert.False(t, isOPT, "synthetic OPT must not leak to a non-EDNS0 client")
+ }
+}
diff --git a/client/internal/dns_test.go b/client/internal/dns_test.go
new file mode 100644
index 000000000..e15cc8fb7
--- /dev/null
+++ b/client/internal/dns_test.go
@@ -0,0 +1,138 @@
+package internal
+
+import (
+ "net/netip"
+ "testing"
+
+ "github.com/miekg/dns"
+ "github.com/stretchr/testify/assert"
+ "github.com/stretchr/testify/require"
+
+ nbdns "github.com/netbirdio/netbird/dns"
+)
+
+func TestCreatePTRRecord_IPv4(t *testing.T) {
+ record := nbdns.SimpleRecord{
+ Name: "peer1.netbird.cloud.",
+ Type: int(dns.TypeA),
+ Class: nbdns.DefaultClass,
+ TTL: 300,
+ RData: "100.64.0.5",
+ }
+ prefix := netip.MustParsePrefix("100.64.0.0/16")
+
+ ptr, ok := createPTRRecord(record, prefix)
+ require.True(t, ok)
+ assert.Equal(t, "5.0.64.100.in-addr.arpa.", ptr.Name)
+ assert.Equal(t, int(dns.TypePTR), ptr.Type)
+ assert.Equal(t, "peer1.netbird.cloud.", ptr.RData)
+}
+
+func TestCreatePTRRecord_IPv6(t *testing.T) {
+ record := nbdns.SimpleRecord{
+ Name: "peer1.netbird.cloud.",
+ Type: int(dns.TypeAAAA),
+ Class: nbdns.DefaultClass,
+ TTL: 300,
+ RData: "fd00:1234:5678::1",
+ }
+ prefix := netip.MustParsePrefix("fd00:1234:5678::/48")
+
+ ptr, ok := createPTRRecord(record, prefix)
+ require.True(t, ok)
+ assert.Equal(t, "1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.8.7.6.5.4.3.2.1.0.0.d.f.ip6.arpa.", ptr.Name)
+ assert.Equal(t, int(dns.TypePTR), ptr.Type)
+ assert.Equal(t, "peer1.netbird.cloud.", ptr.RData)
+}
+
+func TestCreatePTRRecord_OutOfRange(t *testing.T) {
+ record := nbdns.SimpleRecord{
+ Name: "peer1.netbird.cloud.",
+ Type: int(dns.TypeA),
+ RData: "10.0.0.1",
+ }
+ prefix := netip.MustParsePrefix("100.64.0.0/16")
+
+ _, ok := createPTRRecord(record, prefix)
+ assert.False(t, ok)
+}
+
+func TestGenerateReverseZoneName_IPv4(t *testing.T) {
+ tests := []struct {
+ prefix string
+ expected string
+ }{
+ {"100.64.0.0/16", "64.100.in-addr.arpa."},
+ {"10.0.0.0/8", "10.in-addr.arpa."},
+ {"192.168.1.0/24", "1.168.192.in-addr.arpa."},
+ }
+
+ for _, tt := range tests {
+ t.Run(tt.prefix, func(t *testing.T) {
+ zone, err := generateReverseZoneName(netip.MustParsePrefix(tt.prefix))
+ require.NoError(t, err)
+ assert.Equal(t, tt.expected, zone)
+ })
+ }
+}
+
+func TestGenerateReverseZoneName_IPv6(t *testing.T) {
+ tests := []struct {
+ prefix string
+ expected string
+ }{
+ {"fd00:1234:5678::/48", "8.7.6.5.4.3.2.1.0.0.d.f.ip6.arpa."},
+ {"fd00::/16", "0.0.d.f.ip6.arpa."},
+ {"fd12:3456:789a:bcde::/64", "e.d.c.b.a.9.8.7.6.5.4.3.2.1.d.f.ip6.arpa."},
+ }
+
+ for _, tt := range tests {
+ t.Run(tt.prefix, func(t *testing.T) {
+ zone, err := generateReverseZoneName(netip.MustParsePrefix(tt.prefix))
+ require.NoError(t, err)
+ assert.Equal(t, tt.expected, zone)
+ })
+ }
+}
+
+func TestCollectPTRRecords_BothFamilies(t *testing.T) {
+ config := &nbdns.Config{
+ CustomZones: []nbdns.CustomZone{
+ {
+ Domain: "netbird.cloud.",
+ Records: []nbdns.SimpleRecord{
+ {Name: "peer1.netbird.cloud.", Type: int(dns.TypeA), RData: "100.64.0.1"},
+ {Name: "peer1.netbird.cloud.", Type: int(dns.TypeAAAA), RData: "fd00::1"},
+ {Name: "peer2.netbird.cloud.", Type: int(dns.TypeA), RData: "100.64.0.2"},
+ },
+ },
+ },
+ }
+
+ v4Records := collectPTRRecords(config, netip.MustParsePrefix("100.64.0.0/16"))
+ assert.Len(t, v4Records, 2, "should collect 2 A record PTRs for the v4 prefix")
+
+ v6Records := collectPTRRecords(config, netip.MustParsePrefix("fd00::/64"))
+ assert.Len(t, v6Records, 1, "should collect 1 AAAA record PTR for the v6 prefix")
+}
+
+func TestAddReverseZone_IPv6(t *testing.T) {
+ config := &nbdns.Config{
+ CustomZones: []nbdns.CustomZone{
+ {
+ Domain: "netbird.cloud.",
+ Records: []nbdns.SimpleRecord{
+ {Name: "peer1.netbird.cloud.", Type: int(dns.TypeAAAA), RData: "fd00:1234:5678::1"},
+ },
+ },
+ },
+ }
+
+ addReverseZone(config, netip.MustParsePrefix("fd00:1234:5678::/48"))
+
+ require.Len(t, config.CustomZones, 2)
+ reverseZone := config.CustomZones[1]
+ assert.Equal(t, "8.7.6.5.4.3.2.1.0.0.d.f.ip6.arpa.", reverseZone.Domain)
+ assert.Len(t, reverseZone.Records, 1)
+ assert.Equal(t, int(dns.TypePTR), reverseZone.Records[0].Type)
+}
diff --git a/client/internal/dnsfwd/manager.go b/client/internal/dnsfwd/manager.go
index 58b88d9ef..c4c16cd3f 100644
--- a/client/internal/dnsfwd/manager.go
+++ b/client/internal/dnsfwd/manager.go
@@ -80,6 +80,7 @@ func (m *Manager) Start(fwdEntries []*ForwarderEntry) error {
return err
}
+ // IPv4-only: peers reach the forwarder via its v4 overlay address.
localAddr := m.wgIface.Address().IP
if localAddr.IsValid() && m.firewall != nil {
diff --git a/client/internal/ebpf/ebpf/dns_fwd_linux.go b/client/internal/ebpf/ebpf/dns_fwd_linux.go
index 93797da76..1e7774573 100644
--- a/client/internal/ebpf/ebpf/dns_fwd_linux.go
+++ b/client/internal/ebpf/ebpf/dns_fwd_linux.go
@@ -2,7 +2,8 @@ package ebpf
import (
"encoding/binary"
- "net"
+ "fmt"
+ "net/netip"
log "github.com/sirupsen/logrus"
)
@@ -12,7 +13,7 @@ const (
mapKeyDNSPort uint32 = 1
)
-func (tf *GeneralManager) LoadDNSFwd(ip string, dnsPort int) error {
+func (tf *GeneralManager) LoadDNSFwd(ip netip.Addr, dnsPort int) error {
log.Debugf("load eBPF DNS forwarder, watching addr: %s:53, redirect to port: %d", ip, dnsPort)
tf.lock.Lock()
defer tf.lock.Unlock()
@@ -22,7 +23,11 @@ func (tf *GeneralManager) LoadDNSFwd(ip string, dnsPort int) error {
return err
}
- err = tf.bpfObjs.NbMapDnsIp.Put(mapKeyDNSIP, ip2int(ip))
+ if !ip.Is4() {
+ return fmt.Errorf("eBPF DNS forwarder only supports IPv4, got %s", ip)
+ }
+ ip4 := ip.As4()
+ err = tf.bpfObjs.NbMapDnsIp.Put(mapKeyDNSIP, binary.BigEndian.Uint32(ip4[:]))
if err != nil {
return err
}
@@ -45,7 +50,3 @@ func (tf *GeneralManager) FreeDNSFwd() error {
return tf.unsetFeatureFlag(featureFlagDnsForwarder)
}
-func ip2int(ipString string) uint32 {
- ip := net.ParseIP(ipString)
- return binary.BigEndian.Uint32(ip.To4())
-}
diff --git a/client/internal/ebpf/manager/manager.go b/client/internal/ebpf/manager/manager.go
index af10142d5..25a767090 100644
--- a/client/internal/ebpf/manager/manager.go
+++ b/client/internal/ebpf/manager/manager.go
@@ -1,8 +1,10 @@
package manager
+import "net/netip"
+
// Manager is used to load multiple eBPF programs. E.g., current DNS programs and WireGuard proxy
type Manager interface {
- LoadDNSFwd(ip string, dnsPort int) error
+ LoadDNSFwd(ip netip.Addr, dnsPort int) error
FreeDNSFwd() error
LoadWgProxy(proxyPort, wgPort int) error
FreeWGProxy() error
diff --git a/client/internal/engine.go b/client/internal/engine.go
index 7f19e2d28..3bd0d4621 100644
--- a/client/internal/engine.go
+++ b/client/internal/engine.go
@@ -33,6 +33,7 @@ import (
"github.com/netbirdio/netbird/client/iface/device"
nbnetstack "github.com/netbirdio/netbird/client/iface/netstack"
"github.com/netbirdio/netbird/client/iface/udpmux"
+ "github.com/netbirdio/netbird/client/iface/wgaddr"
"github.com/netbirdio/netbird/client/internal/acl"
"github.com/netbirdio/netbird/client/internal/debug"
"github.com/netbirdio/netbird/client/internal/dns"
@@ -64,6 +65,7 @@ import (
mgm "github.com/netbirdio/netbird/shared/management/client"
"github.com/netbirdio/netbird/shared/management/domain"
mgmProto "github.com/netbirdio/netbird/shared/management/proto"
+ "github.com/netbirdio/netbird/shared/netiputil"
auth "github.com/netbirdio/netbird/shared/relay/auth/hmac"
relayClient "github.com/netbirdio/netbird/shared/relay/client"
signal "github.com/netbirdio/netbird/shared/signal/client"
@@ -88,8 +90,9 @@ type EngineConfig struct {
WgPort int
WgIfaceName string
- // WgAddr is a Wireguard local address (Netbird Network IP)
- WgAddr string
+ // WgAddr is the Wireguard local address (Netbird Network IP).
+ // Contains both v4 and optional v6 overlay addresses.
+ WgAddr wgaddr.Address
// WgPrivateKey is a Wireguard private key of our peer (it MUST never leave the machine)
WgPrivateKey wgtypes.Key
@@ -134,6 +137,7 @@ type EngineConfig struct {
DisableFirewall bool
BlockLANAccess bool
BlockInbound bool
+ DisableIPv6 bool
LazyConnectionEnabled bool
@@ -508,16 +512,7 @@ func (e *Engine) Start(netbirdConfig *mgmProto.NetbirdConfig, mgmtURL *url.URL)
e.routeManager.SetRouteChangeListener(e.mobileDep.NetworkChangeListener)
- e.dnsServer.SetRouteChecker(func(ip netip.Addr) bool {
- for _, routes := range e.routeManager.GetSelectedClientRoutes() {
- for _, r := range routes {
- if r.Network.Contains(ip) {
- return true
- }
- }
- }
- return false
- })
+ e.dnsServer.SetRouteSources(e.routeManager.GetSelectedClientRoutes, e.routeManager.GetActiveClientRoutes)
if err = e.wgInterfaceCreate(); err != nil {
log.Errorf("failed creating tunnel interface %s: [%s]", e.config.WgIfaceName, err.Error())
@@ -644,7 +639,7 @@ func (e *Engine) initFirewall() error {
rosenpassPort := e.rpManager.GetAddress().Port
port := firewallManager.Port{Values: []uint16{uint16(rosenpassPort)}}
- // this rule is static and will be torn down on engine down by the firewall manager
+ // IPv4-only: rosenpass peers connect via AllowedIps[0] which is always v4.
if _, err := e.firewall.AddPeerFiltering(
nil,
net.IP{0, 0, 0, 0},
@@ -696,10 +691,15 @@ func (e *Engine) blockLanAccess() {
log.Infof("blocking route LAN access for networks: %v", toBlock)
v4 := netip.PrefixFrom(netip.IPv4Unspecified(), 0)
+ v6 := netip.PrefixFrom(netip.IPv6Unspecified(), 0)
for _, network := range toBlock {
+ source := v4
+ if network.Addr().Is6() {
+ source = v6
+ }
if _, err := e.firewall.AddRouteFiltering(
nil,
- []netip.Prefix{v4},
+ []netip.Prefix{source},
firewallManager.Network{Prefix: network},
firewallManager.ProtocolALL,
nil,
@@ -737,7 +737,7 @@ func (e *Engine) modifyPeers(peersUpdate []*mgmProto.RemotePeerConfig) error {
if !ok {
continue
}
- if !compareNetIPLists(allowedIPs, p.GetAllowedIps()) {
+ if !compareNetIPLists(allowedIPs, e.filterAllowedIPs(p.GetAllowedIps())) {
modified = append(modified, p)
continue
}
@@ -1016,6 +1016,7 @@ func (e *Engine) updateChecksIfNew(checks []*mgmProto.Checks) error {
e.config.DisableFirewall,
e.config.BlockLANAccess,
e.config.BlockInbound,
+ e.config.DisableIPv6,
e.config.LazyConnectionEnabled,
e.config.EnableSSHRoot,
e.config.EnableSSHSFTP,
@@ -1043,6 +1044,13 @@ func (e *Engine) updateConfig(conf *mgmProto.PeerConfig) error {
return ErrResetConnection
}
+ if !e.config.DisableIPv6 && e.hasIPv6Changed(conf) {
+ log.Infof("peer IPv6 address changed, restarting client")
+ _ = CtxGetState(e.ctx).Wrap(ErrResetConnection)
+ e.clientCancel()
+ return ErrResetConnection
+ }
+
if conf.GetSshConfig() != nil {
if err := e.updateSSH(conf.GetSshConfig()); err != nil {
log.Warnf("failed handling SSH server setup: %v", err)
@@ -1051,6 +1059,7 @@ func (e *Engine) updateConfig(conf *mgmProto.PeerConfig) error {
state := e.statusRecorder.GetLocalPeerState()
state.IP = e.wgInterface.Address().String()
+ state.IPv6 = e.wgInterface.Address().IPv6String()
state.PubKey = e.config.WgPrivateKey.PublicKey().String()
state.KernelInterface = !e.wgInterface.IsUserspaceBind()
state.FQDN = conf.GetFqdn()
@@ -1059,6 +1068,28 @@ func (e *Engine) updateConfig(conf *mgmProto.PeerConfig) error {
return nil
}
+
+// hasIPv6Changed reports whether the IPv6 overlay address in the peer config
+// differs from the configured address (added, removed, or changed).
+// Compares against e.config.WgAddr (not the interface address, which may have
+// been cleared by ClearIPv6 if OS assignment failed).
+func (e *Engine) hasIPv6Changed(conf *mgmProto.PeerConfig) bool {
+ current := e.config.WgAddr
+ raw := conf.GetAddressV6()
+
+ if len(raw) == 0 {
+ return current.HasIPv6()
+ }
+
+ prefix, err := netiputil.DecodePrefix(raw)
+ if err != nil {
+ log.Errorf("decode v6 overlay address: %v", err)
+ return false
+ }
+
+ return !current.HasIPv6() || current.IPv6 != prefix.Addr() || current.IPv6Net != prefix.Masked()
+}
+
func (e *Engine) receiveJobEvents() {
e.jobExecutorWG.Add(1)
go func() {
@@ -1157,6 +1188,7 @@ func (e *Engine) receiveManagementEvents() {
e.config.DisableFirewall,
e.config.BlockLANAccess,
e.config.BlockInbound,
+ e.config.DisableIPv6,
e.config.LazyConnectionEnabled,
e.config.EnableSSHRoot,
e.config.EnableSSHSFTP,
@@ -1256,7 +1288,7 @@ func (e *Engine) updateNetworkMap(networkMap *mgmProto.NetworkMap) error {
protoDNSConfig = &mgmProto.DNSConfig{}
}
- dnsConfig := toDNSConfig(protoDNSConfig, e.wgInterface.Address().Network)
+ dnsConfig := toDNSConfig(protoDNSConfig, e.wgInterface.Address())
if err := e.dnsServer.UpdateDNSServer(serial, dnsConfig); err != nil {
log.Errorf("failed to update dns server, err: %v", err)
@@ -1345,9 +1377,6 @@ func (e *Engine) updateNetworkMap(networkMap *mgmProto.NetworkMap) error {
e.networkSerial = serial
- // Test received (upstream) servers for availability right away instead of upon usage.
- // If no server of a server group responds this will disable the respective handler and retry later.
- go e.dnsServer.ProbeAvailability()
return nil
}
@@ -1411,7 +1440,9 @@ func toRouteDomains(myPubKey string, routes []*route.Route) []*dnsfwd.ForwarderE
return entries
}
-func toDNSConfig(protoDNSConfig *mgmProto.DNSConfig, network netip.Prefix) nbdns.Config {
+func toDNSConfig(protoDNSConfig *mgmProto.DNSConfig, addr wgaddr.Address) nbdns.Config {
+ network := addr.Network
+ networkV6 := addr.IPv6Net
//nolint
forwarderPort := uint16(protoDNSConfig.GetForwarderPort())
if forwarderPort == 0 {
@@ -1468,6 +1499,9 @@ func toDNSConfig(protoDNSConfig *mgmProto.DNSConfig, network netip.Prefix) nbdns
if len(dnsUpdate.CustomZones) > 0 {
addReverseZone(&dnsUpdate, network)
+ if networkV6.IsValid() {
+ addReverseZone(&dnsUpdate, networkV6)
+ }
}
return dnsUpdate
@@ -1477,8 +1511,10 @@ func (e *Engine) updateOfflinePeers(offlinePeers []*mgmProto.RemotePeerConfig) {
replacement := make([]peer.State, len(offlinePeers))
for i, offlinePeer := range offlinePeers {
log.Debugf("added offline peer %s", offlinePeer.Fqdn)
+ v4, v6 := overlayAddrsFromAllowedIPs(offlinePeer.GetAllowedIps(), e.wgInterface.Address().IPv6Net)
replacement[i] = peer.State{
- IP: strings.Join(offlinePeer.GetAllowedIps(), ","),
+ IP: addrToString(v4),
+ IPv6: addrToString(v6),
PubKey: offlinePeer.GetWgPubKey(),
FQDN: offlinePeer.GetFqdn(),
ConnStatus: peer.StatusIdle,
@@ -1489,6 +1525,37 @@ func (e *Engine) updateOfflinePeers(offlinePeers []*mgmProto.RemotePeerConfig) {
e.statusRecorder.ReplaceOfflinePeers(replacement)
}
+// overlayAddrsFromAllowedIPs extracts the peer's v4 and v6 overlay addresses
+// from AllowedIPs strings. Only host routes (/32, /128) are considered; v6 must
+// fall within ourV6Net to distinguish overlay addresses from routed prefixes.
+func overlayAddrsFromAllowedIPs(allowedIPs []string, ourV6Net netip.Prefix) (v4, v6 netip.Addr) {
+ for _, cidr := range allowedIPs {
+ prefix, err := netip.ParsePrefix(cidr)
+ if err != nil {
+ log.Warnf("failed to parse AllowedIP %q: %v", cidr, err)
+ continue
+ }
+ addr := prefix.Addr().Unmap()
+ switch {
+ case addr.Is4() && prefix.Bits() == 32 && !v4.IsValid():
+ v4 = addr
+ case addr.Is6() && prefix.Bits() == 128 && ourV6Net.Contains(addr) && !v6.IsValid():
+ v6 = addr
+ }
+ if v4.IsValid() && v6.IsValid() {
+ break
+ }
+ }
+ return
+}
+
+func addrToString(addr netip.Addr) string {
+ if !addr.IsValid() {
+ return ""
+ }
+ return addr.String()
+}
+
// addNewPeers adds peers that were not know before but arrived from the Management service with the update
func (e *Engine) addNewPeers(peersUpdate []*mgmProto.RemotePeerConfig) error {
for _, p := range peersUpdate {
@@ -1514,15 +1581,23 @@ func (e *Engine) addNewPeer(peerConfig *mgmProto.RemotePeerConfig) error {
log.Errorf("failed to parse allowedIPS: %v", err)
return err
}
+ if allowedNetIP.Addr().Is6() && !e.wgInterface.Address().HasIPv6() {
+ continue
+ }
peerIPs = append(peerIPs, allowedNetIP)
}
+ if len(peerIPs) == 0 {
+ return fmt.Errorf("peer %s has no usable AllowedIPs", peerKey)
+ }
+
conn, err := e.createPeerConn(peerKey, peerIPs, peerConfig.AgentVersion)
if err != nil {
return fmt.Errorf("create peer connection: %w", err)
}
- err = e.statusRecorder.AddPeer(peerKey, peerConfig.Fqdn, peerIPs[0].Addr().String())
+ peerV4, peerV6 := overlayAddrsFromAllowedIPs(peerConfig.GetAllowedIps(), e.wgInterface.Address().IPv6Net)
+ err = e.statusRecorder.AddPeer(peerKey, peerConfig.Fqdn, addrToString(peerV4), addrToString(peerV6))
if err != nil {
log.Warnf("error adding peer %s to status recorder, got error: %v", peerKey, err)
}
@@ -1757,6 +1832,7 @@ func (e *Engine) readInitialSettings() ([]*route.Route, *nbdns.Config, bool, err
e.config.DisableFirewall,
e.config.BlockLANAccess,
e.config.BlockInbound,
+ e.config.DisableIPv6,
e.config.LazyConnectionEnabled,
e.config.EnableSSHRoot,
e.config.EnableSSHSFTP,
@@ -1770,7 +1846,7 @@ func (e *Engine) readInitialSettings() ([]*route.Route, *nbdns.Config, bool, err
return nil, nil, false, err
}
routes := toRoutes(netMap.GetRoutes())
- dnsCfg := toDNSConfig(netMap.GetDNSConfig(), e.wgInterface.Address().Network)
+ dnsCfg := toDNSConfig(netMap.GetDNSConfig(), e.wgInterface.Address())
dnsFeatureFlag := toDNSFeatureFlag(netMap)
return routes, &dnsCfg, dnsFeatureFlag, nil
}
@@ -1812,7 +1888,10 @@ func (e *Engine) wgInterfaceCreate() (err error) {
case "android":
err = e.wgInterface.CreateOnAndroid(e.routeManager.InitialRouteRange(), e.dnsServer.DnsIP().String(), e.dnsServer.SearchDomains())
case "ios":
- e.mobileDep.NetworkChangeListener.SetInterfaceIP(e.config.WgAddr)
+ e.mobileDep.NetworkChangeListener.SetInterfaceIP(e.config.WgAddr.String())
+ if e.config.WgAddr.HasIPv6() {
+ e.mobileDep.NetworkChangeListener.SetInterfaceIPv6(e.config.WgAddr.IPv6String())
+ }
err = e.wgInterface.Create()
default:
err = e.wgInterface.Create()
@@ -1841,7 +1920,7 @@ func (e *Engine) newDnsServer(dnsConfig *nbdns.Config) (dns.Server, error) {
return dnsServer, nil
case "ios":
- dnsServer := dns.NewDefaultServerIos(e.ctx, e.wgInterface, e.mobileDep.DnsManager, e.mobileDep.HostDNSAddresses, e.statusRecorder, e.config.DisableDNS)
+ dnsServer := dns.NewDefaultServerIos(e.ctx, e.wgInterface, e.mobileDep.DnsManager, e.statusRecorder, e.config.DisableDNS)
return dnsServer, nil
default:
@@ -2089,6 +2168,14 @@ func (e *Engine) GetWgAddr() netip.Addr {
return e.wgInterface.Address().IP
}
+// GetWgV6Addr returns the IPv6 overlay address of the WireGuard interface.
+func (e *Engine) GetWgV6Addr() netip.Addr {
+ if e.wgInterface == nil {
+ return netip.Addr{}
+ }
+ return e.wgInterface.Address().IPv6
+}
+
func (e *Engine) RenewTun(fd int) error {
e.syncMsgMux.Lock()
wgInterface := e.wgInterface
@@ -2370,8 +2457,7 @@ func getInterfacePrefixes() ([]netip.Prefix, error) {
prefix := netip.PrefixFrom(addr.Unmap(), ones).Masked()
ip := prefix.Addr()
- // TODO: add IPv6
- if !ip.Is4() || ip.IsLoopback() || ip.IsMulticast() || ip.IsLinkLocalUnicast() || ip.IsLinkLocalMulticast() {
+ if ip.IsLoopback() || ip.IsMulticast() || ip.IsLinkLocalUnicast() || ip.IsLinkLocalMulticast() {
continue
}
@@ -2382,6 +2468,24 @@ func getInterfacePrefixes() ([]netip.Prefix, error) {
return prefixes, nberrors.FormatErrorOrNil(merr)
}
+// filterAllowedIPs strips IPv6 entries when the local interface has no v6 address.
+// This covers both the explicit --disable-ipv6 flag (v6 never assigned) and the
+// case where OS v6 assignment failed (ClearIPv6). Without this, WireGuard would
+// accept v6 traffic that the native firewall cannot filter.
+func (e *Engine) filterAllowedIPs(ips []string) []string {
+ if e.wgInterface.Address().HasIPv6() {
+ return ips
+ }
+ filtered := make([]string, 0, len(ips))
+ for _, s := range ips {
+ p, err := netip.ParsePrefix(s)
+ if err != nil || !p.Addr().Is6() {
+ filtered = append(filtered, s)
+ }
+ }
+ return filtered
+}
+
// compareNetIPLists compares a list of netip.Prefix with a list of strings.
// return true if both lists are equal, false otherwise.
func compareNetIPLists(list1 []netip.Prefix, list2 []string) bool {
diff --git a/client/internal/engine_ssh.go b/client/internal/engine_ssh.go
index 1419bc262..53d2c1122 100644
--- a/client/internal/engine_ssh.go
+++ b/client/internal/engine_ssh.go
@@ -41,6 +41,14 @@ func (e *Engine) setupSSHPortRedirection() error {
}
log.Infof("SSH port redirection enabled: %s:22 -> %s:22022", localAddr, localAddr)
+ if v6 := e.wgInterface.Address().IPv6; v6.IsValid() {
+ if err := e.firewall.AddInboundDNAT(v6, firewallManager.ProtocolTCP, 22, 22022); err != nil {
+ log.Warnf("failed to add IPv6 SSH port redirection: %v", err)
+ } else {
+ log.Infof("SSH port redirection enabled: [%s]:22 -> [%s]:22022", v6, v6)
+ }
+ }
+
return nil
}
@@ -137,12 +145,13 @@ func (e *Engine) extractPeerSSHInfo(remotePeers []*mgmProto.RemotePeerConfig) []
continue
}
- peerIP := e.extractPeerIP(peerConfig)
+ peerV4, peerV6 := overlayAddrsFromAllowedIPs(peerConfig.GetAllowedIps(), e.wgInterface.Address().IPv6Net)
hostname := e.extractHostname(peerConfig)
peerInfo = append(peerInfo, sshconfig.PeerSSHInfo{
Hostname: hostname,
- IP: peerIP,
+ IP: peerV4,
+ IPv6: peerV6,
FQDN: peerConfig.GetFqdn(),
})
}
@@ -150,18 +159,6 @@ func (e *Engine) extractPeerSSHInfo(remotePeers []*mgmProto.RemotePeerConfig) []
return peerInfo
}
-// extractPeerIP extracts IP address from peer's allowed IPs
-func (e *Engine) extractPeerIP(peerConfig *mgmProto.RemotePeerConfig) string {
- if len(peerConfig.GetAllowedIps()) == 0 {
- return ""
- }
-
- if prefix, err := netip.ParsePrefix(peerConfig.GetAllowedIps()[0]); err == nil {
- return prefix.Addr().String()
- }
- return ""
-}
-
// extractHostname extracts short hostname from FQDN
func (e *Engine) extractHostname(peerConfig *mgmProto.RemotePeerConfig) string {
fqdn := peerConfig.GetFqdn()
@@ -208,7 +205,7 @@ func (e *Engine) GetPeerSSHKey(peerAddress string) ([]byte, bool) {
fullStatus := statusRecorder.GetFullStatus()
for _, peerState := range fullStatus.Peers {
- if peerState.IP == peerAddress || peerState.FQDN == peerAddress {
+ if peerState.IP == peerAddress || peerState.FQDN == peerAddress || peerState.IPv6 == peerAddress {
if len(peerState.SSHHostKey) > 0 {
return peerState.SSHHostKey, true
}
@@ -262,6 +259,13 @@ func (e *Engine) startSSHServer(jwtConfig *sshserver.JWTConfig) error {
return fmt.Errorf("start SSH server: %w", err)
}
+ if v6 := wgAddr.IPv6; v6.IsValid() {
+ v6Addr := netip.AddrPortFrom(v6, sshserver.InternalSSHPort)
+ if err := server.AddListener(e.ctx, v6Addr); err != nil {
+ log.Warnf("failed to add IPv6 SSH listener: %v", err)
+ }
+ }
+
e.sshServer = server
if netstackNet := e.wgInterface.GetNet(); netstackNet != nil {
@@ -330,6 +334,12 @@ func (e *Engine) cleanupSSHPortRedirection() error {
}
log.Debugf("SSH port redirection removed: %s:22 -> %s:22022", localAddr, localAddr)
+ if v6 := e.wgInterface.Address().IPv6; v6.IsValid() {
+ if err := e.firewall.RemoveInboundDNAT(v6, firewallManager.ProtocolTCP, 22, 22022); err != nil {
+ log.Debugf("failed to remove IPv6 SSH port redirection: %v", err)
+ }
+ }
+
return nil
}
diff --git a/client/internal/engine_test.go b/client/internal/engine_test.go
index f4c5be70a..834a49a09 100644
--- a/client/internal/engine_test.go
+++ b/client/internal/engine_test.go
@@ -67,6 +67,7 @@ import (
mgmt "github.com/netbirdio/netbird/shared/management/client"
mgmtProto "github.com/netbirdio/netbird/shared/management/proto"
relayClient "github.com/netbirdio/netbird/shared/relay/client"
+ "github.com/netbirdio/netbird/shared/netiputil"
signal "github.com/netbirdio/netbird/shared/signal/client"
"github.com/netbirdio/netbird/shared/signal/proto"
signalServer "github.com/netbirdio/netbird/signal/server"
@@ -95,7 +96,7 @@ type MockWGIface struct {
AddressFunc func() wgaddr.Address
ToInterfaceFunc func() *net.Interface
UpFunc func() (*udpmux.UniversalUDPMuxDefault, error)
- UpdateAddrFunc func(newAddr string) error
+ UpdateAddrFunc func(newAddr wgaddr.Address) error
UpdatePeerFunc func(peerKey string, allowedIps []netip.Prefix, keepAlive time.Duration, endpoint *net.UDPAddr, preSharedKey *wgtypes.Key) error
RemovePeerFunc func(peerKey string) error
AddAllowedIPFunc func(peerKey string, allowedIP netip.Prefix) error
@@ -157,7 +158,7 @@ func (m *MockWGIface) Up() (*udpmux.UniversalUDPMuxDefault, error) {
return m.UpFunc()
}
-func (m *MockWGIface) UpdateAddr(newAddr string) error {
+func (m *MockWGIface) UpdateAddr(newAddr wgaddr.Address) error {
return m.UpdateAddrFunc(newAddr)
}
@@ -254,7 +255,7 @@ func TestEngine_SSH(t *testing.T) {
ctx, cancel,
&EngineConfig{
WgIfaceName: "utun101",
- WgAddr: "100.64.0.1/24",
+ WgAddr: wgaddr.MustParseWGAddress("100.64.0.1/24"),
WgPrivateKey: key,
WgPort: 33100,
ServerSSHAllowed: true,
@@ -431,7 +432,7 @@ func TestEngine_UpdateNetworkMap(t *testing.T) {
relayMgr := relayClient.NewManager(ctx, nil, key.PublicKey().String(), iface.DefaultMTU)
engine := NewEngine(ctx, cancel, &EngineConfig{
WgIfaceName: "utun102",
- WgAddr: "100.64.0.1/24",
+ WgAddr: wgaddr.MustParseWGAddress("100.64.0.1/24"),
WgPrivateKey: key,
WgPort: 33100,
MTU: iface.DefaultMTU,
@@ -655,7 +656,7 @@ func TestEngine_Sync(t *testing.T) {
relayMgr := relayClient.NewManager(ctx, nil, key.PublicKey().String(), iface.DefaultMTU)
engine := NewEngine(ctx, cancel, &EngineConfig{
WgIfaceName: "utun103",
- WgAddr: "100.64.0.1/24",
+ WgAddr: wgaddr.MustParseWGAddress("100.64.0.1/24"),
WgPrivateKey: key,
WgPort: 33100,
MTU: iface.DefaultMTU,
@@ -825,7 +826,7 @@ func TestEngine_UpdateNetworkMapWithRoutes(t *testing.T) {
relayMgr := relayClient.NewManager(ctx, nil, key.PublicKey().String(), iface.DefaultMTU)
engine := NewEngine(ctx, cancel, &EngineConfig{
WgIfaceName: wgIfaceName,
- WgAddr: wgAddr,
+ WgAddr: wgaddr.MustParseWGAddress(wgAddr),
WgPrivateKey: key,
WgPort: 33100,
MTU: iface.DefaultMTU,
@@ -843,7 +844,7 @@ func TestEngine_UpdateNetworkMapWithRoutes(t *testing.T) {
opts := iface.WGIFaceOpts{
IFaceName: wgIfaceName,
- Address: wgAddr,
+ Address: wgaddr.MustParseWGAddress(wgAddr),
WGPort: engine.config.WgPort,
WGPrivKey: key.String(),
MTU: iface.DefaultMTU,
@@ -1032,7 +1033,7 @@ func TestEngine_UpdateNetworkMapWithDNSUpdate(t *testing.T) {
relayMgr := relayClient.NewManager(ctx, nil, key.PublicKey().String(), iface.DefaultMTU)
engine := NewEngine(ctx, cancel, &EngineConfig{
WgIfaceName: wgIfaceName,
- WgAddr: wgAddr,
+ WgAddr: wgaddr.MustParseWGAddress(wgAddr),
WgPrivateKey: key,
WgPort: 33100,
MTU: iface.DefaultMTU,
@@ -1050,7 +1051,7 @@ func TestEngine_UpdateNetworkMapWithDNSUpdate(t *testing.T) {
}
opts := iface.WGIFaceOpts{
IFaceName: wgIfaceName,
- Address: wgAddr,
+ Address: wgaddr.MustParseWGAddress(wgAddr),
WGPort: 33100,
WGPrivKey: key.String(),
MTU: iface.DefaultMTU,
@@ -1555,7 +1556,7 @@ func createEngine(ctx context.Context, cancel context.CancelFunc, setupKey strin
wgPort := 33100 + i
conf := &EngineConfig{
WgIfaceName: ifaceName,
- WgAddr: resp.PeerConfig.Address,
+ WgAddr: wgaddr.MustParseWGAddress(resp.PeerConfig.Address),
WgPrivateKey: key,
WgPort: wgPort,
MTU: iface.DefaultMTU,
@@ -1705,3 +1706,224 @@ func getPeers(e *Engine) int {
return len(e.peerStore.PeersPubKey())
}
+
+func mustEncodePrefix(t *testing.T, p netip.Prefix) []byte {
+ t.Helper()
+ b, err := netiputil.EncodePrefix(p)
+ require.NoError(t, err)
+ return b
+}
+
+func TestEngine_hasIPv6Changed(t *testing.T) {
+ v4Only := wgaddr.MustParseWGAddress("100.64.0.1/16")
+
+ v4v6 := wgaddr.MustParseWGAddress("100.64.0.1/16")
+ v4v6.IPv6 = netip.MustParseAddr("fd00::1")
+ v4v6.IPv6Net = netip.MustParsePrefix("fd00::1/64").Masked()
+
+ tests := []struct {
+ name string
+ current wgaddr.Address
+ confV6 []byte
+ expected bool
+ }{
+ {
+ name: "no v6 before, no v6 now",
+ current: v4Only,
+ confV6: nil,
+ expected: false,
+ },
+ {
+ name: "no v6 before, v6 added",
+ current: v4Only,
+ confV6: mustEncodePrefix(t, netip.MustParsePrefix("fd00::1/64")),
+ expected: true,
+ },
+ {
+ name: "had v6, now removed",
+ current: v4v6,
+ confV6: nil,
+ expected: true,
+ },
+ {
+ name: "had v6, same v6",
+ current: v4v6,
+ confV6: mustEncodePrefix(t, netip.MustParsePrefix("fd00::1/64")),
+ expected: false,
+ },
+ {
+ name: "had v6, different v6",
+ current: v4v6,
+ confV6: mustEncodePrefix(t, netip.MustParsePrefix("fd00::2/64")),
+ expected: true,
+ },
+ {
+ name: "same v6 addr, different prefix length",
+ current: v4v6,
+ confV6: mustEncodePrefix(t, netip.MustParsePrefix("fd00::1/80")),
+ expected: true,
+ },
+ {
+ name: "decode error keeps status quo",
+ current: v4Only,
+ confV6: []byte{1, 2, 3},
+ expected: false,
+ },
+ }
+
+ for _, tt := range tests {
+ t.Run(tt.name, func(t *testing.T) {
+ engine := &Engine{
+ config: &EngineConfig{WgAddr: tt.current},
+ }
+ conf := &mgmtProto.PeerConfig{
+ AddressV6: tt.confV6,
+ }
+ assert.Equal(t, tt.expected, engine.hasIPv6Changed(conf))
+ })
+ }
+}
+
+func TestFilterAllowedIPs(t *testing.T) {
+ v4v6Addr := wgaddr.MustParseWGAddress("100.64.0.1/16")
+ v4v6Addr.IPv6 = netip.MustParseAddr("fd00::1")
+ v4v6Addr.IPv6Net = netip.MustParsePrefix("fd00::1/64").Masked()
+
+ v4OnlyAddr := wgaddr.MustParseWGAddress("100.64.0.1/16")
+
+ tests := []struct {
+ name string
+ addr wgaddr.Address
+ input []string
+ expected []string
+ }{
+ {
+ name: "interface has v6, keep all",
+ addr: v4v6Addr,
+ input: []string{"100.64.0.1/32", "fd00::1/128"},
+ expected: []string{"100.64.0.1/32", "fd00::1/128"},
+ },
+ {
+ name: "no v6, strip v6",
+ addr: v4OnlyAddr,
+ input: []string{"100.64.0.1/32", "fd00::1/128"},
+ expected: []string{"100.64.0.1/32"},
+ },
+ {
+ name: "no v6, only v4",
+ addr: v4OnlyAddr,
+ input: []string{"100.64.0.1/32", "10.0.0.0/8"},
+ expected: []string{"100.64.0.1/32", "10.0.0.0/8"},
+ },
+ {
+ name: "no v6, only v6 input",
+ addr: v4OnlyAddr,
+ input: []string{"fd00::1/128", "::/0"},
+ expected: []string{},
+ },
+ {
+ name: "no v6, invalid prefix preserved",
+ addr: v4OnlyAddr,
+ input: []string{"100.64.0.1/32", "garbage"},
+ expected: []string{"100.64.0.1/32", "garbage"},
+ },
+ {
+ name: "no v6, empty input",
+ addr: v4OnlyAddr,
+ input: []string{},
+ expected: []string{},
+ },
+ }
+
+ for _, tt := range tests {
+ t.Run(tt.name, func(t *testing.T) {
+ addr := tt.addr
+ engine := &Engine{
+ config: &EngineConfig{},
+ wgInterface: &MockWGIface{
+ AddressFunc: func() wgaddr.Address { return addr },
+ },
+ }
+ result := engine.filterAllowedIPs(tt.input)
+ assert.Equal(t, tt.expected, result)
+ })
+ }
+}
+
+func TestOverlayAddrsFromAllowedIPs(t *testing.T) {
+ ourV6Net := netip.MustParsePrefix("fd00:1234:5678:abcd::/64")
+
+ tests := []struct {
+ name string
+ allowedIPs []string
+ ourV6Net netip.Prefix
+ wantV4 string
+ wantV6 string
+ }{
+ {
+ name: "v4 only",
+ allowedIPs: []string{"100.64.0.1/32"},
+ ourV6Net: ourV6Net,
+ wantV4: "100.64.0.1",
+ wantV6: "",
+ },
+ {
+ name: "v4 and v6 overlay",
+ allowedIPs: []string{"100.64.0.1/32", "fd00:1234:5678:abcd::1/128"},
+ ourV6Net: ourV6Net,
+ wantV4: "100.64.0.1",
+ wantV6: "fd00:1234:5678:abcd::1",
+ },
+ {
+ name: "v4, routed v6, overlay v6",
+ allowedIPs: []string{"100.64.0.1/32", "2001:db8::1/128", "fd00:1234:5678:abcd::1/128"},
+ ourV6Net: ourV6Net,
+ wantV4: "100.64.0.1",
+ wantV6: "fd00:1234:5678:abcd::1",
+ },
+ {
+ name: "routed v6 /128 outside our subnet is ignored",
+ allowedIPs: []string{"100.64.0.1/32", "2001:db8::1/128"},
+ ourV6Net: ourV6Net,
+ wantV4: "100.64.0.1",
+ wantV6: "",
+ },
+ {
+ name: "routed v6 prefix is ignored",
+ allowedIPs: []string{"100.64.0.1/32", "fd00:1234:5678:abcd::/64"},
+ ourV6Net: ourV6Net,
+ wantV4: "100.64.0.1",
+ wantV6: "",
+ },
+ {
+ name: "no v6 subnet configured",
+ allowedIPs: []string{"100.64.0.1/32", "fd00:1234:5678:abcd::1/128"},
+ ourV6Net: netip.Prefix{},
+ wantV4: "100.64.0.1",
+ wantV6: "",
+ },
+ {
+ name: "v4 /24 route is ignored",
+ allowedIPs: []string{"100.64.0.0/24", "100.64.0.1/32"},
+ ourV6Net: ourV6Net,
+ wantV4: "100.64.0.1",
+ wantV6: "",
+ },
+ }
+
+ for _, tt := range tests {
+ t.Run(tt.name, func(t *testing.T) {
+ v4, v6 := overlayAddrsFromAllowedIPs(tt.allowedIPs, tt.ourV6Net)
+ if tt.wantV4 == "" {
+ assert.False(t, v4.IsValid(), "expected no v4")
+ } else {
+ assert.Equal(t, tt.wantV4, v4.String(), "v4")
+ }
+ if tt.wantV6 == "" {
+ assert.False(t, v6.IsValid(), "expected no v6")
+ } else {
+ assert.Equal(t, tt.wantV6, v6.String(), "v6")
+ }
+ })
+ }
+}
diff --git a/client/internal/iface_common.go b/client/internal/iface_common.go
index 39e9bacfa..2eeac1954 100644
--- a/client/internal/iface_common.go
+++ b/client/internal/iface_common.go
@@ -26,7 +26,7 @@ type wgIfaceBase interface {
Address() wgaddr.Address
ToInterface() *net.Interface
Up() (*udpmux.UniversalUDPMuxDefault, error)
- UpdateAddr(newAddr string) error
+ UpdateAddr(newAddr wgaddr.Address) error
GetProxy() wgproxy.Proxy
GetProxyPort() uint16
UpdatePeer(peerKey string, allowedIps []netip.Prefix, keepAlive time.Duration, endpoint *net.UDPAddr, preSharedKey *wgtypes.Key) error
diff --git a/client/internal/lazyconn/activity/listener_bind.go b/client/internal/lazyconn/activity/listener_bind.go
index 792d04215..60b8baadb 100644
--- a/client/internal/lazyconn/activity/listener_bind.go
+++ b/client/internal/lazyconn/activity/listener_bind.go
@@ -57,6 +57,7 @@ func NewBindListener(wgIface WgInterface, bind device.EndpointManager, cfg lazyc
// deriveFakeIP creates a deterministic fake IP for bind mode based on peer's NetBird IP.
// Maps peer IP 100.64.x.y to fake IP 127.2.x.y (similar to relay proxy using 127.1.x.y).
// It finds the peer's actual NetBird IP by checking which allowedIP is in the same subnet as our WG interface.
+// For IPv6-only peers, the last two bytes of the v6 address are used.
func deriveFakeIP(wgIface WgInterface, allowedIPs []netip.Prefix) (netip.Addr, error) {
if len(allowedIPs) == 0 {
return netip.Addr{}, fmt.Errorf("no allowed IPs for peer")
@@ -64,6 +65,7 @@ func deriveFakeIP(wgIface WgInterface, allowedIPs []netip.Prefix) (netip.Addr, e
ourNetwork := wgIface.Address().Network
+ // Try v4 first (preferred: deterministic from overlay IP)
var peerIP netip.Addr
for _, allowedIP := range allowedIPs {
ip := allowedIP.Addr()
@@ -76,13 +78,24 @@ func deriveFakeIP(wgIface WgInterface, allowedIPs []netip.Prefix) (netip.Addr, e
}
}
- if !peerIP.IsValid() {
- return netip.Addr{}, fmt.Errorf("no peer NetBird IP found in allowed IPs")
+ if peerIP.IsValid() {
+ octets := peerIP.As4()
+ return netip.AddrFrom4([4]byte{127, 2, octets[2], octets[3]}), nil
}
- octets := peerIP.As4()
- fakeIP := netip.AddrFrom4([4]byte{127, 2, octets[2], octets[3]})
- return fakeIP, nil
+ // Fallback: use last two bytes of first v6 overlay IP
+ addr := wgIface.Address()
+ if addr.IPv6Net.IsValid() {
+ for _, allowedIP := range allowedIPs {
+ ip := allowedIP.Addr()
+ if ip.Is6() && addr.IPv6Net.Contains(ip) {
+ raw := ip.As16()
+ return netip.AddrFrom4([4]byte{127, 2, raw[14], raw[15]}), nil
+ }
+ }
+ }
+
+ return netip.Addr{}, fmt.Errorf("no peer NetBird IP found in allowed IPs")
}
func (d *BindListener) setupLazyConn() error {
diff --git a/client/internal/listener/network_change.go b/client/internal/listener/network_change.go
index 08bf5fd52..e0aa43abe 100644
--- a/client/internal/listener/network_change.go
+++ b/client/internal/listener/network_change.go
@@ -5,4 +5,5 @@ type NetworkChangeListener interface {
// OnNetworkChanged invoke when network settings has been changed
OnNetworkChanged(string)
SetInterfaceIP(string)
+ SetInterfaceIPv6(string)
}
diff --git a/client/internal/netflow/conntrack/conntrack.go b/client/internal/netflow/conntrack/conntrack.go
index 2420b1fdf..6f1da5138 100644
--- a/client/internal/netflow/conntrack/conntrack.go
+++ b/client/internal/netflow/conntrack/conntrack.go
@@ -316,7 +316,7 @@ func (c *ConnTrack) handleEvent(event nfct.Event) {
case nftypes.TCP, nftypes.UDP, nftypes.SCTP:
srcPort = flow.TupleOrig.Proto.SourcePort
dstPort = flow.TupleOrig.Proto.DestinationPort
- case nftypes.ICMP:
+ case nftypes.ICMP, nftypes.ICMPv6:
icmpType = flow.TupleOrig.Proto.ICMPType
icmpCode = flow.TupleOrig.Proto.ICMPCode
}
@@ -359,8 +359,14 @@ func (c *ConnTrack) relevantFlow(mark uint32, srcIP, dstIP netip.Addr) bool {
}
// fallback if mark rules are not in place
- wgnet := c.iface.Address().Network
- return wgnet.Contains(srcIP) || wgnet.Contains(dstIP)
+ addr := c.iface.Address()
+ if addr.Network.Contains(srcIP) || addr.Network.Contains(dstIP) {
+ return true
+ }
+ if addr.IPv6Net.IsValid() {
+ return addr.IPv6Net.Contains(srcIP) || addr.IPv6Net.Contains(dstIP)
+ }
+ return false
}
// mapRxPackets maps packet counts to RX based on flow direction
@@ -419,17 +425,16 @@ func (c *ConnTrack) inferDirection(mark uint32, srcIP, dstIP netip.Addr) nftypes
}
// fallback if marks are not set
- wgaddr := c.iface.Address().IP
- wgnetwork := c.iface.Address().Network
+ addr := c.iface.Address()
switch {
- case wgaddr == srcIP:
+ case addr.IP == srcIP || (addr.IPv6.IsValid() && addr.IPv6 == srcIP):
return nftypes.Egress
- case wgaddr == dstIP:
+ case addr.IP == dstIP || (addr.IPv6.IsValid() && addr.IPv6 == dstIP):
return nftypes.Ingress
- case wgnetwork.Contains(srcIP):
+ case addr.Network.Contains(srcIP) || (addr.IPv6Net.IsValid() && addr.IPv6Net.Contains(srcIP)):
// netbird network -> resource network
return nftypes.Ingress
- case wgnetwork.Contains(dstIP):
+ case addr.Network.Contains(dstIP) || (addr.IPv6Net.IsValid() && addr.IPv6Net.Contains(dstIP)):
// resource network -> netbird network
return nftypes.Egress
}
diff --git a/client/internal/netflow/logger/logger.go b/client/internal/netflow/logger/logger.go
index a033a2a7c..8f8e68784 100644
--- a/client/internal/netflow/logger/logger.go
+++ b/client/internal/netflow/logger/logger.go
@@ -24,15 +24,17 @@ type Logger struct {
cancel context.CancelFunc
statusRecorder *peer.Status
wgIfaceNet netip.Prefix
+ wgIfaceNetV6 netip.Prefix
dnsCollection atomic.Bool
exitNodeCollection atomic.Bool
Store types.Store
}
-func New(statusRecorder *peer.Status, wgIfaceIPNet netip.Prefix) *Logger {
+func New(statusRecorder *peer.Status, wgIfaceIPNet, wgIfaceIPNetV6 netip.Prefix) *Logger {
return &Logger{
statusRecorder: statusRecorder,
wgIfaceNet: wgIfaceIPNet,
+ wgIfaceNetV6: wgIfaceIPNetV6,
Store: store.NewMemoryStore(),
}
}
@@ -88,11 +90,11 @@ func (l *Logger) startReceiver() {
var isSrcExitNode bool
var isDestExitNode bool
- if !l.wgIfaceNet.Contains(event.SourceIP) {
+ if !l.isOverlayIP(event.SourceIP) {
event.SourceResourceID, isSrcExitNode = l.statusRecorder.CheckRoutes(event.SourceIP)
}
- if !l.wgIfaceNet.Contains(event.DestIP) {
+ if !l.isOverlayIP(event.DestIP) {
event.DestResourceID, isDestExitNode = l.statusRecorder.CheckRoutes(event.DestIP)
}
@@ -136,6 +138,10 @@ func (l *Logger) UpdateConfig(dnsCollection, exitNodeCollection bool) {
l.exitNodeCollection.Store(exitNodeCollection)
}
+func (l *Logger) isOverlayIP(ip netip.Addr) bool {
+ return l.wgIfaceNet.Contains(ip) || (l.wgIfaceNetV6.IsValid() && l.wgIfaceNetV6.Contains(ip))
+}
+
func (l *Logger) shouldStore(event *types.EventFields, isExitNode bool) bool {
// check dns collection
if !l.dnsCollection.Load() && event.Protocol == types.UDP &&
diff --git a/client/internal/netflow/logger/logger_test.go b/client/internal/netflow/logger/logger_test.go
index 1144544d8..ad2eedef2 100644
--- a/client/internal/netflow/logger/logger_test.go
+++ b/client/internal/netflow/logger/logger_test.go
@@ -12,7 +12,7 @@ import (
)
func TestStore(t *testing.T) {
- logger := logger.New(nil, netip.Prefix{})
+ logger := logger.New(nil, netip.Prefix{}, netip.Prefix{})
logger.Enable()
event := types.EventFields{
diff --git a/client/internal/netflow/manager.go b/client/internal/netflow/manager.go
index 7752c97b0..eff083dbf 100644
--- a/client/internal/netflow/manager.go
+++ b/client/internal/netflow/manager.go
@@ -35,11 +35,12 @@ type Manager struct {
// NewManager creates a new netflow manager
func NewManager(iface nftypes.IFaceMapper, publicKey []byte, statusRecorder *peer.Status) *Manager {
- var prefix netip.Prefix
+ var prefix, prefixV6 netip.Prefix
if iface != nil {
prefix = iface.Address().Network
+ prefixV6 = iface.Address().IPv6Net
}
- flowLogger := logger.New(statusRecorder, prefix)
+ flowLogger := logger.New(statusRecorder, prefix, prefixV6)
var ct nftypes.ConnTracker
if runtime.GOOS == "linux" && iface != nil && !iface.IsUserspaceBind() {
@@ -269,7 +270,7 @@ func toProtoEvent(publicKey []byte, event *nftypes.Event) *proto.FlowEvent {
},
}
- if event.Protocol == nftypes.ICMP {
+ if event.Protocol == nftypes.ICMP || event.Protocol == nftypes.ICMPv6 {
protoEvent.FlowFields.ConnectionInfo = &proto.FlowFields_IcmpInfo{
IcmpInfo: &proto.ICMPInfo{
IcmpType: uint32(event.ICMPType),
diff --git a/client/internal/netflow/types/types.go b/client/internal/netflow/types/types.go
index f76146ba3..3f7d0d0ad 100644
--- a/client/internal/netflow/types/types.go
+++ b/client/internal/netflow/types/types.go
@@ -19,6 +19,7 @@ const (
ICMP = Protocol(1)
TCP = Protocol(6)
UDP = Protocol(17)
+ ICMPv6 = Protocol(58)
SCTP = Protocol(132)
)
@@ -30,6 +31,8 @@ func (p Protocol) String() string {
return "TCP"
case 17:
return "UDP"
+ case 58:
+ return "ICMPv6"
case 132:
return "SCTP"
default:
diff --git a/client/internal/peer/status.go b/client/internal/peer/status.go
index e8e61f660..df746fa13 100644
--- a/client/internal/peer/status.go
+++ b/client/internal/peer/status.go
@@ -53,6 +53,7 @@ type RouterState struct {
type State struct {
Mux *sync.RWMutex
IP string
+ IPv6 string
PubKey string
FQDN string
ConnStatus ConnStatus
@@ -106,6 +107,7 @@ func (s *State) GetRoutes() map[string]struct{} {
// LocalPeerState contains the latest state of the local peer
type LocalPeerState struct {
IP string
+ IPv6 string
PubKey string
KernelInterface bool
FQDN string
@@ -259,7 +261,7 @@ func (d *Status) ReplaceOfflinePeers(replacement []State) {
}
// AddPeer adds peer to Daemon status map
-func (d *Status) AddPeer(peerPubKey string, fqdn string, ip string) error {
+func (d *Status) AddPeer(peerPubKey string, fqdn string, ip string, ipv6 string) error {
d.mux.Lock()
defer d.mux.Unlock()
@@ -270,6 +272,7 @@ func (d *Status) AddPeer(peerPubKey string, fqdn string, ip string) error {
d.peers[peerPubKey] = State{
PubKey: peerPubKey,
IP: ip,
+ IPv6: ipv6,
ConnStatus: StatusIdle,
FQDN: fqdn,
Mux: new(sync.RWMutex),
@@ -710,6 +713,9 @@ func (d *Status) UpdateLocalPeerState(localPeerState LocalPeerState) {
d.localPeer = localPeerState
fqdn := d.localPeer.FQDN
ip := d.localPeer.IP
+ if d.localPeer.IPv6 != "" {
+ ip = ip + "\n" + d.localPeer.IPv6
+ }
d.mux.Unlock()
d.notifier.localAddressChanged(fqdn, ip)
@@ -1316,6 +1322,7 @@ func (fs FullStatus) ToProto() *proto.FullStatus {
}
pbFullStatus.LocalPeerState.IP = fs.LocalPeerState.IP
+ pbFullStatus.LocalPeerState.Ipv6 = fs.LocalPeerState.IPv6
pbFullStatus.LocalPeerState.PubKey = fs.LocalPeerState.PubKey
pbFullStatus.LocalPeerState.KernelInterface = fs.LocalPeerState.KernelInterface
pbFullStatus.LocalPeerState.Fqdn = fs.LocalPeerState.FQDN
@@ -1331,6 +1338,7 @@ func (fs FullStatus) ToProto() *proto.FullStatus {
pbPeerState := &proto.PeerState{
IP: peerState.IP,
+ Ipv6: peerState.IPv6,
PubKey: peerState.PubKey,
ConnStatus: peerState.ConnStatus.String(),
ConnStatusUpdate: timestamppb.New(peerState.ConnStatusUpdate),
diff --git a/client/internal/peer/status_test.go b/client/internal/peer/status_test.go
index 272638750..9bafca55a 100644
--- a/client/internal/peer/status_test.go
+++ b/client/internal/peer/status_test.go
@@ -8,19 +8,20 @@ import (
"time"
"github.com/stretchr/testify/assert"
+ "github.com/stretchr/testify/require"
)
func TestAddPeer(t *testing.T) {
key := "abc"
ip := "100.108.254.1"
status := NewRecorder("https://mgm")
- err := status.AddPeer(key, "abc.netbird", ip)
+ err := status.AddPeer(key, "abc.netbird", ip, "")
assert.NoError(t, err, "shouldn't return error")
_, exists := status.peers[key]
assert.True(t, exists, "value was found")
- err = status.AddPeer(key, "abc.netbird", ip)
+ err = status.AddPeer(key, "abc.netbird", ip, "")
assert.Error(t, err, "should return error on duplicate")
}
@@ -29,7 +30,7 @@ func TestGetPeer(t *testing.T) {
key := "abc"
ip := "100.108.254.1"
status := NewRecorder("https://mgm")
- err := status.AddPeer(key, "abc.netbird", ip)
+ err := status.AddPeer(key, "abc.netbird", ip, "")
assert.NoError(t, err, "shouldn't return error")
peerStatus, err := status.GetPeer(key)
@@ -46,7 +47,7 @@ func TestUpdatePeerState(t *testing.T) {
ip := "10.10.10.10"
fqdn := "peer-a.netbird.local"
status := NewRecorder("https://mgm")
- _ = status.AddPeer(key, fqdn, ip)
+ require.NoError(t, status.AddPeer(key, fqdn, ip, ""))
peerState := State{
PubKey: key,
@@ -85,7 +86,7 @@ func TestGetPeerStateChangeNotifierLogic(t *testing.T) {
key := "abc"
ip := "10.10.10.10"
status := NewRecorder("https://mgm")
- _ = status.AddPeer(key, "abc.netbird", ip)
+ _ = status.AddPeer(key, "abc.netbird", ip, "")
sub := status.SubscribeToPeerStateChanges(context.Background(), key)
assert.NotNil(t, sub, "channel shouldn't be nil")
diff --git a/client/internal/profilemanager/config.go b/client/internal/profilemanager/config.go
index 20c615d57..cd5bc0680 100644
--- a/client/internal/profilemanager/config.go
+++ b/client/internal/profilemanager/config.go
@@ -5,6 +5,7 @@ import (
"crypto/tls"
"encoding/json"
"fmt"
+ "net"
"net/url"
"os"
"os/user"
@@ -89,6 +90,7 @@ type ConfigInput struct {
DisableFirewall *bool
BlockLANAccess *bool
BlockInbound *bool
+ DisableIPv6 *bool
DisableNotifications *bool
@@ -127,6 +129,7 @@ type Config struct {
DisableFirewall bool
BlockLANAccess bool
BlockInbound bool
+ DisableIPv6 bool
DisableNotifications *bool
@@ -542,6 +545,12 @@ func (config *Config) apply(input ConfigInput) (updated bool, err error) {
updated = true
}
+ if input.DisableIPv6 != nil && *input.DisableIPv6 != config.DisableIPv6 {
+ log.Infof("setting IPv6 overlay disabled=%v", *input.DisableIPv6)
+ config.DisableIPv6 = *input.DisableIPv6
+ updated = true
+ }
+
if input.DisableNotifications != nil && input.DisableNotifications != config.DisableNotifications {
if *input.DisableNotifications {
log.Infof("disabling notifications")
@@ -751,8 +760,7 @@ func UpdateOldManagementURL(ctx context.Context, config *Config, configPath stri
return config, nil
}
- newURL, err := parseURL("Management URL", fmt.Sprintf("%s://%s:%d",
- config.ManagementURL.Scheme, defaultManagementURL.Hostname(), 443))
+ newURL, err := parseURL("Management URL", fmt.Sprintf("%s://%s", config.ManagementURL.Scheme, net.JoinHostPort(defaultManagementURL.Hostname(), "443")))
if err != nil {
return nil, err
}
diff --git a/client/internal/relay/relay.go b/client/internal/relay/relay.go
index 59be5b0a7..f00a8d93a 100644
--- a/client/internal/relay/relay.go
+++ b/client/internal/relay/relay.go
@@ -6,6 +6,7 @@ import (
"errors"
"fmt"
"net"
+ "strconv"
"sync"
"time"
@@ -257,7 +258,7 @@ func (p *StunTurnProbe) probeTURN(ctx context.Context, uri *stun.URI) (addr stri
}
}()
- turnServerAddr := fmt.Sprintf("%s:%d", uri.Host, uri.Port)
+ turnServerAddr := net.JoinHostPort(uri.Host, strconv.Itoa(uri.Port))
var conn net.PacketConn
switch uri.Proto {
diff --git a/client/internal/rosenpass/manager.go b/client/internal/rosenpass/manager.go
index 1faa22dc5..11cda8dbc 100644
--- a/client/internal/rosenpass/manager.go
+++ b/client/internal/rosenpass/manager.go
@@ -75,7 +75,7 @@ func (m *Manager) addPeer(rosenpassPubKey []byte, rosenpassAddr string, wireGuar
if err != nil {
return fmt.Errorf("failed to parse rosenpass address: %w", err)
}
- peerAddr := fmt.Sprintf("%s:%s", wireGuardIP, strPort)
+ peerAddr := net.JoinHostPort(wireGuardIP, strPort)
if pcfg.Endpoint, err = net.ResolveUDPAddr("udp", peerAddr); err != nil {
return fmt.Errorf("failed to resolve peer endpoint address: %w", err)
}
@@ -259,6 +259,9 @@ func findRandomAvailableUDPPort() (int, error) {
}
defer conn.Close()
- splitAddress := strings.Split(conn.LocalAddr().String(), ":")
- return strconv.Atoi(splitAddress[len(splitAddress)-1])
+ _, portStr, err := net.SplitHostPort(conn.LocalAddr().String())
+ if err != nil {
+ return 0, fmt.Errorf("parse local address %s: %w", conn.LocalAddr(), err)
+ }
+ return strconv.Atoi(portStr)
}
diff --git a/client/internal/rosenpass/manager_test.go b/client/internal/rosenpass/manager_test.go
new file mode 100644
index 000000000..90bbdda59
--- /dev/null
+++ b/client/internal/rosenpass/manager_test.go
@@ -0,0 +1,14 @@
+package rosenpass
+
+import (
+ "testing"
+
+ "github.com/stretchr/testify/require"
+)
+
+func TestFindRandomAvailableUDPPort(t *testing.T) {
+ port, err := findRandomAvailableUDPPort()
+ require.NoError(t, err)
+ require.Greater(t, port, 0)
+ require.LessOrEqual(t, port, 65535)
+}
diff --git a/client/internal/routemanager/client/client.go b/client/internal/routemanager/client/client.go
index e6ef8b876..c691c54f8 100644
--- a/client/internal/routemanager/client/client.go
+++ b/client/internal/routemanager/client/client.go
@@ -3,9 +3,8 @@ package client
import (
"context"
"fmt"
- "net"
+ "net/netip"
"reflect"
- "strconv"
"time"
log "github.com/sirupsen/logrus"
@@ -566,7 +565,7 @@ func HandlerFromRoute(params common.HandlerParams) RouteHandler {
return dnsinterceptor.New(params)
case handlerTypeDynamic:
dns := nbdns.NewServiceViaMemory(params.WgInterface)
- dnsAddr := net.JoinHostPort(dns.RuntimeIP().String(), strconv.Itoa(dns.RuntimePort()))
+ dnsAddr := netip.AddrPortFrom(dns.RuntimeIP(), uint16(dns.RuntimePort()))
return dynamic.NewRoute(params, dnsAddr)
default:
return static.NewRoute(params)
diff --git a/client/internal/routemanager/client/client_bench_test.go b/client/internal/routemanager/client/client_bench_test.go
index 591042ac5..668aec427 100644
--- a/client/internal/routemanager/client/client_bench_test.go
+++ b/client/internal/routemanager/client/client_bench_test.go
@@ -46,7 +46,7 @@ func generateBenchmarkData(tier benchmarkTier) (*peer.Status, map[route.ID]*rout
fqdn := fmt.Sprintf("peer-%d.example.com", i)
ip := fmt.Sprintf("10.0.%d.%d", i/256, i%256)
- err := statusRecorder.AddPeer(peerKey, fqdn, ip)
+ err := statusRecorder.AddPeer(peerKey, fqdn, ip, "")
if err != nil {
panic(fmt.Sprintf("failed to add peer: %v", err))
}
diff --git a/client/internal/routemanager/dnsinterceptor/handler.go b/client/internal/routemanager/dnsinterceptor/handler.go
index 64f2a8789..e25cc2a5c 100644
--- a/client/internal/routemanager/dnsinterceptor/handler.go
+++ b/client/internal/routemanager/dnsinterceptor/handler.go
@@ -582,7 +582,7 @@ func (d *DnsInterceptor) queryUpstreamDNS(ctx context.Context, w dns.ResponseWri
if nsNet != nil {
reply, err = nbdns.ExchangeWithNetstack(ctx, nsNet, r, upstream)
} else {
- client, clientErr := nbdns.GetClientPrivate(d.wgInterface.Address().IP, d.wgInterface.Name(), dnsTimeout)
+ client, clientErr := nbdns.GetClientPrivate(d.wgInterface, upstreamIP, dnsTimeout)
if clientErr != nil {
d.writeDNSError(w, r, logger, fmt.Sprintf("create DNS client: %v", clientErr))
return nil
diff --git a/client/internal/routemanager/dynamic/route.go b/client/internal/routemanager/dynamic/route.go
index 8d1398a7a..f0efd7b22 100644
--- a/client/internal/routemanager/dynamic/route.go
+++ b/client/internal/routemanager/dynamic/route.go
@@ -50,10 +50,10 @@ type Route struct {
cancel context.CancelFunc
statusRecorder *peer.Status
wgInterface iface.WGIface
- resolverAddr string
+ resolverAddr netip.AddrPort
}
-func NewRoute(params common.HandlerParams, resolverAddr string) *Route {
+func NewRoute(params common.HandlerParams, resolverAddr netip.AddrPort) *Route {
return &Route{
route: params.Route,
routeRefCounter: params.RouteRefCounter,
diff --git a/client/internal/routemanager/dynamic/route_ios.go b/client/internal/routemanager/dynamic/route_ios.go
index 8fed1c8f9..1ae281d56 100644
--- a/client/internal/routemanager/dynamic/route_ios.go
+++ b/client/internal/routemanager/dynamic/route_ios.go
@@ -17,37 +17,47 @@ import (
const dialTimeout = 10 * time.Second
func (r *Route) getIPsFromResolver(domain domain.Domain) ([]net.IP, error) {
- privateClient, err := nbdns.GetClientPrivate(r.wgInterface.Address().IP, r.wgInterface.Name(), dialTimeout)
+ privateClient, err := nbdns.GetClientPrivate(r.wgInterface, r.resolverAddr.Addr(), dialTimeout)
if err != nil {
return nil, fmt.Errorf("error while creating private client: %s", err)
}
- msg := new(dns.Msg)
- msg.SetQuestion(dns.Fqdn(domain.PunycodeString()), dns.TypeA)
-
+ fqdn := dns.Fqdn(domain.PunycodeString())
startTime := time.Now()
- response, _, err := nbdns.ExchangeWithFallback(nil, privateClient, msg, r.resolverAddr)
- if err != nil {
- return nil, fmt.Errorf("DNS query for %s failed after %s: %s ", domain.SafeString(), time.Since(startTime), err)
- }
+ var ips []net.IP
+ var queryErr error
- if response.Rcode != dns.RcodeSuccess {
- return nil, fmt.Errorf("dns response code: %s", dns.RcodeToString[response.Rcode])
- }
+ for _, qtype := range []uint16{dns.TypeA, dns.TypeAAAA} {
+ msg := new(dns.Msg)
+ msg.SetQuestion(fqdn, qtype)
- ips := make([]net.IP, 0)
-
- for _, answ := range response.Answer {
- if aRecord, ok := answ.(*dns.A); ok {
- ips = append(ips, aRecord.A)
+ response, _, err := nbdns.ExchangeWithFallback(nil, privateClient, msg, r.resolverAddr.String())
+ if err != nil {
+ if queryErr == nil {
+ queryErr = fmt.Errorf("DNS query for %s (type %d) after %s: %w", domain.SafeString(), qtype, time.Since(startTime), err)
+ }
+ continue
}
- if aaaaRecord, ok := answ.(*dns.AAAA); ok {
- ips = append(ips, aaaaRecord.AAAA)
+
+ if response.Rcode != dns.RcodeSuccess {
+ continue
+ }
+
+ for _, answ := range response.Answer {
+ if aRecord, ok := answ.(*dns.A); ok {
+ ips = append(ips, aRecord.A)
+ }
+ if aaaaRecord, ok := answ.(*dns.AAAA); ok {
+ ips = append(ips, aaaaRecord.AAAA)
+ }
}
}
if len(ips) == 0 {
+ if queryErr != nil {
+ return nil, queryErr
+ }
return nil, fmt.Errorf("no A or AAAA records found for %s", domain.SafeString())
}
diff --git a/client/internal/routemanager/fakeip/fakeip.go b/client/internal/routemanager/fakeip/fakeip.go
index 1592045d2..5be4ca12e 100644
--- a/client/internal/routemanager/fakeip/fakeip.go
+++ b/client/internal/routemanager/fakeip/fakeip.go
@@ -1,93 +1,145 @@
package fakeip
import (
+ "errors"
"fmt"
"net/netip"
"sync"
)
-// Manager manages allocation of fake IPs from the 240.0.0.0/8 block
-type Manager struct {
- mu sync.Mutex
- nextIP netip.Addr // Next IP to allocate
+var (
+ // 240.0.0.1 - 240.255.255.254, block 240.0.0.0/8 (reserved, RFC 1112)
+ v4Base = netip.AddrFrom4([4]byte{240, 0, 0, 1})
+ v4Max = netip.AddrFrom4([4]byte{240, 255, 255, 254})
+ v4Block = netip.PrefixFrom(netip.AddrFrom4([4]byte{240, 0, 0, 0}), 8)
+
+ // 0100::1 - 0100::ffff:ffff:ffff:fffe, block 0100::/64 (discard, RFC 6666)
+ v6Base = netip.AddrFrom16([16]byte{0x01, 0x00, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0x01})
+ v6Max = netip.AddrFrom16([16]byte{0x01, 0x00, 0, 0, 0, 0, 0, 0, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xfe})
+ v6Block = netip.PrefixFrom(netip.AddrFrom16([16]byte{0x01, 0x00}), 64)
+)
+
+// fakeIPPool holds the allocation state for a single address family.
+type fakeIPPool struct {
+ nextIP netip.Addr
+ baseIP netip.Addr
+ maxIP netip.Addr
+ block netip.Prefix
allocated map[netip.Addr]netip.Addr // real IP -> fake IP
fakeToReal map[netip.Addr]netip.Addr // fake IP -> real IP
- baseIP netip.Addr // First usable IP: 240.0.0.1
- maxIP netip.Addr // Last usable IP: 240.255.255.254
}
-// NewManager creates a new fake IP manager using 240.0.0.0/8 block
-func NewManager() *Manager {
- baseIP := netip.AddrFrom4([4]byte{240, 0, 0, 1})
- maxIP := netip.AddrFrom4([4]byte{240, 255, 255, 254})
-
- return &Manager{
- nextIP: baseIP,
+func newPool(base, maxAddr netip.Addr, block netip.Prefix) *fakeIPPool {
+ return &fakeIPPool{
+ nextIP: base,
+ baseIP: base,
+ maxIP: maxAddr,
+ block: block,
allocated: make(map[netip.Addr]netip.Addr),
fakeToReal: make(map[netip.Addr]netip.Addr),
- baseIP: baseIP,
- maxIP: maxIP,
}
}
-// AllocateFakeIP allocates a fake IP for the given real IP
-// Returns the fake IP, or existing fake IP if already allocated
-func (m *Manager) AllocateFakeIP(realIP netip.Addr) (netip.Addr, error) {
- if !realIP.Is4() {
- return netip.Addr{}, fmt.Errorf("only IPv4 addresses supported")
- }
-
- m.mu.Lock()
- defer m.mu.Unlock()
-
- if fakeIP, exists := m.allocated[realIP]; exists {
+// allocate allocates a fake IP for the given real IP.
+// Returns the existing fake IP if already allocated.
+func (p *fakeIPPool) allocate(realIP netip.Addr) (netip.Addr, error) {
+ if fakeIP, exists := p.allocated[realIP]; exists {
return fakeIP, nil
}
- startIP := m.nextIP
+ startIP := p.nextIP
for {
- currentIP := m.nextIP
+ currentIP := p.nextIP
// Advance to next IP, wrapping at boundary
- if m.nextIP.Compare(m.maxIP) >= 0 {
- m.nextIP = m.baseIP
+ if p.nextIP.Compare(p.maxIP) >= 0 {
+ p.nextIP = p.baseIP
} else {
- m.nextIP = m.nextIP.Next()
+ p.nextIP = p.nextIP.Next()
}
- // Check if current IP is available
- if _, inUse := m.fakeToReal[currentIP]; !inUse {
- m.allocated[realIP] = currentIP
- m.fakeToReal[currentIP] = realIP
+ if _, inUse := p.fakeToReal[currentIP]; !inUse {
+ p.allocated[realIP] = currentIP
+ p.fakeToReal[currentIP] = realIP
return currentIP, nil
}
- // Prevent infinite loop if all IPs exhausted
- if m.nextIP.Compare(startIP) == 0 {
- return netip.Addr{}, fmt.Errorf("no more fake IPs available in 240.0.0.0/8 block")
+ if p.nextIP.Compare(startIP) == 0 {
+ return netip.Addr{}, fmt.Errorf("no more fake IPs available in %s block", p.block)
}
}
}
-// GetFakeIP returns the fake IP for a real IP if it exists
+// Manager manages allocation of fake IPs for dynamic DNS routes.
+// IPv4 uses 240.0.0.0/8 (reserved), IPv6 uses 0100::/64 (discard, RFC 6666).
+type Manager struct {
+ mu sync.Mutex
+ v4 *fakeIPPool
+ v6 *fakeIPPool
+}
+
+// NewManager creates a new fake IP manager.
+func NewManager() *Manager {
+ return &Manager{
+ v4: newPool(v4Base, v4Max, v4Block),
+ v6: newPool(v6Base, v6Max, v6Block),
+ }
+}
+
+func (m *Manager) pool(ip netip.Addr) *fakeIPPool {
+ if ip.Is6() {
+ return m.v6
+ }
+ return m.v4
+}
+
+// AllocateFakeIP allocates a fake IP for the given real IP.
+func (m *Manager) AllocateFakeIP(realIP netip.Addr) (netip.Addr, error) {
+ realIP = realIP.Unmap()
+ if !realIP.IsValid() {
+ return netip.Addr{}, errors.New("invalid IP address")
+ }
+
+ m.mu.Lock()
+ defer m.mu.Unlock()
+
+ return m.pool(realIP).allocate(realIP)
+}
+
+// GetFakeIP returns the fake IP for a real IP if it exists.
func (m *Manager) GetFakeIP(realIP netip.Addr) (netip.Addr, bool) {
+ realIP = realIP.Unmap()
+ if !realIP.IsValid() {
+ return netip.Addr{}, false
+ }
+
m.mu.Lock()
defer m.mu.Unlock()
- fakeIP, exists := m.allocated[realIP]
- return fakeIP, exists
+ fakeIP, ok := m.pool(realIP).allocated[realIP]
+ return fakeIP, ok
}
-// GetRealIP returns the real IP for a fake IP if it exists, otherwise false
+// GetRealIP returns the real IP for a fake IP if it exists.
func (m *Manager) GetRealIP(fakeIP netip.Addr) (netip.Addr, bool) {
+ fakeIP = fakeIP.Unmap()
+ if !fakeIP.IsValid() {
+ return netip.Addr{}, false
+ }
+
m.mu.Lock()
defer m.mu.Unlock()
- realIP, exists := m.fakeToReal[fakeIP]
- return realIP, exists
+ realIP, ok := m.pool(fakeIP).fakeToReal[fakeIP]
+ return realIP, ok
}
-// GetFakeIPBlock returns the fake IP block used by this manager
+// GetFakeIPBlock returns the v4 fake IP block used by this manager.
func (m *Manager) GetFakeIPBlock() netip.Prefix {
- return netip.MustParsePrefix("240.0.0.0/8")
+ return m.v4.block
+}
+
+// GetFakeIPv6Block returns the v6 fake IP block used by this manager.
+func (m *Manager) GetFakeIPv6Block() netip.Prefix {
+ return m.v6.block
}
diff --git a/client/internal/routemanager/fakeip/fakeip_test.go b/client/internal/routemanager/fakeip/fakeip_test.go
index ad3e4bd4e..f554f970d 100644
--- a/client/internal/routemanager/fakeip/fakeip_test.go
+++ b/client/internal/routemanager/fakeip/fakeip_test.go
@@ -9,16 +9,16 @@ import (
func TestNewManager(t *testing.T) {
manager := NewManager()
- if manager.baseIP.String() != "240.0.0.1" {
- t.Errorf("Expected base IP 240.0.0.1, got %s", manager.baseIP.String())
+ if manager.v4.baseIP.String() != "240.0.0.1" {
+ t.Errorf("Expected v4 base IP 240.0.0.1, got %s", manager.v4.baseIP.String())
}
- if manager.maxIP.String() != "240.255.255.254" {
- t.Errorf("Expected max IP 240.255.255.254, got %s", manager.maxIP.String())
+ if manager.v4.maxIP.String() != "240.255.255.254" {
+ t.Errorf("Expected v4 max IP 240.255.255.254, got %s", manager.v4.maxIP.String())
}
- if manager.nextIP.Compare(manager.baseIP) != 0 {
- t.Errorf("Expected nextIP to start at baseIP")
+ if manager.v6.baseIP.String() != "100::1" {
+ t.Errorf("Expected v6 base IP 100::1, got %s", manager.v6.baseIP.String())
}
}
@@ -35,7 +35,6 @@ func TestAllocateFakeIP(t *testing.T) {
t.Error("Fake IP should be IPv4")
}
- // Check it's in the correct range
if fakeIP.As4()[0] != 240 {
t.Errorf("Fake IP should be in 240.0.0.0/8 range, got %s", fakeIP.String())
}
@@ -51,13 +50,31 @@ func TestAllocateFakeIP(t *testing.T) {
}
}
-func TestAllocateFakeIPIPv6Rejection(t *testing.T) {
+func TestAllocateFakeIPv6(t *testing.T) {
manager := NewManager()
- realIPv6 := netip.MustParseAddr("2001:db8::1")
+ realIP := netip.MustParseAddr("2001:db8::1")
- _, err := manager.AllocateFakeIP(realIPv6)
- if err == nil {
- t.Error("Expected error for IPv6 address")
+ fakeIP, err := manager.AllocateFakeIP(realIP)
+ if err != nil {
+ t.Fatalf("Failed to allocate fake IPv6: %v", err)
+ }
+
+ if !fakeIP.Is6() {
+ t.Error("Fake IP should be IPv6")
+ }
+
+ if !netip.MustParsePrefix("100::/64").Contains(fakeIP) {
+ t.Errorf("Fake IP should be in 100::/64 range, got %s", fakeIP.String())
+ }
+
+ // Should return same fake IP for same real IP
+ fakeIP2, err := manager.AllocateFakeIP(realIP)
+ if err != nil {
+ t.Fatalf("Failed to get existing fake IPv6: %v", err)
+ }
+
+ if fakeIP.Compare(fakeIP2) != 0 {
+ t.Errorf("Expected same fake IP, got %s and %s", fakeIP.String(), fakeIP2.String())
}
}
@@ -65,13 +82,11 @@ func TestGetFakeIP(t *testing.T) {
manager := NewManager()
realIP := netip.MustParseAddr("1.1.1.1")
- // Should not exist initially
_, exists := manager.GetFakeIP(realIP)
if exists {
t.Error("Fake IP should not exist before allocation")
}
- // Allocate and check
expectedFakeIP, err := manager.AllocateFakeIP(realIP)
if err != nil {
t.Fatalf("Failed to allocate: %v", err)
@@ -87,12 +102,30 @@ func TestGetFakeIP(t *testing.T) {
}
}
+func TestGetRealIPv6(t *testing.T) {
+ manager := NewManager()
+ realIP := netip.MustParseAddr("2001:db8::1")
+
+ fakeIP, err := manager.AllocateFakeIP(realIP)
+ if err != nil {
+ t.Fatalf("Failed to allocate: %v", err)
+ }
+
+ gotReal, exists := manager.GetRealIP(fakeIP)
+ if !exists {
+ t.Error("Real IP should exist for allocated fake IP")
+ }
+
+ if gotReal.Compare(realIP) != 0 {
+ t.Errorf("Expected real IP %s, got %s", realIP, gotReal)
+ }
+}
+
func TestMultipleAllocations(t *testing.T) {
manager := NewManager()
allocations := make(map[netip.Addr]netip.Addr)
- // Allocate multiple IPs
for i := 1; i <= 100; i++ {
realIP := netip.AddrFrom4([4]byte{10, 0, byte(i / 256), byte(i % 256)})
fakeIP, err := manager.AllocateFakeIP(realIP)
@@ -100,7 +133,6 @@ func TestMultipleAllocations(t *testing.T) {
t.Fatalf("Failed to allocate fake IP for %s: %v", realIP.String(), err)
}
- // Check for duplicates
for _, existingFake := range allocations {
if fakeIP.Compare(existingFake) == 0 {
t.Errorf("Duplicate fake IP allocated: %s", fakeIP.String())
@@ -110,7 +142,6 @@ func TestMultipleAllocations(t *testing.T) {
allocations[realIP] = fakeIP
}
- // Verify all allocations can be retrieved
for realIP, expectedFake := range allocations {
actualFake, exists := manager.GetFakeIP(realIP)
if !exists {
@@ -124,11 +155,13 @@ func TestMultipleAllocations(t *testing.T) {
func TestGetFakeIPBlock(t *testing.T) {
manager := NewManager()
- block := manager.GetFakeIPBlock()
- expected := "240.0.0.0/8"
- if block.String() != expected {
- t.Errorf("Expected %s, got %s", expected, block.String())
+ if block := manager.GetFakeIPBlock(); block.String() != "240.0.0.0/8" {
+ t.Errorf("Expected 240.0.0.0/8, got %s", block.String())
+ }
+
+ if block := manager.GetFakeIPv6Block(); block.String() != "100::/64" {
+ t.Errorf("Expected 100::/64, got %s", block.String())
}
}
@@ -141,7 +174,6 @@ func TestConcurrentAccess(t *testing.T) {
var wg sync.WaitGroup
results := make(chan netip.Addr, numGoroutines*allocationsPerGoroutine)
- // Concurrent allocations
for i := 0; i < numGoroutines; i++ {
wg.Add(1)
go func(goroutineID int) {
@@ -161,7 +193,6 @@ func TestConcurrentAccess(t *testing.T) {
wg.Wait()
close(results)
- // Check for duplicates
seen := make(map[netip.Addr]bool)
count := 0
for fakeIP := range results {
@@ -178,47 +209,61 @@ func TestConcurrentAccess(t *testing.T) {
}
func TestIPExhaustion(t *testing.T) {
- // Create a manager with limited range for testing
manager := &Manager{
- nextIP: netip.AddrFrom4([4]byte{240, 0, 0, 1}),
- allocated: make(map[netip.Addr]netip.Addr),
- fakeToReal: make(map[netip.Addr]netip.Addr),
- baseIP: netip.AddrFrom4([4]byte{240, 0, 0, 1}),
- maxIP: netip.AddrFrom4([4]byte{240, 0, 0, 3}), // Only 3 IPs available
+ v4: newPool(
+ netip.AddrFrom4([4]byte{240, 0, 0, 1}),
+ netip.AddrFrom4([4]byte{240, 0, 0, 3}),
+ netip.MustParsePrefix("240.0.0.0/8"),
+ ),
+ v6: newPool(
+ netip.MustParseAddr("100::1"),
+ netip.MustParseAddr("100::3"),
+ netip.MustParsePrefix("100::/64"),
+ ),
}
- // Allocate all available IPs
- realIPs := []netip.Addr{
- netip.MustParseAddr("1.0.0.1"),
- netip.MustParseAddr("1.0.0.2"),
- netip.MustParseAddr("1.0.0.3"),
- }
-
- for _, realIP := range realIPs {
- _, err := manager.AllocateFakeIP(realIP)
+ for _, realIP := range []string{"1.0.0.1", "1.0.0.2", "1.0.0.3"} {
+ _, err := manager.AllocateFakeIP(netip.MustParseAddr(realIP))
if err != nil {
t.Fatalf("Failed to allocate fake IP: %v", err)
}
}
- // Try to allocate one more - should fail
_, err := manager.AllocateFakeIP(netip.MustParseAddr("1.0.0.4"))
if err == nil {
- t.Error("Expected exhaustion error")
+ t.Error("Expected v4 exhaustion error")
+ }
+
+ // Same for v6
+ for _, realIP := range []string{"2001:db8::1", "2001:db8::2", "2001:db8::3"} {
+ _, err := manager.AllocateFakeIP(netip.MustParseAddr(realIP))
+ if err != nil {
+ t.Fatalf("Failed to allocate fake IPv6: %v", err)
+ }
+ }
+
+ _, err = manager.AllocateFakeIP(netip.MustParseAddr("2001:db8::4"))
+ if err == nil {
+ t.Error("Expected v6 exhaustion error")
}
}
func TestWrapAround(t *testing.T) {
- // Create manager starting near the end of range
manager := &Manager{
- nextIP: netip.AddrFrom4([4]byte{240, 0, 0, 254}),
- allocated: make(map[netip.Addr]netip.Addr),
- fakeToReal: make(map[netip.Addr]netip.Addr),
- baseIP: netip.AddrFrom4([4]byte{240, 0, 0, 1}),
- maxIP: netip.AddrFrom4([4]byte{240, 0, 0, 254}),
+ v4: newPool(
+ netip.AddrFrom4([4]byte{240, 0, 0, 1}),
+ netip.AddrFrom4([4]byte{240, 0, 0, 254}),
+ netip.MustParsePrefix("240.0.0.0/8"),
+ ),
+ v6: newPool(
+ netip.MustParseAddr("100::1"),
+ netip.MustParseAddr("100::ffff:ffff:ffff:fffe"),
+ netip.MustParsePrefix("100::/64"),
+ ),
}
+ // Start near the end
+ manager.v4.nextIP = netip.AddrFrom4([4]byte{240, 0, 0, 254})
- // Allocate the last IP
fakeIP1, err := manager.AllocateFakeIP(netip.MustParseAddr("1.0.0.1"))
if err != nil {
t.Fatalf("Failed to allocate first IP: %v", err)
@@ -228,7 +273,6 @@ func TestWrapAround(t *testing.T) {
t.Errorf("Expected 240.0.0.254, got %s", fakeIP1.String())
}
- // Next allocation should wrap around to the beginning
fakeIP2, err := manager.AllocateFakeIP(netip.MustParseAddr("1.0.0.2"))
if err != nil {
t.Fatalf("Failed to allocate second IP: %v", err)
@@ -238,3 +282,32 @@ func TestWrapAround(t *testing.T) {
t.Errorf("Expected 240.0.0.1 after wrap, got %s", fakeIP2.String())
}
}
+
+func TestMixedV4V6(t *testing.T) {
+ manager := NewManager()
+
+ v4Fake, err := manager.AllocateFakeIP(netip.MustParseAddr("8.8.8.8"))
+ if err != nil {
+ t.Fatalf("Failed to allocate v4: %v", err)
+ }
+
+ v6Fake, err := manager.AllocateFakeIP(netip.MustParseAddr("2001:db8::1"))
+ if err != nil {
+ t.Fatalf("Failed to allocate v6: %v", err)
+ }
+
+ if !v4Fake.Is4() || !v6Fake.Is6() {
+ t.Errorf("Wrong families: v4=%s v6=%s", v4Fake, v6Fake)
+ }
+
+ // Reverse lookups should work for both
+ gotV4, ok := manager.GetRealIP(v4Fake)
+ if !ok || gotV4.String() != "8.8.8.8" {
+ t.Errorf("v4 reverse lookup failed: got %s, ok=%v", gotV4, ok)
+ }
+
+ gotV6, ok := manager.GetRealIP(v6Fake)
+ if !ok || gotV6.String() != "2001:db8::1" {
+ t.Errorf("v6 reverse lookup failed: got %s, ok=%v", gotV6, ok)
+ }
+}
diff --git a/client/internal/routemanager/ipfwdstate/ipfwdstate.go b/client/internal/routemanager/ipfwdstate/ipfwdstate.go
index da81c18f9..2be1c2ae7 100644
--- a/client/internal/routemanager/ipfwdstate/ipfwdstate.go
+++ b/client/internal/routemanager/ipfwdstate/ipfwdstate.go
@@ -9,7 +9,11 @@ import (
)
// IPForwardingState is a struct that keeps track of the IP forwarding state.
-// todo: read initial state of the IP forwarding from the system and reset the state based on it
+// todo: read initial state of the IP forwarding from the system and reset the state based on it.
+// todo: separate v4/v6 forwarding state, since the sysctls are independent
+// (net.ipv4.ip_forward vs net.ipv6.conf.all.forwarding). Currently the nftables
+// manager shares one instance between both routers, which works only because
+// EnableIPForwarding enables both sysctls in a single call.
type IPForwardingState struct {
enabledCounter int
}
diff --git a/client/internal/routemanager/manager.go b/client/internal/routemanager/manager.go
index 3923e153b..839ec14c0 100644
--- a/client/internal/routemanager/manager.go
+++ b/client/internal/routemanager/manager.go
@@ -53,6 +53,7 @@ type Manager interface {
GetRouteSelector() *routeselector.RouteSelector
GetClientRoutes() route.HAMap
GetSelectedClientRoutes() route.HAMap
+ GetActiveClientRoutes() route.HAMap
GetClientRoutesWithNetID() map[route.NetID][]*route.Route
SetRouteChangeListener(listener listener.NetworkChangeListener)
InitialRouteRange() []string
@@ -159,16 +160,24 @@ func (m *DefaultManager) setupAndroidRoutes(config ManagerConfig) {
if config.DNSFeatureFlag {
m.fakeIPManager = fakeip.NewManager()
- id := uuid.NewString()
+ v4ID := uuid.NewString()
fakeIPRoute := &route.Route{
- ID: route.ID(id),
+ ID: route.ID(v4ID),
Network: m.fakeIPManager.GetFakeIPBlock(),
- NetID: route.NetID(id),
+ NetID: route.NetID(v4ID),
Peer: m.pubKey,
NetworkType: route.IPv4Network,
}
- cr = append(cr, fakeIPRoute)
- m.notifier.SetFakeIPRoute(fakeIPRoute)
+ v6ID := uuid.NewString()
+ fakeIPv6Route := &route.Route{
+ ID: route.ID(v6ID),
+ Network: m.fakeIPManager.GetFakeIPv6Block(),
+ NetID: route.NetID(v6ID),
+ Peer: m.pubKey,
+ NetworkType: route.IPv6Network,
+ }
+ cr = append(cr, fakeIPRoute, fakeIPv6Route)
+ m.notifier.SetFakeIPRoutes([]*route.Route{fakeIPRoute, fakeIPv6Route})
}
m.notifier.SetInitialClientRoutes(cr, routesForComparison)
@@ -477,6 +486,39 @@ func (m *DefaultManager) GetSelectedClientRoutes() route.HAMap {
return m.routeSelector.FilterSelectedExitNodes(maps.Clone(m.clientRoutes))
}
+// GetActiveClientRoutes returns the subset of selected client routes
+// that are currently reachable: the route's peer is Connected and is
+// the one actively carrying the route (not just an HA sibling).
+func (m *DefaultManager) GetActiveClientRoutes() route.HAMap {
+ m.mux.Lock()
+ selected := m.routeSelector.FilterSelectedExitNodes(maps.Clone(m.clientRoutes))
+ recorder := m.statusRecorder
+ m.mux.Unlock()
+
+ if recorder == nil {
+ return selected
+ }
+
+ out := make(route.HAMap, len(selected))
+ for id, routes := range selected {
+ for _, r := range routes {
+ st, err := recorder.GetPeer(r.Peer)
+ if err != nil {
+ continue
+ }
+ if st.ConnStatus != peer.StatusConnected {
+ continue
+ }
+ if _, hasRoute := st.GetRoutes()[r.Network.String()]; !hasRoute {
+ continue
+ }
+ out[id] = routes
+ break
+ }
+ }
+ return out
+}
+
// GetClientRoutesWithNetID returns the current routes from the route map, but the keys consist of the network ID only
func (m *DefaultManager) GetClientRoutesWithNetID() map[route.NetID][]*route.Route {
m.mux.Lock()
@@ -696,7 +738,10 @@ func (m *DefaultManager) collectExitNodeInfo(clientRoutes route.HAMap) exitNodeI
}
func (m *DefaultManager) isExitNodeRoute(routes []*route.Route) bool {
- return len(routes) > 0 && routes[0].Network.String() == vars.ExitNodeCIDR
+ if len(routes) == 0 {
+ return false
+ }
+ return route.IsV4DefaultRoute(routes[0].Network) || route.IsV6DefaultRoute(routes[0].Network)
}
func (m *DefaultManager) categorizeUserSelection(netID route.NetID, info *exitNodeInfo) {
diff --git a/client/internal/routemanager/manager_test.go b/client/internal/routemanager/manager_test.go
index 3697545ae..926f06bc9 100644
--- a/client/internal/routemanager/manager_test.go
+++ b/client/internal/routemanager/manager_test.go
@@ -12,6 +12,7 @@ import (
"github.com/stretchr/testify/require"
"github.com/netbirdio/netbird/client/iface"
+ "github.com/netbirdio/netbird/client/iface/wgaddr"
"github.com/netbirdio/netbird/client/internal/peer"
"github.com/netbirdio/netbird/route"
)
@@ -409,7 +410,7 @@ func TestManagerUpdateRoutes(t *testing.T) {
}
opts := iface.WGIFaceOpts{
IFaceName: fmt.Sprintf("utun43%d", n),
- Address: "100.65.65.2/24",
+ Address: wgaddr.MustParseWGAddress("100.65.65.2/24"),
WGPort: 33100,
WGPrivKey: peerPrivateKey.String(),
MTU: iface.DefaultMTU,
diff --git a/client/internal/routemanager/mock.go b/client/internal/routemanager/mock.go
index 66b5e30dd..937314995 100644
--- a/client/internal/routemanager/mock.go
+++ b/client/internal/routemanager/mock.go
@@ -19,6 +19,7 @@ type MockManager struct {
GetRouteSelectorFunc func() *routeselector.RouteSelector
GetClientRoutesFunc func() route.HAMap
GetSelectedClientRoutesFunc func() route.HAMap
+ GetActiveClientRoutesFunc func() route.HAMap
GetClientRoutesWithNetIDFunc func() map[route.NetID][]*route.Route
StopFunc func(manager *statemanager.Manager)
}
@@ -78,6 +79,14 @@ func (m *MockManager) GetSelectedClientRoutes() route.HAMap {
return nil
}
+// GetActiveClientRoutes mock implementation of GetActiveClientRoutes from the Manager interface
+func (m *MockManager) GetActiveClientRoutes() route.HAMap {
+ if m.GetActiveClientRoutesFunc != nil {
+ return m.GetActiveClientRoutesFunc()
+ }
+ return nil
+}
+
// GetClientRoutesWithNetID mock implementation of GetClientRoutesWithNetID from Manager interface
func (m *MockManager) GetClientRoutesWithNetID() map[route.NetID][]*route.Route {
if m.GetClientRoutesWithNetIDFunc != nil {
diff --git a/client/internal/routemanager/notifier/notifier_android.go b/client/internal/routemanager/notifier/notifier_android.go
index 55e0b7421..140a583f7 100644
--- a/client/internal/routemanager/notifier/notifier_android.go
+++ b/client/internal/routemanager/notifier/notifier_android.go
@@ -16,7 +16,7 @@ import (
type Notifier struct {
initialRoutes []*route.Route
currentRoutes []*route.Route
- fakeIPRoute *route.Route
+ fakeIPRoutes []*route.Route
listener listener.NetworkChangeListener
listenerMux sync.Mutex
@@ -38,9 +38,9 @@ func (n *Notifier) SetInitialClientRoutes(initialRoutes []*route.Route, routesFo
n.currentRoutes = filterStatic(routesForComparison)
}
-// SetFakeIPRoute stores the fake IP route to be included in every TUN rebuild.
-func (n *Notifier) SetFakeIPRoute(r *route.Route) {
- n.fakeIPRoute = r
+// SetFakeIPRoutes stores the fake IP routes to be included in every TUN rebuild.
+func (n *Notifier) SetFakeIPRoutes(routes []*route.Route) {
+ n.fakeIPRoutes = routes
}
func (n *Notifier) OnNewRoutes(idMap route.HAMap) {
@@ -74,14 +74,12 @@ func (n *Notifier) notify() {
}
allRoutes := slices.Clone(n.currentRoutes)
- if n.fakeIPRoute != nil {
- allRoutes = append(allRoutes, n.fakeIPRoute)
- }
+ allRoutes = append(allRoutes, n.fakeIPRoutes...)
routeStrings := n.routesToStrings(allRoutes)
sort.Strings(routeStrings)
go func(l listener.NetworkChangeListener) {
- l.OnNetworkChanged(strings.Join(n.addIPv6RangeIfNeeded(routeStrings, allRoutes), ","))
+ l.OnNetworkChanged(strings.Join(routeStrings, ","))
}(n.listener)
}
@@ -119,14 +117,5 @@ func (n *Notifier) hasRouteDiff(a []*route.Route, b []*route.Route) bool {
func (n *Notifier) GetInitialRouteRanges() []string {
initialStrings := n.routesToStrings(n.initialRoutes)
sort.Strings(initialStrings)
- return n.addIPv6RangeIfNeeded(initialStrings, n.initialRoutes)
-}
-
-func (n *Notifier) addIPv6RangeIfNeeded(inputRanges []string, routes []*route.Route) []string {
- for _, r := range routes {
- if r.Network.Addr().Is4() && r.Network.Bits() == 0 {
- return append(slices.Clone(inputRanges), "::/0")
- }
- }
- return inputRanges
+ return initialStrings
}
diff --git a/client/internal/routemanager/notifier/notifier_ios.go b/client/internal/routemanager/notifier/notifier_ios.go
index 68c85067a..27a2a722d 100644
--- a/client/internal/routemanager/notifier/notifier_ios.go
+++ b/client/internal/routemanager/notifier/notifier_ios.go
@@ -34,7 +34,7 @@ func (n *Notifier) SetInitialClientRoutes([]*route.Route, []*route.Route) {
// iOS doesn't care about initial routes
}
-func (n *Notifier) SetFakeIPRoute(*route.Route) {
+func (n *Notifier) SetFakeIPRoutes([]*route.Route) {
// Not used on iOS
}
@@ -65,19 +65,10 @@ func (n *Notifier) notify() {
}
go func(l listener.NetworkChangeListener) {
- l.OnNetworkChanged(strings.Join(n.addIPv6RangeIfNeeded(n.currentPrefixes), ","))
+ l.OnNetworkChanged(strings.Join(n.currentPrefixes, ","))
}(n.listener)
}
func (n *Notifier) GetInitialRouteRanges() []string {
return nil
}
-
-func (n *Notifier) addIPv6RangeIfNeeded(inputRanges []string) []string {
- for _, r := range inputRanges {
- if r == "0.0.0.0/0" {
- return append(slices.Clone(inputRanges), "::/0")
- }
- }
- return inputRanges
-}
diff --git a/client/internal/routemanager/notifier/notifier_other.go b/client/internal/routemanager/notifier/notifier_other.go
index 97c815cf0..f57cadb0b 100644
--- a/client/internal/routemanager/notifier/notifier_other.go
+++ b/client/internal/routemanager/notifier/notifier_other.go
@@ -23,7 +23,7 @@ func (n *Notifier) SetInitialClientRoutes([]*route.Route, []*route.Route) {
// Not used on non-mobile platforms
}
-func (n *Notifier) SetFakeIPRoute(*route.Route) {
+func (n *Notifier) SetFakeIPRoutes([]*route.Route) {
// Not used on non-mobile platforms
}
diff --git a/client/internal/routemanager/server/server.go b/client/internal/routemanager/server/server.go
index e674c80cd..f569c0cac 100644
--- a/client/internal/routemanager/server/server.go
+++ b/client/internal/routemanager/server/server.go
@@ -21,6 +21,7 @@ type Router struct {
firewall firewall.Manager
wgInterface iface.WGIface
statusRecorder *peer.Status
+ useNewDNSRoute bool
}
func NewRouter(ctx context.Context, wgInterface iface.WGIface, firewall firewall.Manager, statusRecorder *peer.Status) (*Router, error) {
@@ -37,6 +38,8 @@ func (r *Router) UpdateRoutes(routesMap map[route.ID]*route.Route, useNewDNSRout
r.mux.Lock()
defer r.mux.Unlock()
+ prevUseNewDNSRoute := r.useNewDNSRoute
+
serverRoutesToRemove := make([]route.ID, 0)
for routeID := range r.routes {
@@ -48,7 +51,7 @@ func (r *Router) UpdateRoutes(routesMap map[route.ID]*route.Route, useNewDNSRout
for _, routeID := range serverRoutesToRemove {
oldRoute := r.routes[routeID]
- err := r.removeFromServerNetwork(oldRoute)
+ err := r.removeFromServerNetwork(oldRoute, prevUseNewDNSRoute)
if err != nil {
log.Errorf("Unable to remove route id: %s, network %s, from server, got: %v",
oldRoute.ID, oldRoute.Network, err)
@@ -56,6 +59,8 @@ func (r *Router) UpdateRoutes(routesMap map[route.ID]*route.Route, useNewDNSRout
delete(r.routes, routeID)
}
+ r.useNewDNSRoute = useNewDNSRoute
+
// If routing is to be disabled, do it after routes have been removed
// If routing is to be enabled, do it before adding new routes; addToServerNetwork needs routing to be enabled
if len(routesMap) > 0 {
@@ -85,13 +90,13 @@ func (r *Router) UpdateRoutes(routesMap map[route.ID]*route.Route, useNewDNSRout
return nil
}
-func (r *Router) removeFromServerNetwork(route *route.Route) error {
+func (r *Router) removeFromServerNetwork(route *route.Route, useNewDNSRoute bool) error {
if r.ctx.Err() != nil {
log.Infof("Not removing from server network because context is done")
return r.ctx.Err()
}
- routerPair := routeToRouterPair(route, false)
+ routerPair := routeToRouterPair(route, useNewDNSRoute)
if err := r.firewall.RemoveNatRule(routerPair); err != nil {
return fmt.Errorf("remove routing rules: %w", err)
}
@@ -124,7 +129,7 @@ func (r *Router) CleanUp() {
defer r.mux.Unlock()
for _, route := range r.routes {
- routerPair := routeToRouterPair(route, false)
+ routerPair := routeToRouterPair(route, r.useNewDNSRoute)
if err := r.firewall.RemoveNatRule(routerPair); err != nil {
log.Errorf("Failed to remove cleanup route: %v", err)
}
@@ -146,8 +151,7 @@ func routeToRouterPair(route *route.Route, useNewDNSRoute bool) firewall.RouterP
if useNewDNSRoute {
destination.Set = firewall.NewDomainSet(route.Domains)
} else {
- // TODO: add ipv6 additionally
- destination = getDefaultPrefix(destination.Prefix)
+ destination = getDefaultPrefix(route.Network)
}
} else {
destination.Prefix = route.Network.Masked()
@@ -158,6 +162,7 @@ func routeToRouterPair(route *route.Route, useNewDNSRoute bool) firewall.RouterP
Source: source,
Destination: destination,
Masquerade: route.Masquerade,
+ Dynamic: route.IsDynamic(),
}
}
diff --git a/client/internal/routemanager/systemops/systemops.go b/client/internal/routemanager/systemops/systemops.go
index c0ca21d22..165448b60 100644
--- a/client/internal/routemanager/systemops/systemops.go
+++ b/client/internal/routemanager/systemops/systemops.go
@@ -107,8 +107,16 @@ func (r *SysOps) validateRoute(prefix netip.Prefix) error {
addr.IsInterfaceLocalMulticast(),
addr.IsMulticast(),
addr.IsUnspecified() && prefix.Bits() != 0,
- r.wgInterface.Address().Network.Contains(addr):
+ r.isOwnAddress(addr):
return vars.ErrRouteNotAllowed
}
return nil
}
+
+func (r *SysOps) isOwnAddress(addr netip.Addr) bool {
+ if r.wgInterface == nil {
+ return false
+ }
+ wgAddr := r.wgInterface.Address()
+ return wgAddr.Network.Contains(addr) || (wgAddr.IPv6Net.IsValid() && wgAddr.IPv6Net.Contains(addr))
+}
diff --git a/client/internal/routemanager/systemops/systemops_generic.go b/client/internal/routemanager/systemops/systemops_generic.go
index bf7b95a28..2b96c14dc 100644
--- a/client/internal/routemanager/systemops/systemops_generic.go
+++ b/client/internal/routemanager/systemops/systemops_generic.go
@@ -221,30 +221,20 @@ func (r *SysOps) genericAddVPNRoute(prefix netip.Prefix, intf *net.Interface) er
return err
}
- // TODO: remove once IPv6 is supported on the interface
- if err := r.addToRouteTable(splitDefaultv6_1, nextHop); err != nil {
- return fmt.Errorf("add unreachable route split 1: %w", err)
- }
- if err := r.addToRouteTable(splitDefaultv6_2, nextHop); err != nil {
- if err2 := r.removeFromRouteTable(splitDefaultv6_1, nextHop); err2 != nil {
- log.Warnf("Failed to rollback route addition: %s", err2)
+ // When the interface has no v6, add v6 split-default as blackhole so
+ // unroutable v6 goes to WG (dropped, no AllowedIPs) instead of leaking
+ // to the system default route. When v6 is active, management sends ::/0
+ // as a separate route that the dedicated handler adds.
+ // Soft-fail: v6 blackhole is best-effort, don't abort v4 routing on failure.
+ if !r.wgInterface.Address().HasIPv6() {
+ if err := r.addV6SplitDefault(nextHop); err != nil {
+ log.Warnf("failed to add v6 split-default blackhole: %s", err)
}
- return fmt.Errorf("add unreachable route split 2: %w", err)
}
return nil
case vars.Defaultv6:
- if err := r.addToRouteTable(splitDefaultv6_1, nextHop); err != nil {
- return fmt.Errorf("add unreachable route split 1: %w", err)
- }
- if err := r.addToRouteTable(splitDefaultv6_2, nextHop); err != nil {
- if err2 := r.removeFromRouteTable(splitDefaultv6_1, nextHop); err2 != nil {
- log.Warnf("Failed to rollback route addition: %s", err2)
- }
- return fmt.Errorf("add unreachable route split 2: %w", err)
- }
-
- return nil
+ return r.addV6SplitDefault(nextHop)
}
return r.addToRouteTable(prefix, nextHop)
@@ -265,30 +255,42 @@ func (r *SysOps) genericRemoveVPNRoute(prefix netip.Prefix, intf *net.Interface)
result = multierror.Append(result, err)
}
- // TODO: remove once IPv6 is supported on the interface
- if err := r.removeFromRouteTable(splitDefaultv6_1, nextHop); err != nil {
- result = multierror.Append(result, err)
- }
- if err := r.removeFromRouteTable(splitDefaultv6_2, nextHop); err != nil {
- result = multierror.Append(result, err)
+ if !r.wgInterface.Address().HasIPv6() {
+ result = multierror.Append(result, r.removeV6SplitDefault(nextHop))
}
return nberrors.FormatErrorOrNil(result)
case vars.Defaultv6:
- var result *multierror.Error
- if err := r.removeFromRouteTable(splitDefaultv6_1, nextHop); err != nil {
- result = multierror.Append(result, err)
- }
- if err := r.removeFromRouteTable(splitDefaultv6_2, nextHop); err != nil {
- result = multierror.Append(result, err)
- }
-
- return nberrors.FormatErrorOrNil(result)
+ return nberrors.FormatErrorOrNil(r.removeV6SplitDefault(nextHop))
default:
return r.removeFromRouteTable(prefix, nextHop)
}
}
+func (r *SysOps) addV6SplitDefault(nextHop Nexthop) error {
+ if err := r.addToRouteTable(splitDefaultv6_1, nextHop); err != nil {
+ return fmt.Errorf("add split 1: %w", err)
+ }
+ if err := r.addToRouteTable(splitDefaultv6_2, nextHop); err != nil {
+ if err2 := r.removeFromRouteTable(splitDefaultv6_1, nextHop); err2 != nil {
+ log.Warnf("Failed to rollback v6 split-default: %s", err2)
+ }
+ return fmt.Errorf("add split 2: %w", err)
+ }
+ return nil
+}
+
+func (r *SysOps) removeV6SplitDefault(nextHop Nexthop) *multierror.Error {
+ var result *multierror.Error
+ if err := r.removeFromRouteTable(splitDefaultv6_1, nextHop); err != nil {
+ result = multierror.Append(result, err)
+ }
+ if err := r.removeFromRouteTable(splitDefaultv6_2, nextHop); err != nil {
+ result = multierror.Append(result, err)
+ }
+ return result
+}
+
func (r *SysOps) setupHooks(initAddresses []net.IP, stateManager *statemanager.Manager) error {
beforeHook := func(connID hooks.ConnectionID, prefix netip.Prefix) error {
if _, err := r.refCounter.IncrementWithID(string(connID), prefix, struct{}{}); err != nil {
diff --git a/client/internal/routemanager/systemops/systemops_generic_test.go b/client/internal/routemanager/systemops/systemops_generic_test.go
index 08e354a78..5695c40c3 100644
--- a/client/internal/routemanager/systemops/systemops_generic_test.go
+++ b/client/internal/routemanager/systemops/systemops_generic_test.go
@@ -21,6 +21,7 @@ import (
"golang.zx2c4.com/wireguard/wgctrl/wgtypes"
"github.com/netbirdio/netbird/client/iface"
+ "github.com/netbirdio/netbird/client/iface/wgaddr"
"github.com/netbirdio/netbird/client/internal/routemanager/vars"
nbnet "github.com/netbirdio/netbird/client/net"
)
@@ -445,7 +446,7 @@ func createWGInterface(t *testing.T, interfaceName, ipAddressCIDR string, listen
opts := iface.WGIFaceOpts{
IFaceName: interfaceName,
- Address: ipAddressCIDR,
+ Address: wgaddr.MustParseWGAddress(ipAddressCIDR),
WGPrivKey: peerPrivateKey.String(),
WGPort: listenPort,
MTU: iface.DefaultMTU,
diff --git a/client/internal/routemanager/systemops/systemops_linux.go b/client/internal/routemanager/systemops/systemops_linux.go
index 39a9fd978..8c6b7d9a9 100644
--- a/client/internal/routemanager/systemops/systemops_linux.go
+++ b/client/internal/routemanager/systemops/systemops_linux.go
@@ -53,6 +53,8 @@ const (
// ipv4ForwardingPath is the path to the file containing the IP forwarding setting.
ipv4ForwardingPath = "net.ipv4.ip_forward"
+ // ipv6ForwardingPath is the path to the file containing the IPv6 forwarding setting.
+ ipv6ForwardingPath = "net.ipv6.conf.all.forwarding"
)
var ErrTableIDExists = errors.New("ID exists with different name")
@@ -185,10 +187,11 @@ func (r *SysOps) AddVPNRoute(prefix netip.Prefix, intf *net.Interface) error {
// No need to check if routes exist as main table takes precedence over the VPN table via Rule 1
- // TODO remove this once we have ipv6 support
- if prefix == vars.Defaultv4 {
+ // When the peer has no IPv6, blackhole v6 to prevent leaking.
+ // When IPv6 is enabled, management sends ::/0 as a separate route.
+ if prefix == vars.Defaultv4 && (r.wgInterface == nil || !r.wgInterface.Address().HasIPv6()) {
if err := addUnreachableRoute(vars.Defaultv6, NetbirdVPNTableID); err != nil {
- return fmt.Errorf("add blackhole: %w", err)
+ return fmt.Errorf("add v6 blackhole: %w", err)
}
}
if err := addRoute(prefix, Nexthop{netip.Addr{}, intf}, NetbirdVPNTableID); err != nil {
@@ -206,10 +209,9 @@ func (r *SysOps) RemoveVPNRoute(prefix netip.Prefix, intf *net.Interface) error
return r.genericRemoveVPNRoute(prefix, intf)
}
- // TODO remove this once we have ipv6 support
- if prefix == vars.Defaultv4 {
+ if prefix == vars.Defaultv4 && (r.wgInterface == nil || !r.wgInterface.Address().HasIPv6()) {
if err := removeUnreachableRoute(vars.Defaultv6, NetbirdVPNTableID); err != nil {
- return fmt.Errorf("remove unreachable route: %w", err)
+ log.Debugf("remove v6 blackhole: %v", err)
}
}
if err := removeRoute(prefix, Nexthop{netip.Addr{}, intf}, NetbirdVPNTableID); err != nil {
@@ -762,8 +764,13 @@ func flushRoutes(tableID, family int) error {
}
func EnableIPForwarding() error {
- _, err := sysctl.Set(ipv4ForwardingPath, 1, false)
- return err
+ if _, err := sysctl.Set(ipv4ForwardingPath, 1, false); err != nil {
+ return err
+ }
+ if _, err := sysctl.Set(ipv6ForwardingPath, 1, false); err != nil {
+ log.Warnf("failed to enable IPv6 forwarding: %v", err)
+ }
+ return nil
}
// entryExists checks if the specified ID or name already exists in the rt_tables file
diff --git a/client/internal/routeselector/routeselector.go b/client/internal/routeselector/routeselector.go
index 30afc013b..2ddc24bf2 100644
--- a/client/internal/routeselector/routeselector.go
+++ b/client/internal/routeselector/routeselector.go
@@ -4,6 +4,7 @@ import (
"encoding/json"
"fmt"
"slices"
+ "strings"
"sync"
"github.com/hashicorp/go-multierror"
@@ -12,10 +13,6 @@ import (
"github.com/netbirdio/netbird/route"
)
-const (
- exitNodeCIDR = "0.0.0.0/0"
-)
-
type RouteSelector struct {
mu sync.RWMutex
deselectedRoutes map[route.NetID]struct{}
@@ -124,13 +121,7 @@ func (rs *RouteSelector) IsSelected(routeID route.NetID) bool {
rs.mu.RLock()
defer rs.mu.RUnlock()
- if rs.deselectAll {
- return false
- }
-
- _, deselected := rs.deselectedRoutes[routeID]
- isSelected := !deselected
- return isSelected
+ return rs.isSelectedLocked(routeID)
}
// FilterSelected removes unselected routes from the provided map.
@@ -144,23 +135,22 @@ func (rs *RouteSelector) FilterSelected(routes route.HAMap) route.HAMap {
filtered := route.HAMap{}
for id, rt := range routes {
- netID := id.NetID()
- _, deselected := rs.deselectedRoutes[netID]
- if !deselected {
+ if !rs.isDeselectedLocked(id.NetID()) {
filtered[id] = rt
}
}
return filtered
}
-// HasUserSelectionForRoute returns true if the user has explicitly selected or deselected this specific route
+// HasUserSelectionForRoute returns true if the user has explicitly selected or deselected this route.
+// Intended for exit-node code paths: a v6 exit-node pair (e.g. "MyExit-v6") with no explicit state of
+// its own inherits its v4 base's state, so legacy persisted selections that predate v6 pairing
+// transparently apply to the synthesized v6 entry.
func (rs *RouteSelector) HasUserSelectionForRoute(routeID route.NetID) bool {
rs.mu.RLock()
defer rs.mu.RUnlock()
- _, selected := rs.selectedRoutes[routeID]
- _, deselected := rs.deselectedRoutes[routeID]
- return selected || deselected
+ return rs.hasUserSelectionForRouteLocked(rs.effectiveNetID(routeID))
}
func (rs *RouteSelector) FilterSelectedExitNodes(routes route.HAMap) route.HAMap {
@@ -174,7 +164,7 @@ func (rs *RouteSelector) FilterSelectedExitNodes(routes route.HAMap) route.HAMap
filtered := make(route.HAMap, len(routes))
for id, rt := range routes {
netID := id.NetID()
- if rs.isDeselected(netID) {
+ if rs.isDeselectedLocked(netID) {
continue
}
@@ -189,13 +179,48 @@ func (rs *RouteSelector) FilterSelectedExitNodes(routes route.HAMap) route.HAMap
return filtered
}
-func (rs *RouteSelector) isDeselected(netID route.NetID) bool {
+// effectiveNetID returns the v4 base for a "-v6" exit pair entry that has no explicit
+// state of its own, so selections made on the v4 entry govern the v6 entry automatically.
+// Only call this from exit-node-specific code paths: applying it to a non-exit "-v6" route
+// would make it inherit unrelated v4 state. Must be called with rs.mu held.
+func (rs *RouteSelector) effectiveNetID(id route.NetID) route.NetID {
+ name := string(id)
+ if !strings.HasSuffix(name, route.V6ExitSuffix) {
+ return id
+ }
+ if _, ok := rs.selectedRoutes[id]; ok {
+ return id
+ }
+ if _, ok := rs.deselectedRoutes[id]; ok {
+ return id
+ }
+ return route.NetID(strings.TrimSuffix(name, route.V6ExitSuffix))
+}
+
+func (rs *RouteSelector) isSelectedLocked(routeID route.NetID) bool {
+ if rs.deselectAll {
+ return false
+ }
+ _, deselected := rs.deselectedRoutes[routeID]
+ return !deselected
+}
+
+func (rs *RouteSelector) isDeselectedLocked(netID route.NetID) bool {
+ if rs.deselectAll {
+ return true
+ }
_, deselected := rs.deselectedRoutes[netID]
- return deselected || rs.deselectAll
+ return deselected
+}
+
+func (rs *RouteSelector) hasUserSelectionForRouteLocked(routeID route.NetID) bool {
+ _, selected := rs.selectedRoutes[routeID]
+ _, deselected := rs.deselectedRoutes[routeID]
+ return selected || deselected
}
func isExitNode(rt []*route.Route) bool {
- return len(rt) > 0 && rt[0].Network.String() == exitNodeCIDR
+ return len(rt) > 0 && (route.IsV4DefaultRoute(rt[0].Network) || route.IsV6DefaultRoute(rt[0].Network))
}
func (rs *RouteSelector) applyExitNodeFilter(
@@ -204,26 +229,23 @@ func (rs *RouteSelector) applyExitNodeFilter(
rt []*route.Route,
out route.HAMap,
) {
-
- if rs.hasUserSelections() {
- // user made explicit selects/deselects
- if rs.IsSelected(netID) {
+ // Exit-node path: apply the v4/v6 pair mirror so a deselect on the v4 base also
+ // drops the synthesized v6 entry that lacks its own explicit state.
+ effective := rs.effectiveNetID(netID)
+ if rs.hasUserSelectionForRouteLocked(effective) {
+ if rs.isSelectedLocked(effective) {
out[id] = rt
}
return
}
- // no explicit selections: only include routes marked !SkipAutoApply (=AutoApply)
+ // no explicit selection for this route: defer to management's SkipAutoApply flag
sel := collectSelected(rt)
if len(sel) > 0 {
out[id] = sel
}
}
-func (rs *RouteSelector) hasUserSelections() bool {
- return len(rs.selectedRoutes) > 0 || len(rs.deselectedRoutes) > 0
-}
-
func collectSelected(rt []*route.Route) []*route.Route {
var sel []*route.Route
for _, r := range rt {
diff --git a/client/internal/routeselector/routeselector_test.go b/client/internal/routeselector/routeselector_test.go
index 5faea2456..3f0d9f120 100644
--- a/client/internal/routeselector/routeselector_test.go
+++ b/client/internal/routeselector/routeselector_test.go
@@ -330,6 +330,137 @@ func TestRouteSelector_FilterSelectedExitNodes(t *testing.T) {
assert.Len(t, filtered, 0) // No routes should be selected
}
+// TestRouteSelector_V6ExitPairInherits covers the v4/v6 exit-node pair selection
+// mirror. The mirror is scoped to exit-node code paths: HasUserSelectionForRoute
+// and FilterSelectedExitNodes resolve a "-v6" entry without explicit state to its
+// v4 base, so legacy persisted selections that predate v6 pairing transparently
+// apply to the synthesized v6 entry. General lookups (IsSelected, FilterSelected)
+// stay literal so unrelated routes named "*-v6" don't inherit unrelated state.
+func TestRouteSelector_V6ExitPairInherits(t *testing.T) {
+ all := []route.NetID{"exit1", "exit1-v6", "exit2", "exit2-v6", "corp", "corp-v6"}
+
+ t.Run("HasUserSelectionForRoute mirrors deselected v4 base", func(t *testing.T) {
+ rs := routeselector.NewRouteSelector()
+ require.NoError(t, rs.DeselectRoutes([]route.NetID{"exit1"}, all))
+
+ assert.True(t, rs.HasUserSelectionForRoute("exit1-v6"), "v6 pair sees v4 base's user selection")
+
+ // unrelated v6 with no v4 base touched is unaffected
+ assert.False(t, rs.HasUserSelectionForRoute("exit2-v6"))
+ })
+
+ t.Run("IsSelected stays literal for non-exit lookups", func(t *testing.T) {
+ rs := routeselector.NewRouteSelector()
+ require.NoError(t, rs.DeselectRoutes([]route.NetID{"corp"}, all))
+
+ // A non-exit route literally named "corp-v6" must not inherit "corp"'s state
+ // via the mirror; the mirror only applies in exit-node code paths.
+ assert.False(t, rs.IsSelected("corp"))
+ assert.True(t, rs.IsSelected("corp-v6"), "non-exit *-v6 routes must not inherit unrelated v4 state")
+ })
+
+ t.Run("explicit v6 state overrides v4 base in filter", func(t *testing.T) {
+ rs := routeselector.NewRouteSelector()
+ require.NoError(t, rs.DeselectRoutes([]route.NetID{"exit1"}, all))
+ require.NoError(t, rs.SelectRoutes([]route.NetID{"exit1-v6"}, true, all))
+
+ v4Route := &route.Route{NetID: "exit1", Network: netip.MustParsePrefix("0.0.0.0/0")}
+ v6Route := &route.Route{NetID: "exit1-v6", Network: netip.MustParsePrefix("::/0")}
+ routes := route.HAMap{
+ "exit1|0.0.0.0/0": {v4Route},
+ "exit1-v6|::/0": {v6Route},
+ }
+
+ filtered := rs.FilterSelectedExitNodes(routes)
+ assert.NotContains(t, filtered, route.HAUniqueID("exit1|0.0.0.0/0"))
+ assert.Contains(t, filtered, route.HAUniqueID("exit1-v6|::/0"), "explicit v6 select wins over v4 base")
+ })
+
+ t.Run("non-v6-suffix routes unaffected", func(t *testing.T) {
+ rs := routeselector.NewRouteSelector()
+ require.NoError(t, rs.DeselectRoutes([]route.NetID{"exit1"}, all))
+
+ // A route literally named "exit1-something" must not pair-resolve.
+ assert.False(t, rs.HasUserSelectionForRoute("exit1-something"))
+ })
+
+ t.Run("filter v6 paired with deselected v4 base", func(t *testing.T) {
+ rs := routeselector.NewRouteSelector()
+ require.NoError(t, rs.DeselectRoutes([]route.NetID{"exit1"}, all))
+
+ v4Route := &route.Route{NetID: "exit1", Network: netip.MustParsePrefix("0.0.0.0/0")}
+ v6Route := &route.Route{NetID: "exit1-v6", Network: netip.MustParsePrefix("::/0")}
+ routes := route.HAMap{
+ "exit1|0.0.0.0/0": {v4Route},
+ "exit1-v6|::/0": {v6Route},
+ }
+
+ filtered := rs.FilterSelectedExitNodes(routes)
+ assert.Empty(t, filtered, "deselecting v4 base must also drop the v6 pair")
+ })
+
+ t.Run("non-exit *-v6 routes pass through FilterSelectedExitNodes", func(t *testing.T) {
+ rs := routeselector.NewRouteSelector()
+ require.NoError(t, rs.DeselectRoutes([]route.NetID{"corp"}, all))
+
+ // A non-default-route entry named "corp-v6" is not an exit node and
+ // must not be skipped because its v4 base "corp" is deselected.
+ corpV6 := &route.Route{NetID: "corp-v6", Network: netip.MustParsePrefix("10.0.0.0/8")}
+ routes := route.HAMap{
+ "corp-v6|10.0.0.0/8": {corpV6},
+ }
+
+ filtered := rs.FilterSelectedExitNodes(routes)
+ assert.Contains(t, filtered, route.HAUniqueID("corp-v6|10.0.0.0/8"),
+ "non-exit *-v6 routes must not inherit unrelated v4 state in FilterSelectedExitNodes")
+ })
+}
+
+// TestRouteSelector_SkipAutoApplyPerRoute verifies that management's
+// SkipAutoApply flag governs each untouched route independently, even when
+// the user has explicit selections on other routes.
+func TestRouteSelector_SkipAutoApplyPerRoute(t *testing.T) {
+ autoApplied := &route.Route{
+ NetID: "Auto",
+ Network: netip.MustParsePrefix("0.0.0.0/0"),
+ SkipAutoApply: false,
+ }
+ skipApply := &route.Route{
+ NetID: "Skip",
+ Network: netip.MustParsePrefix("0.0.0.0/0"),
+ SkipAutoApply: true,
+ }
+ routes := route.HAMap{
+ "Auto|0.0.0.0/0": {autoApplied},
+ "Skip|0.0.0.0/0": {skipApply},
+ }
+
+ rs := routeselector.NewRouteSelector()
+ // User makes an unrelated explicit selection elsewhere.
+ require.NoError(t, rs.DeselectRoutes([]route.NetID{"Unrelated"}, []route.NetID{"Auto", "Skip", "Unrelated"}))
+
+ filtered := rs.FilterSelectedExitNodes(routes)
+ assert.Contains(t, filtered, route.HAUniqueID("Auto|0.0.0.0/0"), "AutoApply route should be included")
+ assert.NotContains(t, filtered, route.HAUniqueID("Skip|0.0.0.0/0"), "SkipAutoApply route should be excluded without explicit user selection")
+}
+
+// TestRouteSelector_V6ExitIsExitNode verifies that ::/0 routes are recognized
+// as exit nodes by the selector's filter path.
+func TestRouteSelector_V6ExitIsExitNode(t *testing.T) {
+ v6Exit := &route.Route{
+ NetID: "V6Only",
+ Network: netip.MustParsePrefix("::/0"),
+ SkipAutoApply: true,
+ }
+ routes := route.HAMap{
+ "V6Only|::/0": {v6Exit},
+ }
+
+ rs := routeselector.NewRouteSelector()
+ filtered := rs.FilterSelectedExitNodes(routes)
+ assert.Empty(t, filtered, "::/0 should be treated as an exit node and respect SkipAutoApply")
+}
+
func TestRouteSelector_NewRoutesBehavior(t *testing.T) {
initialRoutes := []route.NetID{"route1", "route2", "route3"}
newRoutes := []route.NetID{"route1", "route2", "route3", "route4", "route5"}
diff --git a/client/internal/sleep/detector_darwin.go b/client/internal/sleep/detector_darwin.go
index ef495bded..fc4713b21 100644
--- a/client/internal/sleep/detector_darwin.go
+++ b/client/internal/sleep/detector_darwin.go
@@ -188,7 +188,9 @@ func (d *Detector) triggerCallback(event EventType, cb func(event EventType), do
}
doneChan := make(chan struct{})
- timeout := time.NewTimer(500 * time.Millisecond)
+ // macOS forces sleep ~30s after kIOMessageSystemWillSleep, so block long
+ // enough for teardown to finish while staying under that deadline.
+ timeout := time.NewTimer(20 * time.Second)
defer timeout.Stop()
go func() {
diff --git a/client/ios/NetBirdSDK/client.go b/client/ios/NetBirdSDK/client.go
index ee9959b0f..2de0693d8 100644
--- a/client/ios/NetBirdSDK/client.go
+++ b/client/ios/NetBirdSDK/client.go
@@ -52,10 +52,11 @@ type CustomLogger interface {
}
type selectRoute struct {
- NetID string
- Network netip.Prefix
- Domains domain.List
- Selected bool
+ NetID string
+ Network netip.Prefix
+ Domains domain.List
+ Selected bool
+ extraNetworks []netip.Prefix
}
func init() {
@@ -169,11 +170,7 @@ func (c *Client) Run(fd int32, interfaceName string, envList *EnvList) error {
connectClient := internal.NewConnectClient(ctx, cfg, c.recorder)
c.setState(cfg, connectClient)
- hostDNS := []netip.AddrPort{
- netip.MustParseAddrPort("9.9.9.9:53"),
- netip.MustParseAddrPort("149.112.112.112:53"),
- }
- return connectClient.RunOniOS(fd, c.networkChangeListener, c.dnsManager, hostDNS, c.stateFile, c.cacheDir)
+ return connectClient.RunOniOS(fd, c.networkChangeListener, c.dnsManager, c.stateFile, c.cacheDir)
}
// Stop the internal client and free the resources
@@ -283,6 +280,7 @@ func (c *Client) GetStatusDetails() *StatusDetails {
}
pi := PeerInfo{
IP: p.IP,
+ IPv6: p.IPv6,
FQDN: p.FQDN,
LocalIceCandidateEndpoint: p.LocalIceCandidateEndpoint,
RemoteIceCandidateEndpoint: p.RemoteIceCandidateEndpoint,
@@ -301,7 +299,7 @@ func (c *Client) GetStatusDetails() *StatusDetails {
}
peerInfos[n] = pi
}
- return &StatusDetails{items: peerInfos, fqdn: fullStatus.LocalPeerState.FQDN, ip: fullStatus.LocalPeerState.IP}
+ return &StatusDetails{items: peerInfos, fqdn: fullStatus.LocalPeerState.FQDN, ip: fullStatus.LocalPeerState.IP, ipv6: fullStatus.LocalPeerState.IPv6}
}
// SetConnectionListener set the network connection listener
@@ -452,48 +450,60 @@ func (c *Client) GetRoutesSelectionDetails() (*RoutesSelectionDetails, error) {
}
routeManager := engine.GetRouteManager()
- routesMap := routeManager.GetClientRoutesWithNetID()
if routeManager == nil {
return nil, fmt.Errorf("could not get route manager")
}
+ routesMap := routeManager.GetClientRoutesWithNetID()
routeSelector := routeManager.GetRouteSelector()
if routeSelector == nil {
return nil, fmt.Errorf("could not get route selector")
}
+ v6ExitMerged := route.V6ExitMergeSet(routesMap)
+ routes := buildSelectRoutes(routesMap, routeSelector.IsSelected, v6ExitMerged)
+ resolvedDomains := c.recorder.GetResolvedDomainsStates()
+
+ return prepareRouteSelectionDetails(routes, resolvedDomains), nil
+}
+
+func buildSelectRoutes(routesMap map[route.NetID][]*route.Route, isSelected func(route.NetID) bool, v6Merged map[route.NetID]struct{}) []*selectRoute {
var routes []*selectRoute
for id, rt := range routesMap {
if len(rt) == 0 {
continue
}
- route := &selectRoute{
+ if _, ok := v6Merged[id]; ok {
+ continue
+ }
+
+ r := &selectRoute{
NetID: string(id),
Network: rt[0].Network,
Domains: rt[0].Domains,
- Selected: routeSelector.IsSelected(id),
+ Selected: isSelected(id),
}
- routes = append(routes, route)
+
+ v6ID := route.NetID(string(id) + route.V6ExitSuffix)
+ if _, ok := v6Merged[v6ID]; ok {
+ r.extraNetworks = []netip.Prefix{routesMap[v6ID][0].Network}
+ }
+
+ routes = append(routes, r)
}
sort.Slice(routes, func(i, j int) bool {
- iPrefix := routes[i].Network.Bits()
- jPrefix := routes[j].Network.Bits()
-
- if iPrefix == jPrefix {
- iAddr := routes[i].Network.Addr()
- jAddr := routes[j].Network.Addr()
- if iAddr == jAddr {
- return routes[i].NetID < routes[j].NetID
- }
- return iAddr.String() < jAddr.String()
+ iBits, jBits := routes[i].Network.Bits(), routes[j].Network.Bits()
+ if iBits != jBits {
+ return iBits < jBits
}
- return iPrefix < jPrefix
+ iAddr, jAddr := routes[i].Network.Addr(), routes[j].Network.Addr()
+ if iAddr != jAddr {
+ return iAddr.Less(jAddr)
+ }
+ return routes[i].NetID < routes[j].NetID
})
- resolvedDomains := c.recorder.GetResolvedDomainsStates()
-
- return prepareRouteSelectionDetails(routes, resolvedDomains), nil
-
+ return routes
}
func prepareRouteSelectionDetails(routes []*selectRoute, resolvedDomains map[domain.Domain]peer.ResolvedDomainInfo) *RoutesSelectionDetails {
@@ -529,6 +539,9 @@ func prepareRouteSelectionDetails(routes []*selectRoute, resolvedDomains map[dom
if len(r.Domains) > 0 {
netStr = r.Domains.SafeString()
}
+ for _, extra := range r.extraNetworks {
+ netStr += ", " + extra.String()
+ }
routeSelection = append(routeSelection, RoutesSelectionInfo{
ID: r.NetID,
@@ -561,7 +574,9 @@ func (c *Client) SelectRoute(id string) error {
} else {
log.Debugf("select route with id: %s", id)
routes := toNetIDs([]string{id})
- if err := routeSelector.SelectRoutes(routes, true, maps.Keys(routeManager.GetClientRoutesWithNetID())); err != nil {
+ routesMap := routeManager.GetClientRoutesWithNetID()
+ routes = route.ExpandV6ExitPairs(routes, routesMap)
+ if err := routeSelector.SelectRoutes(routes, true, maps.Keys(routesMap)); err != nil {
log.Debugf("error when selecting routes: %s", err)
return fmt.Errorf("select routes: %w", err)
}
@@ -589,7 +604,9 @@ func (c *Client) DeselectRoute(id string) error {
} else {
log.Debugf("deselect route with id: %s", id)
routes := toNetIDs([]string{id})
- if err := routeSelector.DeselectRoutes(routes, maps.Keys(routeManager.GetClientRoutesWithNetID())); err != nil {
+ routesMap := routeManager.GetClientRoutesWithNetID()
+ routes = route.ExpandV6ExitPairs(routes, routesMap)
+ if err := routeSelector.DeselectRoutes(routes, maps.Keys(routesMap)); err != nil {
log.Debugf("error when deselecting routes: %s", err)
return fmt.Errorf("deselect routes: %w", err)
}
diff --git a/client/ios/NetBirdSDK/peer_notifier.go b/client/ios/NetBirdSDK/peer_notifier.go
index 9b00568be..025cd94cd 100644
--- a/client/ios/NetBirdSDK/peer_notifier.go
+++ b/client/ios/NetBirdSDK/peer_notifier.go
@@ -5,6 +5,7 @@ package NetBirdSDK
// PeerInfo describe information about the peers. It designed for the UI usage
type PeerInfo struct {
IP string
+ IPv6 string
FQDN string
LocalIceCandidateEndpoint string
RemoteIceCandidateEndpoint string
@@ -23,6 +24,11 @@ type PeerInfo struct {
Routes RoutesDetails
}
+// GetIPv6 returns the IPv6 address of the peer
+func (p PeerInfo) GetIPv6() string {
+ return p.IPv6
+}
+
// GetRoutes return with RouteDetails
func (p PeerInfo) GetRouteDetails() *RoutesDetails {
return &p.Routes
@@ -57,6 +63,7 @@ type StatusDetails struct {
items []PeerInfo
fqdn string
ip string
+ ipv6 string
}
// Add new PeerInfo to the collection
@@ -100,3 +107,8 @@ func (array StatusDetails) GetFQDN() string {
func (array StatusDetails) GetIP() string {
return array.ip
}
+
+// GetIPv6 return with the IPv6 of the local peer
+func (array StatusDetails) GetIPv6() string {
+ return array.ipv6
+}
diff --git a/client/ios/NetBirdSDK/preferences.go b/client/ios/NetBirdSDK/preferences.go
index c26a6decd..ed49ccddb 100644
--- a/client/ios/NetBirdSDK/preferences.go
+++ b/client/ios/NetBirdSDK/preferences.go
@@ -110,6 +110,24 @@ func (p *Preferences) GetRosenpassPermissive() (bool, error) {
return cfg.RosenpassPermissive, err
}
+// GetDisableIPv6 reads disable IPv6 setting from config file
+func (p *Preferences) GetDisableIPv6() (bool, error) {
+ if p.configInput.DisableIPv6 != nil {
+ return *p.configInput.DisableIPv6, nil
+ }
+
+ cfg, err := profilemanager.ReadConfig(p.configInput.ConfigPath)
+ if err != nil {
+ return false, err
+ }
+ return cfg.DisableIPv6, err
+}
+
+// SetDisableIPv6 stores the given value and waits for commit
+func (p *Preferences) SetDisableIPv6(disable bool) {
+ p.configInput.DisableIPv6 = &disable
+}
+
// Commit write out the changes into config file
func (p *Preferences) Commit() error {
// Use DirectUpdateOrCreateConfig to avoid atomic file operations (temp file + rename)
diff --git a/client/proto/daemon.pb.go b/client/proto/daemon.pb.go
index 11e7877f2..2c054c99a 100644
--- a/client/proto/daemon.pb.go
+++ b/client/proto/daemon.pb.go
@@ -342,6 +342,7 @@ type LoginRequest struct {
EnableSSHRemotePortForwarding *bool `protobuf:"varint,37,opt,name=enableSSHRemotePortForwarding,proto3,oneof" json:"enableSSHRemotePortForwarding,omitempty"`
DisableSSHAuth *bool `protobuf:"varint,38,opt,name=disableSSHAuth,proto3,oneof" json:"disableSSHAuth,omitempty"`
SshJWTCacheTTL *int32 `protobuf:"varint,39,opt,name=sshJWTCacheTTL,proto3,oneof" json:"sshJWTCacheTTL,omitempty"`
+ DisableIpv6 *bool `protobuf:"varint,40,opt,name=disable_ipv6,json=disableIpv6,proto3,oneof" json:"disable_ipv6,omitempty"`
unknownFields protoimpl.UnknownFields
sizeCache protoimpl.SizeCache
}
@@ -650,6 +651,13 @@ func (x *LoginRequest) GetSshJWTCacheTTL() int32 {
return 0
}
+func (x *LoginRequest) GetDisableIpv6() bool {
+ if x != nil && x.DisableIpv6 != nil {
+ return *x.DisableIpv6
+ }
+ return false
+}
+
type LoginResponse struct {
state protoimpl.MessageState `protogen:"open.v1"`
NeedsSSOLogin bool `protobuf:"varint,1,opt,name=needsSSOLogin,proto3" json:"needsSSOLogin,omitempty"`
@@ -1182,6 +1190,7 @@ type GetConfigResponse struct {
EnableSSHRemotePortForwarding bool `protobuf:"varint,23,opt,name=enableSSHRemotePortForwarding,proto3" json:"enableSSHRemotePortForwarding,omitempty"`
DisableSSHAuth bool `protobuf:"varint,25,opt,name=disableSSHAuth,proto3" json:"disableSSHAuth,omitempty"`
SshJWTCacheTTL int32 `protobuf:"varint,26,opt,name=sshJWTCacheTTL,proto3" json:"sshJWTCacheTTL,omitempty"`
+ DisableIpv6 bool `protobuf:"varint,27,opt,name=disable_ipv6,json=disableIpv6,proto3" json:"disable_ipv6,omitempty"`
unknownFields protoimpl.UnknownFields
sizeCache protoimpl.SizeCache
}
@@ -1398,6 +1407,13 @@ func (x *GetConfigResponse) GetSshJWTCacheTTL() int32 {
return 0
}
+func (x *GetConfigResponse) GetDisableIpv6() bool {
+ if x != nil {
+ return x.DisableIpv6
+ }
+ return false
+}
+
// PeerState contains the latest state of a peer
type PeerState struct {
state protoimpl.MessageState `protogen:"open.v1"`
@@ -1419,6 +1435,7 @@ type PeerState struct {
Latency *durationpb.Duration `protobuf:"bytes,17,opt,name=latency,proto3" json:"latency,omitempty"`
RelayAddress string `protobuf:"bytes,18,opt,name=relayAddress,proto3" json:"relayAddress,omitempty"`
SshHostKey []byte `protobuf:"bytes,19,opt,name=sshHostKey,proto3" json:"sshHostKey,omitempty"`
+ Ipv6 string `protobuf:"bytes,20,opt,name=ipv6,proto3" json:"ipv6,omitempty"`
unknownFields protoimpl.UnknownFields
sizeCache protoimpl.SizeCache
}
@@ -1579,6 +1596,13 @@ func (x *PeerState) GetSshHostKey() []byte {
return nil
}
+func (x *PeerState) GetIpv6() string {
+ if x != nil {
+ return x.Ipv6
+ }
+ return ""
+}
+
// LocalPeerState contains the latest state of the local peer
type LocalPeerState struct {
state protoimpl.MessageState `protogen:"open.v1"`
@@ -1589,6 +1613,7 @@ type LocalPeerState struct {
RosenpassEnabled bool `protobuf:"varint,5,opt,name=rosenpassEnabled,proto3" json:"rosenpassEnabled,omitempty"`
RosenpassPermissive bool `protobuf:"varint,6,opt,name=rosenpassPermissive,proto3" json:"rosenpassPermissive,omitempty"`
Networks []string `protobuf:"bytes,7,rep,name=networks,proto3" json:"networks,omitempty"`
+ Ipv6 string `protobuf:"bytes,8,opt,name=ipv6,proto3" json:"ipv6,omitempty"`
unknownFields protoimpl.UnknownFields
sizeCache protoimpl.SizeCache
}
@@ -1672,6 +1697,13 @@ func (x *LocalPeerState) GetNetworks() []string {
return nil
}
+func (x *LocalPeerState) GetIpv6() string {
+ if x != nil {
+ return x.Ipv6
+ }
+ return ""
+}
+
// SignalState contains the latest state of a signal connection
type SignalState struct {
state protoimpl.MessageState `protogen:"open.v1"`
@@ -4009,6 +4041,7 @@ type SetConfigRequest struct {
EnableSSHRemotePortForwarding *bool `protobuf:"varint,32,opt,name=enableSSHRemotePortForwarding,proto3,oneof" json:"enableSSHRemotePortForwarding,omitempty"`
DisableSSHAuth *bool `protobuf:"varint,33,opt,name=disableSSHAuth,proto3,oneof" json:"disableSSHAuth,omitempty"`
SshJWTCacheTTL *int32 `protobuf:"varint,34,opt,name=sshJWTCacheTTL,proto3,oneof" json:"sshJWTCacheTTL,omitempty"`
+ DisableIpv6 *bool `protobuf:"varint,35,opt,name=disable_ipv6,json=disableIpv6,proto3,oneof" json:"disable_ipv6,omitempty"`
unknownFields protoimpl.UnknownFields
sizeCache protoimpl.SizeCache
}
@@ -4281,6 +4314,13 @@ func (x *SetConfigRequest) GetSshJWTCacheTTL() int32 {
return 0
}
+func (x *SetConfigRequest) GetDisableIpv6() bool {
+ if x != nil && x.DisableIpv6 != nil {
+ return *x.DisableIpv6
+ }
+ return false
+}
+
type SetConfigResponse struct {
state protoimpl.MessageState `protogen:"open.v1"`
unknownFields protoimpl.UnknownFields
@@ -6186,7 +6226,7 @@ var File_daemon_proto protoreflect.FileDescriptor
const file_daemon_proto_rawDesc = "" +
"\n" +
"\fdaemon.proto\x12\x06daemon\x1a google/protobuf/descriptor.proto\x1a\x1fgoogle/protobuf/timestamp.proto\x1a\x1egoogle/protobuf/duration.proto\"\x0e\n" +
- "\fEmptyRequest\"\xb6\x12\n" +
+ "\fEmptyRequest\"\xef\x12\n" +
"\fLoginRequest\x12\x1a\n" +
"\bsetupKey\x18\x01 \x01(\tR\bsetupKey\x12&\n" +
"\fpreSharedKey\x18\x02 \x01(\tB\x02\x18\x01R\fpreSharedKey\x12$\n" +
@@ -6230,7 +6270,8 @@ const file_daemon_proto_rawDesc = "" +
"\x1cenableSSHLocalPortForwarding\x18$ \x01(\bH\x17R\x1cenableSSHLocalPortForwarding\x88\x01\x01\x12I\n" +
"\x1denableSSHRemotePortForwarding\x18% \x01(\bH\x18R\x1denableSSHRemotePortForwarding\x88\x01\x01\x12+\n" +
"\x0edisableSSHAuth\x18& \x01(\bH\x19R\x0edisableSSHAuth\x88\x01\x01\x12+\n" +
- "\x0esshJWTCacheTTL\x18' \x01(\x05H\x1aR\x0esshJWTCacheTTL\x88\x01\x01B\x13\n" +
+ "\x0esshJWTCacheTTL\x18' \x01(\x05H\x1aR\x0esshJWTCacheTTL\x88\x01\x01\x12&\n" +
+ "\fdisable_ipv6\x18( \x01(\bH\x1bR\vdisableIpv6\x88\x01\x01B\x13\n" +
"\x11_rosenpassEnabledB\x10\n" +
"\x0e_interfaceNameB\x10\n" +
"\x0e_wireguardPortB\x17\n" +
@@ -6257,7 +6298,8 @@ const file_daemon_proto_rawDesc = "" +
"\x1d_enableSSHLocalPortForwardingB \n" +
"\x1e_enableSSHRemotePortForwardingB\x11\n" +
"\x0f_disableSSHAuthB\x11\n" +
- "\x0f_sshJWTCacheTTL\"\xb5\x01\n" +
+ "\x0f_sshJWTCacheTTLB\x0f\n" +
+ "\r_disable_ipv6\"\xb5\x01\n" +
"\rLoginResponse\x12$\n" +
"\rneedsSSOLogin\x18\x01 \x01(\bR\rneedsSSOLogin\x12\x1a\n" +
"\buserCode\x18\x02 \x01(\tR\buserCode\x12(\n" +
@@ -6290,7 +6332,7 @@ const file_daemon_proto_rawDesc = "" +
"\fDownResponse\"P\n" +
"\x10GetConfigRequest\x12 \n" +
"\vprofileName\x18\x01 \x01(\tR\vprofileName\x12\x1a\n" +
- "\busername\x18\x02 \x01(\tR\busername\"\xdb\b\n" +
+ "\busername\x18\x02 \x01(\tR\busername\"\xfe\b\n" +
"\x11GetConfigResponse\x12$\n" +
"\rmanagementUrl\x18\x01 \x01(\tR\rmanagementUrl\x12\x1e\n" +
"\n" +
@@ -6321,7 +6363,8 @@ const file_daemon_proto_rawDesc = "" +
"\x1cenableSSHLocalPortForwarding\x18\x16 \x01(\bR\x1cenableSSHLocalPortForwarding\x12D\n" +
"\x1denableSSHRemotePortForwarding\x18\x17 \x01(\bR\x1denableSSHRemotePortForwarding\x12&\n" +
"\x0edisableSSHAuth\x18\x19 \x01(\bR\x0edisableSSHAuth\x12&\n" +
- "\x0esshJWTCacheTTL\x18\x1a \x01(\x05R\x0esshJWTCacheTTL\"\xfe\x05\n" +
+ "\x0esshJWTCacheTTL\x18\x1a \x01(\x05R\x0esshJWTCacheTTL\x12!\n" +
+ "\fdisable_ipv6\x18\x1b \x01(\bR\vdisableIpv6\"\x92\x06\n" +
"\tPeerState\x12\x0e\n" +
"\x02IP\x18\x01 \x01(\tR\x02IP\x12\x16\n" +
"\x06pubKey\x18\x02 \x01(\tR\x06pubKey\x12\x1e\n" +
@@ -6345,7 +6388,8 @@ const file_daemon_proto_rawDesc = "" +
"\frelayAddress\x18\x12 \x01(\tR\frelayAddress\x12\x1e\n" +
"\n" +
"sshHostKey\x18\x13 \x01(\fR\n" +
- "sshHostKey\"\xf0\x01\n" +
+ "sshHostKey\x12\x12\n" +
+ "\x04ipv6\x18\x14 \x01(\tR\x04ipv6\"\x84\x02\n" +
"\x0eLocalPeerState\x12\x0e\n" +
"\x02IP\x18\x01 \x01(\tR\x02IP\x12\x16\n" +
"\x06pubKey\x18\x02 \x01(\tR\x06pubKey\x12(\n" +
@@ -6353,7 +6397,8 @@ const file_daemon_proto_rawDesc = "" +
"\x04fqdn\x18\x04 \x01(\tR\x04fqdn\x12*\n" +
"\x10rosenpassEnabled\x18\x05 \x01(\bR\x10rosenpassEnabled\x120\n" +
"\x13rosenpassPermissive\x18\x06 \x01(\bR\x13rosenpassPermissive\x12\x1a\n" +
- "\bnetworks\x18\a \x03(\tR\bnetworks\"S\n" +
+ "\bnetworks\x18\a \x03(\tR\bnetworks\x12\x12\n" +
+ "\x04ipv6\x18\b \x01(\tR\x04ipv6\"S\n" +
"\vSignalState\x12\x10\n" +
"\x03URL\x18\x01 \x01(\tR\x03URL\x12\x1c\n" +
"\tconnected\x18\x02 \x01(\bR\tconnected\x12\x14\n" +
@@ -6534,7 +6579,7 @@ const file_daemon_proto_rawDesc = "" +
"\busername\x18\x02 \x01(\tH\x01R\busername\x88\x01\x01B\x0e\n" +
"\f_profileNameB\v\n" +
"\t_username\"\x17\n" +
- "\x15SwitchProfileResponse\"\xdf\x10\n" +
+ "\x15SwitchProfileResponse\"\x98\x11\n" +
"\x10SetConfigRequest\x12\x1a\n" +
"\busername\x18\x01 \x01(\tR\busername\x12 \n" +
"\vprofileName\x18\x02 \x01(\tR\vprofileName\x12$\n" +
@@ -6573,7 +6618,8 @@ const file_daemon_proto_rawDesc = "" +
"\x1cenableSSHLocalPortForwarding\x18\x1f \x01(\bH\x14R\x1cenableSSHLocalPortForwarding\x88\x01\x01\x12I\n" +
"\x1denableSSHRemotePortForwarding\x18 \x01(\bH\x15R\x1denableSSHRemotePortForwarding\x88\x01\x01\x12+\n" +
"\x0edisableSSHAuth\x18! \x01(\bH\x16R\x0edisableSSHAuth\x88\x01\x01\x12+\n" +
- "\x0esshJWTCacheTTL\x18\" \x01(\x05H\x17R\x0esshJWTCacheTTL\x88\x01\x01B\x13\n" +
+ "\x0esshJWTCacheTTL\x18\" \x01(\x05H\x17R\x0esshJWTCacheTTL\x88\x01\x01\x12&\n" +
+ "\fdisable_ipv6\x18# \x01(\bH\x18R\vdisableIpv6\x88\x01\x01B\x13\n" +
"\x11_rosenpassEnabledB\x10\n" +
"\x0e_interfaceNameB\x10\n" +
"\x0e_wireguardPortB\x17\n" +
@@ -6597,7 +6643,8 @@ const file_daemon_proto_rawDesc = "" +
"\x1d_enableSSHLocalPortForwardingB \n" +
"\x1e_enableSSHRemotePortForwardingB\x11\n" +
"\x0f_disableSSHAuthB\x11\n" +
- "\x0f_sshJWTCacheTTL\"\x13\n" +
+ "\x0f_sshJWTCacheTTLB\x0f\n" +
+ "\r_disable_ipv6\"\x13\n" +
"\x11SetConfigResponse\"Q\n" +
"\x11AddProfileRequest\x12\x1a\n" +
"\busername\x18\x01 \x01(\tR\busername\x12 \n" +
diff --git a/client/proto/daemon.proto b/client/proto/daemon.proto
index 3fee9eca8..dedff43e2 100644
--- a/client/proto/daemon.proto
+++ b/client/proto/daemon.proto
@@ -204,6 +204,7 @@ message LoginRequest {
optional bool enableSSHRemotePortForwarding = 37;
optional bool disableSSHAuth = 38;
optional int32 sshJWTCacheTTL = 39;
+ optional bool disable_ipv6 = 40;
}
message LoginResponse {
@@ -311,6 +312,8 @@ message GetConfigResponse {
bool disableSSHAuth = 25;
int32 sshJWTCacheTTL = 26;
+
+ bool disable_ipv6 = 27;
}
// PeerState contains the latest state of a peer
@@ -333,6 +336,7 @@ message PeerState {
google.protobuf.Duration latency = 17;
string relayAddress = 18;
bytes sshHostKey = 19;
+ string ipv6 = 20;
}
// LocalPeerState contains the latest state of the local peer
@@ -344,6 +348,7 @@ message LocalPeerState {
bool rosenpassEnabled = 5;
bool rosenpassPermissive = 6;
repeated string networks = 7;
+ string ipv6 = 8;
}
// SignalState contains the latest state of a signal connection
@@ -672,6 +677,7 @@ message SetConfigRequest {
optional bool enableSSHRemotePortForwarding = 32;
optional bool disableSSHAuth = 33;
optional int32 sshJWTCacheTTL = 34;
+ optional bool disable_ipv6 = 35;
}
message SetConfigResponse{}
diff --git a/client/server/login_overrides_test.go b/client/server/login_overrides_test.go
new file mode 100644
index 000000000..c45557c59
--- /dev/null
+++ b/client/server/login_overrides_test.go
@@ -0,0 +1,93 @@
+package server
+
+import (
+ "path/filepath"
+ "testing"
+
+ "github.com/stretchr/testify/require"
+
+ "github.com/netbirdio/netbird/client/internal/profilemanager"
+)
+
+func TestPersistLoginOverrides(t *testing.T) {
+ strPtr := func(s string) *string { return &s }
+
+ tests := []struct {
+ name string
+ initialMgmtURL string
+ initialPSK string
+ newMgmtURL string
+ newPSK *string
+ wantMgmtURL string
+ wantPSK string
+ }{
+ {
+ name: "persist new management URL",
+ initialMgmtURL: "https://old.example.com:33073",
+ newMgmtURL: "https://new.example.com:33073",
+ wantMgmtURL: "https://new.example.com:33073",
+ },
+ {
+ name: "persist new pre-shared key",
+ initialMgmtURL: "https://existing.example.com:33073",
+ initialPSK: "old-key",
+ newPSK: strPtr("new-key"),
+ wantMgmtURL: "https://existing.example.com:33073",
+ wantPSK: "new-key",
+ },
+ {
+ name: "persist both",
+ initialMgmtURL: "https://old.example.com:33073",
+ initialPSK: "old-key",
+ newMgmtURL: "https://new.example.com:33073",
+ newPSK: strPtr("new-key"),
+ wantMgmtURL: "https://new.example.com:33073",
+ wantPSK: "new-key",
+ },
+ {
+ name: "no inputs preserves existing",
+ initialMgmtURL: "https://existing.example.com:33073",
+ initialPSK: "existing-key",
+ wantMgmtURL: "https://existing.example.com:33073",
+ wantPSK: "existing-key",
+ },
+ {
+ name: "empty PSK pointer is ignored",
+ initialMgmtURL: "https://existing.example.com:33073",
+ initialPSK: "existing-key",
+ newPSK: strPtr(""),
+ wantMgmtURL: "https://existing.example.com:33073",
+ wantPSK: "existing-key",
+ },
+ }
+
+ for _, tt := range tests {
+ t.Run(tt.name, func(t *testing.T) {
+ origDefault := profilemanager.DefaultConfigPath
+ t.Cleanup(func() { profilemanager.DefaultConfigPath = origDefault })
+
+ dir := t.TempDir()
+ profilemanager.DefaultConfigPath = filepath.Join(dir, "default.json")
+
+ seed := profilemanager.ConfigInput{
+ ConfigPath: profilemanager.DefaultConfigPath,
+ ManagementURL: tt.initialMgmtURL,
+ }
+ if tt.initialPSK != "" {
+ seed.PreSharedKey = strPtr(tt.initialPSK)
+ }
+ _, err := profilemanager.UpdateOrCreateConfig(seed)
+ require.NoError(t, err, "seed config")
+
+ activeProf := &profilemanager.ActiveProfileState{Name: "default"}
+ err = persistLoginOverrides(activeProf, tt.newMgmtURL, tt.newPSK)
+ require.NoError(t, err, "persistLoginOverrides")
+
+ cfg, err := profilemanager.ReadConfig(profilemanager.DefaultConfigPath)
+ require.NoError(t, err, "read back config")
+
+ require.Equal(t, tt.wantMgmtURL, cfg.ManagementURL.String(), "management URL")
+ require.Equal(t, tt.wantPSK, cfg.PreSharedKey, "pre-shared key")
+ })
+ }
+}
diff --git a/client/server/network.go b/client/server/network.go
index 76c5af40e..12cefbd9c 100644
--- a/client/server/network.go
+++ b/client/server/network.go
@@ -18,10 +18,11 @@ import (
)
type selectRoute struct {
- NetID route.NetID
- Network netip.Prefix
- Domains domain.List
- Selected bool
+ NetID route.NetID
+ Network netip.Prefix
+ Domains domain.List
+ Selected bool
+ extraNetworks []netip.Prefix
}
// ListNetworks returns a list of all available networks.
@@ -50,18 +51,32 @@ func (s *Server) ListNetworks(context.Context, *proto.ListNetworksRequest) (*pro
routesMap := routeMgr.GetClientRoutesWithNetID()
routeSelector := routeMgr.GetRouteSelector()
+ v6ExitMerged := route.V6ExitMergeSet(routesMap)
+
var routes []*selectRoute
for id, rt := range routesMap {
if len(rt) == 0 {
continue
}
- route := &selectRoute{
+ // Skip v6 exit nodes that are merged into their v4 counterpart.
+ if _, ok := v6ExitMerged[id]; ok {
+ continue
+ }
+
+ r := &selectRoute{
NetID: id,
Network: rt[0].Network,
Domains: rt[0].Domains,
Selected: routeSelector.IsSelected(id),
}
- routes = append(routes, route)
+
+ // Merge paired v6 exit node prefix into this entry.
+ v6ID := route.NetID(string(id) + route.V6ExitSuffix)
+ if _, ok := v6ExitMerged[v6ID]; ok && len(routesMap[v6ID]) > 0 {
+ r.extraNetworks = []netip.Prefix{routesMap[v6ID][0].Network}
+ }
+
+ routes = append(routes, r)
}
sort.Slice(routes, func(i, j int) bool {
@@ -82,9 +97,13 @@ func (s *Server) ListNetworks(context.Context, *proto.ListNetworksRequest) (*pro
resolvedDomains := s.statusRecorder.GetResolvedDomainsStates()
var pbRoutes []*proto.Network
for _, route := range routes {
+ rangeStr := route.Network.String()
+ for _, extra := range route.extraNetworks {
+ rangeStr += ", " + extra.String()
+ }
pbRoute := &proto.Network{
ID: string(route.NetID),
- Range: route.Network.String(),
+ Range: rangeStr,
Domains: route.Domains.ToSafeStringList(),
ResolvedIPs: map[string]*proto.IPList{},
Selected: route.Selected,
@@ -147,7 +166,9 @@ func (s *Server) SelectNetworks(_ context.Context, req *proto.SelectNetworksRequ
routeSelector.SelectAllRoutes()
} else {
routes := toNetIDs(req.GetNetworkIDs())
- netIdRoutes := maps.Keys(routeManager.GetClientRoutesWithNetID())
+ routesMap := routeManager.GetClientRoutesWithNetID()
+ routes = route.ExpandV6ExitPairs(routes, routesMap)
+ netIdRoutes := maps.Keys(routesMap)
if err := routeSelector.SelectRoutes(routes, req.GetAppend(), netIdRoutes); err != nil {
return nil, fmt.Errorf("select routes: %w", err)
}
@@ -197,7 +218,9 @@ func (s *Server) DeselectNetworks(_ context.Context, req *proto.SelectNetworksRe
routeSelector.DeselectAllRoutes()
} else {
routes := toNetIDs(req.GetNetworkIDs())
- netIdRoutes := maps.Keys(routeManager.GetClientRoutesWithNetID())
+ routesMap := routeManager.GetClientRoutesWithNetID()
+ routes = route.ExpandV6ExitPairs(routes, routesMap)
+ netIdRoutes := maps.Keys(routesMap)
if err := routeSelector.DeselectRoutes(routes, netIdRoutes); err != nil {
return nil, fmt.Errorf("deselect routes: %w", err)
}
diff --git a/client/server/server.go b/client/server/server.go
index 648ffa8ce..397fb37e4 100644
--- a/client/server/server.go
+++ b/client/server/server.go
@@ -385,6 +385,7 @@ func (s *Server) SetConfig(callerCtx context.Context, msg *proto.SetConfigReques
config.DisableNotifications = msg.DisableNotifications
config.LazyConnectionEnabled = msg.LazyConnectionEnabled
config.BlockInbound = msg.BlockInbound
+ config.DisableIPv6 = msg.DisableIpv6
config.EnableSSHRoot = msg.EnableSSHRoot
config.EnableSSHSFTP = msg.EnableSSHSFTP
config.EnableSSHLocalPortForwarding = msg.EnableSSHLocalPortForwarding
@@ -489,6 +490,11 @@ func (s *Server) Login(callerCtx context.Context, msg *proto.LoginRequest) (*pro
s.mutex.Unlock()
+ if err := persistLoginOverrides(activeProf, msg.ManagementUrl, msg.OptionalPreSharedKey); err != nil {
+ log.Errorf("failed to persist login overrides: %v", err)
+ return nil, fmt.Errorf("persist login overrides: %w", err)
+ }
+
config, _, err := s.getConfig(activeProf)
if err != nil {
log.Errorf("failed to get active profile config: %v", err)
@@ -963,7 +969,7 @@ func (s *Server) handleActiveProfileLogout(ctx context.Context) (*proto.LogoutRe
return &proto.LogoutResponse{}, nil
}
-// GetConfig reads config file and returns Config and whether the config file already existed. Errors out if it does not exist
+// getConfig reads config file and returns Config and whether the config file already existed. Errors out if it does not exist
func (s *Server) getConfig(activeProf *profilemanager.ActiveProfileState) (*profilemanager.Config, bool, error) {
cfgPath, err := activeProf.FilePath()
if err != nil {
@@ -1483,6 +1489,7 @@ func (s *Server) GetConfig(ctx context.Context, req *proto.GetConfigRequest) (*p
disableDNS := cfg.DisableDNS
disableClientRoutes := cfg.DisableClientRoutes
disableServerRoutes := cfg.DisableServerRoutes
+ disableIPv6 := cfg.DisableIPv6
blockLANAccess := cfg.BlockLANAccess
enableSSHRoot := false
@@ -1533,6 +1540,7 @@ func (s *Server) GetConfig(ctx context.Context, req *proto.GetConfigRequest) (*p
DisableDns: disableDNS,
DisableClientRoutes: disableClientRoutes,
DisableServerRoutes: disableServerRoutes,
+ DisableIpv6: disableIPv6,
BlockLanAccess: blockLANAccess,
EnableSSHRoot: enableSSHRoot,
EnableSSHSFTP: enableSSHSFTP,
@@ -1763,3 +1771,29 @@ func sendTerminalNotification() error {
return wallCmd.Wait()
}
+
+// persistLoginOverrides writes management URL and pre-shared key from a LoginRequest to the
+// active profile config so that subsequent reads pick them up. Empty/nil values are ignored.
+func persistLoginOverrides(activeProf *profilemanager.ActiveProfileState, managementURL string, preSharedKey *string) error {
+ if preSharedKey != nil && *preSharedKey == "" {
+ preSharedKey = nil
+ }
+ if managementURL == "" && preSharedKey == nil {
+ return nil
+ }
+
+ cfgPath, err := activeProf.FilePath()
+ if err != nil {
+ return fmt.Errorf("active profile file path: %w", err)
+ }
+
+ input := profilemanager.ConfigInput{
+ ConfigPath: cfgPath,
+ ManagementURL: managementURL,
+ PreSharedKey: preSharedKey,
+ }
+ if _, err := profilemanager.UpdateOrCreateConfig(input); err != nil {
+ return fmt.Errorf("update config: %w", err)
+ }
+ return nil
+}
diff --git a/client/server/setconfig_test.go b/client/server/setconfig_test.go
index b90b5653d..553d4ad71 100644
--- a/client/server/setconfig_test.go
+++ b/client/server/setconfig_test.go
@@ -71,6 +71,7 @@ func TestSetConfig_AllFieldsSaved(t *testing.T) {
disableNotifications := true
lazyConnectionEnabled := true
blockInbound := true
+ disableIPv6 := true
mtu := int64(1280)
sshJWTCacheTTL := int32(300)
@@ -95,6 +96,7 @@ func TestSetConfig_AllFieldsSaved(t *testing.T) {
DisableNotifications: &disableNotifications,
LazyConnectionEnabled: &lazyConnectionEnabled,
BlockInbound: &blockInbound,
+ DisableIpv6: &disableIPv6,
NatExternalIPs: []string{"1.2.3.4", "5.6.7.8"},
CleanNATExternalIPs: false,
CustomDNSAddress: []byte("1.1.1.1:53"),
@@ -140,6 +142,7 @@ func TestSetConfig_AllFieldsSaved(t *testing.T) {
require.Equal(t, disableNotifications, *cfg.DisableNotifications)
require.Equal(t, lazyConnectionEnabled, cfg.LazyConnectionEnabled)
require.Equal(t, blockInbound, cfg.BlockInbound)
+ require.Equal(t, disableIPv6, cfg.DisableIPv6)
require.Equal(t, []string{"1.2.3.4", "5.6.7.8"}, cfg.NATExternalIPs)
require.Equal(t, "1.1.1.1:53", cfg.CustomDNSAddress)
// IFaceBlackList contains defaults + extras
@@ -189,6 +192,7 @@ func verifyAllFieldsCovered(t *testing.T, req *proto.SetConfigRequest) {
"DisableNotifications": true,
"LazyConnectionEnabled": true,
"BlockInbound": true,
+ "DisableIpv6": true,
"NatExternalIPs": true,
"CustomDNSAddress": true,
"ExtraIFaceBlacklist": true,
@@ -247,6 +251,7 @@ func TestCLIFlags_MappedToSetConfig(t *testing.T) {
"disable-firewall": "DisableFirewall",
"block-lan-access": "BlockLanAccess",
"block-inbound": "BlockInbound",
+ "disable-ipv6": "DisableIpv6",
"enable-lazy-connection": "LazyConnectionEnabled",
"external-ip-map": "NatExternalIPs",
"dns-resolver-address": "CustomDNSAddress",
diff --git a/client/server/trace.go b/client/server/trace.go
index e4ac91487..7fea31c49 100644
--- a/client/server/trace.go
+++ b/client/server/trace.go
@@ -24,14 +24,9 @@ func (s *Server) TracePacket(_ context.Context, req *proto.TracePacketRequest) (
return nil, err
}
- srcAddr, err := s.parseAddress(req.GetSourceIp(), engine)
+ srcAddr, dstAddr, err := s.resolveTraceAddresses(req.GetSourceIp(), req.GetDestinationIp(), engine)
if err != nil {
- return nil, fmt.Errorf("invalid source IP address: %w", err)
- }
-
- dstAddr, err := s.parseAddress(req.GetDestinationIp(), engine)
- if err != nil {
- return nil, fmt.Errorf("invalid destination IP address: %w", err)
+ return nil, err
}
protocol, err := s.parseProtocol(req.GetProtocol())
@@ -89,16 +84,73 @@ func (s *Server) getPacketTracer() (packetTracer, *internal.Engine, error) {
return tracer, engine, nil
}
-func (s *Server) parseAddress(addr string, engine *internal.Engine) (netip.Addr, error) {
- if addr == "self" {
- return engine.GetWgAddr(), nil
+// resolveTraceAddresses parses src/dst, resolving "self" to the local overlay
+// address matching the peer's address family.
+func (s *Server) resolveTraceAddresses(src, dst string, engine *internal.Engine) (netip.Addr, netip.Addr, error) {
+ srcSelf := src == "self"
+ dstSelf := dst == "self"
+
+ if srcSelf && dstSelf {
+ return netip.Addr{}, netip.Addr{}, fmt.Errorf("both source and destination cannot be 'self'")
}
+ var srcAddr, dstAddr netip.Addr
+ var err error
+
+ // Parse the non-self address first so we know the family for self resolution.
+ if !srcSelf {
+ if srcAddr, err = parseAddr(src); err != nil {
+ return netip.Addr{}, netip.Addr{}, fmt.Errorf("invalid source IP: %w", err)
+ }
+ }
+ if !dstSelf {
+ if dstAddr, err = parseAddr(dst); err != nil {
+ return netip.Addr{}, netip.Addr{}, fmt.Errorf("invalid destination IP: %w", err)
+ }
+ }
+
+ // Determine the peer address to pick the right self address.
+ peer := srcAddr
+ if srcSelf {
+ peer = dstAddr
+ }
+
+ if srcSelf {
+ if srcAddr, err = selfAddr(engine, peer); err != nil {
+ return netip.Addr{}, netip.Addr{}, err
+ }
+ }
+ if dstSelf {
+ if dstAddr, err = selfAddr(engine, peer); err != nil {
+ return netip.Addr{}, netip.Addr{}, err
+ }
+ }
+
+ return srcAddr, dstAddr, nil
+}
+
+func selfAddr(engine *internal.Engine, peer netip.Addr) (netip.Addr, error) {
+ var addr netip.Addr
+ if peer.Is6() {
+ addr = engine.GetWgV6Addr()
+ } else {
+ addr = engine.GetWgAddr()
+ }
+ if !addr.IsValid() {
+ family := "IPv4"
+ if peer.Is6() {
+ family = "IPv6"
+ }
+ return netip.Addr{}, fmt.Errorf("no local %s overlay address configured", family)
+ }
+ return addr, nil
+}
+
+func parseAddr(addr string) (netip.Addr, error) {
a, err := netip.ParseAddr(addr)
if err != nil {
return netip.Addr{}, err
}
-
return a.Unmap(), nil
}
diff --git a/client/ssh/client/client.go b/client/ssh/client/client.go
index 7f72a72cf..ebf8eb794 100644
--- a/client/ssh/client/client.go
+++ b/client/ssh/client/client.go
@@ -25,6 +25,7 @@ import (
nbssh "github.com/netbirdio/netbird/client/ssh"
"github.com/netbirdio/netbird/client/ssh/detection"
"github.com/netbirdio/netbird/util"
+ "github.com/netbirdio/netbird/util/netrelay"
)
const (
@@ -536,7 +537,7 @@ func (c *Client) LocalPortForward(ctx context.Context, localAddr, remoteAddr str
continue
}
- go c.handleLocalForward(localConn, remoteAddr)
+ go c.handleLocalForward(ctx, localConn, remoteAddr)
}
}()
@@ -548,7 +549,7 @@ func (c *Client) LocalPortForward(ctx context.Context, localAddr, remoteAddr str
}
// handleLocalForward handles a single local port forwarding connection
-func (c *Client) handleLocalForward(localConn net.Conn, remoteAddr string) {
+func (c *Client) handleLocalForward(ctx context.Context, localConn net.Conn, remoteAddr string) {
defer func() {
if err := localConn.Close(); err != nil {
log.Debugf("local port forwarding: close local connection: %v", err)
@@ -571,7 +572,7 @@ func (c *Client) handleLocalForward(localConn net.Conn, remoteAddr string) {
}
}()
- nbssh.BidirectionalCopy(log.NewEntry(log.StandardLogger()), localConn, channel)
+ netrelay.Relay(ctx, localConn, channel, netrelay.Options{Logger: log.NewEntry(log.StandardLogger())})
}
// RemotePortForward sets up remote port forwarding, binding on remote and forwarding to localAddr
@@ -653,16 +654,19 @@ func (c *Client) handleRemoteForwardChannels(ctx context.Context, localAddr stri
select {
case <-ctx.Done():
return
- case newChan := <-channelRequests:
+ case newChan, ok := <-channelRequests:
+ if !ok {
+ return
+ }
if newChan != nil {
- go c.handleRemoteForwardChannel(newChan, localAddr)
+ go c.handleRemoteForwardChannel(ctx, newChan, localAddr)
}
}
}
}
// handleRemoteForwardChannel handles a single forwarded-tcpip channel
-func (c *Client) handleRemoteForwardChannel(newChan ssh.NewChannel, localAddr string) {
+func (c *Client) handleRemoteForwardChannel(ctx context.Context, newChan ssh.NewChannel, localAddr string) {
channel, reqs, err := newChan.Accept()
if err != nil {
return
@@ -675,8 +679,14 @@ func (c *Client) handleRemoteForwardChannel(newChan ssh.NewChannel, localAddr st
go ssh.DiscardRequests(reqs)
- localConn, err := net.Dial("tcp", localAddr)
+ // Bound the dial so a black-holed localAddr can't pin the accepted SSH
+ // channel open indefinitely; the relay itself runs under the outer ctx.
+ dialCtx, cancelDial := context.WithTimeout(ctx, 10*time.Second)
+ var dialer net.Dialer
+ localConn, err := dialer.DialContext(dialCtx, "tcp", localAddr)
+ cancelDial()
if err != nil {
+ log.Debugf("remote port forwarding: dial %s: %v", localAddr, err)
return
}
defer func() {
@@ -685,7 +695,7 @@ func (c *Client) handleRemoteForwardChannel(newChan ssh.NewChannel, localAddr st
}
}()
- nbssh.BidirectionalCopy(log.NewEntry(log.StandardLogger()), localConn, channel)
+ netrelay.Relay(ctx, localConn, channel, netrelay.Options{Logger: log.NewEntry(log.StandardLogger())})
}
// tcpipForwardMsg represents the structure for tcpip-forward requests
diff --git a/client/ssh/common.go b/client/ssh/common.go
index f6aec5f9c..92e647b7d 100644
--- a/client/ssh/common.go
+++ b/client/ssh/common.go
@@ -194,63 +194,3 @@ func buildAddressList(hostname string, remote net.Addr) []string {
return addresses
}
-// BidirectionalCopy copies data bidirectionally between two io.ReadWriter connections.
-// It waits for both directions to complete before returning.
-// The caller is responsible for closing the connections.
-func BidirectionalCopy(logger *log.Entry, rw1, rw2 io.ReadWriter) {
- done := make(chan struct{}, 2)
-
- go func() {
- if _, err := io.Copy(rw2, rw1); err != nil && !isExpectedCopyError(err) {
- logger.Debugf("copy error (1->2): %v", err)
- }
- done <- struct{}{}
- }()
-
- go func() {
- if _, err := io.Copy(rw1, rw2); err != nil && !isExpectedCopyError(err) {
- logger.Debugf("copy error (2->1): %v", err)
- }
- done <- struct{}{}
- }()
-
- <-done
- <-done
-}
-
-func isExpectedCopyError(err error) bool {
- return errors.Is(err, io.EOF) || errors.Is(err, context.Canceled)
-}
-
-// BidirectionalCopyWithContext copies data bidirectionally between two io.ReadWriteCloser connections.
-// It waits for both directions to complete or for context cancellation before returning.
-// Both connections are closed when the function returns.
-func BidirectionalCopyWithContext(logger *log.Entry, ctx context.Context, conn1, conn2 io.ReadWriteCloser) {
- done := make(chan struct{}, 2)
-
- go func() {
- if _, err := io.Copy(conn2, conn1); err != nil && !isExpectedCopyError(err) {
- logger.Debugf("copy error (1->2): %v", err)
- }
- done <- struct{}{}
- }()
-
- go func() {
- if _, err := io.Copy(conn1, conn2); err != nil && !isExpectedCopyError(err) {
- logger.Debugf("copy error (2->1): %v", err)
- }
- done <- struct{}{}
- }()
-
- select {
- case <-ctx.Done():
- case <-done:
- select {
- case <-ctx.Done():
- case <-done:
- }
- }
-
- _ = conn1.Close()
- _ = conn2.Close()
-}
diff --git a/client/ssh/config/manager.go b/client/ssh/config/manager.go
index 5d69fd35c..20695cb4d 100644
--- a/client/ssh/config/manager.go
+++ b/client/ssh/config/manager.go
@@ -3,6 +3,7 @@ package config
import (
"context"
"fmt"
+ "net/netip"
"os"
"path/filepath"
"runtime"
@@ -91,7 +92,8 @@ type Manager struct {
// PeerSSHInfo represents a peer's SSH configuration information
type PeerSSHInfo struct {
Hostname string
- IP string
+ IP netip.Addr
+ IPv6 netip.Addr
FQDN string
}
@@ -210,8 +212,11 @@ func (m *Manager) buildPeerConfig(allHostPatterns []string) (string, error) {
func (m *Manager) buildHostPatterns(peer PeerSSHInfo) []string {
var hostPatterns []string
- if peer.IP != "" {
- hostPatterns = append(hostPatterns, peer.IP)
+ if peer.IP.IsValid() {
+ hostPatterns = append(hostPatterns, peer.IP.String())
+ }
+ if peer.IPv6.IsValid() {
+ hostPatterns = append(hostPatterns, peer.IPv6.String())
}
if peer.FQDN != "" {
hostPatterns = append(hostPatterns, peer.FQDN)
@@ -224,18 +229,35 @@ func (m *Manager) buildHostPatterns(peer PeerSSHInfo) []string {
func (m *Manager) writeSSHConfig(sshConfig string) error {
sshConfigPath := filepath.Join(m.sshConfigDir, m.sshConfigFile)
- sshConfigPathTmp := sshConfigPath + ".tmp"
if err := os.MkdirAll(m.sshConfigDir, 0755); err != nil {
return fmt.Errorf("create SSH config directory %s: %w", m.sshConfigDir, err)
}
- if err := writeFileWithTimeout(sshConfigPathTmp, []byte(sshConfig), 0644); err != nil {
- return fmt.Errorf("write SSH config file %s: %w", sshConfigPath, err)
+ tmp, err := os.CreateTemp(m.sshConfigDir, m.sshConfigFile+".*.tmp")
+ if err != nil {
+ return fmt.Errorf("create temp SSH config: %w", err)
+ }
+ tmpPath := tmp.Name()
+ defer func() {
+ if err := os.Remove(tmpPath); err != nil && !os.IsNotExist(err) {
+ log.Debugf("remove temp SSH config %s: %v", tmpPath, err)
+ }
+ }()
+ if err := tmp.Close(); err != nil {
+ return fmt.Errorf("close temp SSH config %s: %w", tmpPath, err)
}
- if err := os.Rename(sshConfigPathTmp, sshConfigPath); err != nil {
- return fmt.Errorf("rename ssh config %s -> %s: %w", sshConfigPathTmp, sshConfigPath, err)
+ if err := writeFileWithTimeout(tmpPath, []byte(sshConfig), 0644); err != nil {
+ return fmt.Errorf("write SSH config file %s: %w", tmpPath, err)
+ }
+
+ if err := os.Chmod(tmpPath, 0644); err != nil {
+ return fmt.Errorf("chmod SSH config file %s: %w", tmpPath, err)
+ }
+
+ if err := os.Rename(tmpPath, sshConfigPath); err != nil {
+ return fmt.Errorf("rename SSH config %s -> %s: %w", tmpPath, sshConfigPath, err)
}
log.Infof("Created NetBird SSH client config: %s", sshConfigPath)
diff --git a/client/ssh/config/manager_test.go b/client/ssh/config/manager_test.go
index e7380c7f2..8e6be40a3 100644
--- a/client/ssh/config/manager_test.go
+++ b/client/ssh/config/manager_test.go
@@ -2,6 +2,7 @@ package config
import (
"fmt"
+ "net/netip"
"os"
"path/filepath"
"runtime"
@@ -28,12 +29,12 @@ func TestManager_SetupSSHClientConfig(t *testing.T) {
peers := []PeerSSHInfo{
{
Hostname: "peer1",
- IP: "100.125.1.1",
+ IP: netip.MustParseAddr("100.125.1.1"),
FQDN: "peer1.nb.internal",
},
{
Hostname: "peer2",
- IP: "100.125.1.2",
+ IP: netip.MustParseAddr("100.125.1.2"),
FQDN: "peer2.nb.internal",
},
}
@@ -101,7 +102,7 @@ func TestManager_PeerLimit(t *testing.T) {
for i := 0; i < MaxPeersForSSHConfig+10; i++ {
peers = append(peers, PeerSSHInfo{
Hostname: fmt.Sprintf("peer%d", i),
- IP: fmt.Sprintf("100.125.1.%d", i%254+1),
+ IP: netip.MustParseAddr(fmt.Sprintf("100.125.1.%d", i%254+1)),
FQDN: fmt.Sprintf("peer%d.nb.internal", i),
})
}
@@ -127,8 +128,8 @@ func TestManager_MatchHostFormat(t *testing.T) {
}
peers := []PeerSSHInfo{
- {Hostname: "peer1", IP: "100.125.1.1", FQDN: "peer1.nb.internal"},
- {Hostname: "peer2", IP: "100.125.1.2", FQDN: "peer2.nb.internal"},
+ {Hostname: "peer1", IP: netip.MustParseAddr("100.125.1.1"), FQDN: "peer1.nb.internal"},
+ {Hostname: "peer2", IP: netip.MustParseAddr("100.125.1.2"), FQDN: "peer2.nb.internal"},
}
err = manager.SetupSSHClientConfig(peers)
@@ -167,7 +168,7 @@ func TestManager_ForcedSSHConfig(t *testing.T) {
for i := 0; i < MaxPeersForSSHConfig+10; i++ {
peers = append(peers, PeerSSHInfo{
Hostname: fmt.Sprintf("peer%d", i),
- IP: fmt.Sprintf("100.125.1.%d", i%254+1),
+ IP: netip.MustParseAddr(fmt.Sprintf("100.125.1.%d", i%254+1)),
FQDN: fmt.Sprintf("peer%d.nb.internal", i),
})
}
diff --git a/client/ssh/proxy/proxy.go b/client/ssh/proxy/proxy.go
index 59007f75c..73b50122c 100644
--- a/client/ssh/proxy/proxy.go
+++ b/client/ssh/proxy/proxy.go
@@ -23,6 +23,7 @@ import (
"github.com/netbirdio/netbird/client/proto"
nbssh "github.com/netbirdio/netbird/client/ssh"
"github.com/netbirdio/netbird/client/ssh/detection"
+ "github.com/netbirdio/netbird/util/netrelay"
"github.com/netbirdio/netbird/version"
)
@@ -321,7 +322,7 @@ func (p *SSHProxy) directTCPIPHandler(_ *ssh.Server, _ *cryptossh.ServerConn, ne
return
}
- dest := fmt.Sprintf("%s:%d", payload.DestAddr, payload.DestPort)
+ dest := net.JoinHostPort(payload.DestAddr, strconv.Itoa(int(payload.DestPort)))
log.Debugf("local port forwarding: %s", dest)
backendClient, err := p.getOrCreateBackendClient(sshCtx, sshCtx.User())
@@ -352,7 +353,7 @@ func (p *SSHProxy) directTCPIPHandler(_ *ssh.Server, _ *cryptossh.ServerConn, ne
}
go cryptossh.DiscardRequests(clientReqs)
- nbssh.BidirectionalCopyWithContext(log.NewEntry(log.StandardLogger()), sshCtx, clientChan, backendChan)
+ netrelay.Relay(sshCtx, clientChan, backendChan, netrelay.Options{Logger: log.NewEntry(log.StandardLogger())})
}
func (p *SSHProxy) sftpSubsystemHandler(s ssh.Session, jwtToken string) {
@@ -591,7 +592,7 @@ func (p *SSHProxy) handleForwardedChannel(sshCtx ssh.Context, sshConn *cryptossh
}
go cryptossh.DiscardRequests(clientReqs)
- nbssh.BidirectionalCopyWithContext(log.NewEntry(log.StandardLogger()), sshCtx, clientChan, backendChan)
+ netrelay.Relay(sshCtx, clientChan, backendChan, netrelay.Options{Logger: log.NewEntry(log.StandardLogger())})
}
func (p *SSHProxy) dialBackend(ctx context.Context, addr, user, jwtToken string) (*cryptossh.Client, error) {
diff --git a/client/ssh/server/port_forwarding.go b/client/ssh/server/port_forwarding.go
index e16ff5d46..a47fdb48a 100644
--- a/client/ssh/server/port_forwarding.go
+++ b/client/ssh/server/port_forwarding.go
@@ -17,7 +17,7 @@ import (
log "github.com/sirupsen/logrus"
cryptossh "golang.org/x/crypto/ssh"
- nbssh "github.com/netbirdio/netbird/client/ssh"
+ "github.com/netbirdio/netbird/util/netrelay"
)
const privilegedPortThreshold = 1024
@@ -56,12 +56,12 @@ func (s *Server) configurePortForwarding(server *ssh.Server) {
server.LocalPortForwardingCallback = func(ctx ssh.Context, dstHost string, dstPort uint32) bool {
logger := s.getRequestLogger(ctx)
if !allowLocal {
- logger.Warnf("local port forwarding denied for %s:%d: disabled", dstHost, dstPort)
+ logger.Warnf("local port forwarding denied for %s: disabled", net.JoinHostPort(dstHost, strconv.Itoa(int(dstPort))))
return false
}
if err := s.checkPortForwardingPrivileges(ctx, "local", dstPort); err != nil {
- logger.Warnf("local port forwarding denied for %s:%d: %v", dstHost, dstPort, err)
+ logger.Warnf("local port forwarding denied for %s: %v", net.JoinHostPort(dstHost, strconv.Itoa(int(dstPort))), err)
return false
}
@@ -71,12 +71,12 @@ func (s *Server) configurePortForwarding(server *ssh.Server) {
server.ReversePortForwardingCallback = func(ctx ssh.Context, bindHost string, bindPort uint32) bool {
logger := s.getRequestLogger(ctx)
if !allowRemote {
- logger.Warnf("remote port forwarding denied for %s:%d: disabled", bindHost, bindPort)
+ logger.Warnf("remote port forwarding denied for %s: disabled", net.JoinHostPort(bindHost, strconv.Itoa(int(bindPort))))
return false
}
if err := s.checkPortForwardingPrivileges(ctx, "remote", bindPort); err != nil {
- logger.Warnf("remote port forwarding denied for %s:%d: %v", bindHost, bindPort, err)
+ logger.Warnf("remote port forwarding denied for %s: %v", net.JoinHostPort(bindHost, strconv.Itoa(int(bindPort))), err)
return false
}
@@ -183,15 +183,16 @@ func (s *Server) cancelTcpipForwardHandler(ctx ssh.Context, _ *ssh.Server, req *
return false, nil
}
- key := forwardKey(fmt.Sprintf("%s:%d", payload.Host, payload.Port))
+ hostPort := net.JoinHostPort(payload.Host, strconv.Itoa(int(payload.Port)))
+ key := forwardKey(hostPort)
if s.removeRemoteForwardListener(key) {
- forwardAddr := fmt.Sprintf("-R %s:%d", payload.Host, payload.Port)
+ forwardAddr := "-R " + hostPort
s.removeConnectionPortForward(ctx.RemoteAddr(), forwardAddr)
- logger.Infof("remote port forwarding cancelled: %s:%d", payload.Host, payload.Port)
+ logger.Infof("remote port forwarding cancelled: %s", hostPort)
return true, nil
}
- logger.Warnf("cancel-tcpip-forward failed: no listener found for %s:%d", payload.Host, payload.Port)
+ logger.Warnf("cancel-tcpip-forward failed: no listener found for %s", net.JoinHostPort(payload.Host, strconv.Itoa(int(payload.Port))))
return false, nil
}
@@ -201,7 +202,7 @@ func (s *Server) handleRemoteForwardListener(ctx ssh.Context, ln net.Listener, h
defer func() {
if err := ln.Close(); err != nil {
- logger.Debugf("remote forward listener close error for %s:%d: %v", host, port, err)
+ logger.Debugf("remote forward listener close error for %s: %v", net.JoinHostPort(host, strconv.Itoa(int(port))), err)
}
}()
@@ -230,7 +231,7 @@ func (s *Server) handleRemoteForwardListener(ctx ssh.Context, ln net.Listener, h
}
go s.handleRemoteForwardConnection(ctx, result.conn, host, port)
case <-ctx.Done():
- logger.Debugf("remote forward listener shutting down for %s:%d", host, port)
+ logger.Debugf("remote forward listener shutting down for %s", net.JoinHostPort(host, strconv.Itoa(int(port))))
return
}
}
@@ -311,17 +312,17 @@ func (s *Server) setupDirectForward(ctx ssh.Context, logger *log.Entry, sshConn
logger.Debugf("tcpip-forward allocated port %d for %s", actualPort, payload.Host)
}
- key := forwardKey(fmt.Sprintf("%s:%d", payload.Host, payload.Port))
+ key := forwardKey(net.JoinHostPort(payload.Host, strconv.Itoa(int(payload.Port))))
s.storeRemoteForwardListener(key, ln)
- forwardAddr := fmt.Sprintf("-R %s:%d", payload.Host, actualPort)
+ forwardAddr := "-R " + net.JoinHostPort(payload.Host, strconv.Itoa(int(actualPort)))
s.addConnectionPortForward(ctx.User(), ctx.RemoteAddr(), forwardAddr)
go s.handleRemoteForwardListener(ctx, ln, payload.Host, actualPort)
response := make([]byte, 4)
binary.BigEndian.PutUint32(response, actualPort)
- logger.Infof("remote port forwarding established: %s:%d", payload.Host, actualPort)
+ logger.Infof("remote port forwarding established: %s", net.JoinHostPort(payload.Host, strconv.Itoa(int(actualPort))))
return true, response
}
@@ -351,12 +352,12 @@ func (s *Server) handleRemoteForwardConnection(ctx ssh.Context, conn net.Conn, h
channel, err := s.openForwardChannel(sshConn, host, port, remoteAddr)
if err != nil {
- logger.Debugf("open forward channel for %s:%d: %v", host, port, err)
+ logger.Debugf("open forward channel for %s: %v", net.JoinHostPort(host, strconv.Itoa(int(port))), err)
_ = conn.Close()
return
}
- nbssh.BidirectionalCopyWithContext(logger, ctx, conn, channel)
+ netrelay.Relay(ctx, conn, channel, netrelay.Options{Logger: logger})
}
// openForwardChannel creates an SSH forwarded-tcpip channel
diff --git a/client/ssh/server/server.go b/client/ssh/server/server.go
index 82d3b700f..6735e0f3b 100644
--- a/client/ssh/server/server.go
+++ b/client/ssh/server/server.go
@@ -10,6 +10,7 @@ import (
"net"
"net/netip"
"slices"
+ "strconv"
"strings"
"sync"
"time"
@@ -26,6 +27,7 @@ import (
"github.com/netbirdio/netbird/client/ssh/detection"
"github.com/netbirdio/netbird/shared/auth"
"github.com/netbirdio/netbird/shared/auth/jwt"
+ "github.com/netbirdio/netbird/util/netrelay"
"github.com/netbirdio/netbird/version"
)
@@ -52,6 +54,10 @@ const (
DefaultJWTMaxTokenAge = 10 * 60
)
+// directTCPIPDialTimeout bounds how long relayDirectTCPIP waits on a dial to
+// the forwarded destination before rejecting the SSH channel.
+const directTCPIPDialTimeout = 30 * time.Second
+
var (
ErrPrivilegedUserDisabled = errors.New(msgPrivilegedUserDisabled)
ErrUserNotFound = errors.New("user not found")
@@ -137,10 +143,11 @@ type sessionState struct {
}
type Server struct {
- sshServer *ssh.Server
- listener net.Listener
- mu sync.RWMutex
- hostKeyPEM []byte
+ sshServer *ssh.Server
+ listener net.Listener
+ extraListeners []net.Listener
+ mu sync.RWMutex
+ hostKeyPEM []byte
// sessions tracks active SSH sessions (shell, command, SFTP).
// These are created when a client opens a session channel and requests shell/exec/subsystem.
@@ -254,6 +261,35 @@ func (s *Server) Start(ctx context.Context, addr netip.AddrPort) error {
return nil
}
+// AddListener starts serving SSH on an additional address (e.g. IPv6).
+// Must be called after Start.
+func (s *Server) AddListener(ctx context.Context, addr netip.AddrPort) error {
+ s.mu.Lock()
+ srv := s.sshServer
+ if srv == nil {
+ s.mu.Unlock()
+ return errors.New("SSH server is not running")
+ }
+
+ ln, addrDesc, err := s.createListener(ctx, addr)
+ if err != nil {
+ s.mu.Unlock()
+ return fmt.Errorf("create listener: %w", err)
+ }
+
+ s.extraListeners = append(s.extraListeners, ln)
+ s.mu.Unlock()
+
+ log.Infof("SSH server also listening on %s", addrDesc)
+
+ go func() {
+ if err := srv.Serve(ln); err != nil && !errors.Is(err, ssh.ErrServerClosed) {
+ log.Errorf("SSH server error on %s: %v", addrDesc, err)
+ }
+ }()
+ return nil
+}
+
func (s *Server) createListener(ctx context.Context, addr netip.AddrPort) (net.Listener, string, error) {
if s.netstackNet != nil {
ln, err := s.netstackNet.ListenTCPAddrPort(addr)
@@ -291,6 +327,8 @@ func (s *Server) Stop() error {
}
s.sshServer = nil
s.listener = nil
+ extraListeners := s.extraListeners
+ s.extraListeners = nil
s.mu.Unlock()
// Close outside the lock: session handlers need s.mu for unregisterSession.
@@ -298,6 +336,12 @@ func (s *Server) Stop() error {
log.Debugf("close SSH server: %v", err)
}
+ for _, ln := range extraListeners {
+ if err := ln.Close(); err != nil {
+ log.Debugf("close extra SSH listener: %v", err)
+ }
+ }
+
s.mu.Lock()
maps.Clear(s.sessions)
maps.Clear(s.pendingAuthJWT)
@@ -749,11 +793,10 @@ func (s *Server) findSessionKeyByContext(ctx ssh.Context) sessionKey {
func (s *Server) connectionValidator(_ ssh.Context, conn net.Conn) net.Conn {
s.mu.RLock()
- netbirdNetwork := s.wgAddress.Network
- localIP := s.wgAddress.IP
+ wgAddr := s.wgAddress
s.mu.RUnlock()
- if !netbirdNetwork.IsValid() || !localIP.IsValid() {
+ if !wgAddr.Network.IsValid() || !wgAddr.IP.IsValid() {
return conn
}
@@ -769,14 +812,17 @@ func (s *Server) connectionValidator(_ ssh.Context, conn net.Conn) net.Conn {
log.Warnf("SSH connection rejected: invalid remote IP %s", tcpAddr.IP)
return nil
}
+ remoteIP = remoteIP.Unmap()
// Block connections from our own IP (prevent local apps from connecting to ourselves)
- if remoteIP == localIP {
+ if remoteIP == wgAddr.IP || wgAddr.IPv6.IsValid() && remoteIP == wgAddr.IPv6 {
log.Warnf("SSH connection rejected from own IP %s", remoteIP)
return nil
}
- if !netbirdNetwork.Contains(remoteIP) {
+ inV4 := wgAddr.Network.Contains(remoteIP)
+ inV6 := wgAddr.IPv6Net.IsValid() && wgAddr.IPv6Net.Contains(remoteIP)
+ if !inV4 && !inV6 {
log.Warnf("SSH connection rejected from non-NetBird IP %s", remoteIP)
return nil
}
@@ -876,20 +922,45 @@ func (s *Server) directTCPIPHandler(srv *ssh.Server, conn *cryptossh.ServerConn,
s.mu.RUnlock()
if !allowLocal {
- logger.Warnf("local port forwarding denied for %s:%d: disabled", payload.Host, payload.Port)
+ logger.Warnf("local port forwarding denied for %s: disabled", net.JoinHostPort(payload.Host, strconv.Itoa(int(payload.Port))))
_ = newChan.Reject(cryptossh.Prohibited, "local port forwarding disabled")
return
}
if err := s.checkPortForwardingPrivileges(ctx, "local", payload.Port); err != nil {
- logger.Warnf("local port forwarding denied for %s:%d: %v", payload.Host, payload.Port, err)
+ logger.Warnf("local port forwarding denied for %s: %v", net.JoinHostPort(payload.Host, strconv.Itoa(int(payload.Port))), err)
_ = newChan.Reject(cryptossh.Prohibited, "insufficient privileges")
return
}
- forwardAddr := fmt.Sprintf("-L %s:%d", payload.Host, payload.Port)
+ hostPort := net.JoinHostPort(payload.Host, strconv.Itoa(int(payload.Port)))
+ forwardAddr := "-L " + hostPort
s.addConnectionPortForward(ctx.User(), ctx.RemoteAddr(), forwardAddr)
- logger.Infof("local port forwarding: %s:%d", payload.Host, payload.Port)
+ logger.Infof("local port forwarding: %s", hostPort)
- ssh.DirectTCPIPHandler(srv, conn, newChan, ctx)
+ s.relayDirectTCPIP(ctx, newChan, payload.Host, int(payload.Port), logger)
+}
+
+// relayDirectTCPIP is a netrelay-based replacement for gliderlabs'
+// DirectTCPIPHandler. The upstream handler closes both sides on the first
+// EOF; netrelay.Relay propagates CloseWrite so each direction drains on its
+// own terms.
+func (s *Server) relayDirectTCPIP(ctx ssh.Context, newChan cryptossh.NewChannel, host string, port int, logger *log.Entry) {
+ dest := net.JoinHostPort(host, strconv.Itoa(port))
+
+ dialer := net.Dialer{Timeout: directTCPIPDialTimeout}
+ dconn, err := dialer.DialContext(ctx, "tcp", dest)
+ if err != nil {
+ _ = newChan.Reject(cryptossh.ConnectionFailed, err.Error())
+ return
+ }
+
+ ch, reqs, err := newChan.Accept()
+ if err != nil {
+ _ = dconn.Close()
+ return
+ }
+ go cryptossh.DiscardRequests(reqs)
+
+ netrelay.Relay(ctx, dconn, ch, netrelay.Options{Logger: logger})
}
diff --git a/client/status/status.go b/client/status/status.go
index 8c932bbab..11ed06c2d 100644
--- a/client/status/status.go
+++ b/client/status/status.go
@@ -60,6 +60,7 @@ type ConvertOptions struct {
type PeerStateDetailOutput struct {
FQDN string `json:"fqdn" yaml:"fqdn"`
IP string `json:"netbirdIp" yaml:"netbirdIp"`
+ IPv6 string `json:"netbirdIpv6,omitempty" yaml:"netbirdIpv6,omitempty"`
PubKey string `json:"publicKey" yaml:"publicKey"`
Status string `json:"status" yaml:"status"`
LastStatusUpdate time.Time `json:"lastStatusUpdate" yaml:"lastStatusUpdate"`
@@ -139,6 +140,7 @@ type OutputOverview struct {
SignalState SignalStateOutput `json:"signal" yaml:"signal"`
Relays RelayStateOutput `json:"relays" yaml:"relays"`
IP string `json:"netbirdIp" yaml:"netbirdIp"`
+ IPv6 string `json:"netbirdIpv6,omitempty" yaml:"netbirdIpv6,omitempty"`
PubKey string `json:"publicKey" yaml:"publicKey"`
KernelInterface bool `json:"usesKernelInterface" yaml:"usesKernelInterface"`
FQDN string `json:"fqdn" yaml:"fqdn"`
@@ -182,6 +184,7 @@ func ConvertToStatusOutputOverview(pbFullStatus *proto.FullStatus, opts ConvertO
SignalState: signalOverview,
Relays: relayOverview,
IP: pbFullStatus.GetLocalPeerState().GetIP(),
+ IPv6: pbFullStatus.GetLocalPeerState().GetIpv6(),
PubKey: pbFullStatus.GetLocalPeerState().GetPubKey(),
KernelInterface: pbFullStatus.GetLocalPeerState().GetKernelInterface(),
FQDN: pbFullStatus.GetLocalPeerState().GetFqdn(),
@@ -317,6 +320,7 @@ func mapPeers(
timeLocal := pbPeerState.GetConnStatusUpdate().AsTime().Local()
peerState := PeerStateDetailOutput{
IP: pbPeerState.GetIP(),
+ IPv6: pbPeerState.GetIpv6(),
PubKey: pbPeerState.GetPubKey(),
Status: pbPeerState.GetConnStatus(),
LastStatusUpdate: timeLocal,
@@ -417,6 +421,11 @@ func (o *OutputOverview) GeneralSummary(showURL bool, showRelays bool, showNameS
interfaceIP = "N/A"
}
+ ipv6Line := ""
+ if o.IPv6 != "" {
+ ipv6Line = fmt.Sprintf("NetBird IPv6: %s\n", o.IPv6)
+ }
+
var relaysString string
if showRelays {
for _, relay := range o.Relays.Details {
@@ -549,6 +558,7 @@ func (o *OutputOverview) GeneralSummary(showURL bool, showRelays bool, showNameS
"Nameservers: %s\n"+
"FQDN: %s\n"+
"NetBird IP: %s\n"+
+ "%s"+
"Interface type: %s\n"+
"Quantum resistance: %s\n"+
"Lazy connection: %s\n"+
@@ -566,6 +576,7 @@ func (o *OutputOverview) GeneralSummary(showURL bool, showRelays bool, showNameS
dnsServersString,
domain.Domain(o.FQDN).SafeString(),
interfaceIP,
+ ipv6Line,
interfaceTypeString,
rosenpassEnabledStatus,
lazyConnectionEnabledStatus,
@@ -616,6 +627,7 @@ func ToProtoFullStatus(fullStatus peer.FullStatus) *proto.FullStatus {
}
pbFullStatus.LocalPeerState.IP = fullStatus.LocalPeerState.IP
+ pbFullStatus.LocalPeerState.Ipv6 = fullStatus.LocalPeerState.IPv6
pbFullStatus.LocalPeerState.PubKey = fullStatus.LocalPeerState.PubKey
pbFullStatus.LocalPeerState.KernelInterface = fullStatus.LocalPeerState.KernelInterface
pbFullStatus.LocalPeerState.Fqdn = fullStatus.LocalPeerState.FQDN
@@ -628,6 +640,7 @@ func ToProtoFullStatus(fullStatus peer.FullStatus) *proto.FullStatus {
for _, peerState := range fullStatus.Peers {
pbPeerState := &proto.PeerState{
IP: peerState.IP,
+ Ipv6: peerState.IPv6,
PubKey: peerState.PubKey,
ConnStatus: peerState.ConnStatus.String(),
ConnStatusUpdate: timestamppb.New(peerState.ConnStatusUpdate),
@@ -733,9 +746,15 @@ func parsePeers(peers PeersStateOutput, rosenpassEnabled, rosenpassPermissive bo
networks = strings.Join(peerState.Networks, ", ")
}
+ ipv6Line := ""
+ if peerState.IPv6 != "" {
+ ipv6Line = fmt.Sprintf(" NetBird IPv6: %s\n", peerState.IPv6)
+ }
+
peerString := fmt.Sprintf(
"\n %s:\n"+
" NetBird IP: %s\n"+
+ "%s"+
" Public key: %s\n"+
" Status: %s\n"+
" -- detail --\n"+
@@ -751,6 +770,7 @@ func parsePeers(peers PeersStateOutput, rosenpassEnabled, rosenpassPermissive bo
" Latency: %s\n",
domain.Domain(peerState.FQDN).SafeString(),
peerState.IP,
+ ipv6Line,
peerState.PubKey,
peerState.Status,
peerState.ConnType,
@@ -787,6 +807,9 @@ func skipDetailByFilters(peerState *proto.PeerState, peerStatus string, statusFi
if len(ipsFilter) > 0 {
_, ok := ipsFilter[peerState.IP]
+ if !ok {
+ _, ok = ipsFilter[peerState.Ipv6]
+ }
if !ok {
ipEval = true
}
@@ -905,6 +928,7 @@ func anonymizePeerDetail(a *anonymize.Anonymizer, peer *PeerStateDetailOutput) {
peer.IceCandidateEndpoint.Remote = fmt.Sprintf("%s:%s", a.AnonymizeIPString(remoteIP), port)
}
+ peer.IPv6 = a.AnonymizeIPString(peer.IPv6)
peer.RelayAddress = a.AnonymizeURI(peer.RelayAddress)
for i, route := range peer.Networks {
@@ -929,6 +953,7 @@ func anonymizeOverview(a *anonymize.Anonymizer, overview *OutputOverview) {
overview.SignalState.Error = a.AnonymizeString(overview.SignalState.Error)
overview.IP = a.AnonymizeIPString(overview.IP)
+ overview.IPv6 = a.AnonymizeIPString(overview.IPv6)
for i, detail := range overview.Relays.Details {
detail.URI = a.AnonymizeURI(detail.URI)
detail.Error = a.AnonymizeString(detail.Error)
diff --git a/client/status/status_test.go b/client/status/status_test.go
index 7754eebae..0986bf0cd 100644
--- a/client/status/status_test.go
+++ b/client/status/status_test.go
@@ -32,6 +32,7 @@ var resp = &proto.StatusResponse{
Peers: []*proto.PeerState{
{
IP: "192.168.178.101",
+ Ipv6: "fd00::1",
PubKey: "Pubkey1",
Fqdn: "peer-1.awesome-domain.com",
ConnStatus: "Connected",
@@ -90,6 +91,7 @@ var resp = &proto.StatusResponse{
},
LocalPeerState: &proto.LocalPeerState{
IP: "192.168.178.100/16",
+ Ipv6: "fd00::100",
PubKey: "Some-Pub-Key",
KernelInterface: true,
Fqdn: "some-localhost.awesome-domain.com",
@@ -130,6 +132,7 @@ var overview = OutputOverview{
Details: []PeerStateDetailOutput{
{
IP: "192.168.178.101",
+ IPv6: "fd00::1",
PubKey: "Pubkey1",
FQDN: "peer-1.awesome-domain.com",
Status: "Connected",
@@ -204,6 +207,7 @@ var overview = OutputOverview{
},
},
IP: "192.168.178.100/16",
+ IPv6: "fd00::100",
PubKey: "Some-Pub-Key",
KernelInterface: true,
FQDN: "some-localhost.awesome-domain.com",
@@ -284,6 +288,7 @@ func TestParsingToJSON(t *testing.T) {
{
"fqdn": "peer-1.awesome-domain.com",
"netbirdIp": "192.168.178.101",
+ "netbirdIpv6": "fd00::1",
"publicKey": "Pubkey1",
"status": "Connected",
"lastStatusUpdate": "2001-01-01T01:01:01Z",
@@ -361,6 +366,7 @@ func TestParsingToJSON(t *testing.T) {
]
},
"netbirdIp": "192.168.178.100/16",
+ "netbirdIpv6": "fd00::100",
"publicKey": "Some-Pub-Key",
"usesKernelInterface": true,
"fqdn": "some-localhost.awesome-domain.com",
@@ -418,6 +424,7 @@ func TestParsingToYAML(t *testing.T) {
details:
- fqdn: peer-1.awesome-domain.com
netbirdIp: 192.168.178.101
+ netbirdIpv6: fd00::1
publicKey: Pubkey1
status: Connected
lastStatusUpdate: 2001-01-01T01:01:01Z
@@ -477,6 +484,7 @@ relays:
available: false
error: 'context: deadline exceeded'
netbirdIp: 192.168.178.100/16
+netbirdIpv6: fd00::100
publicKey: Some-Pub-Key
usesKernelInterface: true
fqdn: some-localhost.awesome-domain.com
@@ -523,6 +531,7 @@ func TestParsingToDetail(t *testing.T) {
`Peers detail:
peer-1.awesome-domain.com:
NetBird IP: 192.168.178.101
+ NetBird IPv6: fd00::1
Public key: Pubkey1
Status: Connected
-- detail --
@@ -568,6 +577,7 @@ Nameservers:
[1.1.1.1:53, 2.2.2.2:53] for [example.com, example.net] is Unavailable, reason: timeout
FQDN: some-localhost.awesome-domain.com
NetBird IP: 192.168.178.100/16
+NetBird IPv6: fd00::100
Interface type: Kernel
Quantum resistance: false
Lazy connection: false
@@ -592,6 +602,7 @@ Relays: 1/2 Available
Nameservers: 1/2 Available
FQDN: some-localhost.awesome-domain.com
NetBird IP: 192.168.178.100/16
+NetBird IPv6: fd00::100
Interface type: Kernel
Quantum resistance: false
Lazy connection: false
diff --git a/client/system/info.go b/client/system/info.go
index 175d1f07f..477d5162b 100644
--- a/client/system/info.go
+++ b/client/system/info.go
@@ -69,6 +69,7 @@ type Info struct {
DisableFirewall bool
BlockLANAccess bool
BlockInbound bool
+ DisableIPv6 bool
LazyConnectionEnabled bool
@@ -83,7 +84,7 @@ func (i *Info) SetFlags(
rosenpassEnabled, rosenpassPermissive bool,
serverSSHAllowed *bool,
disableClientRoutes, disableServerRoutes,
- disableDNS, disableFirewall, blockLANAccess, blockInbound, lazyConnectionEnabled bool,
+ disableDNS, disableFirewall, blockLANAccess, blockInbound, disableIPv6, lazyConnectionEnabled bool,
enableSSHRoot, enableSSHSFTP, enableSSHLocalPortForwarding, enableSSHRemotePortForwarding *bool,
disableSSHAuth *bool,
) {
@@ -99,6 +100,7 @@ func (i *Info) SetFlags(
i.DisableFirewall = disableFirewall
i.BlockLANAccess = blockLANAccess
i.BlockInbound = blockInbound
+ i.DisableIPv6 = disableIPv6
i.LazyConnectionEnabled = lazyConnectionEnabled
diff --git a/client/ui/client_ui.go b/client/ui/client_ui.go
index 28f98ae59..c2129c7a2 100644
--- a/client/ui/client_ui.go
+++ b/client/ui/client_ui.go
@@ -279,6 +279,7 @@ type serviceClient struct {
sDisableDNS *widget.Check
sDisableClientRoutes *widget.Check
sDisableServerRoutes *widget.Check
+ sDisableIPv6 *widget.Check
sBlockLANAccess *widget.Check
sEnableSSHRoot *widget.Check
sEnableSSHSFTP *widget.Check
@@ -299,6 +300,7 @@ type serviceClient struct {
disableDNS bool
disableClientRoutes bool
disableServerRoutes bool
+ disableIPv6 bool
blockLANAccess bool
enableSSHRoot bool
enableSSHSFTP bool
@@ -468,6 +470,7 @@ func (s *serviceClient) showSettingsUI() {
s.sDisableDNS = widget.NewCheck("Keeps system DNS settings unchanged", nil)
s.sDisableClientRoutes = widget.NewCheck("This peer won't route traffic to other peers", nil)
s.sDisableServerRoutes = widget.NewCheck("This peer won't act as router for others", nil)
+ s.sDisableIPv6 = widget.NewCheck("Disable IPv6 overlay addressing", nil)
s.sBlockLANAccess = widget.NewCheck("Blocks local network access when used as exit node", nil)
s.sEnableSSHRoot = widget.NewCheck("Enable SSH Root Login", nil)
s.sEnableSSHSFTP = widget.NewCheck("Enable SSH SFTP", nil)
@@ -585,6 +588,7 @@ func (s *serviceClient) hasSettingsChanged(iMngURL string, port, mtu int64) bool
s.disableDNS != s.sDisableDNS.Checked ||
s.disableClientRoutes != s.sDisableClientRoutes.Checked ||
s.disableServerRoutes != s.sDisableServerRoutes.Checked ||
+ s.disableIPv6 != s.sDisableIPv6.Checked ||
s.blockLANAccess != s.sBlockLANAccess.Checked ||
s.hasSSHChanges()
}
@@ -637,6 +641,7 @@ func (s *serviceClient) buildSetConfigRequest(iMngURL string, port, mtu int64) (
req.DisableDns = &s.sDisableDNS.Checked
req.DisableClientRoutes = &s.sDisableClientRoutes.Checked
req.DisableServerRoutes = &s.sDisableServerRoutes.Checked
+ req.DisableIpv6 = &s.sDisableIPv6.Checked
req.BlockLanAccess = &s.sBlockLANAccess.Checked
req.EnableSSHRoot = &s.sEnableSSHRoot.Checked
@@ -676,24 +681,23 @@ func (s *serviceClient) sendConfigUpdate(req *proto.SetConfigRequest) error {
return fmt.Errorf("set config: %w", err)
}
- // Reconnect if connected to apply the new settings
+ // Reconnect if connected to apply the new settings.
+ // Use a background context so the reconnect outlives the settings window.
go func() {
- status, err := conn.Status(s.ctx, &proto.StatusRequest{})
+ ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
+ defer cancel()
+ status, err := conn.Status(ctx, &proto.StatusRequest{})
if err != nil {
- log.Errorf("get service status: %v", err)
+ log.Errorf("failed to get service status: %v", err)
return
}
if status.Status == string(internal.StatusConnected) {
- // run down & up
- _, err = conn.Down(s.ctx, &proto.DownRequest{})
- if err != nil {
- log.Errorf("down service: %v", err)
+ if _, err = conn.Down(ctx, &proto.DownRequest{}); err != nil {
+ log.Errorf("failed to stop service: %v", err)
}
-
- _, err = conn.Up(s.ctx, &proto.UpRequest{})
- if err != nil {
- log.Errorf("up service: %v", err)
- return
+ // TODO: wait for the service to be idle before calling Up, or use a fresh connection
+ if _, err = conn.Up(ctx, &proto.UpRequest{}); err != nil {
+ log.Errorf("failed to start service: %v", err)
}
}
}()
@@ -730,6 +734,7 @@ func (s *serviceClient) getNetworkForm() *widget.Form {
{Text: "Disable DNS", Widget: s.sDisableDNS},
{Text: "Disable Client Routes", Widget: s.sDisableClientRoutes},
{Text: "Disable Server Routes", Widget: s.sDisableServerRoutes},
+ {Text: "Disable IPv6", Widget: s.sDisableIPv6},
{Text: "Disable LAN Access", Widget: s.sBlockLANAccess},
},
}
@@ -1327,6 +1332,7 @@ func (s *serviceClient) getSrvConfig() {
s.disableDNS = cfg.DisableDNS
s.disableClientRoutes = cfg.DisableClientRoutes
s.disableServerRoutes = cfg.DisableServerRoutes
+ s.disableIPv6 = cfg.DisableIPv6
s.blockLANAccess = cfg.BlockLANAccess
if cfg.EnableSSHRoot != nil {
@@ -1367,6 +1373,7 @@ func (s *serviceClient) getSrvConfig() {
s.sDisableDNS.SetChecked(cfg.DisableDNS)
s.sDisableClientRoutes.SetChecked(cfg.DisableClientRoutes)
s.sDisableServerRoutes.SetChecked(cfg.DisableServerRoutes)
+ s.sDisableIPv6.SetChecked(cfg.DisableIPv6)
s.sBlockLANAccess.SetChecked(cfg.BlockLANAccess)
if cfg.EnableSSHRoot != nil {
s.sEnableSSHRoot.SetChecked(*cfg.EnableSSHRoot)
@@ -1454,6 +1461,7 @@ func protoConfigToConfig(cfg *proto.GetConfigResponse) *profilemanager.Config {
config.DisableDNS = cfg.DisableDns
config.DisableClientRoutes = cfg.DisableClientRoutes
config.DisableServerRoutes = cfg.DisableServerRoutes
+ config.DisableIPv6 = cfg.DisableIpv6
config.BlockLANAccess = cfg.BlockLanAccess
config.EnableSSHRoot = &cfg.EnableSSHRoot
diff --git a/client/ui/event/event.go b/client/ui/event/event.go
index ea968f60a..3b43fdc7f 100644
--- a/client/ui/event/event.go
+++ b/client/ui/event/event.go
@@ -112,7 +112,7 @@ func (e *Manager) handleEvent(event *proto.SystemEvent) {
handlers := slices.Clone(e.handlers)
e.mu.Unlock()
- if event.UserMessage != "" && (enabled || event.Severity == proto.SystemEvent_CRITICAL) {
+ if event.UserMessage != "" && (enabled || event.Severity == proto.SystemEvent_CRITICAL) && !isV6DefaultRoutePartner(event) {
title := e.getEventTitle(event)
body := event.UserMessage
id := event.Metadata["id"]
@@ -133,6 +133,14 @@ func (e *Manager) AddHandler(handler Handler) {
e.handlers = append(e.handlers, handler)
}
+// isV6DefaultRoutePartner reports whether the event is the IPv6 half of a
+// paired v4/v6 default-route event. Management always pairs ::/0 with 0.0.0.0/0
+// for exit nodes, so the v4 partner already drives the user-facing toast and
+// the v6 one is suppressed to avoid a duplicate notification.
+func isV6DefaultRoutePartner(event *proto.SystemEvent) bool {
+ return event.Category == proto.SystemEvent_NETWORK && event.Metadata["network"] == "::/0"
+}
+
func (e *Manager) getEventTitle(event *proto.SystemEvent) string {
var prefix string
switch event.Severity {
diff --git a/client/ui/network.go b/client/ui/network.go
index 571e871bb..cd5d23558 100644
--- a/client/ui/network.go
+++ b/client/ui/network.go
@@ -192,10 +192,22 @@ func getOverlappingNetworks(routes []*proto.Network) []*proto.Network {
return filteredRoutes
}
+func isDefaultRoute(routeRange string) bool {
+ // routeRange is the merged display string from the daemon, e.g. "0.0.0.0/0",
+ // "::/0", or "0.0.0.0/0, ::/0" when a v4 exit node has a paired v6 entry.
+ for _, part := range strings.Split(routeRange, ",") {
+ switch strings.TrimSpace(part) {
+ case "0.0.0.0/0", "::/0":
+ return true
+ }
+ }
+ return false
+}
+
func getExitNodeNetworks(routes []*proto.Network) []*proto.Network {
var filteredRoutes []*proto.Network
for _, route := range routes {
- if route.Range == "0.0.0.0/0" {
+ if isDefaultRoute(route.Range) {
filteredRoutes = append(filteredRoutes, route)
}
}
@@ -499,7 +511,7 @@ func (s *serviceClient) getExitNodes(conn proto.DaemonServiceClient) ([]*proto.N
var exitNodes []*proto.Network
for _, network := range resp.Routes {
- if network.Range == "0.0.0.0/0" {
+ if isDefaultRoute(network.Range) {
exitNodes = append(exitNodes, network)
}
}
diff --git a/client/wasm/cmd/main.go b/client/wasm/cmd/main.go
index cb512f132..066fe043b 100644
--- a/client/wasm/cmd/main.go
+++ b/client/wasm/cmd/main.go
@@ -5,6 +5,8 @@ package main
import (
"context"
"fmt"
+ "net"
+ "strconv"
"sync"
"syscall/js"
"time"
@@ -83,6 +85,10 @@ func parseClientOptions(jsOptions js.Value) (netbird.Options, error) {
options.DeviceName = deviceName.String()
}
+ if disableIPv6 := jsOptions.Get("disableIPv6"); !disableIPv6.IsNull() && !disableIPv6.IsUndefined() {
+ options.DisableIPv6 = disableIPv6.Bool()
+ }
+
return options, nil
}
@@ -163,39 +169,58 @@ func createSSHMethod(client *netbird.Client) js.Func {
})
}
- var jwtToken string
- if len(args) > 3 && !args[3].IsNull() && !args[3].IsUndefined() {
- jwtToken = args[3].String()
- }
+ jwtToken, ipVersion := parseSSHOptions(args)
return createPromise(func(resolve, reject js.Value) {
- sshClient := ssh.NewClient(client)
-
- if err := sshClient.Connect(host, port, username, jwtToken); err != nil {
+ jsInterface, err := connectSSH(client, host, port, username, jwtToken, ipVersion)
+ if err != nil {
reject.Invoke(err.Error())
return
}
-
- if err := sshClient.StartSession(80, 24); err != nil {
- if closeErr := sshClient.Close(); closeErr != nil {
- log.Errorf("Error closing SSH client: %v", closeErr)
- }
- reject.Invoke(err.Error())
- return
- }
-
- jsInterface := ssh.CreateJSInterface(sshClient)
resolve.Invoke(jsInterface)
})
})
}
-func performPing(client *netbird.Client, hostname string) {
+func parseSSHOptions(args []js.Value) (jwtToken string, ipVersion int) {
+ if len(args) > 3 && !args[3].IsNull() && !args[3].IsUndefined() {
+ jwtToken = args[3].String()
+ }
+ if len(args) > 4 {
+ ipVersion = jsIPVersion(args[4])
+ }
+ return
+}
+
+func connectSSH(client *netbird.Client, host string, port int, username, jwtToken string, ipVersion int) (js.Value, error) {
+ sshClient := ssh.NewClient(client)
+
+ if err := sshClient.Connect(host, port, username, jwtToken, ipVersion); err != nil {
+ return js.Undefined(), err
+ }
+
+ if err := sshClient.StartSession(80, 24); err != nil {
+ if closeErr := sshClient.Close(); closeErr != nil {
+ log.Errorf("Error closing SSH client: %v", closeErr)
+ }
+ return js.Undefined(), err
+ }
+
+ return ssh.CreateJSInterface(sshClient), nil
+}
+
+func performPing(client *netbird.Client, hostname string, ipVersion int) {
ctx, cancel := context.WithTimeout(context.Background(), pingTimeout)
defer cancel()
+ // Default to ping4 to avoid dual-stack ICMP endpoint issues in wireguard-go netstack.
+ network := "ping4"
+ if ipVersion == 6 {
+ network = "ping6"
+ }
+
start := time.Now()
- conn, err := client.Dial(ctx, "ping", hostname)
+ conn, err := client.Dial(ctx, network, hostname)
if err != nil {
js.Global().Get("console").Call("log", fmt.Sprintf("Ping to %s failed: %v", hostname, err))
return
@@ -222,27 +247,39 @@ func performPing(client *netbird.Client, hostname string) {
}
latency := time.Since(start)
- js.Global().Get("console").Call("log", fmt.Sprintf("Ping to %s: %dms", hostname, latency.Milliseconds()))
+ remote := conn.RemoteAddr().String()
+ msg := fmt.Sprintf("Ping to %s: %dms", hostname, latency.Milliseconds())
+ if remote != hostname {
+ msg += fmt.Sprintf(" (via %s)", remote)
+ }
+ js.Global().Get("console").Call("log", msg)
}
-func performPingTCP(client *netbird.Client, hostname string, port int) {
+func performPingTCP(client *netbird.Client, hostname string, port, ipVersion int) {
ctx, cancel := context.WithTimeout(context.Background(), pingTimeout)
defer cancel()
- address := fmt.Sprintf("%s:%d", hostname, port)
+ network := ipVersionNetwork("tcp", ipVersion)
+
+ address := net.JoinHostPort(hostname, fmt.Sprintf("%d", port))
start := time.Now()
- conn, err := client.Dial(ctx, "tcp", address)
+ conn, err := client.Dial(ctx, network, address)
if err != nil {
js.Global().Get("console").Call("log", fmt.Sprintf("TCP ping to %s failed: %v", address, err))
return
}
latency := time.Since(start)
+ remote := conn.RemoteAddr().String()
if err := conn.Close(); err != nil {
log.Debugf("failed to close TCP connection: %v", err)
}
- js.Global().Get("console").Call("log", fmt.Sprintf("TCP ping to %s succeeded: %dms", address, latency.Milliseconds()))
+ msg := fmt.Sprintf("TCP ping to %s succeeded: %dms", address, latency.Milliseconds())
+ if remote != address {
+ msg += fmt.Sprintf(" (via %s)", remote)
+ }
+ js.Global().Get("console").Call("log", msg)
}
// createPingMethod creates the ping method
@@ -259,8 +296,12 @@ func createPingMethod(client *netbird.Client) js.Func {
}
hostname := args[0].String()
+ var ipVersion int
+ if len(args) > 1 {
+ ipVersion = jsIPVersion(args[1])
+ }
return createPromise(func(resolve, reject js.Value) {
- performPing(client, hostname)
+ performPing(client, hostname, ipVersion)
resolve.Invoke(js.Undefined())
})
})
@@ -287,8 +328,12 @@ func createPingTCPMethod(client *netbird.Client) js.Func {
hostname := args[0].String()
port := args[1].Int()
+ var ipVersion int
+ if len(args) > 2 {
+ ipVersion = jsIPVersion(args[2])
+ }
return createPromise(func(resolve, reject js.Value) {
- performPingTCP(client, hostname, port)
+ performPingTCP(client, hostname, port, ipVersion)
resolve.Invoke(js.Undefined())
})
})
@@ -461,6 +506,31 @@ func createSetLogLevelMethod(client *netbird.Client) js.Func {
})
}
+// ipVersionNetwork appends "4" or "6" to a base network string (e.g. "tcp" -> "tcp4").
+func ipVersionNetwork(base string, ipVersion int) string {
+ switch ipVersion {
+ case 4:
+ return base + "4"
+ case 6:
+ return base + "6"
+ default:
+ return base
+ }
+}
+
+// jsIPVersion extracts an IP version (4 or 6) from a JS string or number.
+func jsIPVersion(v js.Value) int {
+ switch v.Type() {
+ case js.TypeNumber:
+ return v.Int()
+ case js.TypeString:
+ n, _ := strconv.Atoi(v.String())
+ return n
+ default:
+ return 0
+ }
+}
+
// createStartCaptureMethod creates the programmable packet capture method.
// Returns a JS interface with onpacket callback and stop() method.
//
diff --git a/client/wasm/internal/rdp/rdcleanpath.go b/client/wasm/internal/rdp/rdcleanpath.go
index 16bf63bb9..6c36fdec6 100644
--- a/client/wasm/internal/rdp/rdcleanpath.go
+++ b/client/wasm/internal/rdp/rdcleanpath.go
@@ -82,7 +82,7 @@ func NewRDCleanPathProxy(client interface {
// CreateProxy creates a new proxy endpoint for the given destination
func (p *RDCleanPathProxy) CreateProxy(hostname, port string) js.Value {
- destination := fmt.Sprintf("%s:%s", hostname, port)
+ destination := net.JoinHostPort(hostname, port)
return js.Global().Get("Promise").New(js.FuncOf(func(_ js.Value, args []js.Value) any {
resolve := args[0]
diff --git a/client/wasm/internal/ssh/client.go b/client/wasm/internal/ssh/client.go
index 568437e56..9cfe65266 100644
--- a/client/wasm/internal/ssh/client.go
+++ b/client/wasm/internal/ssh/client.go
@@ -6,6 +6,7 @@ import (
"context"
"fmt"
"io"
+ "net"
"sync"
"time"
@@ -45,9 +46,10 @@ func NewClient(nbClient *netbird.Client) *Client {
}
}
-// Connect establishes an SSH connection through NetBird network
-func (c *Client) Connect(host string, port int, username, jwtToken string) error {
- addr := fmt.Sprintf("%s:%d", host, port)
+// Connect establishes an SSH connection through NetBird network.
+// ipVersion may be 4, 6, or 0 for automatic selection.
+func (c *Client) Connect(host string, port int, username, jwtToken string, ipVersion int) error {
+ addr := net.JoinHostPort(host, fmt.Sprintf("%d", port))
logrus.Infof("SSH: Connecting to %s as %s", addr, username)
authMethods, err := c.getAuthMethods(jwtToken)
@@ -62,10 +64,18 @@ func (c *Client) Connect(host string, port int, username, jwtToken string) error
Timeout: sshDialTimeout,
}
+ network := "tcp"
+ switch ipVersion {
+ case 4:
+ network = "tcp4"
+ case 6:
+ network = "tcp6"
+ }
+
ctx, cancel := context.WithTimeout(context.Background(), sshDialTimeout)
defer cancel()
- conn, err := c.nbClient.Dial(ctx, "tcp", addr)
+ conn, err := c.nbClient.Dial(ctx, network, addr)
if err != nil {
return fmt.Errorf("dial %s: %w", addr, err)
}
diff --git a/combined/cmd/config.go b/combined/cmd/config.go
index ce4df8394..fe350e52a 100644
--- a/combined/cmd/config.go
+++ b/combined/cmd/config.go
@@ -133,13 +133,18 @@ type ManagementConfig struct {
// AuthConfig contains authentication/identity provider settings
type AuthConfig struct {
- Issuer string `yaml:"issuer"`
- LocalAuthDisabled bool `yaml:"localAuthDisabled"`
- SignKeyRefreshEnabled bool `yaml:"signKeyRefreshEnabled"`
- Storage AuthStorageConfig `yaml:"storage"`
- DashboardRedirectURIs []string `yaml:"dashboardRedirectURIs"`
- CLIRedirectURIs []string `yaml:"cliRedirectURIs"`
- Owner *AuthOwnerConfig `yaml:"owner,omitempty"`
+ Issuer string `yaml:"issuer"`
+ LocalAuthDisabled bool `yaml:"localAuthDisabled"`
+ SignKeyRefreshEnabled bool `yaml:"signKeyRefreshEnabled"`
+ MfaSessionMaxLifetime string `yaml:"mfaSessionMaxLifetime"`
+ MfaSessionIdleTimeout string `yaml:"mfaSessionIdleTimeout"`
+ MfaSessionRememberMe bool `yaml:"mfaSessionRememberMe"`
+ SessionCookieEncryptionKey string `yaml:"sessionCookieEncryptionKey"`
+ Storage AuthStorageConfig `yaml:"storage"`
+ DashboardRedirectURIs []string `yaml:"dashboardRedirectURIs"`
+ CLIRedirectURIs []string `yaml:"cliRedirectURIs"`
+ Owner *AuthOwnerConfig `yaml:"owner,omitempty"`
+ DashboardPostLogoutRedirectURIs []string `yaml:"dashboardPostLogoutRedirectURIs"`
}
// AuthStorageConfig contains auth storage settings
@@ -380,7 +385,7 @@ func (c *CombinedConfig) autoConfigureClientSettings(exposedProto, exposedHost,
// Auto-configure local STUN servers for all ports
for _, port := range c.Server.StunPorts {
c.Management.Stuns = append(c.Management.Stuns, HostConfig{
- URI: fmt.Sprintf("stun:%s:%d", exposedHost, port),
+ URI: "stun:" + net.JoinHostPort(strings.Trim(exposedHost, "[]"), fmt.Sprintf("%d", port)),
})
}
}
@@ -581,10 +586,14 @@ func (c *CombinedConfig) buildEmbeddedIdPConfig(mgmt ManagementConfig) (*idp.Emb
}
cfg := &idp.EmbeddedIdPConfig{
- Enabled: true,
- Issuer: mgmt.Auth.Issuer,
- LocalAuthDisabled: mgmt.Auth.LocalAuthDisabled,
- SignKeyRefreshEnabled: mgmt.Auth.SignKeyRefreshEnabled,
+ Enabled: true,
+ Issuer: mgmt.Auth.Issuer,
+ LocalAuthDisabled: mgmt.Auth.LocalAuthDisabled,
+ SignKeyRefreshEnabled: mgmt.Auth.SignKeyRefreshEnabled,
+ MfaSessionMaxLifetime: mgmt.Auth.MfaSessionMaxLifetime,
+ MfaSessionIdleTimeout: mgmt.Auth.MfaSessionIdleTimeout,
+ MfaSessionRememberMe: mgmt.Auth.MfaSessionRememberMe,
+ SessionCookieEncryptionKey: mgmt.Auth.SessionCookieEncryptionKey,
Storage: idp.EmbeddedStorageConfig{
Type: authStorageType,
Config: idp.EmbeddedStorageTypeConfig{
@@ -592,8 +601,9 @@ func (c *CombinedConfig) buildEmbeddedIdPConfig(mgmt ManagementConfig) (*idp.Emb
DSN: authStorageDSN,
},
},
- DashboardRedirectURIs: mgmt.Auth.DashboardRedirectURIs,
- CLIRedirectURIs: mgmt.Auth.CLIRedirectURIs,
+ DashboardRedirectURIs: mgmt.Auth.DashboardRedirectURIs,
+ CLIRedirectURIs: mgmt.Auth.CLIRedirectURIs,
+ DashboardPostLogoutRedirectURIs: mgmt.Auth.DashboardPostLogoutRedirectURIs,
}
if mgmt.Auth.Owner != nil && mgmt.Auth.Owner.Email != "" {
diff --git a/combined/config.yaml.example b/combined/config.yaml.example
index af85b0477..66bc71703 100644
--- a/combined/config.yaml.example
+++ b/combined/config.yaml.example
@@ -86,6 +86,13 @@ server:
issuer: "https://example.com/oauth2"
localAuthDisabled: false
signKeyRefreshEnabled: false
+ # MFA session settings (applies when TOTP is enabled for an account)
+ # mfaSessionMaxLifetime: "24h" # Max duration for an MFA session from creation
+ # mfaSessionIdleTimeout: "1h" # MFA session expires after this idle period
+ # mfaSessionRememberMe: false # Pre-check "remember me" on login so the MFA session persists across tabs/restarts
+ # Optional AES key for encrypting embedded IdP session cookies. Can also be set via NB_IDP_SESSION_COOKIE_ENCRYPTION_KEY.
+ # Must be 16/24/32 raw bytes or base64-encoded to one of those lengths (for example: openssl rand -hex 16).
+ # sessionCookieEncryptionKey: ""
# OAuth2 redirect URIs for dashboard
dashboardRedirectURIs:
- "https://app.example.com/nb-auth"
@@ -93,6 +100,9 @@ server:
# OAuth2 redirect URIs for CLI
cliRedirectURIs:
- "http://localhost:53000/"
+ # OAuth2 post-logout redirect URIs for dashboard (RP-initiated logout)
+ # dashboardPostLogoutRedirectURIs:
+ # - "https://app.example.com/"
# Optional initial admin user
# owner:
# email: "admin@example.com"
diff --git a/go.mod b/go.mod
index bc4e8af15..7c1a95e79 100644
--- a/go.mod
+++ b/go.mod
@@ -14,7 +14,7 @@ require (
github.com/onsi/gomega v1.27.6
github.com/rs/cors v1.8.0
github.com/sirupsen/logrus v1.9.4
- github.com/spf13/cobra v1.10.1
+ github.com/spf13/cobra v1.10.2
github.com/spf13/pflag v1.0.9
github.com/vishvananda/netlink v1.3.1
golang.org/x/crypto v0.50.0
@@ -41,11 +41,11 @@ require (
github.com/cilium/ebpf v0.15.0
github.com/coder/websocket v1.8.14
github.com/coreos/go-iptables v0.7.0
- github.com/coreos/go-oidc/v3 v3.14.1
+ github.com/coreos/go-oidc/v3 v3.18.0
github.com/creack/pty v1.1.24
github.com/crowdsecurity/crowdsec v1.7.7
github.com/crowdsecurity/go-cs-bouncer v0.0.21
- github.com/dexidp/dex v0.0.0-00010101000000-000000000000
+ github.com/dexidp/dex v2.13.0+incompatible
github.com/dexidp/dex/api/v2 v2.4.0
github.com/ebitengine/purego v0.8.4
github.com/eko/gocache/lib/v4 v4.2.0
@@ -53,9 +53,9 @@ require (
github.com/eko/gocache/store/redis/v4 v4.2.2
github.com/fsnotify/fsnotify v1.9.0
github.com/gliderlabs/ssh v0.3.8
- github.com/go-jose/go-jose/v4 v4.1.3
+ github.com/go-jose/go-jose/v4 v4.1.4
github.com/godbus/dbus/v5 v5.1.0
- github.com/golang-jwt/jwt/v5 v5.3.0
+ github.com/golang-jwt/jwt/v5 v5.3.1
github.com/golang/mock v1.6.0
github.com/google/go-cmp v0.7.0
github.com/google/gopacket v1.1.19
@@ -72,7 +72,7 @@ require (
github.com/lrh3321/ipset-go v0.0.0-20250619021614-54a0a98ace81
github.com/mdlayher/socket v0.5.1
github.com/mdp/qrterminal/v3 v3.2.1
- github.com/miekg/dns v1.1.59
+ github.com/miekg/dns v1.1.72
github.com/mitchellh/hashstructure/v2 v2.0.2
github.com/netbirdio/management-integrations/integrations v0.0.0-20260416123949-2355d972be42
github.com/netbirdio/signal-dispatcher/dispatcher v0.0.0-20250805121659-6b4ac470ca45
@@ -113,7 +113,7 @@ require (
go.opentelemetry.io/otel/exporters/prometheus v0.64.0
go.opentelemetry.io/otel/metric v1.43.0
go.opentelemetry.io/otel/sdk/metric v1.43.0
- go.uber.org/mock v0.5.2
+ go.uber.org/mock v0.6.0
go.uber.org/zap v1.27.0
goauthentik.io/api/v3 v3.2023051.3
golang.org/x/exp v0.0.0-20250620022241-b7579e27df2b
@@ -141,7 +141,7 @@ require (
filippo.io/edwards25519 v1.1.1 // indirect
github.com/AppsFlyer/go-sundheit v0.6.0 // indirect
github.com/Azure/go-ansiterm v0.0.0-20230124172434-306776ec8161 // indirect
- github.com/Azure/go-ntlmssp v0.0.0-20221128193559-754e69321358 // indirect
+ github.com/Azure/go-ntlmssp v0.1.0 // indirect
github.com/BurntSushi/toml v1.5.0 // indirect
github.com/Masterminds/goutils v1.1.1 // indirect
github.com/Masterminds/semver/v3 v3.3.0 // indirect
@@ -168,6 +168,7 @@ require (
github.com/aws/smithy-go v1.23.0 // indirect
github.com/beevik/etree v1.6.0 // indirect
github.com/beorn7/perks v1.0.1 // indirect
+ github.com/boombuler/barcode v1.0.1-0.20190219062509-6c824513bacc // indirect
github.com/caddyserver/zerossl v0.1.3 // indirect
github.com/cenkalti/backoff/v5 v5.0.3 // indirect
github.com/cespare/xxhash/v2 v2.3.0 // indirect
@@ -183,6 +184,7 @@ require (
github.com/docker/go-units v0.5.0 // indirect
github.com/felixge/httpsnoop v1.0.4 // indirect
github.com/fredbi/uri v1.1.1 // indirect
+ github.com/fxamacker/cbor/v2 v2.9.1 // indirect
github.com/fyne-io/gl-js v0.2.0 // indirect
github.com/fyne-io/glfw-js v0.3.0 // indirect
github.com/fyne-io/image v0.1.1 // indirect
@@ -190,7 +192,7 @@ require (
github.com/go-asn1-ber/asn1-ber v1.5.8-0.20250403174932-29230038a667 // indirect
github.com/go-gl/gl v0.0.0-20231021071112-07e5d0ea2e71 // indirect
github.com/go-gl/glfw/v3.3/glfw v0.0.0-20240506104042-037f3cc74f2a // indirect
- github.com/go-ldap/ldap/v3 v3.4.12 // indirect
+ github.com/go-ldap/ldap/v3 v3.4.13 // indirect
github.com/go-logr/logr v1.4.3 // indirect
github.com/go-logr/stdr v1.2.2 // indirect
github.com/go-ole/go-ole v1.3.0 // indirect
@@ -206,11 +208,15 @@ require (
github.com/go-sql-driver/mysql v1.9.3 // indirect
github.com/go-text/render v0.2.0 // indirect
github.com/go-text/typesetting v0.2.1 // indirect
+ github.com/go-viper/mapstructure/v2 v2.5.0 // indirect
+ github.com/go-webauthn/webauthn v0.16.4 // indirect
+ github.com/go-webauthn/x v0.2.3 // indirect
github.com/goccy/go-yaml v1.18.0 // indirect
github.com/gogo/protobuf v1.3.2 // indirect
github.com/golang-jwt/jwt/v4 v4.5.2 // indirect
github.com/google/btree v1.1.2 // indirect
github.com/google/go-querystring v1.1.0 // indirect
+ github.com/google/go-tpm v0.9.8 // indirect
github.com/google/s2a-go v0.1.9 // indirect
github.com/googleapis/enterprise-certificate-proxy v0.3.14 // indirect
github.com/googleapis/gax-go/v2 v2.21.0 // indirect
@@ -218,7 +224,13 @@ require (
github.com/hack-pad/go-indexeddb v0.3.2 // indirect
github.com/hack-pad/safejs v0.1.0 // indirect
github.com/hashicorp/errwrap v1.1.0 // indirect
+ github.com/hashicorp/go-cleanhttp v0.5.2 // indirect
+ github.com/hashicorp/go-retryablehttp v0.7.8 // indirect
+ github.com/hashicorp/go-secure-stdlib/parseutil v0.2.0 // indirect
+ github.com/hashicorp/go-secure-stdlib/strutil v0.1.2 // indirect
+ github.com/hashicorp/go-sockaddr v1.0.7 // indirect
github.com/hashicorp/go-uuid v1.0.3 // indirect
+ github.com/hashicorp/hcl v1.0.1-vault-7 // indirect
github.com/huandu/xstrings v1.5.0 // indirect
github.com/huin/goupnp v1.2.0 // indirect
github.com/inconshreveable/mousetrap v1.1.0 // indirect
@@ -238,13 +250,13 @@ require (
github.com/klauspost/cpuid/v2 v2.2.10 // indirect
github.com/koron/go-ssdp v0.0.4 // indirect
github.com/kr/fs v0.1.0 // indirect
- github.com/lib/pq v1.10.9 // indirect
+ github.com/lib/pq v1.12.3 // indirect
github.com/libdns/libdns v0.2.2 // indirect
github.com/lufia/plan9stats v0.0.0-20240513124658-fba389f38bae // indirect
github.com/magiconair/properties v1.8.10 // indirect
github.com/mailru/easyjson v0.9.0 // indirect
github.com/mattermost/xml-roundtrip-validator v0.1.0 // indirect
- github.com/mattn/go-sqlite3 v1.14.32 // indirect
+ github.com/mattn/go-sqlite3 v1.14.42 // indirect
github.com/mdelapenya/tlscert v0.2.0 // indirect
github.com/mdlayher/genetlink v1.3.2 // indirect
github.com/mdlayher/netlink v1.7.3-0.20250113171957-fbb4dce95f42 // indirect
@@ -265,8 +277,10 @@ require (
github.com/nxadm/tail v1.4.11 // indirect
github.com/oklog/ulid v1.3.1 // indirect
github.com/onsi/ginkgo/v2 v2.9.5 // indirect
+ github.com/openbao/openbao/api/v2 v2.5.1 // indirect
github.com/opencontainers/go-digest v1.0.0 // indirect
github.com/opencontainers/image-spec v1.1.1 // indirect
+ github.com/philhofer/fwd v1.2.0 // indirect
github.com/pion/dtls/v2 v2.2.10 // indirect
github.com/pion/dtls/v3 v3.0.9 // indirect
github.com/pion/mdns/v2 v2.0.7 // indirect
@@ -275,11 +289,13 @@ require (
github.com/pkg/errors v0.9.1 // indirect
github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 // indirect
github.com/power-devops/perfstat v0.0.0-20240221224432-82ca36839d55 // indirect
+ github.com/pquerna/otp v1.5.0 // indirect
github.com/prometheus/client_model v0.6.2 // indirect
github.com/prometheus/common v0.67.5 // indirect
github.com/prometheus/otlptranslator v1.0.0 // indirect
github.com/prometheus/procfs v0.19.2 // indirect
github.com/russellhaering/goxmldsig v1.6.0 // indirect
+ github.com/ryanuber/go-glob v1.0.0 // indirect
github.com/rymdport/portal v0.4.2 // indirect
github.com/shirou/gopsutil/v4 v4.25.8 // indirect
github.com/shoenig/go-m1cpu v0.2.1 // indirect
@@ -288,11 +304,13 @@ require (
github.com/srwiley/oksvg v0.0.0-20221011165216-be6e8873101c // indirect
github.com/srwiley/rasterx v0.0.0-20220730225603-2ab79fcdd4ef // indirect
github.com/stretchr/objx v0.5.2 // indirect
+ github.com/tinylib/msgp v1.6.3 // indirect
github.com/tklauser/go-sysconf v0.3.15 // indirect
github.com/tklauser/numcpus v0.10.0 // indirect
github.com/vishvananda/netns v0.0.5 // indirect
github.com/vmihailenco/tagparser/v2 v2.0.0 // indirect
github.com/wlynxg/anet v0.0.5 // indirect
+ github.com/x448/float16 v0.8.4 // indirect
github.com/yuin/goldmark v1.7.8 // indirect
github.com/zeebo/blake3 v0.2.3 // indirect
go.mongodb.org/mongo-driver v1.17.9 // indirect
@@ -319,10 +337,12 @@ replace github.com/getlantern/systray => github.com/netbirdio/systray v0.0.0-202
replace golang.zx2c4.com/wireguard => github.com/netbirdio/wireguard-go v0.0.0-20260107100953-33b7c9d03db0
-replace github.com/cloudflare/circl => github.com/cunicu/circl v0.0.0-20230801113412-fec58fc7b5f6
+replace github.com/cloudflare/circl => codeberg.org/cunicu/circl v0.0.0-20230801113412-fec58fc7b5f6
replace github.com/pion/ice/v4 => github.com/netbirdio/ice/v4 v4.0.0-20250908184934-6202be846b51
-replace github.com/dexidp/dex => github.com/netbirdio/dex v0.244.0
+replace github.com/dexidp/dex => github.com/netbirdio/dex v0.244.1-0.20260512110716-8d70ad8647c1
+
+replace github.com/dexidp/dex/api/v2 => github.com/netbirdio/dex/api/v2 v2.0.0-20260512110716-8d70ad8647c1
replace github.com/mailru/easyjson => github.com/netbirdio/easyjson v0.9.0
diff --git a/go.sum b/go.sum
index d54dc01e6..53789f49d 100644
--- a/go.sum
+++ b/go.sum
@@ -5,6 +5,8 @@ cloud.google.com/go/auth/oauth2adapt v0.2.8/go.mod h1:XQ9y31RkqZCcwJWNSx2Xvric3R
cloud.google.com/go/compute/metadata v0.2.0/go.mod h1:zFmK7XCadkQkj6TtorcaGlCW1hT1fIilQDwofLpJ20k=
cloud.google.com/go/compute/metadata v0.9.0 h1:pDUj4QMoPejqq20dK0Pg2N4yG9zIkYGdBtwLoEkH9Zs=
cloud.google.com/go/compute/metadata v0.9.0/go.mod h1:E0bWwX5wTnLPedCKqk3pJmVgCBSM6qQI1yTBdEb3C10=
+codeberg.org/cunicu/circl v0.0.0-20230801113412-fec58fc7b5f6 h1:b8xUw3004wk+3ipBhu0VU4RtUJsegMIiqjxSK4++lzA=
+codeberg.org/cunicu/circl v0.0.0-20230801113412-fec58fc7b5f6/go.mod h1:+CauBF6R70Jqcyl8N2hC8pAXYbWkGIezuSbuGLtRhnw=
cunicu.li/go-rosenpass v0.4.0 h1:LtPtBgFWY/9emfgC4glKLEqS0MJTylzV6+ChRhiZERw=
cunicu.li/go-rosenpass v0.4.0/go.mod h1:MPbjH9nxV4l3vEagKVdFNwHOketqgS5/To1VYJplf/M=
dario.cat/mergo v1.0.1 h1:Ra4+bf83h2ztPIQYNP99R6m+Y7KfnARDfID+a+vLl4s=
@@ -23,8 +25,8 @@ github.com/AppsFlyer/go-sundheit v0.6.0 h1:d2hBvCjBSb2lUsEWGfPigr4MCOt04sxB+Rppl
github.com/AppsFlyer/go-sundheit v0.6.0/go.mod h1:LDdBHD6tQBtmHsdW+i1GwdTt6Wqc0qazf5ZEJVTbTME=
github.com/Azure/go-ansiterm v0.0.0-20230124172434-306776ec8161 h1:L/gRVlceqvL25UVaW/CKtUDjefjrs0SPonmDGUVOYP0=
github.com/Azure/go-ansiterm v0.0.0-20230124172434-306776ec8161/go.mod h1:xomTg63KZ2rFqZQzSB4Vz2SUXa1BpHTVz9L5PTmPC4E=
-github.com/Azure/go-ntlmssp v0.0.0-20221128193559-754e69321358 h1:mFRzDkZVAjdal+s7s0MwaRv9igoPqLRdzOLzw/8Xvq8=
-github.com/Azure/go-ntlmssp v0.0.0-20221128193559-754e69321358/go.mod h1:chxPXzSsl7ZWRAuOIE23GDNzjWuZquvFlgA8xmpunjU=
+github.com/Azure/go-ntlmssp v0.1.0 h1:DjFo6YtWzNqNvQdrwEyr/e4nhU3vRiwenz5QX7sFz+A=
+github.com/Azure/go-ntlmssp v0.1.0/go.mod h1:NYqdhxd/8aAct/s4qSYZEerdPuH1liG2/X9DiVTbhpk=
github.com/BurntSushi/toml v1.5.0 h1:W5quZX/G/csjUnuI8SUYlsHs9M38FC7znL0lIO+DvMg=
github.com/BurntSushi/toml v1.5.0/go.mod h1:ukJfTF/6rtPPRCnwkur4qwRxa8vTRFBF0uk2lLoLwho=
github.com/Masterminds/goutils v1.1.1 h1:5nUrii3FMTL5diU80unEVvNevw1nH4+ZV4DSLVJLSYI=
@@ -91,6 +93,8 @@ github.com/beevik/etree v1.6.0/go.mod h1:bh4zJxiIr62SOf9pRzN7UUYaEDa9HEKafK25+sL
github.com/beorn7/perks v1.0.1 h1:VlbKKnNfV8bJzeqoa4cOKqO6bYr3WgKZxO8Z16+hsOM=
github.com/beorn7/perks v1.0.1/go.mod h1:G2ZrVWU2WbWT9wwq4/hrbKbnv/1ERSJQ0ibhJ6rlkpw=
github.com/bmatcuk/doublestar v1.1.1/go.mod h1:UD6OnuiIn0yFxxA2le/rnRU1G4RaI4UvFv1sNto9p6w=
+github.com/boombuler/barcode v1.0.1-0.20190219062509-6c824513bacc h1:biVzkmvwrH8WK8raXaxBx6fRVTlJILwEwQGL1I/ByEI=
+github.com/boombuler/barcode v1.0.1-0.20190219062509-6c824513bacc/go.mod h1:paBWMcWSl3LHKBqUq+rly7CNSldXjb2rDl3JlRe0mD8=
github.com/bsm/ginkgo/v2 v2.12.0 h1:Ny8MWAHyOepLGlLKYmXG4IEkioBysk6GpaRTLC8zwWs=
github.com/bsm/ginkgo/v2 v2.12.0/go.mod h1:SwYbGRRDovPVboqFv0tPTcG1sN61LM1Z4ARdbAV9g4c=
github.com/bsm/gomega v1.27.10 h1:yeMWxP2pV2fG3FgAODIY8EiRE3dy0aeFYt4l7wh6yKA=
@@ -117,8 +121,8 @@ github.com/containerd/platforms v0.2.1 h1:zvwtM3rz2YHPQsF2CHYM8+KtB5dvhISiXh5ZpS
github.com/containerd/platforms v0.2.1/go.mod h1:XHCb+2/hzowdiut9rkudds9bE5yJ7npe7dG/wG+uFPw=
github.com/coreos/go-iptables v0.7.0 h1:XWM3V+MPRr5/q51NuWSgU0fqMad64Zyxs8ZUoMsamr8=
github.com/coreos/go-iptables v0.7.0/go.mod h1:Qe8Bv2Xik5FyTXwgIbLAnv2sWSBmvWdFETJConOQ//Q=
-github.com/coreos/go-oidc/v3 v3.14.1 h1:9ePWwfdwC4QKRlCXsJGou56adA/owXczOzwKdOumLqk=
-github.com/coreos/go-oidc/v3 v3.14.1/go.mod h1:HaZ3szPaZ0e4r6ebqvsLWlk2Tn+aejfmrfah6hnSYEU=
+github.com/coreos/go-oidc/v3 v3.18.0 h1:V9orjXynvu5wiC9SemFTWnG4F45v403aIcjWo0d41+A=
+github.com/coreos/go-oidc/v3 v3.18.0/go.mod h1:DYCf24+ncYi+XkIH97GY1+dqoRlbaSI26KVTCI9SrY4=
github.com/cpuguy83/dockercfg v0.3.2 h1:DlJTyZGBDlXqUZ2Dk2Q3xHs/FtnooJJVaad2S9GKorA=
github.com/cpuguy83/dockercfg v0.3.2/go.mod h1:sugsbF4//dDlL/i+S+rtpIWp+5h0BHJHfjj5/jFyUJc=
github.com/cpuguy83/go-md2man/v2 v2.0.6/go.mod h1:oOW0eioCTA6cOiMLiUPZOpcVxMig6NIQQ7OS05n1F4g=
@@ -130,14 +134,10 @@ github.com/crowdsecurity/go-cs-bouncer v0.0.21 h1:arPz0VtdVSaz+auOSfHythzkZVLyy1
github.com/crowdsecurity/go-cs-bouncer v0.0.21/go.mod h1:4JiH0XXA4KKnnWThItUpe5+heJHWzsLOSA2IWJqUDBA=
github.com/crowdsecurity/go-cs-lib v0.0.25 h1:Ov6VPW9yV+OPsbAIQk1iTkEWhwkpaG0v3lrBzeqjzj4=
github.com/crowdsecurity/go-cs-lib v0.0.25/go.mod h1:X0GMJY2CxdA1S09SpuqIKaWQsvRGxXmecUp9cP599dE=
-github.com/cunicu/circl v0.0.0-20230801113412-fec58fc7b5f6 h1:/DS5cDX3FJdl+XaN2D7XAwFpuanTxnp52DBLZAaJKx0=
-github.com/cunicu/circl v0.0.0-20230801113412-fec58fc7b5f6/go.mod h1:+CauBF6R70Jqcyl8N2hC8pAXYbWkGIezuSbuGLtRhnw=
github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc h1:U9qPSI2PIWSS1VwoXQT9A3Wy9MM3WgvqSxFWenqJduM=
github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
-github.com/dexidp/dex/api/v2 v2.4.0 h1:gNba7n6BKVp8X4Jp24cxYn5rIIGhM6kDOXcZoL6tr9A=
-github.com/dexidp/dex/api/v2 v2.4.0/go.mod h1:/p550ADvFFh7K95VmhUD+jgm15VdaNnab9td8DHOpyI=
github.com/dgryski/go-rendezvous v0.0.0-20200823014737-9f7001d12a5f h1:lO4WD4F/rVNCu3HqELle0jiPLLBs70cWOduZpkS1E78=
github.com/dgryski/go-rendezvous v0.0.0-20200823014737-9f7001d12a5f/go.mod h1:cuUVRXasLTGF7a8hSLbxyZXjz+1KgoB3wDUb6vlszIc=
github.com/distribution/reference v0.6.0 h1:0IXCQ5g4/QMHHkarYzh5l+u8T3t73zM5QvfrDyIgxBk=
@@ -156,6 +156,8 @@ github.com/eko/gocache/store/go_cache/v4 v4.2.2 h1:tAI9nl6TLoJyKG1ujF0CS0n/IgTEM
github.com/eko/gocache/store/go_cache/v4 v4.2.2/go.mod h1:T9zkHokzr8K9EiC7RfMbDg6HSwaV6rv3UdcNu13SGcA=
github.com/eko/gocache/store/redis/v4 v4.2.2 h1:Thw31fzGuH3WzJywsdbMivOmP550D6JS7GDHhvCJPA0=
github.com/eko/gocache/store/redis/v4 v4.2.2/go.mod h1:LaTxLKx9TG/YUEybQvPMij++D7PBTIJ4+pzvk0ykz0w=
+github.com/fatih/color v1.18.0 h1:S8gINlzdQ840/4pfAwic/ZE0djQEH3wM94VfqLTZcOM=
+github.com/fatih/color v1.18.0/go.mod h1:4FelSpRwEGDpQ12mAdzqdOukCy4u8WUtOY6lkT/6HfU=
github.com/felixge/fgprof v0.9.3 h1:VvyZxILNuCiUCSXtPtYmmtGvb65nqXh2QFWc0Wpf2/g=
github.com/felixge/fgprof v0.9.3/go.mod h1:RdbpDgzqYVh/T9fPELJyV7EYJuHB55UTEULNun8eiPw=
github.com/felixge/httpsnoop v1.0.4 h1:NFTV2Zj1bL4mc9sqWACXbQFVBBg2W3GPvqp8/ESS2Wg=
@@ -171,6 +173,8 @@ github.com/fsnotify/fsnotify v1.4.9/go.mod h1:znqG4EE+3YCdAaPaxE2ZRY/06pZUdp0tY4
github.com/fsnotify/fsnotify v1.6.0/go.mod h1:sl3t1tCWJFWoRz9R8WJCbQihKKwmorjAbSClcnxKAGw=
github.com/fsnotify/fsnotify v1.9.0 h1:2Ml+OJNzbYCTzsxtv8vKSFD9PbJjmhYF14k/jKC7S9k=
github.com/fsnotify/fsnotify v1.9.0/go.mod h1:8jBTzvmWwFyi3Pb8djgCCO5IBqzKJ/Jwo8TRcHyHii0=
+github.com/fxamacker/cbor/v2 v2.9.1 h1:2rWm8B193Ll4VdjsJY28jxs70IdDsHRWgQYAI80+rMQ=
+github.com/fxamacker/cbor/v2 v2.9.1/go.mod h1:vM4b+DJCtHn+zz7h3FFp/hDAI9WNWCsZj23V5ytsSxQ=
github.com/fyne-io/gl-js v0.2.0 h1:+EXMLVEa18EfkXBVKhifYB6OGs3HwKO3lUElA0LlAjs=
github.com/fyne-io/gl-js v0.2.0/go.mod h1:ZcepK8vmOYLu96JoxbCKJy2ybr+g1pTnaBDdl7c3ajI=
github.com/fyne-io/glfw-js v0.3.0 h1:d8k2+Y7l+zy2pc7wlGRyPfTgZoqDf3AI4G+2zOWhWUk=
@@ -189,10 +193,10 @@ github.com/go-gl/gl v0.0.0-20231021071112-07e5d0ea2e71 h1:5BVwOaUSBTlVZowGO6VZGw
github.com/go-gl/gl v0.0.0-20231021071112-07e5d0ea2e71/go.mod h1:9YTyiznxEY1fVinfM7RvRcjRHbw2xLBJ3AAGIT0I4Nw=
github.com/go-gl/glfw/v3.3/glfw v0.0.0-20240506104042-037f3cc74f2a h1:vxnBhFDDT+xzxf1jTJKMKZw3H0swfWk9RpWbBbDK5+0=
github.com/go-gl/glfw/v3.3/glfw v0.0.0-20240506104042-037f3cc74f2a/go.mod h1:tQ2UAYgL5IevRw8kRxooKSPJfGvJ9fJQFa0TUsXzTg8=
-github.com/go-jose/go-jose/v4 v4.1.3 h1:CVLmWDhDVRa6Mi/IgCgaopNosCaHz7zrMeF9MlZRkrs=
-github.com/go-jose/go-jose/v4 v4.1.3/go.mod h1:x4oUasVrzR7071A4TnHLGSPpNOm2a21K9Kf04k1rs08=
-github.com/go-ldap/ldap/v3 v3.4.12 h1:1b81mv7MagXZ7+1r7cLTWmyuTqVqdwbtJSjC0DAp9s4=
-github.com/go-ldap/ldap/v3 v3.4.12/go.mod h1:+SPAGcTtOfmGsCb3h1RFiq4xpp4N636G75OEace8lNo=
+github.com/go-jose/go-jose/v4 v4.1.4 h1:moDMcTHmvE6Groj34emNPLs/qtYXRVcd6S7NHbHz3kA=
+github.com/go-jose/go-jose/v4 v4.1.4/go.mod h1:x4oUasVrzR7071A4TnHLGSPpNOm2a21K9Kf04k1rs08=
+github.com/go-ldap/ldap/v3 v3.4.13 h1:+x1nG9h+MZN7h/lUi5Q3UZ0fJ1GyDQYbPvbuH38baDQ=
+github.com/go-ldap/ldap/v3 v3.4.13/go.mod h1:LxsGZV6vbaK0sIvYfsv47rfh4ca0JXokCoKjZxsszv0=
github.com/go-logr/logr v1.2.2/go.mod h1:jdQByPbusPIv2/zmleS9BjJVeZ6kBagPoEUsqbVz/1A=
github.com/go-logr/logr v1.4.3 h1:CjnDlHq8ikf6E492q6eKboGOC0T8CDaOvkHCIg8idEI=
github.com/go-logr/logr v1.4.3/go.mod h1:9T104GzyrTigFIr8wt5mBrctHMim0Nb2HLGrmQ40KvY=
@@ -229,12 +233,20 @@ github.com/go-sql-driver/mysql v1.9.3/go.mod h1:qn46aNg1333BRMNU69Lq93t8du/dwxI6
github.com/go-task/slim-sprig v0.0.0-20210107165309-348f09dbbbc0/go.mod h1:fyg7847qk6SyHyPtNmDHnmrv/HOrqktSC+C9fM+CJOE=
github.com/go-task/slim-sprig v0.0.0-20230315185526-52ccab3ef572 h1:tfuBGBXKqDEevZMzYi5KSi8KkcZtzBcTgAUUtapy0OI=
github.com/go-task/slim-sprig v0.0.0-20230315185526-52ccab3ef572/go.mod h1:9Pwr4B2jHnOSGXyyzV8ROjYa2ojvAY6HCGYYfMoC3Ls=
+github.com/go-test/deep v1.1.1 h1:0r/53hagsehfO4bzD2Pgr/+RgHqhmf+k1Bpse2cTu1U=
+github.com/go-test/deep v1.1.1/go.mod h1:5C2ZWiW0ErCdrYzpqxLbTX7MG14M9iiw8DgHncVwcsE=
github.com/go-text/render v0.2.0 h1:LBYoTmp5jYiJ4NPqDc2pz17MLmA3wHw1dZSVGcOdeAc=
github.com/go-text/render v0.2.0/go.mod h1:CkiqfukRGKJA5vZZISkjSYrcdtgKQWRa2HIzvwNN5SU=
github.com/go-text/typesetting v0.2.1 h1:x0jMOGyO3d1qFAPI0j4GSsh7M0Q3Ypjzr4+CEVg82V8=
github.com/go-text/typesetting v0.2.1/go.mod h1:mTOxEwasOFpAMBjEQDhdWRckoLLeI/+qrQeBCTGEt6M=
github.com/go-text/typesetting-utils v0.0.0-20241103174707-87a29e9e6066 h1:qCuYC+94v2xrb1PoS4NIDe7DGYtLnU2wWiQe9a1B1c0=
github.com/go-text/typesetting-utils v0.0.0-20241103174707-87a29e9e6066/go.mod h1:DDxDdQEnB70R8owOx3LVpEFvpMK9eeH1o2r0yZhFI9o=
+github.com/go-viper/mapstructure/v2 v2.5.0 h1:vM5IJoUAy3d7zRSVtIwQgBj7BiWtMPfmPEgAXnvj1Ro=
+github.com/go-viper/mapstructure/v2 v2.5.0/go.mod h1:oJDH3BJKyqBA2TXFhDsKDGDTlndYOZ6rGS0BRZIxGhM=
+github.com/go-webauthn/webauthn v0.16.4 h1:R9jqR/cYZa7hRquFF7Za/8qoH/K/TIs1/Q/4CyGN+1Q=
+github.com/go-webauthn/webauthn v0.16.4/go.mod h1:SU2ljAgToTV/YLPI0C05QS4qn+e04WpB5g1RMfcZfS4=
+github.com/go-webauthn/x v0.2.3 h1:8oArS+Rc1SWFLXhE17KZNx258Z4kUSyaDgsSncCO5RA=
+github.com/go-webauthn/x v0.2.3/go.mod h1:tM04GF3V6VYq79AZMl7vbj4q6pz9r7L2criWRzbWhPk=
github.com/goccy/go-yaml v1.18.0 h1:8W7wMFS12Pcas7KU+VVkaiCng+kG8QiFeFwzFb+rwuw=
github.com/goccy/go-yaml v1.18.0/go.mod h1:XBurs7gK8ATbW4ZPGKgcbrY1Br56PdM69F7LkFRi1kA=
github.com/godbus/dbus/v5 v5.1.0 h1:4KLkAxT3aOY8Li4FRJe/KvhoNFFxo0m6fNuFUO8QJUk=
@@ -243,8 +255,8 @@ github.com/gogo/protobuf v1.3.2 h1:Ov1cvc58UF3b5XjBnZv7+opcTcQFZebYjWzi34vdm4Q=
github.com/gogo/protobuf v1.3.2/go.mod h1:P1XiOD3dCwIKUDQYPy72D8LYyHL2YPYrpS2s69NZV8Q=
github.com/golang-jwt/jwt/v4 v4.5.2 h1:YtQM7lnr8iZ+j5q71MGKkNw9Mn7AjHM68uc9g5fXeUI=
github.com/golang-jwt/jwt/v4 v4.5.2/go.mod h1:m21LjoU+eqJr34lmDMbreY2eSTRJ1cv77w39/MY0Ch0=
-github.com/golang-jwt/jwt/v5 v5.3.0 h1:pv4AsKCKKZuqlgs5sUmn4x8UlGa0kEVt/puTpKx9vvo=
-github.com/golang-jwt/jwt/v5 v5.3.0/go.mod h1:fxCRLWMO43lRc8nhHWY6LGqRcf+1gQWArsqaEUEa5bE=
+github.com/golang-jwt/jwt/v5 v5.3.1 h1:kYf81DTWFe7t+1VvL7eS+jKFVWaUnK9cB1qbwn63YCY=
+github.com/golang-jwt/jwt/v5 v5.3.1/go.mod h1:fxCRLWMO43lRc8nhHWY6LGqRcf+1gQWArsqaEUEa5bE=
github.com/golang/mock v1.6.0 h1:ErTB+efbowRARo13NNdxyJji2egdxLGQhRaY+DUumQc=
github.com/golang/mock v1.6.0/go.mod h1:p6yTPP+5HYm5mzsMV8JkE6ZKdX+/wYM6Hr+LicevLPs=
github.com/golang/protobuf v1.2.0/go.mod h1:6lQm79b+lXiMfvg/cZm0SGofjICqVBUtrP5yJMmIC1U=
@@ -276,6 +288,10 @@ github.com/google/go-cmp v0.7.0 h1:wk8382ETsv4JYUZwIsn6YpYiWiBsYLSJiTsyBybVuN8=
github.com/google/go-cmp v0.7.0/go.mod h1:pXiqmnSA92OHEEa9HXL2W4E7lf9JzCmGVUdgjX3N/iU=
github.com/google/go-querystring v1.1.0 h1:AnCroh3fv4ZBgVIf1Iwtovgjaw/GiKJo8M8yD/fhyJ8=
github.com/google/go-querystring v1.1.0/go.mod h1:Kcdr2DB4koayq7X8pmAG4sNG59So17icRSOU623lUBU=
+github.com/google/go-tpm v0.9.8 h1:slArAR9Ft+1ybZu0lBwpSmpwhRXaa85hWtMinMyRAWo=
+github.com/google/go-tpm v0.9.8/go.mod h1:h9jEsEECg7gtLis0upRBQU+GhYVH6jMjrFxI8u6bVUY=
+github.com/google/go-tpm-tools v0.3.13-0.20230620182252-4639ecce2aba h1:qJEJcuLzH5KDR0gKc0zcktin6KSAwL7+jWKBYceddTc=
+github.com/google/go-tpm-tools v0.3.13-0.20230620182252-4639ecce2aba/go.mod h1:EFYHy8/1y2KfgTAsx7Luu7NGhoxtuVHnNo8jE7FikKc=
github.com/google/gofuzz v1.0.0/go.mod h1:dBl0BpW6vV/+mYPU4Po3pmUjxk6FQPldtuIdl/M65Eg=
github.com/google/gopacket v1.1.19 h1:ves8RnFZPGiFnTS0uPQStjwru6uO6h+nlr9j6fL7kF8=
github.com/google/gopacket v1.1.19/go.mod h1:iJ8V8n6KS+z2U1A8pUwu8bW5SyEMkXJB8Yo/Vo+TKTo=
@@ -308,15 +324,29 @@ github.com/hack-pad/safejs v0.1.0/go.mod h1:HdS+bKF1NrE72VoXZeWzxFOVQVUSqZJAG0xN
github.com/hashicorp/errwrap v1.0.0/go.mod h1:YH+1FKiLXxHSkmPseP+kNlulaMuP3n2brvKWEqk/Jc4=
github.com/hashicorp/errwrap v1.1.0 h1:OxrOeh75EUXMY8TBjag2fzXGZ40LB6IKw45YeGUDY2I=
github.com/hashicorp/errwrap v1.1.0/go.mod h1:YH+1FKiLXxHSkmPseP+kNlulaMuP3n2brvKWEqk/Jc4=
+github.com/hashicorp/go-cleanhttp v0.5.2 h1:035FKYIWjmULyFRBKPs8TBQoi0x6d9G4xc9neXJWAZQ=
+github.com/hashicorp/go-cleanhttp v0.5.2/go.mod h1:kO/YDlP8L1346E6Sodw+PrpBSV4/SoxCXGY6BqNFT48=
+github.com/hashicorp/go-hclog v1.6.3 h1:Qr2kF+eVWjTiYmU7Y31tYlP1h0q/X3Nl3tPGdaB11/k=
+github.com/hashicorp/go-hclog v1.6.3/go.mod h1:W4Qnvbt70Wk/zYJryRzDRU/4r0kIg0PVHBcfoyhpF5M=
github.com/hashicorp/go-multierror v1.1.1 h1:H5DkEtf6CXdFp0N0Em5UCwQpXMWke8IA0+lD48awMYo=
github.com/hashicorp/go-multierror v1.1.1/go.mod h1:iw975J/qwKPdAO1clOe2L8331t/9/fmwbPZ6JB6eMoM=
+github.com/hashicorp/go-retryablehttp v0.7.8 h1:ylXZWnqa7Lhqpk0L1P1LzDtGcCR0rPVUrx/c8Unxc48=
+github.com/hashicorp/go-retryablehttp v0.7.8/go.mod h1:rjiScheydd+CxvumBsIrFKlx3iS0jrZ7LvzFGFmuKbw=
github.com/hashicorp/go-secure-stdlib/base62 v0.1.2 h1:ET4pqyjiGmY09R5y+rSd70J2w45CtbWDNvGqWp/R3Ng=
github.com/hashicorp/go-secure-stdlib/base62 v0.1.2/go.mod h1:EdWO6czbmthiwZ3/PUsDV+UD1D5IRU4ActiaWGwt0Yw=
+github.com/hashicorp/go-secure-stdlib/parseutil v0.2.0 h1:U+kC2dOhMFQctRfhK0gRctKAPTloZdMU5ZJxaesJ/VM=
+github.com/hashicorp/go-secure-stdlib/parseutil v0.2.0/go.mod h1:Ll013mhdmsVDuoIXVfBtvgGJsXDYkTw1kooNcoCXuE0=
+github.com/hashicorp/go-secure-stdlib/strutil v0.1.2 h1:kes8mmyCpxJsI7FTwtzRqEy9CdjCtrXrXGuOpxEA7Ts=
+github.com/hashicorp/go-secure-stdlib/strutil v0.1.2/go.mod h1:Gou2R9+il93BqX25LAKCLuM+y9U2T4hlwvT1yprcna4=
+github.com/hashicorp/go-sockaddr v1.0.7 h1:G+pTkSO01HpR5qCxg7lxfsFEZaG+C0VssTy/9dbT+Fw=
+github.com/hashicorp/go-sockaddr v1.0.7/go.mod h1:FZQbEYa1pxkQ7WLpyXJ6cbjpT8q0YgQaK/JakXqGyWw=
github.com/hashicorp/go-uuid v1.0.2/go.mod h1:6SBZvOh/SIDV7/2o3Jml5SYk/TvGqwFJ/bN7x4byOro=
github.com/hashicorp/go-uuid v1.0.3 h1:2gKiV6YVmrJ1i2CKKa9obLvRieoRGviZFL26PcT/Co8=
github.com/hashicorp/go-uuid v1.0.3/go.mod h1:6SBZvOh/SIDV7/2o3Jml5SYk/TvGqwFJ/bN7x4byOro=
github.com/hashicorp/go-version v1.7.0 h1:5tqGy27NaOTB8yJKUZELlFAS/LTKJkrmONwQKeRZfjY=
github.com/hashicorp/go-version v1.7.0/go.mod h1:fltr4n8CU8Ke44wwGCBoEymUuxUHl09ZGVZPK5anwXA=
+github.com/hashicorp/hcl v1.0.1-vault-7 h1:ag5OxFVy3QYTFTJODRzTKVZ6xvdfLLCA1cy/Y6xGI0I=
+github.com/hashicorp/hcl v1.0.1-vault-7/go.mod h1:XYhtn6ijBSAj6n4YqAaf7RBPS4I06AItNorpy+MoQNM=
github.com/hpcloud/tail v1.0.0/go.mod h1:ab1qPbhIpdTxEkNHXyeSf5vhxWSCs/tWer42PpOxQnU=
github.com/huandu/xstrings v1.5.0 h1:2ag3IFq9ZDANvthTwTiqSSZLjDc+BedvHPAp5tJy2TI=
github.com/huandu/xstrings v1.5.0/go.mod h1:y5/lhBue+AyNmUVz9RLU9xbLR0o4KIIExikq4ovT0aE=
@@ -387,8 +417,8 @@ github.com/kr/text v0.2.0/go.mod h1:eLer722TekiGuMkidMxC/pM04lWEeraHUUmBw8l2grE=
github.com/kylelemons/godebug v1.1.0 h1:RPNrshWIDI6G2gRW9EHilWtl7Z6Sb1BR0xunSBf0SNc=
github.com/kylelemons/godebug v1.1.0/go.mod h1:9/0rRGxNHcop5bhtWyNeEfOS8JIWk580+fNqagV/RAw=
github.com/leodido/go-urn v1.1.0/go.mod h1:+cyI34gQWZcE1eQU7NVgKkkzdXDQHr1dBMtdAPozLkw=
-github.com/lib/pq v1.10.9 h1:YXG7RB+JIjhP29X+OtkiDnYaXQwpS4JEWq7dtCCRUEw=
-github.com/lib/pq v1.10.9/go.mod h1:AlVN5x4E4T544tWzH6hKfbfQvm3HdbOxrmggDNAPY9o=
+github.com/lib/pq v1.12.3 h1:tTWxr2YLKwIvK90ZXEw8GP7UFHtcbTtty8zsI+YjrfQ=
+github.com/lib/pq v1.12.3/go.mod h1:/p+8NSbOcwzAEI7wiMXFlgydTwcgTr3OSKMsD2BitpA=
github.com/libdns/libdns v0.2.2 h1:O6ws7bAfRPaBsgAYt8MDe2HcNBGC29hkZ9MX2eUSX3s=
github.com/libdns/libdns v0.2.2/go.mod h1:4Bj9+5CQiNMVGf87wjX4CY3HQJypUHRuLvlsfsZqLWQ=
github.com/libdns/route53 v1.5.0 h1:2SKdpPFl/qgWsXQvsLNJJAoX7rSxlk7zgoL4jnWdXVA=
@@ -406,9 +436,13 @@ github.com/magiconair/properties v1.8.10 h1:s31yESBquKXCV9a/ScB3ESkOjUYYv+X0rg8S
github.com/magiconair/properties v1.8.10/go.mod h1:Dhd985XPs7jluiymwWYZ0G4Z61jb3vdS329zhj2hYo0=
github.com/mattermost/xml-roundtrip-validator v0.1.0 h1:RXbVD2UAl7A7nOTR4u7E3ILa4IbtvKBHw64LDsmu9hU=
github.com/mattermost/xml-roundtrip-validator v0.1.0/go.mod h1:qccnGMcpgwcNaBnxqpJpWWUiPNr5H3O8eDgGV9gT5To=
+github.com/mattn/go-colorable v0.1.14 h1:9A9LHSqF/7dyVVX6g0U9cwm9pG3kP9gSzcuIPHPsaIE=
+github.com/mattn/go-colorable v0.1.14/go.mod h1:6LmQG8QLFO4G5z1gPvYEzlUgJ2wF+stgPZH1UqBm1s8=
github.com/mattn/go-isatty v0.0.9/go.mod h1:YNRxwqDuOph6SZLI9vUUz6OYw3QyUt7WiY2yME+cCiQ=
-github.com/mattn/go-sqlite3 v1.14.32 h1:JD12Ag3oLy1zQA+BNn74xRgaBbdhbNIDYvQUEuuErjs=
-github.com/mattn/go-sqlite3 v1.14.32/go.mod h1:Uh1q+B4BYcTPb+yiD3kU8Ct7aC0hY9fxUwlHK0RXw+Y=
+github.com/mattn/go-isatty v0.0.20 h1:xfD0iDuEKnDkl03q4limB+vH+GxLEtL/jb4xVJSWWEY=
+github.com/mattn/go-isatty v0.0.20/go.mod h1:W+V8PltTTMOvKvAeJH7IuucS94S2C6jfK/D7dTCTo3Y=
+github.com/mattn/go-sqlite3 v1.14.42 h1:MigqEP4ZmHw3aIdIT7T+9TLa90Z6smwcthx+Azv4Cgo=
+github.com/mattn/go-sqlite3 v1.14.42/go.mod h1:pjEuOr8IwzLJP2MfGeTb0A35jauH+C2kbHKBr7yXKVQ=
github.com/mdelapenya/tlscert v0.2.0 h1:7H81W6Z/4weDvZBNOfQte5GpIMo0lGYEeWbkGp5LJHI=
github.com/mdelapenya/tlscert v0.2.0/go.mod h1:O4njj3ELLnJjGdkN7M/vIVCpZ+Cf0L6muqOG4tLSl8o=
github.com/mdlayher/genetlink v1.3.2 h1:KdrNKe+CTu+IbZnm/GVUMXSqBBLqcGpRDa0xkQy56gw=
@@ -421,8 +455,8 @@ github.com/mdp/qrterminal/v3 v3.2.1 h1:6+yQjiiOsSuXT5n9/m60E54vdgFsw0zhADHhHLrFe
github.com/mdp/qrterminal/v3 v3.2.1/go.mod h1:jOTmXvnBsMy5xqLniO0R++Jmjs2sTm9dFSuQ5kpz/SU=
github.com/mholt/acmez/v2 v2.0.1 h1:3/3N0u1pLjMK4sNEAFSI+bcvzbPhRpY383sy1kLHJ6k=
github.com/mholt/acmez/v2 v2.0.1/go.mod h1:fX4c9r5jYwMyMsC+7tkYRxHibkOTgta5DIFGoe67e1U=
-github.com/miekg/dns v1.1.59 h1:C9EXc/UToRwKLhK5wKU/I4QVsBUc8kE6MkHBkeypWZs=
-github.com/miekg/dns v1.1.59/go.mod h1:nZpewl5p6IvctfgrckopVx2OlSEHPRO/U4SYkRklrEk=
+github.com/miekg/dns v1.1.72 h1:vhmr+TF2A3tuoGNkLDFK9zi36F2LS+hKTRW0Uf8kbzI=
+github.com/miekg/dns v1.1.72/go.mod h1:+EuEPhdHOsfk6Wk5TT2CzssZdqkmFhf8r+aVyDEToIs=
github.com/mikioh/ipaddr v0.0.0-20190404000644-d465c8ab6721 h1:RlZweED6sbSArvlE924+mUcZuXKLBHA35U7LN621Bws=
github.com/mikioh/ipaddr v0.0.0-20190404000644-d465c8ab6721/go.mod h1:Ickgr2WtCLZ2MDGd4Gr0geeCH5HybhRJbonOgQpvSxc=
github.com/mitchellh/copystructure v1.2.0 h1:vpKXTN4ewci03Vljg/q9QvCGUDttBOGBIa15WveJJGw=
@@ -451,8 +485,10 @@ github.com/morikuni/aec v1.0.0 h1:nP9CBfwrvYnBRgY6qfDQkygYDmYwOilePFkwzv4dU8A=
github.com/morikuni/aec v1.0.0/go.mod h1:BbKIizmSmc5MMPqRYbxO4ZU0S0+P200+tUnFx7PXmsc=
github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 h1:C3w9PqII01/Oq1c1nUAm88MOHcQC9l5mIlSMApZMrHA=
github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822/go.mod h1:+n7T8mK8HuQTcFwEeznm/DIxMOiR9yIdICNftLE1DvQ=
-github.com/netbirdio/dex v0.244.0 h1:1GOvi8wnXYassnKGildzNqRHq0RbcfEUw7LKYpKIN7U=
-github.com/netbirdio/dex v0.244.0/go.mod h1:STGInJhPcAflrHmDO7vyit2kSq03PdL+8zQPoGALtcU=
+github.com/netbirdio/dex v0.244.1-0.20260512110716-8d70ad8647c1 h1:4TaYr9O4xX0D2kszeOLclTiCbA3eHq3xWV+9ILJbIYs=
+github.com/netbirdio/dex v0.244.1-0.20260512110716-8d70ad8647c1/go.mod h1:IHH+H8vK2GfqtIt5u/5OdPh18yk0oDHuj2vz5+Goetg=
+github.com/netbirdio/dex/api/v2 v2.0.0-20260512110716-8d70ad8647c1 h1:neE7z+FPUkldl3faK/Jt+hJK2L+1XfQ1W33TQhU9m88=
+github.com/netbirdio/dex/api/v2 v2.0.0-20260512110716-8d70ad8647c1/go.mod h1:awuTyT29CYALpEyET0S307EgNlPWrc7fFKRAyhsO45M=
github.com/netbirdio/easyjson v0.9.0 h1:6Nw2lghSVuy8RSkAYDhDv1thBVEmfVbKZnV7T7Z6Aus=
github.com/netbirdio/easyjson v0.9.0/go.mod h1:1+xMtQp2MRNVL/V1bOzuP3aP8VNwRW55fQUto+XFtTU=
github.com/netbirdio/ice/v4 v4.0.0-20250908184934-6202be846b51 h1:Ov4qdafATOgGMB1wbSuh+0aAHcwz9hdvB6VZjh1mVMI=
@@ -489,6 +525,8 @@ github.com/onsi/gomega v1.7.1/go.mod h1:XdKZgCCFLUoM/7CFJVPcG8C1xQ1AJ0vpAezJrB7J
github.com/onsi/gomega v1.10.1/go.mod h1:iN09h71vgCQne3DLsj+A5owkum+a2tYe+TOCB1ybHNo=
github.com/onsi/gomega v1.27.6 h1:ENqfyGeS5AX/rlXDd/ETokDz93u0YufY1Pgxuy/PvWE=
github.com/onsi/gomega v1.27.6/go.mod h1:PIQNjfQwkP3aQAH7lf7j87O/5FiNr+ZR8+ipb+qQlhg=
+github.com/openbao/openbao/api/v2 v2.5.1 h1:Br79D6L20SbAa5P7xqENxmvv8LyI4HoKosPy7klhn4o=
+github.com/openbao/openbao/api/v2 v2.5.1/go.mod h1:Dh5un77tqGgMbmlVEqjqN+8/dMyUohnkaQVg/wXW0Ig=
github.com/opencontainers/go-digest v1.0.0 h1:apOUWs51W5PlhuyGyz9FCeeBIOUDA/6nW8Oi/yOhh5U=
github.com/opencontainers/go-digest v1.0.0/go.mod h1:0JzlMkj0TRzQZfJkVvzbP0HBR3IKzErnv2BNG4W4MAM=
github.com/opencontainers/image-spec v1.1.1 h1:y0fUlFfIZhPF1W537XOLg0/fcx6zcHCJwooC2xJA040=
@@ -501,6 +539,8 @@ github.com/pelletier/go-toml/v2 v2.2.4 h1:mye9XuhQ6gvn5h28+VilKrrPoQVanw5PMw/TB0
github.com/pelletier/go-toml/v2 v2.2.4/go.mod h1:2gIqNv+qfxSVS7cM2xJQKtLSTLUE9V8t9Stt+h56mCY=
github.com/petermattis/goid v0.0.0-20250303134427-723919f7f203 h1:E7Kmf11E4K7B5hDti2K2NqPb1nlYlGYsu02S1JNd/Bs=
github.com/petermattis/goid v0.0.0-20250303134427-723919f7f203/go.mod h1:pxMtw7cyUw6B2bRH0ZBANSPg+AoSud1I1iyJHI69jH4=
+github.com/philhofer/fwd v1.2.0 h1:e6DnBTl7vGY+Gz322/ASL4Gyp1FspeMvx1RNDoToZuM=
+github.com/philhofer/fwd v1.2.0/go.mod h1:RqIHx9QI14HlwKwm98g9Re5prTQ6LdeRQn+gXJFxsJM=
github.com/pion/dtls/v2 v2.2.7/go.mod h1:8WiMkebSHFD0T+dIU+UeBaoV7kDhOW5oDCzZ7WZ/F9s=
github.com/pion/dtls/v2 v2.2.10 h1:u2Axk+FyIR1VFTPurktB+1zoEPGIW3bmyj3LEFrXjAA=
github.com/pion/dtls/v2 v2.2.10/go.mod h1:d9SYc9fch0CqK90mRk1dC7AkzzpwJj6u2GU3u+9pqFE=
@@ -542,6 +582,8 @@ github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2/go.mod h1:iKH
github.com/power-devops/perfstat v0.0.0-20210106213030-5aafc221ea8c/go.mod h1:OmDBASR4679mdNQnz2pUhc2G8CO2JrUAVFDRBDP/hJE=
github.com/power-devops/perfstat v0.0.0-20240221224432-82ca36839d55 h1:o4JXh1EVt9k/+g42oCprj/FisM4qX9L3sZB3upGN2ZU=
github.com/power-devops/perfstat v0.0.0-20240221224432-82ca36839d55/go.mod h1:OmDBASR4679mdNQnz2pUhc2G8CO2JrUAVFDRBDP/hJE=
+github.com/pquerna/otp v1.5.0 h1:NMMR+WrmaqXU4EzdGJEE1aUUI0AMRzsp96fFFWNPwxs=
+github.com/pquerna/otp v1.5.0/go.mod h1:dkJfzwRKNiegxyNb54X/3fLwhCynbMspSyWKnvi1AEg=
github.com/prometheus/client_golang v1.23.2 h1:Je96obch5RDVy3FDMndoUsjAhG5Edi49h0RJWRi/o0o=
github.com/prometheus/client_golang v1.23.2/go.mod h1:Tb1a6LWHB3/SPIzCoaDXI4I8UHKeFTEQ1YCr+0Gyqmg=
github.com/prometheus/client_model v0.6.2 h1:oBsgwpGs7iVziMvrGhE53c/GrLUsZdHnqNwqPLxwZyk=
@@ -565,6 +607,8 @@ github.com/rs/xid v1.3.0/go.mod h1:trrq9SKmegXys3aeAKXMUTdJsYXVwGY3RLcfgqegfbg=
github.com/russellhaering/goxmldsig v1.6.0 h1:8fdWXEPh2k/NZNQBPFNoVfS3JmzS4ZprY/sAOpKQLks=
github.com/russellhaering/goxmldsig v1.6.0/go.mod h1:TrnaquDcYxWXfJrOjeMBTX4mLBeYAqaHEyUeWPxZlBM=
github.com/russross/blackfriday/v2 v2.1.0/go.mod h1:+Rmxgy9KzJVeS9/2gXHxylqXiyQDYRxCVz55jmeOWTM=
+github.com/ryanuber/go-glob v1.0.0 h1:iQh3xXAumdQ+4Ufa5b25cRpC5TYKlno6hsv6Cb3pkBk=
+github.com/ryanuber/go-glob v1.0.0/go.mod h1:807d1WSdnB0XRJzKNil9Om6lcp/3a0v4qIHxIXzX/Yc=
github.com/rymdport/portal v0.4.2 h1:7jKRSemwlTyVHHrTGgQg7gmNPJs88xkbKcIL3NlcmSU=
github.com/rymdport/portal v0.4.2/go.mod h1:kFF4jslnJ8pD5uCi17brj/ODlfIidOxlgUDTO5ncnC4=
github.com/shirou/gopsutil/v3 v3.24.4 h1:dEHgzZXt4LMNm+oYELpzl9YCqV65Yr/6SfrvgRBtXeU=
@@ -587,8 +631,8 @@ github.com/songgao/water v0.0.0-20200317203138-2b4b6d7c09d8 h1:TG/diQgUe0pntT/2D
github.com/songgao/water v0.0.0-20200317203138-2b4b6d7c09d8/go.mod h1:P5HUIBuIWKbyjl083/loAegFkfbFNx5i2qEP4CNbm7E=
github.com/spf13/cast v1.7.0 h1:ntdiHjuueXFgm5nzDRdOS4yfT43P5Fnud6DH50rz/7w=
github.com/spf13/cast v1.7.0/go.mod h1:ancEpBxwJDODSW/UG4rDrAqiKolqNNh2DX3mk86cAdo=
-github.com/spf13/cobra v1.10.1 h1:lJeBwCfmrnXthfAupyUTzJ/J4Nc1RsHC/mSRU2dll/s=
-github.com/spf13/cobra v1.10.1/go.mod h1:7SmJGaTHFVBY0jW4NXGluQoLvhqFQM+6XSKD+P4XaB0=
+github.com/spf13/cobra v1.10.2 h1:DMTTonx5m65Ic0GOoRY2c16WCbHxOOw6xxezuLaBpcU=
+github.com/spf13/cobra v1.10.2/go.mod h1:7C1pvHqHw5A4vrJfjNwvOdzYu0Gml16OCs2GRiTUUS4=
github.com/spf13/pflag v1.0.9 h1:9exaQaMOCwffKiiiYk6/BndUBv+iRViNW+4lEMi0PvY=
github.com/spf13/pflag v1.0.9/go.mod h1:McXfInJRrz4CZXVZOBLb0bTZqETkiAhM9Iw0y3An2Bg=
github.com/spkg/bom v0.0.0-20160624110644-59b7046e48ad/go.mod h1:qLr4V1qq6nMqFKkMo8ZTx3f+BZEkzsRUY10Xsm2mwU0=
@@ -628,6 +672,8 @@ github.com/ti-mo/conntrack v0.5.1 h1:opEwkFICnDbQc0BUXl73PHBK0h23jEIFVjXsqvF4GY0
github.com/ti-mo/conntrack v0.5.1/go.mod h1:T6NCbkMdVU4qEIgwL0njA6lw/iCAbzchlnwm1Sa314o=
github.com/ti-mo/netfilter v0.5.2 h1:CTjOwFuNNeZ9QPdRXt1MZFLFUf84cKtiQutNauHWd40=
github.com/ti-mo/netfilter v0.5.2/go.mod h1:Btx3AtFiOVdHReTDmP9AE+hlkOcvIy403u7BXXbWZKo=
+github.com/tinylib/msgp v1.6.3 h1:bCSxiTz386UTgyT1i0MSCvdbWjVW+8sG3PjkGsZQt4s=
+github.com/tinylib/msgp v1.6.3/go.mod h1:RSp0LW9oSxFut3KzESt5Voq4GVWyS+PSulT77roAqEA=
github.com/tklauser/go-sysconf v0.3.12/go.mod h1:Ho14jnntGE1fpdOqQEEaiKRpvIavV0hSfmBq8nJbHYI=
github.com/tklauser/go-sysconf v0.3.15 h1:VE89k0criAymJ/Os65CSn1IXaol+1wrsFHEB8Ol49K4=
github.com/tklauser/go-sysconf v0.3.15/go.mod h1:Dmjwr6tYFIseJw7a3dRLJfsHAMXZ3nEnL/aZY+0IuI4=
@@ -646,6 +692,8 @@ github.com/vmihailenco/tagparser/v2 v2.0.0 h1:y09buUbR+b5aycVFQs/g70pqKVZNBmxwAh
github.com/vmihailenco/tagparser/v2 v2.0.0/go.mod h1:Wri+At7QHww0WTrCBeu4J6bNtoV6mEfg5OIWRZA9qds=
github.com/wlynxg/anet v0.0.5 h1:J3VJGi1gvo0JwZ/P1/Yc/8p63SoW98B5dHkYDmpgvvU=
github.com/wlynxg/anet v0.0.5/go.mod h1:eay5PRQr7fIVAMbTbchTnO9gG65Hg/uYGdc7mguHxoA=
+github.com/x448/float16 v0.8.4 h1:qLwI1I70+NjRFUR3zs1JPUCgaCXSh3SW62uAKT1mSBM=
+github.com/x448/float16 v0.8.4/go.mod h1:14CWIYCyZA/cWjXOioeEpHeN/83MdbZDRQHoFcYsOfg=
github.com/yuin/goldmark v1.1.27/go.mod h1:3hX8gzYuyVAZsxl0MRgGTJEmQBFcNTphYh9decYSb74=
github.com/yuin/goldmark v1.2.1/go.mod h1:3hX8gzYuyVAZsxl0MRgGTJEmQBFcNTphYh9decYSb74=
github.com/yuin/goldmark v1.3.5/go.mod h1:mwnBkeHKe2W/ZEtQ+71ViKU8L12m81fl3OWwC1Zlc8k=
@@ -690,14 +738,15 @@ go.opentelemetry.io/proto/otlp v1.0.0 h1:T0TX0tmXU8a3CbNXzEKGeU5mIVOdf0oykP+u2lI
go.opentelemetry.io/proto/otlp v1.0.0/go.mod h1:Sy6pihPLfYHkr3NkUbEhGHFhINUSI/v80hjKIs5JXpM=
go.uber.org/goleak v1.3.0 h1:2K3zAYmnTNqV73imy9J1T3WC+gmCePx2hEGkimedGto=
go.uber.org/goleak v1.3.0/go.mod h1:CoHD4mav9JJNrW/WLlf7HGZPjdw8EucARQHekz1X6bE=
-go.uber.org/mock v0.5.2 h1:LbtPTcP8A5k9WPXj54PPPbjcI4Y6lhyOZXn+VS7wNko=
-go.uber.org/mock v0.5.2/go.mod h1:wLlUxC2vVTPTaE3UD51E0BGOAElKrILxhVSDYQLld5o=
+go.uber.org/mock v0.6.0 h1:hyF9dfmbgIX5EfOdasqLsWD6xqpNZlXblLB/Dbnwv3Y=
+go.uber.org/mock v0.6.0/go.mod h1:KiVJ4BqZJaMj4svdfmHM0AUx4NJYO8ZNpPnZn1Z+BBU=
go.uber.org/multierr v1.11.0 h1:blXXJkSxSSfBVBlC76pxqeO+LN3aDfLQo+309xJstO0=
go.uber.org/multierr v1.11.0/go.mod h1:20+QtiLqy0Nd6FdQB9TLXag12DsQkrbs3htMFfDN80Y=
go.uber.org/zap v1.27.0 h1:aJMhYGrd5QSmlpLMr2MftRKl7t8J8PTZPA732ud/XR8=
go.uber.org/zap v1.27.0/go.mod h1:GB2qFLM7cTU87MWRP2mPIjqfIDnGu+VIO4V/SdhGo2E=
go.yaml.in/yaml/v2 v2.4.3 h1:6gvOSjQoTB3vt1l+CU+tSyi/HOjfOjRLJ4YwYZGwRO0=
go.yaml.in/yaml/v2 v2.4.3/go.mod h1:zSxWcmIDjOzPXpjlTTbAsKokqkDNAVtZO0WOMiT90s8=
+go.yaml.in/yaml/v3 v3.0.4/go.mod h1:DhzuOOF2ATzADvBadXxruRBLzYTpT36CKvDb3+aBEFg=
goauthentik.io/api/v3 v3.2023051.3 h1:NebAhD/TeTWNo/9X3/Uj+rM5fG1HaiLOlKTNLQv9Qq4=
goauthentik.io/api/v3 v3.2023051.3/go.mod h1:nYECml4jGbp/541hj8GcylKQG1gVBsKppHy4+7G8u4U=
golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2/go.mod h1:djNgcEr1/C05ACkg1iLfiJU5Ep61QUkGW8qpdssI0+w=
diff --git a/idp/dex/config.go b/idp/dex/config.go
index e686233ad..56ed998c2 100644
--- a/idp/dex/config.go
+++ b/idp/dex/config.go
@@ -51,6 +51,70 @@ type YAMLConfig struct {
// StaticPasswords cause the server use this list of passwords rather than
// querying the storage.
StaticPasswords []Password `yaml:"staticPasswords" json:"staticPasswords"`
+
+ // Sessions holds authentication session configuration.
+ // Requires DEX_SESSIONS_ENABLED=true feature flag.
+ Sessions *Sessions `yaml:"sessions" json:"sessions"`
+
+ // MFA holds multi-factor authentication configuration.
+ MFA MFAConfig `yaml:"mfa" json:"mfa"`
+}
+
+type Sessions struct {
+ // CookieName is the name of the session cookie. Defaults to "dex_session".
+ CookieName string `yaml:"cookieName" json:"cookieName"`
+ // AbsoluteLifetime is the maximum session lifetime from creation. Defaults to "24h".
+ AbsoluteLifetime string `yaml:"absoluteLifetime" json:"absoluteLifetime"`
+ // ValidIfNotUsedFor is the idle timeout. Defaults to "1h".
+ ValidIfNotUsedFor string `yaml:"validIfNotUsedFor" json:"validIfNotUsedFor"`
+ // RememberMeCheckedByDefault controls the default state of the "remember me" checkbox.
+ RememberMeCheckedByDefault *bool `yaml:"rememberMeCheckedByDefault" json:"rememberMeCheckedByDefault"`
+ // CookieEncryptionKey is the AES key for encrypting session cookies.
+ // Must be 16, 24, or 32 bytes for AES-128, AES-192, or AES-256.
+ // If empty, cookies are not encrypted.
+ CookieEncryptionKey string `yaml:"cookieEncryptionKey" json:"cookieEncryptionKey"`
+ // SSOSharedWithDefault is the default SSO sharing policy for clients without explicit ssoSharedWith.
+ // "all" = share with all clients, "none" = share with no one (default: "none").
+ SSOSharedWithDefault string `yaml:"ssoSharedWithDefault" json:"ssoSharedWithDefault"`
+}
+
+type MFAConfig struct {
+ Authenticators []MFAAuthenticator `yaml:"authenticators" json:"authenticators"`
+}
+
+type MFAAuthenticator struct {
+ ID string `yaml:"id" json:"id"`
+ Type string `yaml:"type" json:"type"`
+ Config map[string]interface{} `yaml:"config" json:"config"`
+
+ ConnectorTypes []string `yaml:"connectorTypes" json:"connectorTypes"`
+}
+
+type TOTPConfig struct {
+ Issuer string `yaml:"issuer" json:"issuer"`
+}
+
+// WebAuthnConfig holds configuration for a WebAuthn authenticator.
+type WebAuthnConfig struct {
+ // RPDisplayName is the human-readable relying party name shown in the browser
+ // dialog during key registration and authentication (e.g., "My Company SSO").
+ RPDisplayName string `yaml:"rpDisplayName" json:"rpDisplayName"`
+ // RPID is the relying party identifier โ must match the domain in the browser
+ // address bar. If empty, derived from the issuer URL hostname.
+ // Example: "auth.example.com"
+ RPID string `yaml:"rpID" json:"rpID"`
+ // RPOrigins is the list of allowed origins for WebAuthn ceremonies.
+ // If empty, derived from the issuer URL (scheme + host).
+ // Example: ["https://auth.example.com"]
+ RPOrigins []string `yaml:"rpOrigins" json:"rpOrigins"`
+ // AttestationPreference controls what attestation data the authenticator should provide:
+ // "none" โ don't request attestation (simpler, more private)
+ // "indirect" โ authenticator may anonymize attestation (default)
+ // "direct" โ request full attestation (for enterprise key model verification)
+ AttestationPreference string `yaml:"attestationPreference" json:"attestationPreference"`
+ // Timeout is the duration allowed for the browser WebAuthn ceremony
+ // (registration or login). Defaults to "60s".
+ Timeout string `yaml:"timeout" json:"timeout"`
}
// Web is the config format for the HTTP server.
@@ -116,7 +180,6 @@ type Storage struct {
Config map[string]interface{} `yaml:"config" json:"config"`
}
-// Password represents a static user configuration
type Password storage.Password
func (p *Password) UnmarshalYAML(node *yaml.Node) error {
@@ -429,9 +492,98 @@ func (c *YAMLConfig) Validate() error {
if !c.EnablePasswordDB && len(c.StaticPasswords) != 0 {
return fmt.Errorf("cannot specify static passwords without enabling password db")
}
+
return nil
}
+func buildTotpConfig(auth MFAAuthenticator) (*server.TOTPProvider, error) {
+ data, err := json.Marshal(auth.Config)
+ if err != nil {
+ return nil, fmt.Errorf("failed to marshal TOTP config id: %s - %w", auth.ID, err)
+ }
+
+ var cfg TOTPConfig
+ if err := json.Unmarshal(data, &cfg); err != nil {
+ return nil, fmt.Errorf("failed to parse TOTP config id: %s - %w", auth.ID, err)
+ }
+
+ return server.NewTOTPProvider(cfg.Issuer, auth.ConnectorTypes), nil
+}
+
+func buildWebAuthnConfig(auth MFAAuthenticator, issuerURL string) (*server.WebAuthnProvider, error) {
+ data, err := json.Marshal(auth.Config)
+ if err != nil {
+ return nil, fmt.Errorf("failed to marshal WebAuthn config id: %s - %w", auth.ID, err)
+ }
+
+ var cfg WebAuthnConfig
+ if err := json.Unmarshal(data, &cfg); err != nil {
+ return nil, fmt.Errorf("failed to parse WebAuthn config id: %s - %w", auth.ID, err)
+ }
+
+ provider, err := server.NewWebAuthnProvider(cfg.RPDisplayName, cfg.RPID, cfg.RPOrigins,
+ cfg.AttestationPreference, cfg.Timeout, issuerURL, auth.ConnectorTypes)
+ if err != nil {
+ return nil, fmt.Errorf("failed to create WebAuthn provider id: %s - err: %w", auth.ID, err)
+ }
+
+ return provider, nil
+}
+
+func buildMFAProviders(authenticators []MFAAuthenticator, issuerURL string, logger *slog.Logger) map[string]server.MFAProvider {
+ if len(authenticators) == 0 {
+ return nil
+ }
+
+ providers := make(map[string]server.MFAProvider, len(authenticators))
+ for _, auth := range authenticators {
+ switch auth.Type {
+ case "TOTP":
+ provider, err := buildTotpConfig(auth)
+ if err != nil {
+ logger.Error("failed to parse TOTP config", "id", auth.ID, "err", err)
+ continue
+ }
+ providers[auth.ID] = provider
+ logger.Info("MFA authenticator configured", "id", auth.ID, "type", auth.Type)
+ case "WebAuthn":
+ provider, err := buildWebAuthnConfig(auth, issuerURL)
+ if err != nil {
+ logger.Error("failed to parse WebAuthn config", "id", auth.ID, "err", err)
+ continue
+ }
+ providers[auth.ID] = provider
+ logger.Info("MFA authenticator configured", "id", auth.ID, "type", auth.Type)
+ default:
+ logger.Error("unknown MFA authenticator type, skipping", "id", auth.ID, "type", auth.Type)
+ }
+ }
+ return providers
+}
+
+func buildSessionsConfig(sessions *Sessions) *server.SessionConfig {
+ if sessions == nil {
+ return nil
+ }
+
+ if sessions.RememberMeCheckedByDefault == nil {
+ defaultRememberMeCheckedByDefault := false
+ sessions.RememberMeCheckedByDefault = &defaultRememberMeCheckedByDefault
+ }
+
+ absoluteLifetime, _ := parseDuration(sessions.AbsoluteLifetime)
+ validIfNotUsedFor, _ := parseDuration(sessions.ValidIfNotUsedFor)
+
+ return &server.SessionConfig{
+ CookieEncryptionKey: []byte(sessions.CookieEncryptionKey),
+ CookieName: sessions.CookieName,
+ AbsoluteLifetime: absoluteLifetime,
+ ValidIfNotUsedFor: validIfNotUsedFor,
+ RememberMeCheckedByDefault: *sessions.RememberMeCheckedByDefault,
+ SSOSharedWithDefault: sessions.SSOSharedWithDefault,
+ }
+}
+
// ToServerConfig converts YAMLConfig to dex server.Config
func (c *YAMLConfig) ToServerConfig(stor storage.Storage, logger *slog.Logger) server.Config {
cfg := server.Config{
@@ -448,6 +600,8 @@ func (c *YAMLConfig) ToServerConfig(stor storage.Storage, logger *slog.Logger) s
Dir: c.Frontend.Dir,
Extra: c.Frontend.Extra,
},
+ SessionConfig: buildSessionsConfig(c.Sessions),
+ MFAProviders: buildMFAProviders(c.MFA.Authenticators, c.Issuer, logger),
}
// Use embedded NetBird-styled templates if no custom dir specified
@@ -460,11 +614,6 @@ func (c *YAMLConfig) ToServerConfig(stor storage.Storage, logger *slog.Logger) s
}
// Apply expiry settings
- if c.Expiry.SigningKeys != "" {
- if d, err := parseDuration(c.Expiry.SigningKeys); err == nil {
- cfg.RotateKeysAfter = d
- }
- }
if c.Expiry.IDTokens != "" {
if d, err := parseDuration(c.Expiry.IDTokens); err == nil {
cfg.IDTokensValidFor = d
diff --git a/idp/dex/provider.go b/idp/dex/provider.go
index 24aed1b99..526d6a17a 100644
--- a/idp/dex/provider.go
+++ b/idp/dex/provider.go
@@ -18,6 +18,7 @@ import (
dexapi "github.com/dexidp/dex/api/v2"
"github.com/dexidp/dex/server"
+ "github.com/dexidp/dex/server/signer"
"github.com/dexidp/dex/storage"
"github.com/dexidp/dex/storage/sql"
jose "github.com/go-jose/go-jose/v4"
@@ -70,7 +71,7 @@ func NewProvider(ctx context.Context, config *Config) (*Provider, error) {
logger := slog.New(slog.NewTextHandler(os.Stderr, nil))
// Ensure data directory exists
- if err := os.MkdirAll(config.DataDir, 0700); err != nil {
+ if err := os.MkdirAll(config.DataDir, 0o700); err != nil {
return nil, fmt.Errorf("failed to create data directory: %w", err)
}
@@ -101,6 +102,15 @@ func NewProvider(ctx context.Context, config *Config) (*Provider, error) {
return nil, fmt.Errorf("failed to create refresh token policy: %w", err)
}
+ localSignerConfig := signer.LocalConfig{
+ KeysRotationPeriod: "6h",
+ }
+
+ localSigner, err := localSignerConfig.Open(ctx, stor, 24*time.Hour, time.Now, logger)
+ if err != nil {
+ return nil, fmt.Errorf("failed to create local signer: %w", err)
+ }
+
// Build Dex server config - use Dex's types directly
dexConfig := server.Config{
Issuer: issuer,
@@ -110,12 +120,12 @@ func NewProvider(ctx context.Context, config *Config) (*Provider, error) {
ContinueOnConnectorFailure: true,
Logger: logger,
PrometheusRegistry: prometheus.NewRegistry(),
- RotateKeysAfter: 6 * time.Hour,
IDTokensValidFor: 24 * time.Hour,
RefreshTokenPolicy: refreshPolicy,
Web: server.WebConfig{
Issuer: "NetBird",
},
+ Signer: localSigner,
}
dexSrv, err := server.NewServer(ctx, dexConfig)
@@ -167,6 +177,14 @@ func NewProviderFromYAML(ctx context.Context, yamlConfig *YAMLConfig) (*Provider
return nil, fmt.Errorf("failed to create refresh token policy: %w", err)
}
+ localSigner, err := getSigner(ctx, stor, yamlConfig, logger)
+ if err != nil {
+ stor.Close()
+ return nil, fmt.Errorf("failed to create local signer: %w", err)
+ }
+
+ dexConfig.Signer = localSigner
+
dexSrv, err := server.NewServer(ctx, dexConfig)
if err != nil {
stor.Close()
@@ -182,6 +200,32 @@ func NewProviderFromYAML(ctx context.Context, yamlConfig *YAMLConfig) (*Provider
}, nil
}
+func getSigner(ctx context.Context, stor storage.Storage, yamlConfig *YAMLConfig, logger *slog.Logger) (signer.Signer, error) {
+ // Parse expiry durations
+ idTokensValidFor := 24 * time.Hour // default
+ if yamlConfig.Expiry.IDTokens != "" {
+ var err error
+ idTokensValidFor, err = parseDuration(yamlConfig.Expiry.IDTokens)
+ if err != nil {
+ return nil, fmt.Errorf("invalid config value %q for id token expiry: %v", yamlConfig.Expiry.IDTokens, err)
+ }
+ }
+
+ localSignerConfig := &signer.LocalConfig{
+ KeysRotationPeriod: "720h", // 30 Days
+ }
+
+ if yamlConfig.Expiry.SigningKeys != "" {
+ if _, err := parseDuration(yamlConfig.Expiry.SigningKeys); err != nil {
+ return nil, fmt.Errorf("invalid config value %q for signing key expiry: %v", yamlConfig.Expiry.SigningKeys, err)
+ }
+
+ localSignerConfig.KeysRotationPeriod = yamlConfig.Expiry.SigningKeys
+ }
+
+ return localSignerConfig.Open(ctx, stor, idTokensValidFor, time.Now, logger)
+}
+
// initializeStorage sets up connectors, passwords, and clients in storage
func initializeStorage(ctx context.Context, stor storage.Storage, cfg *YAMLConfig) error {
if cfg.EnablePasswordDB {
@@ -241,6 +285,8 @@ func ensureStaticClients(ctx context.Context, stor storage.Storage, clients []st
old.RedirectURIs = client.RedirectURIs
old.Name = client.Name
old.Public = client.Public
+ old.PostLogoutRedirectURIs = client.PostLogoutRedirectURIs
+ old.MFAChain = client.MFAChain
return old, nil
}); err != nil {
return fmt.Errorf("failed to update client %s: %w", client.ID, err)
@@ -253,9 +299,6 @@ func ensureStaticClients(ctx context.Context, stor storage.Storage, clients []st
func buildDexConfig(yamlConfig *YAMLConfig, stor storage.Storage, logger *slog.Logger) server.Config {
cfg := yamlConfig.ToServerConfig(stor, logger)
cfg.PrometheusRegistry = prometheus.NewRegistry()
- if cfg.RotateKeysAfter == 0 {
- cfg.RotateKeysAfter = 24 * 30 * time.Hour
- }
if cfg.IDTokensValidFor == 0 {
cfg.IDTokensValidFor = 24 * time.Hour
}
@@ -450,10 +493,34 @@ func (p *Provider) Storage() storage.Storage {
return p.storage
}
+// SetClientsMFAChain updates the MFAChain field on the dashboard and CLI OAuth2 clients.
+// Pass a non-empty slice (e.g. []string{"default-totp"}) to enable MFA, or nil to disable it.
+func (p *Provider) SetClientsMFAChain(ctx context.Context, clientIDs []string, mfaChain []string) error {
+ for _, clientID := range clientIDs {
+ if err := p.storage.UpdateClient(ctx, clientID, func(old storage.Client) (storage.Client, error) {
+ old.MFAChain = mfaChain
+ return old, nil
+ }); err != nil {
+ return fmt.Errorf("failed to update MFA chain on client %s: %w", clientID, err)
+ }
+ }
+ return nil
+}
+
// Handler returns the Dex server as an http.Handler for embedding in another server.
// The handler expects requests with path prefix "/oauth2/".
func (p *Provider) Handler() http.Handler {
- return p.dexServer
+ return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+ // Dex's /logout endpoint requires id_token_hint for RP-initiated logout with
+ // post_logout_redirect_uri. If the dashboard calls logout without one, avoid
+ // rendering Dex's non-actionable Bad Request page and send the user home.
+ if strings.HasSuffix(r.URL.Path, "/logout") && r.FormValue("id_token_hint") == "" {
+ http.Redirect(w, r, "/", http.StatusSeeOther)
+ return
+ }
+
+ p.dexServer.ServeHTTP(w, r)
+ })
}
// CreateUser creates a new user with the given email, username, and password.
diff --git a/idp/dex/provider_test.go b/idp/dex/provider_test.go
index 4ed89fd2e..88828fbbb 100644
--- a/idp/dex/provider_test.go
+++ b/idp/dex/provider_test.go
@@ -4,6 +4,8 @@ import (
"context"
"encoding/json"
"log/slog"
+ "net/http"
+ "net/http/httptest"
"os"
"path/filepath"
"testing"
@@ -144,6 +146,30 @@ func TestEncodeDexUserID_MatchesDexFormat(t *testing.T) {
assert.Equal(t, knownEncodedID, reEncoded)
}
+func TestHandlerRedirectsLogoutWithoutIDTokenHint(t *testing.T) {
+ ctx := context.Background()
+
+ tmpDir, err := os.MkdirTemp("", "dex-logout-handler-*")
+ require.NoError(t, err)
+ defer os.RemoveAll(tmpDir)
+
+ provider, err := NewProvider(ctx, &Config{
+ Issuer: "http://localhost:5556/oauth2",
+ Port: 5556,
+ DataDir: tmpDir,
+ })
+ require.NoError(t, err)
+ defer func() { _ = provider.Stop(ctx) }()
+
+ req := httptest.NewRequest(http.MethodGet, "/oauth2/logout?post_logout_redirect_uri=https://example.com", nil)
+ rec := httptest.NewRecorder()
+
+ provider.Handler().ServeHTTP(rec, req)
+
+ require.Equal(t, http.StatusSeeOther, rec.Code)
+ require.Equal(t, "/", rec.Header().Get("Location"))
+}
+
func TestCreateUserInTempDB(t *testing.T) {
ctx := context.Background()
diff --git a/idp/dex/web/templates/home.html b/idp/dex/web/templates/home.html
new file mode 100644
index 000000000..be7c938ae
--- /dev/null
+++ b/idp/dex/web/templates/home.html
@@ -0,0 +1,12 @@
+{{ template "header.html" . }}
+
+
+
+
+{{ template "footer.html" . }}
diff --git a/idp/dex/web/templates/logout.html b/idp/dex/web/templates/logout.html
new file mode 100644
index 000000000..b623d35af
--- /dev/null
+++ b/idp/dex/web/templates/logout.html
@@ -0,0 +1,14 @@
+{{ template "header.html" . }}
+
+