mirror of
https://github.com/netbirdio/netbird.git
synced 2026-10-02 11:39:06 +02:00
[client] Say that the null-on-disk fixture is synthesized, not written
The test comment described the null state in the present tense — "the config a plain login writes leaves every one of them unset" — which was true before this branch and is not any more: apply() now resolves those fields, so a login writes them set. unsetOnDisk puts the null state back deliberately, to stand in for a profile an older client wrote. Comments only.
This commit is contained in:
@@ -371,7 +371,8 @@ func TestAdminURLPathIsPartOfTheIdentity(t *testing.T) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
// unsetOnDisk rewrites the stored config so the named fields carry a JSON null,
|
// unsetOnDisk rewrites the stored config so the named fields carry a JSON null,
|
||||||
// which is how a profile that was never asked about them looks on disk.
|
// which is how a profile written before apply() resolved them looks on disk.
|
||||||
|
// It synthesizes that state: no write produces it any more.
|
||||||
func unsetOnDisk(t *testing.T, path string, fields ...string) {
|
func unsetOnDisk(t *testing.T, path string, fields ...string) {
|
||||||
t.Helper()
|
t.Helper()
|
||||||
|
|
||||||
@@ -392,13 +393,16 @@ func unsetOnDisk(t *testing.T, path string, fields ...string) {
|
|||||||
require.NoError(t, os.WriteFile(path, rewritten, 0600))
|
require.NoError(t, os.WriteFile(path, rewritten, 0600))
|
||||||
}
|
}
|
||||||
|
|
||||||
// Seven fields mean "the effective default" when they hold no value, and the
|
// Seven fields mean "the effective default" when they hold no value, and every
|
||||||
// config a plain login writes leaves every one of them unset. Restating that
|
// profile written before apply() resolved them holds them as null. Restating
|
||||||
// default is asking for no change — and the CLI restates it on every `netbird
|
// that default is asking for no change — and the CLI restates it on every
|
||||||
// up`, because a flag set through an environment variable is a flag pflag
|
// `netbird up`, because a flag set through an environment variable is a flag
|
||||||
// reports as Changed. Judging those restatements as changes made the
|
// pflag reports as Changed. Judging those restatements as changes made the
|
||||||
// update-settings gate refuse `netbird up` outright for a client configured
|
// update-settings gate refuse `netbird up` outright for a client configured
|
||||||
// through the environment, which is the shape of a Kubernetes deployment.
|
// through the environment, which is the shape of a Kubernetes deployment.
|
||||||
|
//
|
||||||
|
// A login now writes those fields set, so the fixture puts the null state back
|
||||||
|
// on disk with unsetOnDisk instead of getting it from a login.
|
||||||
func TestWouldChangeIgnoresRestatedDefaultsOfUnsetFields(t *testing.T) {
|
func TestWouldChangeIgnoresRestatedDefaultsOfUnsetFields(t *testing.T) {
|
||||||
networkMonitorDefault := runtime.GOOS == "windows" || runtime.GOOS == "darwin"
|
networkMonitorDefault := runtime.GOOS == "windows" || runtime.GOOS == "darwin"
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user