From 9d5f3a7b867df34673541ca0423d7efecd33ea50 Mon Sep 17 00:00:00 2001 From: pascal Date: Tue, 9 Jun 2026 17:01:22 +0200 Subject: [PATCH] remove unnecessary tests --- .../server/affected_peers_coverage_test.go | 6 -- .../affected_peers_router_paths_test.go | 46 --------- management/server/affected_peers_test.go | 94 ------------------- 3 files changed, 146 deletions(-) diff --git a/management/server/affected_peers_coverage_test.go b/management/server/affected_peers_coverage_test.go index 6942a603d..a82a66168 100644 --- a/management/server/affected_peers_coverage_test.go +++ b/management/server/affected_peers_coverage_test.go @@ -96,12 +96,6 @@ func TestAffectedPeers_DependencyCoverageMatrix(t *testing.T) { []string{s.sourcePeerID, s.routerPeerID}, []string{s.unrelatedPeerID} }, }, - { - name: "empty-change yields nothing", - build: func(t *testing.T, s *routerScenario, ctx context.Context) (affectedpeers.Change, []string, []string) { - return affectedpeers.Change{}, nil, []string{s.sourcePeerID, s.routerPeerID, s.unrelatedPeerID} - }, - }, } for _, r := range rows { diff --git a/management/server/affected_peers_router_paths_test.go b/management/server/affected_peers_router_paths_test.go index bdd7a6cc4..22db1bee6 100644 --- a/management/server/affected_peers_router_paths_test.go +++ b/management/server/affected_peers_router_paths_test.go @@ -81,20 +81,6 @@ func TestAffectedPeers_PeerChange_SourcePeer_RefreshesRoutingPeer(t *testing.T) assert.NotContains(t, affected, s.unrelatedPeerID, "unrelated peer must not be affected") } -func TestAffectedPeers_PeerChange_RoutingPeer_RefreshesPolicySources(t *testing.T) { - s := setupRouterScenario(t, true) - ctx := context.Background() - - _, err := s.manager.SavePolicy(ctx, s.accountID, userID, peerToResourcePolicyByGroup(s.sourceGroupID, s.resourceGroupID), true) - require.NoError(t, err) - - affected := s.resolvePeerChangeAffected(ctx, []string{s.routerPeerID}) - - assert.Contains(t, affected, s.sourcePeerID, - "a status change on the routing peer must refresh the source peers that route through it") - assert.NotContains(t, affected, s.unrelatedPeerID, "unrelated peer must not be affected") -} - func TestAffectedPeers_PeerChange_SourcePeer_ByDestinationResource_RefreshesRoutingPeer(t *testing.T) { s := setupRouterScenario(t, true) ctx := context.Background() @@ -124,20 +110,6 @@ func TestAffectedPeers_E2E_DeleteGroup_ResolvesAffectedPeers(t *testing.T) { require.NoError(t, s.manager.DeleteGroup(ctx, s.accountID, userID, memberOnlyGroupID)) } -func TestAffectedPeers_DeleteGroup_LinkedGroupIsBlocked(t *testing.T) { - s := setupRouterScenario(t, true) - ctx := context.Background() - - _, err := s.manager.SavePolicy(ctx, s.accountID, userID, peerToResourcePolicyByGroup(s.sourceGroupID, s.resourceGroupID), true) - require.NoError(t, err) - - err = s.manager.DeleteGroup(ctx, s.accountID, userID, s.sourceGroupID) - require.Error(t, err, "deleting a policy-linked group must be blocked by validateDeleteGroup") - - var linkErr *GroupLinkError - require.ErrorAs(t, err, &linkErr, "expected a GroupLinkError") -} - func TestAffectedPeers_GroupAddResource_RefreshesRoutingPeer(t *testing.T) { s := setupRouterScenario(t, true) ctx := context.Background() @@ -163,10 +135,6 @@ func TestAffectedPeers_GroupAddResource_RefreshesRoutingPeer(t *testing.T) { assert.NotContains(t, affected, s.unrelatedPeerID, "unrelated peer must not be affected") } -func (s *routerScenario) resolvePostureCheckAffected(ctx context.Context, postureCheckID string) []string { - return s.manager.ResolveAffectedPeers(ctx, s.manager.Store, s.accountID, affectedpeers.Change{PostureCheckIDs: []string{postureCheckID}}) -} - func (s *routerScenario) createPostureCheckGatedPolicy(t *testing.T, ctx context.Context) string { t.Helper() @@ -186,20 +154,6 @@ func (s *routerScenario) createPostureCheckGatedPolicy(t *testing.T, ctx context return check.ID } -func TestAffectedPeers_PostureCheckChange_RefreshesRoutingPeer(t *testing.T) { - s := setupRouterScenario(t, true) - ctx := context.Background() - - checkID := s.createPostureCheckGatedPolicy(t, ctx) - - affected := s.resolvePostureCheckAffected(ctx, checkID) - - assert.Contains(t, affected, s.sourcePeerID, "policy source peer must be affected by a posture-check change") - assert.Contains(t, affected, s.routerPeerID, - "a posture check gating a peer->resource policy must refresh the resource's routing peer") - assert.NotContains(t, affected, s.unrelatedPeerID, "unrelated peer must not be affected") -} - func TestAffectedPeers_E2E_SavePostureCheck_RefreshesRoutingPeer(t *testing.T) { s := setupRouterScenario(t, true) ctx := context.Background() diff --git a/management/server/affected_peers_test.go b/management/server/affected_peers_test.go index 9e0a26b33..6d49002af 100644 --- a/management/server/affected_peers_test.go +++ b/management/server/affected_peers_test.go @@ -85,28 +85,6 @@ func setupAffectedPeersTest(t *testing.T) (*DefaultAccountManager, store.Store, func affectedGroupID(i int) string { return fmt.Sprintf("affected-grp-%d", i) } func affectedGroupName(i int) string { return fmt.Sprintf("AffectedGroup%d", i) } -func TestCollectGroupChange_NoEntities(t *testing.T) { - _, s, accountID, _, groupIDs := setupAffectedPeersTest(t) - ctx := context.Background() - - groups, directPeers := collectGroupChangeAffectedGroups(ctx, s, accountID, []string{groupIDs[0]}) - assert.Empty(t, groups) - assert.Empty(t, directPeers) -} - -func TestCollectGroupChange_EmptyInput(t *testing.T) { - _, s, accountID, _, _ := setupAffectedPeersTest(t) - ctx := context.Background() - - groups, directPeers := collectGroupChangeAffectedGroups(ctx, s, accountID, nil) - assert.Nil(t, groups) - assert.Nil(t, directPeers) - - groups, directPeers = collectGroupChangeAffectedGroups(ctx, s, accountID, []string{}) - assert.Nil(t, groups) - assert.Nil(t, directPeers) -} - func TestCollectGroupChange_PolicyLinked(t *testing.T) { manager, s, accountID, _, groupIDs := setupAffectedPeersTest(t) ctx := context.Background() @@ -440,50 +418,6 @@ func TestCollectGroupChange_MultipleNameServerGroups_OnlyLinkedAffected(t *testi assert.Empty(t, groups) } -// Pure policy/route/router extraction unit tests moved to the affectedpeers -// package (management/server/affectedpeers) along with the logic they cover. - -func TestResolvePeerIDs_GroupsOnly(t *testing.T) { - manager, s, accountID, peerIDs, groupIDs := setupAffectedPeersTest(t) - ctx := context.Background() - - result := manager.resolvePeerIDs(ctx, s, accountID, []string{groupIDs[0], groupIDs[1]}, nil) - assert.ElementsMatch(t, []string{peerIDs[0], peerIDs[1]}, result) -} - -func TestResolvePeerIDs_WithDirectPeers(t *testing.T) { - manager, s, accountID, peerIDs, groupIDs := setupAffectedPeersTest(t) - ctx := context.Background() - - result := manager.resolvePeerIDs(ctx, s, accountID, []string{groupIDs[0]}, []string{peerIDs[2]}) - assert.ElementsMatch(t, []string{peerIDs[0], peerIDs[2]}, result) -} - -func TestResolvePeerIDs_Deduplication(t *testing.T) { - manager, s, accountID, peerIDs, groupIDs := setupAffectedPeersTest(t) - ctx := context.Background() - - result := manager.resolvePeerIDs(ctx, s, accountID, []string{groupIDs[0]}, []string{peerIDs[0]}) - assert.Len(t, result, 1) - assert.Equal(t, peerIDs[0], result[0]) -} - -func TestResolvePeerIDs_EmptyInputs(t *testing.T) { - manager, s, accountID, _, _ := setupAffectedPeersTest(t) - ctx := context.Background() - - result := manager.resolvePeerIDs(ctx, s, accountID, nil, nil) - assert.Empty(t, result) -} - -func TestResolveAffectedPeers_NoPoliciesOrRoutes(t *testing.T) { - manager, s, accountID, peerIDs, _ := setupAffectedPeersTest(t) - ctx := context.Background() - - result := manager.resolveAffectedPeersForPeerChanges(ctx, s, accountID, []string{peerIDs[0]}) - assert.Empty(t, result) -} - func TestResolveAffectedPeers_PolicyBetweenTwoGroups(t *testing.T) { manager, s, accountID, peerIDs, groupIDs := setupAffectedPeersTest(t) ctx := context.Background() @@ -798,17 +732,6 @@ func TestResolveAffectedPeers_SharedGroupAcrossPolicyAndRoute(t *testing.T) { assert.ElementsMatch(t, []string{peerIDs[0], peerIDs[1], peerIDs[2]}, result) } -func TestResolveAffectedPeers_EmptyChangedPeers(t *testing.T) { - manager, s, accountID, _, _ := setupAffectedPeersTest(t) - ctx := context.Background() - - result := manager.resolveAffectedPeersForPeerChanges(ctx, s, accountID, nil) - assert.Empty(t, result) - - result = manager.resolveAffectedPeersForPeerChanges(ctx, s, accountID, []string{}) - assert.Empty(t, result) -} - func TestResolveAffectedPeers_NoDuplicates(t *testing.T) { manager, s, accountID, peerIDs, groupIDs := setupAffectedPeersTest(t) ctx := context.Background() @@ -841,15 +764,6 @@ func TestResolveAffectedPeers_NoDuplicates(t *testing.T) { assert.Equal(t, 1, count, "peer0 should appear exactly once") } -func TestCollectPostureCheckAffected_NoMatch(t *testing.T) { - _, s, accountID, _, _ := setupAffectedPeersTest(t) - ctx := context.Background() - - groups, directPeers := collectPostureCheckAffectedGroupsAndPeers(ctx, s, accountID, "nonexistent-check") - assert.Empty(t, groups) - assert.Empty(t, directPeers) -} - func TestCollectPostureCheckAffected_LinkedToPolicy(t *testing.T) { manager, s, accountID, _, groupIDs := setupAffectedPeersTest(t) ctx := context.Background() @@ -1827,14 +1741,6 @@ func TestCollectAffectedFromProxyServices_GroupContainingTargetPeerChanged(t *te assert.Contains(t, directPeers, peerIDs[1], "target peer must be refreshed") } -func TestCollectAffectedFromProxyServices_NoServices(t *testing.T) { - manager, _, accountID, peerIDs, _ := setupAffectedPeersTest(t) - ctx := context.Background() - - _, directPeers := collectPeerChangeAffectedGroups(ctx, manager.Store, accountID, nil, []string{peerIDs[0]}) - assert.NotContains(t, directPeers, peerIDs[0], "no services means no proxy contribution") -} - func TestCollectAffectedFromProxyServices_DisabledServiceStillMatches(t *testing.T) { manager, s, accountID, peerIDs, _ := setupAffectedPeersTest(t) ctx := context.Background()