mirror of
https://github.com/netbirdio/netbird.git
synced 2026-10-04 12:39:06 +02:00
Add support for IPv6 networks (on Linux clients) (#1459)
* Feat add basic support for IPv6 networks Newly generated networks automatically generate an IPv6 prefix of size 64 within the ULA address range, devices obtain a randomly generated address within this prefix. Currently, this is Linux only and does not yet support all features (routes currently cause an error). * Fix firewall configuration for IPv6 networks * Fix routing configuration for IPv6 networks * Feat provide info on IPv6 support for specific client to mgmt server * Feat allow configuration of IPv6 support through API, improve stability * Feat add IPv6 support to new firewall implementation * Fix peer list item response not containing IPv6 address * Fix nftables breaking on IPv6 address change * Fix build issues for non-linux systems * Fix intermittent disconnections when IPv6 is enabled * Fix test issues and make some minor revisions * Fix some more testing issues * Fix more CI issues due to IPv6 * Fix more testing issues * Add inheritance of IPv6 enablement status from groups * Fix IPv6 events not having associated messages * Address first review comments regarding IPv6 support * Fix IPv6 table being created even when IPv6 is disabled Also improved stability of IPv6 route and firewall handling on client side * Fix IPv6 routes not being removed * Fix DNS IPv6 issues, limit IPv6 nameservers to IPv6 peers * Improve code for IPv6 DNS server selection, add AAAA custom records * Ensure IPv6 routes can only exist for IPv6 routing peers * Fix IPv6 network generation randomness * Fix a bunch of compilation issues and test failures * Replace method calls that are unavailable in Go 1.21 * Fix nil dereference in cleanUpDefaultForwardRules6 * Fix nil pointer dereference when persisting IPv6 network in sqlite * Clean up of client-side code changes for IPv6 * Fix nil dereference in rule mangling and compilation issues * Add a bunch of client-side test cases for IPv6 * Fix IPv6 tests running on unsupported environments * Fix import cycle in tests * Add missing method SupportsIPv6() for windows * Require IPv6 default route for IPv6 tests * Fix panics in routemanager tests on non-linux * Fix some more route manager tests concerning IPv6 * Add some final client-side tests * Add IPv6 tests for management code, small fixes * Fix linting issues * Fix small test suite issues * Fix linter issues and builds on macOS and Windows again * fix builds for iOS because of IPv6 breakage
This commit is contained in:
Hugo Hakim Damer
@@ -2,6 +2,8 @@ package server
|
||||
|
||||
import (
|
||||
"errors"
|
||||
nbpeer "github.com/netbirdio/netbird/management/server/peer"
|
||||
"github.com/stretchr/testify/require"
|
||||
"testing"
|
||||
|
||||
nbdns "github.com/netbirdio/netbird/dns"
|
||||
@@ -12,6 +14,8 @@ import (
|
||||
|
||||
const (
|
||||
groupAdminUserID = "testingAdminUser"
|
||||
groupPeer1Key = "BhRPtynAAYRDy08+q4HTMsos8fs4plTP4NOSh7C1ry8="
|
||||
groupPeer2Key = "/yF0+vCfv+mRR5k0dca0TrGdO/oiNeAI58gToZm5NyI="
|
||||
)
|
||||
|
||||
func TestDefaultAccountManager_CreateGroup(t *testing.T) {
|
||||
@@ -20,7 +24,7 @@ func TestDefaultAccountManager_CreateGroup(t *testing.T) {
|
||||
t.Error("failed to create account manager")
|
||||
}
|
||||
|
||||
account, err := initTestGroupAccount(am)
|
||||
_, account, err := initTestGroupAccount(am)
|
||||
if err != nil {
|
||||
t.Error("failed to init testing account")
|
||||
}
|
||||
@@ -55,7 +59,7 @@ func TestDefaultAccountManager_DeleteGroup(t *testing.T) {
|
||||
t.Error("failed to create account manager")
|
||||
}
|
||||
|
||||
account, err := initTestGroupAccount(am)
|
||||
_, account, err := initTestGroupAccount(am)
|
||||
if err != nil {
|
||||
t.Error("failed to init testing account")
|
||||
}
|
||||
@@ -131,10 +135,137 @@ func TestDefaultAccountManager_DeleteGroup(t *testing.T) {
|
||||
}
|
||||
}
|
||||
|
||||
func initTestGroupAccount(am *DefaultAccountManager) (*Account, error) {
|
||||
func TestDefaultAccountManager_GroupIPv6Consistency(t *testing.T) {
|
||||
am, err := createManager(t)
|
||||
if err != nil {
|
||||
t.Error("failed to create account manager")
|
||||
}
|
||||
|
||||
peers, account, err := initTestGroupAccount(am)
|
||||
peer1Id := peers[0]
|
||||
peer2Id := peers[1]
|
||||
if err != nil {
|
||||
t.Error("failed to init testing account")
|
||||
}
|
||||
|
||||
group := account.GetGroup("grp-for-ipv6")
|
||||
|
||||
// First, add one member to the IPv6 group before enabling IPv6.
|
||||
group.Peers = append(group.Peers, peer1Id)
|
||||
err = am.SaveGroup(account.Id, groupAdminUserID, group)
|
||||
require.NoError(t, err, "unable to update group")
|
||||
account, err = am.Store.GetAccount(account.Id)
|
||||
require.NoError(t, err, "unable to update account")
|
||||
group = account.GetGroup("grp-for-ipv6")
|
||||
require.Nil(t, account.Peers[peer1Id].IP6, "peer1 should not have an IPv6 address if the group doesn't have it enabled.")
|
||||
require.Nil(t, account.Peers[peer2Id].IP6, "peer2 should not have an IPv6 address.")
|
||||
|
||||
// Now, enable IPv6.
|
||||
group.IPv6Enabled = true
|
||||
err = am.SaveGroup(account.Id, groupAdminUserID, group)
|
||||
require.NoError(t, err, "unable to update group")
|
||||
account, err = am.Store.GetAccount(account.Id)
|
||||
require.NoError(t, err, "unable to update account")
|
||||
group = account.GetGroup("grp-for-ipv6")
|
||||
require.NotNil(t, account.Peers[peer1Id].IP6, "peer1 should have an IPv6 address as it is a member of the IPv6-enabled group.")
|
||||
require.Nil(t, account.Peers[peer2Id].IP6, "peer2 should not have an IPv6 address as it is not a member of the IPv6-enabled group.")
|
||||
|
||||
// Add the second peer.
|
||||
group.Peers = append(group.Peers, peer2Id)
|
||||
err = am.SaveGroup(account.Id, groupAdminUserID, group)
|
||||
require.NoError(t, err, "unable to update group")
|
||||
account, err = am.Store.GetAccount(account.Id)
|
||||
require.NoError(t, err, "unable to update account")
|
||||
group = account.GetGroup("grp-for-ipv6")
|
||||
require.NotNil(t, account.Peers[peer1Id].IP6, "peer1 should have an IPv6 address as it is a member of the IPv6-enabled group.")
|
||||
require.NotNil(t, account.Peers[peer2Id].IP6, "peer2 should have an IPv6 address as it is a member of the IPv6-enabled group.")
|
||||
|
||||
// Disable IPv6 and simultaneously delete the first peer.
|
||||
group.IPv6Enabled = false
|
||||
group.Peers = group.Peers[1:]
|
||||
err = am.SaveGroup(account.Id, groupAdminUserID, group)
|
||||
require.NoError(t, err, "unable to update group")
|
||||
account, err = am.Store.GetAccount(account.Id)
|
||||
require.NoError(t, err, "unable to update account")
|
||||
group = account.GetGroup("grp-for-ipv6")
|
||||
require.Nil(t, account.Peers[peer1Id].IP6, "peer1 should not have an IPv6 address as it is not a member of any IPv6-enabled group.")
|
||||
require.Nil(t, account.Peers[peer2Id].IP6, "peer2 should not have an IPv6 address as the group has IPv6 disabled.")
|
||||
|
||||
// Enable IPv6 and simultaneously add the first peer again.
|
||||
group.IPv6Enabled = true
|
||||
group.Peers = append(group.Peers, peer1Id)
|
||||
err = am.SaveGroup(account.Id, groupAdminUserID, group)
|
||||
require.NoError(t, err, "unable to update group")
|
||||
account, err = am.Store.GetAccount(account.Id)
|
||||
require.NoError(t, err, "unable to update account")
|
||||
require.NotNil(t, account.Peers[peer1Id].IP6, "peer1 should have an IPv6 address as it is a member of the IPv6-enabled group.")
|
||||
require.NotNil(t, account.Peers[peer2Id].IP6, "peer2 should have an IPv6 address as it is a member of the IPv6-enabled group.")
|
||||
|
||||
// Force disable IPv6.
|
||||
peer1 := account.GetPeer(peer1Id)
|
||||
peer2 := account.GetPeer(peer2Id)
|
||||
peer1.V6Setting = nbpeer.V6Disabled
|
||||
peer2.V6Setting = nbpeer.V6Disabled
|
||||
_, err = am.UpdatePeer(account.Id, groupAdminUserID, peer1)
|
||||
require.NoError(t, err, "unable to update peer1")
|
||||
_, err = am.UpdatePeer(account.Id, groupAdminUserID, peer2)
|
||||
require.NoError(t, err, "unable to update peer2")
|
||||
account, err = am.Store.GetAccount(account.Id)
|
||||
require.NoError(t, err, "unable to fetch updated account")
|
||||
group = account.GetGroup("grp-for-ipv6")
|
||||
require.Nil(t, account.GetPeer(peer1Id).IP6, "peer1 should not have an IPv6 address as it is force disabled.")
|
||||
require.Nil(t, account.GetPeer(peer2Id).IP6, "peer2 should not have an IPv6 address as it is force disabled.")
|
||||
|
||||
// Delete Group.
|
||||
err = am.DeleteGroup(account.Id, groupAdminUserID, group.ID)
|
||||
require.NoError(t, err, "unable to delete group")
|
||||
account, err = am.Store.GetAccount(account.Id)
|
||||
require.NoError(t, err, "unable to update account")
|
||||
group = account.GetGroup("grp-for-ipv6")
|
||||
require.Nil(t, group, "Group should no longer exist.")
|
||||
require.Nil(t, account.Peers[peer1Id].IP6, "peer1 should not have an IPv6 address as the only IPv6-enabled group was deleted.")
|
||||
require.Nil(t, account.Peers[peer2Id].IP6, "peer2 should not have an IPv6 address as the only IPv6-enabled group was deleted.")
|
||||
}
|
||||
|
||||
func initTestGroupAccount(am *DefaultAccountManager) ([]string, *Account, error) {
|
||||
accountID := "testingAcc"
|
||||
domain := "example.com"
|
||||
|
||||
peer1 := &nbpeer.Peer{
|
||||
Key: peer1Key,
|
||||
Name: "peer1",
|
||||
Meta: nbpeer.PeerSystemMeta{
|
||||
Hostname: "test-host1@netbird.io",
|
||||
GoOS: "linux",
|
||||
Kernel: "Linux",
|
||||
Core: "21.04",
|
||||
Platform: "x86_64",
|
||||
OS: "Ubuntu",
|
||||
WtVersion: "development",
|
||||
UIVersion: "development",
|
||||
Ipv6Supported: true,
|
||||
},
|
||||
V6Setting: nbpeer.V6Auto,
|
||||
DNSLabel: groupPeer1Key,
|
||||
}
|
||||
peer2 := &nbpeer.Peer{
|
||||
Key: peer2Key,
|
||||
Name: "peer2",
|
||||
Meta: nbpeer.PeerSystemMeta{
|
||||
Hostname: "test-host2@netbird.io",
|
||||
GoOS: "linux",
|
||||
Kernel: "Linux",
|
||||
Core: "21.04",
|
||||
Platform: "x86_64",
|
||||
OS: "Ubuntu",
|
||||
WtVersion: "development",
|
||||
UIVersion: "development",
|
||||
Ipv6Supported: true,
|
||||
},
|
||||
V6Setting: nbpeer.V6Auto,
|
||||
DNSLabel: groupPeer2Key,
|
||||
}
|
||||
|
||||
groupForRoute := &nbgroup.Group{
|
||||
ID: "grp-for-route",
|
||||
AccountID: "account-id",
|
||||
@@ -191,6 +322,14 @@ func initTestGroupAccount(am *DefaultAccountManager) (*Account, error) {
|
||||
Peers: make([]string, 0),
|
||||
}
|
||||
|
||||
groupForIPv6 := &nbgroup.Group{
|
||||
ID: "grp-for-ipv6",
|
||||
AccountID: "account-id",
|
||||
Name: "Group for IPv6",
|
||||
Issued: nbgroup.GroupIssuedAPI,
|
||||
Peers: make([]string, 0),
|
||||
}
|
||||
|
||||
routeResource := &route.Route{
|
||||
ID: "example route",
|
||||
Groups: []string{groupForRoute.ID},
|
||||
@@ -235,7 +374,7 @@ func initTestGroupAccount(am *DefaultAccountManager) (*Account, error) {
|
||||
|
||||
err := am.Store.SaveAccount(account)
|
||||
if err != nil {
|
||||
return nil, err
|
||||
return nil, nil, err
|
||||
}
|
||||
|
||||
_ = am.SaveGroup(accountID, groupAdminUserID, groupForRoute)
|
||||
@@ -245,6 +384,11 @@ func initTestGroupAccount(am *DefaultAccountManager) (*Account, error) {
|
||||
_ = am.SaveGroup(accountID, groupAdminUserID, groupForSetupKeys)
|
||||
_ = am.SaveGroup(accountID, groupAdminUserID, groupForUsers)
|
||||
_ = am.SaveGroup(accountID, groupAdminUserID, groupForIntegration)
|
||||
_ = am.SaveGroup(accountID, groupAdminUserID, groupForIPv6)
|
||||
peer1, _, _ = am.AddPeer(setupKey.Key, user.Id, peer1)
|
||||
peer2, _, _ = am.AddPeer(setupKey.Key, user.Id, peer2)
|
||||
|
||||
return am.Store.GetAccount(account.Id)
|
||||
account, err = am.Store.GetAccount(account.Id)
|
||||
|
||||
return []string{peer1.ID, peer2.ID}, account, err
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user