sendnrw/netbird
2
0
Fork 0
mirror of https://github.com/netbirdio/netbird.git synced 2026-09-15 03:09:06 +02:00
Code Issues Packages Projects Releases Wiki Activity

Describe the approval no-match result and the cursor-skip key as they behave

Browse Source
This commit is contained in:
Viktor Liu
2026-08-30 05:56:59 +02:00
parent 8389211aa2
commit 89aafa16eb
3 changed files with 19 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
client/proto/daemon.pb.go
+5 -4
View File
@@ -7271,10 +7271,11 @@ func (x *RespondApprovalRequest) GetViewOnly() bool {
type RespondApprovalResponse struct {
state protoimpl.MessageState `protogen:"open.v1"`
// matched is true when request_id named a prompt that was still waiting.
// False covers three cases and does not distinguish them: request_id was
// never known, the prompt had already been answered, or it had expired and
// the connection was denied. In all three this call changed nothing, so the
// UI must not report the outcome the user picked as having taken effect.
// False means it was not, for any reason and without saying which: never
// known, already answered, expired, or abandoned because the prompt never
// reached a UI or the daemon shut the request down. What they share is that
// this call changed nothing, so the UI must not report the outcome the user
// picked as having taken effect.
Matched bool `protobuf:"varint,1,opt,name=matched,proto3" json:"matched,omitempty"`
unknownFields protoimpl.UnknownFields
sizeCache protoimpl.SizeCache
client/proto/daemon.proto
+5 -4
View File
@@ -1127,9 +1127,10 @@ message RespondApprovalRequest {
message RespondApprovalResponse {
// matched is true when request_id named a prompt that was still waiting.
// False covers three cases and does not distinguish them: request_id was
// never known, the prompt had already been answered, or it had expired and
// the connection was denied. In all three this call changed nothing, so the
// UI must not report the outcome the user picked as having taken effect.
// False means it was not, for any reason and without saying which: never
// known, already answered, expired, or abandoned because the prompt never
// reached a UI or the daemon shut the request down. What they share is that
// this call changed nothing, so the UI must not report the outcome the user
// picked as having taken effect.
bool matched = 1;
}