sendnrw/netbird
2
0
Fork 0
mirror of https://github.com/netbirdio/netbird.git synced 2026-04-16 07:16:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

Allow empty groups for DNS setting (#656)

Browse Source 
We should allow passing empty group slice for DisabledManagementGroups to reset any setting.


Fix DNS settings activities message
This commit is contained in:
Maycon Santos
2023-01-18 14:01:50 +01:00
committed by GitHub
parent dcf6533ed5
commit 793e4f1f29
2 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
management/server/dns.go
View File

@@ -87,9 +87,11 @@ func (am *DefaultAccountManager) SaveDNSSettings(accountID string, userID string
return status.Errorf(status.InvalidArgument, "the dns settings provided are nil")
}
err = validateGroups(dnsSettingsToSave.DisabledManagementGroups, account.Groups)
if err != nil {
return err
if len(dnsSettingsToSave.DisabledManagementGroups) != 0 {
err = validateGroups(dnsSettingsToSave.DisabledManagementGroups, account.Groups)
if err != nil {
return err
}
}
oldSettings := &DNSSettings{}