sendnrw/netbird
2
0
Fork 0
mirror of https://github.com/netbirdio/netbird.git synced 2026-04-19 00:36:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

added new 'handleOfferAnswer' method to engine.go to clean up offer answer logic and satisfy SonarQube analysis (case clause with > 6 lines)

Browse Source
This commit is contained in:
Ashley Mensah
2025-11-05 17:20:22 +01:00
parent 8aa1b23a22
commit 74eebeb95a
1 changed files with 15 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
client/internal/engine.go
View File

@@ -1442,16 +1442,9 @@ func (e *Engine) receiveSignalEvents() {
switch msg.GetBody().Type { switch msg.GetBody().Type {
case sProto.Body_OFFER, sProto.Body_ANSWER: case sProto.Body_OFFER, sProto.Body_ANSWER:
offerAnswer, err := convertToOfferAnswer(msg) if err := e.handleOfferAnswer(msg, conn); err != nil {
if err != nil {
return err return err
} }
if msg.Body.Type == sProto.Body_OFFER {
conn.OnRemoteOffer(*offerAnswer)
} else {
conn.OnRemoteAnswer(*offerAnswer)
}
case sProto.Body_CANDIDATE: case sProto.Body_CANDIDATE:
candidate, err := ice.UnmarshalCandidate(msg.GetBody().Payload) candidate, err := ice.UnmarshalCandidate(msg.GetBody().Payload)
if err != nil { if err != nil {
@@ -1479,6 +1472,20 @@ func (e *Engine) receiveSignalEvents() {
e.signal.WaitStreamConnected() e.signal.WaitStreamConnected()
} }
func (e *Engine) handleOfferAnswer(msg *sProto.Message, conn *peer.Conn) error {
offerAnswer, err := convertToOfferAnswer(msg)
if err != nil {
return err
}
if msg.Body.Type == sProto.Body_OFFER {
conn.OnRemoteOffer(*offerAnswer)
} else {
conn.OnRemoteAnswer(*offerAnswer)
}
return nil
}
func (e *Engine) parseNATExternalIPMappings() []string { func (e *Engine) parseNATExternalIPMappings() []string {
var mappedIPs []string var mappedIPs []string
var ignoredIFaces = make(map[string]interface{}) var ignoredIFaces = make(map[string]interface{})