From 70209170259fd95bc0517b00dc2be0933f11f7a4 Mon Sep 17 00:00:00 2001 From: Brad Ison Date: Mon, 3 Aug 2026 23:33:36 +0200 Subject: [PATCH] chore(agentnetwork): state why TargetId stays pinned to the shared cluster The test comment referred to an out-of-scope note in another file. Say the reason inline instead: TargetId identifies the placeholder target the router rewrites per request, so only the advertised proxy address follows ServingProxy(). --- management/internals/modules/agentnetwork/synthesizer_test.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/management/internals/modules/agentnetwork/synthesizer_test.go b/management/internals/modules/agentnetwork/synthesizer_test.go index 8a3a65d30..3fe436753 100644 --- a/management/internals/modules/agentnetwork/synthesizer_test.go +++ b/management/internals/modules/agentnetwork/synthesizer_test.go @@ -1251,7 +1251,8 @@ func TestSynthesizeServices_EmptyAPIKey_FailsClosed(t *testing.T) { // point of the column: the synthesized service must advertise the private // proxy's address, because that value is what mesh-DNS peer selection and the // connect-snapshot filter both join on. TargetId must NOT move with it — it -// names the noop placeholder target and is out of scope (see the note above). +// identifies the placeholder target the router rewrites per request, and only +// the advertised proxy address follows ServingProxy(). func TestBuildAccountService_ProxyClusterFollowsServingProxyAddress(t *testing.T) { ctx := context.Background() ctrl := gomock.NewController(t)