sendnrw/netbird
2
0
Fork 0
mirror of https://github.com/netbirdio/netbird.git synced 2026-10-30 16:29:09 +01:00
Code Issues Packages Projects Releases Wiki Activity

Reject an unsupported VNC session id and say why a cursor rect was skipped

Browse Source
This commit is contained in:
Viktor Liu
2026-08-29 16:09:47 +02:00
parent d0d8813dcb
commit 5f739ef0ac
3 changed files with 39 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
client/vnc/server/agent_ipc.go
+11
View File
@@ -58,6 +58,17 @@ func (s *Server) handleServiceConnection(conn net.Conn, sa sessionAgent) {
return
}
// Service mode always attaches to the agent manager's active session.
// Honouring a requested session ID would mean routing to a specific
// desktop, which is not implemented; accepting the field anyway would
// silently hand the caller a different desktop from the one it asked for.
if header.sessionID != 0 {
rejectConnection(conn, codeMessage(RejectCodeBadRequest,
fmt.Sprintf("targeting session %d is not supported; omit the session id to attach to the active session", header.sessionID)))
connLog.Infof("VNC connection rejected: requested session %d, only the active session is supported", header.sessionID)
return
}
authedLog, sessionUserID, ok := s.authorizeSession(conn, header, connLog)
if !ok {
authedLog.Info("VNC connection rejected: auth failed")