sendnrw/netbird
2
0
Fork 0
mirror of https://github.com/netbirdio/netbird.git synced 2026-10-09 23:19:11 +02:00
Code Issues Packages Projects Releases Wiki Activity

Address review findings on the VNC server, session auth and capture decoder

Browse Source
This commit is contained in:
Viktor Liu
2026-08-27 18:33:52 +02:00
parent 09e069a175
commit 47d8f912e5
18 changed files with 179 additions and 72 deletions
Download Patch File Download Diff File Expand all files Collapse all files
client/vnc/server/agent_windows.go
+5 -6
View File
@@ -800,17 +800,16 @@ func relogAgentOutput(pipe windows.Handle) {
// each call site, while still capturing diagnostic info when the OS reports
// a failure.
func logCleanupCall(name string, proc *windows.LazyProc) {
r, _, err := proc.Call()
if r == 0 && err != nil && err != windows.NTE_OP_OK {
log.Tracef("%s: %v", name, err)
}
logCleanupCallArgs(name, proc)
}
// logCleanupCallArgs is logCleanupCall with one argument; common pattern for
// logCleanupCallArgs is logCleanupCall with arguments; common pattern for
// release-by-handle syscalls.
func logCleanupCallArgs(name string, proc *windows.LazyProc, args ...uintptr) {
r, _, err := proc.Call(args...)
if r == 0 && err != nil && err != windows.NTE_OP_OK {
// LazyProc.Call always returns a non-nil error carrying the thread's last
// error code, so a zero code is what "the call did not fail" looks like.
if r == 0 && !errors.Is(err, windows.ERROR_SUCCESS) {
log.Tracef("%s: %v", name, err)
}
}