From 46494bd8604b9fe5f7617b4f26c7a0837f4f69a7 Mon Sep 17 00:00:00 2001 From: pascal Date: Thu, 7 May 2026 16:08:45 +0200 Subject: [PATCH] bugfixes --- .../controllers/network_map/controller/controller.go | 2 +- management/server/networks/routers/manager.go | 5 ++++- management/server/posture_checks.go | 2 ++ 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/management/internals/controllers/network_map/controller/controller.go b/management/internals/controllers/network_map/controller/controller.go index 150c59d4b..8ba7c3a49 100644 --- a/management/internals/controllers/network_map/controller/controller.go +++ b/management/internals/controllers/network_map/controller/controller.go @@ -204,7 +204,7 @@ func (c *Controller) sendUpdateAccountPeers(ctx context.Context, accountID strin c.metrics.CountCalcPeerNetworkMapDuration(time.Since(start)) - proxyNetworkMap, ok := proxyNetworkMaps[peer.ID] + proxyNetworkMap, ok := proxyNetworkMaps[p.ID] if ok { remotePeerNetworkMap.Merge(proxyNetworkMap) } diff --git a/management/server/networks/routers/manager.go b/management/server/networks/routers/manager.go index 7ee9dc281..6b33f558e 100644 --- a/management/server/networks/routers/manager.go +++ b/management/server/networks/routers/manager.go @@ -177,7 +177,10 @@ func (m *managerImpl) UpdateRouter(ctx context.Context, userID string, router *t } allPeerGroups := router.PeerGroups - directPeers := []string{router.Peer} + var directPeers []string + if router.Peer != "" { + directPeers = append(directPeers, router.Peer) + } oldRouter, err := transaction.GetNetworkRouterByID(ctx, store.LockingStrengthNone, router.AccountID, router.ID) if err == nil { allPeerGroups = append(allPeerGroups, oldRouter.PeerGroups...) diff --git a/management/server/posture_checks.go b/management/server/posture_checks.go index cc6abc943..f22bc8d14 100644 --- a/management/server/posture_checks.go +++ b/management/server/posture_checks.go @@ -5,6 +5,7 @@ import ( "slices" "github.com/rs/xid" + log "github.com/sirupsen/logrus" "github.com/netbirdio/netbird/management/server/activity" "github.com/netbirdio/netbird/management/server/permissions/modules" @@ -134,6 +135,7 @@ func (am *DefaultAccountManager) ListPostureChecks(ctx context.Context, accountI func collectPostureCheckAffectedGroupsAndPeers(ctx context.Context, transaction store.Store, accountID, postureCheckID string) (groupIDs []string, directPeerIDs []string) { policies, err := transaction.GetAccountPolicies(ctx, store.LockingStrengthNone, accountID) if err != nil { + log.WithContext(ctx).Errorf("failed to get policies for posture check affected peers resolution: %v", err) return nil, nil }