From 43254950a449d1a4d829d7c3072ec05443b5a61d Mon Sep 17 00:00:00 2001 From: jnfrati Date: Wed, 15 Apr 2026 11:57:58 +0200 Subject: [PATCH] remove unused config and rename totp issuer --- idp/dex/config.go | 11 +---------- management/server/idp/embedded.go | 2 +- 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/idp/dex/config.go b/idp/dex/config.go index c2fcdc8ce..988c6a8c6 100644 --- a/idp/dex/config.go +++ b/idp/dex/config.go @@ -112,16 +112,6 @@ type WebAuthnConfig struct { // "indirect" — authenticator may anonymize attestation (default) // "direct" — request full attestation (for enterprise key model verification) AttestationPreference string `yaml:"attestationPreference" json:"attestationPreference"` - // UserVerification controls whether PIN or biometric verification is required: - // "required" — always require (PIN, fingerprint, etc.) - // "preferred" — request if the authenticator supports it (default) - // "discouraged" — skip verification, presence check only - UserVerification string `yaml:"userVerification" json:"userVerification"` - // AuthenticatorAttachment restricts which authenticator types are allowed: - // "platform" — built-in only (Touch ID, Windows Hello) - // "cross-platform" — external only (YubiKey, USB security keys) - // "" — any authenticator (default) - AuthenticatorAttachment string `yaml:"authenticatorAttachment" json:"authenticatorAttachment"` // Timeout is the duration allowed for the browser WebAuthn ceremony // (registration or login). Defaults to "60s". Timeout string `yaml:"timeout" json:"timeout"` @@ -518,6 +508,7 @@ func buildWebAuthnConfig(auth MFAAuthenticator, issuerURL string) (*server.WebAu if err := json.Unmarshal(auth.Config, &cfg); err != nil { return nil, fmt.Errorf("failed to parse WebAuthn config id: %s - %w", auth.ID, err) } + provider, err := server.NewWebAuthnProvider(cfg.RPDisplayName, cfg.RPID, cfg.RPOrigins, cfg.AttestationPreference, cfg.Timeout, issuerURL, auth.ConnectorTypes) if err != nil { diff --git a/management/server/idp/embedded.go b/management/server/idp/embedded.go index 8ec0058ce..3d6f5c7ca 100644 --- a/management/server/idp/embedded.go +++ b/management/server/idp/embedded.go @@ -203,7 +203,7 @@ func (c *EmbeddedIdPConfig) ToYAMLConfig() (*dex.YAMLConfig, error) { func configureMFA(cfg *dex.YAMLConfig) error { totpConfig := dex.TOTPConfig{ - Issuer: "Netbird", + Issuer: "NetBird", } rawTotpConfig, err := json.Marshal(totpConfig)