From 3d6fc3bf9248b86303ed8295c71684c1d9c51c70 Mon Sep 17 00:00:00 2001 From: Dmitri Dolguikh Date: Tue, 16 Jun 2026 16:20:10 +0200 Subject: [PATCH] added a comment re: unbounded unacked events Signed-off-by: Dmitri Dolguikh --- client/internal/netflow/manager.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/client/internal/netflow/manager.go b/client/internal/netflow/manager.go index b26455141..fa66fcf32 100644 --- a/client/internal/netflow/manager.go +++ b/client/internal/netflow/manager.go @@ -248,6 +248,8 @@ func (m *Manager) receiveACKs(ctx context.Context, client *client.GRPCClient) { } } +// We effectively never drop events (see MaxInterval), which makes eventsWithoutAcks unbounded. +// We may want to limit the max size of the store, and start dropping oldest events when the threshold is reached. func (m *Manager) startRetries(ctx context.Context) { timer := time.NewTimer(m.retryInterval) retryBackoff := backoff.WithContext(&backoff.ExponentialBackOff{